* BALATON Zoltan (bala...@eik.bme.hu) wrote:
> On Sun, 5 May 2024, BALATON Zoltan wrote:
> > On Sun, 5 May 2024, Dr. David Alan Gilbert wrote:
> > > I think it's use was removed by
> > > Commit 5883d8b296 ("mmu-hash*: Don't use full ppc_hash{32,
> > > 64}
* Richard Henderson (richard.hender...@linaro.org) wrote:
> On 5/5/24 10:14, Dr. David Alan Gilbert wrote:
> > The structs 'target_fpxreg' and 'target_xmmreg' are unused since
> > Paolo's:
> >
> > Commit 2796f290b546 ("linux-user: i386/signal: support FXSAVE
This struct is unused since Peter's
Commit b8ae597f0e6d ("linux-user/sparc: Fix errors in target_ucontext
structures")
However, hmm, I'm a bit confused since that commit modifies the
structure and then removes it, was that intentional?
Signed-off-by: Dr. David Alan Gilbert
---
linux-
The structs 'target_fpxreg' and 'target_xmmreg' are unused since
Paolo's:
Commit 2796f290b546 ("linux-user: i386/signal: support FXSAVE fpstate on
32-bit emulation")
Signed-off-by: Dr. David Alan Gilbert
---
linux-user/i386/signal.c | 10 --
1 file changed, 10 deletions(-)
Since 'setup_rt_frame' has never been implemented, this struct
is unused.
Signed-off-by: Dr. David Alan Gilbert
---
linux-user/cris/signal.c | 8
1 file changed, 8 deletions(-)
diff --git a/linux-user/cris/signal.c b/linux-user/cris/signal.c
index 4f532b2903..10948bcf30 100644
-softmmu,aarch64-softmmu,cris-linux-user,i386-linux-user,sparc-linux-user
and 'make check' on x86 linux.
Dave
Dr. David Alan Gilbert (7):
linux-user: cris: Remove unused struct 'rt_signal_frame'
linux-user: i386/signal: Remove unused fp structs
linux-user: sparc: Remove unused struct
As far as I can tell this struct has never been used in this
file (it is used in can_core.c).
Signed-off-by: Dr. David Alan Gilbert
---
net/can/can_host.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/net/can/can_host.c b/net/can/can_host.c
index a3c84028c6..b2fe553f91 100644
This struct has been unused since
Commit f932093ae165 ("hw/arm/bcm2836: Split out common part of BCM283X
classes")
Signed-off-by: Dr. David Alan Gilbert
---
hw/arm/bcm2836.c | 12
1 file changed, 12 deletions(-)
diff --git a/hw/arm/bcm2836.c b/hw/arm/bcm2836.c
index
I think it's use was removed by
Commit 5883d8b296 ("mmu-hash*: Don't use full ppc_hash{32,
64}_translate() path for get_phys_page_debug()")
Signed-off-by: Dr. David Alan Gilbert
---
target/ppc/mmu-hash32.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/target/ppc/mmu-hash32.
As far as I can tell it was never used.
Signed-off-by: Dr. David Alan Gilbert
---
hw/usb/dev-network.c | 8
1 file changed, 8 deletions(-)
diff --git a/hw/usb/dev-network.c b/hw/usb/dev-network.c
index 2c33e36cad..d00d68b21d 100644
--- a/hw/usb/dev-network.c
+++ b/hw/usb/dev-network.c
rate [-d]`` *uri*
> >Migrate to *uri* (using -d to not wait for completion).
> > -
> > - ``-b``
> > -for migration with full copy of disk
> > ERST
>
> Not this patch's fault, but here goes anyway: -r is undocumented here.
Probably one for Peter I guess.
Dave
> >
> > {
>
> [...]
>
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Alan Gilbert| Running GNU/Linux | Happy \
\dave @ treblig.org | | In Hex /
\ _|_ http://www.treblig.org |___/
sons. And for the
> human monitor (HMP) we don't need to keep things around
> for backwards compatibility.
I'm not sure what happens for the (MIPS/SPARC ?) where it's not
a traditional table hierarchy.
The other thing you might want (and I'm not sure how it interacts
with any of this) i
memory_mapping
>
> * tcg/sysemu/excp_helper.c: implements mmu_translate() and
> get_physical_address()
One thing to keep in mind (although I don't know the x86 code) is that
you want the monitor command not to change any state, nor to fail if
there's a particularly screwy page ta
* BALATON Zoltan (bala...@eik.bme.hu) wrote:
> On Sun, 24 Mar 2024, Dr. David Alan Gilbert wrote:
> > * Philippe Mathieu-Daudé (phi...@linaro.org) wrote:
> > > Replace qemu_printf() by monitor_printf() / monitor_puts() in monitor.
> > >
> > > S
monitor_puts(mon, "S"); /* Supervisor */
> } else {
> -qemu_printf(".");
> +monitor_puts(mon, ".");
> }
> if (env->mmu.mmusr & M68K_MMU_M_040) {
> - qemu_printf("
" HWADDR_PRIx "is not RAM",
> > addr);
> > +error_setg(errp, "Memory at address 0x%" HWADDR_PRIx " is not
> > RAM", addr);
> > memory_region_unref(mrs.mr);
> > return NULL;
> > }
>
> Fi
ecate them we need to be
> > > pretty sure that "info mmu" is what we want to replace them with.
> >
> > An alternative is to just deprecate them, without adding "info mmu" :)
> >
> > It is OK to un-deprecate stuff if we realize its usefulness.
&
stick to one or the other as variable names); still:
Reviewed-by: Dr. David Alan Gilbert
> ---
> hmp-commands-info.hx | 6 +++---
> system/qdev-monitor.c | 24 +---
> 2 files changed, 16 insertions(+), 14 deletions(-)
>
> diff --git a/hmp-commands-info.hx
;,
> -.params = "[on|off]",
> -.help = "deprecated synonym for one-insn-per-tb",
> - .cmd= hmp_one_insn_per_tb,
> -},
> -
> -SRST
> -``singlestep [off]``
> - This is a deprecated synonym for the one-insn-per-tb command.
* Markus Armbruster (arm...@redhat.com) wrote:
> Improve
>
> (qemu) sync-profile of
> Error: Invalid parameter 'of'
>
> to
>
> Error: invalid parameter 'of', expecting 'on', 'off', or 'reset'
>
> Signed-off-by: Markus Armbruster
Revie
p starting at *addr*. See xp/ for physical and x/ for
> virtual memory
>
> + *fmt* is a format which tells the command how to format the
> + data. Its syntax is: ``/{count}{format}{size}``
> +ERST
> {
> .name = "gpa2hva",
> .args_type = "addr:l",
> --
> 2.39.2
>
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Alan Gilbert| Running GNU/Linux | Happy \
\dave @ treblig.org | | In Hex /
\ _|_ http://www.treblig.org |___/
and in both
> cases it is pretty relevant to make unstable features stand out to
> the human via the x- prefix IMHO.
Using x- for events makes sense to me; the semantics of events can be
quite subtle; often you don't find out how broken they are until you
wire them through libvir
* Stefan Hajnoczi (stefa...@gmail.com) wrote:
> On Thu, 7 Sept 2023 at 10:07, Dr. David Alan Gilbert wrote:
> >
> > * Stefan Hajnoczi (stefa...@redhat.com) wrote:
> > > On Thu, Sep 07, 2023 at 01:06:39AM +, Dr. David Alan Gilbert wrote:
> > > > * Stefan
* Stefan Hajnoczi (stefa...@redhat.com) wrote:
> On Thu, Sep 07, 2023 at 01:06:39AM +0000, Dr. David Alan Gilbert wrote:
> > * Stefan Hajnoczi (stefa...@redhat.com) wrote:
> > > Coroutine HMP commands currently run to completion in a nested event
> > > loop with t
/* resumed by handle_hmp_command_co()
> */
> monitor_set_cur(co, >common);
> aio_co_enter(qemu_get_aio_context(), co);
> -AIO_WAIT_WHILE_UNLOCKED(NULL, !data.done);
> }
> -
> -qobject_unref(qdict);
> }
>
> static void cmd_
or even currently not mapped to any guest
> physical address at all. And it could be present at different physical
> addresses for different vCPUs.
True, but isn't there a similar mechanism for when an MCE happens
in the host memory?
Dave
> thanks
> -- PMM
--
-Open up your ey
* T.J. Alumbaugh (talum...@google.com) wrote:
> On Tue, May 16, 2023 at 5:03 AM Dr. David Alan Gilbert
> wrote:
> >
> > * T.J. Alumbaugh (talum...@google.com) wrote:
> > > Working Set Reporting supported in virtio-balloon.
> > > - adds working se
es. File-backed and
> +# anonymous memory are tracked separately.
> +#
> +# @anon: number of bytes of anonymous memory
> +# @file: number of bytes of file-backed memory
> +##
> +{ 'struct': 'MemoryBin',
> + 'data': { 'anon': 'uint64',
> +'file': 'uint64' } }
> +
> +##
> +# @WorkingSetInfo:
> +#
> +# A bin of memory of the given size that has been idle at most `idle-age` ms
> +#
> +# @idle-age: guest-relative time (in milliseconds)
> +#
> +# @memory-size-bytes: A MemoryBin with file and anon info.
> +##
> +{ 'struct': 'WorkingSetInfo',
> + 'data': { 'idle-age': 'uint64',
> +'memory-size-bytes': 'MemoryBin' } }
> +
> ##
> # @query-command-line-options:
> #
> diff --git a/softmmu/balloon.c b/softmmu/balloon.c
> index e0e8969a4b..8ff30fe43b 100644
> --- a/softmmu/balloon.c
> +++ b/softmmu/balloon.c
> @@ -35,6 +35,8 @@
>
> static QEMUBalloonEvent *balloon_event_fn;
> static QEMUBalloonStatus *balloon_stat_fn;
> +static QEMUBalloonWSRequest *balloon_ws_request_fn;
> +static QEMUBalloonWSConfig *balloon_ws_config_fn;
> static void *balloon_opaque;
>
> static bool have_balloon(Error **errp)
> @@ -53,9 +55,12 @@ static bool have_balloon(Error **errp)
> }
>
> int qemu_add_balloon_handler(QEMUBalloonEvent *event_func,
> - QEMUBalloonStatus *stat_func, void *opaque)
> + QEMUBalloonStatus *stat_func,
> + QEMUBalloonWSRequest *ws_request_func,
> + QEMUBalloonWSConfig *ws_config_func, void
> *opaque)
> {
> -if (balloon_event_fn || balloon_stat_fn || balloon_opaque) {
> +if (balloon_event_fn || balloon_stat_fn || balloon_ws_request_fn \
> +|| balloon_ws_config_fn || balloon_opaque) {
> /* We're already registered one balloon handler. How many can
> * a guest really have?
> */
> @@ -63,6 +68,8 @@ int qemu_add_balloon_handler(QEMUBalloonEvent *event_func,
> }
> balloon_event_fn = event_func;
> balloon_stat_fn = stat_func;
> +balloon_ws_request_fn = ws_request_func;
> +balloon_ws_config_fn = ws_config_func;
> balloon_opaque = opaque;
> return 0;
> }
> @@ -74,6 +81,8 @@ void qemu_remove_balloon_handler(void *opaque)
> }
> balloon_event_fn = NULL;
> balloon_stat_fn = NULL;
> +balloon_ws_request_fn = NULL;
> +balloon_ws_config_fn = NULL;
> balloon_opaque = NULL;
> }
>
> @@ -104,3 +113,22 @@ void qmp_balloon(int64_t target, Error **errp)
> trace_balloon_event(balloon_opaque, target);
> balloon_event_fn(balloon_opaque, target);
> }
> +
> +void qmp_ws_request(Error **errp)
> +{
> +if (!have_balloon(errp)) {
> +return;
> +}
> +
> +balloon_ws_request_fn(balloon_opaque);
> +}
> +
> +void qmp_ws_config(uint64_t i0, uint64_t i1, uint64_t i2, uint64_t refresh,
> + uint64_t report, Error **errp)
> +{
> +if (!have_balloon(errp)) {
> +return;
> +}
> +
> +balloon_ws_config_fn(balloon_opaque, i0, i1, i2, refresh, report);
> +}
> --
> 2.40.1.521.gf1e218fcd8-goog
>
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Alan Gilbert| Running GNU/Linux | Happy \
\dave @ treblig.org | | In Hex /
\ _|_ http://www.treblig.org |___/
ef includes the
SRST/ERST doc section; some ifdef do and some don't; and thus
it depends whether or not you want the command documented
even though it's compiled out.
I think it's probably OK, but maybe worth reconsidering:
Acked-by: Dr. David Alan Gilbert
> SRST
> ``x_colo_lost_heartbeat
* Peter Maydell (peter.mayd...@linaro.org) wrote:
> On Wed, 5 Apr 2023 at 15:56, Dr. David Alan Gilbert
> wrote:
> >
> > * Peter Maydell (peter.mayd...@linaro.org) wrote:
> > > I think on balance I would go for:
> > > * remove (ie deprecate-and-dr
tb', for consistency
>(then 'info status' matches the QMP query-status)
If it's pretty obscure, then the qom-set/get is fine; as long
as there is a way to do it, then just make sure in the commit
message you say what the replacement command is.
Dave
> In particular, the fact that messing with this obscure debug
> functionality requires updating the reference-output for a
> bunch of io tests that have no interest at all in it rather
> suggests that even if we did want to expose this to QMP that
> the query-status command is the wrong place to do it.
>
> thanks
> -- PMM
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
ULL, NULL, opaque);
> > +aio_set_fd_handler(ctx, rioc->rdmaout->recv_comp_channel->fd,
> > io_read,
> > + io_write, NULL, NULL, opaque);
> > +aio_set_fd_handler(ctx, rioc->rdmaout->send_comp_channel->fd,
> >
tests/qtest/test-hmp.c
> @@ -64,6 +64,7 @@ static const char *hmp_cmds[] = {
> "screendump /dev/null",
> "sendkey x",
> "singlestep on",
> +"one-insn-per-tb on",
OK, it wouldn't be bad if this list got a bit back into near alph
lemented someday, we'll
> > need some other flag/cap for it.
>
> As I've mentioned a few times, I think we need to throw away the idea
> of exposing capabilities that mgmt apps need to learn about, and make
> the migration protocol fully bi-directional so src + dst QEMU can
> directly negotiate features. Apps shouldn't have to care about the
> day-to-day improvements in the migration impl to the extent that they
> are today.
>
> With regards,
> Daniel
> --
> |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org -o-https://fstop138.berrange.com :|
> |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote:
> From: "Dr. David Alan Gilbert"
>
> I'm leaving Red Hat next week, so clean up the maintainer entries.
>
> 'virtiofs' is just the device code now, so is pretty small, and
> Stefan is still a maintainer t
From: "Dr. David Alan Gilbert"
I'm leaving Red Hat next week, so clean up the maintainer entries.
'virtiofs' is just the device code now, so is pretty small, and
Stefan is still a maintainer there.
'migration' still has Juan.
For 'HMP' I'll swing that over to my personal email.
enario, and now it should be
> working on most cases.
>
> But since there is not enough testing/support nor any reported users for
> this scenario, we should disable this combination before it may cause any
> problems for users.
>
> Suggested-by: Dr. David Alan Gilbert
> Signed-
* Peter Xu (pet...@redhat.com) wrote:
> On Wed, Mar 22, 2023 at 02:05:06PM +0000, Dr. David Alan Gilbert wrote:
> > * Peter Xu (pet...@redhat.com) wrote:
> > > On Tue, Mar 21, 2023 at 08:24:37PM +0000, Dr. David Alan Gilbert wrote:
> > > > Hi Peter's,
> &g
* Peter Xu (pet...@redhat.com) wrote:
> On Tue, Mar 21, 2023 at 08:24:37PM +0000, Dr. David Alan Gilbert wrote:
> > Hi Peter's,
> > Peter M pointed me to a seg in a migration test in CI; I can reproduce
> > it:
> > * On an s390 host
>
> How easy to reproduce?
opy_common (args=0x3ffc247cf48) at
../tests/qtest/migration-test.c:1162
#20 test_postcopy_preempt () at ../tests/qtest/migration-test.c:1178
Looking at the iov and file it's garbage; so it makes me think this is
something like a flush on a closed file.
Dave
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
-2219,9 +2216,6 @@ int audioformat_bytes_per_sample(AudioFormat fmt)
> case AUDIO_FORMAT_S32:
> case AUDIO_FORMAT_F32:
> return 4;
> -
> -case AUDIO_FORMAT__MAX:
> -;
> }
> abort();
> }
> diff --git a/migration/migration.
;
> bool is_same = (comp & 0x1);
> while (bytes_to_check) {
> +if (d + 2 > dlen) {
> +return -1;
> +}
I agree that's better, so:
Reviewed-by: Dr. David Alan Gilbert
but is it sufficient?
In that bytes_to_check loop ther
to ctz(), which is not
> a valid argument
>
> Replace __builtin_ctzll() with our ctz64() wrapper which properly
> handles 0.
>
> Signed-off-by: Matheus Tavares Bernardino
Reviewed-by: Dr. David Alan Gilbert
> ---
> migration/xbzrle.c | 5 +++--
> 1 file changed, 3 ins
* Peter Xu (pet...@redhat.com) wrote:
> On Tue, Mar 14, 2023 at 05:15:58PM +0000, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > The RDMA code has return-path handling code, but it's only enabled
> > if postcopy is en
From: "Dr. David Alan Gilbert"
The RDMA code has return-path handling code, but it's only enabled
if postcopy is enabled; if the 'return-path' migration capability
is enabled, the return path is NOT setup but the core migration
code still tries to use it and breaks.
Enable the RDMA r
LAKY_TESTS=1 in your environment.
>
> Suggested-by: Dr. David Alan Gilbert
> Signed-off-by: Peter Maydell
Reviewed-by: Dr. David Alan Gilbert
> ---
> tests/qtest/migration-test.c | 23 ---
> 1 file changed, 16 insertions(+), 7 deletions(-)
>
> diff --
* Peter Maydell (peter.mayd...@linaro.org) wrote:
> On Tue, 14 Mar 2023 at 10:12, Dr. David Alan Gilbert
> wrote:
> >
> > Copying Peter Xu on this one since it's poscopy, especially the newer
> > postcopy preempt.
> >
> > * Peter Maydell (peter.mayd...@linaro.o
x2aa2b37b538) at pthread_cond_wait.c:508
> #2 __pthread_cond_wait (cond=cond@entry=0x2aa2b37b538,
> mutex=mutex@entry=0x2aa2b37b508) at pthread_cond_wait.c:647
> #3 0x02aa28ac500e in qemu_cond_wait_impl (cond=0x2aa2b37b538,
> mutex=0x2aa2b37b508, file=0x2aa28d70dee "../uti
ot;current migration capabilities");
> return false;
> }
> -migrate_set_block_enabled(true, _err);
> -if (local_err) {
> +if (!migrate_cap_set(MIGRATION_CAPABILITY_BLOCK, true, _err)) {
> error_propagate(errp, local_err);
> return false;
> }
> --
> 2.39.2
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
he top-level directory.
> + *
> + * Contributions after 2012-01-13 are licensed under the terms of the
> + * GNU GPL, version 2 or (at your option) any later version.
I don't think any of these functions were written by Anthony, and I
think they're all after 2012 aren't they? If so we can up
* Steven Sistare (steven.sist...@oracle.com) wrote:
> On 3/7/2023 6:32 AM, Dr. David Alan Gilbert wrote:
> > * Steve Sistare (steven.sist...@oracle.com) wrote:
> >> Include CONFIG_DEVICES so that populate_vfio_info is instantiated for
> >> CONFIG_VFIO. Without it, the '
ot;hw/vfio/vfio-common.h"
> @@ -17,7 +18,6 @@ void populate_vfio_info(MigrationInfo *info)
> {
> #ifdef CONFIG_VFIO
> if (vfio_mig_active()) {
> -info->has_vfio = true;
Why this removal?
Dave
> info->vfio = g_malloc0(sizeof(*info->vfio));
> info->vfio->transferred = vfio_mig_bytes_transferred();
> }
> --
> 1.8.3.1
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
From: "Dr. David Alan Gilbert"
Thomas found an autoconverge test failure where the
migration completed before the autoconverge had kicked in.
To try and avoid this again:
a) Reduce the usleep in test_migrate_auto_converge
so that it should exit quicker when autoconverge kicks in
* Daniel P. Berrangé (berra...@redhat.com) wrote:
> On Mon, Mar 06, 2023 at 01:44:38PM +0000, Dr. David Alan Gilbert wrote:
> > * Thomas Huth (th...@redhat.com) wrote:
> > > On 03/03/2023 13.05, Peter Maydell wrote:
> > > > On Fri, 3 Mar 202
* Daniel P. Berrangé (berra...@redhat.com) wrote:
> On Mon, Mar 06, 2023 at 01:44:38PM +0000, Dr. David Alan Gilbert wrote:
> > * Thomas Huth (th...@redhat.com) wrote:
> > > On 03/03/2023 13.05, Peter Maydell wrote:
> > > > On Fri, 3 Mar 202
> > /home/qemu/qemu-test.fYHKFz/build/tests/qtest/migration-test --tap -k
> ―― ✀
> ―――
> stderr:
> qemu: thread naming not supported on this host
> qemu: thread naming not supported on this host
> qemu: thread naming not supported on this host
> qemu: thread naming not supported on this host
> qemu: thread naming not supported on this host
> qemu: thread naming not supported on this host
> **
> ERROR:../src/tests/qtest/migration-test.c:1841:test_migrate_auto_converge:
> 'got_stop' should be FALSE
>
> (test program exited with status code -6)
>
> Thomas
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
target")
> > +class PPC64(MigrationTest):
> > +"""
> > +:avocado: tags=arch:ppc64
> > +:avocado: tags=machine:pseries
> > +:avocado: tags=cpu:power9_v2.0
> > +"""
> > +
> > + def test_migration_with_tcp_localhost(self):
> > +self.migration_with_tcp_localhost()
> > +
> > +def test_migration_with_unix(self):
> > +self.migration_with_unix()
> > +
> > +def test_migration_with_exec(self):
> > +self.migration_with_exec()
> > +
> > +
> > +@skipUnless('s390x' in os.uname()[4], "host != target")
> > +class S390X(MigrationTest):
> > +"""
> > +:avocado: tags=arch:s390x
> > +:avocado: tags=machine:s390-ccw-virtio
> > +:avocado: tags=cpu:qemu
> > +"""
> > +
> > +def test_migration_with_tcp_localhost(self):
> > +self.migration_with_tcp_localhost()
> > +
> > +def test_migration_with_unix(self):
> > +self.migration_with_unix()
> > +
> > +def test_migration_with_exec(self):
> > +self.migration_with_exec()
> > --
> > 2.35.3
>
> thanks
> -- PMM
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
* Michael Tokarev (m...@tls.msk.ru) wrote:
> 02.03.2023 11:25, Michael S. Tsirkin wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > In bad9c5a516 ("virtio-rng-pci: fix migration compat for vectors") I
> > fixed the virtio-rng-pci migration compat
cp_cancel);
> +/*
> + * This test is flaky and sometimes fails in CI and otherwise:
> + * don't run unless user opts in via environment variable.
> + */
> +if (getenv("QEMU_TEST_FLAKY_TESTS")) {
> +qtest_add_func("/migration/multifd/tcp/plain/cancel",
&
igned-off-by: zhenwei pi
Yes, I think that's fine from HMP; you might want to use some of the
qapi list macros;
Acked-by: Dr. David Alan Gilbert
> ---
> backends/cryptodev-hmp-cmds.c | 54 +++
> backends/meson.build | 1 +
>
igned-off-by: zhenwei pi
Acked-by: Dr. David Alan Gilbert
> ---
> backends/cryptodev-hmp-cmds.c | 54 +++
> backends/meson.build | 1 +
> hmp-commands-info.hx | 14 +
> include/monitor/hmp.h | 1 +
> 4 files chang
hread blocking on the mutex I'm not convinced
> that'll happen either. The FD set is scoped to the current
> monitor. Almost certainly the FD is going to be consumed by
> a later QMP device-add/object-add command, in the same thread.
> Processing of that later QMP command will be delayed regardless
> of whether the close is inside or outside the critical section.
>
> AFAICT keeping close() oujtside the critical section serves
> no purpose and we could just stick with the lock guard and
> delete the comment.
>
> With regards,
> Daniel
> --
> |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org -o-https://fstop138.berrange.com :|
> |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
X_INTEL_PT, prefix);
> }
> }
> +
> +/* Update XSAVE components again based on the filtered CPU feature flags
> */
> +x86_cpu_enable_xsave_components(cpu);
> }
>
> static void x86_cpu_hyperv_realize(X86CPU *cpu)
> --
> 2.27.0
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
* Peter Maydell (peter.mayd...@linaro.org) wrote:
> On Tue, 21 Feb 2023 at 15:21, Dr. David Alan Gilbert
> wrote:
> > Damn this is really going to impact the stability of migration if we
> > don't regularly test.
> > But fundamentally, I've never been able to d
-test',
>'device-introspect-test',
> @@ -343,6 +349,9 @@ foreach dir : target_dirs
>endif
>
>foreach test : target_qtests
> +if test in qtests_disabled
> + continue
> +endif
> # Executables are shared across targets, declare them only the first
> time we
> # encounter them
> if not qtest_executables.has_key(test)
> --
> 2.34.1
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
From: "Dr. David Alan Gilbert"
Remove all the virtiofsd build and docs infrastructure.
Signed-off-by: Dr. David Alan Gilbert
Acked-by: Stefan Hajnoczi
---
MAINTAINERS| 2 --
docs/conf.py | 4
docs/m
From: "Dr. David Alan Gilbert"
Rmove the avocado test for virtiofsd, since we're about to remove
the C implementation.
Signed-off-by: Dr. David Alan Gilbert
Acked-by: Stefan Hajnoczi
---
.../org.centos/stream/8/x86_64/test-avocado | 7 -
tests/avocado/virtiofs_su
From: "Dr. David Alan Gilbert"
Move the deprecation message, since it's now gone.
Signed-off-by: Dr. David Alan Gilbert
Acked-by: Stefan Hajnoczi
---
docs/about/deprecated.rst | 18 --
docs/about/removed-features.rst | 13 +
2 files changed, 13
From: "Dr. David Alan Gilbert"
The following changes since commit 6dffbe36af79e26a4d23f94a9a1c1201de99c261:
Merge tag 'migration-20230215-pull-request' of
https://gitlab.com/juan.quintela/qemu into staging (2023-02-16 13:09:51 +)
are available in the Git repository at
tps://entangle-photo.org -o-https://www.instagram.com/dberrange :|
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
From: "Dr. David Alan Gilbert"
Rmove the avocado test for virtiofsd, since we're about to remove
the C implementation.
Signed-off-by: Dr. David Alan Gilbert
---
.../org.centos/stream/8/x86_64/test-avocado | 7 -
tests/avocado/virtiofs_submounts.py | 217 ---
From: "Dr. David Alan Gilbert"
We deprecated the C virtiofsd in commit 34deee7b6a1418f3d62a
in v7.0 in favour of the Rust implementation at
https://gitlab.com/virtio-fs/virtiofsd
since then, the Rust version has had more development and
has held up well. It's time to say goodby
From: "Dr. David Alan Gilbert"
Remove all the virtiofsd build and docs infrastructure.
Signed-off-by: Dr. David Alan Gilbert
---
MAINTAINERS| 2 --
docs/conf.py | 4
docs/m
From: "Dr. David Alan Gilbert"
Move the deprecation message, since it's now gone.
Signed-off-by: Dr. David Alan Gilbert
---
docs/about/deprecated.rst | 18 --
docs/about/removed-features.rst | 13 +
2 files changed, 13 insertions(+), 18 deletion
stable interface. Changes to members therefore require the usual
> deprecation grace period. We'd add a new member with a sane name, and
> deprecate the old one.
>
> The matching HMP command is "info status". It shows member @singlestep
> as " (single step mode)". Changing that is fine; HMP is not a stable
> interface.
Right, and similarly you don't need to keep the old 'singlestep' command
around; you can just rename.
Dave
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
* Juan Quintela (quint...@redhat.com) wrote:
> I called the helper function from the wrong top level function.
Oops yes; as Peter says, this needs a Fixes: line, bu tother than that.
Reviewed-by: Dr. David Alan Gilbert
> This code was introduced in:
>
* Philippe Mathieu-Daudé (phi...@linaro.org) wrote:
> On 7/2/23 18:49, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > In bad9c5a5166fd5e3a892b7b0477cf2f4bd3a959a I fixed the virito-rng-pci
>
> Typo "virtio-rn
From: "Dr. David Alan Gilbert"
In bad9c5a5166fd5e3a892b7b0477cf2f4bd3a959a I fixed the virito-rng-pci
migration compatibility, but it was discovered that we also need to fix
the other aliases of the device for the transitional cases.
Fixes: 9ea02e8f1 ('virtio-rng-pci: Allow setting nv
* Marc-André Lureau (marcandre.lur...@gmail.com) wrote:
> Hi David
>
> On Fri, Sep 25, 2020 at 4:27 PM Dr. David Alan Gilbert (git)
> wrote:
> >
> > From: "Dr. David Alan Gilbert"
> >
> > Use the lock guard macros in monitor/misc.c - saves
> >
o
another process, which processes address space are you trying to
monitor?
Dave
> Michal
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
rate minor page faults
> not missing page faults, we need to pre-allocate the files to make sure
> page cache exist start from the beginning.
>
> Signed-off-by: Peter Xu
Reviewed-by: Dr. David Alan Gilbert
> ---
> include/exec/ramblock.h | 7
* Peter Xu (pet...@redhat.com) wrote:
> On Tue, Jan 24, 2023 at 10:06:48AM +0000, Dr. David Alan Gilbert wrote:
> > * Peter Xu (pet...@redhat.com) wrote:
> > > Add a helper to do mmap() for a ramblock based on the cached informations.
> > >
> > > A trivial
n't be migrated.
>
> Signed-off-by: Peter Xu
Reviewed-by: Dr. David Alan Gilbert
> ---
> include/exec/cpu-common.h | 1 -
> migration/migration.c | 2 +-
> migration/ram.c | 12
> migration/ram.h | 1 +
> softmmu/physmem.c
(block->page_size / TARGET_PAGE_SIZE)) {
> +(migration_ram_pagesize(block) / TARGET_PAGE_SIZE)) {
> place_needed = true;
> }
> place_source = tmp_page->tmp_huge_page;
> diff --git a/migration/ram.h b/migration/ram.h
> index 81cbb0947c..162b3e7cb8 100644
> --- a/migration/ram.h
> +++ b/migration/ram.h
> @@ -68,6 +68,7 @@ bool ramblock_is_ignored(RAMBlock *block);
> if (!qemu_ram_is_migratable(block)) {} else
>
> int xbzrle_cache_resize(uint64_t new_size, Error **errp);
> +size_t migration_ram_pagesize(RAMBlock *block);
> uint64_t ram_bytes_remaining(void);
> uint64_t ram_bytes_total(void);
> void mig_throttle_counter_reset(void);
> --
> 2.37.3
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
* Peter Xu (pet...@redhat.com) wrote:
> Add a new cap to allow mapping hugetlbfs backed RAMs in small page sizes.
>
> Signed-off-by: Peter Xu
Reviewed-by: Dr. David Alan Gilbert
although, I'm curious if the protocol actually changes - or whether
a doublepage enabled destination w
Error **errp)
> {
> -uint32_t qemu_map_flags;
> void *area;
>
> /* Remember the offset just in case we'll need to map the range again */
Note that this comment is now wrong; you need to always set that for the
map call.
Other than that,
Reviewed-by: Dr. Da
* Stefan Hajnoczi (stefa...@gmail.com) wrote:
> On Mon, 23 Jan 2023 at 14:54, Stefan Hajnoczi wrote:
> >
> > On Mon, Jan 23, 2023 at 06:27:23PM +0000, Dr. David Alan Gilbert wrote:
> > > * Michael S. Tsirkin (m...@redhat.com) wrote:
> > > > On Sun, Jan 22, 20
ramblock flags.
>
> The main purpose of this patch is not for clean up though, it's for caching
> mapping information of each ramblock so when we want to mmap() it again for
> whatever reason we can have all the information on hand.
>
> Signed-off-by: Peter Xu
Re
ecause
> that's always true for file-backed ramblocks.
Having a length previously called 'memory' was a bit odd!
> Signed-off-by: Peter Xu
Reviewed-by: Dr. David Alan Gilbert
> ---
> include/exec/ramblock.h | 2 ++
> softmmu/physmem.c | 14 +++---
> 2 files chan
on. I think we just assumed there's no use-case where
> > > this is practical for vhost-user-fs so we blocked it.
> > > But in any case it's orchestrator's responsibility.
> >
> > Yes, you are right. So do you think we should just drop the blocker
> > without adding a new flag?
>
> I'd be inclined to. I am curious what do dgilbert and stefanha think though.
Yes I think that's probably OK, as long as we use the flag for knowing
how to handle the discard bitmap as a proxy for the daemon knowing how
to handle *some* migrations; knowing which migrations is then the job
for the orchestrator to be careful of.
Dave
> --
> MST
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
by the state restore.
> > + *
> > + * However, there's a chance that the board will powerup the SD
> > + * before reaching INMIGRATE state in the destination host.
> > + * Powering up the SD again in this case will cause an assert
> > + * inside sd_ocr_powerup(). Skip sd_ocr_powerup() in this case.
> >*/
> > -sd_ocr_powerup(sd);
> > +if (!sd_card_powered_up(sd)) {
> > +sd_ocr_powerup(sd);
> > +}
> > return 0;
> > }
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
ppend(cmd_common, "-accel kvm ");
> +}
> +g_string_append(cmd_common, "-accel tcg ");
Yep, that's the right way around this time :-)
Reviewed-by: Dr. David Alan Gilbert
> bootpath = g_strdup_printf("%s/bootsect", tmpfs);
> if (strcmp(arch, &q
* Philippe Mathieu-Daudé (phi...@linaro.org) wrote:
> Part 1/4: Convert memory & machine options.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Dr. David Alan Gilbert
> ---
> tests/qtest/migration-test.c | 24 ++--
> 1 file changed, 14 inser
DPDK side to handle Vhost-user
> > > > requests, it will read a request, handle it and reply to it. Then it
> > > > reads the next one, etc... So I don't think it is possible to mix
> > > > request replies order on DPDK side.
> > > >
> > > > Maybe there are two threads concurrently sending requests on QEMU side?
> > > >
> > > > Regards,
> > > > Maxime
> > > >
> > > >>>> Thanks,
> > > >>>> Laurent
> > > >>>
> > > >>>
> > > >>> So I am guessing it's coming from:
> > > >>>
> > > >>> if (msg.hdr.request != request) {
> > > >>> error_report("Received unexpected msg type. Expected %d
> > > >>> received %d",
> > > >>>request, msg.hdr.request);
> > > >>> return -EPROTO;
> > > >>> }
> > > >>>
> > > >>> in process_message_reply and/or in vhost_user_get_u64.
> > > >>>
> > > >>>
> > > >>>> On 11/7/22 23:53, Michael S. Tsirkin wrote:
> > > >>>>> From: Yajun Wu
> > > >>>>>
> > > >>>>> The motivation of adding vhost-user vhost_dev_start support is to
> > > >>>>> improve backend configuration speed and reduce live migration VM
> > > >>>>> downtime.
> > > >>>>>
> > > >>>>> Today VQ configuration is issued one by one. For virtio net with
> > > >>>>> multi-queue support, backend needs to update RSS (Receive side
> > > >>>>> scaling) on every rx queue enable. Updating RSS is time-consuming
> > > >>>>> (typical time like 7ms).
> > > >>>>>
> > > >>>>> Implement already defined vhost status and message in the vhost
> > > >>>>> specification [1].
> > > >>>>> (a) VHOST_USER_PROTOCOL_F_STATUS
> > > >>>>> (b) VHOST_USER_SET_STATUS
> > > >>>>> (c) VHOST_USER_GET_STATUS
> > > >>>>>
> > > >>>>> Send message VHOST_USER_SET_STATUS with VIRTIO_CONFIG_S_DRIVER_OK
> > > >>>>> for device start and reset(0) for device stop.
> > > >>>>>
> > > >>>>> On reception of the DRIVER_OK message, backend can apply the needed
> > > >>>>> setting only once (instead of incremental) and also utilize
> > > >>>>> parallelism on enabling queues.
> > > >>>>>
> > > >>>>> This improves QEMU's live migration downtime with vhost user
> > > >>>>> backend implementation by great margin, specially for the large
> > > >>>>> number of VQs of 64 from 800 msec to 250 msec.
> > > >>>>>
> > > >>>>> [1]
> > > >>>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fq
> > > >>>>> emu-project.gitlab.io%2Fqemu%2Finterop%2Fvhost-user.html=05%7C
> > > >>>>> 01%7Cyajunw%40nvidia.com%7C47e6e0fabd044383fd3308daf47f0253%7C43083
> > > >>>>> d15727340c1b7db39efd9ccc17a%7C0%7C0%7C638091123577559319%7CUnknown%
> > > >>>>> 7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL
> > > >>>>> CJXVCI6Mn0%3D%7C3000%7C%7C%7C=YPbrFRJA92KLLwADMUDvwBt%2Fme2Ef
> > > >>>>> GZuVANOmXH5pic%3D=0
> > > >>>>>
> > > >>>>> Signed-off-by: Yajun Wu
> > > >>>>> Acked-by: Parav Pandit
> > > >>>>> Message-Id: <20221017064452.1226514-3-yaj...@nvidia.com>
> > > >>>>> Reviewed-by: Michael S. Tsirkin
> > > >>>>> Signed-off-by: Michael S. Tsirkin
> > > >>>
> > > >>> Probably easiest to debug from dpdk side.
> > > >>> Does the problem go away if you disable the feature
> > > >>> VHOST_USER_PROTOCOL_F_STATUS in dpdk?
> > > >>
> > > >> Maxime could you help to debug this?
> > > >>
> > > >> Thanks,
> > > >> Laurent
> > > >>
> > > >
> > >
> >
> >
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
gt; # Features:
> > > # @unstable: Members @x-colo and @x-ignore-shared are experimental.
> > > @@ -492,7 +497,7 @@
> > > 'dirty-bitmaps', 'postcopy-blocktime', 'late-block-activate',
> > > { 'name': 'x-ignore-shared', 'features': [ 'unstable' ] },
> > > 'validate-uuid', 'background-snapshot',
> > > - 'zero-copy-send', 'postcopy-preempt'] }
> > > + 'zero-copy-send', 'postcopy-preempt', 'vhost-user-fs'] }
> > I kind of dislike that it's such a specific flag. Is only vhost-user-fs
> > ever going to be affected? Any way to put it in a way that is more generic?
> Here I agree with you: I would prefer less narrow naming too. But I
> didn't manage to come up with one. Looks like many other vhost-user
> devices could benefit from this so maybe "vhost-user-stateless" or
> something like this would be better.
> I'm not sure that other types of devices could handle reconnect to
> the old endpoint as easy as vhost-user-fs, but anyway the support for
> this flag needs to be implemented for each device individually.
> What do you think? Any ideas would be appreciated.
>
> >
> >
> > > ##
> > > # @MigrationCapabilityStatus:
> > > --
> > > 2.34.1
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
t;
> /* as none machine has no memory by default, add a test case with memory
> */
> -qtest_add_data_func("hmp/none+2MB", g_strdup("none -m 2"), test_machine);
> +qtest_add_func("hmp/none+2MB", test_none_with_memory);
>
> return g_test_run();
> }
> --
> 2.35.3
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
* Markus Armbruster (arm...@redhat.com) wrote:
> "Dr. David Alan Gilbert" writes:
>
> > * Markus Armbruster (arm...@redhat.com) wrote:
> >> Clean up includes so that osdep.h is included first and headers
> >> which it implies are not included manually.
&
ch, "x86_64") == 0) {
> @@ -2472,6 +2476,7 @@ int main(int argc, char **argv)
>
> has_tcg = qtest_has_accel("tcg");
> has_kvm = qtest_has_accel("kvm");
> +has_hvf = qtest_has_accel("hvf");
>
> g_test_init(, , NULL);
>
> --
> 2.38.1
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
Signed-off-by: Philippe Mathieu-Daudé
With the ordering proviso of the previous patch,
Reviewed-by: Dr. David Alan Gilbert
> ---
> tests/qtest/migration-test.c | 17 +
> 1 file changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/tests/qtest/migration-test.c
machine_opts ? machine_opts : "",
> - memory_size, tmpfs, uri,
> - arch_target, shmem_opts,
> - args->opts_target ? args->opts_target : "",
> - ignore_stderr);
> -*to = qtest_init(cmd_target);
> +cmd_target = g_string_new(cmd_common->str);
> +g_string_append(cmd_target, "-name target,debug-threads=on ");
> +g_string_append_printf(cmd_target, "-serial file:%s/dest_serial ",
> tmpfs);
> +g_string_append_printf(cmd_target, "-incoming %s ", uri);
> +g_string_append_printf(cmd_target, "%s ", arch_target);
> +if (args->opts_target) {
> +g_string_append_printf(cmd_target, "%s ", args->opts_target);
> +}
> +if (ignore_stderr) {
> +g_string_append(cmd_source, ignore_stderr);
> +}
> +*to = qtest_init(cmd_target->str);
>
> /*
> * Remove shmem file immediately to avoid memory leak in test failed
> case.
> --
> 2.38.1
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
1 - 100 of 11021 matches
Mail list logo
