Re: [PULL 00/10] Modules 20200702 patches

2020-07-06 Thread Claudio Fontana
On 7/3/20 2:05 PM, Paolo Bonzini wrote: > On 03/07/20 12:39, Gerd Hoffmann wrote: >> On Fri, Jul 03, 2020 at 09:54:13AM +0100, Peter Maydell wrote: >>> On Thu, 2 Jul 2020 at 13:23, Gerd Hoffmann wrote: The following changes since commit fc1bff958998910ec8d25db86cd2f53ff125f7ab: >>>

Re: [PULL 00/10] Modules 20200702 patches

2020-07-06 Thread Gerd Hoffmann
Hi, > >>> build: fix device module builds > >> No code review at all? :-( > > > > Well, there have been 5 revisions on the list, partly due to bugs being > > fixed, partly with changes as response to review comments. So it got > > some review (not much though) even though the v5 series (pos

Re: [PULL 00/10] Modules 20200702 patches

2020-07-03 Thread Paolo Bonzini
On 03/07/20 12:39, Gerd Hoffmann wrote: > On Fri, Jul 03, 2020 at 09:54:13AM +0100, Peter Maydell wrote: >> On Thu, 2 Jul 2020 at 13:23, Gerd Hoffmann wrote: >>> >>> The following changes since commit fc1bff958998910ec8d25db86cd2f53ff125f7ab: >>> >>> hw/misc/pca9552: Add missing TypeInfo::class_

Re: [PULL 00/10] Modules 20200702 patches

2020-07-03 Thread Gerd Hoffmann
On Fri, Jul 03, 2020 at 09:54:13AM +0100, Peter Maydell wrote: > On Thu, 2 Jul 2020 at 13:23, Gerd Hoffmann wrote: > > > > The following changes since commit fc1bff958998910ec8d25db86cd2f53ff125f7ab: > > > > hw/misc/pca9552: Add missing TypeInfo::class_size field (2020-06-29 > > 21:16:10 +0100)

Re: [PULL 00/10] Modules 20200702 patches

2020-07-03 Thread Gerd Hoffmann
On Fri, Jul 03, 2020 at 11:14:27AM +0200, Claudio Fontana wrote: > Hello Gerd, > > I think in general the idea to make it easier to modularize things is great, > is this thought for devices only, or could I rework my changes to > support modularizing per-target AccelClass types and all the relate

Re: [PULL 00/10] Modules 20200702 patches

2020-07-03 Thread Claudio Fontana
Hello Gerd, I think in general the idea to make it easier to modularize things is great, is this thought for devices only, or could I rework my changes to support modularizing per-target AccelClass types and all the related code on top of your design? Thanks, Claudio On 7/2/20 2:20 PM, Gerd H

Re: [PULL 00/10] Modules 20200702 patches

2020-07-03 Thread Peter Maydell
On Thu, 2 Jul 2020 at 13:23, Gerd Hoffmann wrote: > > The following changes since commit fc1bff958998910ec8d25db86cd2f53ff125f7ab: > > hw/misc/pca9552: Add missing TypeInfo::class_size field (2020-06-29 > 21:16:10 +0100) > > are available in the Git repository at: > > git://git.kraxel.org/qem

[PULL 00/10] Modules 20200702 patches

2020-07-02 Thread Gerd Hoffmann
The following changes since commit fc1bff958998910ec8d25db86cd2f53ff125f7ab: hw/misc/pca9552: Add missing TypeInfo::class_size field (2020-06-29 21:16:10 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/modules-20200702-pull-request for you to fetch changes up