[Qemu-devel] [PATCH] qapi-schema: Use existing type for drive-backup arguments

2013-07-09 Thread Kevin Wolf
This removes duplicated definitions and documentation by reusing the existing data type. Signed-off-by: Kevin Wolf kw...@redhat.com --- To be applied on top of '[PATCH v3 0/3] qapi: Top-level type reference for command definitions' qapi-schema.json | 32 ++-- 1 file

Re: [Qemu-devel] [PATCH] qapi-schema: Use existing type for drive-backup arguments

2013-07-09 Thread Eric Blake
On 07/09/2013 02:05 AM, Kevin Wolf wrote: This removes duplicated definitions and documentation by reusing the existing data type. Signed-off-by: Kevin Wolf kw...@redhat.com --- To be applied on top of '[PATCH v3 0/3] qapi: Top-level type reference for command definitions'

Re: [Qemu-devel] [PATCH] qapi-schema: Use existing type for drive-backup arguments

2013-07-09 Thread Fam Zheng
On Tue, 07/09 10:05, Kevin Wolf wrote: This removes duplicated definitions and documentation by reusing the existing data type. Signed-off-by: Kevin Wolf kw...@redhat.com --- To be applied on top of '[PATCH v3 0/3] qapi: Top-level type reference for command definitions'

Re: [Qemu-devel] [PATCH] qapi-schema: Use existing type for drive-backup arguments

2013-07-09 Thread Kevin Wolf
Am 09.07.2013 um 13:58 hat Fam Zheng geschrieben: On Tue, 07/09 10:05, Kevin Wolf wrote: This removes duplicated definitions and documentation by reusing the existing data type. Signed-off-by: Kevin Wolf kw...@redhat.com --- To be applied on top of '[PATCH v3 0/3] qapi: Top-level

Re: [Qemu-devel] [PATCH] qapi-schema: Use existing type for drive-backup arguments

2013-07-09 Thread Eric Blake
On 07/09/2013 05:58 AM, Fam Zheng wrote: On Tue, 07/09 10:05, Kevin Wolf wrote: This removes duplicated definitions and documentation by reusing the existing data type. Signed-off-by: Kevin Wolf kw...@redhat.com --- +++ b/qapi-schema.json @@ -1791,42 +1791,14 @@ # The operation can be

Re: [Qemu-devel] [PATCH] qapi-schema: Use existing type for drive-backup arguments

2013-07-09 Thread Eric Blake
On 07/09/2013 06:04 AM, Kevin Wolf wrote: and these still duplication of those comments for type declaration? No, the DriveBackup documentation doesn't describe what the command does or what it returns. You might argue that it should be there, but I think that's out of scope for this patch

Re: [Qemu-devel] [PATCH] qapi-schema: Use existing type for drive-backup arguments

2013-07-09 Thread Kevin Wolf
Am 09.07.2013 um 14:09 hat Eric Blake geschrieben: On 07/09/2013 06:04 AM, Kevin Wolf wrote: and these still duplication of those comments for type declaration? No, the DriveBackup documentation doesn't describe what the command does or what it returns. You might argue that it should be

Re: [Qemu-devel] [PATCH] qapi-schema: Use existing type for drive-backup arguments

2013-07-09 Thread Fam Zheng
On Tue, 07/09 06:07, Eric Blake wrote: On 07/09/2013 05:58 AM, Fam Zheng wrote: On Tue, 07/09 10:05, Kevin Wolf wrote: This removes duplicated definitions and documentation by reusing the existing data type. Signed-off-by: Kevin Wolf kw...@redhat.com --- +++ b/qapi-schema.json

Re: [Qemu-devel] [PATCH] qapi-schema: Use existing type for drive-backup arguments

2013-07-09 Thread Luiz Capitulino
On Tue, 9 Jul 2013 10:05:35 +0200 Kevin Wolf kw...@redhat.com wrote: This removes duplicated definitions and documentation by reusing the existing data type. Signed-off-by: Kevin Wolf kw...@redhat.com Applied to the qmp branch, thanks. --- To be applied on top of '[PATCH v3 0/3] qapi: