[Qemu-devel] [Tracing][RFC v3 PATCH 0/2] QMP Query interfaces for tracing

2010-10-18 Thread Prerna Saxena
This patch set introduces two QMP interfaces for tracing : * query-trace: to list current contents of trace-buffer * query-trace-events : to list all available trace-events with their state. Changelog : --- Changes v2 - v3 : - Change declarations of st_print_trace_to_qlist() and

[Qemu-devel] Re: [PATCH v4 01/15] pci: make pci_del_capability() update for w1cmask

2010-10-18 Thread Michael S. Tsirkin
On Mon, Oct 18, 2010 at 12:17:42PM +0900, Isaku Yamahata wrote: When deleting pci capability, w1cmask should be 0 to make those registers writablein addition to wmask. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp Applied (typo in commit message fixed). --- hw/pci.c |1 + 1

Re: [Qemu-devel] Snapshots ide0-hd0 issue

2010-10-18 Thread Stefan Hajnoczi
On Mon, Oct 18, 2010 at 12:37 AM, Ubuntu Explorer ubuntuexplo...@gmail.com wrote: I am trying to implement snapshot saving and loading from command line using qemu. I am using both the drive and disk options as follows. qemu exe \ --disk path to disk file \ ...other options \ -drive

[Qemu-devel] [Tracing][RFC v3 PATCH 1/2] Introduce QMP interfaces : query-trace query-trace-events

2010-10-18 Thread Prerna Saxena
[PATCH 1/2] Introduce QMP interfaces : query-trace query-trace-events. Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com --- monitor.c | 40 +++--- simpletrace.c | 58 + simpletrace.h |4 +++

[Qemu-devel] [Tracing][RFC v3 PATCH 2/2] Add documentation for QMP commands: query-trace query-trace-events.

2010-10-18 Thread Prerna Saxena
[PATCH 2/2] Add documentation for QMP commands: query-trace query-trace-events. Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com --- qmp-commands.hx | 71 +++ 1 files changed, 71 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] Re: [PATCH v4 00/15] pcie port switch emulators

2010-10-18 Thread Michael S. Tsirkin
On Mon, Oct 18, 2010 at 12:17:41PM +0900, Isaku Yamahata wrote: Here is v4 of the pcie patch series. - PCIDevice::written The abuse of PCIDevice::config to record a written bit of non-modifiable registers is confusing and bad style. So I introduced PCIDevice::written. - FLR stuff I

[Qemu-devel] Re: [PATCH v4 05/15] pci/bridge: fix pci_bridge_reset()

2010-10-18 Thread Michael S. Tsirkin
On Mon, Oct 18, 2010 at 12:17:46PM +0900, Isaku Yamahata wrote: lower 4bits of base/limit register is RO, and should not be modified on reset. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/pci_bridge.c | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-)

[Qemu-devel] Re: [PATCH v4 02/15] pci: introduce helper functions to clear/set bits in configuration space

2010-10-18 Thread Michael S. Tsirkin
On Mon, Oct 18, 2010 at 12:17:43PM +0900, Isaku Yamahata wrote: This patch introduces helper functions to clear/set bits in configuration space. pci_{clear_set, clear, set}_bit_{byte, word, long, quad}(). They will be used later. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp I am not

[Qemu-devel] [Bug 586175] Re: Windows XP/2003 doesn't boot

2010-10-18 Thread Michael Tokarev
virtio disk is entrely different story, unrelated to this issue. ** Changed in: qemu Status: Incomplete = Fix Committed -- Windows XP/2003 doesn't boot https://bugs.launchpad.net/bugs/586175 You received this bug notification because you are a member of qemu- devel-ml, which is

[Qemu-devel] Re: [PATCH v4 05/15] pci/bridge: fix pci_bridge_reset()

2010-10-18 Thread Isaku Yamahata
On Mon, Oct 18, 2010 at 08:22:24AM +0200, Michael S. Tsirkin wrote: On Mon, Oct 18, 2010 at 12:17:46PM +0900, Isaku Yamahata wrote: lower 4bits of base/limit register is RO, and should not be modified on reset. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/pci_bridge.c

[Qemu-devel] Re: [PATCH v4 05/15] pci/bridge: fix pci_bridge_reset()

2010-10-18 Thread Michael S. Tsirkin
On Mon, Oct 18, 2010 at 04:10:17PM +0900, Isaku Yamahata wrote: On Mon, Oct 18, 2010 at 08:22:24AM +0200, Michael S. Tsirkin wrote: On Mon, Oct 18, 2010 at 12:17:46PM +0900, Isaku Yamahata wrote: lower 4bits of base/limit register is RO, and should not be modified on reset.

[Qemu-devel] Re: [PATCH v4 04/15] pci: record which is written into pci configuration space

2010-10-18 Thread Isaku Yamahata
On Mon, Oct 18, 2010 at 07:38:53AM +0200, Michael S. Tsirkin wrote: On Mon, Oct 18, 2010 at 12:17:45PM +0900, Isaku Yamahata wrote: record which is written into pci configuration space. introduce helper function to zero PCIDevice::written. They will be used later. Signed-off-by: Isaku

[Qemu-devel] Re: [PATCH 8/9] Consolidate oom_check() functions

2010-10-18 Thread Jes Sorensen
On 10/16/10 21:02, Blue Swirl wrote: On Sat, Oct 16, 2010 at 4:04 PM, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com This consolidates the duplicated oom_check() functions, as well as splitting them into OS dependant versions to avoid the #ifdef grossness that was

[Qemu-devel] Re: [PATCH v4 05/15] pci/bridge: fix pci_bridge_reset()

2010-10-18 Thread Isaku Yamahata
On Mon, Oct 18, 2010 at 09:08:09AM +0200, Michael S. Tsirkin wrote: The spec says the lower bits are read-only and they have its meaning. Yes. but my question is why even touch io base/io limit at all in this function? It looks like guest can not rely on these being 0 after reset. Oh, now

[Qemu-devel] [Bug 181561] Re: Hardy alpha [2-6] daily-live i386 don't boot

2010-10-18 Thread Bug Watch Updater
** Changed in: linux (Gentoo Linux) Status: Fix Released = Won't Fix -- Hardy alpha [2-6] daily-live i386 don't boot https://bugs.launchpad.net/bugs/181561 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in The Linux

[Qemu-devel] [PATCH v3 0/9] Re-factor osdep code + macro and brace fixes

2010-10-18 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Hi, Here is another set of patches which tries to split up osdep.c further into posix and win32 versions. It introduces oslib-{posix,win32}.c files which are used for functions that are OS specific core library functionality, like gettimeofday(), and

[Qemu-devel] [PATCH 2/9] Move osdep socket code to oslib-{posix, win32}.c

2010-10-18 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- osdep.c | 38 -- oslib-posix.c | 15 +++ oslib-win32.c | 21 + 3 files changed, 36 insertions(+), 38 deletions(-)

[Qemu-devel] [PATCH 1/9] Move QEMU OS dependant library functions to OS specific files

2010-10-18 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This moves library functions used by both QEMU and the QEMU tools, such as qemu-img, qemu-nbd etc. from osdep.c to oslib-{posix,win32}.c In addition it introduces oslib-obj.y to the Makefile set to be included by the various targets, instead of relying

[Qemu-devel] [PATCH 3/9] qemu_pipe() is used only by POSIX code, so move to oslib-posix.c

2010-10-18 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- osdep.c | 22 -- oslib-posix.c | 22 ++ 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/osdep.c b/osdep.c index 902fce9..926c8ad

[Qemu-devel] Re: [PATCH 5/9] Move qemu_gettimeofday() to OS specific files

2010-10-18 Thread Jes Sorensen
On 10/16/10 21:32, Blue Swirl wrote: On Sat, Oct 16, 2010 at 4:04 PM, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com In addition add sysemu.h includes to file requiring a prototype for ffs() There are probably a lot more files which would need that:

[Qemu-devel] [PATCH 9/9] Remove unncessary includes

2010-10-18 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com No need to include stdlib.h for BSD as it is included by qemu-common.h, windows.h is handled by sysemu.h and osdep.c no longer needs malloc.h Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- osdep.c |8 1 files changed, 0

[Qemu-devel] [PATCH 6/9] Do not redefine reserved key-words TRUE/FALSE

2010-10-18 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com TRUE/FALSE are generally reserved keywords and shouldn't be defined in a driver like this. Rename the macros to SDP_TRUE and SDP_FALSE respectively. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- hw/bt-sdp.c | 20 ++-- 1

[Qemu-devel] [PATCH 4/9] We only support eventfd under POSIX, move qemu_eventfd() to os-posix.c

2010-10-18 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c | 32 osdep.c| 34 -- 2 files changed, 32 insertions(+), 34 deletions(-) diff --git a/os-posix.c b/os-posix.c

[Qemu-devel] Re: [PATCH 1/3] Make kvm64 the default cpu model when kvm_enabled()

2010-10-18 Thread Roedel, Joerg
(Sorry for the late reply) On Thu, Oct 07, 2010 at 08:48:06AM -0400, Anthony Liguori wrote: On 10/07/2010 03:42 AM, Roedel, Joerg wrote: On Wed, Oct 06, 2010 at 03:24:59PM -0400, Anthony Liguori wrote: +qemu_compat_version = machine-compat_version; + if (display_type ==

[Qemu-devel] [PATCH 7/9] Separate qemu_pidfile() into OS specific versions

2010-10-18 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c | 21 + os-win32.c | 24 osdep.c| 38 -- 3 files changed, 45 insertions(+), 38 deletions(-)

[Qemu-devel] [PATCH 5/9] Move qemu_gettimeofday() to OS specific files

2010-10-18 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- osdep.c| 31 --- osdep.h| 15 --- oslib-win32.c | 27 +++ posix-aio-compat.c |1 +

[Qemu-devel] [PATCH 8/9] Consolidate oom_check() functions

2010-10-18 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This consolidates the duplicated oom_check() functions, as well as splitting them into OS dependant versions to avoid the #ifdef grossness that was present in the old osdep.c version. Signed-off-by: Jes Sorensen jes.soren...@redhat.com ---

[Qemu-devel] Re: [PATCH v3 0/9] Re-factor osdep code + macro and brace fixes

2010-10-18 Thread Paolo Bonzini
On 10/18/2010 10:15 AM, jes.soren...@redhat.com wrote: From: Jes Sorensenjes.soren...@redhat.com Hi, Here is another set of patches which tries to split up osdep.c further into posix and win32 versions. It introduces oslib-{posix,win32}.c files which are used for functions that are OS specific

[Qemu-devel] [PATCH 0/2] pciinit: fix overflow when bar allocation

2010-10-18 Thread Isaku Yamahata
This patch set fixes PCI bar allocation when bar overflow occured. I checked if pmm_alloc facility can be used, but it doesn't suit for pci bar allocation. So I resulted in new API, pci_region which encapsulates region allocation and overflow checks. The first patch introduces pci_region, and the

[Qemu-devel] [PATCH 1/2] pci: introduce pci_region to manage pci io/memory/prefmemory regions.

2010-10-18 Thread Isaku Yamahata
This patch adds helper functions to manage pci area. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- Makefile |3 +- src/pci_region.c | 70 ++ src/util.h | 15 +++ 3 files changed, 87 insertions(+), 1

[Qemu-devel] [PATCH 2/2] pciinit: use pci_region functions.

2010-10-18 Thread Isaku Yamahata
This patch cleans up pci region allocation with pci_region. Now it is aware of overflow. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- src/pciinit.c | 122 - 1 files changed, 60 insertions(+), 62 deletions(-) diff --git

[Qemu-devel] Re: [PATCH 0/2] pciinit: fix overflow when bar allocation

2010-10-18 Thread Michael S. Tsirkin
On Mon, Oct 18, 2010 at 06:34:21PM +0900, Isaku Yamahata wrote: This patch set fixes PCI bar allocation when bar overflow occured. I checked if pmm_alloc facility can be used, but it doesn't suit for pci bar allocation. So I resulted in new API, pci_region which encapsulates region allocation

[Qemu-devel] Re: [PATCH 1/2] pci: introduce pci_region to manage pci io/memory/prefmemory regions.

2010-10-18 Thread Michael S. Tsirkin
On Mon, Oct 18, 2010 at 06:34:22PM +0900, Isaku Yamahata wrote: This patch adds helper functions to manage pci area. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- Makefile |3 +- src/pci_region.c | 70 ++

Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI device id in PCI ROM

2010-10-18 Thread Gerd Hoffmann
Hi, +/* Don't patch a rom with wrong vendor id (might be changed if needed). */ +if (vendor_id != rom_vendor_id) { +return; +} Yes, please drop that one. If this is accepted I'd like to use this for vga roms too, so we have to carry only two of them instead of four. +

Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI device id in PCI ROM

2010-10-18 Thread Gerd Hoffmann
On 10/15/10 23:05, Anthony Liguori wrote: On 10/15/2010 03:51 PM, Stefan Weil wrote: PCI device with different device ids sometimes share the same rom code. Only the device id and the checksum differ in a boot rom for such devices. BTW, SeaBIOS doesn't reject ROMs when they're loaded via

[Qemu-devel] Re: [PATCH] trace: improve info trace output

2010-10-18 Thread Stefan Hajnoczi
On Sun, Oct 17, 2010 at 08:05:45AM +, Blue Swirl wrote: Use PRI*64 to print full 64 bit data even on ILP32 hosts. Print also sixth tracepoint parameter. Cc: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Signed-off-by: Blue Swirl blauwir...@gmail.com --- simpletrace.c |6 -- 1

[Qemu-devel] Re: TODO item: guest programmable mac/vlan filtering with macvtap

2010-10-18 Thread Arnd Bergmann
On Friday 15 October 2010, Michael S. Tsirkin wrote: On Thu, Oct 14, 2010 at 11:40:52PM +0200, Dragos Tatulea wrote: Hi, I'm starting a thread related to the TODO item mentioned in the subject. Currently still gathering info and trying to make kvm macvtap play nicely together. I

[Qemu-devel] Re: [PATCH] qemu-timer: move commonly used timer code to qemu-timer-common

2010-10-18 Thread Stefan Hajnoczi
On Sun, Oct 17, 2010 at 01:50:33PM +, Blue Swirl wrote: Move timer init functions to a new file, qemu-timer-common.c. Make other critical timer functions inlined to preserve performance in qemu-timer.c, also move muldiv64() (used by the inline functions) to qemu-timer.h. Adjust

Re: [Qemu-devel] [PATCH 1/3] Introduce threadlets

2010-10-18 Thread Arun R Bharadwaj
* Avi Kivity a...@redhat.com [2010-10-17 10:57:23]: On 10/14/2010 11:32 PM, Venkateswararao Jujjuri (JV) wrote: Blocking is somewhat against the spirit of the thing, no? While I agree that the current cancel API is hard to use correctly, blocking defeats the purpose of the

Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI device id in PCI ROM

2010-10-18 Thread Stefan Weil
Am 18.10.2010 12:04, schrieb Gerd Hoffmann: Hi, +/* Don't patch a rom with wrong vendor id (might be changed if needed). */ +if (vendor_id != rom_vendor_id) { +return; +} Yes, please drop that one. If this is accepted I'd like to use this for vga roms too, so we have

[Qemu-devel] LP#584139

2010-10-18 Thread Michael Tokarev
Can we fix this trivial bug please? See: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=578846 https://bugs.launchpad.net/qemu/+bug/584139 I switched qemu-kvm in debian to use qemu-keymaps package (separately packaged keymaps), but it re-introduces debian#578846. Thanks! /mjt

Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI device id in PCI ROM

2010-10-18 Thread Gerd Hoffmann
Hi, As far as I know there is no well-defined checksum offset. The checksum is simply set by modifying any byte (which normally should be unused). Etherboot has some unused bytes at the beginning of rom data and always uses the same offset 6. Ah, so you don't actually update the checksum

Re: [Qemu-devel] [PATCH 1/3] Introduce threadlets

2010-10-18 Thread Avi Kivity
On 10/18/2010 12:47 PM, Arun R Bharadwaj wrote: * Avi Kivitya...@redhat.com [2010-10-17 10:57:23]: On 10/14/2010 11:32 PM, Venkateswararao Jujjuri (JV) wrote: Blocking is somewhat against the spirit of the thing, no? While I agree that the current cancel API is hard to use

[Qemu-devel] Re: [PATCH] apic: convert debug printf statements to tracepoints

2010-10-18 Thread Stefan Hajnoczi
Thanks for pointing out this problem with simpletrace.py. There are two issues: 1. The regular expression used by simpletrace.py to parse trace event declarations cannot cope with concatenated string literals. 2. Format strings must begin and end with double quotes. This was previously

[Qemu-devel] [PATCH 2/3] trace: Format strings must begin/end with double quotes

2010-10-18 Thread Stefan Hajnoczi
Document the restriction that format strings must begin and end with double quotes. This is for easy parsing since we don't run cpp over trace-events. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- docs/tracing.txt |5 - 1 files changed, 4 insertions(+), 1 deletions(-)

[Qemu-devel] [PATCH 3/3] apic: convert debug printf statements to tracepoints

2010-10-18 Thread Stefan Hajnoczi
From: Blue Swirl blauwir...@gmail.com Replace debug printf statements with tracepoints. Signed-off-by: Blue Swirl blauwir...@gmail.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/apic.c| 48 ++-- trace-events | 12

[Qemu-devel] [PATCH 1/3] trace: Relax trace-events parsing regex in simpletrace.py

2010-10-18 Thread Stefan Hajnoczi
The regular expression to parse trace event definitions assumed the format string would be a simple double-quoted string. However, we now use PRI?64 for portability which splits string literals. The regular expression can disregard the format string entirely since simpletrace.py never needs to

Re: [Qemu-devel] Changelog of qemu-0.13.0.tar.gz ?

2010-10-18 Thread Anthony Liguori
On 10/17/2010 11:58 PM, Sergei Steshenko wrote: Hello, though there is already http://download.savannah.gnu.org/releases/qemu/qemu-0.13.0.tar.gz available, I don't see its changelog on http://wiki.qemu.org/Index.html . Is it expected to be this way ? I haven't sent the announce yet

[Qemu-devel] [PATCH] Fix bug in translation of REVSH

2010-10-18 Thread Johan Bengtsson
The translation of REVSH shifted the low byte 8 steps left before performing an 8-bit sign extend, causing this part of the expression to alwas be 0. The fix for this is either to extend before shifting or switch to a 16-bit extend. I choose the former. Signed-off-by: Johan Bengtsson

Re: [Qemu-devel] LP#584139

2010-10-18 Thread Anthony Liguori
On 10/18/2010 06:34 AM, Michael Tokarev wrote: Can we fix this trivial bug please? See: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=578846 https://bugs.launchpad.net/qemu/+bug/584139 I switched qemu-kvm in debian to use qemu-keymaps package (separately packaged keymaps), but it

[Qemu-devel] [PATCH] USB keyboard emulation key mapping error - debian#578846

2010-10-18 Thread Michael Tokarev
Brad Jorsch ano...@users.sourceforge.net writes ( http://bugs.debian.org/578846 ): The USB keyboard emulation's translation table in hw/usb-hid.c doesn't match the codes actually sent for the Logo (a.k.a. Windows) or Menu keys. This results in the guest OS not being able to receive these

[Qemu-devel] [PATCH] add support for qed format

2010-10-18 Thread Stefan Hajnoczi
Note that 019 current fails for both qcow2 and qed due to an outdated .out file. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- 017 |2 +- 018 |2 +- 019 |2 +- 020 |2 +- 024 |4 ++-- 027 |2 +- 028 |2 +-

Re: [Qemu-devel] [PATCH] add support for qed format

2010-10-18 Thread Stefan Hajnoczi
I forgot to add the [qemu-iotests] tag, sorry. This applies to Christoph's qemu-iotests suite at: http://git.kernel.org/?p=linux/kernel/git/hch/qemu-iotests.git;a=summary Stefan

Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI device id in PCI ROM

2010-10-18 Thread Stefan Weil
Hi, Am 18.10.2010 13:54, schrieb Gerd Hoffmann: Hi, As far as I know there is no well-defined checksum offset. The checksum is simply set by modifying any byte (which normally should be unused). Etherboot has some unused bytes at the beginning of rom data and always uses the same offset 6.

[Qemu-devel] [PATCH 0/1] ccid emulated card (v1, for usb-ccid v3)

2010-10-18 Thread Alon Levy
Meant to be applied after the usb-ccid v3 patch on the list. Causes --enable-smartcard to depend on libcac_card, library for emulating CAC compliant smart cards at http://cgit.freedesktop.org/~alon/cac_card/ hw/ccid-card-emulated.c: new device Makefile.objs: add ccid-card-emulated.o if

[Qemu-devel] [PATCH 1/1] add ccid-card-emulated device

2010-10-18 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- Makefile.objs |2 +- configure | 20 ++ hw/ccid-card-emulated.c | 497 +++ hw/ccid-card-passthru.c |6 - hw/usb-ccid.c |2 + 5 files changed, 520

[Qemu-devel] [PATCH] Add support for async page fault to qemu

2010-10-18 Thread Gleb Natapov
Add save/restore of MSR for migration and cpuid bit. Signed-off-by: Gleb Natapov g...@redhat.com diff --git a/qemu-kvm-x86.c b/qemu-kvm-x86.c index bb09fd8..5d8c428 100644 --- a/qemu-kvm-x86.c +++ b/qemu-kvm-x86.c @@ -678,6 +678,9 @@ static int get_msr_entry(struct kvm_msr_entry *entry, CPUState

Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI device id in PCI ROM

2010-10-18 Thread Gerd Hoffmann
Hi, When following this argumentation the vendor id sanity check shouldn't be there in the first place ;) The sanity check is simply there because I had no test case which patches the vendor id. How could I test with vga bios? No trivial way as the vgabios needs to be patched to handle

[Qemu-devel] [PATCH] Add a DTrace tracing backend targetted for SystemTAP compatability

2010-10-18 Thread Daniel P. Berrange
This introduces a new tracing backend that targets the SystemTAP implementation of DTrace userspace tracing. The core functionality should be applicable and standard across any DTrace implementation on Solaris, OS-X, *BSD, but the Makefile rules will likely need some small additional changes to

Re: [Qemu-devel] [PATCH] Trivial fix for QMP/qmp-events.txt

2010-10-18 Thread Luiz Capitulino
On Thu, 14 Oct 2010 09:51:02 +0900 Hidetoshi Seto seto.hideto...@jp.fujitsu.com wrote: Fix example of STOP event that was just copy-and-pasted. Signed-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com Applied to the QMP queue, thanks. --- QMP/qmp-events.txt |2 +- 1 files

Re: [Qemu-devel] [PATCH] Silence compiler warning in json test case

2010-10-18 Thread Luiz Capitulino
On Sat, 16 Oct 2010 19:42:43 +0200 Jan Kiszka jan.kis...@web.de wrote: Am 16.10.2010 18:28, Blue Swirl wrote: On Sat, Oct 16, 2010 at 12:37 AM, Paolo Bonzini pbonz...@redhat.com wrote: On 10/15/2010 07:41 PM, Blue Swirl wrote: Which functions are optimized away and which aren't? It's

[Qemu-devel] Re: [Tracing][RFC v3 PATCH 0/2] QMP Query interfaces for tracing

2010-10-18 Thread Luiz Capitulino
On Mon, 18 Oct 2010 11:36:55 +0530 Prerna Saxena pre...@linux.vnet.ibm.com wrote: This patch set introduces two QMP interfaces for tracing : * query-trace: to list current contents of trace-buffer * query-trace-events : to list all available trace-events with their state. This is in

Re: [Qemu-devel] Trace Logical memory

2010-10-18 Thread kenhcon bk
Hi,I also investigate to implement trace target memory. Now i can trace logical address ( simulate ARM on i386) I focus on tcg_out_qemu_ld and tcg_out_qemu_st function to generate i386 code. But i found that , QEMU don't generate full memory access for loop ( it only generate for 1 TB on loop

[Qemu-devel] KVM call agenda for Oct 19

2010-10-18 Thread Juan Quintela
Please send in any agenda items you are interested in covering. thanks, Juan.

[Qemu-devel] Re: [PATCH] Add support for async page fault to qemu

2010-10-18 Thread Juan Quintela
Gleb Natapov g...@redhat.com wrote: Add save/restore of MSR for migration and cpuid bit. It is there a way to test if async page faults are in use? if so, we can add a subsection instead of changing the cpuversion. I think that at some point we are going to need a bitmap that indicates what

Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI device id in PCI ROM

2010-10-18 Thread Gerd Hoffmann
On 10/18/10 15:30, Gerd Hoffmann wrote: Hi, When following this argumentation the vendor id sanity check shouldn't be there in the first place ;) The sanity check is simply there because I had no test case which patches the vendor id. How could I test with vga bios? No trivial way as the

[Qemu-devel] Re: [PATCH] Add support for async page fault to qemu

2010-10-18 Thread Avi Kivity
On 10/18/2010 05:48 PM, Juan Quintela wrote: Gleb Natapovg...@redhat.com wrote: Add save/restore of MSR for migration and cpuid bit. It is there a way to test if async page faults are in use? Yes, msr != 0 - need a subsection. Good idea. if so, we can add a subsection instead of

[Qemu-devel] [PATCH][block] qcow2: Support exact L1 table growth

2010-10-18 Thread Stefan Hajnoczi
The L1 table grow operation includes a size calculation that bumps up the new L1 table size in order to anticipate the size needs of vmstate data. This helps reduce the number of times that the L1 table has to be grown when vmstate data is appended. This size overhead is not necessary during

[Qemu-devel] Re: [PATCH] Add support for async page fault to qemu

2010-10-18 Thread Gleb Natapov
On Mon, Oct 18, 2010 at 05:48:16PM +0200, Juan Quintela wrote: Gleb Natapov g...@redhat.com wrote: Add save/restore of MSR for migration and cpuid bit. It is there a way to test if async page faults are in use? if so, we can add a subsection instead of changing the cpuversion. Yeah. Good

Re: Testing of russian keymap (was Re: [Qemu-devel] [PATCH] fix '/' and '|' on russian keymap)

2010-10-18 Thread Oleg Sadov
Sorry for delay with answer -- vacations time without e-mail account access. 07/10/2010 08:38 +0400, Michael Tokarev wrote: 06.10.2010 23:56, Eduardo Habkost wrote: Anybody using a russian keyboard layout who can test this change and confirm it works as expected? I can perform such a

[Qemu-devel] [ANNOUNCE] Release 0.13.0 of QEMU

2010-10-18 Thread Anthony Liguori
The QEMU team is pleased to announce the availability of the 0.13.0 release. This release consists of over 2,500 commits from 145 contributors. Some major features were added in this release including: - vhost-net: kernel-accelerating network backend for virtio devices (using KVM) - qmp:

Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI device id in PCI ROM

2010-10-18 Thread Stefan Weil
Am 18.10.2010 17:50, schrieb Gerd Hoffmann: On 10/18/10 15:30, Gerd Hoffmann wrote: Hi, When following this argumentation the vendor id sanity check shouldn't be there in the first place ;) The sanity check is simply there because I had no test case which patches the vendor id. How could

[Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM

2010-10-18 Thread Stefan Weil
PCI devices with different vendor or device ids sometimes share the same rom code. Only the ids and the checksum differs in a boot rom for such devices. The i825xx ethernet controller family is a typical example which is implemented in hw/eepro100.c. It uses at least 3 different device ids, so

[Qemu-devel] Re: [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM

2010-10-18 Thread Michael S. Tsirkin
On Mon, Oct 18, 2010 at 07:55:11PM +0200, Stefan Weil wrote: PCI devices with different vendor or device ids sometimes share the same rom code. Only the ids and the checksum differs in a boot rom for such devices. The i825xx ethernet controller family is a typical example which is

[Qemu-devel] [PATCH] [virtio-9p] Add support to v9fs_string_alloc_printf() for handling %lu.

2010-10-18 Thread Venkateswararao Jujjuri (JV)
Signed-off-by: Venkateswararao Jujjuri jv...@linux.vnet.ibm.com --- hw/virtio-9p.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/hw/virtio-9p.c b/hw/virtio-9p.c index 3b2d49c..9575698 100644 --- a/hw/virtio-9p.c +++ b/hw/virtio-9p.c @@ -325,6 +325,14 @@

Re: [Qemu-devel] [PATCH] Don't call cpu_synchronize_state() from machine init.

2010-10-18 Thread Scott Wood
On Mon, Oct 04, 2010 at 04:15:58PM -0500, Scott Wood wrote: This will deadlock when the I/O thread is used, since the CPU thread is blocked waiting for qemu_system_ready. The synchronization is unnecessary since this is before cpu_synchronize_all_post_init(). Signed-off-by: Scott Wood

[Qemu-devel] Re: [PATCH 1/3] Make kvm64 the default cpu model when kvm_enabled()

2010-10-18 Thread Anthony Liguori
On 10/18/2010 03:22 AM, Roedel, Joerg wrote: (Sorry for the late reply) On Thu, Oct 07, 2010 at 08:48:06AM -0400, Anthony Liguori wrote: On 10/07/2010 03:42 AM, Roedel, Joerg wrote: On Wed, Oct 06, 2010 at 03:24:59PM -0400, Anthony Liguori wrote: +qemu_compat_version =

Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI device id in PCI ROM

2010-10-18 Thread Anthony Liguori
On 10/18/2010 05:09 AM, Gerd Hoffmann wrote: On 10/15/10 23:05, Anthony Liguori wrote: On 10/15/2010 03:51 PM, Stefan Weil wrote: PCI device with different device ids sometimes share the same rom code. Only the device id and the checksum differ in a boot rom for such devices. BTW, SeaBIOS

Re: [Qemu-devel] Re: [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM

2010-10-18 Thread Anthony Liguori
On 10/18/2010 12:58 PM, Michael S. Tsirkin wrote: On Mon, Oct 18, 2010 at 07:55:11PM +0200, Stefan Weil wrote: PCI devices with different vendor or device ids sometimes share the same rom code. Only the ids and the checksum differs in a boot rom for such devices. The i825xx ethernet

Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM

2010-10-18 Thread Anthony Liguori
On 10/18/2010 12:55 PM, Stefan Weil wrote: PCI devices with different vendor or device ids sometimes share the same rom code. Only the ids and the checksum differs in a boot rom for such devices. The i825xx ethernet controller family is a typical example which is implemented in hw/eepro100.c.

[Qemu-devel] Re: [PATCH] Don't call cpu_synchronize_state() from machine init.

2010-10-18 Thread Jan Kiszka
Am 18.10.2010 20:32, Scott Wood wrote: On Mon, Oct 04, 2010 at 04:15:58PM -0500, Scott Wood wrote: This will deadlock when the I/O thread is used, since the CPU thread is blocked waiting for qemu_system_ready. The synchronization is unnecessary since this is before

Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM

2010-10-18 Thread Anthony Liguori
On 10/18/2010 01:44 PM, Anthony Liguori wrote: On 10/18/2010 12:55 PM, Stefan Weil wrote: PCI devices with different vendor or device ids sometimes share the same rom code. Only the ids and the checksum differs in a boot rom for such devices. The i825xx ethernet controller family is a typical

Re: Testing of russian keymap (was Re: [Qemu-devel] [PATCH] fix '/' and '|' on russian keymap)

2010-10-18 Thread Anthony Liguori
On 10/18/2010 12:30 PM, Oleg Sadov wrote: I don't understand reasons for such locale-default keyboard settings for qemu too, but may be it's useful for someone... -k only exists to deal with crappy VNC clients. If you use a good VNC client (like vinagre or virt-viewer) then you don't

Re: [Qemu-devel] Re: [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM

2010-10-18 Thread Michael S. Tsirkin
On Mon, Oct 18, 2010 at 01:42:06PM -0500, Anthony Liguori wrote: +/* Patch the PCI vendor and device ids in a PCI rom image if necessary. + This is needed for an option rom which is used for more than one device. */ +static void pci_patch_ids(PCIDevice *pdev, uint8_t *ptr, int size) let's

Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM

2010-10-18 Thread Stefan Weil
Am 18.10.2010 20:53, schrieb Anthony Liguori: On 10/18/2010 01:44 PM, Anthony Liguori wrote: On 10/18/2010 12:55 PM, Stefan Weil wrote: PCI devices with different vendor or device ids sometimes share the same rom code. Only the ids and the checksum differs in a boot rom for such devices. The

Re: [Qemu-devel] Re: [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM

2010-10-18 Thread Stefan Weil
Am 18.10.2010 21:03, schrieb Michael S. Tsirkin: On Mon, Oct 18, 2010 at 01:42:06PM -0500, Anthony Liguori wrote: +/* Patch the PCI vendor and device ids in a PCI rom image if necessary. + This is needed for an option rom which is used for more than one device. */ +static void

Re: [Qemu-devel] Re: [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM

2010-10-18 Thread Anthony Liguori
On 10/18/2010 02:03 PM, Michael S. Tsirkin wrote: On Mon, Oct 18, 2010 at 01:42:06PM -0500, Anthony Liguori wrote: +/* Patch the PCI vendor and device ids in a PCI rom image if necessary. + This is needed for an option rom which is used for more than one device. */ +static void

Re: [Qemu-devel] Re: [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM

2010-10-18 Thread Anthony Liguori
On 10/18/2010 02:36 PM, Stefan Weil wrote: Maybe a more perfect solution would only patch the preconfigured rom files but not user configured files, but I don't think we need this degree of perfection. Generally speaking, patching third-party code is not something that we should get in the

Re: [Qemu-devel] Hitting 29 NIC limit

2010-10-18 Thread H. Peter Anvin
On 10/14/2010 05:57 AM, Anthony Liguori wrote: I've always been sceptical of this. When physical systems have a large number of NICs, it's via multiple functions, not a bunch of PCI bridges. Actually a lot of multiport PCI cards are in fact single or dual NICs behind PCI bridges.

[Qemu-devel] [PULL] virtio-9p patches - Request for pull

2010-10-18 Thread Venkateswararao Jujjuri (JV)
The following changes since commit 38cc9b607f85017b095793cab6c129bc9844f441: Jindrich Makovicka (1): issue snd_pcm_start() when capturing audio are available in the git repository at: git://repo.or.cz/qemu/aliguori/jvrao.git for-anthony Aneesh Kumar K.V (2): virtio-9p: Use

[Qemu-devel] [PATCH 1/2] Add drive_get_by_id

2010-10-18 Thread Ryan Harper
Add a function to find a drive by id string. Signed-off-by: Ryan Harper ry...@us.ibm.com --- blockdev.c | 12 blockdev.h |1 + 2 files changed, 13 insertions(+), 0 deletions(-) diff --git a/blockdev.c b/blockdev.c index ff7602b..a00b3fa 100644 --- a/blockdev.c +++

[Qemu-devel] [PATCH 0/2] Decouple block device removal from device removal

2010-10-18 Thread Ryan Harper
This patch series decouples the detachment of a block device from the removal of the backing pci-device. Removal of a hotplugged pci device requires the guest to respond before qemu tears down the block device. In some cases, the guest may not respond leaving the guest with continued access to

[Qemu-devel] [PATCH 2/2] Fix Block Hotplug race with drive_unplug()

2010-10-18 Thread Ryan Harper
Block hot unplug is racy since the guest is required to acknowlege the ACPI unplug event; this may not happen synchronously with the device removal command This series aims to close a gap where by mgmt applications that assume the block resource has been removed without confirming that the guest

Re: [Qemu-devel] [PATCH 0/7] ATAPI CDROM passthrough v5

2010-10-18 Thread Alexander Graf
On 30.08.2009, at 02:14, Anthony Liguori wrote: Carl-Daniel Hailfinger wrote: The guest can also mess up other devices with the help of specially crafted firmware. So even if the user does not care about the effects on a particular device, a firmware upgrade might affect other devices

Re: [Qemu-devel] Snapshots ide0-hd0 issue

2010-10-18 Thread Ubuntu Explorer
Thanks for your help. But, after commenting out snapshot option, I still cannot save the VM state into the ide0-hd0 block device. Here is some more information about the problem. I am trying to do the following a. info block shows virtio, ide0-hd0 b. savevm snapshot_name c. info snapshots

Re: [Qemu-devel] [PATCH 0/7] ATAPI CDROM passthrough v5

2010-10-18 Thread Anthony Liguori
On 10/18/2010 06:29 PM, Alexander Graf wrote: A user will get a really nasty surprise if they think they can use a flag or rely on QEMU to prevent a VM from doing something nasty with a device. If they have this feeling of security, they're likely to chmod the device to allow unprivileged

Re: [Qemu-devel] Snapshots ide0-hd0 issue

2010-10-18 Thread Ubuntu Explorer
I also read the following VM snapshots currently have the following known limitations: They cannot cope with removable devices if they are removed or inserted after a snapshot is done. A few device drivers still have incomplete snapshot support so their state is not saved or restored properly (in

Re: [Qemu-devel] Snapshots ide0-hd0 issue

2010-10-18 Thread Ubuntu Explorer
An additional note is that, qemu-img snapshot -l snapshot_file shows VM_Size = 0 Has anyone observed this issue before? Regards -- On Tue, Oct 19, 2010 at 9:18 AM, Ubuntu Explorer ubuntuexplo...@gmail.comwrote: I also read the following VM snapshots currently have the following known

[Qemu-devel] Re: [SeaBIOS] [PATCH 1/2] pci: introduce pci_region to manage pci io/memory/prefmemory regions.

2010-10-18 Thread Isaku Yamahata
On Mon, Oct 18, 2010 at 11:55:08AM +0200, Michael S. Tsirkin wrote: +static u32 pci_region_alloc_align(struct pci_region *r, u32 size, u32 align) +{ +if (r-cur_end == PCI_REGION_DISABLED) { +return 0; +} So is special value PCI_REGION_DISABLED or cur_end? cur_end

Re: [Qemu-devel] Re: [PATCH 11/11] kvm, x86: broadcast mce depending on the cpu version

2010-10-18 Thread Hidetoshi Seto
(2010/10/15 22:30), Marcelo Tosatti wrote: On Fri, Oct 15, 2010 at 10:52:05AM +0900, Hidetoshi Seto wrote: (2010/10/15 10:06), Marcelo Tosatti wrote: On Thu, Oct 14, 2010 at 05:55:28PM +0900, Jin Dongming wrote: There is no reason why SRAO event received by the main thread is the only one

  1   2   >