Il 08/04/2013 23:59, Anthony Liguori ha scritto:
This patch refactors existing virtio-scsi code into VirtIOSCSICommon
in order to allow virtio_scsi_init_common() to be used by both internal
virtio_scsi_init() and external vhost-scsi-pci code.
Changes in Patch-v2:
- Move
Il 09/04/2013 06:33, Nicholas A. Bellinger ha scritto:
Nicholas, where is the latest v3 code. Can you push it to your tree.
Sure. Just pushed to:
http://git.kernel.org/cgit/virt/kvm/nab/qemu-kvm.git/log/?h=vhost-scsi-for-1.4
and should be appearing momentarily.
I'm going to test my
On Mon, Apr 08, 2013 at 10:21:44PM +0200, Stefan Hajnoczi wrote:
On Mon, Apr 8, 2013 at 4:58 PM, Stefan Hajnoczi stefa...@gmail.com wrote:
On Mon, Apr 8, 2013 at 3:05 PM, Richard W.M. Jones rjo...@redhat.com
wrote:
From what I can see libssh2 does not support loading .ssh/config.
I was
在 2013-04-08一的 11:53 +0200，Paolo Bonzini写道：
Il 08/04/2013 02:18, li guang ha scritto:
In short, the purpose is to implement a power control process
just like real world(hardware platform),
a power chip(controller) connect power signals to other devices,
and devices can do power (on, off,
Il 09/04/2013 09:34, li guang ha scritto:
Hmm ... maybe, but,
S-states may be more exactly,
S0 - power on
S3 - suspend
S5 - power off
but that are conceptual,
actually, I just want centralize controlling
of power state transition of whole emulated machine.
That is already there:
Am 08.04.2013 um 18:18 hat Paolo Bonzini geschrieben:
Il 08/04/2013 18:03, Stefan Hajnoczi ha scritto:
Looks fine on the block side. Perhaps Orit, Juan, or Paolo can
double-check the migration side.
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com
Looks good, but given there are
Hi liguang,
Just to be curious, how much performance improvement this patch can get?
Regards,
chenwj
On Tue, Apr 09, 2013 at 11:45:39AM +0800, liguang wrote:
Signed-off-by: liguang lig.f...@cn.fujitsu.com
---
target-arm/translate.c | 17 -
target-i386/translate.c |
Il 09/04/2013 10:04, Kevin Wolf ha scritto:
Looks good, but given there are patches to fix it, I'm not sure it's
worth the trouble...
Shouldn't this perform even a little better? And we should get rid of
non-vectored interfaces in the block layer anyway.
Yes, if you have a very fast disk
Hi Gerd,
Here is a v2 of the patch I send yesterday, changed in v2 is that the warning
is only printed when packets with a status of success are dropped, since on
a regular stall or disconnect chances are all other packets in the queue
also have completed with an error status when we process the
With pipelining it is possible to encounter a finished packet when cleaning
the queue due to a halt. This happens when a non stall error happens while
talking to a real device. In this case the queue on the usb-host side will
continue processing packets, and we can have completed packets waiting
Il 09/04/2013 10:05, 陳韋任 (Wei-Ren Chen) ha scritto:
Hi liguang,
Just to be curious, how much performance improvement this patch can get?
I think zero. It is indeed making the code a tiny bit more readable in
the 2nd/3rd/5th/6th hunks.
But the 1st and 4th hunks, which do
-num_insns =
在 2013-04-08一的 10:21 +0100，Peter Maydell写道：
On 8 April 2013 01:32, li guang lig.f...@cn.fujitsu.com wrote:
在 2013-04-05五的 10:23 +0100，Peter Maydell写道：
QEMU is fundamentally modelling real hardware platforms,
not abstract devices. You have to model a real power
controller to at least some
Signed-off-by: Hans de Goede hdego...@redhat.com
Cc: Paolo Bonzini pbonz...@redhat.com
---
hw/9pfs/virtio-9p-device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
index 43f930e..b476b81 100644
---
Hi Gerd,
And here is a v3 fixing a whitespace issue in v2, sorry about the noise.
Regards,
Hans
With pipelining it is possible to encounter a finished packet when cleaning
the queue due to a halt. This happens when a non stall error happens while
talking to a real device. In this case the queue on the usb-host side will
continue processing packets, and we can have completed packets waiting
I compile the QEMU source download from qemu.git
(http://git.qemu.org/git/qemu.git) on 4-9-2013, errors reported as below,
hw/virtio/dataplane/vring.c: In function 'vring_enable_notification':
hw/virtio/dataplane/vring.c:72: warning: implicit declaration of function
'vring_avail_event'
Il 09/04/2013 10:14, li guang ha scritto:
The approach of power-control may be specific for architectures,
but, I think the thought beneath is common, e.g. for some ARM and MIPS
platforms, OS issue commands to a embedded controller's firmware,
then this firmware will help to do the real
On Tue, Apr 09, 2013 at 10:08:22AM +0200, Paolo Bonzini wrote:
Il 09/04/2013 10:04, Kevin Wolf ha scritto:
Looks good, but given there are patches to fix it, I'm not sure it's
worth the trouble...
Shouldn't this perform even a little better? And we should get rid of
non-vectored
On Tue, Apr 09, 2013 at 10:11:37AM +0200, Paolo Bonzini wrote:
Il 09/04/2013 10:05, 陳韋任 (Wei-Ren Chen) ha scritto:
Hi liguang,
Just to be curious, how much performance improvement this patch can get?
I think zero. It is indeed making the code a tiny bit more readable in
the
Il 09/04/2013 10:22, Hans de Goede ha scritto:
Signed-off-by: Hans de Goede hdego...@redhat.com
Cc: Paolo Bonzini pbonz...@redhat.com
---
hw/9pfs/virtio-9p-device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Ouch, /me installs libcap-ng-devel.
Thanks.
Paolo
diff --git
Il 09/04/2013 10:22, Zhanghaoyu (A) ha scritto:
I compile the QEMU source download from qemu.git
(http://git.qemu.org/git/qemu.git) on 4-9-2013, errors reported as below,
hw/virtio/dataplane/vring.c: In function ‘vring_enable_notification’:
hw/virtio/dataplane/vring.c:72: warning:
Paolo Bonzini pbonz...@redhat.com writes:
Many of these should be cleaned up with proper qdev-/QOM-ification.
Right now there are many catch-all headers in include/hw/ARCH depending
on cpu.h, and this makes it necessary to compile these files per-target.
However, fixing this does not belong
Il 09/04/2013 10:35, Markus Armbruster ha scritto:
Many of these should be cleaned up with proper qdev-/QOM-ification.
Right now there are many catch-all headers in include/hw/ARCH depending
on cpu.h, and this makes it necessary to compile these files per-target.
However, fixing this
Paolo Bonzini pbonz...@redhat.com writes:
Using qemu_memalign only leaves the RAM zero by chance, because libc
will usually use mmap to satisfy our huge requests. But memory will
not be zero when using MALLOC_PERTURB_ with a nonzero value. In the
case of incoming migration, this breaks a
在 2013-04-09二的 09:43 +0200，Paolo Bonzini写道：
Il 09/04/2013 09:34, li guang ha scritto:
Hmm ... maybe, but,
S-states may be more exactly,
S0 - power on
S3 - suspend
S5 - power off
but that are conceptual,
actually, I just want centralize controlling
of power state transition of
在 2013-04-09二的 10:11 +0200，Paolo Bonzini写道：
Il 09/04/2013 10:05, 陳韋任 (Wei-Ren Chen) ha scritto:
Hi liguang,
Just to be curious, how much performance improvement this patch can get?
I think zero. It is indeed making the code a tiny bit more readable in
the 2nd/3rd/5th/6th hunks.
I
Hi,
I've just pulled the latest git repository of QEMU but it's failing the
compilation on missing virtio-9p-device.h header file:
CCx86_64-softmmu/target-i386/arch_memory_mapping.o
CCx86_64-softmmu/target-i386/arch_dump.o
CCx86_64-softmmu/target-i386/kvm.o
CC
Il 09/04/2013 10:52, Markus Armbruster ha scritto:
This also removes the need to do something special on valgrind
(see commit c2a8238a, Support running QEMU on Valgrind, 2011-10-31).
Suggest to state explicitly that you effectively revert it.
You left #define CONFIG_VALGRIND in, even
On 9 April 2013 09:21, li guang lig.f...@cn.fujitsu.com wrote:
在 2013-04-09二的 10:11 +0200，Paolo Bonzini写道：
Il 09/04/2013 10:05, 陳韋任 (Wei-Ren Chen) ha scritto:
Hi liguang,
Just to be curious, how much performance improvement this patch can get?
I think zero. It is indeed making the
Am 29.03.2013 um 03:26 hat Anthony Liguori geschrieben:
Kevin Wolf kw...@redhat.com writes:
Am 13.03.2013 um 15:03 hat Anthony Liguori geschrieben:
You are correct, it should look something like:
if (addr PCI_BASE_ADDRESS_SPACE_IO) {
size = (1ULL ctzl(addr
Hi liguang,
On Tue, Apr 09, 2013 at 04:21:10PM +0800, li guang wrote:
在 2013-04-09二的 10:11 +0200，Paolo Bonzini写道：
Il 09/04/2013 10:05, 陳韋任 (Wei-Ren Chen) ha scritto:
Hi liguang,
Just to be curious, how much performance improvement this patch can get?
I think zero. It is
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Hu Tao hu...@cn.fujitsu.com
---
hw/i386/pc_piix.c | 16 ++--
hw/i386/pc_q35.c | 15 ++-
hw/pc.h | 3 +++
hw/pvpanic.c | 7 +++
4 files changed, 38 insertions(+), 3 deletions(-)
diff
Commit 47b5264eb3e1cd2825e48d28fd0d1b239ed53974 broke the compile. It's
caused by the rename of the file:
hw/9pfs/virtio-9p-device.h = include/hw/virtio/virtio-9p.h
Signed-off-by: Lei Li li...@linux.vnet.ibm.com
---
hw/9pfs/virtio-9p-device.c |2 +-
1 files changed, 1 insertions(+), 1
On 09/04/2013 10:36, Paolo Bonzini wrote:
Il 09/04/2013 10:22, Hans de Goede ha scritto:
Signed-off-by: Hans de Goede hdego...@redhat.com
Cc: Paolo Bonzini pbonz...@redhat.com
---
hw/9pfs/virtio-9p-device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Ouch, /me installs
Il 09/04/2013 11:06, Hu Tao ha scritto:
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Hu Tao hu...@cn.fujitsu.com
Thanks, seems like we're good.
Please resubmit, the new position for pvpanic.c should be in hw/misc.
Paolo
---
hw/i386/pc_piix.c | 16 ++--
Il 09/04/2013 11:30, KONRAD Frédéric ha scritto:
#include hw/virtio/virtio.h
+#include hw/virtio/virtio-9p.h
[..]
#include virtio-9p.h
Is that normal?
We have two virtio-9p.h:
./hw/9pfs/virtio-9p.h
./include/hw/virtio/virtio-9p.h
which can be confusing.
Yes, the first one is
On Tue, Apr 9, 2013 at 11:07 AM, Michal Novotny minov...@redhat.com wrote:
Hi,
I've just pulled the latest git repository of QEMU but it's failing the
compilation on missing virtio-9p-device.h header file:
CCx86_64-softmmu/target-i386/arch_memory_mapping.o
CC
On 04/09/2013 05:07 PM, Michal Novotny wrote:
Hi,
I've just pulled the latest git repository of QEMU but it's failing the
compilation on missing virtio-9p-device.h header file:
CCx86_64-softmmu/target-i386/arch_memory_mapping.o
CCx86_64-softmmu/target-i386/arch_dump.o
CC
On Tue, Apr 09, 2013 at 05:23:43PM +0800, Lei Li wrote:
Commit 47b5264eb3e1cd2825e48d28fd0d1b239ed53974 broke the compile. It's
caused by the rename of the file:
hw/9pfs/virtio-9p-device.h = include/hw/virtio/virtio-9p.h
Signed-off-by: Lei Li li...@linux.vnet.ibm.com
---
Changes since v7:
- fsync (ie. bdrv_co_flush_to_disk) is now supported, *if* you have
the following patches to libssh2 and OpenSSH:
https://bugzilla.mindrot.org/show_bug.cgi?id=1798
(OpenSSH: accepted, but not upstream)
http://www.libssh2.org/mail/libssh2-devel-archive-2013-04/0006.shtml
From: Richard W.M. Jones rjo...@redhat.com
libssh2_sftp_fsync is an extension to libssh2 to support fsync(2) over
sftp, which is itself an extension of OpenSSH.
If both libssh2 and the ssh daemon support it, this will allow
bdrv_flush_to_disk to commit changes through to disk on the remote
From: Richard W.M. Jones rjo...@redhat.com
Note in order to run these tests on ssh, you must be running a local
ssh daemon, and that daemon must accept loopback connections, and
ssh-agent has to be set up to allow logins on the local daemon. In
other words, the following command should just work
From: Richard W.M. Jones rjo...@redhat.com
qemu-system-x86_64 -drive file=ssh://hostname/some/image
QEMU will ssh into 'hostname' and open '/some/image' which is made
available as a standard block device.
You can specify a username (ssh://user@host/...) and/or a port number
From: KONRAD Frederic fred.kon...@greensocs.com
This fix the broken aliases, by renaming the devices.
So: * virtio-blk = virtio-blk-device.
* virtio-balloon = virtio-balloon-device.
* virtio-scsi = virtio-scsi-device.
All virtio-*-pci, virtio-*-s390, virtio-*-ccw didn't change.
On Mon, 8 Apr 2013 16:45:01 -0300
Eduardo Habkost ehabk...@redhat.com wrote:
On Fri, Apr 05, 2013 at 04:36:57PM +0200, Igor Mammedov wrote:
... to synchronize CPU state to KVM
* in addition link kvm-stub.o to *-user target and fix related compiling
issues.
Signed-off-by: Igor
We already had a test to add -march=i486 when needed. Make the
existing test independent of vhost-net, so that it is also used
under Win32.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
configure | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/configure
On Mon, 8 Apr 2013 17:13:11 -0300
Eduardo Habkost ehabk...@redhat.com wrote:
On Fri, Apr 05, 2013 at 04:36:58PM +0200, Igor Mammedov wrote:
... and call it if defined from CPUClass.realize() if CPU was hotplugged
by default leave .resume() unset (i.e. NULL) and override it for softmmu
There is no reason why vhost-net should not work with TCG.
Hence, put the limitation in hw/vhost-net.c, not straight in
the config-*.mak files.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
configure | 6 +++---
hw/net/vhost_net.c | 2 +-
2 files changed, 4 insertions(+), 4
Il 08/04/2013 20:30, Eduardo Habkost ha scritto:
-cpu_x86_register(cpu, name, error);
-if (error) {
+cpu_x86_register(cpu, name, errp);
+if (error_is_set(errp)) {
So the function now does error checking properly if and only if errp is
not NULL. Do we really want to do
On Tue, 09 Apr 2013 12:30:21 +0200
Paolo Bonzini pbonz...@redhat.com wrote:
Il 08/04/2013 20:30, Eduardo Habkost ha scritto:
-cpu_x86_register(cpu, name, error);
-if (error) {
+cpu_x86_register(cpu, name, errp);
+if (error_is_set(errp)) {
So the function now does
On 9 April 2013 11:25, Paolo Bonzini pbonz...@redhat.com wrote:
We already had a test to add -march=i486 when needed. Make the
existing test independent of vhost-net, so that it is also used
under Win32.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
configure | 7 +--
1 file
Hello Stefan,
Thank you for reviewing my patch.
(2013/04/08 23:10), Stefan Hajnoczi wrote:
On Wed, Apr 03, 2013 at 03:30:58PM +0900, Eiichi Tsukata wrote:
diff --git a/scripts/tracetool/backend/ftrace.py
b/scripts/tracetool/backend/ftrace.py
new file mode 100644
index 000..e02f0ca
---
Since 0d09e41a51aa0752b1ce525ce084f7cd210e461b virtio-9p-device.h has
been renamed as virtio-9p.h, so there will be a compiling error. This
patch will fix it.
Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com
---
hw/9pfs/virtio-9p-device.c | 2 +-
1 file changed, 1 insertion(+), 1
On 04/09/2013 11:23 AM, Lei Li wrote:
Commit 47b5264eb3e1cd2825e48d28fd0d1b239ed53974 broke the compile. It's
caused by the rename of the file:
hw/9pfs/virtio-9p-device.h = include/hw/virtio/virtio-9p.h
Signed-off-by: Lei Li li...@linux.vnet.ibm.com
---
hw/9pfs/virtio-9p-device.c |2
If TARGET_ABI_BITS is bigger than 32 we shift by more than the size of int.
Signed-off-by: Andreas Schwab sch...@suse.de
---
linux-user/syscall.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index fa3039f..5abc16f 100644
---
Il 09/04/2013 10:26, li guang ha scritto:
qemu_system_suspend_request, qemu_register_suspend_notifier
for S0-S3
qemu_system_wakeup_request, qemu_register_wakeup_notifier
for S3-S0
qemu_system_powerdown_request, qemu_register_powerdown_notifier
for Sx-S5
and the
On Tue, Apr 09, 2013 at 07:00:23PM +0800, zhangleiqi...@gmail.com wrote:
Is there already a plan to support the differential or incremental backups
in this Live backup feature?
No, it has been mentioned but no design or patches have been proposed.
It seems like a persistent dirty bitmap
On 9 April 2013 12:02, Andreas Schwab sch...@suse.de wrote:
If TARGET_ABI_BITS is bigger than 32 we shift by more than the size of int.
Signed-off-by: Andreas Schwab sch...@suse.de
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
-- PMM
---
linux-user/syscall.c | 2 +-
1 file changed,
On 09/04/2013 11:36, Paolo Bonzini wrote:
Il 09/04/2013 11:30, KONRAD Frédéric ha scritto:
#include hw/virtio/virtio.h
+#include hw/virtio/virtio-9p.h
[..]
#include virtio-9p.h
Is that normal?
We have two virtio-9p.h:
./hw/9pfs/virtio-9p.h
./include/hw/virtio/virtio-9p.h
which can
Il 05/04/2013 16:36, Igor Mammedov ha scritto:
... to synchronize CPU state to KVM
* in addition link kvm-stub.o to *-user target and fix related compiling
issues.
Please make it a separate patch.
The Makefile.target parts should look like this, I think:
diff --git a/Makefile.target
Il 09/04/2013 12:13, Igor Mammedov ha scritto:
Why you didn't include it on libqemustub instead? You said on a previous
thread that it is not possible to include all of kvm-stub.c into
libqemustub. Why not?
It wasn't possible, but after this patch it's, I guess.
Paolo objected to
Il 08/04/2013 22:13, Eduardo Habkost ha scritto:
So you are initializing a field of CPUClass struct inside a CPU object
initialization function. And that's a function that is not even
converted to QOM yet, and buried inside a non-trivial function call tree
(hence easy to be called at the wrong
Paolo Bonzini pbonz...@redhat.com wrote:
Using qemu_memalign only leaves the RAM zero by chance, because libc
will usually use mmap to satisfy our huge requests. But memory will
not be zero when using MALLOC_PERTURB_ with a nonzero value. In the
case of incoming migration, this breaks a
Il 05/04/2013 16:37, Igor Mammedov ha scritto:
hot-added CPU will be distributed to acpi_piix4, rtc_cmos and icc_bridge
Signed-off-by: Igor Mammedov imamm...@redhat.com
---
v2:
* move notifier to qom/cpu.c and call it from CPUClass.realize() on hotplug
---
include/qom/cpu.h | 2
Il 05/04/2013 16:37, Igor Mammedov ha scritto:
... it should be used only on slow path since it does recursive search
on /machine QOM tree for objects of TYPE_CPU
Signed-off-by: Igor Mammedov imamm...@redhat.com
---
include/qom/cpu.h | 10 ++
qom/cpu.c | 21
Il 05/04/2013 16:37, Igor Mammedov ha scritto:
... and use it from board level to set APIC ID for CPUs
it creates.
Signed-off-by: Igor Mammedov imamm...@redhat.com
---
Note:
* pc_new_cpu() function will be reused later in CPU hot-plug hook.
v2:
* use generic cpu_exists() instead of
Paolo Bonzini pbonz...@redhat.com writes:
Il 09/04/2013 10:52, Markus Armbruster ha scritto:
This also removes the need to do something special on valgrind
(see commit c2a8238a, Support running QEMU on Valgrind, 2011-10-31).
Suggest to state explicitly that you effectively revert it.
You
The sysbus-ohci dma-address property is declared as a HEX64
property, not a TADDR, so use the correct setter for it.
Signed-off-by: Peter Maydell peter.mayd...@linaro.org
---
hw/display/sm501.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/display/sm501.c
Drop all the infrastructure for taddr properties (ie ones which
are 'hwaddr' sized). These are now unused, and any further desired
use would be rather questionable since device properties shouldn't
generally depend on a type that is conceptually variable based on
the target CPU. 32 or 64 bit
Il 05/04/2013 16:37, Igor Mammedov ha scritto:
@@ -282,12 +284,14 @@ static int apic_load_old(QEMUFile *f, void *opaque, int
version_id)
return 0;
}
-static int apic_init_common(SysBusDevice *dev)
+static int apic_init_common(ICCDevice *dev)
{
APICCommonState *s =
Paolo Bonzini pbonz...@redhat.com writes:
Il 09/04/2013 11:30, KONRAD Frédéric ha scritto:
#include hw/virtio/virtio.h
+#include hw/virtio/virtio-9p.h
[..]
#include virtio-9p.h
Is that normal?
We have two virtio-9p.h:
./hw/9pfs/virtio-9p.h
./include/hw/virtio/virtio-9p.h
Paolo Bonzini pbonz...@redhat.com wrote:
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
savevm.c | 25 +
1 file changed, 9 insertions(+), 16 deletions(-)
diff --git a/savevm.c b/savevm.c
index b1d8988..c952c41 100644
--- a/savevm.c
+++ b/savevm.c
@@ -631,6
Il 05/04/2013 16:37, Igor Mammedov ha scritto:
+const char *ioapic_name = ioapic;
if (kvm_irqchip_in_kernel()) {
-dev = qdev_create(NULL, kvm-ioapic);
-} else {
-dev = qdev_create(NULL, ioapic);
-}
-if (parent_name) {
-
Il 05/04/2013 16:37, Igor Mammedov ha scritto:
Currently device_set_realized() sets parent only after device was realized,
But qdev_device_add() sets it before device is realized.
Make behavior consistent and alter device_set_realized() to behave like
qdev_device_add().
It will allow to set
Il 08/04/2013 13:32, Igor Mammedov ha scritto:
This patch should be combined with [PATCH 07/22]
在 2013-04-05五的 16:37 +0200，Igor Mammedov写道：
Signed-off-by: Igor Mammedov imamm...@redhat.com
---
hw/ioapic_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Ping.
On 2013-03-31 17:34, Richard Henderson wrote:
Changes v4-v5:
* Incorprate stack realignment into frame size, instead of pushing r12.
* Disassemble prologues with -d out_asm.
Changes v3-v4:
* Local stack frame fix has been reworked to be independant of the rest
of the
Ping 2.
On 2013-04-03 17:11, Richard Henderson wrote:
Ping?
On 2013-03-28 10:37, Richard Henderson wrote:
My main goal here is the last patch. With the patches I've posted
for arm and s390, tci is the only remaining user of env-temp_buf.
r~
Richard Henderson (5):
tci: Use 32-bit
Paolo Bonzini pbonz...@redhat.com wrote:
The recent patches to use vectored I/O for RAM migration caused a
regression in savevm speed. To restore previous performance,
add data to the buffer in qemu_put_buffer_async whenever writev_buffer
is not available in the QEMUFile.
Signed-off-by:
Il 09/04/2013 13:32, Juan Quintela ha scritto:
Paolo Bonzini pbonz...@redhat.com wrote:
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
savevm.c | 25 +
1 file changed, 9 insertions(+), 16 deletions(-)
diff --git a/savevm.c b/savevm.c
index b1d8988..c952c41
Paolo Bonzini pbonz...@redhat.com wrote:
The same QEMUFile is never used for both read and write. Simplify
the logic to simply look for presence or absence of the right ops.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Love this one.
@@ -556,11 +557,7 @@ static void
There is currently only one user of the qdev taddr (target addr,
now hwaddr) property code, and that user is wrong anyway, since the
property it's trying to set isn't actually a taddr property.
Fix the erroneous use in sm501 and drop all the taddr property code.
The justification for dropping the
Il 09/04/2013 13:38, Juan Quintela ha scritto:
And this
is not needed if we just put the code inside add_to_iovec() no?
Users of add_to_iovec() should not care if we are using vritev or
put_buffer() right.
I'm taking the opposite stance here. add_to_iovec() should not be
called at
Paolo Bonzini pbonz...@redhat.com wrote:
Check f-iovcnt in add_to_iovec, f-buf_index in qemu_put_buffer/byte.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
savevm.c | 22 +-
1 file changed, 9 insertions(+), 13 deletions(-)
diff --git a/savevm.c b/savevm.c
index
Minor fixes to documentation and code comments.
Signed-off-by: Peter Maydell peter.mayd...@linaro.org
---
No actual changes, just rebased and resent following Paolo
moving everything around.
docs/bootindex.txt | 10 +-
docs/ccid.txt |2 +-
Il 09/04/2013 13:30, Markus Armbruster ha scritto:
We have two virtio-9p.h:
./hw/9pfs/virtio-9p.h
./include/hw/virtio/virtio-9p.h
which can be confusing.
Yes, the first one is only included with a local path. Though I think
this is what confused my scripts.
It'll confuse
On Mon, Apr 08, 2013 at 01:01:53PM +, Zhangleiqiang wrote:
I guess maybe the non-dataplane already reached the physical disk's IOPS
upper limit in the scenario above so that data plane didn't make a difference?
Yes.
Stefan
Il 09/04/2013 13:43, Juan Quintela ha scritto:
@@ -687,12 +685,10 @@ void qemu_put_byte(QEMUFile *f, int v)
f-bytes_xfer++;
if (f-ops-writev_buffer) {
add_to_iovec(f, f-buf + f-buf_index, 1);
-f-buf_index++;
-} else {
-f-buf_index++;
-
Ping.
On 2013-04-05 13:47, Richard Henderson wrote:
Here's the latest set of tcg-s390 updates. The only real change
from v1 is the addition of the last patch. This is able to run
the i386-softmmu nbench test, and boot both arm and sparc32 kernels.
I tried to look at addressing Aurelien's
Hi Andreas,
not sure if this is what you had in mind. Does it at least go into the right
direction?
It is pretty much untested and won't compile as is. I just wanted to get your
opinion
before putting more work into this.
This patch adds 4 write_elf_XX functions to the CPUClass which can be
On Tue, Apr 09, 2013 at 12:27:28PM +0200, Paolo Bonzini wrote:
There is no reason why vhost-net should not work with TCG.
Hence, put the limitation in hw/vhost-net.c, not straight in
the config-*.mak files.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
If you want to enable vhost for tcg
Paolo Bonzini pbonz...@redhat.com wrote:
Il 09/04/2013 13:43, Juan Quintela ha scritto:
@@ -687,12 +685,10 @@ void qemu_put_byte(QEMUFile *f, int v)
f-bytes_xfer++;
if (f-ops-writev_buffer) {
add_to_iovec(f, f-buf + f-buf_index, 1);
-f-buf_index++;
-}
Paolo Bonzini pbonz...@redhat.com wrote:
Il 09/04/2013 13:42, Juan Quintela ha scritto:
@@ -556,11 +557,7 @@ static void qemu_fill_buffer(QEMUFile *f)
int len;
int pending;
-if (!f-ops-get_buffer)
-return;
Why are we removing this test? this has nothing to do
On 04/09/2013 02:53 PM, Paolo Bonzini wrote:
Il 09/04/2013 13:43, Juan Quintela ha scritto:
@@ -687,12 +685,10 @@ void qemu_put_byte(QEMUFile *f, int v)
f-bytes_xfer++;
if (f-ops-writev_buffer) {
add_to_iovec(f, f-buf + f-buf_index, 1);
-f-buf_index++;
-} else
Hi!
I've tried passing through my ASUS Radeon HD7750, but qemu just hogs 100%
of one core and stops. Since the display didn't light up, I couldn't see
how far Win 7 boot went. For a Linux guest I tried redirecting kernel
messages to serial console, but there was nothing (qemu stops even before
Il 09/04/2013 14:17, Juan Quintela ha scritto:
This test assumes that it makes sense to call qemu_get_byte on a
write-opened QEMUFile. This is not true anymore after this patch.
After eliminating is_write, the right thing to do is abort.
But this would not abort, it would do a
On Fri, Apr 05, 2013 at 09:27:52PM +0200, Kevin Wolf wrote:
This gives us back reasonable savevm performance, which regressed in
commit 500f0061.
Kevin Wolf (4):
block: Introduce bdrv_writev_vmstate
savevm: Implement block_writev_buffer()
block: Introduce bdrv_pwritev() for
On Tue, 9 Apr 2013 11:02:15 +0800
Hu Tao hu...@cn.fujitsu.com wrote:
'add qobject_get_length()' in the subject line but you are actually
adding qstring_get_length()
Thanks, but this was corrected in v2 and it's what got merged.
On Mon, Mar 25, 2013 at 03:40:38PM -0400, Luiz Capitulino
On Tue, Apr 09, 2013 at 10:56:32AM +0100, Richard W.M. Jones wrote:
These are both not worth respinning for, but just in case you send
another version.
+static coroutine_fn int ssh_flush(BDRVSSHState *s)
+{
+int r;
+static int warned = 0;
+
+DPRINTF(fsync);
+ again:
+r =
On Fri, 5 Apr 2013 16:37:12 +0200
Igor Mammedov imamm...@redhat.com wrote:
... to allow it to be hotplugged
* map APIC's mmio at board level if it is present
Signed-off-by: Igor Mammedov imamm...@redhat.com
---
hw/apic_common.c | 17 -
hw/apic_internal.h | 6 +++---
On Tue, 09 Apr 2013 13:33:56 +0200
Paolo Bonzini pbonz...@redhat.com wrote:
Il 05/04/2013 16:37, Igor Mammedov ha scritto:
+const char *ioapic_name = ioapic;
if (kvm_irqchip_in_kernel()) {
-dev = qdev_create(NULL, kvm-ioapic);
-} else {
-dev =
1 - 100 of 308 matches
Mail list logo
