Re: [Qemu-devel] [PULL 00/27] Trivial patches for 2016-09-14

Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: cover.1473839869.git@msgid.tls.msk.ru Subject: [Qemu-devel] [PULL 00/27] Trivial patches for 2016-09-14 === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

Re: [Qemu-devel] [PATCH RFC] pci: call PCIDeviceClass->exit on its .realize failure

On 09/14/2016 12:14 PM, Cao jin wrote: It cannot guarantee all pci devices will free the allocated resource in its .realize function on realize failure. CC: Michael S. Tsirkin CC: Marcel Apfelbaum Signed-off-by: Cao jin --- I

Re: [Qemu-devel] [Bug 1536487] Re: Unable to migrate pc-i440fx-2.4 KVM guest from QEMU 2.5.0 to QEMU 2.4.1

Migrating a VM from xenial -> trusty (or anything moving backward) is not supported. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1536487 Title: Unable to migrate pc-i440fx-2.4 KVM guest from

Re: [Qemu-devel] [RFC PATCH v1 20/22] fw_cfg: sev: disable dma in real mode

On Wed, Sep 14, 2016 at 04:14:58PM +0300, Michael S. Tsirkin wrote: > On Wed, Sep 14, 2016 at 03:01:51PM +0200, Paolo Bonzini wrote: > > > > > > On 14/09/2016 14:09, Eduardo Habkost wrote: > > > On Wed, Sep 14, 2016 at 05:33:09AM +0300, Michael S. Tsirkin wrote: > > >> On Wed, Sep 14, 2016 at

[Qemu-devel] [networking] : writing to nic without using tap api's

I am using qemu 2.2.0 with e1000 as my default eth i/f. I want to trap data packets from/to e1000 without using tap i/f. Downstream packets i am able to get with 'e1000_send_packet'. However, i am not able to inject packet back to the nic without tap. Can someone point me to how can i do that ?

Re: [Qemu-devel] [RFC PATCH v1 20/22] fw_cfg: sev: disable dma in real mode

On Wed, Sep 14, 2016 at 05:33:09AM +0300, Michael S. Tsirkin wrote: > On Wed, Sep 14, 2016 at 12:53:36AM +0200, Paolo Bonzini wrote: > > > > > > On 13/09/2016 16:50, Brijesh Singh wrote: > > > In SEV-enabled guest dma should be performed on shared pages. Since > > > the SeaBIOS executes in non

Re: [Qemu-devel] [RFC PATCH v1 10/22] sev: add SEV debug decrypt command

On 09/13/2016 09:28 PM, Michael S. Tsirkin wrote: On Tue, Sep 13, 2016 at 10:48:27AM -0400, Brijesh Singh wrote: The SEV DEBUG_DECRYPT command is used for decrypting a guest memory for the debugging purposes. Note that debugging is permitting only when guest policy allows it. When wouldn't

[Qemu-devel] [Bug 1596009] Re: config/build problem due to libncursesw on Xenial

This is not an issue with Ubu but a Yocto build issue. In Xenial libsdl1.2-dev depends on libcaca-dev which depends on libcaca0 which depends on ncursesw5. Additionally libcaca.so is looking for symbols in libncursesw5 with variable decorations like `resize_term@NCURSESW_5.3.20021019', yet Yocto

Re: [Qemu-devel] [PATCH v2] qom: Implement qom-get HMP command

On Wed, Sep 14, 2016 at 11:30:06AM +0100, Dr. David Alan Gilbert wrote: > * Markus Armbruster (arm...@redhat.com) wrote: > > "Dr. David Alan Gilbert (git)" writes: > > > > > From: "Dr. David Alan Gilbert" > > > > > > This started off as Andreas Färber's

Re: [Qemu-devel] [PATCH v4 1/3] memory: introduce IOMMUNotifier and its caps

On Wed, Sep 14, 2016 at 03:40:08PM +0800, Peter Xu wrote: > On Wed, Sep 14, 2016 at 05:15:03PM +1000, David Gibson wrote: > > [...] > > > > > @@ -1564,8 +1569,22 @@ void > > > > memory_region_unregister_iommu_notifier(MemoryRegion *mr, Notifier *n) > > > > void

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 3/3] tests: add RTAS command in the protocol

On Wed, Sep 14, 2016 at 11:05:47AM +0200, Greg Kurz wrote: > On Wed, 14 Sep 2016 13:22:40 +1000 > David Gibson wrote: > > > On Tue, Sep 13, 2016 at 02:52:45PM +0200, Laurent Vivier wrote: > > > Add a first test to validate the protocol: > > > > > > -

Re: [Qemu-devel] [PATCH v4 1/3] memory: introduce IOMMUNotifier and its caps

On Wed, Sep 14, 2016 at 04:17:26PM +0800, Peter Xu wrote: > On Wed, Sep 14, 2016 at 05:15:03PM +1000, David Gibson wrote: > > [...] > > > Peter suggested commenting this next to the IOTLBEntry definition, and > > I think that's probably ok for now. > > Looks like we have something already (just

Re: [Qemu-devel] [PATCH v4 2/3] memory: introduce IOMMUOps.notify_flag_changed

On Wed, Sep 14, 2016 at 08:37:34PM +1000, David Gibson wrote: [...] > > This should not be related to the interface at all? > > > > I was based on the assumption that "Power cannot support either one of > > MAP/UNMAP, but only if both exist". > > Huh? I have no idea what you mean by that. > >

Re: [Qemu-devel] [PATCH 2/2] target-i386: turn off CPU.l3-cache only for 2.7 and older machine types

On 09/14/2016 01:01 PM, Igor Mammedov wrote: commit (14c985cff target-i386: present virtual L3 cache info for vcpus) misplaced compat property putting it in new 2.8 machine type which would effectively to disable feature until 2.9 is released. Intent of commit probably should be to disable

Re: [Qemu-devel] [PATCH] linux-user: Fixed brk syscall memory allocation

Please ignore this patch. Issue was in another place, and proposed solution is simply wrong. 2016-09-13 16:14 GMT+03:00 Stanislav Shmarov : > When application is trying to allocate memory through brk > QEMU is allocating host memory using mmap. > Without MAP_FIXED attribute it

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] block: Accept qdev IDs in device level QMP commands

Am 05.09.2016 um 17:55 hat Kevin Wolf geschrieben: > Am 19.08.2016 um 18:50 hat Kevin Wolf geschrieben: > > In order to remove the necessity to use BlockBackend names in the external > > API, > > we already converted all block layer QMP commands on the node level to > > accept > > node names

[Qemu-devel] [Bug 1603636] Re: Guest has not initialized the display yet on ubuntu 16.10 PPC

Alll revisions are available in the git repository, so please simply do: git clone git://git.qemu-project.org/qemu.git cd qemu git checkout 4fd811a6bd0b8f24f4761fc281454494c336d310 ./configure ... make -j4 And then check whether it is working or not. Once you're done, switch to the other

Re: [Qemu-devel] [RFC PATCH v1 10/22] sev: add SEV debug decrypt command

On Wed, Sep 14, 2016 at 10:57:34AM +0200, Paolo Bonzini wrote: > > > On 14/09/2016 04:28, Michael S. Tsirkin wrote: > > On Tue, Sep 13, 2016 at 10:48:27AM -0400, Brijesh Singh wrote: > >> The SEV DEBUG_DECRYPT command is used for decrypting a guest memory > >> for the debugging purposes. Note

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

Daniel P Berrange writes: > On Tue, Sep 13, 2016 at 08:36:25PM +0200, Lluís Vilanova wrote: >> Daniel P Berrange writes: >> >> > On Thu, Sep 08, 2016 at 03:23:26PM +0200, Lluís Vilanova wrote: >> >> Daniel P Berrange writes: >> >> >> >> > I previously split the global trace-events file up into

Re: [Qemu-devel] [RFC PATCH v1 10/22] sev: add SEV debug decrypt command

On Wed, Sep 14, 2016 at 02:23:14PM +0100, Daniel P. Berrange wrote: > On Wed, Sep 14, 2016 at 03:07:58PM +0200, Paolo Bonzini wrote: > > > > > > On 14/09/2016 15:05, Michael S. Tsirkin wrote: > > > I assumed that with debug on, memory is still encrypted but the > > > hypervisor can break

Re: [Qemu-devel] [PATCH for-2.8 v1 60/60] trace: update docs to reflect new code generation approach

On Fri, Sep 02, 2016 at 05:24:04PM -0400, Stefan Hajnoczi wrote: > On Thu, Aug 11, 2016 at 12:11:06PM +0200, Lluís Vilanova wrote: > > Daniel P Berrange writes: > > > > > On Wed, Aug 10, 2016 at 06:11:24PM +0200, Lluís Vilanova wrote: > > >> Daniel P Berrange writes: > > >> > > >> > On Wed, Aug

Re: [Qemu-devel] [PATCH for-2.8 v1 05/60] trace: add trace event iterator APIs

On Fri, Sep 02, 2016 at 04:52:18PM -0400, Stefan Hajnoczi wrote: > On Tue, Aug 09, 2016 at 04:31:33PM +0100, Daniel P. Berrange wrote: > > +TraceEvent *trace_event_iter_next(TraceEventIter *iter) > > +{ > > +TraceEvent *ev; > > + > > +if (iter->event >= TRACE_EVENT_COUNT) { > > +

Re: [Qemu-devel] [PATCH for-2.8 v1 11/60] trace: remove use of event ID enums from APIs

On Fri, Sep 02, 2016 at 05:13:48PM -0400, Stefan Hajnoczi wrote: > On Tue, Aug 09, 2016 at 06:26:49PM +0200, Paolo Bonzini wrote: > > > > > > On 09/08/2016 18:24, Daniel P. Berrange wrote: > > >>> > > -static inline TraceEventID trace_event_get_id(TraceEvent *ev) > > >>> > > +static inline

Re: [Qemu-devel] [PATCH 00/11] block: Remove BB interface from blockdev-add/del

Am 23.08.2016 um 19:01 hat Kevin Wolf geschrieben: > This series makes the next step towards a QAPI interface that doesn't require > clients to know about BlockBackends. By removing the support for 'id' from > blockdev-add, it becomes a command that always only creates a BDS (with a node > name).

[Qemu-devel] [PATCH] MAINTAINERS: add sPAPR tests

Signed-off-by: Greg Kurz --- MAINTAINERS |4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 13b882ba01ce..6552ccde3ee1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -625,6 +625,10 @@ F: pc-bios/spapr-rtas.bin F: pc-bios/slof.bin F:

Re: [Qemu-devel] [RFC PATCH v1 10/22] sev: add SEV debug decrypt command

On Wed, Sep 14, 2016 at 03:07:58PM +0200, Paolo Bonzini wrote: > > > On 14/09/2016 15:05, Michael S. Tsirkin wrote: > > I assumed that with debug on, memory is still encrypted but the > > hypervisor can break encryption, and as the cover letter states, the > > hypervisor is assumed benign. If

Re: [Qemu-devel] [RFC PATCH v1 10/22] sev: add SEV debug decrypt command

On Wed, Sep 14, 2016 at 04:32:44PM +0300, Michael S. Tsirkin wrote: > On Wed, Sep 14, 2016 at 02:23:14PM +0100, Daniel P. Berrange wrote: > > On Wed, Sep 14, 2016 at 03:07:58PM +0200, Paolo Bonzini wrote: > > > > > > > > > On 14/09/2016 15:05, Michael S. Tsirkin wrote: > > > > I assumed that

Re: [Qemu-devel] [RFC PATCH v1 10/22] sev: add SEV debug decrypt command

On Wed, Sep 14, 2016 at 08:36:50AM -0500, Brijesh Singh wrote: > On 09/13/2016 09:28 PM, Michael S. Tsirkin wrote: > > On Tue, Sep 13, 2016 at 10:48:27AM -0400, Brijesh Singh wrote: > > > The SEV DEBUG_DECRYPT command is used for decrypting a guest memory > > > for the debugging purposes. Note

Re: [Qemu-devel] [RFC PATCH v1 06/22] sev: add initial SEV support

On Wed, Sep 14, 2016 at 09:30:51AM +0100, Daniel P. Berrange wrote: > On Tue, Sep 13, 2016 at 07:00:44PM -0300, Eduardo Habkost wrote: > > (CCing Daniel Berrange in case he has feedback on the > > nonce/dh_pub_qx/dh_pub_qy loading/parsing at the end of this > > message) > > > > On Tue, Sep 13,

Re: [Qemu-devel] [RFC PATCH v1 20/22] fw_cfg: sev: disable dma in real mode

On Wed, Sep 14, 2016 at 03:01:51PM +0200, Paolo Bonzini wrote: > > > On 14/09/2016 14:09, Eduardo Habkost wrote: > > On Wed, Sep 14, 2016 at 05:33:09AM +0300, Michael S. Tsirkin wrote: > >> On Wed, Sep 14, 2016 at 12:53:36AM +0200, Paolo Bonzini wrote: > >>> > >>> > >>> On 13/09/2016 16:50,

Re: [Qemu-devel] [PATCH v2] virtio_pci: Limit DMA mask to 44 bits for legacy virtio devices

On Wed, Sep 14, 2016 at 03:07:58PM +0200, Paolo Bonzini wrote: > > > On 14/09/2016 15:05, Michael S. Tsirkin wrote: > > I assumed that with debug on, memory is still encrypted but the > > hypervisor can break encryption, and as the cover letter states, the > > hypervisor is assumed benign. If

[Qemu-devel] [Bug 1536487] Re: Unable to migrate pc-i440fx-2.4 KVM guest from QEMU 2.5.0 to QEMU 2.4.1

Hi Serge I agree to "created on xenial -> migrating to trusty" not being supported. I already tended to even say "created on xenial with the Trusty machine type -> migrating to trusty" is not supported as well (at least it is failing for all combos I tried. But I wonder how far "anything

Re: [Qemu-devel] [PATCH v3 24/34] target-i386: remove helper_lock()

Richard Henderson writes: > From: "Emilio G. Cota" > > It's been superseded by the atomic helpers. > > The use of the atomic helpers provides a significant performance and > scalability > improvement. Below is the result of running the atomic_add-test >

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

Daniel P Berrange writes: > On Fri, Sep 09, 2016 at 03:16:50PM +0200, Lluís Vilanova wrote: >> > The various _DSTATE variables are still arbitrarily scattered in >> > memory, as opposed to in a contiguous cache friendly array, which >> > is one of the goals of Paolo's original change. >> >> >

Re: [Qemu-devel] [RFC PATCH v1 10/22] sev: add SEV debug decrypt command

On Wed, Sep 14, 2016 at 02:37:49PM +0100, Daniel P. Berrange wrote: > On Wed, Sep 14, 2016 at 04:32:44PM +0300, Michael S. Tsirkin wrote: > > On Wed, Sep 14, 2016 at 02:23:14PM +0100, Daniel P. Berrange wrote: > > > On Wed, Sep 14, 2016 at 03:07:58PM +0200, Paolo Bonzini wrote: > > > > > > > > >

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 0/3] tests: add RTAS protocol

On Wed, Sep 14, 2016 at 11:07:59AM +0200, Greg Kurz wrote: > On Wed, 14 Sep 2016 13:23:37 +1000 > David Gibson wrote: > > > On Tue, Sep 13, 2016 at 02:52:42PM +0200, Laurent Vivier wrote: > > > This series allows to call RTAS commands from the qtest framework, > > >

Re: [Qemu-devel] [PATCH v4 2/3] memory: introduce IOMMUOps.notify_flag_changed

On Wed, Sep 14, 2016 at 03:49:41PM +0800, Peter Xu wrote: > On Wed, Sep 14, 2016 at 05:22:40PM +1000, David Gibson wrote: > > On Wed, Sep 14, 2016 at 03:12:43PM +0800, Peter Xu wrote: > > > On Wed, Sep 14, 2016 at 03:55:28PM +1000, David Gibson wrote: > > > > > > [...] > > > > > > > > -static

Re: [Qemu-devel] [PATCH] qemu-char: avoid segfault if user lacks of permisson of a given logfile

On 14/09/2016 08:22, Lin Ma wrote: > Function qemu_chr_alloc returns NULL if it failed to open logfile by any > reason, > says no write permission. For backends tty, stdio and msmouse, They need to > check this return value to avoid segfault in this case. > > Signed-off-by: Lin Ma

Re: [Qemu-devel] [PATCH 1/2] pc: fix regression introduced by adding 2.8 machine

On 09/14/2016 01:01 PM, Igor Mammedov wrote: commit (a4d3c834 pc: Add 2.8 machine) didn't ammend PC_COMPAT_2_6 to include PC_COMPAT_2_7 which results in {\ .driver = "virtio-pci",\ .property = "page-per-vq",\ .value= "on",\ }, and {\ .driver

Re: [Qemu-devel] [RFC PATCH v1 06/22] sev: add initial SEV support

On Wed, Sep 14, 2016 at 08:54:12AM -0300, Eduardo Habkost wrote: > On Wed, Sep 14, 2016 at 09:30:51AM +0100, Daniel P. Berrange wrote: > > On Tue, Sep 13, 2016 at 07:00:44PM -0300, Eduardo Habkost wrote: > > > (CCing Daniel Berrange in case he has feedback on the > > > nonce/dh_pub_qx/dh_pub_qy

Re: [Qemu-devel] [RFC PATCH v1 20/22] fw_cfg: sev: disable dma in real mode

On 14/09/2016 14:09, Eduardo Habkost wrote: > On Wed, Sep 14, 2016 at 05:33:09AM +0300, Michael S. Tsirkin wrote: >> On Wed, Sep 14, 2016 at 12:53:36AM +0200, Paolo Bonzini wrote: >>> >>> >>> On 13/09/2016 16:50, Brijesh Singh wrote: In SEV-enabled guest dma should be performed on shared

Re: [Qemu-devel] [RFC PATCH v1 10/22] sev: add SEV debug decrypt command

On 14/09/2016 15:05, Michael S. Tsirkin wrote: > I assumed that with debug on, memory is still encrypted but the > hypervisor can break encryption, and as the cover letter states, the > hypervisor is assumed benign. If true I don't see a need to > give users more rope. The hypervisor is assumed

[Qemu-devel] [Bug 1618431] Re: windows hangs after live migration with virtio

I can reproduce this bug also on Ubuntu 16.04 with libvirt. The interesting thing is that this bug triggers faster, if I use tunneled migration instead direct. Using the virt-manager for migration. The test VM is a Win10 with virtio driver from fedora 0.1.118. win10-1

Re: [Qemu-devel] [PATCH v2 4/6] hypertrace: [softmmu] Add QEMU-side proxy to "guest_hypertrace" event

On Tue, Sep 06, 2016 at 04:43:00AM +0300, Michael S. Tsirkin wrote: > On Mon, Sep 05, 2016 at 08:56:44PM +0200, Lluís Vilanova wrote: > > diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h > > index 929ec2f..8973f57 100644 > > --- a/include/hw/pci/pci.h > > +++ b/include/hw/pci/pci.h > > @@

Re: [Qemu-devel] [PATCH v11 5/6] qapi: add a QmpInputVisitor that does string conversion

Am 05.09.2016 um 17:16 hat Daniel P. Berrange geschrieben: > Currently the QmpInputVisitor assumes that all scalar > values are directly represented as their final types. > ie it assumes an 'int' is using QInt, and a 'bool' is > using QBool. > > This adds an alternative constructor for

[Qemu-devel] [Bug 1589923] Re: https websockets not working in 2.5 or 2.6

Fixed in stable-2.6 branch in commit 510531ea442a02048b1837fcf574d03559b38c9e Author: Daniel P. Berrange Date: Tue Jun 7 12:27:51 2016 +0100 io: remove mistaken call to object_ref on QTask The QTask struct is just a standalone struct, not a QOM Object, so

Re: [Qemu-devel] [PATCH] MAINTAINERS: add virtio-* tests

On Fri, Sep 09, 2016 at 10:31:20AM +0200, Greg Kurz wrote: > Except virtio-9p, all virtio-* tests are orphan. This patch tries to fix > it, according to the following logic: > > - when the related subsystem has its own section in MAINTAINERS, the test > is added there > - otherwise it is added

[Qemu-devel] [PATCH v4 01/11] linux-user: Add support for adjtimex() syscall

From: Aleksandar Markovic This patch implements Qemu user mode adjtimex() syscall support. Syscall adjtimex() reads and optionally sets parameters for a clock adjustment algorithm used in network synchonization or similar scenarios. The implementation is based

Re: [Qemu-devel] [PATCH] pc: apic: fix touch LAPIC when irqchip is split

2016-09-14 16:02+0200, Radim Krčmář: > Reviewed-by: Radim Krčmář > > (The code is horribly tangled, so I might have missed something.) This reply should have went for the v2, sorry.

Re: [Qemu-devel] [RFC PATCH v1 10/22] sev: add SEV debug decrypt command

On Wed, Sep 14, 2016 at 04:50:51PM +0300, Michael S. Tsirkin wrote: > On Wed, Sep 14, 2016 at 02:37:49PM +0100, Daniel P. Berrange wrote: > > On Wed, Sep 14, 2016 at 04:32:44PM +0300, Michael S. Tsirkin wrote: > > > On Wed, Sep 14, 2016 at 02:23:14PM +0100, Daniel P. Berrange wrote: > > > > On

Re: [Qemu-devel] [PATCH qemu v2] tap: Allow specifying a bridge

On Tue, 13 Sep 2016 17:11:54 +1000 Alexey Kardashevskiy wrote: > The tap backend is already using qemu-bridge-helper to attach tap > interface to a bridge but (unlike the bridge backend) it always uses > the default bridge name - br0. > > This adds a "br" property support to the

Re: [Qemu-devel] [PULL 54/64] hw/ppc: add a ppc_create_page_sizes_prop() helper routine

On 09/14/2016 03:59 PM, Alex Bennée wrote: > > David Gibson writes: > >> From: Cédric Le Goater >> >> The exact same routine will be used in PowerNV. >> >> Signed-off-by: Cédric Le Goater >> Signed-off-by: David Gibson

Re: [Qemu-devel] [PATCH v11 0/6] QAPI/QOM work for non-scalar object properties

Am 05.09.2016 um 17:16 hat Daniel P. Berrange geschrieben: > This patch series contains only the QAPI/QOM bits of my previous > access control patch series: > > v1: https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg04618.html > v2:

Re: [Qemu-devel] [PATCH V2 2/2] arm: virt: add PMU property to machvirt machine type

On 09/14/2016 03:37 AM, Andrew Jones wrote: > On Wed, Sep 14, 2016 at 02:09:03AM -0400, Wei Huang wrote: >> CPU vPMU is now turned off by default, but it was ON in virt-2.7 >> machine type. To solve this problem, this patch adds a PMU option >> in machine state, which is used to control CPU's

Re: [Qemu-devel] [PATCH qemu v2] tap: Allow specifying a bridge

On 09/14/2016 09:17 AM, Greg Kurz wrote: > On Tue, 13 Sep 2016 17:11:54 +1000 > Alexey Kardashevskiy wrote: > >> The tap backend is already using qemu-bridge-helper to attach tap >> interface to a bridge but (unlike the bridge backend) it always uses >> the default bridge name -

[Qemu-devel] [PATCH v4 11/11] linux-user: Remove a duplicate item from strace.list

From: Aleksandar Markovic There is a duplicate item in strace.list. It is benign, but it shouldn't be there. It is the only duplicate in strace.list. This patch removes it. Signed-off-by: Aleksandar Markovic ---

[Qemu-devel] [PATCH 2/7] block: Set BDRV_O_ALLOW_RDWR and snapshot_options before storing the flags

If an image is opened with snapshot=on, its flags are modified by bdrv_backing_options() and then bs->open_flags is updated accordingly. This last step is unnecessary if we calculate the new flags before setting bs->open_flags. Soon we'll introduce the "read-only" option, and then we'll need to

Re: [Qemu-devel] qemu 2.7.0 incompatible with host kernel < 3.19

On 9/14/2016 12:35 AM, Michael S. Tsirkin wrote: On Tue, Sep 13, 2016 at 11:09:27PM +0200, Laszlo Ersek wrote: Hi, (CC Michael and Cornelia,) On 09/13/16 21:10, Brian Rak wrote: I have some KVM hosts that I just upgraded to qemu 2.7.0. When the host is running a kernel newer then 3.19,

Re: [Qemu-devel] [PATCH qemu v2] tap: Allow specifying a bridge

On 09/13/2016 11:23 PM, Alexey Kardashevskiy wrote: >>> >>> Also, we don't have to abbreviate; 'bridge-name' may be easier to >>> understand than 'br', as well as a mention of the default value if the >>> parameter is not supplied. > > > The existing NetdevBridgeOptions does not do this in json

[Qemu-devel] [PATCH 0/2] improve aio_poll performance

This patchset change to check epoll's enablement first before nodes iteration to improve aio_poll()'s performance. Also fix a wrong comment of mirror_start(). Yaowei Bai (2): block: mirror: fix wrong comment of mirror_start aio: improve aio_poll performance by checking epoll only once

Re: [Qemu-devel] [PATCH v1] log: fix parsing of multiple trace:PATTERN log args

On Tue, Sep 06, 2016 at 08:56:16PM +0200, Paolo Bonzini wrote: > Stefan, is util/log.c part of tracing or not?!? :) No. Stefan signature.asc Description: PGP signature

Re: [Qemu-devel] [RFC PATCH v1 10/22] sev: add SEV debug decrypt command

On Wed, Sep 14, 2016 at 11:08:45AM -0300, Eduardo Habkost wrote: > On Wed, Sep 14, 2016 at 04:50:51PM +0300, Michael S. Tsirkin wrote: > > On Wed, Sep 14, 2016 at 02:37:49PM +0100, Daniel P. Berrange wrote: > > > On Wed, Sep 14, 2016 at 04:32:44PM +0300, Michael S. Tsirkin wrote: > > > > On Wed,

[Qemu-devel] [PATCH v4 05/11] linux-user: Fix msgrcv() and msgsnd() syscalls support

From: Aleksandar Markovic If syscalls msgrcv() and msgsnd() fail, they return E2BIG, EACCES, EAGAIN, EFAULT, EIDRM, EINTR, EINVAL, ENOMEM, or ENOMSG. By examining negative scenarios of these syscalls for Mips, it was established that ENOMSG does not have the same

Re: [Qemu-devel] [PATCH v3 26/34] target-arm: Rearrange aa32 load and store functions

Richard Henderson writes: > Stop specializing on TARGET_LONG_BITS == 32; unconditionally allocate > a temp and expand with tcg_gen_extu_i32_tl. Split out gen_aa32_addr, > gen_aa32_frob64, gen_aa32_ld_i32 and gen_aa32_st_i32 as separate interfaces. > > Signed-off-by: Richard

Re: [Qemu-devel] [PATCH v2] pc: apic: fix touch LAPIC when irqchip is split

2016-09-14 13:54+0800, Wanpeng Li: > From: Wanpeng Li > > Add -kernel_irqchip=split > ./x86-run x86/eventinj.flat > > qemu-system-x86_64 -enable-kvm -machine kernel_irqchip=split -cpu host > -device pc-testdev -device isa-debug-exit,iobase=0xf4,iosize=0x4 -vnc > none

Re: [Qemu-devel] [PATCH v2] scripts: Add a script to check for bug URLs in the git log

On 09/14/2016 05:35 AM, Thomas Huth wrote: > Erik, It's Eric, but don't sweat it (you're not the first, and probably not the last, to typo names) +while [ $# -ge 1 ]; do + case "$1" in +-s) START="$2" ; shift ;; >>> >>> POSIX recommends that short options with arguments be

Re: [Qemu-devel] [PULL 00/64] ppc-for-2.8 queue 20160907

On 14/09/2016 16:00, Alex Bennée wrote: > For reference this has broken 32 bit x86 builds on CentOS6. I bisected > the problem to: > > commit 3654fa95bc29e72c2eef22f26eb621af1f86feec > Author: Cédric Le Goater > Date: Tue Aug 2 19:38:01 2016 +0200 > >

Re: [Qemu-devel] proposed release timetable for 2.8

On Mon, Sep 05, 2016 at 04:11:43PM +0100, Peter Maydell wrote: > On 5 September 2016 at 15:47, Paolo Bonzini wrote: > > Based also on the discussion at QEMU summit, where there was consensus > > that three weeks between softfreeze and rc0 was too much, IMO we can > > shorten

Re: [Qemu-devel] [RFC PATCH v1 10/22] sev: add SEV debug decrypt command

On 14/09/2016 15:48, Michael S. Tsirkin wrote: >> One of the bit in policy field is "debugging", if this bit is set then >> hypervisor can use SEV commands to decrypt a guest memory > > That is my point. Arbitrary code execution in hypervisor means game over > anyway, at least with the hardware

Re: [Qemu-devel] [PATCH v4 0/3] block: Fix libbz2 library dependency regresssion

On Mon, Sep 05, 2016 at 10:50:42AM +0800, Fam Zheng wrote: > v4: Remove unused variable in patch 1 and unwanted warning in patch 2. [Max] > > v3: Fix typo in copyright header. [Max] > Fix pre-existing type casting. [Max] > > v2: Rebase on top of Max's block-next tree, which has Colin's

Re: [Qemu-devel] [RFC PATCH v1 10/22] sev: add SEV debug decrypt command

On Wed, Sep 14, 2016 at 03:15:07PM +0100, Daniel P. Berrange wrote: > On Wed, Sep 14, 2016 at 04:50:51PM +0300, Michael S. Tsirkin wrote: > > On Wed, Sep 14, 2016 at 02:37:49PM +0100, Daniel P. Berrange wrote: > > > On Wed, Sep 14, 2016 at 04:32:44PM +0300, Michael S. Tsirkin wrote: > > > > On

Re: [Qemu-devel] [PATCH v5] migrate: Move max-bandwidth and downtime-limit to migrate_set_parameter

>> +++ b/migration/migration.c >> @@ -44,6 +44,10 @@ >> #define BUFFER_DELAY 100 >> #define XFER_LIMIT_RATIO (1000 / BUFFER_DELAY) >> >> +/* Time in nanoseconds we are allowed to stop the source, >> + * for sending the last part */ >> +#define DEFAULT_MIGRATE_SET_DOWNTIME 3 >> + > >

[Qemu-devel] [Bug 1599214] Re: virtlogd: qemu 2.6.0 doesn't log boot message

Fix in 2.7.0 release thanks to commit bce6261eb2d879625126485d4ddd28cacb93152e Author: Daniel P. Berrange Date: Wed Aug 3 17:22:36 2016 +0100 virtio-console: set frontend open permanently for console devs The virtio-console.c file handles both serial consoles

[Qemu-devel] [PATCH v4 10/11] linux-user: Improve usage of spaces in linux-user/main.c

From: Aleksandar Markovic This patch removes all spaces-related errors (reported by checkpatch.pl) from linux-user/main.c. Signed-off-by: Aleksandar Markovic --- linux-user/main.c | 96

[Qemu-devel] [PATCH v4 03/11] linux-user: Add support for sysfs() syscall

From: Aleksandar Markovic This patch implements Qemu user mode sysfs() syscall support. Syscall sysfs() involves returning information about the filesystem types currently present in the kernel, and can operate in three distinct flavors, depending on its first

[Qemu-devel] [PATCH 6/7] commit: Add 'base' to the reopen queue before 'overlay_bs'

Now that we're checking for duplicates in the reopen queue, there's no need to force a specific order in which the queue is constructed so we can revert 3db2bd5508c86a1605258bc77c9672d93b5c350e. Since both ways of constructing the queue are now valid, this patch doesn't have any effect on the

Re: [Qemu-devel] [PATCH v5] cutils: Rewrite x86 buffer zero checking

On 09/14/2016 01:56 AM, Paolo Bonzini wrote: >> I was hoping to avoid an extra RELATIVE relocation in the (normal) PIE >> case. > > There would be no relocation for 0 and NULL, right? GCC would actually > put them in bss, IIRC. Ah, I now see your complaint. You'd prefer "type var = INIT" over

Re: [Qemu-devel] [Bug 1536487] Re: Unable to migrate pc-i440fx-2.4 KVM guest from QEMU 2.5.0 to QEMU 2.4.1

You might ask on #virt for the opinion there, but I don't believe migrating backward is supported in any case. t->x->t doesn't change the fact that there is x->t. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH v11 2/6] option: make parse_option_bool/number non-static

Am 05.09.2016 um 17:16 hat Daniel P. Berrange geschrieben: > The opts-visitor.c opts_type_bool() method has code for > parsing a string to set a bool value, as does the > qemu-option.c parse_option_bool() method, except it > handles fewer cases. > > To enable consistency across the codebase,

Re: [Qemu-devel] [RFC PATCH v1 10/22] sev: add SEV debug decrypt command

On Wed, Sep 14, 2016 at 04:14:04PM +0200, Paolo Bonzini wrote: > > > On 14/09/2016 16:08, Eduardo Habkost wrote: > >> > If attacker can trigger things, IOW execute code in hypervisor, > >> > then encrypting memory is not useful anyway. > > I believe the whole point of SEV attestation and key

Re: [Qemu-devel] [PATCH v4 0/3] block: Fix libbz2 library dependency regresssion

On 2016-09-14 at 16:35, Stefan Hajnoczi wrote: On Mon, Sep 05, 2016 at 10:50:42AM +0800, Fam Zheng wrote: v4: Remove unused variable in patch 1 and unwanted warning in patch 2. [Max] v3: Fix typo in copyright header. [Max] Fix pre-existing type casting. [Max] v2: Rebase on top of Max's

[Qemu-devel] [PATCH v4 00/11] linux user: Fix assorted Qemu user mode issues

From: Aleksandar Markovic v3->v4: - rebased to the latest code - added patch on clock_adjtime() support - minor commit messages improvements v2->v3: - rebased to the latest code - merged patches on adjtimex(), sysfs(), and ustat() from

Re: [Qemu-devel] [PATCH 0/3] iscsi: add -drive ..., iscsi= parameter

On Thu, Sep 08, 2016 at 09:14:10AM +0100, Daniel P. Berrange wrote: > On Wed, Sep 07, 2016 at 05:23:09PM -0400, Stefan Hajnoczi wrote: > > Add a parameter to associate an iSCSI block driver instance with an -iscsi > > object. This is more powerful than relying on the implicit target IQN > >

[Qemu-devel] [PATCH v4 04/11] linux-user: Add support for ustat() syscall

From: Aleksandar Markovic This patch implements Qemu user mode ustat() syscall support. Syscall ustat() returns information about a mounted filesystem. The implementation is similar to the implementations of statfs(), fstatfs() and other related syscalls. It is

Re: [Qemu-devel] [RFC PATCH v1 10/22] sev: add SEV debug decrypt command

On Wed, Sep 14, 2016 at 04:06:33PM +0100, Daniel P. Berrange wrote: > On Wed, Sep 14, 2016 at 05:48:17PM +0300, Michael S. Tsirkin wrote: > > On Wed, Sep 14, 2016 at 03:15:07PM +0100, Daniel P. Berrange wrote: > > > On Wed, Sep 14, 2016 at 04:50:51PM +0300, Michael S. Tsirkin wrote: > > > > On

Re: [Qemu-devel] [PULL 54/64] hw/ppc: add a ppc_create_page_sizes_prop() helper routine

David Gibson writes: > From: Cédric Le Goater > > The exact same routine will be used in PowerNV. > > Signed-off-by: Cédric Le Goater > Signed-off-by: David Gibson This patch has broken 32 bit x86 builds

Re: [Qemu-devel] [PATCH v5] migrate: Move max-bandwidth and downtime-limit to migrate_set_parameter

On 09/14/2016 03:05 AM, Ashijeet Acharya wrote: >>> +if (params->has_max_bandwidth && >>> +(params->max_bandwidth < 0 || params->max_bandwidth > SIZE_MAX)) { >>> +error_setg(errp, QERR_INVALID_PARAMETER_VALUE, >>> + "max_bandwidth", >>> +

[Qemu-devel] [PATCH 1/2] block: mirror: fix wrong comment of mirror_start

Obviously, we should write to '@target'. Signed-off-by: Yaowei Bai Reviewed-by: Xiubo Li --- include/block/block_int.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/block/block_int.h

Re: [Qemu-devel] [PATCH] pc: apic: fix touch LAPIC when irqchip is split

2016-09-14 11:04+0800, Wanpeng Li: > From: Wanpeng Li > > Add -kernel_irqchip=split > ./x86-run x86/eventinj.flat > > qemu-system-x86_64 -enable-kvm -machine kernel_irqchip=split -cpu host > -device pc-testdev -device isa-debug-exit,iobase=0xf4,iosize=0x4 -vnc > none

Re: [Qemu-devel] [PATCH 7/9] target-cris: ignore prefix insns in singlestep

> Date: Tue, 13 Sep 2016 00:49:51 +0200 > From: "Edgar E. Iglesias" > On Mon, Sep 05, 2016 at 01:54:10PM +0200, Rabin Vincent wrote: > > From: Hans-Peter Nilsson > > > > Don't count prefix instructions as separate when singlestepping. > > > > For

Re: [Qemu-devel] [PULL 00/64] ppc-for-2.8 queue 20160907

Peter Maydell writes: > On 7 September 2016 at 11:28, David Gibson > wrote: >> The following changes since commit 2926375cffce464fde6b4dabaed1e133d549af39: >> >> Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into >>

Re: [Qemu-devel] [PATCH 1/2] trace: Add "cpu_init" event

On Tue, Sep 06, 2016 at 04:25:53PM +0200, Lluís Vilanova wrote: > +## vCPU > + > +# Create a new virtual (guest) CPU > +# > +# Targets: all > +guest_cpu_init(void *cpu) "cpu=%p" This isn't a vcpu trace event. Please add keep it with the other non-vcpu trace events: # cpus.c guest_cpu_init(void

Re: [Qemu-devel] [PATCH v5] migrate: Move max-bandwidth and downtime-limit to migrate_set_parameter

On Wed, Sep 14, 2016 at 7:28 PM, Eric Blake wrote: > On 09/14/2016 03:05 AM, Ashijeet Acharya wrote: > +if (params->has_max_bandwidth && +(params->max_bandwidth < 0 || params->max_bandwidth > SIZE_MAX)) { +error_setg(errp,

Re: [Qemu-devel] [PULL 54/64] hw/ppc: add a ppc_create_page_sizes_prop() helper routine

On 09/14/2016 04:33 PM, Cédric Le Goater wrote: > On 09/14/2016 03:59 PM, Alex Bennée wrote: >> >> David Gibson writes: >> >>> From: Cédric Le Goater >>> >>> The exact same routine will be used in PowerNV. >>> >>> Signed-off-by: Cédric Le Goater

Re: [Qemu-devel] [RFC PATCH v1 10/22] sev: add SEV debug decrypt command

On Wed, Sep 14, 2016 at 04:19:38PM +0200, Paolo Bonzini wrote: > > > On 14/09/2016 15:48, Michael S. Tsirkin wrote: > >> One of the bit in policy field is "debugging", if this bit is set then > >> hypervisor can use SEV commands to decrypt a guest memory > > > > That is my point. Arbitrary code

Re: [Qemu-devel] [PATCH for-2.8 v1 04/60] trace: move hw/virtio/virtio-balloon.c trace points into correct file

On Thu, Sep 08, 2016 at 01:09:01PM -0500, Eric Blake wrote: > On 08/09/2016 10:31 AM, Daniel P. Berrange wrote: > > The trace points for hw/virtio/virtio-balloon.c were mistakenly put > > in the top level trace-events file, instead of util/trace-events. > > Is it worth updating the commit

[Qemu-devel] [PATCH v4 08/11] linux-user: Remove tabs and trailing spaces from linux-user/main.c

From: Aleksandar Markovic File main.c is frequently a starting point of debugging or analysing Qemu code for novice devevelopers, and it would be nice if it had format as clean as posible. This patch starts improving its format by removing tabs and trailing

Re: [Qemu-devel] [PATCH] MAINTAINERS: add virtio-* tests

On Fri, Sep 09, 2016 at 10:31:20AM +0200, Greg Kurz wrote: > Except virtio-9p, all virtio-* tests are orphan. This patch tries to fix > it, according to the following logic: > > - when the related subsystem has its own section in MAINTAINERS, the test > is added there > - otherwise it is added

[Qemu-devel] [PATCH 3/7] block: Update bs->open_flags earlier in bdrv_open_common()

We're only doing this immediately before opening the image, but bs->open_flags is used earlier in the function. At the moment this is not causing problems because none of the checked flags are modified by update_flags_from_options(), but this will change when we introduce the "read-only" option.

[Qemu-devel] [PATCH 1/7] block: Remove bdrv_is_snapshot

This is unnecessary and has been unused since 5433c24f0f9306c82ad9bcc. Signed-off-by: Alberto Garcia --- block.c | 5 - include/block/block.h | 1 - 2 files changed, 6 deletions(-) diff --git a/block.c b/block.c index 66ed1c0..1c75a6f 100644 --- a/block.c

  1   2   3   4   5   >