[Qemu-devel] [PATCH v6 2/3] target-i386: x86_cpu_load_features() function

2016-10-07 Thread Eduardo Habkost
When probing for CPU model information, we need to reuse the code that initializes CPUID fields, but not the remaining side-effects of x86_cpu_realizefn(). Move that code to a separate function that can be reused later. Signed-off-by: Eduardo Habkost --- Changes v5 -> v6: *

[Qemu-devel] [PATCH v6 1/3] target-i386: Move warning code outside x86_cpu_filter_features()

2016-10-07 Thread Eduardo Habkost
x86_cpu_filter_features() will be reused by code that shouldn't print any warning. Move the warning code to a new x86_cpu_report_filtered_features() function, and call it from x86_cpu_realizefn(). Signed-off-by: Eduardo Habkost --- Changes v5 -> v6: * Recovered v3 of patch,

[Qemu-devel] [PATCH v6 0/3] Add runnability info to query-cpu-definitions

2016-10-07 Thread Eduardo Habkost
This series extends query-cpu-definitions to include an extra field: "unavailable-features". The new field can be used to find out reasons that prevent the CPU model from running in the current host. This will return information based on the current machine and accelerator only. In the future we

Re: [Qemu-devel] [PULL 00/20] Tracing patches

2016-10-07 Thread Peter Maydell
On 7 October 2016 at 11:09, Stefan Hajnoczi wrote: > The following changes since commit e902754e3d0890945ddcc1b33748ed73762ddb8d: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.8-20161006' > into staging (2016-10-06 13:34:00 +0100) > > are available in

Re: [Qemu-devel] [PULL 00/20] Tracing patches

2016-10-07 Thread Daniel P. Berrange
On Fri, Oct 07, 2016 at 02:22:38PM +0100, Peter Maydell wrote: > On 7 October 2016 at 11:09, Stefan Hajnoczi wrote: > > The following changes since commit e902754e3d0890945ddcc1b33748ed73762ddb8d: > > > > Merge remote-tracking branch

Re: [Qemu-devel] [PATCH v3] net: don't poke at chardev internal QemuOpts

2016-10-07 Thread Marc-André Lureau
Hi On Fri, Oct 7, 2016 at 4:18 PM Daniel P. Berrange wrote: > The vhost-user & colo code is poking at the QemuOpts instance > in the CharDriverState struct, not realizing that it is valid > for this to be NULL. e.g. the following crash shows a codepath > where it will be

Re: [Qemu-devel] [PATCH 1/9] target-mips: Add CP0_Ebase.WG (write gate) support

2016-10-07 Thread Yongbok Kim
On 06/09/2016 12:03, James Hogan wrote: > Add support for the CP0_EBase.WG bit, which allows upper bits to be > written (bits 31:30 on MIPS32, or bits 63:30 on MIPS64), along with the > CP0_Config5.CV bit to control whether the exception vector for Cache > Error exceptions is forced into KSeg1.

[Qemu-devel] [PULL 04/10] block: Add bdrv_runtime_opts to query-command-line-options

2016-10-07 Thread Kevin Wolf
Recently we moved a few options from QemuOptsLists in blockdev.c to bdrv_runtime_opts in block.c in order to make them accissble using blockdev-add. However, this has the side effect that these options are missing from query-command-line-options now, and libvirt consequently disables the

[Qemu-devel] [PULL 01/10] block: use bdrv_add_before_write_notifier

2016-10-07 Thread Kevin Wolf
From: Paolo Bonzini Register the notifier using the specific API for block devices. Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf

[Qemu-devel] [PULL 06/10] block-backend: Remember if attached device is non-qdev

2016-10-07 Thread Kevin Wolf
Almost all block devices are qdevified by now. This allows us to go back from the BlockBackend to the DeviceState. xen_disk is the last device that is missing. We'll remember in the BlockBackend if a xen_disk is attached and can then disable any features that require going from a BB to the

[Qemu-devel] [PULL 00/10] Block layer patches

2016-10-07 Thread Kevin Wolf
The following changes since commit e902754e3d0890945ddcc1b33748ed73762ddb8d: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.8-20161006' into staging (2016-10-06 13:34:00 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git block for you to fetch

[Qemu-devel] [PULL 03/10] block: use aio_bh_schedule_oneshot

2016-10-07 Thread Kevin Wolf
From: Paolo Bonzini This simplifies bottom half handlers by removing calls to qemu_bh_delete and thus removing the need to stash the bottom half pointer in the opaque datum. Signed-off-by: Paolo Bonzini Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PULL 05/10] block: Add node name to BLOCK_IO_ERROR event

2016-10-07 Thread Kevin Wolf
The event currently only contains the BlockBackend name. However, with anonymous BlockBackends, this is always the empty string. Add the node name so that the user can still see which block device caused the event. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz

Re: [Qemu-devel] [PULL 00/12] QAPI patches for 2016-10-07

2016-10-07 Thread Markus Armbruster
Peter Maydell writes: > On 7 October 2016 at 13:09, Markus Armbruster wrote: >> The following changes since commit a65b6f27ce65e2e4f771f69d549ffa455a4d543a: >> >> Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20161004' >> into

[Qemu-devel] [PULL v2 02/11] qapi: Fix crash when 'any' or 'null' parameter is missing

2016-10-07 Thread Markus Armbruster
From: Marc-André Lureau Unlike the other visit methods, visit_type_any() and visit_type_null() neglect to check whether qmp_input_get_object() succeeded. They crash when it fails. Reproducer: { "execute": "qom-set", "arguments": { "path": "/machine", "property":

[Qemu-devel] [PATCH v2 1/1] block: add gluster ifdef guard checks for SEEK_DATA/SEEK_HOLE support

2016-10-07 Thread Jeff Cody
Add checks to see if the system compiling QEMU has support for SEEK_HOLE/SEEK_DATA. If the system does not, we will flag that seek data is unsupported in gluster. Note: this is not a check on whether the gluster server itself supports SEEK_DATA (that is already done during runtime), but rather

Re: [Qemu-devel] [PATCH v2 1/1] block: add gluster ifdef guard checks for SEEK_DATA/SEEK_HOLE support

2016-10-07 Thread Eric Blake
On 10/07/2016 04:48 PM, Jeff Cody wrote: > Add checks to see if the system compiling QEMU has support for > SEEK_HOLE/SEEK_DATA. If the system does not, we will flag that seek > data is unsupported in gluster. > > Note: this is not a check on whether the gluster server itself supports >

[Qemu-devel] [PATCH 2/3] block: change drain to look only at one child at a time

2016-10-07 Thread Paolo Bonzini
bdrv_requests_pending is checking children to also wait until internal requests (such as metadata writes) have completed. However, checking children is in general overkill. Children requests can be of two kinds: - requests caused by an operation on bs, e.g. a bdrv_aio_write to bs causing a

[Qemu-devel] [PATCH 3/3] qed: Implement .bdrv_drain

2016-10-07 Thread Paolo Bonzini
From: Fam Zheng The "need_check_timer" is used to clear the "NEED_CHECK" flag in the image header after a grace period once metadata update has finished. To comply with the bdrv_drain semantics, we should make sure it remains deleted once .bdrv_drain is called. The change to

Re: [Qemu-devel] [PATCH v4 3/8] intel_iommu: pass whole remapped addresses to apic

2016-10-07 Thread Radim Krčmář
2016-10-07 15:05+0200, Igor Mammedov: > On Wed, 5 Oct 2016 15:06:52 +0200 > Radim Krčmář wrote: > >> The MMIO interface to APIC only allowed 8 bit addresses, which is not >> enough for 32 bit addresses from EIM remapping. >> Intel stored upper 24 bits in the high MSI

[Qemu-devel] [PULL 22/39] char: use a fixed idx for child muxed chr

2016-10-07 Thread Paolo Bonzini
From: Marc-André Lureau mux_chr_update_read_handler() is adding a new mux_cnt each time mux_chr_update_read_handler() is called, it's not possible to actually update the "child" chr callbacks that were set previously. This may lead to crashes if the "child" chr is

[Qemu-devel] [PULL 09/39] intc: make HMP 'info irq' and 'info pic' commands available on all targets

2016-10-07 Thread Paolo Bonzini
From: Hervé Poussineau Signed-off-by: Hervé Poussineau Message-Id: <1474921408-24710-7-git-send-email-hpous...@reactos.org> Signed-off-by: Paolo Bonzini --- hmp-commands-info.hx | 5 + 1 file changed, 1 insertion(+), 4

[Qemu-devel] [PULL 13/39] seqlock: use atomic writes for the sequence

2016-10-07 Thread Paolo Bonzini
There is a data race if the sequence is written concurrently to the read. In C11 this has undefined behavior. Use atomic_set; the read side is already using atomic_read. Reported-by: Alex Bennée Signed-off-by: Paolo Bonzini Signed-off-by: Alex

[Qemu-devel] [PULL 32/39] qemu-doc: drop installation and compilation notes

2016-10-07 Thread Paolo Bonzini
These are in README or obsolete, and the detailed version can be on a website instead. Reviewed-by: Emilio G. Cota Signed-off-by: Paolo Bonzini --- README| 2 - qemu-doc.texi | 249 -- 2

[Qemu-devel] [PULL 38/39] qemu-tech: rewrite some parts

2016-10-07 Thread Paolo Bonzini
Drop most the device emulation part and merge the rest into the description of the MMU. Make some bits more up-to-date. Reviewed-by: Emilio G. Cota Signed-off-by: Paolo Bonzini --- qemu-tech.texi | 124

[Qemu-devel] [PULL 37/39] qemu-tech: reorganize content

2016-10-07 Thread Paolo Bonzini
Split more parts into separate chapters, place comparison last, rename "Introduction" to "CPU emulation". Reviewed-by: Emilio G. Cota Signed-off-by: Paolo Bonzini --- qemu-tech.texi | 171 + 1 file

Re: [Qemu-devel] [PATCH] block: Remove "options" indirection from blockdev-add

2016-10-07 Thread Eric Blake
On 10/07/2016 10:38 AM, Kevin Wolf wrote: > Now that QAPI supports boxed types, we can have unions at the top level > of a command, so let's put our real options directly there for > blockdev-add instead of having a single "options" dict that contains the > real arguments. > > blockdev-add is

Re: [Qemu-devel] [PATCH 09/22] block: introduce persistent dirty bitmaps

2016-10-07 Thread Max Reitz
On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: > New field BdrvDirtyBitmap.persistent means, that bitmap should be saved > on bdrv_close, using format driver. Format driver should maintain bitmap > storing. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > ---

Re: [Qemu-devel] [PATCH 10/22] block/dirty-bitmap: add bdrv_dirty_bitmap_next()

2016-10-07 Thread Max Reitz
On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/dirty-bitmap.c | 7 +++ > include/block/dirty-bitmap.h | 3 +++ > 2 files changed, 10 insertions(+) Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH] block: Remove "options" indirection from blockdev-add

2016-10-07 Thread Max Reitz
On 07.10.2016 17:38, Kevin Wolf wrote: > Now that QAPI supports boxed types, we can have unions at the top level > of a command, so let's put our real options directly there for > blockdev-add instead of having a single "options" dict that contains the > real arguments. > > blockdev-add is still

Re: [Qemu-devel] [PATCH 3/9] target-mips: Decode EVA load & store instructions

2016-10-07 Thread James Hogan
On Fri, Oct 07, 2016 at 05:05:30PM +0100, Yongbok Kim wrote: > On 07/10/2016 16:48, James Hogan wrote: > > On Fri, Oct 07, 2016 at 04:34:27PM +0100, Yongbok Kim wrote: > >>> diff --git a/target-mips/translate.c b/target-mips/translate.c > >>> index df2befbd5294..8506c39a359c 100644 > >>> ---

[Qemu-devel] [PATCH 0/3] block: new bdrv_drain implementation

2016-10-07 Thread Paolo Bonzini
Another tiny bit from the multiqueue series. This takes care of reimplementing bdrv_drain to process each BDS in the tree in order. A side effect is to separate draining of data writes from draining of metadata writes, which allows us to reinstate QED's .bdrv_drain implementation. A couple words

Re: [Qemu-devel] [PATCH v4 01/20] ppc/pnv: add skeleton PowerNV platform

2016-10-07 Thread Jeff Cody
On Fri, Oct 07, 2016 at 09:38:07AM +0200, Cédric Le Goater wrote: > Hello, > > >> - removed the requirement on having a kernel loaded as running with > >>just a firmware is fine. We will need to discuss the inclusion of > >>the file skiboot.lid under qemu. > > > > Yes, this isn't

[Qemu-devel] [PULL 14/39] qom/object: update class cache atomically

2016-10-07 Thread Paolo Bonzini
From: Alex Bennée The idiom CPU_GET_CLASS(cpu) is fairly extensively used in various threads and trips of ThreadSanitizer due to the fact it updates obj->class->object_cast_cache behind the scenes. As this is just a fast-path cache there is no need to lock updates.

[Qemu-devel] [PULL 20/39] .travis.yml: add gcc sanitizer build

2016-10-07 Thread Paolo Bonzini
From: Alex Bennée As it seems easy to break the ThreadSanitizer build we should defend it to ensure that fixes get applied when it breaks. We use the Ubuntu GCC PPA to get the latest GCC goodness. As we need to use the -fuse-ld=gold work around we have to disable the

[Qemu-devel] [PULL 11/39] atomic.h: comment on use of atomic_read/set

2016-10-07 Thread Paolo Bonzini
From: Alex Bennée Add some notes on the use of the relaxed atomic access helpers and their importance for defined behaviour in C11's multi-threaded memory model. Signed-off-by: Alex Bennée Message-Id:

[Qemu-devel] [PULL 30/39] qemu-tech: drop index

2016-10-07 Thread Paolo Bonzini
Reviewed-by: Emilio G. Cota Signed-off-by: Paolo Bonzini --- qemu-tech.texi | 5 - 1 file changed, 5 deletions(-) diff --git a/qemu-tech.texi b/qemu-tech.texi index 1b048cb..be1c210 100644 --- a/qemu-tech.texi +++ b/qemu-tech.texi @@ -32,7 +32,6 @@ *

[Qemu-devel] [PULL 17/39] util/qht: atomically set b->hashes

2016-10-07 Thread Paolo Bonzini
From: Alex Bennée ThreadSanitizer detects a possible race between reading/writing the hashes. The ordering semantics are already documented for QHT however for true C11 compliance we should use relaxed atomic primitives for accesses that are done across threads. On x86

[Qemu-devel] [PULL 31/39] qemu-doc: replace introduction with the one from the internals manual

2016-10-07 Thread Paolo Bonzini
The user manual has an obsolete introduction, and the one in the internals manual lists QEMU's features quite nicely. Drop the obsolete content and remove generic user-level documentation from qemu-tech. Reviewed-by: Emilio G. Cota Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v5 4/6] migration: migrate QTAILQ

2016-10-07 Thread Dr. David Alan Gilbert
* Jianjun Duan (du...@linux.vnet.ibm.com) wrote: > > > On 10/07/2016 09:32 AM, Paolo Bonzini wrote: > > > > > > On 07/10/2016 18:31, Jianjun Duan wrote: > >> > >> > >> On 10/07/2016 07:34 AM, Dr. David Alan Gilbert wrote: > >>> * Paolo Bonzini (pbonz...@redhat.com) wrote: > > >

[Qemu-devel] [PULL 34/39] qemu-tech: document lazy condition code evaluation in cpu.h

2016-10-07 Thread Paolo Bonzini
Unlike the other sections, they are pretty specific to a particular CPU. Reviewed-by: Emilio G. Cota Signed-off-by: Paolo Bonzini --- qemu-tech.texi | 25 - target-cris/cpu.h | 7 +++ target-i386/cpu.h | 7 +++

[Qemu-devel] [PULL v2 03/11] tests/test-qmp-input-strict: Cover missing struct members

2016-10-07 Thread Markus Armbruster
These tests would have caught the bug fixed by the previous commit. Signed-off-by: Markus Armbruster Message-Id: <1475594630-24758-1-git-send-email-arm...@redhat.com> --- tests/test-qmp-input-strict.c | 46 +++ 1 file changed, 46

[Qemu-devel] [PULL v2 04/11] qapi: add assert about root value

2016-10-07 Thread Markus Armbruster
From: Marc-André Lureau qiv->root should not be null, make that clearer with some assert. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake Message-Id: <20160930095948.3154-2-marcandre.lur...@redhat.com>

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v5 3/6] migration: extend VMStateInfo

2016-10-07 Thread Jianjun Duan
On 10/07/2016 05:08 AM, Dr. David Alan Gilbert wrote: > * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >> Current migration code cannot handle some data structures such as >> QTAILQ in qemu/queue.h. Here we extend the signatures of put/get >> in VMStateInfo so that customized handling is

Re: [Qemu-devel] [PATCH 3/4] sockets: add AF_VSOCK support

2016-10-07 Thread Michael Roth
Quoting Stefan Hajnoczi (2016-10-06 11:40:17) > Add the AF_VSOCK address family so that qemu-ga will be able to use > virtio-vsock. > > The AF_VSOCK address family uses address tuples. The cid is > the unique identifier comparable to an IP address. AF_VSOCK does not > use name

[Qemu-devel] [PULL 12/39] tcg/optimize: move default return out of if statement

2016-10-07 Thread Paolo Bonzini
From: Alex Bennée This is to appease sanitizer builds which complain that: "error: control reaches end of non-void function" Signed-off-by: Alex Bennée Reviewed-by: Marc-André Lureau Message-Id:

[Qemu-devel] [PULL 08/39] intc: make HMP 'info irq' and 'info pic' commands use InterruptStatsProvider interface

2016-10-07 Thread Paolo Bonzini
From: Hervé Poussineau Signed-off-by: Hervé Poussineau Message-Id: <1474921408-24710-6-git-send-email-hpous...@reactos.org> Signed-off-by: Paolo Bonzini --- hmp-commands-info.hx | 12 - hmp.c |

[Qemu-devel] [PULL 25/39] qemu_kill_report: Report PID name too

2016-10-07 Thread Paolo Bonzini
From: Michal Privoznik When qemu is being killed, its last words are: 2016-08-31T11:48:15.293587Z qemu-system-x86_64: terminating on signal 15 from pid 11180 That's nice, but what process is 11180? What if I told you we can do better: 2016-08-31T11:48:15.293587Z

Re: [Qemu-devel] [PATCH 4/4] qga: add vsock-listen method

2016-10-07 Thread Michael Roth
Quoting Stefan Hajnoczi (2016-10-06 11:40:18) > Add AF_VSOCK (virtio-vsock) support as an alternative to virtio-serial. > > $ qemu-system-x86_64 -device vhost-vsock-pci,guest-cid=3 ... > (guest)# qemu-ga -m vsock-listen -p 3:1234 > > Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PULL 39/39] qemu-doc: merge qemu-tech and qemu-doc

2016-10-07 Thread Paolo Bonzini
Merge what is left of qemu-tech into the main manual as an appendix. Ultimately we should have a new internals manual built from docs/, and then the "Translator Internals" parts of qemu-tech could move to docs/ as well. The bits on limitation and features of CPU emulation should remain in

[Qemu-devel] [PULL 36/39] qemu-tech: move TCG test documentation to tests/tcg/README

2016-10-07 Thread Paolo Bonzini
Reviewed-by: Emilio G. Cota Signed-off-by: Paolo Bonzini --- qemu-tech.texi | 35 -- tests/tcg/README | 76 2 files changed, 76 insertions(+), 35 deletions(-) create mode

Re: [Qemu-devel] [QEMU PATCH v5 2/6] migration: spapr_drc: defined VMStateDescription struct

2016-10-07 Thread Jianjun Duan
On 10/06/2016 08:12 PM, David Gibson wrote: > On Mon, Oct 03, 2016 at 11:24:53AM -0700, Jianjun Duan wrote: >> To manage hotplug/unplug of dynamic resources such as PCI cards, >> memory, and CPU on sPAPR guests, a firmware abstraction known as >> a Dynamic Resource Connector (DRC) is used to

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v5 4/6] migration: migrate QTAILQ

2016-10-07 Thread Jianjun Duan
On 10/07/2016 10:34 AM, Dr. David Alan Gilbert wrote: > * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >> >> >> On 10/07/2016 09:32 AM, Paolo Bonzini wrote: >>> >>> >>> On 07/10/2016 18:31, Jianjun Duan wrote: On 10/07/2016 07:34 AM, Dr. David Alan Gilbert wrote: > * Paolo

[Qemu-devel] [PULL v2 07/11] MAINTAINERS: Pass the HMP staff from Luiz to David

2016-10-07 Thread Markus Armbruster
David graciously volunteered to take this off Luiz's hands. Signed-off-by: Markus Armbruster Message-Id: <1475084022-30117-2-git-send-email-arm...@redhat.com> Reviewed-by: Dr. David Alan Gilbert Acked-by: Luiz Capitulino ---

Re: [Qemu-devel] [PULL 00/20] Tracing patches

2016-10-07 Thread Peter Maydell
On 7 October 2016 at 14:46, Lluís Vilanova wrote: > diff --git a/qom/cpu.c b/qom/cpu.c > index 484c493..40f2eb1 100644 > --- a/qom/cpu.c > +++ b/qom/cpu.c > @@ -356,12 +356,15 @@ static void cpu_common_initfn(Object *obj) > qemu_mutex_init(>work_mutex); >

Re: [Qemu-devel] [PATCH v3] timer: a9gtimer: remove loop to auto-increment comparator

2016-10-07 Thread Peter Maydell
On 3 October 2016 at 10:04, P J P wrote: > From: Prasad J Pandit > > ARM A9MP processor has a peripheral timer with an auto-increment > register, which holds an increment step value. A user could set > this value to zero. When auto-increment control

Re: [Qemu-devel] [PATCH 1/5] target-tricore: Added FTOUZ instruction

2016-10-07 Thread Richard Henderson
On 10/06/2016 09:20 AM, Bastian Koppelmann wrote: +if (!float32_eq(f_arg, make_float32(result), >fp_status)) { This is comparing a float (f_arg) with an integer (result), forced to be interpreted as a float. r~

[Qemu-devel] [PULL 23/39] char: update read handler in all cases

2016-10-07 Thread Paolo Bonzini
From: Marc-André Lureau In commit ac1b84dd1 (rhbz#1027181), a check was added to only update the "read handler" when the front-end is opened, because the read callbacks were not restored when a device is plugged. However, this seems not correct, the handler is

[Qemu-devel] [PULL 27/39] qht: simplify qht_reset_size

2016-10-07 Thread Paolo Bonzini
From: "Emilio G. Cota" Sometimes gcc doesn't pick up the fact that 'new' is properly set if 'resize == true', which may generate an unnecessary build warning. Fix it by removing 'resize' and directly checking that 'new' is non-NULL. Signed-off-by: Emilio G. Cota

[Qemu-devel] [PULL 33/39] qemu-tech: move text from qemu-tech to tcg/README

2016-10-07 Thread Paolo Bonzini
Reviewed-by: Emilio G. Cota Signed-off-by: Paolo Bonzini --- qemu-tech.texi | 12 ++-- tcg/README | 5 + 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/qemu-tech.texi b/qemu-tech.texi index 2ab7cd4..082b62c 100644 ---

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v5 4/6] migration: migrate QTAILQ

2016-10-07 Thread Paolo Bonzini
On 07/10/2016 18:31, Jianjun Duan wrote: > > > On 10/07/2016 07:34 AM, Dr. David Alan Gilbert wrote: >> * Paolo Bonzini (pbonz...@redhat.com) wrote: >>> >>> >>> On 06/10/2016 21:01, Dr. David Alan Gilbert wrote: >>> +} else if (field->flags & VMS_LINKED) { >>> +

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v5 4/6] migration: migrate QTAILQ

2016-10-07 Thread Jianjun Duan
On 10/07/2016 07:34 AM, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: >> >> >> On 06/10/2016 21:01, Dr. David Alan Gilbert wrote: >> +} else if (field->flags & VMS_LINKED) { >> +ret = field->info->get(f, addr, size,

Re: [Qemu-devel] [PATCH v3 3/5] tests: use qtest_pc_boot()/qtest_shutdown() in virtio tests

2016-10-07 Thread Greg Kurz
On Sat, 1 Oct 2016 20:56:02 +0200 Laurent Vivier wrote: > This patch replaces calls to qtest_start() and qtest_end() by > calls to qtest_pc_boot() and qtest_shutdown(). > > This allows to initialize memory allocator and PCI interface > functions. This will ease to enable

Re: [Qemu-devel] [PATCH 2/4] qga: drop unnecessary GA_CHANNEL_UNIX_LISTEN checks

2016-10-07 Thread Michael Roth
Quoting Stefan Hajnoczi (2016-10-06 11:40:16) > Throughout the code there are c->listen_channel checks which manage the > listen socket file descriptor (waiting for accept(2), closing the file > descriptor, etc). These checks are currently preceded by explicit > c->method ==

Re: [Qemu-devel] [PATCH 1/4] qga: drop unused sockaddr in accept(2) call

2016-10-07 Thread Michael Roth
Quoting Stefan Hajnoczi (2016-10-06 11:40:15) > ga_channel_listen_accept() is currently hard-coded to support only > AF_UNIX because the struct sockaddr_un type is used. This function > should work with any address family. > > Drop the sockaddr since the client address is unused and is an

[Qemu-devel] [PULL 18/39] linux-user/syscall: extend lock around cpu-list

2016-10-07 Thread Paolo Bonzini
From: Alex Bennée There is a potential race if several threads exit at once. To serialise the exits extend the lock above the initial checking of the CPU list. Signed-off-by: Alex Bennée Message-Id:

Re: [Qemu-devel] [PATCH 08/22] block/dirty-bitmap: add autoload field to BdrvDirtyBitmap

2016-10-07 Thread Max Reitz
On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: > Mirror AUTO flag from Qcow2 bitmap in BdrvDirtyBitmap. This will be > needed in future, to save this flag back to Qcow2 for persistent > bitmaps. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- >

Re: [Qemu-devel] [PULL 00/20] Tracing patches

2016-10-07 Thread Lluís Vilanova
Daniel P Berrange writes: > On Fri, Oct 07, 2016 at 03:46:27PM +0200, Lluís Vilanova wrote: >> Peter Maydell writes: >> >> > On 7 October 2016 at 11:09, Stefan Hajnoczi wrote: >> >> The following changes since commit >> >> e902754e3d0890945ddcc1b33748ed73762ddb8d: >> >>

Re: [Qemu-devel] [PATCH v4 3/3] tests: start generic qemu-qmp tests

2016-10-07 Thread Markus Armbruster
Marc-André Lureau writes: > These 2 tests exhibit two qmp bugs fixed by the previous patches. > > Signed-off-by: Marc-André Lureau > Reviewed-by: Daniel P. Berrange > Reviewed-by: Eric Blake

[Qemu-devel] [PULL 02/39] MC146818 RTC: coordinate guest clock base to destination host after migration

2016-10-07 Thread Paolo Bonzini
From: Junlian Bell qemu tracks guest time based on vector [base_rtc, last_update], in which last_update stands for a monotonic tick which is actually uptime of the host. according to rtc implementation codes of recent releases and upstream, after migration, the time base

[Qemu-devel] [PULL 00/39] Misc patches for 2016-10-07

2016-10-07 Thread Paolo Bonzini
The following changes since commit 49540a1f652afd419812bd4d35cc6f45a46a2afe: Merge remote-tracking branch 'remotes/jnsnow/tags/ide-pull-request' into staging (2016-09-30 00:42:08 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to

[Qemu-devel] [PULL 01/39] hw/iommu: Fix problems reported by Coverity scan

2016-10-07 Thread Paolo Bonzini
From: David Kiarie Signed-off-by: David Kiarie Message-Id: <1475553808-13285-2-git-send-email-davidkiar...@gmail.com> Signed-off-by: Paolo Bonzini --- hw/i386/amd_iommu.c | 22 +- 1 file changed, 13

[Qemu-devel] [PULL 07/39] intc/lm32_pic: implement InterruptStatsProvider interface

2016-10-07 Thread Paolo Bonzini
From: Hervé Poussineau We have to change the vmstate version due to changes in statistics counters. Signed-off-by: Hervé Poussineau Message-Id: <1474921408-24710-5-git-send-email-hpous...@reactos.org> Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL 06/39] intc/slavio_intctl: implement InterruptStatsProvider interface

2016-10-07 Thread Paolo Bonzini
From: Hervé Poussineau Acked-by: Artyom Tarasenko Signed-off-by: Hervé Poussineau Message-Id: <1474921408-24710-4-git-send-email-hpous...@reactos.org> Signed-off-by: Paolo Bonzini ---

[Qemu-devel] [PULL 19/39] qga/command: use QEMU atomic primitives

2016-10-07 Thread Paolo Bonzini
From: Alex Bennée The guest client's use of the glib's g_atomic primitives causes newer GCC's to barf when built on Travis. As QEMU has its own primitives with well understood semantics we might as well use them. The use of atomics was a little inconsistent so I've also

[Qemu-devel] [PULL 21/39] i8259: give ISA device when registering ISA ioports

2016-10-07 Thread Paolo Bonzini
From: Hervé Poussineau Signed-off-by: Hervé Poussineau Message-Id: <1475437467-22781-1-git-send-email-hpous...@reactos.org> Signed-off-by: Paolo Bonzini --- hw/intc/i8259_common.c | 5 +++-- 1 file changed, 3 insertions(+), 2

Re: [Qemu-devel] [PATCH v3 3/5] tests: use qtest_pc_boot()/qtest_shutdown() in virtio tests

2016-10-07 Thread Laurent Vivier
On 07/10/2016 18:38, Greg Kurz wrote: > On Sat, 1 Oct 2016 20:56:02 +0200 > Laurent Vivier wrote: > >> This patch replaces calls to qtest_start() and qtest_end() by >> calls to qtest_pc_boot() and qtest_shutdown(). >> >> This allows to initialize memory allocator and PCI

[Qemu-devel] [PATCH 1/3] block: add BDS field to count in-flight requests

2016-10-07 Thread Paolo Bonzini
Unlike tracked_requests, this field also counts throttled requests, and remains non-zero if an AIO operation needs a BH to be "really" completed. With this change, it is no longer necessary to have a dummy BdrvTrackedRequest for requests that are never serialising, and it is no longer necessary

[Qemu-devel] [PULL 04/39] intc: add an interface to gather statistics/informations on interrupt controllers

2016-10-07 Thread Paolo Bonzini
From: Hervé Poussineau This interface will be used by HMP commands 'info irq' and 'info pic'. Signed-off-by: Hervé Poussineau Message-Id: <1474921408-24710-2-git-send-email-hpous...@reactos.org> Signed-off-by: Paolo Bonzini ---

[Qemu-devel] [PULL 03/39] hw/misc/edu: support MSI interrupt

2016-10-07 Thread Paolo Bonzini
From: Peter Xu So now edu device can support both line or msi interrupt, depending on how user configures it. Signed-off-by: Peter Xu Message-Id: <1475067819-21413-1-git-send-email-pet...@redhat.com> Signed-off-by: Paolo Bonzini ---

[Qemu-devel] [PULL 10/39] atomic.h: fix __SANITIZE_THREAD__ build

2016-10-07 Thread Paolo Bonzini
From: Alex Bennée Only very modern GCC's actually set this define when building with the ThreadSanitizer so this little typo slipped though. Signed-off-by: Alex Bennée Message-Id: <20160930213106.20186-2-alex.ben...@linaro.org> Signed-off-by:

[Qemu-devel] [PULL 05/39] intc/i8259: implement InterruptStatsProvider interface

2016-10-07 Thread Paolo Bonzini
From: Hervé Poussineau Signed-off-by: Hervé Poussineau Message-Id: <1474921408-24710-3-git-send-email-hpous...@reactos.org> Signed-off-by: Paolo Bonzini --- hw/intc/i8259.c | 37 + 1 file

[Qemu-devel] [PULL 15/39] qom/cpu: atomically clear the tb_jmp_cache

2016-10-07 Thread Paolo Bonzini
From: Alex Bennée The ThreadSanitizer rightly complains that something initialised with a normal access is later updated and read atomically. Signed-off-by: Alex Bennée Message-Id: <20160930213106.20186-8-alex.ben...@linaro.org> Signed-off-by:

[Qemu-devel] [PULL 16/39] cpu: atomically modify cpu->exit_request

2016-10-07 Thread Paolo Bonzini
From: Alex Bennée ThreadSanitizer picks up potential races although we already use barriers to ensure things are in the correct order when processing exit requests. For true C11 defined behaviour across threads we need to use relaxed atomic_set/atomic_read semantics to

[Qemu-devel] [PULL 28/39] qht: fix unlock-after-free segfault upon resizing

2016-10-07 Thread Paolo Bonzini
From: "Emilio G. Cota" The old map's bucket locks are being unlocked *after* that same old map has been passed to RCU for destruction. This is a bug that can cause a segfault, since there's no guarantee that the deletion will be deferred (e.g. there may be no concurrent readers).

[Qemu-devel] [PULL 24/39] util: Introduce qemu_get_pid_name

2016-10-07 Thread Paolo Bonzini
From: Michal Privoznik This is a small helper that tries to fetch binary name for given PID. Signed-off-by: Michal Privoznik Message-Id: <4d75d475c1884f8e94ee8b1e57273ddf3ed68bf7.1474987617.git.mpriv...@redhat.com> Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL 35/39] qemu-tech: move user mode emulation features from qemu-tech

2016-10-07 Thread Paolo Bonzini
These are interesting for users too, since nowadays most qemu-user users are going to be somewhat technical rather than just people that want to run Wine. Some detail is lost, on the other hand some of the information I removed (e.g. basic block unchaining) was obsolete. Reviewed-by: Emilio G.

[Qemu-devel] [PULL 29/39] test-qht: perform lookups under rcu_read_lock

2016-10-07 Thread Paolo Bonzini
From: "Emilio G. Cota" qht_lookup is meant to be called from an RCU read-critical section. Make sure we're in such a section in test-qht when performing lookups, despite the fact that no races in qht can be triggered by test-qht since it is single-threaded. Note that

[Qemu-devel] [PULL 26/39] qemu-nbd: Shrink image size by specified offset

2016-10-07 Thread Paolo Bonzini
From: Tomáš Golembiovský When --offset is set the apparent device size has to be adjusted accordingly. Otherwise client may request read/write beyond the file end which would fail. Signed-off-by: Tomáš Golembiovský Message-Id:

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v5 4/6] migration: migrate QTAILQ

2016-10-07 Thread Jianjun Duan
On 10/07/2016 09:32 AM, Paolo Bonzini wrote: > > > On 07/10/2016 18:31, Jianjun Duan wrote: >> >> >> On 10/07/2016 07:34 AM, Dr. David Alan Gilbert wrote: >>> * Paolo Bonzini (pbonz...@redhat.com) wrote: On 06/10/2016 21:01, Dr. David Alan Gilbert wrote: +

Re: [Qemu-devel] [PATCH v14 03/21] qapi: add trace events for visitor

2016-10-07 Thread Daniel P. Berrange
On Fri, Oct 07, 2016 at 03:59:07PM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > Allow tracing of the operation of visitors > > > > Signed-off-by: Daniel P. Berrange > > --- > > Makefile.objs | 1 + > >

Re: [Qemu-devel] [PATCH 1/1] block: add gluster ifdef guard checks for SEEK_DATA/SEEK_HOLE support

2016-10-07 Thread Jeff Cody
On Fri, Oct 07, 2016 at 09:20:54AM -0500, Eric Blake wrote: > On 10/06/2016 10:53 PM, Jeff Cody wrote: > > Add checks to see if the system compiling QEMU has support for > > SEEK_HOLE/SEEK_DATA. If the system does not, we will flag that seek > > data is unsupported in gluster. > > > > Note: this

Re: [Qemu-devel] Adding Save States menu items

2016-10-07 Thread Programmingkid
On Oct 7, 2016, at 5:14 AM, Daniel P. Berrange wrote: > On Fri, Oct 07, 2016 at 09:21:36AM +0200, Paolo Bonzini wrote: >> >> >> On 06/10/2016 22:26, Eric Blake wrote: > Doesn't virt-manager already do this? What do we gain by duplicating > GUI functionality at this level that is

Re: [Qemu-devel] Adding Save States menu items

2016-10-07 Thread Programmingkid
On Oct 7, 2016, at 5:09 AM, Daniel P. Berrange wrote: > On Thu, Oct 06, 2016 at 02:59:49PM -0500, Eric Blake wrote: >> On 10/06/2016 09:22 AM, Programmingkid wrote: >>> Would you accept a patch that added "Save State" and "Restore State" menu >>> items to the cocoa interface? They would allow

[Qemu-devel] [PATCH 0/2] qemu-img: change img_open() and opening method in dd

2016-10-07 Thread Reda Sallahi
The patch series include the previously submitted patch: [PATCH v5] qemu-img: change opening method for the output in dd Changes from v5: * Replace access() with a modified version of img_open() in img_dd() Depends on: [PATCH v3] qemu-img: add conv=notrunc option to dd Reda Sallahi (2):

Re: [Qemu-devel] [PATCH 3/9] target-mips: Decode EVA load & store instructions

2016-10-07 Thread James Hogan
On Fri, Oct 07, 2016 at 04:34:27PM +0100, Yongbok Kim wrote: > > > On 06/09/2016 12:03, James Hogan wrote: > > Implement decoding of EVA loads and stores. These access the user > > address space from kernel mode when implemented, so for each instruction > > we need to check that EVA is available

[Qemu-devel] [PULL 08/10] scripts: Allow block module to not define BlockDriver

2016-10-07 Thread Kevin Wolf
From: Fam Zheng Signed-off-by: Fam Zheng Message-id: 1473043845-13197-2-git-send-email-f...@redhat.com Reviewed-by: Stefan Hajnoczi Signed-off-by: Max Reitz --- scripts/modules/module_block.py | 7 --- 1 file

[Qemu-devel] [PULL 02/10] async: add aio_bh_schedule_oneshot

2016-10-07 Thread Kevin Wolf
From: Paolo Bonzini qemu_bh_delete is already clearing bh->scheduled at the same time as it's setting bh->deleted. Since it's not using any memory barriers, there is no synchronization going on for bh->deleted, and this makes the bh->deleted checks superfluous in

Re: [Qemu-devel] [PATCH v3 1/1] docs/generic-loader: Update the document

2016-10-07 Thread Peter Maydell
On 6 October 2016 at 09:24, Markus Armbruster wrote: > Alistair Francis writes: > >> This patch does three things: >> - It adds a list of restrictions and ToDos >> - It corrects the header --- lines to match the length of the header >> - It

Re: [Qemu-devel] [PATCH] target-arm: kvm: use AddressSpace-specific listener

2016-10-07 Thread Peter Maydell
On 6 October 2016 at 17:02, Peter Maydell wrote: > On 30 September 2016 at 08:17, Paolo Bonzini wrote: >> The only address space where the GIC devices are added is >> address_space_memory. There is no need to use a global >> MemoryListener. >> >>

  1   2   3   >