[Qemu-devel] [PATCH V2 7/7] xilinx_spips: allow mmio execution

From: KONRAD Frederic This allows to execute from the lqspi area. When the request_ptr is called the device loads 1024bytes from the SPI device. Then this code can be executed by the guest. Signed-off-by: KONRAD Frederic ---

[Qemu-devel] [PULL 08/23] virtio: use MemoryRegionCache to access descriptors

From: Paolo Bonzini For now, the cache is created on every virtqueue_pop. Later on, direct descriptors will be able to reuse it. Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PATCH] tests: Use error_free_or_abort() where appropriate

Done with this Coccinelle semantic patch: @@ expression E; @@ -g_assert(E); -error_free(E); +error_free_or_abort(); Signed-off-by: Markus Armbruster --- tests/test-qemu-opts.c | 3 +-- tests/test-qobject-output-visitor.c | 6

[Qemu-devel] [PULL 14/23] pcie: simplify pcie_add_capability()

From: Peter Xu When we add PCIe extended capabilities, we should be following the rule that we add the head extended cap (at offset 0x100) first, then the rest of them. Meanwhile, we are always adding new capability bits at the end of the list. Here the "next" looks

[Qemu-devel] [PATCH 05/14] libqtest: Clean up qmp_response() a bit

Use qobject_to_qdict() instead of a type cast. Signed-off-by: Markus Armbruster --- tests/libqtest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/libqtest.c b/tests/libqtest.c index d8fba66..e54354d 100644 --- a/tests/libqtest.c +++

[Qemu-devel] [PATCH 00/14] qobject: Cleanups, mostly in tests

Markus Armbruster (14): qdict: Make qdict_get_qlist() safe like qdict_get_qdict() check-qdict: Simplify qdict_crumple_test_recursive() check-qdict: Tighten qdict_crumple_test_recursive() some check-qjson: Simplify around compare_litqobj_to_qobj() libqtest: Clean up qmp_response() a bit

Re: [Qemu-devel] [PATCH 21/24] util/cutils: Let qemu_strtosz*() optionally reject trailing crap

On 02/14/2017 04:26 AM, Markus Armbruster wrote: > Change the qemu_strtosz() & friends to return -EINVAL when @endptr is > null and the conversion doesn't consume the string completely. > Matches how qemu_strtol() & friends work. > > Only test_qemu_strtosz_simple() passes a null @endptr. No

Re: [Qemu-devel] [PATCH 18/24] tests/test-cutils: Use qemu_strtosz() more often

On 02/14/2017 04:26 AM, Markus Armbruster wrote: > Use qemu_strtosz() instead of qemu_strtosz_mebi() where it doesn't > really make a difference. Rebase churn to Paolo's naming suggestion on 15/24, but that shouldn't stop you from adding: Reviewed-by: Eric Blake > >

Re: [Qemu-devel] [PATCH 1/2] block/nfs: convert to preadv / pwritev

On Fri, Feb 17, 2017 at 05:39:00PM +0100, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > block/nfs.c | 33 +++-- > 1 file changed, 15 insertions(+), 18 deletions(-) > > diff --git a/block/nfs.c b/block/nfs.c > index 689eaa7..ab5dcc2 100644 >

[Qemu-devel] [Bug 1665789] [NEW] More resolutions for vga displays

Public bug reported: Would it be possible to add more resolutions for vga displays (which I am accessing via vnc instead of spice)? In particular: - 1080 wide x 1920 high (rotate 1920 x 1080 screen) - 1920 wide x 1080 + 1980 high (1920 x 1080 screen on top of 1600 x 900 screen) ** Affects:

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Thu, Feb 16, 2017 at 02:24:19PM -0800, ashish mittal wrote: > Hi, > > I am getting the following error with checkpatch.pl > > ERROR: externs should be avoided in .c files > #78: FILE: block/vxhs.c:28: > +QemuUUID qemu_uuid __attribute__ ((weak)); > > Is there any way to get around this, or

Re: [Qemu-devel] [PATCH 23/24] util/cutils: Change qemu_strtosz*() from int64_t to uint64_t

On 02/14/2017 04:26 AM, Markus Armbruster wrote: > This will permit its use in parse_option_size(). Progress! (not that it matters - off_t is a signed value, so you are STILL limited to 2^63, not 2^64, as the maximum theoretical size storage that you can target - and it's not like we have that

[Qemu-devel] [PATCH 06/14] test-qmp-event: Simplify and tighten event_test_emit()

Use qdict_get_qdict() and qdict_get_try_int() to simplify. While there, add a sanity check for seconds. Signed-off-by: Markus Armbruster --- tests/test-qmp-event.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/tests/test-qmp-event.c

[Qemu-devel] [PATCH 02/14] check-qdict: Simplify qdict_crumple_test_recursive()

Use qdict_get_qdict(), qdict_get_qlist() instead of qdict_get() followed by qobject_to_qdict(), qobject_to_qlist(). While there, drop some redundant code. Signed-off-by: Markus Armbruster --- tests/check-qdict.c | 25 + 1 file changed, 9

Re: [Qemu-devel] [PATCH 14/24] util/cutils: New qemu_strtosz_metric()

On 02/14/2017 04:26 AM, Markus Armbruster wrote: > To parse numbers with metric suffixes, we use > > qemu_strtosz_suffix_unit(nptr, , QEMU_STRTOSZ_DEFSUFFIX_B, 1000) > > Capture this in a new function for legibility: > > qemu_strtosz_metric(nptr, ) > > Replace

[Qemu-devel] [PATCH] Add missing fp_access_check() to aarch64 crypto instructions

The aarch64 crypto instructions for AES and SHA are missing the check for if the FPU is enabled. Signed-off-by: Nick Reilly --- target/arm/translate-a64.c | 12 1 file changed, 12 insertions(+) diff --git a/target/arm/translate-a64.c

Re: [Qemu-devel] [PATCH v2 0/7] iscsi: Add blockdev-add support

On Wed, Jan 25, 2017 at 12:42:01PM -0500, Jeff Cody wrote: > This adds blockdev-add support to the iscsi block driver. > > Picked this series up from Kevin. I've tested it on my local iscsi setup. > > There are only a few minor changes: > > * In patch 2, fixed the segfault pointed out by

Re: [Qemu-devel] [PATCH 22/24] util/cutils: Return qemu_strtosz*() error and value separately

On 02/14/2017 04:26 AM, Markus Armbruster wrote: > This makes qemu_strtosz(), qemu_strtosz_mebi() and > qemu_strtosz_metric() similar to qemu_strtoi64(), except negative > values are rejected. Yay. It also opens the door to allowing them to return an unsigned 64 bit value ;) > > Cc: Dr. David

[Qemu-devel] [PULL 20/23] intel_iommu: renaming gpa to iova where proper

From: Peter Xu There are lots of places in current intel_iommu.c codes that named "iova" as "gpa". It is really confusing to use a name "gpa" in these places (which is very easily to be understood as "Guest Physical Address", while it's not). To make the codes (much) easier to

[Qemu-devel] [PATCH 08/14] tests: Don't check qobject_type() before qobject_to_qlist()

qobject_to_qlist(obj) returns NULL when obj isn't a QList. Check that instead of qobject_type(obj) == QTYPE_QLIST. Signed-off-by: Markus Armbruster --- tests/test-qobject-output-visitor.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git

[Qemu-devel] [PATCH 11/14] tests: Don't check qobject_type() before qobject_to_qfloat()

qobject_to_qfloat(obj) returns NULL when obj isn't a QFloat. Check that instead of qobject_type(obj) == QTYPE_QFLOAT. Signed-off-by: Markus Armbruster --- tests/check-qjson.c | 12 ++-- tests/test-qobject-output-visitor.c | 8 2 files

[Qemu-devel] [PULL 22/23] intel_iommu: convert dbg macros to trace for trans

From: Peter Xu Another patch to convert the DPRINTF() stuffs. This patch focuses on the address translation path and caching. Signed-off-by: Peter Xu Reviewed-by: Jason Wang Reviewed-by: David Gibson

[Qemu-devel] [PATCH 14/14] block: Don't bother asserting type of output visitor's output

After a visit of a complex QAPI type FOO ov = qobject_output_visitor_new(); visit_type_FOO(ov, NULL, expr, _abort); visit_complete(ov, ); we can safely assume qobject_type(foo) is QTYPE_QDICT. We do in many places, but occasionally assert qobject_type(obj) == QTYPE_QDICT. Don't.

[Qemu-devel] [PATCH 04/14] check-qjson: Simplify around compare_litqobj_to_qobj()

Make compare_litqobj_to_qobj() cope with null, and drop non-null assertions from callers. compare_litqobj_to_qobj() already checks the QType matches; drop the redundant assertions from callers. Signed-off-by: Markus Armbruster --- tests/check-qjson.c | 22

[Qemu-devel] [PATCH 13/14] monitor: Clean up handle_hmp_command() a bit

Leave checking qobject_type(req) to qmp_check_input_obj(). Rework handling of json_parser_parse_err() failing without setting an error. Signed-off-by: Markus Armbruster --- monitor.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/monitor.c

[Qemu-devel] [PATCH v3] linux-user: Add sockopts for IPv6 ping and IPv6 traceroute

Add the neccessary sockopts for ping and traceroute on IPv6. This fixes the following qemu warnings with IPv6: Unsupported ancillary data: 0/2 Unsupported ancillary data: 0/11 Unsupported ancillary data: 41/25 Unsupported setsockopt level=0 optname=12 Unsupported setsockopt level=41 optname=16

Re: [Qemu-devel] [PATCH 2/2] block/nfs: try to avoid the bounce buffer in pwritev

On Fri, Feb 17, 2017 at 05:39:01PM +0100, Peter Lieven wrote: > if the passed qiov contains exactly one iov we can > pass the buffer directly. > > Signed-off-by: Peter Lieven > --- > block/nfs.c | 23 --- > 1 file changed, 16 insertions(+), 7 deletions(-) > >

Re: [Qemu-devel] [PATCH 2/2] block/nfs: try to avoid the bounce buffer in pwritev

On 02/17/2017 03:37 PM, Jeff Cody wrote: > On Fri, Feb 17, 2017 at 05:39:01PM +0100, Peter Lieven wrote: >> if the passed qiov contains exactly one iov we can >> pass the buffer directly. >> >> Signed-off-by: Peter Lieven >> --- >> block/nfs.c | 23 --- >> 1

Re: [Qemu-devel] [PATCH v4 4/4] sd: sdhci: Remove block count enable check in single block transfers

On Tue, Feb 14, 2017 at 10:52 AM, P J P wrote: > From: Prasad J Pandit > > In SDHCI protocol, the 'Block count enable' bit of the Transfer > Mode register is relevant only in multi block transfers. We need > not check it in single block transfers. > >

Re: [Qemu-devel] [PATCH 02/14] check-qdict: Simplify qdict_crumple_test_recursive()

On 02/17/2017 02:38 PM, Markus Armbruster wrote: > Use qdict_get_qdict(), qdict_get_qlist() instead of qdict_get() > followed by qobject_to_qdict(), qobject_to_qlist(). Worth a Coccinelle script to make sure we catch it all? > > While there, drop some redundant code. > > Signed-off-by: Markus

[Qemu-devel] [PATCH V2 5/7] qdev: add MemoryRegion property

From: KONRAD Frederic We need to pass a pointer to a MemoryRegion for mmio_interface. So this just adds that. Signed-off-by: KONRAD Frederic --- include/hw/qdev-properties.h | 2 ++ 1 file changed, 2 insertions(+) diff --git

[Qemu-devel] [PULL 10/23] virtio: use VRingMemoryRegionCaches for descriptor ring

From: Paolo Bonzini Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio.c | 26

[Qemu-devel] [PULL 19/23] intel_iommu: simplify irq region translation

From: Peter Xu Now we have a standalone memory region for MSI, all the irq region requests should be redirected there. Cleaning up the block with an assertion instead. Reviewed-by: Jason Wang Signed-off-by: Peter Xu Reviewed-by: David

Re: [Qemu-devel] [PATCH 19/24] tests/test-cutils: Drop suffix from test_qemu_strtosz_simple()

On 02/14/2017 04:26 AM, Markus Armbruster wrote: > Leave testing unit suffixes to test_qemu_strtosz_units(). > > Signed-off-by: Markus Armbruster > --- > tests/test-cutils.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > Reviewed-by: Eric Blake

[Qemu-devel] [PATCH] ARM i.MX timers: fix software reset

Hello! i.MX6 RM says that setting software reset bit in CR register of GPT (general purpose timers) should resets all of the registers of GPT to their default reset values, except for the CLKSRC, EN, ENMOD, STOPEN, WAITEN, and DBGEN bits in CR. But current implementation does the opposite

Re: [Qemu-devel] [PATCH v2 6/7] iscsi: Add blockdev-add support

On 01/25/2017 11:42 AM, Jeff Cody wrote: > From: Kevin Wolf > > This adds blockdev-add support for iscsi devices. > > Reviewed-by: Daniel P. Berrange > Signed-off-by: Kevin Wolf > Signed-off-by: Jeff Cody > --- >

[Qemu-devel] [PULL 06/23] virtio: use address_space_map/unmap to access descriptors

From: Paolo Bonzini This makes little difference, but it makes the code change smaller for the next patch that introduces MemoryRegionCache. This is because map/unmap are similar to MemoryRegionCache init/destroy. Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PATCH 12/14] tests: Don't check qobject_type() before qobject_to_qbool()

qobject_to_qbool(obj) returns NULL when obj isn't a QBool. Check that instead of qobject_type(obj) == QTYPE_QBOOL. Signed-off-by: Markus Armbruster --- tests/check-qjson.c | 24 ++-- tests/test-qobject-output-visitor.c | 12 +--- 2

[Qemu-devel] [PATCH 03/14] check-qdict: Tighten qdict_crumple_test_recursive() some

Consistently check for unexpected QDict entries, and qdict_get_qdict() success. The latter doesn't tighten the test, it only makes it fail more nicely. Signed-off-by: Markus Armbruster --- tests/check-qdict.c | 5 + 1 file changed, 5 insertions(+) diff --git

[Qemu-devel] [PATCH 01/14] qdict: Make qdict_get_qlist() safe like qdict_get_qdict()

Commit 89cad9f changed qdict_get_qdict() to return NULL instead of crash when the key doesn't exist or its value isn't a QDict. Commit 2d6421a neglected to do the same for qdict_get_qlist(). Correct that, and update the function comments. qdict_get_obj() is now unused, remove. Signed-off-by:

Re: [Qemu-devel] [PATCH] tests: Use error_free_or_abort() where appropriate

On 02/17/2017 02:15 PM, Markus Armbruster wrote: > Done with this Coccinelle semantic patch: > > @@ > expression E; > @@ > -g_assert(E); > -error_free(E); > +error_free_or_abort(); > > Signed-off-by: Markus Armbruster > --- >

[Qemu-devel] [Bug 1665389] Re: Nested kvm guest fails to start on a emulated Westmere CPU guest under a Broadwell CPU host

kvm_msr_entry_add: @8 index=9e value=3 kvm_msr_entry_add: @9 index=d90 value=0 kvm_msr_entry_add: @10 index=c083 value=0 kvm_put_msrs: ret=9 expected=90 OK, 9... so that's probably the d90; $ ag d90: 418:#define MSR_IA32_BNDCFGS0x0d90 The Intel book

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

On 02/17/17 19:34, Ben Warren wrote: > >> On Feb 17, 2017, at 8:03 AM, Laszlo Ersek > > wrote: >> >> On 02/17/17 16:33, Ben Warren wrote: >>> On Feb 17, 2017, at 2:43 AM, Igor Mammedov

Re: [Qemu-devel] [PATCH 17/24] util/cutils: Drop QEMU_STRTOSZ_DEFSUFFIX_* macros

On 02/14/2017 04:26 AM, Markus Armbruster wrote: > Writing QEMU_STRTOSZ_DEFSUFFIX_* instead of '*' gains nothing. Get > rid of these eyesores. > > Signed-off-by: Markus Armbruster > --- > util/cutils.c | 28 ++-- > 1 file changed, 10 insertions(+), 18

[Qemu-devel] [PATCH V2 0/7] execute code from mmio area

From: KONRAD Frederic This series allows to execute code from mmio areas. The main goal of this is to be able to run code for example from an SPI device. The three first patch fixes the way get_page_addr_code fills the TLB. The fourth patch implements the mmio

Re: [Qemu-devel] [PATCH 16/24] util/cutils: New qemu_strtosz()

On 02/14/2017 04:26 AM, Markus Armbruster wrote: > Most callers of qemu_strtosz_suffix() pass QEMU_STRTOSZ_DEFSUFFIX_B. > Capture the pattern in new qemu_strtosz(). > > Inline qemu_strtosz_suffix() into its only remaining caller. > > Signed-off-by: Markus Armbruster > --- >

[Qemu-devel] [PATCH 10/14] tests: Don't check qobject_type() before qobject_to_qint()

qobject_to_qint(obj) returns NULL when obj isn't a QInt. Check that instead of qobject_type(obj) == QTYPE_QINT. Signed-off-by: Markus Armbruster --- tests/check-qjson.c | 24 +--- tests/test-qobject-output-visitor.c | 28

Re: [Qemu-devel] [PATCH 15/24] util/cutils: Rename qemu_strtosz() to qemu_strtosz_mebi()

On 02/14/2017 04:26 AM, Markus Armbruster wrote: > With qemu_strtosz(), no suffix means mebibytes. It's used rarely. > I'm going to add a similar function where no suffix means bytes. > Rename qemu_strtosz() to qemu_strtosz_mebi() to make the name > qemu_strtosz() available for the new function.

Re: [Qemu-devel] [PATCH v2 6/7] iscsi: Add blockdev-add support

On Fri, Feb 17, 2017 at 03:40:21PM -0600, Eric Blake wrote: > On 01/25/2017 11:42 AM, Jeff Cody wrote: > > From: Kevin Wolf > > > > This adds blockdev-add support for iscsi devices. > > > > Reviewed-by: Daniel P. Berrange > > Signed-off-by: Kevin Wolf

Re: [Qemu-devel] [PATCH 24/24] QemuOpts: Fix checking of sizes for overflow and trailing crap

On 02/14/2017 04:26 AM, Markus Armbruster wrote: > parse_option_size()'s checking for overflow and trailing crap is > wrong. Has always been that way. qemu_strtosz() gets it right, so > use that. > > This adds support for size suffixes 'P', 'E', and ignores case for all > suffixes, not just

[Qemu-devel] [PATCH V2 1/7] cputlb: cleanup get_page_addr_code to use VICTIM_TLB_HIT

From: KONRAD Frederic This replaces env1 and page_index variables by env and index so we can use VICTIM_TLB_HIT macro later. Signed-off-by: KONRAD Frederic --- cputlb.c | 18 +- 1 file changed, 9 insertions(+), 9

[Qemu-devel] [PULL 16/23] vfio: introduce vfio_get_vaddr()

From: Peter Xu A cleanup for vfio_iommu_map_notify(). Now we will fetch vaddr even if the operation is unmap, but it won't hurt much. One thing to mention is that we need the RCU read lock to protect the whole translation and map/unmap procedure. Acked-by: Alex Williamson

[Qemu-devel] [PATCH V2 6/7] introduce mmio_interface

From: KONRAD Frederic This introduces mmio_interface object which contains a MemoryRegion and can be hotplugged/hotunplugged. Signed-off-by: KONRAD Frederic V1 -> V2: * Fix the qemu_log format. --- hw/misc/Makefile.objs| 1

Re: [Qemu-devel] [PATCH] Changing error message of QMP 'migrate_set_downtime' to seconds

Eric Blake writes: > On 02/17/2017 01:01 PM, Daniel Henrique Barboza wrote: > 200)) { +(params->downtime_limit < 0 || + params->downtime_limit > MAX_MIGRATE_SET_DOWNTIME)) { error_setg(errp, QERR_INVALID_PARAMETER_VALUE,

[Qemu-devel] [PULL 18/23] intel_iommu: add "caching-mode" option

From: Aviv Ben-David This capability asks the guest to invalidate cache before each map operation. We can use this invalidation to trap map operations in the hypervisor. Signed-off-by: Aviv Ben-David [peterx: using "caching-mode" instead of "cache-mode" to

[Qemu-devel] [PATCH 09/14] tests: Don't check qobject_type() before qobject_to_qstring()

qobject_to_qstring(obj) returns NULL when obj isn't a QString. Check that instead of qobject_type(obj) == QTYPE_QSTRING. Signed-off-by: Markus Armbruster --- tests/check-qjson.c | 31 --- tests/test-qobject-output-visitor.c | 37

[Qemu-devel] [PATCH 07/14] Don't check qobject_type() before qobject_to_qdict()

qobject_to_qdict(obj) returns NULL when obj isn't a QDict. Check that instead of qobject_type(obj) == QTYPE_QDICT. Signed-off-by: Markus Armbruster --- block.c | 4 ++-- hw/pci/pcie_aer.c | 2 +- monitor.c

Re: [Qemu-devel] [PATCH 20/24] qemu-img: Wrap cvtnum() around qemu_strtosz()

On 02/14/2017 04:26 AM, Markus Armbruster wrote: > Cc: Kevin Wolf > Cc: Max Reitz > Cc: qemu-bl...@nongnu.org > Signed-off-by: Markus Armbruster > --- > qemu-img.c | 58 +++--- > 1 file

Re: [Qemu-devel] [PATCH v3] linux-user: Add sockopts for IPv6 ping and IPv6 traceroute

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v3] linux-user: Add sockopts for IPv6 ping and IPv6 traceroute Message-id: 20170217210831.ga26...@ls3530.fritz.box === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [Bug 1665791] [NEW] Multiple displays each attached to a separate vnc connection

Public bug reported: Would it be possible to create two displays in qemu (for windows 10) with each accessible by a separate vnc connection? I think this already exists for spice (and I would like it because vnc works better for me than does spice) ** Affects: qemu Importance: Undecided

Re: [Qemu-devel] [PATCH 2/2] block/nfs: try to avoid the bounce buffer in pwritev

On Fri, Feb 17, 2017 at 03:42:52PM -0600, Eric Blake wrote: > On 02/17/2017 03:37 PM, Jeff Cody wrote: > > On Fri, Feb 17, 2017 at 05:39:01PM +0100, Peter Lieven wrote: > >> if the passed qiov contains exactly one iov we can > >> pass the buffer directly. > >> > >> Signed-off-by: Peter Lieven

Re: [Qemu-devel] [PATCH v4 0/4] sd: sdhci: correct transfer mode register usage

On Fri, Feb 17, 2017 at 5:21 AM, Peter Maydell wrote: > On 14 February 2017 at 18:52, P J P wrote: >> From: Prasad J Pandit >> >> Hello, >> >> In SDHCI protocol, the 'Block Count Enable' bit of the Transfer Mode >> register

Re: [Qemu-devel] [PATCH 01/14] qdict: Make qdict_get_qlist() safe like qdict_get_qdict()

On 02/17/2017 02:38 PM, Markus Armbruster wrote: > Commit 89cad9f changed qdict_get_qdict() to return NULL instead of > crash when the key doesn't exist or its value isn't a QDict. > Commit 2d6421a neglected to do the same for qdict_get_qlist(). > Correct that, and update the function comments. >

[Qemu-devel] [PATCH RESEND] aarch64: Change ext type to TCGType to fix warnings

To fix the following warnings: In file included from /users/pranith/qemu/tcg/tcg.c:255: /users/pranith/qemu/tcg/aarch64/tcg-target.inc.c:879:24: warning: implicit conversion from enumeration type 'TCGMemOp' (aka 'enum TCGMemOp') to different enumeration type 'TCGType' (aka 'enum TCGType')

Re: [Qemu-devel] [PATCH] Makefile: Put VERSION info into version.texi rather than using -D

Hi - Original Message - > Unfortunately some older versions of makeinfo don't correctly > handle the -D command line option and fail to set the variable. > This then causes them to complain > docs/qemu-ga-ref.texi:41: warning: undefined flag: VERSION > > Work around this by doing as the

Re: [Qemu-devel] [PATCH v15 25/25] qcow2-bitmap: improve check_constraints_on_bitmap

On 02/17/2017 04:18 AM, Vladimir Sementsov-Ogievskiy wrote: > 16.02.2017 17:21, Kevin Wolf wrote: >> Am 15.02.2017 um 11:10 hat Vladimir Sementsov-Ogievskiy geschrieben: >>> Add detailed error messages. >>> >>> Signed-off-by: Vladimir Sementsov-Ogievskiy >> Why not merge

Re: [Qemu-devel] [PATCH] Makefile: Put VERSION info into version.texi rather than using -D

On 02/17/2017 09:12 AM, Peter Maydell wrote: > Unfortunately some older versions of makeinfo don't correctly > handle the -D command line option and fail to set the variable. > This then causes them to complain > docs/qemu-ga-ref.texi:41: warning: undefined flag: VERSION > > Work around this by

Re: [Qemu-devel] [PATCH] Makefile: Put VERSION info into version.texi rather than using -D

On 17 February 2017 at 15:50, Eric Blake wrote: > On 02/17/2017 09:12 AM, Peter Maydell wrote: >> Unfortunately some older versions of makeinfo don't correctly >> handle the -D command line option and fail to set the variable. >> This then causes them to complain >>

Re: [Qemu-devel] [PATCH] Makefile: Put VERSION info into version.texi rather than using -D

On 02/17/2017 09:52 AM, Peter Maydell wrote: >>> Makefile | 17 ++--- >>> docs/qemu-ga-ref.texi | 2 ++ >>> docs/qemu-qmp-ref.texi | 2 ++ >>> 3 files changed, 14 insertions(+), 7 deletions(-) >> >> Missing a change to .gitignore for version.texi. > > Should be >

[Qemu-devel] [RFC PATCH V4] qemu-img: make convert async

this is something I have been thinking about for almost 2 years now. we heavily have the following two use cases when using qemu-img convert. a) reading from NFS and writing to iSCSI for deploying templates b) reading from iSCSI and writing to NFS for backups In both processes we use libiscsi

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

On 02/17/17 16:33, Ben Warren wrote: > >> On Feb 17, 2017, at 2:43 AM, Igor Mammedov > > wrote: >> >> On Thu, 16 Feb 2017 15:15:36 -0800 >> b...@skyportsystems.com wrote: >> >>> From: Ben Warren

Re: [Qemu-devel] [PATCH v15 08/25] block: introduce auto-loading bitmaps

On 02/17/2017 03:48 PM, Kevin Wolf wrote: > Am 17.02.2017 um 13:40 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 17.02.2017 15:09, Kevin Wolf wrote: >>> Am 17.02.2017 um 12:46 hat Vladimir Sementsov-Ogievskiy geschrieben: 16.02.2017 14:49, Kevin Wolf wrote: > Am 16.02.2017 um 12:25 hat

Re: [Qemu-devel] [PATCH v2 2/7] iscsi: Handle -iscsi user/password in bdrv_parse_filename()

On Fri, 02/17 14:26, Kevin Wolf wrote: > It is the one that it put into the QDict by iscsi_parse_iscsi_option(), > which is supposed to be the value from -iscsi. OK! This is what I was missing. :) Fam

Re: [Qemu-devel] [PATCH v2 2/7] iscsi: Handle -iscsi user/password in bdrv_parse_filename()

On Wed, 01/25 12:42, Jeff Cody wrote: > From: Kevin Wolf > > This splits the logic in the old parse_chap() function into a part that > parses the -iscsi options into the new driver-specific options, and > another part that actually applies those options (called apply_chap() >

Re: [Qemu-devel] [PATCH] bcm2835_rng: Use qcrypto_random_bytes() rather than rand()

On 17 February 2017 at 14:05, Daniel P. Berrange wrote: > On Fri, Feb 17, 2017 at 12:22:39PM +, Peter Maydell wrote: >> We should probably improve crypto/random-platform.c to use >> getentropy() if available, which would fix the "BSD or OSX >> host and not using gcrypt or

Re: [Qemu-devel] [PATCH 1/3] qemu-img: Add tests for raw image preallocation

Am 17.02.2017 um 15:20 hat Nir Soffer geschrieben: > On Fri, Feb 17, 2017 at 11:14 AM, Kevin Wolf wrote: > > Am 17.02.2017 um 01:51 hat Nir Soffer geschrieben: > >> Add tests for creating raw image with and without the preallocation > >> option. > >> > >> Signed-off-by: Nir

[Qemu-devel] [PATCH] Makefile: Put VERSION info into version.texi rather than using -D

Unfortunately some older versions of makeinfo don't correctly handle the -D command line option and fail to set the variable. This then causes them to complain docs/qemu-ga-ref.texi:41: warning: undefined flag: VERSION Work around this by doing as the autotools do, and writing the information

Re: [Qemu-devel] [PATCH] hw/arm/virt: fix cpu object reference leak

On Fri, 17 Feb 2017 13:32:15 + Peter Maydell wrote: > On 16 February 2017 at 15:11, Igor Mammedov wrote: > > On Thu, 16 Feb 2017 14:18:05 + > > Peter Maydell wrote: > >> I've always found the object reference

Re: [Qemu-devel] [PATCH v2] target-arm: Implement BCM2835 hardware RNG

On 17 February 2017 at 12:54, Peter Maydell wrote: > On 10 February 2017 at 21:08, Marcin Chojnacki wrote: >> Recent vanilla Raspberry Pi kernels started to make use of >> the hardware random number generator in BCM2835 SoC. As a >> result, those

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

> On Feb 17, 2017, at 2:43 AM, Igor Mammedov wrote: > > On Thu, 16 Feb 2017 15:15:36 -0800 > b...@skyportsystems.com wrote: > >> From: Ben Warren >> >> This implements the VM Generation ID feature by passing a 128-bit >> GUID to the guest via a

Re: [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems.

On 02/17/2017 03:28 AM, Peter Maydell wrote: > On 17 February 2017 at 06:43, Fam Zheng wrote: >> But your point is taken, we should make the first (or a one-shot) >> contribution as easy as possible. > > Yes; we could do with providing a "This page seems very long..." >

[Qemu-devel] [RFC 3/3] machine: generilize cpu_model parsing

Parse cpu_model string into cpu_type and [=-]foo features in common machine code instead of doing the same on every board. TODO: patch handles only virt-arm/spapr/pc boards, but to avoid bisection breakage it should take care of all boards. Signed-off-by: Igor Mammedov ---

[Qemu-devel] [RFC 0/3] generalize parsing of cpu_model

Some callers call CPUClass->parse_features manually to convert '-cpu cpufoo,featurestr' string to cpu type and featurestr into a set of global properties. And theni do controlled cpu creation with setting properties and completing it with realize. That's a lot of code duplication as they are

Re: [Qemu-devel] [PATCH 0/4] cpu: Implement cpu_generic_new()

On Mon, 13 Feb 2017 14:28:15 + Peter Maydell wrote: > This patchset adds a new function cpu_generic_new() > which is similar to cpu_generic_init() except that it > does not realize the created CPU object. This means that > board code can do a "new cpu; set QOM

[Qemu-devel] [PULL 00/23] virtio, pci: fixes, features

The following changes since commit ad584d37f2a86b392c25f3f00cc1f1532676c2d1: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2017-02-16 17:46:52 +) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git

[Qemu-devel] [PULL 17/23] vfio: allow to notify unmap for very large region

From: Peter Xu Linux vfio driver supports to do VFIO_IOMMU_UNMAP_DMA for a very big region. This can be leveraged by QEMU IOMMU implementation to cleanup existing page mappings for an entire iova address space (by notifying with an IOTLB with extremely huge addr_mask). However

[Qemu-devel] [PATCH V2 3/7] cputlb: fix the way get_page_addr_code fills the tlb

From: KONRAD Frederic get_page_addr_code(..) does a cpu_ldub_code to fill the tlb: This can lead to some side effects if a device is mapped at this address. So this patch replaces the cpu_memory_ld by a tlb_fill. Signed-off-by: KONRAD Frederic

[Qemu-devel] [PATCH 3/3] iscsi: do not use aio_context_acquire/release

Now that all bottom halves and callbacks take care of taking the AioContext lock, we can migrate some users away from it and to a specific QemuMutex or CoMutex. Protect libiscsi calls with a QemuMutex. Callbacks are invoked using bottom halves, so we don't even have to drop it around callback

[Qemu-devel] [PATCH 1/3] curl: do not use aio_context_acquire/release

Now that all bottom halves and callbacks take care of taking the AioContext lock, we can migrate some users away from it and to a specific QemuMutex or CoMutex. Protect BDRVCURLState access with a QemuMutex. Signed-off-by: Paolo Bonzini --- block/curl.c | 24

[Qemu-devel] [PATCH 0/3] do not use aio_context_acquire/release in AIO-based drivers

aio_context_acquire/release are only going away as soon as the block layer becomes thread-safe, but we can already move away to other finer-grained mutex whenever possible. These three drivers don't use coroutines, hence a QemuMutex is a fine primitive to use for protecting any per-BDS data in

[Qemu-devel] [PULL 02/23] virtio: Report real progress in VQ aio poll handler

From: Fam Zheng In virtio_queue_host_notifier_aio_poll, not all "!virtio_queue_empty()" cases are making true progress. Currently the offending one is virtio-scsi event queue, whose handler does nothing if no event is pending. As a result aio_poll() will spin on the "non-empty"

[Qemu-devel] [PULL 13/23] virtio: Fix no interrupt when not creating msi controller

For ARM virt machine, if we use virt-2.7 which will not create ITS node, the virtio-net can not recieve interrupts so it can't get ip address through dhcp. This fixes commit 83d768b(virtio: set ISR on dataplane notifications). Signed-off-by: Shannon Zhao Reviewed-by:

[Qemu-devel] [PULL 21/23] intel_iommu: convert dbg macros to traces for inv

From: Peter Xu VT-d codes are still using static DEBUG_INTEL_IOMMU macro. That's not good, and we should end the day when we need to recompile the code before getting useful debugging information for vt-d. Time to switch to the trace system. This is the first patch to do it.

[Qemu-devel] [PULL 09/23] virtio: add MemoryListener to cache ring translations

From: Paolo Bonzini The cached translations are RCU-protected to allow efficient use when processing virtqueues. Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PATCH V2 4/7] exec: allow to get a pointer for some mmio memory region

From: KONRAD Frederic This introduces a special callback which allows to run code from some MMIO devices. SysBusDevice with a MemoryRegion which implements the request_ptr callback will be notified when the guest try to execute code from their offset. Then it will be

[Qemu-devel] [PULL 03/23] docs: add document to explain the usage of vNVDIMM

From: Haozhong Zhang Signed-off-by: Haozhong Zhang Reviewed-by: Xiao Guangrong Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S.

Re: [Qemu-devel] [PATCH] Add missing fp_access_check() to aarch64 crypto instructions

On 17 February 2017 at 17:58, Nick Reilly wrote: > The aarch64 crypto instructions for AES and SHA are missing the > check for if the FPU is enabled. > > Signed-off-by: Nick Reilly Oops, nice catch. Applied to target-arm.next, thanks. -- PMM

Re: [Qemu-devel] [PATCH 15/17] iotests: add default node-name

* Fam Zheng (f...@redhat.com) wrote: > On Fri, 02/17 16:36, Vladimir Sementsov-Ogievskiy wrote: > > 17.02.2017 15:21, Fam Zheng wrote: > > > On Fri, 02/17 13:20, Vladimir Sementsov-Ogievskiy wrote: > > > > 16.02.2017 16:48, Fam Zheng wrote: > > > > > On Mon, 02/13 12:54, Vladimir

[Qemu-devel] [PULL 23/23] intel_iommu: vtd_slpt_level_shift check level

From: Peter Xu This helps in debugging incorrect level passed in. Reviewed-by: Jason Wang Signed-off-by: Peter Xu Reviewed-by: David Gibson Reviewed-by: Michael S. Tsirkin Signed-off-by:

[Qemu-devel] [PULL 01/23] pci/pcie: don't assume cap id 0 is reserved

VFIO actually wants to create a capability with ID == 0. This is done to make guest drivers skip the given capability. pcie_add_capability then trips up on this capability when looking for end of capability list. To support this use-case, it's easy enough to switch to e.g. 0x for these

  1   2   3   >