Re: [Qemu-devel] ping Re: [PATCH V2] target-arm:Add a dynamic XML-description of the cp-registers to GDB

2018-02-12 Thread Abdallah Bouassida
ping http://patchwork.ozlabs.org/patch/867467/ ping http://patchwork.ozlabs.org/patch/867467/ [PATCH V2] target-arm:Add a dynamic XML-description of the cp-registers to GDB This patch offers to GDB the ability to read/write all the coprocessor registers for ARM and ARM64 by generating

[Qemu-devel] [PATCH 2/4] tests/m48t59: Make the test independent of global_qtest

2018-02-12 Thread Thomas Huth
Stop using the functions that require global_qtest here and pass around the QTestState instead (global_qtest should finally get removed since this causes problems with tests running in parallel). Signed-off-by: Thomas Huth --- tests/m48t59-test.c | 60

[Qemu-devel] [PATCH 4/4] tests/m48t59: Add the m48t59 test on ppc, too

2018-02-12 Thread Thomas Huth
The ref405ep machine has a memory-mapped m48t59 device, so we can run the m48t59 test on this machine, too. Signed-off-by: Thomas Huth --- tests/Makefile.include | 2 ++ tests/m48t59-test.c| 9 - 2 files changed, 10 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH 0/4] Re-enable and extend the m48t59 test

2018-02-12 Thread Thomas Huth
This patch series fixes the currently disabled m48t59 test and enables it for ppc, too. Thomas Huth (4): tests/m48t59: Fix and re-enable the test for sparc tests/m48t59: Make the test independent of global_qtest tests/Makefile: Derive check-qtest-ppc64-y from check-qtest-ppc-y

[Qemu-devel] [PATCH 1/4] tests/m48t59: Fix and re-enable the test for sparc

2018-02-12 Thread Thomas Huth
The m48t59 test has been disabled in commit baeddded5fe6fa37d13fb94bf8d ("sparc: disable qtest in make check"), likely due to some timing issues in the bcd_check_time tests which might fail if it gets interrupted for too long. It should be OK to re-enable this test if we make sure that we do not

Re: [Qemu-devel] [PATCH] block: early check for blockers on drive-mirror

2018-02-12 Thread Paolo Bonzini
On 10/02/2018 00:07, John Snow wrote: >> +/* Early check to avoid creating target */ >> +if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_MIRROR_SOURCE, errp)) { >> +return; >> +} >> + >> aio_context = bdrv_get_aio_context(bs); >> aio_context_acquire(aio_context); >> >> >

[Qemu-devel] [PATCH 1/3] qmp: expose s390-specific CPU info

2018-02-12 Thread Viktor Mihajlovski
Presently s390x is the only architecture not exposing specific CPU information via QMP query-cpus. Upstream discussion has shown that it could make sense to report the architecture specific CPU state, e.g. to detect that a CPU has been stopped. With this change the output of query-cpus will look

[Qemu-devel] [PATCH 0/3] add query-cpu-fast and related s390 changes

2018-02-12 Thread Viktor Mihajlovski
This series consolidates patches around a performance issue caused by the usage of QMP query-cpus. A performance issue was found in an OpenStack environment, where ceilometer was collecting domain statistics with libvirt. The domain statistics reported by libvirt include the vCPU halted state,

Re: [Qemu-devel] [PATCH v12 00/30] SDHCI: clean v1/2 Specs, UHS-I cards tuning sequence

2018-02-12 Thread Fam Zheng
On Fri, 02/09 11:54, Philippe Mathieu-Daudé wrote: > This series is expected to be taken by Paolo. > > It includes the last versions of both series: > - SDHCI: clean v1/v2 Specs (part 2) > - SDHCI: add tuning sequence for UHS-I cards (part 3) > > Since v11: > - rebased due to conflict (IMX_USDHC

Re: [Qemu-devel] [PATCH] iotests: Use virtio-blk in 155

2018-02-12 Thread Christian Borntraeger
On 02/12/2018 01:47 PM, Max Reitz wrote: > Only a few select machine types support floppy drives and there is > actually nothing preventing us from using virtio here, so let's do it. > > Reported-by: Christian Borntraeger > Signed-off-by: Max Reitz

Re: [Qemu-devel] [PULL 00/26] virtio, vhost, pci, pc: features, fixes and cleanups

2018-02-12 Thread Peter Maydell
On 9 February 2018 at 17:07, Michael S. Tsirkin wrote: > On Fri, Feb 09, 2018 at 10:06:42AM +, Peter Maydell wrote: >> On 8 February 2018 at 19:08, Michael S. Tsirkin wrote: >> > The following changes since commit >> >

[Qemu-devel] [Bug 1748612] Re: qemu-user option -strace -D doesn't work

2018-02-12 Thread Peter Maydell
This is intentional, more or less. The -D logfile is for the debug logs enabled with -d, not for strace. I think if we wanted to support redirecting strace output to a file we might need to have an extra argument, to avoid breaking existing users. -- You received this bug notification because

[Qemu-devel] [Bug 1748612] Re: qemu-user option -strace -D doesn't work

2018-02-12 Thread Peter Maydell
If you use -D it will create a file named , which will contain any logs created via the qemu_log subsystem (which might be nothing at all, depending on what the guest does). I don't know where the "-strace" part would come from unless you specified it as part of the filename. -- You received

Re: [Qemu-devel] [PULL 06/29] iotests: Make BD-{remove, insert}-medium use @id

2018-02-12 Thread Christian Borntraeger
On 01/23/2018 03:01 PM, Kevin Wolf wrote: > From: Max Reitz > > In some cases, these commands still use the deprecated @device > parameter. Fix that so we can later drop that parameter from their > interface. > > Signed-off-by: Max Reitz > Message-id:

Re: [Qemu-devel] [PULL 06/29] iotests: Make BD-{remove, insert}-medium use @id

2018-02-12 Thread Max Reitz
On 2018-02-12 12:33, Christian Borntraeger wrote: > Adding Max and Alberto, > > I think the issue is that on s390 you cannot add a floppy Thanks for letting me know. I don't know why I resorted to floppy when virtio would have worked (in this test) just as well... Max signature.asc

Re: [Qemu-devel] [PATCH] block: early check for blockers on drive-mirror

2018-02-12 Thread Daniel P . Berrangé
On Mon, Feb 12, 2018 at 10:58:31AM +0100, Paolo Bonzini wrote: > On 10/02/2018 00:07, John Snow wrote: > >> +/* Early check to avoid creating target */ > >> +if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_MIRROR_SOURCE, errp)) { > >> +return; > >> +} > >> + > >> aio_context =

Re: [Qemu-devel] [PULL 06/29] iotests: Make BD-{remove, insert}-medium use @id

2018-02-12 Thread Christian Borntraeger
Adding Max and Alberto, I think the issue is that on s390 you cannot add a floppy On 02/12/2018 12:16 PM, Christian Borntraeger wrote: > > On 01/23/2018 03:01 PM, Kevin Wolf wrote: >> From: Max Reitz >> >> In some cases, these commands still use the deprecated @device >>

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 02/19] spapr: introduce a skeleton for the XIVE interrupt controller

2018-02-12 Thread Andrea Bolognani
On Mon, 2018-02-12 at 13:02 +1100, Alexey Kardashevskiy wrote: > On 12/02/18 09:55, Benjamin Herrenschmidt wrote: > > Well, we have a problem then. It looks like Qemu broken migration is > > fundamentally incompatible with PAPR and CAS design... > > > > I know we don't migrate the configuration,

[Qemu-devel] [PATCH 3/4] tests/Makefile: Derive check-qtest-ppc64-y from check-qtest-ppc-y

2018-02-12 Thread Thomas Huth
ppc64 is a superset of ppc, so the ppc64 tests should include all the ppc tests. Signed-off-by: Thomas Huth --- tests/Makefile.include | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index

Re: [Qemu-devel] [PATCHv2 11/12] ppc: move CUDAState and other CUDA-related definitions into separate cuda.h file

2018-02-12 Thread David Gibson
On Fri, Feb 09, 2018 at 06:51:41PM +, Mark Cave-Ayland wrote: > Signed-off-by: Mark Cave-Ayland Applied, thanks. > --- > hw/misc/macio/cuda.c | 1 + > hw/misc/macio/macio.c| 1 + > hw/ppc/mac.h | 77

[Qemu-devel] [PATCH 3/3] qmp: add architecture specific cpu data for query-cpus-fast

2018-02-12 Thread Viktor Mihajlovski
The s390 CPU state can be retrieved without interrupting the VM execution. Extendend the CpuInfoFast union with architecture specific data and an implementation for s390. Return data looks like this: [ {"thread-id":64301,"props":{"core-id":0}, "arch":"s390","cpu-state":"operating",

Re: [Qemu-devel] [Qemu-block] [PATCH] block: early check for blockers on drive-mirror

2018-02-12 Thread Kevin Wolf
Am 12.02.2018 um 11:02 hat Daniel P. Berrangé geschrieben: > On Mon, Feb 12, 2018 at 10:58:31AM +0100, Paolo Bonzini wrote: > > On 10/02/2018 00:07, John Snow wrote: > > >> +/* Early check to avoid creating target */ > > >> +if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_MIRROR_SOURCE, errp)) {

[Qemu-devel] [Bug 1748612] Re: qemu-user option -strace -D doesn't work

2018-02-12 Thread mou
I will check that again, pretty sure I saw that. Anyway any chance there is an option/fix for that? Today it is impossible to differentiate strace output with program's stderr output, and it is causing trouble while used in scripts. -- You received this bug notification because you are a member

Re: [Qemu-devel] [PATCH v3] spapr: set vsmt to MAX(8, smp_threads)

2018-02-12 Thread Greg Kurz
On Sat, 10 Feb 2018 20:23:07 +1100 David Gibson wrote: > On Fri, Feb 09, 2018 at 03:06:49PM +0100, Greg Kurz wrote: > > On Fri, 9 Feb 2018 09:18:58 +0100 > > Laurent Vivier wrote: > > > > > We ignore silently the value of smp_threads when we

[Qemu-devel] [PATCH v2] docs: document our stable process

2018-02-12 Thread Cornelia Huck
Some pointers on how to get a patch into stable. [contains some suggestions by mdroth] Signed-off-by: Cornelia Huck --- RFC/D->v2: added mdroth's suggestions --- docs/stable-process.rst | 67 + 1 file changed, 67 insertions(+)

Re: [Qemu-devel] [Qemu-block] [PATCH] block: early check for blockers on drive-mirror

2018-02-12 Thread Daniel P . Berrangé
On Mon, Feb 12, 2018 at 01:42:11PM +0100, Kevin Wolf wrote: > Am 12.02.2018 um 11:02 hat Daniel P. Berrangé geschrieben: > > On Mon, Feb 12, 2018 at 10:58:31AM +0100, Paolo Bonzini wrote: > > > On 10/02/2018 00:07, John Snow wrote: > > > >> +/* Early check to avoid creating target */ > > > >>

Re: [Qemu-devel] ping Re: [PATCH V2] target-arm:Add a dynamic XML-description of the cp-registers to GDB

2018-02-12 Thread Peter Maydell
On 12 February 2018 at 12:07, Abdallah Bouassida wrote: > ping > http://patchwork.ozlabs.org/patch/867467/ > > > ping > http://patchwork.ozlabs.org/patch/867467/ Hi -- thanks for the ping. I've been a bit busy recently but this is in my queue to look at and I'm

Re: [Qemu-devel] [PULL 0/2] NBD patches through 2018-02-09

2018-02-12 Thread Peter Maydell
On 9 February 2018 at 19:08, Eric Blake wrote: > The following changes since commit c7b02d7d032d6022060e4b393827c963c93ce63f: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-travis-speedup-090218-1' into staging (2018-02-09 > 16:12:34 +) > > are available

[Qemu-devel] [Bug 1748612] Re: qemu-user option -strace -D doesn't work

2018-02-12 Thread mou
If this is not for strace, then why when I launch qemu as subprocess (example: from a python script) with option -strace -D it creates a log file called -strace? Seems like a bug to me. Anyway, I understand you don't want to break the current behavior, is there any chance this gets added in

[Qemu-devel] [PATCH 2/3] qmp: add query-cpus-fast

2018-02-12 Thread Viktor Mihajlovski
From: Luiz Capitulino The query-cpus command has an extremely serious side effect: it always interrupts all running vCPUs so that they can run ioctl calls. This can cause a huge performance degradation for some workloads. And most of the information retrieved by the ioctl

[Qemu-devel] [PATCH] iotests: Use virtio-blk in 155

2018-02-12 Thread Max Reitz
Only a few select machine types support floppy drives and there is actually nothing preventing us from using virtio here, so let's do it. Reported-by: Christian Borntraeger Signed-off-by: Max Reitz --- tests/qemu-iotests/155 | 14 +- 1

Re: [Qemu-devel] [PATCHv2 12/12] cuda: convert to trace-events

2018-02-12 Thread David Gibson
On Fri, Feb 09, 2018 at 06:51:42PM +, Mark Cave-Ayland wrote: > Signed-off-by: Mark Cave-Ayland Applied, thanks. > --- > Makefile.objs | 1 + > hw/misc/macio/cuda.c | 50 > -- >

Re: [Qemu-devel] [PATCH 3/3] qapi: Rename .json to .qapi

2018-02-12 Thread Marc-André Lureau
Hi On Mon, Feb 12, 2018 at 10:52 AM, Daniel P. Berrangé wrote: > On Sat, Feb 10, 2018 at 06:40:13PM -0600, Eric Blake wrote: >> Our QAPI input files aren't quite true JSON (comments being the obvious >> difference); naming things .json doesn't make that obvious. Use a new

Re: [Qemu-devel] [PATCH RFC/D] docs: document our stable process

2018-02-12 Thread Cornelia Huck
On Sun, 11 Feb 2018 21:03:02 -0600 Michael Roth wrote: > Quoting Cornelia Huck (2018-02-09 07:11:12) > > Some pointers on how to get a patch into stable. > > Thanks for putting this together. I made some minor suggestions below > that might help clarify some points.

Re: [Qemu-devel] [PATCH 11/27] block: x-blockdev-create QMP command

2018-02-12 Thread Max Reitz
On 2018-02-08 20:23, Kevin Wolf wrote: > This adds a synchronous x-blockdev-create QMP command that can create > qcow2 images on a given node name. > > We don't want to block while creating an image, so this is not the final > interface in all aspects, but BlockdevCreateOptionsQcow2 and >

Re: [Qemu-devel] [PATCH v2 4/8] mem/nvdimm: ensure write persistence to PMEM in label emulation

2018-02-12 Thread Stefan Hajnoczi
On Fri, Feb 09, 2018 at 10:57:26PM +0800, Haozhong Zhang wrote: > On 02/09/18 14:27 +, Stefan Hajnoczi wrote: > > On Wed, Feb 07, 2018 at 03:33:27PM +0800, Haozhong Zhang wrote: > > > @@ -156,11 +157,17 @@ static void nvdimm_write_label_data(NVDIMMDevice > > > *nvdimm, const void *buf, > > >

Re: [Qemu-devel] [PATCH 13/27] file-win32: Support .bdrv_co_create

2018-02-12 Thread Max Reitz
On 2018-02-08 20:23, Kevin Wolf wrote: > This adds the .bdrv_co_create driver callback to file-win32, which > enables image creation over QMP. > > Signed-off-by: Kevin Wolf > --- > block/file-win32.c | 45 + > 1 file changed, 37

Re: [Qemu-devel] [PATCH 07/27] qcow2: Handle full/falloc preallocation in qcow2_create2()

2018-02-12 Thread Max Reitz
On 2018-02-08 20:23, Kevin Wolf wrote: > Once qcow2_create2() can be called directly on an already existing node, > we must provide the 'full' and 'falloc' preallocation modes outside of > creating the image on the protocol layer. Fortunately, we have > preallocated truncate now which can provide

Re: [Qemu-devel] [PATCH 14/27] gluster: Support .bdrv_co_create

2018-02-12 Thread Max Reitz
On 2018-02-08 20:23, Kevin Wolf wrote: > This adds the .bdrv_co_create driver callback to gluster, which enables > image creation over QMP. > > Signed-off-by: Kevin Wolf > --- > qapi/block-core.json | 18 ++- > block/gluster.c | 149 >

Re: [Qemu-devel] "make check -j4" hangs

2018-02-12 Thread klim
On 02/09/2018 02:55 PM, Paolo Bonzini wrote: On 08/02/2018 22:54, Alistair Francis wrote: On Thu, Feb 8, 2018 at 1:12 PM, Peter Maydell wrote: On 8 February 2018 at 19:13, Thomas Huth wrote: I'm currently facing some issues with "make check -j4"

Re: [Qemu-devel] [PULL 00/17] Trivial patches for 2018-02-10

2018-02-12 Thread Peter Maydell
On 10 February 2018 at 07:54, Michael Tokarev wrote: > Here's a next pull request for the trivial-patches tree. > After a very long delay. > > Hopefully I still remember how to apply patches :) > > The following changes since commit c7b02d7d032d6022060e4b393827c963c93ce63f: > >

[Qemu-devel] [PATCH v8 09/28] target/i386: add Secure Encrypted Virtulization (SEV) object

2018-02-12 Thread Brijesh Singh
Add a new memory encryption object 'sev-guest'. The object will be used to create enrypted VMs on AMD EPYC CPU. The object provides the properties to pass guest owner's public Diffie-hellman key, guest policy and session information required to create the memory encryption context within the SEV

[Qemu-devel] [PATCH v8 04/28] monitor/i386: use debug APIs when accessing guest memory

2018-02-12 Thread Brijesh Singh
Updates HMP commands to use the debug version of APIs when accessing the guest memory. Cc: Paolo Bonzini Cc: Peter Crosthwaite Cc: Richard Henderson Cc: "Dr. David Alan Gilbert" Cc: Markus Armbruster

Re: [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-12 Thread Richard Palethorpe
Hello, Juan Quintela writes: > "Daniel P. Berrange" wrote: >> On Thu, Jan 11, 2018 at 01:23:05PM +, Dr. David Alan Gilbert wrote: >>> * Daniel P. Berrange (berra...@redhat.com) wrote: >>> > On Thu, Jan 11, 2018 at 01:46:38PM +0100, Max Reitz wrote: >>> > > On 2018-01-08

[Qemu-devel] [PATCH v3 0/1] dump.c: allow fd_write_vmcore to return errno on failure

2018-02-12 Thread Daniel Henrique Barboza
v3: - added set_errg_errno() to all callers of fd_write_vmcore - changed patch subject to reflect what it is addressing now - link to previous version: http://lists.gnu.org/archive/html/qemu-devel/2018-02/msg02787.html Yasmin Beatriz (1): dump.c: allow fd_write_vmcore to return errno on

[Qemu-devel] [PATCH v8 03/28] exec: add debug version of physical memory read and write API

2018-02-12 Thread Brijesh Singh
Adds the following new APIs - cpu_physical_memory_read_debug - cpu_physical_memory_write_debug - cpu_physical_memory_rw_debug - ldl_phys_debug - ldq_phys_debug Cc: Paolo Bonzini Cc: Peter Crosthwaite Cc: Richard Henderson

[Qemu-devel] [PATCH v8 10/28] sev/i386: add command to initialize the memory encryption context

2018-02-12 Thread Brijesh Singh
When memory encryption is enabled, KVM_SEV_INIT command is used to initialize the platform. The command loads the SEV related persistent data from non-volatile storage and initializes the platform context. This command should be first issued before invoking any other guest commands provided by the

[Qemu-devel] [PATCH v8 12/28] kvm: introduce memory encryption APIs

2018-02-12 Thread Brijesh Singh
Inorder to integerate the Secure Encryption Virtualization (SEV) support add few high-level memory encryption APIs which can be used for encrypting the guest memory region. Cc: Paolo Bonzini Cc: k...@vger.kernel.org Signed-off-by: Brijesh Singh ---

[Qemu-devel] [PATCH v8 15/28] sev/i386: add command to create launch memory encryption context

2018-02-12 Thread Brijesh Singh
The KVM_SEV_LAUNCH_START command creates a new VM encryption key (VEK). The encryption key created with the command will be used for encrypting the bootstrap images (such as guest bios). Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost

Re: [Qemu-devel] [PATCH 0/3] add query-cpu-fast and related s390 changes

2018-02-12 Thread Cornelia Huck
On Mon, 12 Feb 2018 13:14:29 +0100 Viktor Mihajlovski wrote: > This series consolidates patches around a performance issue > caused by the usage of QMP query-cpus. Thank you for consolidating this; it was a bit hard to follow the different discussions. > > A

Re: [Qemu-devel] [PATCH v2 1/2] iotest 033: add misaligned write-zeroes test via truncate

2018-02-12 Thread Alberto Garcia
On Mon 12 Feb 2018 02:14:00 PM CET, Anton Nefedov wrote: > +# Trigger truncate that would shrink qcow2 L1 table, which is done by > +# clearing one entry (8 bytes) with bdrv_co_pwrite_zeroes() > + > +echo > +echo "=== Test misaligned write zeroes via truncate ===" > +echo > + >

Re: [Qemu-devel] [PATCH 1/3] block: add BlockBackend->in_flight counter

2018-02-12 Thread Stefan Hajnoczi
On Fri, Feb 09, 2018 at 06:26:41PM +0100, Paolo Bonzini wrote: > On 09/02/2018 18:23, Kevin Wolf wrote: > > Am 09.02.2018 um 17:28 hat Paolo Bonzini geschrieben: > >> On 08/02/2018 18:18, Stefan Hajnoczi wrote: > >>> +BlockDriverState *bs = blk_bs(blk); > >>> + > >>> +if (bs) { > >>> +

Re: [Qemu-devel] [PATCH 2/2] scsi: add block job opblockers for scsi-block

2018-02-12 Thread Paolo Bonzini
On 12/02/2018 15:30, Kevin Wolf wrote: >>> We shouldn't be adding new instances of BLOCK_OP_* at all. I couldn't >>> find the time yet to remove the existing ones, but any new protections >>> should be using the permission system. >> I agree. But does this include not fixing bugs wherever clients

Re: [Qemu-devel] [PATCH v3 1/1] dump.c: allow fd_write_vmcore to return errno on failure

2018-02-12 Thread Murilo Opsfelder Araujo
On 02/12/2018 12:25 PM, Daniel Henrique Barboza wrote: > From: Yasmin Beatriz > > fd_write_vmcore can fail to execute for a lot of reasons that can be > retrieved by errno, but it only returns -1. This makes difficult for > the caller to know what happened and only a

Re: [Qemu-devel] [PATCH] iotests: Use virtio-blk in 155

2018-02-12 Thread Kevin Wolf
Am 12.02.2018 um 13:47 hat Max Reitz geschrieben: > Only a few select machine types support floppy drives and there is > actually nothing preventing us from using virtio here, so let's do it. > > Reported-by: Christian Borntraeger > Signed-off-by: Max Reitz

Re: [Qemu-devel] [PATCH 1/4] multiboot: Change multiboot_info from array of bytes to a C struct

2018-02-12 Thread Kevin Wolf
Am 09.02.2018 um 22:52 hat Anatol Pomozov geschrieben: > Actually I just fetched recent chnages and tests/multiboot/run_test.sh > does not work for me anymore. I rebuilt 'master' branch without my > changes and see the same issue. It looks like debug console does not > print to stdio anymore. > >

Re: [Qemu-devel] [PATCH 2/2] scsi: add block job opblockers for scsi-block

2018-02-12 Thread Kevin Wolf
Am 12.02.2018 um 15:00 hat Paolo Bonzini geschrieben: > On 12/02/2018 14:52, Kevin Wolf wrote: > > Am 08.02.2018 um 11:42 hat Paolo Bonzini geschrieben: > >> On 08/02/2018 02:35, Fam Zheng wrote: > >>> On Wed, 02/07 17:36, Paolo Bonzini wrote: > @@ -2626,6 +2656,36 @@ static void

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 02/19] spapr: introduce a skeleton for the XIVE interrupt controller

2018-02-12 Thread Benjamin Herrenschmidt
On Mon, 2018-02-12 at 13:20 +0100, Andrea Bolognani wrote: > On Mon, 2018-02-12 at 13:02 +1100, Alexey Kardashevskiy wrote: > > On 12/02/18 09:55, Benjamin Herrenschmidt wrote: > > > Well, we have a problem then. It looks like Qemu broken migration is > > > fundamentally incompatible with PAPR and

Re: [Qemu-devel] [PATCH 2/2] scsi: add block job opblockers for scsi-block

2018-02-12 Thread Kevin Wolf
Am 12.02.2018 um 15:32 hat Paolo Bonzini geschrieben: > On 12/02/2018 15:30, Kevin Wolf wrote: > >>> We shouldn't be adding new instances of BLOCK_OP_* at all. I couldn't > >>> find the time yet to remove the existing ones, but any new protections > >>> should be using the permission system. > >>

[Qemu-devel] [PATCH v8 08/28] docs: add AMD Secure Encrypted Virtualization (SEV)

2018-02-12 Thread Brijesh Singh
Create a documentation entry to describe the AMD Secure Encrypted Virtualization (SEV) feature. Cc: Paolo Bonzini Signed-off-by: Brijesh Singh --- docs/amd-memory-encryption.txt | 92 ++ 1 file changed, 92

[Qemu-devel] [PATCH v8 07/28] kvm: update kvm.h to include memory encryption ioctls

2018-02-12 Thread Brijesh Singh
Updates kmv.h to include memory encryption ioctls and SEV commands. Cc: Christian Borntraeger Cc: Cornelia Huck Cc: Paolo Bonzini Signed-off-by: Brijesh Singh --- linux-headers/linux/kvm.h | 90

[Qemu-devel] [PATCH v8 26/28] qmp: add query-sev-launch-measure command

2018-02-12 Thread Brijesh Singh
The command can be used by libvirt to retrieve the measurement of SEV guest. This measurement is a signature of the memory contents that was encrypted through the LAUNCH_UPDATE_DATA. Cc: "Daniel P. Berrangé" Cc: "Dr. David Alan Gilbert" Cc: Markus

[Qemu-devel] [PATCH v8 18/28] sev/i386: add support to LAUNCH_MEASURE command

2018-02-12 Thread Brijesh Singh
During machine creation we encrypted the guest bios image, the LAUNCH_MEASURE command can be used to retrieve the measurement of the encrypted memory region. This measurement is a signature of the memory contents that can be sent to the guest owner as an attestation that the memory was encrypted

[Qemu-devel] [PATCH v8 28/28] sev/i386: add migration blocker

2018-02-12 Thread Brijesh Singh
SEV guest migration is not implemented yet. Signed-off-by: Brijesh Singh Reviewed-by: Dr. David Alan Gilbert --- target/i386/sev.c | 13 + 1 file changed, 13 insertions(+) diff --git a/target/i386/sev.c b/target/i386/sev.c index

Re: [Qemu-devel] [PATCH] s390/stattrib: Make SaveVMHandlers data static

2018-02-12 Thread David Hildenbrand
On 12.02.2018 16:49, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > There's no need for this to be dynamic, make it static. > > Signed-off-by: Dr. David Alan Gilbert > --- > hw/s390x/s390-stattrib.c | 26

Re: [Qemu-devel] [PATCH 12/27] file-posix: Support .bdrv_co_create

2018-02-12 Thread Max Reitz
On 2018-02-08 20:23, Kevin Wolf wrote: > This adds the .bdrv_co_create driver callback to file, which enables > image creation over QMP. > > Signed-off-by: Kevin Wolf > --- > qapi/block-core.json | 20 +- > block/file-posix.c | 77 >

Re: [Qemu-devel] [PATCH 2/3] block: test blk_aio_flush() with blk->root == NULL

2018-02-12 Thread Stefan Hajnoczi
On Fri, Feb 09, 2018 at 09:23:53AM -0600, Eric Blake wrote: > On 02/08/2018 11:18 AM, Stefan Hajnoczi wrote: > > From: Kevin Wolf > > > > This patch adds test cases for the scenario where blk_aio_flush() is > > called on a BlockBackend with no root. Calling drain afterwards

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

2018-02-12 Thread Igor Mammedov
On Fri, 9 Feb 2018 15:19:31 -0500 Stefan Berger wrote: > On 01/16/2018 10:51 AM, Stefan Berger wrote: > > The TPM Physical Presence interface consists of an ACPI part, a shared > > memory part, and code in the firmware. Users can send messages to the > > firmware by

[Qemu-devel] [PATCH v8 02/28] exec: add ram_debug_ops support

2018-02-12 Thread Brijesh Singh
Currently, the guest memory access for the debug purpose is performed using the memcpy(). Lets extend the 'struct MemoryRegion' to include ram_debug_ops callbacks. The ram_debug_ops can be used to override memcpy() with something else. The feature can be used by encrypted guest -- which can

[Qemu-devel] [PATCH v8 19/28] sev/i386: finalize the SEV guest launch flow

2018-02-12 Thread Brijesh Singh
SEV launch flow requires us to issue LAUNCH_FINISH command before guest is ready to run. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Signed-off-by: Brijesh Singh --- target/i386/sev.c|

[Qemu-devel] [PATCH] s390/stattrib: Make SaveVMHandlers data static

2018-02-12 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" There's no need for this to be dynamic, make it static. Signed-off-by: Dr. David Alan Gilbert --- hw/s390x/s390-stattrib.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git

[Qemu-devel] [PATCH v8 22/28] target/i386: clear C-bit when walking SEV guest page table

2018-02-12 Thread Brijesh Singh
In SEV-enabled guest the pte entry will have C-bit set, we need to clear the C-bit when walking the page table. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Signed-off-by: Brijesh Singh ---

Re: [Qemu-devel] [PATCH v2] tests/migration: Add source to PC boot block

2018-02-12 Thread Andrew Jones
On Mon, Feb 05, 2018 at 06:18:46PM +, Dr. David Alan Gilbert (git) wrote: > diff --git a/tests/migration/rebuild-x86-bootblock.sh > b/tests/migration/rebuild-x86-bootblock.sh > new file mode 100755 > index 00..c40f025e1a > --- /dev/null > +++ b/tests/migration/rebuild-x86-bootblock.sh

Re: [Qemu-devel] [PATCH 1/4] multiboot: Change multiboot_info from array of bytes to a C struct

2018-02-12 Thread Kevin Wolf
Am 09.02.2018 um 22:48 hat Anatol Pomozov geschrieben: > Hi Kevin > > Is the patch series look good? Are there any other unresolved issues? This is the email thread for the first version. No, it doesn't look good. In the thread for your second version, Jack had a few comments that you didn't

Re: [Qemu-devel] [PATCH 2/2] scsi: add block job opblockers for scsi-block

2018-02-12 Thread Kevin Wolf
Am 08.02.2018 um 11:42 hat Paolo Bonzini geschrieben: > On 08/02/2018 02:35, Fam Zheng wrote: > > On Wed, 02/07 17:36, Paolo Bonzini wrote: > >> @@ -2626,6 +2656,36 @@ static void scsi_block_realize(SCSIDevice *dev, > >> Error **errp) > >> > >> scsi_realize(>qdev, errp); > >>

Re: [Qemu-devel] [PATCH 2/2] scsi: add block job opblockers for scsi-block

2018-02-12 Thread Paolo Bonzini
On 12/02/2018 14:52, Kevin Wolf wrote: > Am 08.02.2018 um 11:42 hat Paolo Bonzini geschrieben: >> On 08/02/2018 02:35, Fam Zheng wrote: >>> On Wed, 02/07 17:36, Paolo Bonzini wrote: @@ -2626,6 +2656,36 @@ static void scsi_block_realize(SCSIDevice *dev, Error **errp)

Re: [Qemu-devel] [PATCH 2/2] scsi: add block job opblockers for scsi-block

2018-02-12 Thread Paolo Bonzini
On 12/02/2018 15:48, Kevin Wolf wrote: > Am 12.02.2018 um 15:32 hat Paolo Bonzini geschrieben: >> Okay, we are in agreement about this and you expressed very well why I >> (at the gut feeling level) didn't like the old op blockers. But you >> bypassed the real question, which is: should I send a

Re: [Qemu-devel] [PATCH v2 2/2] block: fix write with zero flag set and iovector provided

2018-02-12 Thread Alberto Garcia
On Mon 12 Feb 2018 02:14:01 PM CET, Anton Nefedov wrote: > The normal bdrv_co_pwritev() use is either > - BDRV_REQ_ZERO_WRITE clear and iovector provided > - BDRV_REQ_ZERO_WRITE set and iovector == NULL > > while > - the flag clear and iovector == NULL is an assertion failure > in

Re: [Qemu-devel] [PATCH 15/27] rbd: Support .bdrv_co_create

2018-02-12 Thread Max Reitz
On 2018-02-08 20:23, Kevin Wolf wrote: > This adds the .bdrv_co_create driver callback to rbd, which enables > image creation over QMP. > > Signed-off-by: Kevin Wolf > --- > qapi/block-core.json | 20 +++- > block/rbd.c | 137 >

[Qemu-devel] [PATCH v8 05/28] target/i386: add memory encryption feature cpuid support

2018-02-12 Thread Brijesh Singh
AMD EPYC processors support memory encryption feature. The feature is reported through CPUID 8000_001F[EAX]. Fn8000_001F [EAX]: Bit 0 Secure Memory Encryption (SME) supported Bit 1 Secure Encrypted Virtualization (SEV) supported Bit 2 Page flush MSR supported Bit 3 Ecrypted State

[Qemu-devel] [PATCH v8 14/28] hmp: add 'info sev' command

2018-02-12 Thread Brijesh Singh
The command can be used to show the SEV information when memory encryption is enabled on AMD platform. Cc: "Daniel P. Berrangé" Cc: "Dr. David Alan Gilbert" Cc: Markus Armbruster Signed-off-by: Brijesh Singh

[Qemu-devel] [PATCH v8 06/28] machine: add -memory-encryption property

2018-02-12 Thread Brijesh Singh
When CPU supports memory encryption feature, the property can be used to specify the encryption object to use when launching an encrypted guest. Cc: Paolo Bonzini Cc: Eduardo Habkost Cc: Marcel Apfelbaum Cc: Stefan Hajnoczi

[Qemu-devel] [PATCH v8 17/28] target/i386: encrypt bios rom

2018-02-12 Thread Brijesh Singh
SEV requires that guest bios must be encrypted before booting the guest. Cc: "Michael S. Tsirkin" Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Signed-off-by: Brijesh Singh ---

[Qemu-devel] [PATCH v8 16/28] sev/i386: add command to encrypt guest memory region

2018-02-12 Thread Brijesh Singh
The KVM_SEV_LAUNCH_UPDATE_DATA command is used to encrypt a guest memory region using the VM Encryption Key created using LAUNCH_START. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Signed-off-by: Brijesh Singh

[Qemu-devel] [PATCH v8 27/28] tests/qmp-test: blacklist query-sev-launch-measure command

2018-02-12 Thread Brijesh Singh
The query-sev-launch-measure command returns a measurement of encrypted memory when SEV is enabled otherwise it returns an error. Blacklist the command in qmp-test to fix the 'make check' failure. Cc: "Daniel P. Berrangé" Cc: "Dr. David Alan Gilbert"

Re: [Qemu-devel] [PATCH v3 1/1] dump.c: allow fd_write_vmcore to return errno on failure

2018-02-12 Thread Marc-Andre Lureau
Hi On Mon, Feb 12, 2018 at 3:25 PM, Daniel Henrique Barboza wrote: > From: Yasmin Beatriz > > fd_write_vmcore can fail to execute for a lot of reasons that can be > retrieved by errno, but it only returns -1. This makes difficult for >

[Qemu-devel] [PATCH v8 00/28] x86: Secure Encrypted Virtualization (AMD)

2018-02-12 Thread Brijesh Singh
This patch series provides support for AMD's new Secure Encrypted Virtualization (SEV) feature. SEV is an extension to the AMD-V architecture which supports running multiple VMs under the control of a hypervisor. The SEV feature allows the memory contents of a virtual machine (VM) to be

[Qemu-devel] [PATCH v8 01/28] memattrs: add debug attribute

2018-02-12 Thread Brijesh Singh
Extend the MemTxAttrs to include 'debug' flag. The flag can be used as general indicator that operation was triggered by the debugger. Later in the patch series we set the debug=1 when issuing a memory access from the gdbstub or HMP commands. This patch is prerequisite to support debugging the

[Qemu-devel] [PATCH v8 11/28] sev/i386: register the guest memory range which may contain encrypted data

2018-02-12 Thread Brijesh Singh
When SEV is enabled, the hardware encryption engine uses a tweak such that the two identical plaintext at different location will have a different ciphertexts. So swapping or moving a ciphertexts of two guest pages will not result in plaintexts being swapped. Hence relocating a physical backing

[Qemu-devel] [PATCH v8 20/28] hw/i386: set ram_debug_ops when memory encryption is enabled

2018-02-12 Thread Brijesh Singh
When memory encryption is enabled, the guest RAM and boot flash ROM will contain the encrypted data. By setting the debug ops allow us to invoke encryption APIs when accessing the memory for the debug purposes. Cc: Paolo Bonzini Cc: Richard Henderson Cc:

[Qemu-devel] [PATCH v2 2/2] block: fix write with zero flag set and iovector provided

2018-02-12 Thread Anton Nefedov
The normal bdrv_co_pwritev() use is either - BDRV_REQ_ZERO_WRITE clear and iovector provided - BDRV_REQ_ZERO_WRITE set and iovector == NULL while - the flag clear and iovector == NULL is an assertion failure in bdrv_co_do_zero_pwritev() - the flag set and iovector provided is in fact

[Qemu-devel] [PATCH v2 0/2] block: fix write with zero flag set and iovector provided

2018-02-12 Thread Anton Nefedov
v2: patch 1: commit message fixed test added (patch 2) v1: http://lists.nongnu.org/archive/html/qemu-devel/2018-02/msg00131.html Anton Nefedov (2): iotest 033: add misaligned write-zeroes test via truncate block: fix write with zero flag set and iovector provided block/io.c

[Qemu-devel] [PATCH v2 1/2] iotest 033: add misaligned write-zeroes test via truncate

2018-02-12 Thread Anton Nefedov
This new test case only makes sense for qcow2 while iotest 033 is generic; however it matches the test purpose perfectly and also 033 contains those do_test() tricks to pass the alignment, which won't look nice being duplicated in other tests or moved to the common code. Signed-off-by: Anton

[Qemu-devel] [PATCH] virtio-pci: trivial fixes in error message

2018-02-12 Thread Greg Kurz
Signed-off-by: Greg Kurz --- hw/virtio/virtio-pci.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index c20537f31de7..ae3e8e1ca9b8 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio-pci.c @@ -1585,7

[Qemu-devel] [PATCH v3 1/1] dump.c: allow fd_write_vmcore to return errno on failure

2018-02-12 Thread Daniel Henrique Barboza
From: Yasmin Beatriz fd_write_vmcore can fail to execute for a lot of reasons that can be retrieved by errno, but it only returns -1. This makes difficult for the caller to know what happened and only a generic error message is propagated back to the user. This is an

Re: [Qemu-devel] [PATCH v2] tests/migration: Add source to PC boot block

2018-02-12 Thread Dr. David Alan Gilbert
* Andrew Jones (drjo...@redhat.com) wrote: > On Mon, Feb 05, 2018 at 06:18:46PM +, Dr. David Alan Gilbert (git) wrote: > > diff --git a/tests/migration/rebuild-x86-bootblock.sh > > b/tests/migration/rebuild-x86-bootblock.sh > > new file mode 100755 > > index 00..c40f025e1a > > ---

Re: [Qemu-devel] [PATCH 16/27] nfs: Use QAPI options in nfs_client_open()

2018-02-12 Thread Max Reitz
On 2018-02-08 20:23, Kevin Wolf wrote: > Using the QAPI visitor to turn all options into QAPI BlockdevOptionsNfs > simplifies the code a lot. It will also be useful for implementing the > QAPI based .bdrv_co_create callback. > > Signed-off-by: Kevin Wolf > --- > block/nfs.c |

[Qemu-devel] [PATCH v8 13/28] qmp: add query-sev command

2018-02-12 Thread Brijesh Singh
The QMP query command can used to retrieve the SEV information when memory encryption is enabled on AMD platform. Cc: "Daniel P. Berrangé" Cc: "Dr. David Alan Gilbert" Cc: Markus Armbruster Signed-off-by: Brijesh Singh

[Qemu-devel] [PATCH v8 21/28] sev/i386: add debug encrypt and decrypt commands

2018-02-12 Thread Brijesh Singh
KVM_SEV_DBG_DECRYPT and KVM_SEV_DBG_ENCRYPT commands are used for decrypting and encrypting guest memory region. The command works only if the guest policy allows the debugging. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost

[Qemu-devel] [PATCH v8 23/28] include: add psp-sev.h header file

2018-02-12 Thread Brijesh Singh
The header file provide the ioctl command and structure to communicate with /dev/sev device. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Signed-off-by: Brijesh Singh ---

  1   2   3   4   >