Re: [Qemu-devel] [PATCH v3 07/12] vfio/pci: register sva notifier

2018-03-06 Thread Liu, Yi L
> From: Peter Xu [mailto:pet...@redhat.com] > Sent: Tuesday, March 6, 2018 2:45 PM > Subject: Re: [PATCH v3 07/12] vfio/pci: register sva notifier > > On Thu, Mar 01, 2018 at 06:33:30PM +0800, Liu, Yi L wrote: > > This patch shows how sva notifier is registered. And provided an > > example by regi

Re: [Qemu-devel] [PATCH v2] pc-bios/s390-ccw: Move string arrays from bootmap header to .c file

2018-03-06 Thread Christian Borntraeger
On 03/06/2018 07:18 AM, Thomas Huth wrote: > bootmap.h can currently only be included once - otherwise the linker > complains about multiple definitions of the "magic" strings. It's a > bad style to define string arrays in header files, so let's better > move these to the bootmap.c file instead w

Re: [Qemu-devel] [PATCH v2] s390x/sclpconsole: Remove dead code - delete error handlers

2018-03-06 Thread Christian Borntraeger
On 03/05/2018 06:49 PM, Nia Alarie wrote: > The other event handlers (quiesce and cpu) do not define these > handlers, and this one does nothing, so it can be removed. > > virtio_ccw_exit always returns 0, so change its return type to > void. > > Signed-off-by: Nia Alarie I would like to hav

Re: [Qemu-devel] [PATCH 0/7] memory: address_space_to_flatview needs RCU lock

2018-03-06 Thread Paolo Bonzini
On 06/03/2018 08:47, Alexey Kardashevskiy wrote: > On 05/03/18 19:36, Paolo Bonzini wrote: >> I noticed that the introduction of flatview_{read,write} placed >> address_space_to_flatview outside the RCU lock. This is wrong and has >> to be fixed, because address_space_to_flatview does an atomic_rc

Re: [Qemu-devel] [PATCH] tap: delete tap(net client) if net_init_tap_one failed

2018-03-06 Thread Jason Wang
On 2018年03月06日 13:11, linzhecheng wrote: If net_init_tap_one failed but net_tap_fd_init succeeded, we should delete the TAPState *s without vhostforce and has_vhostforce flag. Signed-off-by: linzhecheng Applied and queued for stable. Thanks diff --git a/net/tap.c b/net/tap.c index 2b3a3

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 3/3] s390x/sclp: extend SCLP event masks to 64 bits

2018-03-06 Thread Christian Borntraeger
On 03/05/2018 04:27 PM, Cornelia Huck wrote: > On Fri, 2 Mar 2018 10:44:46 +0100 > Christian Borntraeger wrote: > >> On 02/23/2018 06:42 PM, Claudio Imbrenda wrote: >>> Extend the SCLP event masks to 64 bits. >>> >>> Notice that using any of the new bits results in a state that cannot be >>> mi

Re: [Qemu-devel] [PATCH v2] s390x/sclpconsole: Remove dead code - delete error handlers

2018-03-06 Thread Cornelia Huck
On Tue, 6 Mar 2018 09:13:33 +0100 Christian Borntraeger wrote: > On 03/05/2018 06:49 PM, Nia Alarie wrote: > > The other event handlers (quiesce and cpu) do not define these > > handlers, and this one does nothing, so it can be removed. > > > > virtio_ccw_exit always returns 0, so change its ret

[Qemu-devel] [PATCH v2 1/3] spice: drop dprint() debug logging

2018-03-06 Thread Gerd Hoffmann
Some calls are deleted, some are converted into tracepoints. Signed-off-by: Gerd Hoffmann --- ui/spice-display.c | 75 -- ui/trace-events| 9 +++ 2 files changed, 31 insertions(+), 53 deletions(-) diff --git a/ui/spice-display.c b/ui/

[Qemu-devel] [PATCH v2 0/3] spice: add support for dmabufs

2018-03-06 Thread Gerd Hoffmann
v2: rebase, fix codestyle issues. Gerd Hoffmann (3): spice: drop dprint() debug logging spice: add scanout_dmabuf support spice: add cursor_dmabuf support include/ui/spice-display.h | 9 +++ ui/spice-display.c | 194 - ui/trace-events

[Qemu-devel] [PATCH v2 3/3] spice: add cursor_dmabuf support

2018-03-06 Thread Gerd Hoffmann
Add support for cursor dmabufs. qemu has to render the cursor for that, so in case a cursor is present qemu allocates a new dmabuf, blits the scanout, blends in the pointer and passes on the new dmabuf to spice-server. Without cursor qemu continues to simply pass on the scanout dmabuf as-is. Sig

[Qemu-devel] [PATCH v2 2/3] spice: add scanout_dmabuf support

2018-03-06 Thread Gerd Hoffmann
Add support for scanout dmabufs. Just pass them through to spice-server. Signed-off-by: Gerd Hoffmann --- ui/spice-display.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/ui/spice-display.c b/ui/spice-display.c index f3ae6beb3d..a494db1196 100644 --- a/ui/spice-display.c

Re: [Qemu-devel] [edk2] [PATCH 3/7] HACK: HobLib: workaround infinite loop

2018-03-06 Thread Laszlo Ersek
On 03/06/18 01:45, Brian J. Johnson wrote: > On 03/05/2018 12:22 PM, Laszlo Ersek wrote: >> PEIMs generally "execute in place" (XIP), i.e. they run from flash, not >> RAM. In this status they use "temporary RAM" (e.g. CPU caches configured >> like RAM) for stack & heap; whatever HOBs they produce a

Re: [Qemu-devel] [PATCH] KVM: x86: Add support for save/load MSR_SMI_COUNT

2018-03-06 Thread Liran Alon
Gentle ping. (http://patchwork.ozlabs.org/patch/878657/) - liran.a...@oracle.com wrote: > This MSR returns the number of #SMIs that occurred on > CPU since boot. > > KVM commit 52797bf9a875 ("KVM: x86: Add emulation of MSR_SMI_COUNT") > introduced support for emulating this MSR. > > This c

Re: [Qemu-devel] [PATCH v8 03/23] RISC-V CPU Core Definition

2018-03-06 Thread Igor Mammedov
On Tue, 6 Mar 2018 11:24:02 +1300 Michael Clark wrote: > On Mon, Mar 5, 2018 at 10:44 PM, Igor Mammedov wrote: > > > On Sat, 3 Mar 2018 02:51:31 +1300 > > Michael Clark wrote: > > > > > Add CPU state header, CPU definitions and initialization routines > > > > > > Reviewed-by: Richard Hender

Re: [Qemu-devel] [PATCH v4] qapi: Add device ID and head parameters to screendump

2018-03-06 Thread Thomas Huth
On 05.03.2018 17:50, Eric Blake wrote: > On 03/05/2018 10:37 AM, Thomas Huth wrote: >> QEMU's screendump command can only take dumps from the primary display. >> When using multiple VGA cards, there is no way to get a dump from a >> secondary card or other display heads yet. So let's add an 'device

Re: [Qemu-devel] [PATCH v2 26/30] hw/smbios: use the BYTE-based definitions

2018-03-06 Thread Igor Mammedov
On Mon, 5 Mar 2018 08:27:28 -0300 Philippe Mathieu-Daudé wrote: > It eases code review, unit is explicit. > > Patch generated using: > > $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ > > and modified manually. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-

Re: [Qemu-devel] [PATCH] sparc: fix leon3 casa instruction when MMU is disabled

2018-03-06 Thread Richard Henderson
On 03/05/2018 09:56 PM, Mark Cave-Ayland wrote: > Thanks for reviewing the patch Richard. Do you want me to take this one via my > qemu-sparc branch? Yes, please. r~

Re: [Qemu-devel] [PATCH v3 03/12] hw/core: introduce IOMMUSVAContext for virt-SVA

2018-03-06 Thread Liu, Yi L
On Mon, Mar 05, 2018 at 02:25:09PM +1100, David Gibson wrote: > On Thu, Mar 01, 2018 at 06:31:53PM +0800, Liu, Yi L wrote: > > From: Peter Xu > > > > This patch adds IOMMUSVAContext as an abstract for virt-SVA in > > Qemu. > > > > IOMMUSVAContext is per-PASID(Process Address Space Identity). > > A

[Qemu-devel] [PATCH v2 5/6] ui/gtk-egl: add scanout_dmabuf support

2018-03-06 Thread Gerd Hoffmann
Add support for dmabuf scanouts to gtk-egl. Signed-off-by: Gerd Hoffmann --- include/ui/gtk.h | 4 ui/gtk-egl.c | 23 +++ ui/gtk.c | 2 ++ 3 files changed, 29 insertions(+) diff --git a/include/ui/gtk.h b/include/ui/gtk.h index f6dafc5961..84c992c227 10064

[Qemu-devel] [PATCH v2 6/6] ui/gtk-egl: add cursor_dmabuf support

2018-03-06 Thread Gerd Hoffmann
Add support for cursor dmabufs to gtk-egl. Just blend in the cursor (if we have one) when rendering the dmabuf. Signed-off-by: Gerd Hoffmann --- include/ui/gtk.h | 8 ui/gtk-egl.c | 40 +++- ui/gtk.c | 2 ++ 3 files changed, 49 insertio

[Qemu-devel] [PATCH v2 1/6] ui/gtk: make GtkGlArea usage a runtime option

2018-03-06 Thread Gerd Hoffmann
Compile in both gtk-egl and gtk-gl-area, then allow to choose at runtime instead of compile time which opengl variant we want use. Signed-off-by: Gerd Hoffmann --- include/ui/gtk.h | 2 ++ ui/gtk.c | 53 + ui/Makefile.objs | 3 +-- 3

[Qemu-devel] [PATCH v2 3/6] ui/opengl: Makefile cleanup

2018-03-06 Thread Gerd Hoffmann
With gtk.mo bits moved away we don't need the ifeq any more. Also add missing opengl libs for some objects. Signed-off-by: Gerd Hoffmann --- ui/Makefile.objs | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/ui/Makefile.objs b/ui/Makefile.objs index b560ee12c3..cc7

[Qemu-devel] [PATCH v2 4/6] ui/gtk: use GtkGlArea on wayland only

2018-03-06 Thread Gerd Hoffmann
For dma-buf support we need a egl context. The gtk x11 backend uses glx contexts though. We can't use the GtkGlArea widget on x11 because of that, so use our own gtk-egl code instead. wayland continues to use the GtkGlArea widget. Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 13 -

[Qemu-devel] [PATCH v2 0/6] gtk: add support for dmabufs

2018-03-06 Thread Gerd Hoffmann
v2: rebase, add some makefile cleanups. Gerd Hoffmann (6): ui/gtk: make GtkGlArea usage a runtime option ui/gtk: group gtk.mo declarations in Makefile ui/opengl: Makefile cleanup ui/gtk: use GtkGlArea on wayland only ui/gtk-egl: add scanout_dmabuf support ui/gtk-egl: add cursor_dmabuf

Re: [Qemu-devel] [PULL] RISC-V QEMU Port Submission v8

2018-03-06 Thread Andrea Bolognani
On Tue, 2018-03-06 at 14:30 +1300, Michael Clark wrote: > I'm currently working on some changes locally to split the firmware from > the kernel image. Currently the kernel image is embedded in the firmware (r > iscv-pk/bbl). I was wondering about this just yesterday. Will this eventually lead to

[Qemu-devel] [PATCH v2 2/6] ui/gtk: group gtk.mo declarations in Makefile

2018-03-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/Makefile.objs | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/ui/Makefile.objs b/ui/Makefile.objs index d1203bb80a..b560ee12c3 100644 --- a/ui/Makefile.objs +++ b/ui/Makefile.objs @@ -38,6 +38,13 @@ common-obj-$(CONFIG_GTK) += g

Re: [Qemu-devel] [PATCH] hw/s390x: Add the possibility to specify the netboot image on the command line

2018-03-06 Thread Cornelia Huck
On Tue, 27 Feb 2018 12:32:34 +0100 Thomas Huth wrote: > The file name of the netboot binary is currently hard-coded to > "s390-netboot.img", without a possibility for the user to select > an alternative firmware image here. That's unfortunate, especially > since the basics are already there: The

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 3/3] s390x/sclp: extend SCLP event masks to 64 bits

2018-03-06 Thread Cornelia Huck
On Tue, 6 Mar 2018 09:23:23 +0100 Christian Borntraeger wrote: > On 03/05/2018 04:27 PM, Cornelia Huck wrote: > > On Fri, 2 Mar 2018 10:44:46 +0100 > > Christian Borntraeger wrote: > > > >> On 02/23/2018 06:42 PM, Claudio Imbrenda wrote: > >>> Extend the SCLP event masks to 64 bits. > >>> >

[Qemu-devel] [PATCH v7 4/9] console: minimal hotplug suport

2018-03-06 Thread Gerd Hoffmann
This patch allows to unbind devices from QemuConsoles, using the new graphic_console_close() function. The QemuConsole will show a static display then, saying the device was unplugged. When re-plugging a display later on the QemuConsole will be reused. Eventually we will allocate and release Qem

[Qemu-devel] [PATCH v7 7/9] vfio/display: core & wireup

2018-03-06 Thread Gerd Hoffmann
Infrastructure for display support. Must be enabled using 'display' property. Signed-off-by: Gerd Hoffmann --- hw/vfio/pci.h | 4 hw/vfio/display.c | 56 +++ hw/vfio/pci.c | 10 + hw/vfio/Makefile.objs | 2 +- 4

[Qemu-devel] [PATCH v7 0/9] vfio: add display support

2018-03-06 Thread Gerd Hoffmann
This series adds support for a vgpu display to the qemu vfio code. v7: - rebase to latest master. - dmabuf: update cursor hotspot properly (Tina). - dmabuf: track whenever cursor hotspot + position changes. - codestryle fixes. v6: - add support for hotplugging QemuConsoles. - drop vfio-pci-

[Qemu-devel] [PATCH v7 3/9] ui/pixman: add qemu_drm_format_to_pixman()

2018-03-06 Thread Gerd Hoffmann
Map drm fourcc codes to pixman formats. Signed-off-by: Gerd Hoffmann --- include/ui/qemu-pixman.h | 5 + ui/qemu-pixman.c | 22 ++ 2 files changed, 27 insertions(+) diff --git a/include/ui/qemu-pixman.h b/include/ui/qemu-pixman.h index 4a67e01232..b7c82d17fc 100

[Qemu-devel] [PATCH v7 8/9] vfio/display: adding region support

2018-03-06 Thread Gerd Hoffmann
Wire up region-based display. Signed-off-by: Gerd Hoffmann --- hw/vfio/pci.h | 1 + include/hw/vfio/vfio-common.h | 8 +++ hw/vfio/display.c | 116 +- 3 files changed, 123 insertions(+), 2 deletions(-) diff --git a/hw/vfio/

[Qemu-devel] [PATCH v7 2/9] standard-headers: add drm/drm_fourcc.h

2018-03-06 Thread Gerd Hoffmann
So we can use the drm fourcc codes without a dependency on libdrm-devel. Signed-off-by: Gerd Hoffmann --- include/standard-headers/drm/drm_fourcc.h | 411 ++ scripts/update-linux-headers.sh | 5 + 2 files changed, 416 insertions(+) create mode 100644 incl

[Qemu-devel] [PATCH v7 1/9] linux-headers: update to 4.16-rc1

2018-03-06 Thread Gerd Hoffmann
s390 has splitted syscall numbers into unistd_{32,64}.h files, so update scripts/update-linux-headers.sh accordingly. Also add a rewrite from __BITS_PER_LONG to HOST_LONG_BITS for linux/input.h Signed-off-by: Gerd Hoffmann --- include/standard-headers/linux/input-event-codes.h | 1 + include/

[Qemu-devel] [PATCH v7 9/9] vfio/display: adding dmabuf support

2018-03-06 Thread Gerd Hoffmann
Wire up dmabuf-based display. Signed-off-by: Gerd Hoffmann --- include/hw/vfio/vfio-common.h | 14 hw/vfio/display.c | 185 +- 2 files changed, 196 insertions(+), 3 deletions(-) diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfi

[Qemu-devel] [PATCH v7 6/9] vfio/common: cleanup in vfio_region_finalize

2018-03-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/vfio/common.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index f895e3c335..6a8203a532 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c @@ -858,6 +858,13 @@ void vfio_region_finalize(VFIORegion *region)

[Qemu-devel] [PATCH v7 5/9] secondary-vga: properly close QemuConsole on unplug

2018-03-06 Thread Gerd Hoffmann
Using the new graphic_console_close() function. Signed-off-by: Gerd Hoffmann --- hw/display/vga-pci.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/display/vga-pci.c b/hw/display/vga-pci.c index 1674bd3581..f312930664 100644 --- a/hw/display/vga-pci.c +++ b/hw/display/vga-pci.c

Re: [Qemu-devel] [PATCH v2 0/5] s390x: vfio-ap: guest dedicated crypto adapters

2018-03-06 Thread David Hildenbrand
On 27.02.2018 16:44, Tony Krowiak wrote: > This patch series is the QEMU counterpart to the KVM/kernel support for > guest dedicated crypto adapters. The KVM/kernel model is built on the > VFIO mediated device framework and provides the infrastructure for > granting exclusive guest access to cry

Re: [Qemu-devel] [Qemu-block] [PATCH] block: include original filename when reporting invalid URIs

2018-03-06 Thread Stefan Hajnoczi
On Tue, Feb 06, 2018 at 10:52:04AM +, Daniel P. Berrangé wrote: > Consider passing a JSON based block driver to "qemu-img commit" > > $ qemu-img commit 'json:{"driver":"qcow2","file":{"driver":"gluster",\ > "volume":"gv0","path":"sn1.qcow2", > "server":[{"ty

[Qemu-devel] [PATCH v3 1/2] s390x/sclpconsole: Remove dead code - remove exit handlers

2018-03-06 Thread Nia Alarie
The other event handlers (quiesce and cpu) do not define these handlers, and this one does nothing, so it can be removed. Signed-off-by: Nia Alarie Reviewed-by: Christian Borntraeger --- hw/char/sclpconsole-lm.c | 6 -- hw/char/sclpconsole.c | 6 -- hw/s390x/event

[Qemu-devel] [PATCH v3 2/2] s390x: Change return type of virtio_ccw_exit to void.

2018-03-06 Thread Nia Alarie
Allows a branch to be removed - this function always returns 0. Signed-off-by: Nia Alarie Reviewed-by: Christian Borntraeger --- hw/s390x/virtio-ccw.c | 6 +++--- hw/s390x/virtio-ccw.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio

Re: [Qemu-devel] [PULL v2 00/38] Block layer patches

2018-03-06 Thread Peter Maydell
On 5 March 2018 at 17:51, Kevin Wolf wrote: > The following changes since commit 86f4c7e05b1c44dbe1b329a51f311f10aef6ff34: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20180302' into staging (2018-03-02 > 14:37:10 +) > > are available in the git repository at:

Re: [Qemu-devel] [PATCH v3] numa: we don't implement NUMA for s390x

2018-03-06 Thread Cornelia Huck
On Tue, 27 Feb 2018 12:02:55 +0100 David Hildenbrand wrote: > Right now it is possible to crash QEMU for s390x by providing e.g. > -numa node,nodeid=0,cpus=0-1 > > Problem is, that numa.c uses mc->cpu_index_to_instance_props as an > indicator whether NUMA is supported by a machine type. We d

Re: [Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu()

2018-03-06 Thread Paolo Bonzini
On 05/03/2018 09:42, Liu, Yi L wrote: >> In general I think it's better to change your names from "assigned_dev" >> to "sva_dev", because the point of the list is to only iterate over >> devices that might be interested in using SVA. > > For "assigned_dev", my purpose is to distinguish "assigned de

Re: [Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu()

2018-03-06 Thread Paolo Bonzini
On 05/03/2018 11:43, Peter Xu wrote: > On Mon, Mar 05, 2018 at 04:43:09PM +0800, Liu, Yi L wrote: >> On Fri, Mar 02, 2018 at 05:06:56PM +0100, Paolo Bonzini wrote: >>> On 01/03/2018 11:33, Liu, Yi L wrote: +pci_device_notify_iommu(pdev, PCI_NTY_DEV_ADD); + pci_setup_sva_ops(

Re: [Qemu-devel] [PULL v2 00/38] Block layer patches

2018-03-06 Thread Kevin Wolf
Am 06.03.2018 um 11:09 hat Peter Maydell geschrieben: > On 5 March 2018 at 17:51, Kevin Wolf wrote: > > The following changes since commit 86f4c7e05b1c44dbe1b329a51f311f10aef6ff34: > > > > Merge remote-tracking branch > > 'remotes/pmaydell/tags/pull-target-arm-20180302' into staging (2018-03-02

Re: [Qemu-devel] [PATCH v3] iotests: Tweak 030 in order to trigger a race condition with parallel jobs

2018-03-06 Thread Alberto Garcia
On Mon 05 Mar 2018 05:59:47 PM CET, Max Reitz wrote: > Secondly, I've reverted 3d5d319e1221082 to test this, and I could > reproduce failure exactly once. Since then, no luck (in like 20 > attempts, I think)... Oh, I see. I was bisecting this and it seems that 1a63a907507fbbcf made this problem m

Re: [Qemu-devel] [PATCH v3 11/12] intel_iommu: add framework for PASID AddressSpace management

2018-03-06 Thread Paolo Bonzini
On 05/03/2018 10:11, Liu, Yi L wrote: >> Do you really need VTDDeviceNode? I think can you simply put the >> QLIST_ENTRY in VTDAddressSpace (named e.g. next_by_pasid), since >> VTDAddressSpace already includes a (bus, devfn). > Existing VTDAddressSpace is actaully per-device. While for PASID tagge

Re: [Qemu-devel] [PATCH v3 0/6] qio: general non-default GMainContext support

2018-03-06 Thread Daniel P . Berrangé
On Mon, Mar 05, 2018 at 02:43:18PM +0800, Peter Xu wrote: > V1: http://lists.nongnu.org/archive/html/qemu-devel/2018-02/msg06972.html > V2: http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg00016.html > > From this version, I'll split the old series into two: one QIO series > and one CHARDEV

Re: [Qemu-devel] [PULL v2 00/38] Block layer patches

2018-03-06 Thread Peter Maydell
On 6 March 2018 at 10:24, Kevin Wolf wrote: > Am 06.03.2018 um 11:09 hat Peter Maydell geschrieben: >> On 5 March 2018 at 17:51, Kevin Wolf wrote: >> > The following changes since commit >> > 86f4c7e05b1c44dbe1b329a51f311f10aef6ff34: >> > >> > Merge remote-tracking branch >> > 'remotes/pmayde

Re: [Qemu-devel] [PULL 12/51] build-sys: compile with -Og or -O1 when --enable-debug

2018-03-06 Thread Paolo Bonzini
On 02/03/2018 19:48, Peter Maydell wrote: > On 16 January 2018 at 14:16, Paolo Bonzini wrote: >> From: Marc-André Lureau >> >> When --enable-debug is turned on, configure doesn't set -O level, and >> uses default compiler -O0 level, which is slow. >> >> Instead, use -Og if supported by the compil

Re: [Qemu-devel] [PATCH] block: implement the bdrv_reopen_prepare helper for LUKS driver

2018-03-06 Thread Daniel P . Berrangé
Ping On Fri, Feb 16, 2018 at 01:53:12PM +, Daniel P. Berrangé wrote: > Ping, can this be queued in the block tree, since it appears the no-op impl > is ok ? > > On Thu, Jan 18, 2018 at 10:31:43AM +, Daniel P. Berrange wrote: > > If the bdrv_reopen_prepare helper isn't provided, the qemu-

Re: [Qemu-devel] [PATCH v3 22/29] vhost+postcopy: Call wakeups

2018-03-06 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Fri, Feb 16, 2018 at 01:16:18PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Cause the vhost-user client to be woken up whenever: > > a) We place a page in postcopy mode > > b) We get a fault and the page has

Re: [Qemu-devel] [PATCH] migration: convert socket server to QIONetListener

2018-03-06 Thread Daniel P . Berrangé
Ping On Mon, Feb 12, 2018 at 05:48:22PM +, Daniel P. Berrangé wrote: > Ping, any thoughts on this ? > > NB, it will conflict with the multiple-sockets migration work I > expect, since IIRC that assumes it can get the GSource ID of the > migration listener, but that's not valid going forward,

Re: [Qemu-devel] [PATCH v8 03/23] RISC-V CPU Core Definition

2018-03-06 Thread Igor Mammedov
On Tue, 6 Mar 2018 09:58:34 +0100 Igor Mammedov wrote: > On Tue, 6 Mar 2018 11:24:02 +1300 > Michael Clark wrote: > > > On Mon, Mar 5, 2018 at 10:44 PM, Igor Mammedov wrote: > > > > > On Sat, 3 Mar 2018 02:51:31 +1300 > > > Michael Clark wrote: > > > > > > > Add CPU state header, CPU

Re: [Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu()

2018-03-06 Thread Peter Xu
On Tue, Mar 06, 2018 at 11:19:13AM +0100, Paolo Bonzini wrote: > On 05/03/2018 11:43, Peter Xu wrote: > > On Mon, Mar 05, 2018 at 04:43:09PM +0800, Liu, Yi L wrote: > >> On Fri, Mar 02, 2018 at 05:06:56PM +0100, Paolo Bonzini wrote: > >>> On 01/03/2018 11:33, Liu, Yi L wrote: > +pci_device

Re: [Qemu-devel] [PATCH v3 05/12] hw/pci: introduce PCISVAOps to PCIDevice

2018-03-06 Thread Liu, Yi L
On Mon, Mar 05, 2018 at 02:31:44PM +1100, David Gibson wrote: > On Thu, Mar 01, 2018 at 06:31:55PM +0800, Liu, Yi L wrote: > > This patch intoduces PCISVAOps for virt-SVA. > > > > So far, to setup virt-SVA for assigned SVA capable device, needs to > > config host translation structures. e.g. for VT

[Qemu-devel] [PATCH] block: make BDRV_POLL_WHILE() re-entrancy safe

2018-03-06 Thread Stefan Hajnoczi
Nested BDRV_POLL_WHILE() calls can occur. Currently assert(!bs_->wakeup) will fail when this happens. This patch converts bs->wakeup from bool to a counter. Nesting works correctly because outer BDRV_POLL_WHILE() callers evaluate the condition again after the inner caller completes (invoking the

Re: [Qemu-devel] [PATCH v3 20/29] postcopy: postcopy_notify_shared_wake

2018-03-06 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Mon, Mar 05, 2018 at 07:55:13PM +, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > On Fri, Feb 16, 2018 at 01:16:16PM +, Dr. David Alan Gilbert (git) > > > wrote: > > > > From: "Dr. David Alan Gilbert" > > > > > > >

Re: [Qemu-devel] Question: qemu crashed for re-entry of bdrv_drain_recurse

2018-03-06 Thread Stefan Hajnoczi
On Fri, Feb 09, 2018 at 07:57:42AM +, fuweiwei (C) wrote: > We find a problem of reentrant of bdrv_drain_recurse() of the same bs, which > makes > Qemu assertion failed at > > assert(!bs_->wakeup); > > in BDRV_POLL_WHILE. > > To construct the problem, we do block-commit job (or others)

Re: [Qemu-devel] [PATCH v3 0/6] qio: general non-default GMainContext support

2018-03-06 Thread Peter Xu
On Tue, Mar 06, 2018 at 10:29:47AM +, Daniel P. Berrangé wrote: > On Mon, Mar 05, 2018 at 02:43:18PM +0800, Peter Xu wrote: > > V1: http://lists.nongnu.org/archive/html/qemu-devel/2018-02/msg06972.html > > V2: http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg00016.html > > > > From this

Re: [Qemu-devel] [PATCH 1/7] audio: add driver registry

2018-03-06 Thread Marc-André Lureau
On Tue, Mar 6, 2018 at 8:40 AM, Gerd Hoffmann wrote: > Add registry for audio drivers, using the existing audio_driver struct. > Make all drivers register themself. The old list of audio_driver struct > pointers is now a list of audio driver names, specifying the priority > (aka probe order) in c

Re: [Qemu-devel] [PATCH 2/7] audio: add module loading support

2018-03-06 Thread Marc-André Lureau
On Tue, Mar 6, 2018 at 8:40 AM, Gerd Hoffmann wrote: > Make audio_driver_lookup() try load the module in case it doesn't find > the driver in the registry. Also load all modules for -audio-help, so > the help output includes the help text for modular audio drivers. > > Signed-off-by: Gerd Hoffman

Re: [Qemu-devel] [PATCH] block: make BDRV_POLL_WHILE() re-entrancy safe

2018-03-06 Thread Paolo Bonzini
On 06/03/2018 11:53, Stefan Hajnoczi wrote: > Nested BDRV_POLL_WHILE() calls can occur. Currently > assert(!bs_->wakeup) will fail when this happens. > > This patch converts bs->wakeup from bool to a counter. > > Nesting works correctly because outer BDRV_POLL_WHILE() callers evaluate > the cond

Re: [Qemu-devel] [Bug 1749016] [NEW] VHDX BAT and Metadata Region Header Required Bit Not Set

2018-03-06 Thread Stefan Hajnoczi
On Mon, Feb 12, 2018 at 09:44:09PM -, Michael Fruchtman wrote: > Public bug reported: > > When converting a VMDK to VHDX the resulting VHDX's Region table has a > small error. According to the VHDX specification the BAT and Metadata > entries for the region header required bit should be set to

Re: [Qemu-devel] [PATCH] block: make BDRV_POLL_WHILE() re-entrancy safe

2018-03-06 Thread Kevin Wolf
Am 06.03.2018 um 11:53 hat Stefan Hajnoczi geschrieben: > Nested BDRV_POLL_WHILE() calls can occur. Currently > assert(!bs_->wakeup) will fail when this happens. > > This patch converts bs->wakeup from bool to a counter. > > Nesting works correctly because outer BDRV_POLL_WHILE() callers evaluat

Re: [Qemu-devel] [PULL] RISC-V QEMU Port Submission v8

2018-03-06 Thread Peter Maydell
On 6 March 2018 at 01:30, Michael Clark wrote: > I've squashed the trivial spike rename fix and rebased against master as of > commit f2bb2d14c2958f3f5aef456bd2cdb1ff99f4a562 Merge remote-tracking branch > 'remotes/stefanha/tags/block-pull-request' into staging. See here: > > - https://github.com/

Re: [Qemu-devel] [PATCH v4] scripts/checkpatch.pl: add check for `while` and `for`

2018-03-06 Thread Paolo Bonzini
On 06/03/2018 08:04, Su Hang wrote: > Adding check for `while` and `for` statements, which condition has more than > one line. > > The former checkpatch.pl can check `if` statement, which condition has more > than one line, whether block misses brace round, like this: > ''' > if (cond1 || > co

Re: [Qemu-devel] [PATCH] block: implement the bdrv_reopen_prepare helper for LUKS driver

2018-03-06 Thread Kevin Wolf
Am 18.01.2018 um 11:31 hat Daniel P. Berrange geschrieben: > If the bdrv_reopen_prepare helper isn't provided, the qemu-img commit > command fails to re-open the base layer after committing changes into > it. Provide a no-op implementation for the LUKS driver, since there > is not any custom work t

Re: [Qemu-devel] [PULL 00/30] ppc-for-2.12 queue 20180306

2018-03-06 Thread Peter Maydell
ble in the Git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-2.12-20180306 > > for you to fetch changes up to 21b786f607b11d888f90bbb8c3414500515d11e7: > > PowerPC: Add TS bits into msr_mask (2018-03-06 13:16:29 +1100) > > ---

Re: [Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu()

2018-03-06 Thread Liu, Yi L
On Tue, Mar 06, 2018 at 11:18:43AM +0100, Paolo Bonzini wrote: > On 05/03/2018 09:42, Liu, Yi L wrote: > >> In general I think it's better to change your names from "assigned_dev" > >> to "sva_dev", because the point of the list is to only iterate over > >> devices that might be interested in using

Re: [Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu()

2018-03-06 Thread Paolo Bonzini
On 06/03/2018 12:03, Liu, Yi L wrote: > On Tue, Mar 06, 2018 at 11:18:43AM +0100, Paolo Bonzini wrote: >> On 05/03/2018 09:42, Liu, Yi L wrote: In general I think it's better to change your names from "assigned_dev" to "sva_dev", because the point of the list is to only iterate over

Re: [Qemu-devel] [PATCH 0/7] audio: modularize

2018-03-06 Thread Marc-André Lureau
Hi On Tue, Mar 6, 2018 at 8:40 AM, Gerd Hoffmann wrote: > Add audio driver (host backend) registry. Add audio module support. > Enable module builds for alsa, oss, pulse and sdl. > > Gerd Hoffmann (7): > audio: add driver registry > audio: add module loading support > build: enable audio m

Re: [Qemu-devel] [PATCH v3 11/29] vhost+postcopy: Transmit 'listen' to client

2018-03-06 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Mon, Mar 05, 2018 at 05:42:42PM +, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > On Fri, Feb 16, 2018 at 01:16:07PM +, Dr. David Alan Gilbert (git) > > > wrote: > > > > > > [...] > > > > > > > typedef struct VuVi

Re: [Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu()

2018-03-06 Thread Liu, Yi L
On Tue, Mar 06, 2018 at 06:47:27PM +0800, Peter Xu wrote: > On Tue, Mar 06, 2018 at 11:19:13AM +0100, Paolo Bonzini wrote: > > On 05/03/2018 11:43, Peter Xu wrote: > > > On Mon, Mar 05, 2018 at 04:43:09PM +0800, Liu, Yi L wrote: > > >> On Fri, Mar 02, 2018 at 05:06:56PM +0100, Paolo Bonzini wrote:

Re: [Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu()

2018-03-06 Thread Liu, Yi L
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Tuesday, March 6, 2018 7:22 PM > Subject: Re: [Qemu-devel] [PATCH v3 08/12] hw/pci: introduce > pci_device_notify_iommu() > > On 06/03/2018 12:03, Liu, Yi L wrote: > > On Tue, Mar 06, 2018 at 11:18:43AM +0100, Paolo Bonzini wrote: > >> On

Re: [Qemu-devel] make error

2018-03-06 Thread Stefan Hajnoczi
On Tue, Feb 20, 2018 at 04:40:49PM +0100, Ronald Delobel wrote: > Hello, > > This is the error I get when building qemu-2.11.[0-1] with > gcc-7.3.0/glibc-2.27, removing the static attribute suffice to finnish the > build using the glibc provided memfd_create and qemu don't crash, but I > miss some

[Qemu-devel] [PATCH v8 6/9] vfio/common: cleanup in vfio_region_finalize

2018-03-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/vfio/common.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index f895e3c335..6a8203a532 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c @@ -858,6 +858,13 @@ void vfio_region_finalize(VFIORegion *region)

[Qemu-devel] [PATCH v8 4/9] console: minimal hotplug suport

2018-03-06 Thread Gerd Hoffmann
This patch allows to unbind devices from QemuConsoles, using the new graphic_console_close() function. The QemuConsole will show a static display then, saying the device was unplugged. When re-plugging a display later on the QemuConsole will be reused. Eventually we will allocate and release Qem

[Qemu-devel] [PATCH v8 5/9] secondary-vga: properly close QemuConsole on unplug

2018-03-06 Thread Gerd Hoffmann
Using the new graphic_console_close() function. Signed-off-by: Gerd Hoffmann --- hw/display/vga-pci.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/display/vga-pci.c b/hw/display/vga-pci.c index 1674bd3581..f312930664 100644 --- a/hw/display/vga-pci.c +++ b/hw/display/vga-pci.c

[Qemu-devel] [PATCH v8 8/9] vfio/display: adding region support

2018-03-06 Thread Gerd Hoffmann
Wire up region-based display. Signed-off-by: Gerd Hoffmann --- hw/vfio/pci.h | 1 + include/hw/vfio/vfio-common.h | 8 +++ hw/vfio/display.c | 117 +- 3 files changed, 124 insertions(+), 2 deletions(-) diff --git a/hw/vfio/

[Qemu-devel] [PATCH v8 2/9] standard-headers: add drm/drm_fourcc.h

2018-03-06 Thread Gerd Hoffmann
So we can use the drm fourcc codes without a dependency on libdrm-devel. Signed-off-by: Gerd Hoffmann --- include/standard-headers/drm/drm_fourcc.h | 411 ++ scripts/update-linux-headers.sh | 5 + 2 files changed, 416 insertions(+) create mode 100644 incl

[Qemu-devel] [PATCH v8 9/9] vfio/display: adding dmabuf support

2018-03-06 Thread Gerd Hoffmann
Wire up dmabuf-based display. Signed-off-by: Gerd Hoffmann --- include/hw/vfio/vfio-common.h | 14 hw/vfio/display.c | 182 +- 2 files changed, 194 insertions(+), 2 deletions(-) diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfi

[Qemu-devel] [PATCH v8 1/9] linux-headers: update to 4.16-rc1

2018-03-06 Thread Gerd Hoffmann
s390 has splitted syscall numbers into unistd_{32,64}.h files, so update scripts/update-linux-headers.sh accordingly. Also add a rewrite from __BITS_PER_LONG to HOST_LONG_BITS for linux/input.h Signed-off-by: Gerd Hoffmann --- include/standard-headers/linux/input-event-codes.h | 1 + include/

[Qemu-devel] [PATCH v8 0/9] vfio: add display support

2018-03-06 Thread Gerd Hoffmann
This series adds support for a vgpu display to the qemu vfio code. v8: - codestyle fixes, this time for real ... v7: - rebase to latest master. - dmabuf: update cursor hotspot properly (Tina). - dmabuf: track whenever cursor hotspot + position changes. - codestyle fixes. v6: - add support

[Qemu-devel] [PATCH v8 7/9] vfio/display: core & wireup

2018-03-06 Thread Gerd Hoffmann
Infrastructure for display support. Must be enabled using 'display' property. Signed-off-by: Gerd Hoffmann --- hw/vfio/pci.h | 4 hw/vfio/display.c | 56 +++ hw/vfio/pci.c | 10 + hw/vfio/Makefile.objs | 2 +- 4

[Qemu-devel] [PATCH v8 3/9] ui/pixman: add qemu_drm_format_to_pixman()

2018-03-06 Thread Gerd Hoffmann
Map drm fourcc codes to pixman formats. Signed-off-by: Gerd Hoffmann --- include/ui/qemu-pixman.h | 5 + ui/qemu-pixman.c | 22 ++ 2 files changed, 27 insertions(+) diff --git a/include/ui/qemu-pixman.h b/include/ui/qemu-pixman.h index 4a67e01232..b7c82d17fc 100

Re: [Qemu-devel] SSD virtio-scsi passthrough

2018-03-06 Thread Stefan Hajnoczi
On Wed, Feb 21, 2018 at 02:51:38PM +0530, Nitin Gupta wrote: > Please let me know the qemu command for doing ssd virtio-scsi passthrough . > i am able to do the pass through with virsh .but same command when i am > trying with qemu , VM is not coming up > > Please let me know how can i proceed fur

Re: [Qemu-devel] [Xen-devel] [RFC QEMU PATCH v4 00/10] Implement vNVDIMM for Xen HVM guest

2018-03-06 Thread Anthony PERARD
On Tue, Mar 06, 2018 at 12:16:08PM +0800, Haozhong Zhang wrote: > On 03/02/18 12:03 +, Anthony PERARD wrote: > > On Wed, Feb 28, 2018 at 05:36:59PM +0800, Haozhong Zhang wrote: > > > On 02/27/18 17:22 +, Anthony PERARD wrote: > > > > On Thu, Dec 07, 2017 at 06:18:02PM +0800, Haozhong Zhang

Re: [Qemu-devel] [PATCH risu 1/3] ppc64.risu: Add missing byte and dword loads

2018-03-06 Thread Peter Maydell
On 6 March 2018 at 06:42, Sandipan Das wrote: > The patterns for the following instructions are added: > * Load Byte and Zero (lbz) > * Load Byte and Zero with Update (lbzu) > * Load Byte and Zero Indexed (lbzx) > * Load Byte and Zero with Update Indexed (lbzux) > * Load Doubleword (ld) > > S

Re: [Qemu-devel] [PATCH] checkpatch: Exempt long URLs

2018-03-06 Thread Stefan Hajnoczi
On Thu, Feb 22, 2018 at 03:58:38PM -0600, Eric Blake wrote: > Sometimes, we want to refer to really long URLs, but checkpatch > balks, and we have to manually bypass the check. URL shorterners > may be nice at reducing long links, but it's hard to guarantee the > shortened link will live as long a

Re: [Qemu-devel] [PATCH risu 1/3] ppc64.risu: Add missing byte and dword loads

2018-03-06 Thread Sandipan Das
On 03/06/2018 05:09 PM, Peter Maydell wrote: > On 6 March 2018 at 06:42, Sandipan Das wrote: >> The patterns for the following instructions are added: >> * Load Byte and Zero (lbz) >> * Load Byte and Zero with Update (lbzu) >> * Load Byte and Zero Indexed (lbzx) >> * Load Byte and Zero with U

Re: [Qemu-devel] [PATCH v2 1/3] spice: drop dprint() debug logging

2018-03-06 Thread Marc-André Lureau
Hi On Tue, Mar 6, 2018 at 9:38 AM, Gerd Hoffmann wrote: > Some calls are deleted, some are converted into tracepoints. > > Signed-off-by: Gerd Hoffmann > --- > ui/spice-display.c | 75 > -- > ui/trace-events| 9 +++ > 2 files changed

Re: [Qemu-devel] [PATCH v3 12/12] intel_iommu: bind device to PASID tagged AddressSpace

2018-03-06 Thread Peter Xu
On Thu, Mar 01, 2018 at 06:33:35PM +0800, Liu, Yi L wrote: > This patch shows the idea of how a device is binded to a PASID tagged > AddressSpace. > > when Intel vIOMMU emulator detected a pasid table entry programming > from guest. Intel vIOMMU emulator firstly finds a VTDPASIDAddressSpace > with

Re: [Qemu-devel] [PATCH v2 2/3] spice: add scanout_dmabuf support

2018-03-06 Thread Marc-André Lureau
Hi On Tue, Mar 6, 2018 at 9:38 AM, Gerd Hoffmann wrote: > Add support for scanout dmabufs. Just > pass them through to spice-server. > > Signed-off-by: Gerd Hoffmann > --- > ui/spice-display.c | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/ui/spice-display.c b/ui/spi

Re: [Qemu-devel] [Qemu-block] Limiting coroutine stack usage

2018-03-06 Thread Stefan Hajnoczi
On Tue, Feb 20, 2018 at 06:04:02PM +0100, Peter Lieven wrote: > I remember we discussed a long time ago to limit the stack usage of all > functions that are executed in a coroutine > context to a very low value to be able to safely limit the coroutine stack > size as well. > > I checked through

Re: [Qemu-devel] [PATCH v2 3/3] spice: add cursor_dmabuf support

2018-03-06 Thread Marc-André Lureau
Hi On Tue, Mar 6, 2018 at 9:38 AM, Gerd Hoffmann wrote: > Add support for cursor dmabufs. qemu has to render the cursor for > that, so in case a cursor is present qemu allocates a new dmabuf, blits > the scanout, blends in the pointer and passes on the new dmabuf to > spice-server. Without curs

Re: [Qemu-devel] [PATCH v3 05/11] linux-user: fix mmap/munmap/mprotect/mremap/shmat

2018-03-06 Thread Laurent Vivier
Le 01/03/2018 à 18:36, Max Filippov a écrit : > In linux-user QEMU that runs for a target with TARGET_ABI_BITS bigger > than L1_MAP_ADDR_SPACE_BITS an assertion in page_set_flags fires when > mmap, munmap, mprotect, mremap or shmat is called for an address outside > the guest address space. mmap an

[Qemu-devel] [PATCH risu v2 0/3] Miscellaneous fixes for powerpc64

2018-03-06 Thread Sandipan Das
The first patch adds the patterns for the missing byte and doubleword load instructions. The second patch fixes mismatches encountered when using the load quadword instruction. The last patch fixes a minor typo in the floating-point register prefix shown when dumping the register values. Changelog

  1   2   3   4   5   >