[Qemu-devel] [Bug 1756519] Re: qemu linux-user crash in QOM path canonicalization during do_fork() call to cpu_create

2018-03-19 Thread Daniel Berrange
** Summary changed: - qemu linux-user glib hash table crash in qom/object.c + qemu linux-user crash in QOM path canonicalization during do_fork() call to cpu_create -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [RFC PATCH] tests/device-introspect: Test devices with all machines, not only with "none"

2018-03-19 Thread Thomas Huth
Many device introspection crashes only happen if you are using a certain machine, e.g.: $ ppc-softmmu/qemu-system-ppc -S -M ref405ep,accel=qtest -qmp stdio {"QMP": {"version": {"qemu": {"micro": 50, "minor": 11, "major": 2}, "package": "build-all"}, "capabilities": []}} { 'execute':

[Qemu-devel] [PULL 1/1] update seabios to 1.11.1

2018-03-19 Thread Gerd Hoffmann
git shortlog rel-1.11.0..rel-1.11.1 === Kevin O'Connor (3): build: Use git describe --always shadow: Don't invoke a shutdown on reboot unless in a reboot loop paravirt: Only enable sercon in NOGRAPHIC mode if no other console specified Marcel

Re: [Qemu-devel] [PULL 0/1] Seabios 1.11.1 20180319 patches

2018-03-19 Thread Peter Maydell
are available in the git repository at: > > git://git.kraxel.org/qemu tags/seabios-1.11.1-20180319-pull-request > > for you to fetch changes up to 9cdd2a736b99bad19fb4f88d2230c75f680c31ec: > > update seabios to 1.11.1 (2018-03-19 11:18:29 +0100) > > -

[Qemu-devel] [PATCH] scripts/decodetree: Fix insnmask not marked as global in main()

2018-03-19 Thread Bastian Koppelmann
if '-w 16' was given as a cmdline args a local copy of insnmask is set and not the global one. Signed-off-by: Peer Adelt Signed-off-by: Bastian Koppelmann --- scripts/decodetree.py | 1 + 1 file changed, 1 insertion(+) diff

Re: [Qemu-devel] [PATCH 2/8] migration: stop allocating and freeing memory frequently

2018-03-19 Thread Xiao Guangrong
On 03/19/2018 06:54 PM, Dr. David Alan Gilbert wrote: +return 0; +exit: +compress_threads_load_cleanup(); I don't think this is safe; if inflateInit(..) fails in not-the-last thread, compress_threads_load_cleanup() will try and destroy all the mutex's and condition variables, even

Re: [Qemu-devel] [PATCH 1/8] migration: stop compressing page in migration thread

2018-03-19 Thread Dr. David Alan Gilbert
* Xiao Guangrong (guangrong.x...@gmail.com) wrote: > > Hi David, > > Thanks for your review. > > On 03/15/2018 06:25 PM, Dr. David Alan Gilbert wrote: > > > > migration/ram.c | 32 > > > > Hi, > >Do you have some performance numbers to show this helps?

Re: [Qemu-devel] [PULL v3 00/46] Block layer patches

2018-03-19 Thread Peter Maydell
On 19 March 2018 at 11:04, Kevin Wolf wrote: > The following changes since commit e1e44a9916b4318e943aecd669e096222cb3eaeb: > > Merge remote-tracking branch 'remotes/xtensa/tags/20180316-xtensa' into > staging (2018-03-17 14:15:03 +) > > are available in the git

[Qemu-devel] [PATCH for-2.12] gitmodules: Use the QEMU mirror of qemu-palcode

2018-03-19 Thread Peter Maydell
We have a mirror of the qemu-palcode repository on git.qemu.org; use that instead of the upstream github, in line with our general policy of keeping and using a mirror for submodules. Signed-off-by: Peter Maydell --- We also currently have two submodules we don't have

Re: [Qemu-devel] [PATCH v3 10/24] RISC-V: Hold rcu_read_lock when accessing memory

2018-03-19 Thread Paolo Bonzini
On 16/03/2018 20:41, Michael Clark wrote: > From reading other code that accesses memory regions directly, > it appears that the rcu_read_lock needs to be held. Note: the > original code for accessing RAM directly was added because > there is no other way to use atomic_cmpxchg on guest physical >

Re: [Qemu-devel] [PULL 00/38] QAPI patches for 2018-03-12, 2.12 softfreeze

2018-03-19 Thread Peter Xu
On Sat, Mar 17, 2018 at 12:10:35PM +, Peter Maydell wrote: > On 16 March 2018 at 14:04, Eric Blake wrote: > > The following changes since commit 3788c7b6e56fa34ee2a73e41706eb2a2447ba75a: > > > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > >

[Qemu-devel] [PATCH v1 0/1] iotests: fix test case 185

2018-03-19 Thread QingFeng Hao
Hi, This patch is to remove the redundant call to bdrv_drain_all in vm_shutdown. Thanks! Test case 185 failed as below: 185 2s ... - output mismatch (see 185.out.bad) --- /home/mc/gitcheck/work/qemu-master/tree/qemu/tests/qemu-iotests/185.out 2018-03-09 01:00:40.451603189 +0100 +++

[Qemu-devel] [PATCH for-2.12] hw/arm/bcm2836: Use the Cortex-A7 instead of Cortex-A15

2018-03-19 Thread Peter Maydell
The BCM2836 uses a Cortex-A7, not a Cortex-A15. Update the device to use the correct CPU. https://www.raspberrypi.org/documentation/hardware/raspberrypi/bcm2836/QA7_rev3.4.pdf When the BCM2836 was introduced (bad5623690b) the Cortex-A7 was not available, so the very similar Cortex-A15 was used.

Re: [Qemu-devel] Moving seabios-hppa git submodule to use a qemu.org mirror

2018-03-19 Thread BALATON Zoltan
On Mon, 19 Mar 2018, Peter Maydell wrote: On 21 February 2018 at 05:27, Jeff Cody wrote: On Tue, Feb 20, 2018 at 06:43:22PM +, Peter Maydell wrote: I just noticed that we seem to have acquired another git submodule that isn't pointing to a qemu.org git url: [submodule

[Qemu-devel] [PULL 0/1] Seabios 1.11.1 20180319 patches

2018-03-19 Thread Gerd Hoffmann
The following changes since commit e1e44a9916b4318e943aecd669e096222cb3eaeb: Merge remote-tracking branch 'remotes/xtensa/tags/20180316-xtensa' into staging (2018-03-17 14:15:03 +) are available in the git repository at: git://git.kraxel.org/qemu tags/seabios-1.11.1-20180319-pull

Re: [Qemu-devel] HELP

2018-03-19 Thread Stefan Hajnoczi
On Sat, Mar 17, 2018 at 8:37 PM, Projat Banerjee wrote: > What is the type of proposal should I submit here ? What kind or on what > basis should I build my proposal so that I may get easily selected or chances > for my selection is high ? Are you referring to

Re: [Qemu-devel] [PATCH 8/9] hw/arm/bcm2836: Hardcode correct CPU type

2018-03-19 Thread Peter Maydell
On 13 March 2018 at 23:16, Philippe Mathieu-Daudé wrote: > On 03/13/2018 06:09 PM, Peter Maydell wrote: >> On 13 March 2018 at 16:55, Andrew Baumann >> wrote: >>> At some point I remember seeing a patch to change this to cortex-a7. Is >>> there a

Re: [Qemu-devel] [Qemu-arm] [PATCH 8/9] hw/arm/bcm2836: Hardcode correct CPU type

2018-03-19 Thread Peter Maydell
On 13 March 2018 at 15:34, Peter Maydell wrote: > Now we have separate types for BCM2386 and BCM2387, we might as well > just hard-code the CPU type they use rather than having it passed > through as an object property. This then lets us put the initialization > of the

Re: [Qemu-devel] [PATCH] migration: Fix rate limiting issue on RDMA migration

2018-03-19 Thread 858585 jemmy
ping. On Thu, Mar 15, 2018 at 1:33 PM, 858585 jemmy wrote: > On Thu, Mar 15, 2018 at 4:19 AM, Dr. David Alan Gilbert > wrote: >> * Lidong Chen (jemmy858...@gmail.com) wrote: >>> RDMA migration implement save_page function for QEMUFile, but >>>

Re: [Qemu-devel] Moving seabios-hppa git submodule to use a qemu.org mirror

2018-03-19 Thread Peter Maydell
On 21 February 2018 at 05:27, Jeff Cody wrote: > On Tue, Feb 20, 2018 at 06:43:22PM +, Peter Maydell wrote: >> I just noticed that we seem to have acquired another git >> submodule that isn't pointing to a qemu.org git url: >> >> [submodule "roms/seabios-hppa"] >>

Re: [Qemu-devel] [PATCH] gdbstub: send a terminaison packet instead of crashing gdb

2018-03-19 Thread KONRAD Frederic
Hi Philippe, Thanks for the review! BTW I forgot the for 2.12 tag can this be included in 2.12 or is it too late? Thanks, Fred On 03/19/2018 12:30 AM, Philippe Mathieu-Daudé wrote: On 03/16/2018 05:23 PM, KONRAD Frederic wrote: Since the commit: commit

Re: [Qemu-devel] [PATCH 5/8] migration: move calling control_save_page to the common place

2018-03-19 Thread Dr. David Alan Gilbert
* Xiao Guangrong (guangrong.x...@gmail.com) wrote: > > > On 03/15/2018 07:47 PM, Dr. David Alan Gilbert wrote: > > > > /* Check the pages is dirty and if it is send it */ > > > if (migration_bitmap_clear_dirty(rs, pss->block, pss->page)) { > > > +RAMBlock *block =

Re: [Qemu-devel] qapi escape-too-big test doesn't work if LANG=C ?

2018-03-19 Thread Daniel P . Berrangé
On Mon, Mar 19, 2018 at 10:37:12AM +, Peter Maydell wrote: > I recently tweaked my build scripts to run with LANG=C (trying > to suppress gcc's irritating habit of using smartquotes rather > than plain old ''). This seems to result in an error running > the qapi-schema/escape-too-big test: >

Re: [Qemu-devel] [PATCH v8 5/9] block: treat BDRV_REQ_ALLOCATE as serialising

2018-03-19 Thread Alberto Garcia
On Mon 12 Mar 2018 11:16:54 AM CET, Anton Nefedov wrote: > The idea is that ALLOCATE requests may overlap with other requests. > Reuse the existing block layer infrastructure for serialising requests. > Use the following approach: > - mark ALLOCATE serialising, so subsequent requests to the area

[Qemu-devel] qapi escape-too-big test doesn't work if LANG=C ?

2018-03-19 Thread Peter Maydell
I recently tweaked my build scripts to run with LANG=C (trying to suppress gcc's irritating habit of using smartquotes rather than plain old ''). This seems to result in an error running the qapi-schema/escape-too-big test: PYTHONPATH=/home/petmay01/linaro/qemu-for-merges/scripts python3 -B

Re: [Qemu-devel] [PATCH 1/2] char: i.MX: Simplify imx_update()

2018-03-19 Thread Peter Maydell
On 15 March 2018 at 19:11, Andrey Smirnov wrote: > Code of imx_update() is slightly confusing since the "flags" variable > doesn't really corespond to anything in real hardware and server as a > kitchensink accumulating events normally reported via USR1 and USR2 >

Re: [Qemu-devel] [PATCH 2/8] migration: stop allocating and freeing memory frequently

2018-03-19 Thread Dr. David Alan Gilbert
* Xiao Guangrong (guangrong.x...@gmail.com) wrote: > > > On 03/15/2018 07:03 PM, Dr. David Alan Gilbert wrote: > > > > +static int compress_threads_load_setup(void) > > > +{ > > > +int i, thread_count; > > > + > > > +if (!migrate_use_compression()) { > > > +return 0; > > > +

[Qemu-devel] [PATCH v2 2/2] target/m68k: add a mechanism to automatically free TCGv

2018-03-19 Thread Laurent Vivier
SRC_EA() and gen_extend() can return either a temporary TCGv or a memory allocated one. Mark them when they are allocated, and free them automatically at end of the instruction translation. We want to free locally allocated TCGv to avoid overflow in sequence like: 0xc00ae406: movel

[Qemu-devel] [PATCH v2 0/2] target/m68k: add a mechanism to automatically free TCGv

2018-03-19 Thread Laurent Vivier
SRC_EA() and gen_extend() can return either a temporary TCGv or a memory allocated one. Mark them when they are allocated, and free them automatically at end of the instruction translation. We want to free locally allocated TCGv to avoid overflow in sequence like:

[Qemu-devel] [PATCH v2 1/2] target/m68k: add DisasContext parameter to gen_extend()

2018-03-19 Thread Laurent Vivier
This parameter will be needed to manage automatic release of temporary allocated TCG variables. Signed-off-by: Laurent Vivier --- target/m68k/translate.c | 46 +++--- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 8/9] hw/arm/bcm2836: Hardcode correct CPU type

2018-03-19 Thread Igor Mammedov
On Thu, 15 Mar 2018 17:13:03 + Peter Maydell wrote: > On 13 March 2018 at 16:55, Andrew Baumann > wrote: > >> From: Qemu-devel >> bounces+andrew.baumann=microsoft@nongnu.org> On Behalf Of Peter > >> Maydell > >> Sent: Tuesday, 13

Re: [Qemu-devel] [PULL v2 0/7] Machine queue, 2018-03-15

2018-03-19 Thread Igor Mammedov
On Fri, 16 Mar 2018 16:28:54 -0300 Eduardo Habkost wrote: > On Fri, Mar 16, 2018 at 07:05:29PM +, Peter Maydell wrote: > > On 15 March 2018 at 18:14, Eduardo Habkost wrote: > > > Changes in v2 (v1 was 2018-03-12): > > > * Fix bsd-user build error >

Re: [Qemu-devel] [PATCH v4] file-posix: specify expected filetypes

2018-03-19 Thread Kevin Wolf
Am 13.03.2018 um 18:20 hat John Snow geschrieben: > > > On 01/19/2018 06:03 PM, Eric Blake wrote: > > On 01/19/2018 04:47 PM, John Snow wrote: > >> Adjust each caller of raw_open_common to specify if they are expecting > >> host and character devices or not. Tighten expectations of file types

Re: [Qemu-devel] [PATCH v3 14/22] target/arm: Make PMOVSCLR 64 bits wide

2018-03-19 Thread Aaron Lindsay
Phil, On Mar 19 00:14, Philippe Mathieu-Daudé wrote: > Hi Aaron, > > On 03/16/2018 09:31 PM, Aaron Lindsay wrote: > > This is a bug fix to ensure 64-bit reads of this register don't read > > adjacent data. > > > > Signed-off-by: Aaron Lindsay > > --- > >

Re: [Qemu-devel] [PULL 00/38] QAPI patches for 2018-03-12, 2.12 softfreeze

2018-03-19 Thread Eric Blake
On 03/19/2018 09:57 AM, Eric Blake wrote: On 03/19/2018 04:26 AM, Peter Xu wrote: for you to fetch changes up to 75eb57e3ed3682f011a6694863044e8b143a9821:    qapi: Pass '-u' when doing non-silent diff (2018-03-16 09:00:07 -0500) Hi. I get a bunch of test assertion failures with this:

Re: [Qemu-devel] [PATCH] replay: finish record/replay before closing the disks

2018-03-19 Thread Paolo Bonzini
On 19/03/2018 10:25, Pavel Dovgalyuk wrote: > After recent updates block devices cannot be closed on qemu exit. > This happens due to the block request polling when replay is not finished. > Therefore now we stop execution recording before closing the block devices. > > Signed-off-by: Pavel

Re: [Qemu-devel] [PATCH] audio: Convert use of atoi to qemu_strtoi

2018-03-19 Thread nee
On Mon, Mar 19, 2018 at 2:47 PM, Eric Blake wrote: > On 03/16/2018 09:40 AM, Nia Alarie wrote: >> >> If qemu_strtoi indicates an error, return the default value. > > > Would it be better to diagnose the error instead of silently returning a > default value? > >> >>

[Qemu-devel] [PATCH 2/2] vhost-user-scsi: reset the device if supported

2018-03-19 Thread David Vrabel
If the vhost-user-scsi backend supports the VHOST_USER_F_RESET_DEVICE protocol feature, then the device can be reset when requested. If this feature is not supported, do not try a reset as this will send a VHOST_USER_RESET_OWNER that the backend is not expecting, potentially putting into an

[Qemu-devel] [PATCH 0/2] vhost-user-scsi: add message for device reset

2018-03-19 Thread David Vrabel
When a virtio scsi device is reset by a guest, the reset is not passed on to the vhost-user backend. This reset may be necessary if a device driver is restarted or the device is handed off between (for example) SeaBIOS and the OS. Iff the vhost-user-scsi backend reports that it supports a new

[Qemu-devel] [PATCH 1/2] vhost-user: add VHOST_USER_RESET_DEVICE to reset devices

2018-03-19 Thread David Vrabel
Add a VHOST_USER_RESET_DEVICE message which will reset the vhost user backend. Disabling all rings, and resetting all internal state, ready for the backend to be reinitialized. A backend has to report it supports this features with the VHOST_USER_PROTOCOL_F_RESET_DEVICE protocol feature bit. If

Re: [Qemu-devel] qapi escape-too-big test doesn't work if LANG=C ?

2018-03-19 Thread Eric Blake
On 03/19/2018 06:20 AM, Daniel P. Berrangé wrote: On Mon, Mar 19, 2018 at 10:37:12AM +, Peter Maydell wrote: I recently tweaked my build scripts to run with LANG=C (trying to suppress gcc's irritating habit of using smartquotes rather than plain old ''). This seems to result in an error

[Qemu-devel] [PATCH 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR

2018-03-19 Thread Shannon Zhao
It should skip to getting/putting the registers banked by GICR so that it could get/put the correct ones. Signed-off-by: Shannon Zhao --- hw/intc/arm_gicv3_kvm.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/hw/intc/arm_gicv3_kvm.c

Re: [Qemu-devel] [PATCH] audio: Convert use of atoi to qemu_strtoi

2018-03-19 Thread Eric Blake
On 03/16/2018 09:40 AM, Nia Alarie wrote: If qemu_strtoi indicates an error, return the default value. Would it be better to diagnose the error instead of silently returning a default value? Signed-off-by: Nia Alarie --- audio/audio.c | 3 +-- 1 file changed, 1

Re: [Qemu-devel] [PATCH] iotests: 163 is not quick

2018-03-19 Thread Kevin Wolf
Am 10.03.2018 um 22:45 hat Eric Blake geschrieben: > Testing on ext4, most 'quick' qcow2 tests took less than 5 seconds, > but 163 took more than 20. Let's remove it from the quick set. > > Signed-off-by: Eric Blake Takes only 11 seconds for me, but that's still longer than

[Qemu-devel] [PULL v2 3/7] fixup! tests: add machine 'none' with -cpu test

2018-03-19 Thread Igor Mammedov
Fixup test to account for 2 new targets that were merged since this test was written. Signed-off-by: Igor Mammedov --- tests/machine-none-test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/machine-none-test.c b/tests/machine-none-test.c index

Re: [Qemu-devel] [PATCH v3 14/22] target/arm: Make PMOVSCLR 64 bits wide

2018-03-19 Thread Peter Maydell
On 19 March 2018 at 15:24, Aaron Lindsay wrote: > Phil, > > On Mar 19 00:14, Philippe Mathieu-Daudé wrote: >> Hi Aaron, >> >> On 03/16/2018 09:31 PM, Aaron Lindsay wrote: >> > This is a bug fix to ensure 64-bit reads of this register don't read >> > adjacent data. >> > >>

Re: [Qemu-devel] [PATCH] hax: Properly handle IA32_APIC_BASE MSR

2018-03-19 Thread Igor Mammedov
On Mon, 19 Mar 2018 17:04:49 +0800 chao@linux.intel.com wrote: > From: Qin Chao > > Emulation of IA32_APIC_BASE MSR in HAXM is not correct, such as bit > 8, which is BSP flag and should be set to 1 for the bootstrap > processor and set to 0 for the application

[Qemu-devel] [PATCH] hax: Properly handle IA32_APIC_BASE MSR

2018-03-19 Thread chao . qin
From: Qin Chao Emulation of IA32_APIC_BASE MSR in HAXM is not correct, such as bit 8, which is BSP flag and should be set to 1 for the bootstrap processor and set to 0 for the application processors, but it's set to 0 for all processors in HAXM. So guest OSes that expect a

[Qemu-devel] [PATCH 0/2] two fixes for KVM GICv3 dist get/put functions

2018-03-19 Thread Shannon Zhao
Shannon Zhao (2): arm_gicv3_kvm: increase clroffset accordingly arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR hw/intc/arm_gicv3_kvm.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) -- 2.0.4

Re: [Qemu-devel] [PULL 00/38] QAPI patches for 2018-03-12, 2.12 softfreeze

2018-03-19 Thread Eric Blake
On 03/19/2018 04:26 AM, Peter Xu wrote: for you to fetch changes up to 75eb57e3ed3682f011a6694863044e8b143a9821: qapi: Pass '-u' when doing non-silent diff (2018-03-16 09:00:07 -0500) Hi. I get a bunch of test assertion failures with this: ppc64 host:

Re: [Qemu-devel] [PATCH] audio: Convert use of atoi to qemu_strtoi

2018-03-19 Thread Eric Blake
On 03/19/2018 10:01 AM, nee wrote: On Mon, Mar 19, 2018 at 2:47 PM, Eric Blake wrote: On 03/16/2018 09:40 AM, Nia Alarie wrote: If qemu_strtoi indicates an error, return the default value. Would it be better to diagnose the error instead of silently returning a default

Re: [Qemu-devel] [PATCH v9 13/14] hw/arm/virt-acpi-build: Add smmuv3 node in IORT table

2018-03-19 Thread Shannon Zhao
On 2018/3/12 20:48, Peter Maydell wrote: > On 17 February 2018 at 18:46, Eric Auger wrote: >> From: Prem Mallappa >> >> This patch builds the smmuv3 node in the ACPI IORT table. >> >> The RID space of the root complex, which spans 0x0-0x1

Re: [Qemu-devel] [PATCH v3 23/24] RISC-V: Convert cpu definition towards future model

2018-03-19 Thread Igor Mammedov
On Fri, 16 Mar 2018 12:41:20 -0700 Michael Clark wrote: > - Model borrowed from target/sh4/cpu.c > - Rewrote riscv_cpu_list to use object_class_get_list > - Dropped 'struct RISCVCPUInfo' and used TypeInfo array > - Replaced riscv_cpu_register_types with DEFINE_TYPES > - Marked

[Qemu-devel] [PATCH RFC] scripts/checkpatch.pl: Bug fix

2018-03-19 Thread Su Hang
Bug fix: checkpatch.pl stops complaining about following pattern: """ do { //do somethins; } while (conditions); """ Signed-off-by: Su Hang --- scripts/checkpatch.pl | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH 1/2] arm_gicv3_kvm: increase clroffset accordingly

2018-03-19 Thread Shannon Zhao
It forgot to increase clroffset during the loop. So it only clear the first 4 bytes. Signed-off-by: Shannon Zhao --- hw/intc/arm_gicv3_kvm.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/intc/arm_gicv3_kvm.c b/hw/intc/arm_gicv3_kvm.c

Re: [Qemu-devel] [PATCH RFC] scripts/checkpatch.pl: Bug fix

2018-03-19 Thread Eric Blake
On 03/19/2018 08:56 AM, Su Hang wrote: Bug fix: checkpatch.pl stops complaining about following pattern: """ do { //do somethins; s/somethins/something/ } while (conditions); Having the commit message point to the commit id that introduced the bug is useful. The grammar is awkward

Re: [Qemu-devel] [PATCH RFC] scripts/checkpatch.pl: Bug fix

2018-03-19 Thread Su Hang
> -Original Messages- > From: "Eric Blake" > Sent Time: 2018-03-19 23:25:20 (Monday) > To: "Su Hang" , vsement...@virtuozzo.com > Cc: qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] [PATCH RFC] scripts/checkpatch.pl: Bug fix > Having the

Re: [Qemu-devel] [PATCH v2] tcg: Really fix cpu_io_recompile

2018-03-19 Thread Paolo Bonzini
On 19/03/2018 04:15, Richard Henderson wrote: > We have confused the number of instructions that have been > executed in the TB with the number of instructions needed > to repeat the I/O instruction. > > We have used cpu_restore_state_from_tb, which means that > the guest pc is pointing to the

[Qemu-devel] [PATCH v2] target-mips: Add initrd support for the Boston board

2018-03-19 Thread Aleksandar Rikalo
From: Aleksandar Rikalo Add support for initial ramdisk loading for the Mips Boston board. Signed-off-by: Aleksandar Rikalo Reviewed-by: Philippe Mathieu-Daudé --- Changes since previous version according to Philippe's

[Qemu-devel] [PATCH for-2.12] hw/misc/macio: Fix crash when listing device properties of macio device

2018-03-19 Thread Thomas Huth
The macio-newworld device can currently be used to abort QEMU unexpectedly: $ ppc-softmmu/qemu-system-ppc -S -M ref405ep,accel=qtest -qmp stdio {"QMP": {"version": {"qemu": {"micro": 50, "minor": 11, "major": 2}, "package": "build-all"}, "capabilities": []}} { 'execute': 'qmp_capabilities' }

[Qemu-devel] [Bug 1756807] Re: performance regression in qemu-user + proot

2018-03-19 Thread ChristianEhrhardt
Thanks for the check Alistar, Lets add a Qemu (upstream) bug task so this one is mirrored to the ML. I'm not familiar with that area, but on the ML one can decide if it is a dup to https://bugs.launchpad.net/qemu/+bug/1740219 or not. ** Also affects: qemu Importance: Undecided Status:

[Qemu-devel] [PATCH for-2.12] hw/char/serial: Fix crash when serial_mm_init() is used with -nodefaults

2018-03-19 Thread Thomas Huth
Quite a lot of boards call serial_mm_init() directly with a value from the serial_hds[] table. However, this table is only containing NULL if QEMU has been started with "-nodefaults": $ gdb --args arm-softmmu/qemu-system-arm -S -nodefaults -M cubieboard (gdb) r Program received signal SIGSEGV,

Re: [Qemu-devel] [PATCH] hax: Properly handle IA32_APIC_BASE MSR

2018-03-19 Thread Paolo Bonzini
On 19/03/2018 10:04, chao@linux.intel.com wrote: > From: Qin Chao > > Emulation of IA32_APIC_BASE MSR in HAXM is not correct, such as bit > 8, which is BSP flag and should be set to 1 for the bootstrap > processor and set to 0 for the application processors, but it's set

Re: [Qemu-devel] [PATCH] hax: Properly handle IA32_APIC_BASE MSR

2018-03-19 Thread Qin, Chao
On 3/20/2018 12:05 AM, Igor Mammedov wrote: On Mon, 19 Mar 2018 17:04:49 +0800 chao@linux.intel.com wrote: > >> From: Qin Chao >> >> Emulation of IA32_APIC_BASE MSR in HAXM is not correct, such as >> bit 8, which is BSP flag and should be set to 1 for the bootstrap

Re: [Qemu-devel] pvrdma build with clang fails

2018-03-19 Thread Marcel Apfelbaum
Hi Michael, On 20/03/2018 3:40, Michael S. Tsirkin wrote: > Marcel, could you pls try a pvrdma build with clang? > It seems to fail due to enum type mismatches. > I guess this is something worth fixing. > Sure, I will fix it. Marcel

Re: [Qemu-devel] [PATCH v3] RISC-V: Fix riscv_isa_string memory size bug

2018-03-19 Thread Richard Henderson
On 03/20/2018 02:35 AM, Michael Clark wrote: > FYI - I also have an experimental branch containing a RISC-V TCG back-end > that I started on during the RISC-V Hackathon in Portland last week: > > - https://github.com/michaeljclark/riscv-qemu/tree/wip-riscv-tcg-backend Cool. > I'm able to run a

[Qemu-devel] [Bug 1385934] Re: USB with passthrougth guest cannot enumerate USB host

2018-03-19 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1385934 Title: USB with

Re: [Qemu-devel] [PATCH v2] tcg: Really fix cpu_io_recompile

2018-03-19 Thread Philippe Mathieu-Daudé
On 03/19/2018 04:15 AM, Richard Henderson wrote: > We have confused the number of instructions that have been > executed in the TB with the number of instructions needed > to repeat the I/O instruction. > > We have used cpu_restore_state_from_tb, which means that > the guest pc is pointing to the

Re: [Qemu-devel] [Qemu-arm] [PATCH v3 01/22] target/arm: A53: Initialize PMCEID[01]

2018-03-19 Thread Philippe Mathieu-Daudé
On 03/19/2018 09:35 PM, Aaron Lindsay wrote: > On Mar 18 23:35, Philippe Mathieu-Daudé wrote: >> Hi Aaron, >> >> On 03/16/2018 09:30 PM, Aaron Lindsay wrote: >>> A53 advertises ARM_FEATURE_PMU, but wasn't initializing pmceid[01]. >>> pmceid[01] are already being initialized to zero for both A15

Re: [Qemu-devel] [PATCH] scripts/decodetree: Fix insnmask not marked as global in main()

2018-03-19 Thread Richard Henderson
On 03/19/2018 07:58 PM, Bastian Koppelmann wrote: > if '-w 16' was given as a cmdline args a local copy of insnmask > is set and not the global one. > > Signed-off-by: Peer Adelt > Signed-off-by: Bastian Koppelmann Reviewed-by:

[Qemu-devel] pvrdma build with clang fails

2018-03-19 Thread Michael S. Tsirkin
Marcel, could you pls try a pvrdma build with clang? It seems to fail due to enum type mismatches. I guess this is something worth fixing. -- MST

Re: [Qemu-devel] [PATCH] vhost-user: avoid misaligned access

2018-03-19 Thread Zhoujian (jay)
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Saturday, March 17, 2018 2:20 AM > To: qemu-devel@nongnu.org > Cc: Zhoujian (jay) > Subject: [PATCH] vhost-user: avoid misaligned access > > We can't pass a pointer to memory field

Re: [Qemu-devel] [PATCH v2] virtio_net: flush uncompleted TX on reset

2018-03-19 Thread Jason Wang
On 2018年03月16日 20:07, Greg Kurz wrote: If the backend could not transmit a packet right away for some reason, the packet is queued for asynchronous sending. The corresponding vq element is tracked in the async_tx.elem field of the VirtIONetQueue, for later freeing when the transmission is

Re: [Qemu-devel] [PATCH] vhost-user: avoid misaligned access

2018-03-19 Thread Michael S. Tsirkin
On Tue, Mar 20, 2018 at 02:01:07AM +, Zhoujian (jay) wrote: > > > > -Original Message- > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Sent: Saturday, March 17, 2018 2:20 AM > > To: qemu-devel@nongnu.org > > Cc: Zhoujian (jay) > > Subject: [PATCH]

[Qemu-devel] [PATCH] replay: finish record/replay before closing the disks

2018-03-19 Thread Pavel Dovgalyuk
After recent updates block devices cannot be closed on qemu exit. This happens due to the block request polling when replay is not finished. Therefore now we stop execution recording before closing the block devices. Signed-off-by: Pavel Dovgalyuk --- replay/replay.c |

[Qemu-devel] [PATCH v1 1/1] iotests: fix test case 185

2018-03-19 Thread QingFeng Hao
Test case 185 failed since commit 4486e89c219 --- "vl: introduce vm_shutdown()". It's because of the newly introduced function vm_shutdown calls bdrv_drain_all, which is called later by bdrv_close_all. bdrv_drain_all resumes the jobs that doubles the speed and offset is doubled. Some jobs' status

Re: [Qemu-devel] [PULL 0/8] ppc-for-2.12 queue 20180319

2018-03-19 Thread Peter Maydell
> > are available in the Git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-2.12-20180319 > > for you to fetch changes up to 91c60f124e682a78c9a2ef951e8e58ebab6441d0: > > target/ppc: fix tlbsync to check privilege level depen

[Qemu-devel] [PULL v3 00/46] Block layer patches

2018-03-19 Thread Kevin Wolf
The following changes since commit e1e44a9916b4318e943aecd669e096222cb3eaeb: Merge remote-tracking branch 'remotes/xtensa/tags/20180316-xtensa' into staging (2018-03-17 14:15:03 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to

Re: [Qemu-devel] [PATCH 8/9] hw/arm/bcm2836: Hardcode correct CPU type

2018-03-19 Thread Peter Maydell
On 19 March 2018 at 14:40, Igor Mammedov wrote: > On Thu, 15 Mar 2018 17:13:03 + > Peter Maydell wrote: >> Igor, can you help with this question? For a board that always >> has one CPU type (because the real hardware only ever has >> one SoC,

Re: [Qemu-devel] https:// for GIT submodules / "smart" HTTP protocol on git.qemu.git

2018-03-19 Thread Daniel P . Berrangé
On Mon, Mar 19, 2018 at 04:49:39PM +, Daniel P. Berrangé wrote: > Most of QEMU regular developers are fortunate to have unfiltered internet > access which allows using the git:// protocol. People working in more > old fashioned / paranoid environments often find access to anything other > than

Re: [Qemu-devel] [PATCH v3] RISC-V: Fix riscv_isa_string memory size bug

2018-03-19 Thread Michael Clark
On Sun, Mar 18, 2018 at 4:22 PM, Philippe Mathieu-Daudé wrote: > On 03/16/2018 06:26 PM, Michael Clark wrote: > > This version uses a constant size memory buffer sized for > > the maximum possible ISA string length. It also uses g_new > > instead of g_new0, uses more efficient

Re: [Qemu-devel] Moving seabios-hppa git submodule to use a qemu.org mirror

2018-03-19 Thread Jeff Cody
On Mon, Mar 19, 2018 at 01:19:36PM +, Peter Maydell wrote: > On 21 February 2018 at 05:27, Jeff Cody wrote: > > On Tue, Feb 20, 2018 at 06:43:22PM +, Peter Maydell wrote: > >> I just noticed that we seem to have acquired another git > >> submodule that isn't pointing to

[Qemu-devel] [PULL 05/13] hw/arm/raspi: Don't do board-setup or secure-boot for raspi3

2018-03-19 Thread Peter Maydell
For the rpi1 and 2 we want to boot the Linux kernel via some custom setup code that makes sure that the SMC instruction acts as a no-op, because it's used for cache maintenance. The rpi3 boots AArch64 kernels, which don't need SMC for cache maintenance and always expect to be booted non-secure.

[Qemu-devel] [PULL 09/13] hw/arm/bcm2836: Rename bcm2836 type/struct to bcm283x

2018-03-19 Thread Peter Maydell
Our BCM2836 type is really a generic one that can be any of the bcm283x family. Rename it accordingly. We change only the names which are visible via the header file to the rest of the QEMU code, leaving private function names in bcm2836.c as they are. This is a preliminary to making bcm283x be

Re: [Qemu-devel] [PULL v3 00/38] QAPI patches for 2018-03-12, 2.12 softfreeze

2018-03-19 Thread Peter Maydell
On 19 March 2018 at 16:41, Eric Blake wrote: > The following changes since commit 2c8cfc0b52b5a4d123c26c0b5fdf941be24805be: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2018-03-19 11:44:26 +) > > are available in the Git repository

[Qemu-devel] [PULL 13/13] hw/arm/raspi: Provide spin-loop code for AArch64 CPUs

2018-03-19 Thread Peter Maydell
The raspi3 has AArch64 CPUs, which means that our smpboot code for keeping the secondary CPUs in a pen needs to have a version for A64 as well as A32. Without this, the secondary CPUs go into an infinite loop of taking undefined instruction exceptions. Signed-off-by: Peter Maydell

Re: [Qemu-devel] Moving seabios-hppa git submodule to use a qemu.org mirror

2018-03-19 Thread Jeff Cody
On Mon, Mar 19, 2018 at 02:32:22PM +0100, BALATON Zoltan wrote: > On Mon, 19 Mar 2018, Peter Maydell wrote: > >On 21 February 2018 at 05:27, Jeff Cody wrote: > >>On Tue, Feb 20, 2018 at 06:43:22PM +, Peter Maydell wrote: > >>>I just noticed that we seem to have acquired

Re: [Qemu-devel] [PATCH for-2.12] hmp: free sev info

2018-03-19 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 03/19/2018 12:58 PM, Marc-André Lureau wrote: > > Found thanks to ASAN: > > > > Direct leak of 16 byte(s) in 1 object(s) allocated from: > > #0 0x7efe20417a38 in __interceptor_calloc (/lib64/libasan.so.4+0xdea38) > > #1 0x7efe1f7b2f75 in

[Qemu-devel] [PULL 01/13] fsl-imx6: Swap Ethernet interrupt defines

2018-03-19 Thread Peter Maydell
From: Guenter Roeck The sabrelite machine model used by qemu-system-arm is based on the Freescale/NXP i.MX6Q processor. This SoC has an on-board ethernet controller which is supported in QEMU using the imx_fec.c module (actually called imx.enet for this model.) The

[Qemu-devel] [PULL 06/13] hw/arm/boot: assert that secure_boot and secure_board_setup are false for AArch64

2018-03-19 Thread Peter Maydell
Add some assertions that if we're about to boot an AArch64 kernel, the board code has not mistakenly set either secure_boot or secure_board_setup. It doesn't make sense to set secure_boot, because all AArch64 kernels must be booted in non-secure mode. It might in theory make sense to set

[Qemu-devel] [PULL 10/13] hw/arm/bcm2836: Create proper bcm2837 device

2018-03-19 Thread Peter Maydell
The bcm2837 is pretty similar to the bcm2836, but it does have some differences. Notably, the MPIDR affinity aff1 values it sets for the CPUs are 0x0, rather than the 0xf that the bcm2836 uses, and if this is wrong Linux will not boot. Rather than trying to have one device with properties that

[Qemu-devel] [PULL 03/13] char: i.MX: Simplify imx_update()

2018-03-19 Thread Peter Maydell
From: Andrey Smirnov Code of imx_update() is slightly confusing since the "flags" variable doesn't really corespond to anything in real hardware and server as a kitchensink accumulating events normally reported via USR1 and USR2 registers. Change the code to explicitly

[Qemu-devel] [PULL 11/13] hw/arm/bcm2836: Use correct affinity values for BCM2837

2018-03-19 Thread Peter Maydell
The BCM2837 sets the Aff1 field of the MPIDR affinity values for the CPUs to 0, whereas the BCM2836 uses 0xf. Set this correctly, as it is required for Linux to boot. Signed-off-by: Peter Maydell Reviewed-by: Andrew Baumann Reviewed-by:

[Qemu-devel] [PULL 12/13] hw/arm/bcm2836: Hardcode correct CPU type

2018-03-19 Thread Peter Maydell
Now we have separate types for BCM2386 and BCM2387, we might as well just hard-code the CPU type they use rather than having it passed through as an object property. This then lets us put the initialization of the CPU object in init rather than realize. Note that this change means that it's no

Re: [Qemu-devel] [PATCH for-2.12] hmp: free sev info

2018-03-19 Thread Eric Blake
On 03/19/2018 12:58 PM, Marc-André Lureau wrote: Found thanks to ASAN: Direct leak of 16 byte(s) in 1 object(s) allocated from: #0 0x7efe20417a38 in __interceptor_calloc (/lib64/libasan.so.4+0xdea38) #1 0x7efe1f7b2f75 in g_malloc0 ../glib/gmem.c:124 #2 0x7efe1f7b3249 in

Re: [Qemu-devel] https:// for GIT submodules / "smart" HTTP protocol on git.qemu.git

2018-03-19 Thread Jeff Cody
On Mon, Mar 19, 2018 at 06:28:16PM +, Daniel P. Berrangé wrote: > On Mon, Mar 19, 2018 at 04:49:39PM +, Daniel P. Berrangé wrote: > > Most of QEMU regular developers are fortunate to have unfiltered internet > > access which allows using the git:// protocol. People working in more > > old

Re: [Qemu-devel] [PATCH v3 2/7] qapi: Add qobject_to()

2018-03-19 Thread Max Reitz
On 2018-03-19 20:36, Eric Blake wrote: > On 02/26/2018 05:58 AM, Max Reitz wrote: >> On 2018-02-24 21:57, Eric Blake wrote: >>> On 02/24/2018 09:40 AM, Max Reitz wrote: This is a dynamic casting macro that, given a QObject type, returns an object as that type or NULL if the object is of

Re: [Qemu-devel] [PATCH v3] RISC-V: Fix riscv_isa_string memory size bug

2018-03-19 Thread Richard W.M. Jones
On Mon, Mar 19, 2018 at 11:35:51AM -0700, Michael Clark wrote: > The RISC-V post-merge spec conformance and cleanup series has had a lot of > testing. I've been using it to compile QEMU inside of QEMU using the RISC-V > Fedora Image and its native RISC-V GCC toolchain running inside SMP Linux >

Re: [Qemu-devel] [PULL v3 00/38] QAPI patches for 2018-03-12, 2.12 softfreeze

2018-03-19 Thread Eric Blake
On 03/19/2018 01:43 PM, Peter Maydell wrote: On 19 March 2018 at 16:41, Eric Blake wrote: The following changes since commit 2c8cfc0b52b5a4d123c26c0b5fdf941be24805be: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2018-03-19 11:44:26 +)

Re: [Qemu-devel] [PATCH v3 2/7] qapi: Add qobject_to()

2018-03-19 Thread Eric Blake
On 02/26/2018 05:58 AM, Max Reitz wrote: On 2018-02-24 21:57, Eric Blake wrote: On 02/24/2018 09:40 AM, Max Reitz wrote: This is a dynamic casting macro that, given a QObject type, returns an object as that type or NULL if the object is of a different type (or NULL itself). +#define

  1   2   3   4   >