Import KVM_CAP_ARM_INJECT_SERROR_ESR and struct kvm_vcpu_events
for arm64, they are added manually in the kernel tree, so it will be
added after re-running scripts/update-linux-headers.sh.
Signed-off-by: Dongjiu Geng
---
linux-headers/asm-arm/kvm.h | 12
support for KVM_GET/SET_VCPU_EVENTS to get/set the SError exception
state, and support the state migration.
change since v2:
1. add header definition for arm platform
change since v1:
1. update the code to fix the build errors
Dongjiu Geng (2):
linux-headers: sync linux headers
target: arm:
On Tue, Jun 05, 2018 at 10:06:29PM +0800, Fam Zheng wrote:
> Based-on: <20180529055959.32002-1-f...@redhat.com>
> ([PATCH v7 00/10] qemu-img convert with copy offloading)
>
> This enhances the backup job to make use of the copy offloading API. It
> eliminates the necessity to use the bounce
We currently don't enforce that the sparse segments we detect during convert are
aligned. This leads to unnecessary and costly read-modify-write cycles either
internally in Qemu or in the background on the storage device as nearly all
modern filesystems or hardware has a 4k alignment internally.
Daniel P. Berrangé writes:
> On Fri, Jun 01, 2018 at 05:18:35PM +0800, Fam Zheng wrote:
>> When hot-plugging a block device fails due to image locking errors,
>> users won't see the helpful 'Is another process using the image?'
>> message in QMP because currently the error hint is not carried
Dear all,
Currently Qemu supports only 2 cores when SMP enabled for or1k architecure, so
I would like to know if there is a quick way to increase the number of cores by
changing a few lines of code or to accomplish this, will requires significant
changes in the source code?
I'm asking because
Philippe Mathieu-Daudé writes:
> On 05/30/2018 05:23 PM, John Snow wrote:
>> On 05/29/2018 01:48 PM, Philippe Mathieu-Daudé wrote:
>>> Use error_report() + abort() instead of error_setg(_abort),
>>> as suggested by the "qapi/error.h" documentation:
>>>
>>> Please don't error_setg(_fatal,
On Tue, 5 Jun 2018 09:51:26 +0200
David Hildenbrand wrote:
> On 05.06.2018 03:08, David Gibson wrote:
> > On Thu, May 17, 2018 at 10:15:19AM +0200, David Hildenbrand wrote:
> >> For multi stage hotplug handlers, we'll have to do some error handling
> >> in some hotplug functions, so let's use
Peter Xu writes:
> Add some explicit comments for both Readline and cpu_set/cpu_get helpers
> that they do not need the mon_lock protection.
>
> Signed-off-by: Peter Xu
Reviewed-by: Markus Armbruster
Peter Xu writes:
> Instead, use a dynamic function to detect which clock we'll use. The
> problem is that the old code will let monitor initialization depends on
> qtest_enabled(). After this change, we don't have such a dependency any
> more.
>
> Suggested-by: Markus Armbruster
>
On 3/2/2018 6:59 PM, Markus Armbruster wrote:
Eric Blake writes:
On 01/19/2018 06:50 AM, Anton Nefedov wrote:
A block driver can provide a callback to report driver-specific
statistics.
file-posix driver now reports discard statistics
Signed-off-by: Anton Nefedov
Reviewed-by: Vladimir
Peter Xu writes:
> Introduce a new global big lock for mon_fdsets. Take it where needed.
>
> The monitor_fdset_get_fd() handling is a bit tricky: now we need to call
> qemu_mutex_unlock() which might pollute errno, so we need to make sure
> the correct errno be passed up to the callers. To
On Thu, Jun 07, 2018 at 02:24:18PM +, Moger, Babu wrote:
[...]
> > > +/* On AMD systems, check if we can support topoext feature */
> > > +if (IS_AMD_CPU(env) &&
> > > +(env->features[FEAT_8000_0001_ECX] & CPUID_EXT3_TOPOEXT)) {
> > > +if
Thomas Huth writes:
> On 07.06.2018 08:57, Markus Armbruster wrote:
>> Thomas Huth writes:
>>
>>> On 05.06.2018 00:40, Eric Blake wrote:
On 06/04/2018 05:34 AM, Thomas Huth wrote:
> On 04.06.2018 09:18, Markus Armbruster wrote:
>> Roman Kagan writes:
>>
>>> Add helper
On 06/07/2018 02:32 PM, Peter Xu wrote:
On Thu, Jun 07, 2018 at 01:24:29PM +0800, Wei Wang wrote:
On 06/06/2018 07:02 PM, Peter Xu wrote:
On Wed, Jun 06, 2018 at 06:04:23PM +0800, Wei Wang wrote:
On 06/06/2018 01:42 PM, Peter Xu wrote:
IMHO migration states do not suite here. IMHO bitmap
On Thu, 7 Jun 2018 11:21:21 +0100
"Dr. David Alan Gilbert (git)" wrote:
> From: "Dr. David Alan Gilbert"
>
> Allow a bunch of the info commands to be used in preconfig.
> Could probably add most of them.
>
> Signed-off-by: Dr. David Alan Gilbert
Reviewed-by: Igor Mammedov
> ---
>
guest xml definition:
vps25
0cf4666d-6855-b3a8-12da-2967563f
8388608
8388608
4
/machine
hvm
Westmere
destroy
restart
restart
/usr/bin/kvm
734003200
On Mon, Jun 04, 2018 at 05:14:25PM -0500, Eric Blake wrote:
> On 06/01/2018 10:16 PM, Steffen Görtz wrote:
> > From: Steffen Goertz
> >
> > Add a new category "stimulate" to host commands that
> > act upon high-level devices associated with machines/boards.
> >
> > This is patch is part of an
On 30 May 2018 at 07:17, Cédric Le Goater wrote:
> The ftgmac100 NIC supports VLAN tag insertion and the MAC engine also
> has a control to remove VLAN tags from received packets.
>
> The VLAN control bits and VLAN tag information are contained in the
> second word of the transmit and receive
On Wed, Jun 06, 2018 at 07:02:57PM -0400, John Snow wrote:
> These point to the job versions now, not the blockjob versions which
> don't really exist anymore.
>
> Except set-speed, which does. It sticks out like a sore thumb. This
> patch doesn't fix that, but it doesn't make it any worse,
On Mon, 4 Jun 2018 12:53:42 +0200
David Hildenbrand wrote:
> >> Let me explain a little bit why I don't like such restrictions (for
> >> which I don't see a need yet):
> > (*) being conservative is good here because we can always relax restrictions
> > in future if it's needed without breaking
There is an exception when I passes iommu.passthrough=1 to guest's
kernel boot parameter(host QDF2400 kernel 4.17, guest kernel 4.14).
The guest will be hang when booting up.
When guest smmu is in passthrough mode, entry.perm will not be assigned
to flag in smmuv3_translate. It seems not be
Peter Xu writes:
> The out_lock is protecting a few Monitor fields. In the future the
> monitor code will start to run in multiple threads. We are going to
> turn it into a bigger lock to protect not only the out buffer but also
> most of the rest.
>
> Since at it, rearrange the Monitor struct
A block driver may need to know about the block configuration, most
critically the sector sizes, of a block backend for alignment purposes
or for some other reason. It doesn't seem like qemu has an existing
mechanism for a block backend to convey the required information to
the relevant block
Peter Xu writes:
> There was a regression reported by Eric Auger before with OOB:
>
> http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06231.html
>
> The fix is 951702f39c ("monitor: bind dispatch bh to iohandler context",
> 2018-04-10), which is in master already.
>
> For the bug, we
On 07/06/2018 13:27, Thomas Huth wrote:
>> As to "-enable-kvm", I don't see anything wrong with users using it, or
>> even with occasionally adding more options like it. However, we should
>> warn developers that such simple options should be syntactic sugar for a
>> structured (i.e.
hangs like this after migration are a pain to debug; especially with
that really rare recurrence rate.
The fact the RIP is changing and is moving in and out of the kernel suggests
something is happening; so it might be that we've corrupted some memory, or got
a device in a mess where the device
On 07.06.2018 13:42, Paolo Bonzini wrote:
> On 07/06/2018 13:27, Thomas Huth wrote:
>>> As to "-enable-kvm", I don't see anything wrong with users using it, or
>>> even with occasionally adding more options like it. However, we should
>>> warn developers that such simple options should be
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1528374154-14680-1-git-send-email-th...@redhat.com
Subject: [Qemu-devel] [PATCH v2 0/4] pc-bios/s390-ccw: Allow network booting
via pxelinux.cfg
=== TEST SCRIPT BEGIN ===
On Thu, Jun 07, 2018 at 09:50:41AM +0200, Thomas Huth wrote:
> On 07.06.2018 08:57, Markus Armbruster wrote:
> > Thomas Huth writes:
> >
> >> On 05.06.2018 00:40, Eric Blake wrote:
> >>> On 06/04/2018 05:34 AM, Thomas Huth wrote:
> On 04.06.2018 09:18, Markus Armbruster wrote:
> > Roman
Eric Blake writes:
> On 06/03/2018 12:05 AM, Zhang Chen wrote:
>> From: zhanghailiang
>>
>> If some errors happen during VM's COLO FT stage, it's important to
>> notify the users of this event. Together with 'x-colo-lost-heartbeat',
>> Users can intervene in COLO's failover work immediately.
>>
On Wed, Jun 06, 2018 at 07:02:56PM -0400, John Snow wrote:
> During the design for manual completion, we decided not to use the
> "manual" property as a shorthand for both auto-dismiss and auto-finalize.
>
> Fix the wording.
>
> Signed-off-by: John Snow
Reviewed-by: Jeff Cody
> ---
>
Zhang Chen writes:
> Libvirt or other high level software can use this command query colo status.
> You can test this command like that:
> {'execute':'query-colo-status'}
>
> Signed-off-by: Zhang Chen
> ---
> migration/colo.c| 39 +++
>
On 06/07/2018 03:30 PM, Stefan Hajnoczi wrote:
On Mon, Jun 04, 2018 at 03:10:47PM +0300, Ari Sundholm wrote:
On 06/04/2018 12:51 PM, Stefan Hajnoczi wrote:
On Fri, Jun 01, 2018 at 05:24:53PM +0300, Ari Sundholm wrote:
On 06/01/2018 04:32 PM, Stefan Hajnoczi wrote:
On Fri, Jun 01, 2018 at
On Mon, 4 Jun 2018 13:27:01 +0200
David Hildenbrand wrote:
> On 31.05.2018 16:13, Igor Mammedov wrote:
> > On Wed, 30 May 2018 16:13:32 +0200
> > David Hildenbrand wrote:
> >
> >> On 30.05.2018 15:08, Igor Mammedov wrote:
> >>> On Thu, 17 May 2018 10:15:17 +0200
> >>> David Hildenbrand
* Markus Armbruster (arm...@redhat.com) wrote:
> Peter Xu writes:
>
> > On Tue, Jun 05, 2018 at 01:26:34PM +0100, Dr. David Alan Gilbert (git)
> > wrote:
> >> From: "Dr. David Alan Gilbert"
> >>
> >> Allow a bunch of the info commands to be used in preconfig.
> >> Could probably add most of
Philippe Mathieu-Daudé writes:
> Hi,
>
> This series converts error_setg(_fatal) to error_report() + exit() as
> suggested by the "qapi/error.h" documentation.
Appreciated!
The series actually converts two anti-patterns.
1. From
if (COND) {
error_setg(_fatal, ...);
}
to
On 07.06.2018 15:44, Igor Mammedov wrote:
> On Mon, 4 Jun 2018 13:27:01 +0200
> David Hildenbrand wrote:
>
>> On 31.05.2018 16:13, Igor Mammedov wrote:
>>> On Wed, 30 May 2018 16:13:32 +0200
>>> David Hildenbrand wrote:
>>>
On 30.05.2018 15:08, Igor Mammedov wrote:
> On Thu, 17
This allows the block driver to use the block configuration of the new
SCSI device. One use for this information is to set request limits
using this information.
Signed-off-by: Ari Sundholm
---
hw/scsi/scsi-disk.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/scsi/scsi-disk.c
This patch series adds a new block driver, blklogwrites, to QEMU. The
driver is given two block devices: a raw device backed by an image or a
host block device, and a log device, typically backed by a file, on
which writes to the raw device are logged.
The logging format used is the same as in
This allows the block driver to use the block configuration of the new
floppy device. One use for this information is to set request limits
using this information.
Signed-off-by: Ari Sundholm
---
hw/block/fdc.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/block/fdc.c
On 07.06.2018 13:02, Paolo Bonzini wrote:
> On 07/06/2018 12:37, David Hildenbrand wrote:
>>
>> I have a related requirement, which would be to atomically grow a
>> memory regions. So instead of region_del(old)+region_add(new), I would
>> have to do it in one shot (atomically).
>>
>> AFAICS an
* Markus Armbruster (arm...@redhat.com) wrote:
> "Dr. David Alan Gilbert (git)" writes:
>
> > From: "Dr. David Alan Gilbert"
> >
> > Add a flag to command definitions to allow them to be used in preconfig
> > and check it.
> >
> > Signed-off-by: Dr. David Alan Gilbert
> > ---
> > monitor.c |
Since it is quite cumbersome to manually create a combined kernel with
initrd image for network booting, we now support loading via pxelinux
configuration files, too. In these files, the kernel, initrd and command
line parameters can be specified seperately, and the firmware then takes
care of
The ip_version information now has to be stored in the filename_ip_t
structure, and there is now a common function called tftp_get_error_info()
which can be used to get the error string for a TFTP error code.
We can also get rid of some superfluous "(char *)" casts now.
Signed-off-by: Thomas Huth
On Tue, Jun 05, 2018 at 09:47:44AM +0100, Daniel P. Berrangé wrote:
> On Tue, Jun 05, 2018 at 10:27:03AM +0200, Igor Mammedov wrote:
> > On Mon, 4 Jun 2018 22:04:13 -0300
> > Eduardo Habkost wrote:
> >
> > > On Mon, Jun 04, 2018 at 10:14:38PM +0200, Igor Mammedov wrote:
> > > > Since commit
On 6 June 2018 at 20:18, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> $ qemu-system ... -d trace:i2c_recv,trace:i2c_send
>
> 4486@1528311614.709959:i2c_recv recv(addr:0x50) data:0x00
> 4486@1528311614.709994:i2c_send send(addr:0x50) data:0x05
>
On Thu, Jun 07, 2018 at 03:20:24PM +0200, Markus Armbruster wrote:
> Daniel P. Berrangé writes:
>
> > On Fri, Jun 01, 2018 at 05:18:35PM +0800, Fam Zheng wrote:
> >> When hot-plugging a block device fails due to image locking errors,
> >> users won't see the helpful 'Is another process using the
On 7 June 2018 at 14:38, Jia He wrote:
> There is an exception when I passes iommu.passthrough=1 to guest's
> kernel boot parameter(host QDF2400 kernel 4.17, guest kernel 4.14).
> The guest will be hang when booting up.
>
> When guest smmu is in passthrough mode, entry.perm will not be assigned
>
Philippe Mathieu-Daudé writes:
> Use error_report() + exit() instead of error_setg(_fatal),
> as suggested by the "qapi/error.h" documentation:
>
>Please don't error_setg(_fatal, ...), use error_report() and
>exit(), because that's more obvious.
>
> This fixes CID 1352173:
> "Passing
On 07.06.2018 13:13, Gonglei (Arei) wrote:
>
>> -Original Message-
>> From: David Hildenbrand [mailto:da...@redhat.com]
>> Sent: Thursday, June 07, 2018 6:40 PM
>> Subject: Re: An emulation failure occurs,if I hotplug vcpus immediately
>> after the
>> VM start
>>
>> On 06.06.2018 15:57,
When using --daemonize, the initial lead process will fork a child and
then wait to be notified that setup is complete via a pipe, before it
exits. When using --preconfig there is an extra call to main_loop()
before the notification is done from os_setup_post(). Thus the parent
process won't exit
This patch extends the qemu-kvm state sync logic with support for
KVM_GET/SET_VCPU_EVENTS, giving access to yet missing SError exception.
And also it can support the exception state migration.
Signed-off-by: Dongjiu Geng
---
target/arm/cpu.h | 5
target/arm/kvm64.c | 64
With the STSI instruction, we can get the UUID of the current VM instance,
so we can support loading pxelinux config files via UUID in the file name,
too.
Signed-off-by: Thomas Huth
---
pc-bios/s390-ccw/netmain.c | 56 +-
1 file changed, 55
On 07/06/2018 13:36, David Hildenbrand wrote:
>> The dirty bitmap would be synced in kvm_region_del (so it's not true
>> that kvm_region_del would disappear, but almost :)).
> I was rather concerned when doing a KVM_SET_USER_MEMORY_REGIONS while
> some (already present) memory region is performing
On 06/07/2018 02:41 PM, Peter Maydell wrote:
> On 30 May 2018 at 07:17, Cédric Le Goater wrote:
>> The ftgmac100 NIC supports VLAN tag insertion and the MAC engine also
>> has a control to remove VLAN tags from received packets.
>>
>> The VLAN control bits and VLAN tag information are contained
>> And another point against introducing a check for the maimum alignment
>> would be: There might be users with a specified alignment > max page
>> size. Changing the behavior will break these setups (strange but true).
> check is already there implicitly as assert, and you're removing it
>
Peter Xu writes:
> Fix typo in d622cb5879c. Meanwhile move these variables close to each
> other. monitor_qapi_event_state can be declared static, add that.
>
> Reported-by: Markus Armbruster
> Signed-off-by: Peter Xu
Reviewed-by: Markus Armbruster
On 06/07/2018 10:41 AM, Markus Armbruster wrote:
> Philippe Mathieu-Daudé writes:
>> On 05/30/2018 05:23 PM, John Snow wrote:
>>> On 05/29/2018 01:48 PM, Philippe Mathieu-Daudé wrote:
Use error_report() + abort() instead of error_setg(_abort),
as suggested by the "qapi/error.h"
Peter Xu writes:
> Before this patch, monitor fd helpers might be called even earlier than
> monitor_init_globals(). This can be problematic.
>
> After previous work, now monitor_init_globals() does not depend on
> accelerator initialization any more. Call it earlier (before CLI
> parsing;
Peter Xu writes:
> Previously we cleanup the queues when we got CLOSED event. It was used
we clean up
> to make sure we won't leftover replies/events of a old client to a new
we won't send leftover replies/events of an old client
> client. Now this patch postpones that until OPENED.
What
> -Original Message-
> From: David Hildenbrand [mailto:da...@redhat.com]
> Sent: Thursday, June 07, 2018 6:40 PM
> Subject: Re: An emulation failure occurs,if I hotplug vcpus immediately after
> the
> VM start
>
> On 06.06.2018 15:57, Paolo Bonzini wrote:
> > On 06/06/2018 15:28,
On Mon, Jun 04, 2018 at 03:10:47PM +0300, Ari Sundholm wrote:
> On 06/04/2018 12:51 PM, Stefan Hajnoczi wrote:
> > On Fri, Jun 01, 2018 at 05:24:53PM +0300, Ari Sundholm wrote:
> > > On 06/01/2018 04:32 PM, Stefan Hajnoczi wrote:
> > > > On Fri, Jun 01, 2018 at 12:17:19AM +0300, Ari Sundholm
On Thu, Jun 07, 2018 at 01:17:24PM +0200, Andrea Bolognani wrote:
> On Thu, 2018-06-07 at 11:22 +0100, Daniel P. Berrangé wrote:
> > On Thu, Jun 07, 2018 at 12:02:29PM +0200, Andrea Bolognani wrote:
> > > While hints might be considered a reasonable fit for qcow2, I think
> > > it's pretty hard to
On Mon, Jun 04, 2018 at 07:17:56PM -0600, Alex Williamson wrote:
> Note that the kernel coding style, except for certain exceptions, is:
>
> /*
> * This is a
> * multi-line
> * comment
> */
Amen, the one true way. :-)
Stefan
signature.asc
Description: PGP signature
On 5 June 2018 at 22:18, Thomas Huth wrote:
> It has been marked as deprecated since QEMU v2.11, so it is time to
> remove this now. The xlnx-zcu102 machine is very much the same and
> can be used as a replacement instead.
>
> Signed-off-by: Thomas Huth
Applied to target-arm.next, thanks.
--
On 7 June 2018 at 13:40, Stefan Hajnoczi wrote:
> On Mon, Jun 04, 2018 at 07:17:56PM -0600, Alex Williamson wrote:
>> Note that the kernel coding style, except for certain exceptions, is:
>>
>> /*
>> * This is a
>> * multi-line
>> * comment
>> */
>
> Amen, the one true way. :-)
OK,
> -Original Message-
> From: Eduardo Habkost [mailto:ehabk...@redhat.com]
> Sent: Wednesday, June 6, 2018 5:06 PM
> To: Moger, Babu
> Cc: m...@redhat.com; marcel.apfelb...@gmail.com; pbonz...@redhat.com;
> r...@twiddle.net; mtosa...@redhat.com; qemu-devel@nongnu.org;
>
This allows using the two constants outside of block.c, which will
happen in a subsequent patch.
Signed-off-by: Ari Sundholm
---
block.c | 6 --
include/block/block.h | 7 +++
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/block.c b/block.c
index
The guest OS may perform writes which are aligned to the logical
sector size instead of the physical one, so logging at this granularity
records the writes performed on the block device most faithfully.
Signed-off-by: Ari Sundholm
---
block/blklogwrites.c | 47
On 06/07/2018 02:58 PM, Peter Xu wrote:
On Thu, Jun 07, 2018 at 01:29:22PM +0800, Wei Wang wrote:
[...]
+static const VMStateDescription vmstate_virtio_balloon_free_page_report = {
+.name = "virtio-balloon-device/free-page-report",
+.version_id = 1,
+.minimum_version_id = 1,
+
Peter Maydell writes:
> On 5 June 2018 at 08:46, Cornelia Huck wrote:
>> On Tue, 5 Jun 2018 06:33:22 +0200
>> Thomas Huth wrote:
>>> On 05.06.2018 03:17, Alex Williamson wrote:
>>> > On Mon, 4 Jun 2018 17:21:40 +0100
>>> > Peter Maydell wrote:
>>> >> +Multiline comments blocks should have a
"Dr. David Alan Gilbert (git)" writes:
> From: "Dr. David Alan Gilbert"
>
> Add a flag to command definitions to allow them to be used in preconfig
> and check it.
>
> Signed-off-by: Dr. David Alan Gilbert
> ---
> monitor.c | 19 +++
> 1 file changed, 19 insertions(+)
>
> diff
This patch series adds pxelinux.cfg-style network booting to the s390-ccw
firmware. The core pxelinux.cfg loading and parsing logic has recently
been merged to SLOF, so these patches now just have to make sure to call
the right functions to get the config file loaded and parsed. Once this is
done,
Peter Xu writes:
> On Tue, Jun 05, 2018 at 01:26:34PM +0100, Dr. David Alan Gilbert (git) wrote:
>> From: "Dr. David Alan Gilbert"
>>
>> Allow a bunch of the info commands to be used in preconfig.
>> Could probably add most of them.
>
> I guess some of them may not work yet during preconfig.
We need the latest version of SLOF's libnet for adding pxelinux.cfg
support in the s390-ccw bios, too.
Signed-off-by: Thomas Huth
---
I assume that Alexey will send a SLOF update soon, too, which
supplies the SLOF.bin file for these changes.
roms/SLOF | 2 +-
1 file changed, 1 insertion(+),
On Wed, Jun 06, 2018 at 09:24:48PM +0800, Yongji Xie wrote:
> Some old guests (before commit 7a11370e5: "virtio_blk: enable VQs early")
> kick virtqueue before setting VIRTIO_CONFIG_S_DRIVER_OK. This violates
> the virtio spec. But virtio 1.0 transitional devices support this behaviour.
> So we
On 07.06.2018 14:36, Paolo Bonzini wrote:
> On 07/06/2018 13:36, David Hildenbrand wrote:
>>> The dirty bitmap would be synced in kvm_region_del (so it's not true
>>> that kvm_region_del would disappear, but almost :)).
>> I was rather concerned when doing a KVM_SET_USER_MEMORY_REGIONS while
>>
Hi,
> I prefer the WebSocket route over creating a fake display that will not
> be able to implement complex widgets well.
Makes sense.
> Gerd: What is your preference? Do you want board-specific fake displays
> inside the QEMU process as the long-term direction for UIs?
Well, it isn't the
* Daniel P. Berrangé (berra...@redhat.com) wrote:
> On Thu, Jun 07, 2018 at 01:17:24PM +0200, Andrea Bolognani wrote:
> > On Thu, 2018-06-07 at 11:22 +0100, Daniel P. Berrangé wrote:
> > > On Thu, Jun 07, 2018 at 12:02:29PM +0200, Andrea Bolognani wrote:
> > > > While hints might be considered a
On Fri, Jun 01, 2018 at 01:27:14AM -0700, no-re...@patchew.org wrote:
> /tmp/qemu-test/src/stubs/pmem.c: In function 'pmem_persist':
> /tmp/qemu-test/src/stubs/pmem.c:23:1: error: control reaches end of non-void
> function [-Werror=return-type]
> }
> ^
> cc1: all warnings being treated as
Philippe Mathieu-Daudé writes:
> Use error_report() + exit() instead of error_setg(_fatal),
> as suggested by the "qapi/error.h" documentation:
>
>Please don't error_setg(_fatal, ...), use error_report() and
>exit(), because that's more obvious.
>
> Suggested-by: Eric Blake
>
On Thu, 2018-06-07 at 14:49 +0100, Dr. David Alan Gilbert wrote:
> Including the nvram and efi makes me nervous; but I can see why together
> they might work. However, there's no guarantee that EFI has been tested
> with the QEMU it's used on and ... that could be trouble.
If the QEMU binary
The guest OS may perform writes which are aligned to the logical
sector size instead of the physical one, so logging at this granularity
records the writes performed on the block device most faithfully.
Signed-off-by: Ari Sundholm
---
block/blklogwrites.c | 47
On 06.06.2018 15:14, Samuel Thibault wrote:
> Ping? I'm not sure who I am supposed to get a review from, or if I have
> to have one at all?
>
> Samuel
>
> Samuel Thibault, le jeu. 31 mai 2018 21:48:43 +0200, a ecrit:
>> Signed-off-by: Samuel Thibault
>> ---
>> MAINTAINERS | 1 +
>> 1 file
"Dr. David Alan Gilbert" writes:
> * Markus Armbruster (arm...@redhat.com) wrote:
>> "Dr. David Alan Gilbert" writes:
>>
>> > * Markus Armbruster (arm...@redhat.com) wrote:
>> >> Peter Xu writes:
>> >>
>> >> > On Tue, Jun 05, 2018 at 01:26:34PM +0100, Dr. David Alan Gilbert (git)
>> >> >
Oops, it seems this old patch found its way in this series somehow. My
apologies.
And sorry for this top-post.
Best regards,
Ari Sundholm
a...@tuxera.com
On 06/07/2018 05:40 PM, Ari Sundholm wrote:
The guest OS may perform writes which are aligned to the logical
sector size instead of the
This allows the block driver to use the block configuration of the new
VirtIO block device. One use for this information is to set request
limits using this information.
Signed-off-by: Ari Sundholm
---
hw/block/virtio-blk.c | 1 +
1 file changed, 1 insertion(+)
diff --git
Use assert() instead of error_setg(_abort),
as suggested by the "qapi/error.h" documentation:
Please don't error_setg(_fatal, ...), use error_report() and
exit(), because that's more obvious.
Likewise, don't error_setg(_abort, ...), use assert().
Signed-off-by: Philippe Mathieu-Daudé
This patch series adds a new block driver, blklogwrites, to QEMU. The
driver is given two block devices: a raw device backed by an image or a
host block device, and a log device, typically backed by a file, on
which writes to the raw device are logged.
The logging format used is the same as in
On Thu, Jun 07, 2018 at 10:43:59AM -0400, Yaowei Bai wrote:
> They were introduced by commit bf42508f24ee(job: Introduce
> qapi/job.json) but forgot to ignore them in .gitignore.
>
> Signed-off-by: Yaowei Bai
Good patch, but Eric Blake already sent an identical one that has two r-b's
on it
"Dr. David Alan Gilbert" writes:
> * Markus Armbruster (arm...@redhat.com) wrote:
>> Peter Xu writes:
>>
>> > On Tue, Jun 05, 2018 at 01:26:34PM +0100, Dr. David Alan Gilbert (git)
>> > wrote:
>> >> From: "Dr. David Alan Gilbert"
>> >>
>> >> Allow a bunch of the info commands to be used in
From: Keno Fischer
The 9p-local code previously relied on P9_DOTL_AT_REMOVEDIR and AT_REMOVEDIR
having the same numerical value and deferred any errorchecking to the
syscall itself. However, while the former assumption is true on Linux,
it is not true in general. 9p-handle did this properly
The following changes since commit 5d328d7d2f1fd4fb160bcfb6e4eb838720274438:
Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20180605.0'
into staging (2018-06-07 08:59:28 +0100)
are available in the Git repository at:
https://github.com/gkurz/qemu.git tags/for-upstream
for
* Markus Armbruster (arm...@redhat.com) wrote:
> "Dr. David Alan Gilbert" writes:
>
> > * Markus Armbruster (arm...@redhat.com) wrote:
> >> Peter Xu writes:
> >>
> >> > On Tue, Jun 05, 2018 at 01:26:34PM +0100, Dr. David Alan Gilbert (git)
> >> > wrote:
> >> >> From: "Dr. David Alan Gilbert"
* Andrea Bolognani (abolo...@redhat.com) wrote:
> On Thu, 2018-06-07 at 15:45 +0100, Dr. David Alan Gilbert wrote:
> > * Andrea Bolognani (abolo...@redhat.com) wrote:
> > > On Thu, 2018-06-07 at 14:49 +0100, Dr. David Alan Gilbert wrote:
> > > > Including the nvram and efi makes me nervous; but I
This allows the block driver to use the block configuration of the new
NVMe device. One use for this information is to set request limits
using this information.
Signed-off-by: Ari Sundholm
---
hw/block/nvme.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
The Event Queue Descriptor (EQD) table is an internal table of the
XIVE routing sub-engine, the IVRE. It specifies on which Event Queue
the Event Queue data should be posted when an exception occurs (and
later on pulled by the OS) and which Virtual Processor to notify.
The routing algorithm of
Right now we can crash QEMU using e.g.
qemu-system-x86_64 -m 256M,maxmem=20G,slots=2 \
-object memory-backend-file,id=mem0,size=12288,mem-path=/dev/zero,align=12288 \
-device pc-dimm,id=dimm1,memdev=mem0
qemu-system-x86_64: util/mmap-alloc.c:115:
qemu_ram_mmap: Assertion
PCI LSIs are today allocated one by one using the IRQ alloc_block
routine. Change the code sequence to first allocate a PCI_NUM_PINS
block. It will help us providing a generic IRQ framework to the
machine.
Signed-off-by: Cédric Le Goater
Reviewed-by: Greg Kurz
Signed-off-by: Cédric Le Goater
1 - 100 of 426 matches
Mail list logo
