Re: [Qemu-devel] [PATCH v3 11/13] nvdimm: allow setting the label-size to 0

2018-06-15 Thread Haozhong Zhang
On 06/15/18 16:04, David Hildenbrand wrote: > It is inititally 0, so setting it to 0 should be allowed, too. I'm fine with this change and believe nothing is broken in practice, but what is expected by the user who sets a zero label size? Look at nvdimm_dsm_device() which enables label DSMs only

[Qemu-devel] [Bug 1516446] Re: Migration always causes guest freeze in one direction.

2018-06-15 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1516446 Title: Migration

Re: [Qemu-devel] [PATCH v3 9/9] target/ppc: Add missing opcode for icbt on PPC440

2018-06-15 Thread BALATON Zoltan
On Thu, 14 Jun 2018, David Gibson wrote: On Thu, Jun 14, 2018 at 10:03:41AM +0200, BALATON Zoltan wrote: On Thu, 14 Jun 2018, David Gibson wrote: On Thu, Jun 14, 2018 at 02:17:00AM +0200, BALATON Zoltan wrote: Maybe amend commit message like this: According to PPC440 User Manual On which

[Qemu-devel] [PATCH v3] loader: Check access size when calling rom_ptr() to avoid crashes

2018-06-15 Thread Thomas Huth
The rom_ptr() function allows direct access to the ROM blobs that we load during startup. However, there are currently no checks for the size of the accesses, so it's currently possible to crash QEMU for example with: $ echo "Insane in the mainframe" > /tmp/test.txt $

Re: [Qemu-devel] [PATCH v1 07/11] pc-dimm: get_memory_region() can never fail

2018-06-15 Thread David Hildenbrand
>>> pre_plug isn't part of device, it's a separate part that might vary >>> depending on machine and which might modify device properties along >>> the way and then exaggerating we would need 'prepare2()' and after >>> that 'pre_plug2()' and ... >> >> That's how two parties (device vs hotplug

[Qemu-devel] [PATCH v2 08/12] nvdimm: no need to overwrite get_vmstate_memory_region()

2018-06-15 Thread David Hildenbrand
Our parent class (PC_DIMM) provides exactly the same function. Reviewed-by: David Gibson Reviewed-by: Igor Mammedov Signed-off-by: David Hildenbrand --- hw/mem/nvdimm.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c index 37e19044d6..df9716231f

Re: [Qemu-devel] [PATCH 04/12] migration: introduce migration_update_rates

2018-06-15 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * guangrong.x...@gmail.com (guangrong.x...@gmail.com) wrote: > > From: Xiao Guangrong > > > > It is used to slightly clean the code up, no logic is changed > > Actually, there is a slight change; iterations_prev is always updated > when

[Qemu-devel] [PATCH v2 12/12] pc-dimm: get_memory_region() will not fail after realize

2018-06-15 Thread David Hildenbrand
Let's try to reduce error handling a bit. In the plug/unplug case, the device was realized and therefore we can assume that getting access to the memory region will not fail. For get_vmstate_memory_region() this is already handled that way. Document both cases. Signed-off-by: David Hildenbrand

[Qemu-devel] [PATCH 1/3] spapr: split the IRQ allocation sequence

2018-06-15 Thread Cédric Le Goater
Today, when a device requests for IRQ number in a sPAPR machine, the spapr_irq_alloc() routine first scans the ICSState status array to find an empty slot and then performs the assignement of the selected numbers. Split this sequence in two distinct routines : spapr_irq_find() for lookups and

[Qemu-devel] [PATCH 0/3] introduce a fixed IRQ number space

2018-06-15 Thread Cédric Le Goater
Hello, Here is a proposal for a new IRQ number space layout using static numbers and a bitmap allocator for the MSIs. The previous layout is kept for compatibly in machines raising the 'xics_legacy' flag. These are just the basics preparing ground for the new XIVE controller. I would also like

Re: [Qemu-devel] [PATCH v2 03/12] pc-dimm: rename pc_dimm_memory_* to pc_dimm_*

2018-06-15 Thread Igor Mammedov
On Fri, 15 Jun 2018 13:24:51 +0200 David Hildenbrand wrote: > Let's rename it to make it look more consistent. > > Signed-off-by: David Hildenbrand Reviewed-by: Igor Mammedov > --- > hw/i386/pc.c | 4 ++-- > hw/mem/pc-dimm.c | 6 +++--- > hw/ppc/spapr.c | 6

Re: [Qemu-devel] [virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-15 Thread Michael S. Tsirkin
On Fri, Jun 15, 2018 at 11:32:42AM +0200, Cornelia Huck wrote: > On Fri, 15 Jun 2018 05:34:24 +0300 > "Michael S. Tsirkin" wrote: > > > On Thu, Jun 14, 2018 at 12:02:31PM +0200, Cornelia Huck wrote: > > > > > > I am not all that familiar with how Qemu manages network devices. If > > > > > we

Re: [Qemu-devel] [PATCH v2 02/12] pc: rename pc_dimm_(plug|unplug|...)* into pc_memory_(plug|unplug|...)*

2018-06-15 Thread Igor Mammedov
On Fri, 15 Jun 2018 13:52:25 +0200 David Hildenbrand wrote: > On 15.06.2018 13:51, Igor Mammedov wrote: > > On Fri, 15 Jun 2018 13:24:50 +0200 > > David Hildenbrand wrote: > > > >> Use a similar naming scheme as spapr. This way, we can go ahead and > >> rename e.g. pc_dimm_memory_plug to

Re: [Qemu-devel] [PATCH v2 00/13] iommu: support txattrs, support TCG execution, implement TZ MPC

2018-06-15 Thread Peter Maydell
On 14 June 2018 at 17:51, Peter Maydell wrote: > On 4 June 2018 at 16:29, Peter Maydell wrote: >> Hi; this is v2 of my iommu patchset, which does: >> * support IOMMUs that are aware of memory transaction attributes and >>may generate different translations for different attributes >> *

Re: [Qemu-devel] [PATCH v2 10/12] nvdimm: convert "label-size" into a static property

2018-06-15 Thread Igor Mammedov
On Fri, 15 Jun 2018 13:24:58 +0200 David Hildenbrand wrote: > We don't allow to modify it after realization. So we can simply turn > it into a static property. The value is now validated during realize(). > > Signed-off-by: David Hildenbrand > --- > hw/mem/nvdimm.c | 53

Re: [Qemu-devel] [PATCH v3 3/8] ide: account UNMAP (TRIM) operations

2018-06-15 Thread Alberto Garcia
On Wed 13 Jun 2018 07:44:21 PM CEST, Anton Nefedov wrote: > Signed-off-by: Anton Nefedov Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH v2 05/13] hw/misc/tz-mpc.c: Implement the Arm TrustZone Memory Protection Controller

2018-06-15 Thread Auger Eric
Hi Peter, On 06/15/2018 10:53 AM, Peter Maydell wrote: > On 15 June 2018 at 08:10, Auger Eric wrote: >> after reading 8/13, I have a doubt here about the ret.perm value that >> stays IOMMU_RW independently on the translation success. Usually if the >> translation failn perm is set to IOMMU_NONE.

Re: [Qemu-devel] [PATCH v2 1/2] Partially revert commit d4e5ec877ca

2018-06-15 Thread Matthias Maier
On Fri, Jun 15, 2018, at 04:42 CDT, Daniel P. Berrangé wrote: > On Thu, Jun 14, 2018 at 11:40:41PM -0500, Matthias Maier wrote: >> This commit removes the PYTHON_UTF8 workaround. The problem with setting >> >> LC_ALL= LANG=C LC_CTYPE=en_US.UTF-8 >> >> is that the en_US.UTF-8 locale might

Re: [Qemu-devel] [PATCH v1 10/11] pc-dimm: introduce and use pc_dimm_memory_pre_plug()

2018-06-15 Thread Igor Mammedov
On Fri, 15 Jun 2018 11:48:33 +0200 David Hildenbrand wrote: > On 15.06.2018 11:34, Igor Mammedov wrote: > > On Wed, 13 Jun 2018 16:15:48 +0200 > > David Hildenbrand wrote: > > > >> On 13.06.2018 15:10, Igor Mammedov wrote: > >>> On Mon, 11 Jun 2018 14:16:54 +0200 > >>> David Hildenbrand

Re: [Qemu-devel] [PATCH v2 1/2] Partially revert commit d4e5ec877ca

2018-06-15 Thread Daniel P . Berrangé
On Thu, Jun 14, 2018 at 11:40:41PM -0500, Matthias Maier wrote: > This commit removes the PYTHON_UTF8 workaround. The problem with setting > > LC_ALL= LANG=C LC_CTYPE=en_US.UTF-8 > > is that the en_US.UTF-8 locale might not be available. In this case What platform are you using where UTF8

Re: [Qemu-devel] [PATCH v4 1/1] migration: calculate expected_downtime with ram_bytes_remaining()

2018-06-15 Thread Dr. David Alan Gilbert
* Balamuruhan S (bal...@linux.vnet.ibm.com) wrote: > expected_downtime value is not accurate with dirty_pages_rate * page_size, > using ram_bytes_remaining() would yeild it resonable. > > consider to read the remaining ram just after having updated the dirty > pages count later

[Qemu-devel] valgrind problem in sun4u_load_kernel()

2018-06-15 Thread Thomas Huth
Hi Mark, hi Artyom, while using valgrind to fix some issues with the rom_ptr() function today, I noticed that there is one more problem in sun4u_load_kernel(): The kernel_top variable can be used uninitialized in some cases: If load_elf() fails and the kernel is loaded via load_aout() or

Re: [Qemu-devel] [PATCH v2 00/18] block: Configuration fixes and rbd authentication

2018-06-15 Thread Kevin Wolf
Am 14.06.2018 um 21:14 hat Markus Armbruster geschrieben: > PATCH 01-17 are configuration fixes and cleanup, in particular > -blockdev driver=nfs,... and -drive driver=(nbd|sheepdog|ssh),... with > non-string scalars. > > PATCH 18-19 provide support for configuring rbd authentication. > > I'm

Re: [Qemu-devel] [RFC PATCH v3 0/1] SDCard: support UHS-I

2018-06-15 Thread Peter Maydell
On 6 June 2018 at 16:48, Philippe Mathieu-Daudé wrote: > Hi Peter, > > This is a rewrite of the previous series after running tests and sniffed > traffic on real hardware. > Tagged RFC to be sure this particular patch is going in the correct > direction, before reposting the series with the 'uhs'

[Qemu-devel] [PULL 0/3] Travis updates

2018-06-15 Thread Alex Bennée
The following changes since commit 409c241f887a38bb7a2ac12e34d3a8d73922a9a5: Merge remote-tracking branch 'remotes/kraxel/tags/ui-20180614-pull-request' into staging (2018-06-14 14:04:14 +0100) are available in the Git repository at: https://github.com/stsquad/qemu.git

[Qemu-devel] [PATCH v2 01/12] pc-dimm: remove leftover "struct pc_dimms_capacity"

2018-06-15 Thread David Hildenbrand
Not needed anymore, let's drop it. Reviewed-by: David Gibson Reviewed-by: Igor Mammedov Signed-off-by: David Hildenbrand --- hw/mem/pc-dimm.c | 5 - 1 file changed, 5 deletions(-) diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c index 12da89d562..62b34a992e 100644 --- a/hw/mem/pc-dimm.c

Re: [Qemu-devel] [PATCH 03/12] migration: fix counting xbzrle cache_miss_rate

2018-06-15 Thread Dr. David Alan Gilbert
* guangrong.x...@gmail.com (guangrong.x...@gmail.com) wrote: > From: Xiao Guangrong > > Sync up xbzrle_cache_miss_prev only after migration iteration goes > forward > > Signed-off-by: Xiao Guangrong This patch (not the whole set) queued > --- > migration/ram.c | 2 +- > 1 file changed, 1

[Qemu-devel] [PATCH v2 11/12] nvdimm: make get_memory_region() perform checks and initialization

2018-06-15 Thread David Hildenbrand
We might get a call to get_memory_region() before the device has been realized. We should return a consistent value, as the return value will e.g. later on be used in the pre_plug handler. To avoid duplicating too much code, factor the initialization and checks out into a helper function.

Re: [Qemu-devel] [PATCH v2 02/12] pc: rename pc_dimm_(plug|unplug|...)* into pc_memory_(plug|unplug|...)*

2018-06-15 Thread Igor Mammedov
On Fri, 15 Jun 2018 13:24:50 +0200 David Hildenbrand wrote: > Use a similar naming scheme as spapr. This way, we can go ahead and > rename e.g. pc_dimm_memory_plug to pc_dimm_plug_plug, which avoids ^ typo? > confusion. > > Signed-off-by: David

Re: [Qemu-devel] [PATCH v2 02/12] pc: rename pc_dimm_(plug|unplug|...)* into pc_memory_(plug|unplug|...)*

2018-06-15 Thread David Hildenbrand
On 15.06.2018 13:51, Igor Mammedov wrote: > On Fri, 15 Jun 2018 13:24:50 +0200 > David Hildenbrand wrote: > >> Use a similar naming scheme as spapr. This way, we can go ahead and >> rename e.g. pc_dimm_memory_plug to pc_dimm_plug_plug, which avoids > ^

Re: [Qemu-devel] [PATCH v2 04/12] pc-dimm: remove pc_dimm_get_free_slot() from header

2018-06-15 Thread Igor Mammedov
On Fri, 15 Jun 2018 13:24:52 +0200 David Hildenbrand wrote: > Not used outside of pc-dimm.c and there shouldn't be other users. If > other devices ever have to also sue slots, this has to be factored out. s/sue/use/ or better rephrase the last sentence (it's hard to read) with that fixed

Re: [Qemu-devel] [PATCH v2 08/12] nvdimm: no need to overwrite get_vmstate_memory_region()

2018-06-15 Thread David Hildenbrand
On 15.06.2018 14:46, Igor Mammedov wrote: > On Fri, 15 Jun 2018 13:24:56 +0200 > David Hildenbrand wrote: > >> Our parent class (PC_DIMM) provides exactly the same function. >> >> Reviewed-by: David Gibson >> Reviewed-by: Igor Mammedov >> Signed-off-by: David Hildenbrand >> --- >>

Re: [Qemu-devel] [PATCH v2 12/12] pc-dimm: get_memory_region() will not fail after realize

2018-06-15 Thread Igor Mammedov
On Fri, 15 Jun 2018 13:25:00 +0200 David Hildenbrand wrote: > Let's try to reduce error handling a bit. In the plug/unplug case, the > device was realized and therefore we can assume that getting access to > the memory region will not fail. > > For get_vmstate_memory_region() this is already

Re: [Qemu-devel] [RFC] xen: Don't use memory_region_init_ram_nomigrate() in pci_assign_dev_load_option_rom()

2018-06-15 Thread Peter Maydell
On 5 June 2018 at 17:55, Anthony PERARD wrote: > On Fri, Jun 01, 2018 at 06:59:10PM +0100, Peter Maydell wrote: >> The xen pci_assign_dev_load_option_rom() currently creates a RAM >> memory region with memory_region_init_ram_nomigrate(), and then >> manually registers it with

Re: [Qemu-devel] [PATCH v1 06/11] pc-dimm: don't allow to access "size" before the device was realized

2018-06-15 Thread Igor Mammedov
On Fri, 15 Jun 2018 11:25:59 +0200 David Hildenbrand wrote: > On 15.06.2018 11:16, Igor Mammedov wrote: > > On Thu, 14 Jun 2018 16:10:14 +0200 > > David Hildenbrand wrote: > > > >> On 14.06.2018 15:24, Igor Mammedov wrote: > >>> On Wed, 13 Jun 2018 16:03:35 +0200 > >>> David Hildenbrand

Re: [Qemu-devel] [PATCH 0/2] mips boston/malta: don't have nomigrate RAM regions

2018-06-15 Thread Peter Maydell
On 4 June 2018 at 12:03, Peter Maydell wrote: > This patchset fixes a a bug in the MIPS boston and malta boards: > they currently use memory_region_init_rom_nomigrate() to create > memory regions for their BIOS/flash, and they don't manually > register the MR with vmstate_register_ram() either.

Re: [Qemu-devel] [PATCH 0/2] cputlb: document iotlb.addr, fix txfail physaddr

2018-06-15 Thread Peter Maydell
On 11 June 2018 at 13:56, Peter Maydell wrote: > This patchset is two vaguely related patches that I wrote > while I was trying to understand the cputlb code enough to > add support for small-MPU-regions for v7M/v8M. > > Patch 1 is just a docs comment patch, describing what the > CPUIOTLBEntry

Re: [Qemu-devel] [PULL 00/18] tcg queued patches

2018-06-15 Thread Peter Maydell
On 14 June 2018 at 20:31, Richard Henderson wrote: > The following changes since commit 2ab09bf2f9f55b9fb8d2de6eb2ba2a8570e268e2: > > Merge remote-tracking branch > 'remotes/kraxel/tags/usb-20180612-pull-request' into staging (2018-06-12 > 15:34:34 +0100) > > are available in the Git

Re: [Qemu-devel] [PATCH] target/arm: Allow ARMv6-M Thumb2 instructions

2018-06-15 Thread Julia Suvorova via Qemu-devel
On 15.06.2018 13:55, Peter Maydell wrote: On 12 June 2018 at 21:46, Julia Suvorova wrote: ARMv6-M supports 6 Thumb2 instructions. This patch checks for these instructions and allows their execution. Like Thumb2 cores, ARMv6-M always interprets BL instruction as 32-bit. This patch is required

Re: [Qemu-devel] [PATCH 0/2] Fixups for non-migratable RAMBlocks

2018-06-15 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: > From: "Dr. David Alan Gilbert" > > Hi, > Cédric's b895de50 got merged at about the same > time as some of Peter's changes and there's a rdma > case as well; so tidy up those cases that were looping > over all (rather than just

[Qemu-devel] [PULL 3/3] travis: reduce time taken for trace-backend testing

2018-06-15 Thread Alex Bennée
These builds are reaching regular timeouts and probably don't need to be so widely exercised. ftrace and ust in particular are used in conjunction with whole system profiling which makes most sense with KVM setups, hence the native softmmu target. We also expand simple to cover the multiple log

Re: [Qemu-devel] [PATCH v2 06/12] hostmem: drop error variable from host_memory_backend_get_memory()

2018-06-15 Thread Igor Mammedov
On Fri, 15 Jun 2018 13:24:54 +0200 David Hildenbrand wrote: > Unused, so let's remove it. > > Reviewed-by: David Gibson > Reviewed-by: Igor Mammedov > Signed-off-by: David Hildenbrand breaks compilation with hw/mem/nvdimm.c:171:5: error: too many arguments to function

Re: [Qemu-devel] [PATCH v2 0/4] block: Remove deprecated -drive options

2018-06-15 Thread Kevin Wolf
Am 14.06.2018 um 11:55 hat Kevin Wolf geschrieben: > We deprecated a bunch of -drive options in 2.10, so let's remove them > for 3.0. > > v2: > - Simplified hd-geo-test code after removing test cases [Markus] > - Split patch 3 and 4 so that the deprecation warning code can be easily > restored

Re: [Qemu-devel] [PATCH] hw/isa/smc37c669: Change the parallel I/O base to 378H

2018-06-15 Thread Emilio G. Cota
On Thu, Jun 14, 2018 at 20:39:35 -0300, Philippe Mathieu-Daudé wrote: > As there is no particular reason to use this base address > (introduced in 7bea0dd434e), change to 378H which is the > default on PC machines. Tested-by: Emilio G. Cota Thanks, Emilio

Re: [Qemu-devel] [PATCH v4b 00/18] target/arm: SVE instructions, part 2

2018-06-15 Thread Peter Maydell
On 13 June 2018 at 02:56, Richard Henderson wrote: > Here's the second installment of SVE instructions. > There are about 25 patches waiting for a third installment; > this makes a nice break before beginning with the memory ops. > > Since v3, r-b tags, comment fixes, and other review feedback. >

Re: [Qemu-devel] [PATCH] typedefs: add QJSON

2018-06-15 Thread Dr. David Alan Gilbert
* Greg Kurz (gr...@kaod.org) wrote: > Since commit 83ee768d6247b, we now have two places that define the > QJSON type: > > $ git grep 'typedef struct QJSON QJSON' > include/migration/vmstate.h:typedef struct QJSON QJSON; > migration/qjson.h:typedef struct QJSON QJSON; > > This breaks

[Qemu-devel] [PATCH v2 07/12] pc-dimm: merge get_(vmstate_)memory_region()

2018-06-15 Thread David Hildenbrand
Importantly, get_vmstate_memory_region() should also fail with a proper error if called before the device is realized. For a PCDIMM, both functions are to return the same thing, so share the implementation. All current users are called after the device has been realized, so we can expect the

[Qemu-devel] [PATCH v2 10/12] nvdimm: convert "label-size" into a static property

2018-06-15 Thread David Hildenbrand
We don't allow to modify it after realization. So we can simply turn it into a static property. The value is now validated during realize(). Signed-off-by: David Hildenbrand --- hw/mem/nvdimm.c | 53 - 1 file changed, 8 insertions(+), 45

[Qemu-devel] [PATCH v2 09/12] nvdimm: convert "unarmed" into a static property

2018-06-15 Thread David Hildenbrand
We don't allow to modify it after realization. So we can simply turn it into a static property. Signed-off-by: David Hildenbrand --- hw/mem/nvdimm.c | 32 +++- 1 file changed, 7 insertions(+), 25 deletions(-) diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c index

Re: [Qemu-devel] [PULL 0/4] Net patches

2018-06-15 Thread Peter Maydell
On 15 June 2018 at 04:01, Jason Wang wrote: > The following changes since commit 409c241f887a38bb7a2ac12e34d3a8d73922a9a5: > > Merge remote-tracking branch 'remotes/kraxel/tags/ui-20180614-pull-request' > into staging (2018-06-14 14:04:14 +0100) > > are available in the git repository at: > >

[Qemu-devel] [PATCH 2/3] spapr: remove unused spapr_irq routines

2018-06-15 Thread Cédric Le Goater
spapr_irq_alloc_block and spapr_irq_alloc() are now deprecated. Signed-off-by: Cédric Le Goater --- include/hw/ppc/spapr.h | 4 --- hw/ppc/spapr.c | 80 +- 2 files changed, 1 insertion(+), 83 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 1/2] hw/arm/virt: Silence dtc /intc warnings

2018-06-15 Thread Peter Maydell
On 9 June 2018 at 15:23, Eric Auger wrote: > When running dtc on the guest /proc/device-tree we get the > following warnings: "Warning (unit_address_vs_reg): Node > has a reg or ranges property, but no unit name", with name: > /intc, /intc/its, /intc/v2m. > > Nodes should have a name in the form

Re: [Qemu-devel] [PATCH 0/2] ARM virt: Silence dtc warnings

2018-06-15 Thread Peter Maydell
On 9 June 2018 at 15:23, Eric Auger wrote: > When running dtc on the guest /proc/device-tree, we get the > following warnings: "Warning (unit_address_vs_reg): Node > has a reg or ranges property, but no unit name", with name: > /intc, /intc/its, /intc/v2m, /memory. > > This series removes those

Re: [Qemu-devel] [PATCH] target/ppc, spapr: Move VPA information to machine_data

2018-06-15 Thread David Gibson
On Fri, Jun 15, 2018 at 10:33:36AM +0200, Greg Kurz wrote: > On Fri, 15 Jun 2018 12:16:28 +1000 > David Gibson wrote: > > > CPUPPCState currently contains a number of fields containing the state of > > the VPA. The VPA is a PAPR specific concept covering several guest/host > > shared memory

Re: [Qemu-devel] [PATCH v2] Makefile: Check for more dangling scratch files in out-of-tree builds

2018-06-15 Thread Peter Maydell
On 9 June 2018 at 16:10, Philippe Mathieu-Daudé wrote: > It is easy to catch the generated 'config-host.mak' in the source > tree, however qemu-version.h and qemu-options.def are also generated > files and are hidden by .gitignore rules. > > Improve the out-of-tree safety net rule added in

Re: [Qemu-devel] [PATCH v3 1/8] qapi: group BlockDeviceStats fields

2018-06-15 Thread Alberto Garcia
On Wed 13 Jun 2018 07:44:19 PM CEST, Anton Nefedov wrote: > Make the stat fields definition slightly more readable. > Also reorder total_time_ns stats read-write-flush as done elsewhere. > Cosmetic change only. > > Signed-off-by: Anton Nefedov > --- > qapi/block-core.json | 34

Re: [Qemu-devel] [PATCH v2 11/12] nvdimm: make get_memory_region() perform checks and initialization

2018-06-15 Thread Igor Mammedov
On Fri, 15 Jun 2018 13:24:59 +0200 David Hildenbrand wrote: > We might get a call to get_memory_region() before the device has been > realized. We should return a consistent value, as the return value > will e.g. later on be used in the pre_plug handler. > > To avoid duplicating too much code,

Re: [Qemu-devel] [PATCH v1 00/11] pc-dimm: next bunch of cleanups

2018-06-15 Thread David Hildenbrand
On 13.06.2018 16:11, David Hildenbrand wrote: > On 13.06.2018 15:34, Igor Mammedov wrote: >> On Mon, 11 Jun 2018 14:16:44 +0200 >> David Hildenbrand wrote: >> >>> This is another set of cleanups as the result from >>> [PATCH v4 00/14] MemoryDevice: use multi stage hotplug handlers >>> And is

[Qemu-devel] [PATCHv2] target/ppc, spapr: Move VPA information to machine_data

2018-06-15 Thread David Gibson
CPUPPCState currently contains a number of fields containing the state of the VPA. The VPA is a PAPR specific concept covering several guest/host shared memory areas used to communicate some information with the hypervisor. As a PAPR concept this is really machine specific information, although

Re: [Qemu-devel] [PATCH 3/5] spapr_cpu_core: add missing rollback on realization path

2018-06-15 Thread David Gibson
On Fri, Jun 15, 2018 at 10:01:47AM +0200, Greg Kurz wrote: > On Fri, 15 Jun 2018 09:07:24 +0200 > Greg Kurz wrote: > > > On Fri, 15 Jun 2018 16:29:15 +1000 > > David Gibson wrote: > > > > > On Fri, Jun 15, 2018 at 07:58:05AM +0200, Greg Kurz wrote: > > > > On Fri, 15 Jun 2018 10:14:31 +1000

Re: [Qemu-devel] [PATCH v3 4/6] docs: mention shared state protect for OOB

2018-06-15 Thread Markus Armbruster
Peter Xu writes: > Out-Of-Band handlers need to protect shared state if there is any. > Mention it in the document. > > Suggested-by: Markus Armbruster > Signed-off-by: Peter Xu > --- > docs/devel/qapi-code-gen.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

Re: [Qemu-devel] [PATCH v2 08/12] nvdimm: no need to overwrite get_vmstate_memory_region()

2018-06-15 Thread Igor Mammedov
On Fri, 15 Jun 2018 13:24:56 +0200 David Hildenbrand wrote: > Our parent class (PC_DIMM) provides exactly the same function. > > Reviewed-by: David Gibson > Reviewed-by: Igor Mammedov > Signed-off-by: David Hildenbrand > --- > hw/mem/nvdimm.c | 6 -- > 1 file changed, 6 deletions(-) >

Re: [Qemu-devel] [PATCH v2 09/18] block: Make remaining uses of qobject input visitor more robust

2018-06-15 Thread Markus Armbruster
Kevin Wolf writes: > Am 14.06.2018 um 21:14 hat Markus Armbruster geschrieben: >> Remaining uses of qobject_input_visitor_new_keyval() in the block >> subsystem: >> >> * block_crypto_create_opts_init() > > Still the wrong function name. Will fix this while applying. (Should be >

Re: [Qemu-devel] [PATCH 2/2] hw/arm/virt: Silence dtc /memory warning

2018-06-15 Thread Peter Maydell
On 15 June 2018 at 13:26, Peter Maydell wrote: > On 9 June 2018 at 15:23, Eric Auger wrote: >> When running dtc on the guest /proc/device-tree we get the >> following warning: Warning (unit_address_vs_reg): Node /memory >> has a reg or ranges property, but no unit name". >> >> Let's fix that by

Re: [Qemu-devel] [PATCH v1 10/11] pc-dimm: introduce and use pc_dimm_memory_pre_plug()

2018-06-15 Thread David Hildenbrand
On 15.06.2018 11:34, Igor Mammedov wrote: > On Wed, 13 Jun 2018 16:15:48 +0200 > David Hildenbrand wrote: > >> On 13.06.2018 15:10, Igor Mammedov wrote: >>> On Mon, 11 Jun 2018 14:16:54 +0200 >>> David Hildenbrand wrote: >>> We'll be factoring out some pc-dimm specific and some

Re: [Qemu-devel] [PATCH v3] loader: Check access size when calling rom_ptr() to avoid crashes

2018-06-15 Thread Cornelia Huck
On Fri, 15 Jun 2018 11:49:05 +0200 Thomas Huth wrote: > The rom_ptr() function allows direct access to the ROM blobs that we > load during startup. However, there are currently no checks for the > size of the accesses, so it's currently possible to crash QEMU for > example with: > > $ echo

Re: [Qemu-devel] [PATCH 0/6] More conversions away from old_mmio

2018-06-15 Thread Peter Maydell
On 11 June 2018 at 15:06, Peter Maydell wrote: > On 1 June 2018 at 15:12, Peter Maydell wrote: >> Peter Maydell (6): >> hw/sh/sh7750: Convert away from old_mmio >> hw/m68k/mcf5206: Convert away from old_mmio >> hw/block/pflash_cfi02: Convert away from old_mmio >>

Re: [Qemu-devel] [PATCH 0/3] Add ldn_*_p() and stn_*_p() and use them in exec.c

2018-06-15 Thread Peter Maydell
On 11 June 2018 at 18:10, Peter Maydell wrote: > There's a common pattern in QEMU where a function needs to perform > a data load or store of an N byte integer in a particular endianness. > At the moment this is handled by doing a switch() on the size and > calling the appropriate ld*_p or st*_p

Re: [Qemu-devel] [PATCH v4] aspeed_scu: Implement RNG register

2018-06-15 Thread Peter Maydell
On 13 June 2018 at 12:48, Joel Stanley wrote: > The ASPEED SoCs contain a single register that returns random data when > read. This models that register so that guests can use it. > > The random number data register has a corresponding control register, > however it returns data regardless of

Re: [Qemu-devel] [PATCH v2 09/18] block: Make remaining uses of qobject input visitor more robust

2018-06-15 Thread Kevin Wolf
Am 14.06.2018 um 21:14 hat Markus Armbruster geschrieben: > Remaining uses of qobject_input_visitor_new_keyval() in the block > subsystem: > > * block_crypto_create_opts_init() Still the wrong function name. Will fix this while applying. (Should be block_crypto_open_opts_init()) > Currently

[Qemu-devel] [PATCH v2 05/12] pc: factor out pc specific dimm checks into pc_memory_pre_plug()

2018-06-15 Thread David Hildenbrand
We can perform these checks before the device is actually realized. Reviewed-by: David Gibson Reviewed-by: Igor Mammedov Signed-off-by: David Hildenbrand --- hw/i386/pc.c | 44 ++-- 1 file changed, 26 insertions(+), 18 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] migration/block-dirty-bitmap: fix dirty_bitmap_load

2018-06-15 Thread Dr. David Alan Gilbert
* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > dirty_bitmap_load_header return code is obtained but not handled. Fix > this. > > Bug was introduced in b35ebdf076d697bc > "migration: add postcopy migration of dirty bitmaps" with the whole > function. > > Signed-off-by:

[Qemu-devel] [PATCH v2 00/12] pc-dimm: next bunch of cleanups

2018-06-15 Thread David Hildenbrand
This is another set of cleanups as the result from [PATCH v4 00/14] MemoryDevice: use multi stage hotplug handlers And is based on [PATCH v1 0/2] memory: fix alignment checks/asserts These cleanup are the last step before - 1. moving pc-dimm address and slot assignment into

Re: [Qemu-devel] [virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-15 Thread Cornelia Huck
On Thu, 14 Jun 2018 18:57:11 -0700 Siwei Liu wrote: > Thank you for sharing your thoughts, Cornelia. With questions below, I > think you raised really good points, some of which I don't have answer > yet and would also like to explore here. > > First off, I don't want to push the discussion to

Re: [Qemu-devel] [PATCH] migration: invalidate cache before source start

2018-06-15 Thread Vladimir Sementsov-Ogievskiy
15.06.2018 15:06, Dr. David Alan Gilbert wrote: * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: Invalidate cache before source start in case of failed migration. Signed-off-by: Vladimir Sementsov-Ogievskiy Why doesn't the code at the bottom of migration_completion,

Re: [Qemu-devel] [PATCH v3 1/6] chardev: comment details for CLOSED event

2018-06-15 Thread Markus Armbruster
Peter Xu writes: > It was unclear before on what does the CLOSED event mean. Meanwhile we > add a TODO to fix up the CLOSED event in the future when the in/out > ports are different for a chardev. > > CC: Paolo Bonzini > CC: "Marc-André Lureau" > CC: Stefan Hajnoczi > CC: Markus Armbruster

Re: [Qemu-devel] [RFC v1 1/1] virtio-crypto: Allow disabling of cipher algorithms for virtio-crypto device

2018-06-15 Thread Christian Borntraeger
On 06/13/2018 05:05 PM, Daniel P. Berrangé wrote: > On Wed, Jun 13, 2018 at 11:01:05AM -0400, Farhan Ali wrote: >> Hi Daniel >> >> On 06/13/2018 05:37 AM, Daniel P. Berrangé wrote: >>> On Tue, Jun 12, 2018 at 03:48:34PM -0400, Farhan Ali wrote: The virtio-crypto driver currently propagates

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/3] spapr: split the IRQ allocation sequence

2018-06-15 Thread Greg Kurz
On Fri, 15 Jun 2018 13:53:01 +0200 Cédric Le Goater wrote: > Today, when a device requests for IRQ number in a sPAPR machine, the > spapr_irq_alloc() routine first scans the ICSState status array to > find an empty slot and then performs the assignement of the selected > numbers. Split this

Re: [Qemu-devel] [RFC v1 1/1] virtio-crypto: Allow disabling of cipher algorithms for virtio-crypto device

2018-06-15 Thread Viktor VM Mihajlovski
On 14.06.2018 18:12, Farhan Ali wrote: > > > On 06/14/2018 11:10 AM, Daniel P. Berrangé wrote: >> On Thu, Jun 14, 2018 at 10:50:40AM -0400, Farhan Ali wrote: >>> >>> >>> On 06/14/2018 04:21 AM, Daniel P. Berrangé wrote: On Wed, Jun 13, 2018 at 07:28:08PM +0200, Halil Pasic wrote: >

Re: [Qemu-devel] [PATCH v4] dump: add Windows dump format to dump-guest-memory

2018-06-15 Thread Viktor Prutyanov
On Mon, 11 Jun 2018 16:31:42 +0200 Markus Armbruster wrote: > Looks stuck. Paolo, would you be willing to take this through your > tree? > > Viktor Prutyanov writes: > > > This patch adds Windows crashdumping feature. Now QEMU can produce > > ELF-dump containing Windows crashdump header,

Re: [Qemu-devel] [PATCH v1 07/11] pc-dimm: get_memory_region() can never fail

2018-06-15 Thread Igor Mammedov
On Thu, 14 Jun 2018 17:11:38 +0200 David Hildenbrand wrote: > On 14.06.2018 17:00, Igor Mammedov wrote: > > On Wed, 13 Jun 2018 16:50:54 +0200 > > David Hildenbrand wrote: > > > >> On 13.06.2018 16:07, David Hildenbrand wrote: > >>> On 13.06.2018 15:03, Igor Mammedov wrote: > On

Re: [Qemu-devel] [PATCH] m25p80: add support for two bytes WRSR for Macronix chips

2018-06-15 Thread Peter Maydell
On 11 June 2018 at 23:03, Alistair Francis wrote: > On Mon, Jun 11, 2018 at 10:18 AM, Cédric Le Goater wrote: >> On 06/11/2018 07:15 PM, Cédric Le Goater wrote: >>> On Macronix chips, two bytes can written to the WRSR. First byte will >>> configure the status register and the second the

Re: [Qemu-devel] [PATCH] target/arm: Allow ARMv6-M Thumb2 instructions

2018-06-15 Thread Peter Maydell
On 12 June 2018 at 21:46, Julia Suvorova wrote: > ARMv6-M supports 6 Thumb2 instructions. This patch checks for these > instructions and allows their execution. > Like Thumb2 cores, ARMv6-M always interprets BL instruction as 32-bit. > > This patch is required for future Cortex-M0 support. > >

[Qemu-devel] [PULL 2/3] travis: reduce coverage of gprof build

2018-06-15 Thread Alex Bennée
This build is regularly timing out and even switching off linux-user wasn't enough. Instead explicitly choose a target list of broadly the "major" architectures. This is enough to check the gprof build machinery works without worrying about the actual coverage results. I did try various YAML

[Qemu-devel] [PULL 1/3] travis: display config.log when configure fails

2018-06-15 Thread Alex Bennée
From: Daniel P. Berrangé When configure fails in CI systems we must be able to see the contents of the config.log file to diagnose the root cause. Signed-off-by: Daniel P. Berrangé Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Fam Zheng [AJB: used Eric's suggested

[Qemu-devel] [PATCH v2 03/12] pc-dimm: rename pc_dimm_memory_* to pc_dimm_*

2018-06-15 Thread David Hildenbrand
Let's rename it to make it look more consistent. Signed-off-by: David Hildenbrand --- hw/i386/pc.c | 4 ++-- hw/mem/pc-dimm.c | 6 +++--- hw/ppc/spapr.c | 6 +++--- include/hw/mem/pc-dimm.h | 6 +++--- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git

[Qemu-devel] [PATCH v2 06/12] hostmem: drop error variable from host_memory_backend_get_memory()

2018-06-15 Thread David Hildenbrand
Unused, so let's remove it. Reviewed-by: David Gibson Reviewed-by: Igor Mammedov Signed-off-by: David Hildenbrand --- backends/hostmem.c | 3 +-- hw/mem/nvdimm.c | 4 ++-- hw/mem/pc-dimm.c | 4 ++-- hw/misc/ivshmem.c| 3 +-- include/sysemu/hostmem.h | 3 +--

[Qemu-devel] [PATCH v2 02/12] pc: rename pc_dimm_(plug|unplug|...)* into pc_memory_(plug|unplug|...)*

2018-06-15 Thread David Hildenbrand
Use a similar naming scheme as spapr. This way, we can go ahead and rename e.g. pc_dimm_memory_plug to pc_dimm_plug_plug, which avoids confusion. Signed-off-by: David Hildenbrand --- hw/i386/pc.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/i386/pc.c

[Qemu-devel] [PATCH v2 04/12] pc-dimm: remove pc_dimm_get_free_slot() from header

2018-06-15 Thread David Hildenbrand
Not used outside of pc-dimm.c and there shouldn't be other users. If other devices ever have to also sue slots, this has to be factored out. Signed-off-by: David Hildenbrand --- hw/mem/pc-dimm.c | 4 +++- include/hw/mem/pc-dimm.h | 2 -- 2 files changed, 3 insertions(+), 3 deletions(-)

[Qemu-devel] [PATCH 3/3] spapr: introduce a fixed IRQ number space

2018-06-15 Thread Cédric Le Goater
This proposal introduces a new IRQ number space layout using static numbers for all devices and a bitmap allocator for the MSI numbers which are negotiated by the guest at runtime. The previous layout is kept in machines raising the 'xics_legacy' flag. Signed-off-by: Cédric Le Goater ---

Re: [Qemu-devel] [PATCH] migration: invalidate cache before source start

2018-06-15 Thread Dr. David Alan Gilbert
* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > Invalidate cache before source start in case of failed migration. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Why doesn't the code at the bottom of migration_completion, fail_invalidate: and the code in migrate_fd_cancel

Re: [Qemu-devel] [PATCH 2/2] hw/arm/virt: Silence dtc /memory warning

2018-06-15 Thread Peter Maydell
On 9 June 2018 at 15:23, Eric Auger wrote: > When running dtc on the guest /proc/device-tree we get the > following warning: Warning (unit_address_vs_reg): Node /memory > has a reg or ranges property, but no unit name". > > Let's fix that by adding the unit address to the node name. We also >

Re: [Qemu-devel] [PATCH 2/2] hw/arm/virt: Add virt-3.0 machine type

2018-06-15 Thread Peter Maydell
On 30 May 2018 at 15:26, Eric Auger wrote: > Add virt-3.0 machine type. > > This machine type supports highmem 256MB ECAM by default. > This feature is disabled for earlier machine types and > if highmem is off. > > The high 256MB ECAM region is chosen instead of the legacy > 16MB one if the

Re: [Qemu-devel] [PATCH v2 07/12] pc-dimm: merge get_(vmstate_)memory_region()

2018-06-15 Thread Igor Mammedov
On Fri, 15 Jun 2018 13:24:55 +0200 David Hildenbrand wrote: > Importantly, get_vmstate_memory_region() should also fail with a proper > error if called before the device is realized. For a PCDIMM, both functions > are to return the same thing, so share the implementation. > > All current users

Re: [Qemu-devel] [PATCH v2 06/12] hostmem: drop error variable from host_memory_backend_get_memory()

2018-06-15 Thread David Hildenbrand
On 15.06.2018 14:39, Igor Mammedov wrote: > On Fri, 15 Jun 2018 13:24:54 +0200 > David Hildenbrand wrote: > >> Unused, so let's remove it. >> >> Reviewed-by: David Gibson >> Reviewed-by: Igor Mammedov >> Signed-off-by: David Hildenbrand > breaks compilation with > > hw/mem/nvdimm.c:171:5:

Re: [Qemu-devel] [PATCH v2] CODING_STYLE: Define our preferred form for multiline comments

2018-06-15 Thread Markus Armbruster
Peter Maydell writes: > On 13 June 2018 at 17:55, John Snow wrote: [...] >> It would only begin to matter terribly much if we actually decided we >> wanted to do a doxygen-style doc generation for our internal APIs for >> compatibility with, say, fancier IDEs than vim/emacs. > > We ought to do

Re: [Qemu-devel] [PATCH 3/5] spapr_cpu_core: add missing rollback on realization path

2018-06-15 Thread Greg Kurz
On Fri, 15 Jun 2018 22:32:44 +1000 David Gibson wrote: > On Fri, Jun 15, 2018 at 10:01:47AM +0200, Greg Kurz wrote: > > On Fri, 15 Jun 2018 09:07:24 +0200 > > Greg Kurz wrote: > > > > > On Fri, 15 Jun 2018 16:29:15 +1000 > > > David Gibson wrote: > > > > > > > On Fri, Jun 15, 2018 at

Re: [Qemu-devel] [PATCH v2 06/13] hw/misc/tz-mpc.c: Implement registers

2018-06-15 Thread Auger Eric
Hi Peter, On 06/15/2018 11:04 AM, Peter Maydell wrote: > On 14 June 2018 at 21:36, Auger Eric wrote: >> Hi Peter, >> >> On 06/04/2018 05:29 PM, Peter Maydell wrote: >>> Implement the missing registers for the TZ MPC. >>> >>> Signed-off-by: Peter Maydell > >>> +case A_INT_CLEAR: >>> +

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/3] spapr: remove unused spapr_irq routines

2018-06-15 Thread Greg Kurz
On Fri, 15 Jun 2018 13:53:02 +0200 Cédric Le Goater wrote: > spapr_irq_alloc_block and spapr_irq_alloc() are now deprecated. > > Signed-off-by: Cédric Le Goater > --- Reviewed-by: Greg Kurz > include/hw/ppc/spapr.h | 4 --- > hw/ppc/spapr.c | 80 >

[Qemu-devel] [PATCH v3 05/13] pc: factor out pc specific dimm checks into pc_memory_pre_plug()

2018-06-15 Thread David Hildenbrand
We can perform these checks before the device is actually realized. Reviewed-by: David Gibson Reviewed-by: Igor Mammedov Signed-off-by: David Hildenbrand --- hw/i386/pc.c | 44 ++-- 1 file changed, 26 insertions(+), 18 deletions(-) diff --git

  1   2   3   4   5   >