Re: [PATCH v1 0/9] gdbstub/next

2020-05-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200430190122.4592-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200430190122.4592-1-alex.ben...@linaro.org Subject: [PATCH v1 0/9] gdbstub/next Type: series

[Bug 1749393] Re: sbrk() not working under qemu-user with a PIE-compiled binary?

2020-05-01 Thread Christian Ehrhardt 
Will be merged in 20.10 with qemu >=5.0 where this came upstream. ** Tags added: qemu-20.10 ** Changed in: qemu (Ubuntu) Status: Confirmed => Triaged -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PATCH 1/1] vfio/nvlink: Remove exec permission to avoid SELinux AVCs

2020-05-01 Thread Alexey Kardashevskiy
On 01/05/2020 15:54, Leonardo Bras wrote: > If SELinux is setup without 'execmem' permission for qemu, all mmap > with (PROT_WRITE | PROT_EXEC) will fail and print a warning in > SELinux log. > > If "nvlink2-mr" memory allocation fails (fist diff), it will cause > guest NUMA nodes to not be

Re: [PATCH v4 00/18] target/arm: sve load/store improvements

2020-05-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200430162813.17671-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200430162813.17671-1-richard.hender...@linaro.org Subject: [PATCH v4 00/18] target/arm:

Re: [PULL 0/4] Block patches

2020-05-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200501082806.205696-1-stefa...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [PULL 0/4] Block patches

2020-05-01 Thread Peter Maydell
On Fri, 1 May 2020 at 09:28, Stefan Hajnoczi wrote: > > The following changes since commit 27c94566379069fb8930bb1433dcffbf7df3203d: > > Merge remote-tracking branch > 'remotes/edgar/tags/edgar/xilinx-next-2020-04-30.for-upstream' into staging > (2020-04-30 16:47:23 +0100) > > are available

Re: [PATCH] hostmem: don't use mbind() if host-nodes is epmty

2020-05-01 Thread Manuel Hohmann
Thanks! I applied the patch, and now it works also inside the docker container, for all architectures (i386, x86_64, arm, aarch64) for which I have test cases at hand. Indeed, since the container is configured by a public cloud service, there is no possibility to change any security settings.

[RESEND PATCH 1/1] vfio/nvlink: Remove exec permission to avoid SELinux AVCs

2020-05-01 Thread Leonardo Bras
If SELinux is setup without 'execmem' permission for qemu, all mmap with (PROT_WRITE | PROT_EXEC) will fail and print a warning in SELinux log. If "nvlink2-mr" memory allocation fails (fist diff), it will cause guest NUMA nodes to not be correctly configured (V100 memory will not be visible for

[PULL for-5.0 0/4] Block patches

2020-05-01 Thread Stefan Hajnoczi
The following changes since commit 27c94566379069fb8930bb1433dcffbf7df3203d: Merge remote-tracking branch 'remotes/edgar/tags/edgar/xilinx-next-2020-04-30.for-upstream' into staging (2020-04-30 16:47:23 +0100) are available in the Git repository at: https://github.com/stefanha/qemu.git

[PULL for-5.0 1/4] fuzz: select fuzz target using executable name

2020-05-01 Thread Stefan Hajnoczi
From: Alexander Bulekov The fuzzers are built into a binary (e.g. qemu-fuzz-i386). To select the device to fuzz/fuzz target, we usually use the --fuzz-target= argument. This commit allows the fuzz-target to be specified using the name of the executable. If the executable name ends with

Re: [PATCH] hostmem: don't use mbind() if host-nodes is epmty

2020-05-01 Thread Daniel P . Berrangé
On Thu, Apr 30, 2020 at 11:46:06AM -0400, Igor Mammedov wrote: > Since 5.0 QEMU uses hostmem backend for allocating main guest RAM. > The backend however calls mbind() which is typically NOP > in case of default policy/absent host-nodes bitmap. > However when runing in container with black-listed

[PULL 2/4] lockable: fix __COUNTER__ macro to be referenced properly

2020-05-01 Thread Stefan Hajnoczi
From: Daniel Brodsky - __COUNTER__ doesn't work with ## concat - replaced ## with glue() macro so __COUNTER__ is evaluated Fixes: 3284c3ddc4 Signed-off-by: Daniel Brodsky Message-id: 20200404042108.389635-2-dnbrd...@gmail.com Signed-off-by: Stefan Hajnoczi --- include/qemu/lockable.h | 7

[PULL 4/4] lockable: Replace locks with lock guard macros

2020-05-01 Thread Stefan Hajnoczi
From: Simran Singhal Replace manual lock()/unlock() calls with lock guard macros (QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD). Signed-off-by: Simran Singhal Reviewed-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum Tested-by: Yuval Shaia Message-id: 20200402065035.GA15477@simran-Inspiron-5558

Re: [PATCH 08/17] s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes,eaes}-256

2020-05-01 Thread David Hildenbrand
On 30.04.20 20:22, Markus Armbruster wrote: > David Hildenbrand writes: > >> On 28.04.20 18:34, Markus Armbruster wrote: >>> Both s390_features[S390_FEAT_PCC_CMAC_AES_256].name and >>> s390_features[S390_FEAT_PCC_CMAC_EAES_256].name is >>> "pcc-cmac-eaes-256". The former is obviously a pasto.

[PATCH v1 4/4] .travis.yml: reduce the load on [ppc64] GCC check-tcg

2020-05-01 Thread Alex Bennée
This seems to be timing out quite often and occasionally running out of disk space. Relegate it to light duties. Signed-off-by: Alex Bennée --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 49267b73b3..fe708792ca 100644 ---

[PATCH v1 2/4] .travis.yml: drop MacOSX

2020-05-01 Thread Alex Bennée
This keeps breaking on Travis so lets just fall back to the Cirrus CI builds which seem to be better maintained. Fix up the comments while we are doing this as we never had a windows build. Signed-off-by: Alex Bennée --- .travis.yml | 28 +--- 1 file changed, 1

[PATCH v1 1/4] .travis.yml: show free disk space at end of run

2020-05-01 Thread Alex Bennée
Signed-off-by: Alex Bennée --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index 2fd63eceaa..a4c3c6c805 100644 --- a/.travis.yml +++ b/.travis.yml @@ -113,6 +113,7 @@ script: $(exit $BUILD_RC); fi after_script: + - df -h - if

Re: [PATCH 00/36] target/arm: Convert Neon to decodetree (part 1)

2020-05-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200430181003.21682-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200430181003.21682-1-peter.mayd...@linaro.org Subject: [PATCH 00/36] target/arm: Convert Neon

[PULL 3/4] lockable: replaced locks with lock guard macros where appropriate

2020-05-01 Thread Stefan Hajnoczi
From: Daniel Brodsky - ran regexp "qemu_mutex_lock\(.*\).*\n.*if" to find targets - replaced result with QEMU_LOCK_GUARD if all unlocks at function end - replaced result with WITH_QEMU_LOCK_GUARD if unlock not at end Signed-off-by: Daniel Brodsky Reviewed-by: Juan Quintela Message-id:

[PULL 1/4] fuzz: select fuzz target using executable name

2020-05-01 Thread Stefan Hajnoczi
From: Alexander Bulekov The fuzzers are built into a binary (e.g. qemu-fuzz-i386). To select the device to fuzz/fuzz target, we usually use the --fuzz-target= argument. This commit allows the fuzz-target to be specified using the name of the executable. If the executable name ends with

[PULL 0/4] Block patches

2020-05-01 Thread Stefan Hajnoczi
The following changes since commit 27c94566379069fb8930bb1433dcffbf7df3203d: Merge remote-tracking branch 'remotes/edgar/tags/edgar/xilinx-next-2020-04-30.for-upstream' into staging (2020-04-30 16:47:23 +0100) are available in the Git repository at: https://github.com/stefanha/qemu.git

Re: [PATCH 0/2] virt: Set tpm-tis-device ppi property to off by default

2020-05-01 Thread Peter Maydell
On Mon, 27 Apr 2020 at 15:32, Eric Auger wrote: > > Instead of using a compat in the mach-virt machine to force > PPI off for all virt machines (PPI not supported by the > tpm-tis-device device), let's simply change the default value > in the sysbus device. > > Best Regards > > Eric > > Eric

Re: [PULL 00/15] Block layer patches

2020-05-01 Thread Peter Maydell
On Thu, 30 Apr 2020 at 16:52, Kevin Wolf wrote: > > The following changes since commit 16aaacb307ed607b9780c12702c44f0fe52edc7e: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20200430' into > staging (2020-04-30 14:00:36 +0100) > > are available in the Git repository at: > >

[PATCH v1 3/4] .cirrus.yml: bump FreeBSD to the current stable release

2020-05-01 Thread Alex Bennée
Hopefully this will un-stick the test which has been broken for a long time. Signed-off-by: Alex Bennée --- .cirrus.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index 90645fede6..f06f5af2b9 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -3,7

[PATCH v1 0/4] testing/next updates

2020-05-01 Thread Alex Bennée
Hi, The following updates bring us to green across the board again. MacOSX has been getting continually flakey on Travis but we still have coverage on Cirrus. Please review. Alex Bennée (4): .travis.yml: show free disk space at end of run .travis.yml: drop MacOSX .cirrus.yml: bump FreeBSD

Re: [PATCH v1 0/4] testing/next updates

2020-05-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/2020050505.4225-1-alex.ben...@linaro.org/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

[PATCH] riscv: Change the default behavior if no -bios option is specified

2020-05-01 Thread Bin Meng
From: Bin Meng Per QEMU deprecated doc, QEMU 4.1 introduced support for the -bios option in QEMU for RISC-V for the virt machine and sifive_u machine. The default behavior has been that QEMU does not automatically load any firmware if no -bios option is included. Now 2 releases passed, it's

Re: [PATCH v1 2/4] .travis.yml: drop MacOSX

2020-05-01 Thread Philippe Mathieu-Daudé
On 5/1/20 1:15 PM, Alex Bennée wrote: This keeps breaking on Travis so lets just fall back to the Cirrus CI builds which seem to be better maintained. Fix up the comments while we are doing this as we never had a windows build. Signed-off-by: Alex Bennée --- .travis.yml | 28

Re: [PATCH] riscv/spike: Change the default bios to use plain binary image

2020-05-01 Thread Anup Patel
On Fri, May 1, 2020 at 6:01 PM Bin Meng wrote: > > From: Bin Meng > > To keep sync with other RISC-V machines, change the default bios > to use .bin instead of the .elf images. > > Signed-off-by: Bin Meng > --- > > hw/riscv/spike.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

Re: [PATCH v1 4/4] .travis.yml: reduce the load on [ppc64] GCC check-tcg

2020-05-01 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 5/1/20 1:15 PM, Alex Bennée wrote: >> This seems to be timing out quite often and occasionally running out >> of disk space. Relegate it to light duties. >> Signed-off-by: Alex Bennée >> --- >> .travis.yml | 2 +- >> 1 file changed, 1 insertion(+), 1

Re: [PATCH v1 0/4] testing/next updates

2020-05-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/2020050505.4225-1-alex.ben...@linaro.org/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash

Re: [PATCH] target/m68k: Allow movec only on 68010+

2020-05-01 Thread BALATON Zoltan
Ping? On Tue, 14 Jan 2020, BALATON Zoltan wrote: The movec opcode does not exist on 68000 and should raise an exception. Fix the feature mask to only allow movec on newer 68k CPUs. Signed-off-by: BALATON Zoltan --- target/m68k/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: About hardfloat in ppc

2020-05-01 Thread BALATON Zoltan
On Fri, 1 May 2020, Alex Bennée wrote: 罗勇刚(Yonggang Luo) writes: On Fri, May 1, 2020 at 7:58 PM BALATON Zoltan wrote: On Fri, 1 May 2020, 罗勇刚(Yonggang Luo) wrote: That's what I suggested, We preserve a float computing cache typedef struct FpRecord { uint8_t op; float32 A; float32 B; }

[PATCH] aspeed: Add support for the sonorapass-bmc board

2020-05-01 Thread Patrick Williams
Sonora Pass is a 2 socket x86 motherboard designed by Facebook and supported by OpenBMC. Strapping configuration was obtained from hardware and i2c configuration is based on dts found at:

Re: [PATCH v6 3/5] 9pfs: add new function v9fs_co_readdir_many()

2020-05-01 Thread Christian Schoenebeck
On Donnerstag, 30. April 2020 15:30:49 CEST Greg Kurz wrote: > > > I agree that a client that issues concurrent readdir requests on the > > > same fid is probably asking for troubles, but this permitted by the > > > spec. Whether we should detect such conditions and warn or even fail > > > is

Re: [PATCH v1 2/4] .travis.yml: drop MacOSX

2020-05-01 Thread Daniel P . Berrangé
On Fri, May 01, 2020 at 12:15:03PM +0100, Alex Bennée wrote: > This keeps breaking on Travis so lets just fall back to the Cirrus CI > builds which seem to be better maintained. Fix up the comments while > we are doing this as we never had a windows build. FYI the current problem with macOS

Re: [PATCH v1 0/4] testing/next updates

2020-05-01 Thread Daniel P . Berrangé
On Fri, May 01, 2020 at 12:15:01PM +0100, Alex Bennée wrote: > Hi, > > The following updates bring us to green across the board again. MacOSX > has been getting continually flakey on Travis but we still have > coverage on Cirrus. Please review. Does anyone ever look at the cirrus jobs ? They

Re: [PATCH v1 0/4] testing/next updates

2020-05-01 Thread Alex Bennée
Daniel P. Berrangé writes: > On Fri, May 01, 2020 at 12:15:01PM +0100, Alex Bennée wrote: >> Hi, >> >> The following updates bring us to green across the board again. MacOSX >> has been getting continually flakey on Travis but we still have >> coverage on Cirrus. Please review. > > Does

Re: [PATCH v1 5/9] gdbstub: eliminate gdbserver_fd global

2020-05-01 Thread Philippe Mathieu-Daudé
On 4/30/20 9:01 PM, Alex Bennée wrote: We don't really need to track this fd beyond the initial creation of the socket. We already know if the system has been initialised by virtue of the gdbserver_state so lets remove it. This makes the later re-factoring easier. Signed-off-by: Alex Bennée

[PATCH v2] fuzz: select fuzz target using executable name

2020-05-01 Thread Alexander Bulekov
The fuzzers are built into a binary (e.g. qemu-fuzz-i386). To select the device to fuzz/fuzz target, we usually use the --fuzz-target= argument. This commit allows the fuzz-target to be specified using the name of the executable. If the executable name ends with -target-FUZZ_TARGET, then we select

Re: About hardfloat in ppc

2020-05-01 Thread Yonggang Luo
On Fri, May 1, 2020 at 7:58 PM BALATON Zoltan wrote: > On Fri, 1 May 2020, 罗勇刚(Yonggang Luo) wrote: > > That's what I suggested, > > We preserve a float computing cache > > typedef struct FpRecord { > > uint8_t op; > > float32 A; > > float32 B; > > } FpRecord; > > FpRecord fp_cache[1024]; >

Re: [PATCH v1 4/4] .travis.yml: reduce the load on [ppc64] GCC check-tcg

2020-05-01 Thread Philippe Mathieu-Daudé
On 5/1/20 1:15 PM, Alex Bennée wrote: This seems to be timing out quite often and occasionally running out of disk space. Relegate it to light duties. Signed-off-by: Alex Bennée --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml

Re: [PATCH] riscv/spike: Change the default bios to use plain binary image

2020-05-01 Thread Bin Meng
On Fri, May 1, 2020 at 8:41 PM Anup Patel wrote: > > On Fri, May 1, 2020 at 6:01 PM Bin Meng wrote: > > > > From: Bin Meng > > > > To keep sync with other RISC-V machines, change the default bios > > to use .bin instead of the .elf images. > > > > Signed-off-by: Bin Meng > > --- > > > >

RE: [PATCH] riscv/spike: Change the default bios to use plain binary image

2020-05-01 Thread Anup Patel
> -Original Message- > From: Qemu-riscv bounces+anup.patel=wdc@nongnu.org> On Behalf Of Bin Meng > Sent: 01 May 2020 18:15 > To: Anup Patel > Cc: Bin Meng ; open list:RISC-V ri...@nongnu.org>; Sagar Karandikar ; Bastian > Koppelmann ; Palmer Dabbelt > ; QEMU Developers

Re: [PATCH v1 1/9] configure: favour gdb-multiarch if we have it

2020-05-01 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 4/30/20 9:01 PM, Alex Bennée wrote: >> As gdb will generally be talking to "foreign" guests lets use that if >> we can. Otherwise the chances of gdb barfing are considerably higher. >> Signed-off-by: Alex Bennée >> --- >> configure | 2 +- >> 1 file

[PATCH 1/1] vfio/nvlink: Remove exec permission to avoid SELinux AVCs

2020-05-01 Thread Leonardo Bras
If SELinux is setup without 'execmem' permission for qemu, all mmap with (PROT_WRITE | PROT_EXEC) will fail and print a warning in SELinux log. If "nvlink2-mr" memory allocation fails (fist diff), it will cause guest NUMA nodes to not be correctly configured (V100 memory will not be visible for

Re: About hardfloat in ppc

2020-05-01 Thread Alex Bennée
BALATON Zoltan writes: > On Fri, 1 May 2020, Alex Bennée wrote: >> 罗勇刚(Yonggang Luo) writes: >>> On Fri, May 1, 2020 at 7:58 PM BALATON Zoltan wrote: On Fri, 1 May 2020, 罗勇刚(Yonggang Luo) wrote: > That's what I suggested, > We preserve a float computing cache > typedef

Re: [PATCH] target/m68k: Allow movec only on 68010+

2020-05-01 Thread Laurent Vivier
Le 01/05/2020 à 15:11, BALATON Zoltan a écrit : > Ping? I sent a comment: https://lists.gnu.org/archive/html/qemu-devel/2020-01/msg02840.html Thanks, Laurent > > On Tue, 14 Jan 2020, BALATON Zoltan wrote: >> The movec opcode does not exist on 68000 and should raise an >> exception. Fix the

[PATCH v2 1/2] virtiofsd: add --rlimit-nofile=NUM option

2020-05-01 Thread Stefan Hajnoczi
Make it possible to specify the RLIMIT_NOFILE on the command-line. Users running multiple virtiofsd processes should allocate a certain number to each process so that the system-wide limit can never be exhausted. When this option is set to 0 the rlimit is left at its current value. This is useful

[PATCH v2 2/2] virtiofsd: stay below fs.file-max sysctl value (CVE-2020-10717)

2020-05-01 Thread Stefan Hajnoczi
The system-wide fs.file-max sysctl value determines how many files can be open. It defaults to a value calculated based on the machine's RAM size. Previously virtiofsd would try to set RLIMIT_NOFILE to 1,000,000 and this allowed the FUSE client to exhaust the number of open files system-wide on

Re: About hardfloat in ppc

2020-05-01 Thread BALATON Zoltan
On Fri, 1 May 2020, 罗勇刚(Yonggang Luo) wrote: That's what I suggested, We preserve a float computing cache typedef struct FpRecord { uint8_t op; float32 A; float32 B; } FpRecord; FpRecord fp_cache[1024]; int fp_cache_length; uint32_t fp_exceptions; 1. For each new fp operation we push it to

Re: [PATCH v1 1/4] .travis.yml: show free disk space at end of run

2020-05-01 Thread Philippe Mathieu-Daudé
On 5/1/20 1:15 PM, Alex Bennée wrote: Signed-off-by: Alex Bennée --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index 2fd63eceaa..a4c3c6c805 100644 --- a/.travis.yml +++ b/.travis.yml @@ -113,6 +113,7 @@ script: $(exit $BUILD_RC);

Re: [PATCH v1 0/4] testing/next updates

2020-05-01 Thread Philippe Mathieu-Daudé
On 5/1/20 1:23 PM, Daniel P. Berrangé wrote: On Fri, May 01, 2020 at 12:15:01PM +0100, Alex Bennée wrote: Hi, The following updates bring us to green across the board again. MacOSX has been getting continually flakey on Travis but we still have coverage on Cirrus. Please review. Does anyone

[PATCH] riscv/spike: Change the default bios to use plain binary image

2020-05-01 Thread Bin Meng
From: Bin Meng To keep sync with other RISC-V machines, change the default bios to use .bin instead of the .elf images. Signed-off-by: Bin Meng --- hw/riscv/spike.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/riscv/spike.c b/hw/riscv/spike.c index

Re: [PATCH v1 1/9] configure: favour gdb-multiarch if we have it

2020-05-01 Thread Philippe Mathieu-Daudé
On 4/30/20 9:01 PM, Alex Bennée wrote: As gdb will generally be talking to "foreign" guests lets use that if we can. Otherwise the chances of gdb barfing are considerably higher. Signed-off-by: Alex Bennée --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: About hardfloat in ppc

2020-05-01 Thread Alex Bennée
罗勇刚(Yonggang Luo) writes: > On Fri, May 1, 2020 at 7:58 PM BALATON Zoltan wrote: > >> On Fri, 1 May 2020, 罗勇刚(Yonggang Luo) wrote: >> > That's what I suggested, >> > We preserve a float computing cache >> > typedef struct FpRecord { >> > uint8_t op; >> > float32 A; >> > float32 B; >> > }

[PATCH] qcow2: Avoid integer wraparound in qcow2_co_truncate()

2020-05-01 Thread Alberto Garcia
After commit f01643fb8b47e8a70c04bbf45e0f12a9e5bc54de when an image is extended and BDRV_REQ_ZERO_WRITE is set then the new clusters are zeroized. The code however does not detect correctly situations when the old and the new end of the image are within the same cluster. The problem can be

[PATCH 1/1] vfio/nvlink: Remove exec permission to avoid SELinux AVCs

2020-05-01 Thread Leonardo Bras
If SELinux is setup without 'execmem' permission for qemu, all mmap with (PROT_WRITE | PROT_EXEC) will fail and print a warning in SELinux log. If "nvlink2-mr" memory allocation fails (fist diff), it will cause guest NUMA nodes to not be correctly configured (V100 memory will not be visible for

[PATCH v2 0/2] virtiofsd: stay under fs.file-max sysctl limit (CVE-2020-10717)

2020-05-01 Thread Stefan Hajnoczi
This patch series introduces the --rlimit-nofile=NUM option for setting the number of open files on the virtiofsd process. This gives users and management tools more control over resource limits. Previously it was possible for FUSE clients on machines with less than ~10 GB of RAM to exhaust the

Re: [PATCH v1 2/4] .travis.yml: drop MacOSX

2020-05-01 Thread Richard Henderson
On 5/1/20 4:15 AM, Alex Bennée wrote: > This keeps breaking on Travis so lets just fall back to the Cirrus CI > builds which seem to be better maintained. Fix up the comments while > we are doing this as we never had a windows build. > > Signed-off-by: Alex Bennée > --- > .travis.yml | 28

Re: [PATCH 20/36] target/arm: Convert Neon 3-reg-same VQRDMLAH/VQRDMLSH to decodetree

2020-05-01 Thread Peter Maydell
On Thu, 30 Apr 2020 at 21:28, Richard Henderson wrote: > > On 4/30/20 11:09 AM, Peter Maydell wrote: > > These don't use do_3same() because they want to > > operate on VFP double registers, whose offsets are different from the > > neon_reg_offset() calculations do_3same does. > > Actually, no,

[PATCH v1 4/7] accel/tcg: don't disable exec_tb trace events

2020-05-01 Thread Alex Bennée
I doubt the well predicted trace event check is particularly special in the grand context of TCG code execution. Signed-off-by: Alex Bennée --- accel/tcg/trace-events | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/accel/tcg/trace-events b/accel/tcg/trace-events

Re: RFC: use VFIO over a UNIX domain socket to implement device offloading

2020-05-01 Thread Felipe Franciosi
Hi, > On Apr 30, 2020, at 4:20 PM, Thanos Makatos > wrote: > More importantly, considering: a) Marc-André's comments about data alignment etc., and b) the possibility to run the server on another guest or host, we won't be able to use native VFIO types. If we do want to

Re: [PATCH v1 2/4] .travis.yml: drop MacOSX

2020-05-01 Thread Alex Bennée
Daniel P. Berrangé writes: > On Fri, May 01, 2020 at 12:15:03PM +0100, Alex Bennée wrote: >> This keeps breaking on Travis so lets just fall back to the Cirrus CI >> builds which seem to be better maintained. Fix up the comments while >> we are doing this as we never had a windows build. > >

Re: [PATCH] linux-user/strace.list: fix epoll_create{,1} -strace output

2020-05-01 Thread Philippe Mathieu-Daudé
+ Helge & Aleksandar. On 5/1/20 12:59 AM, Sergei Trofimovich wrote: On Thu, 16 Apr 2020 18:59:57 +0100 Sergei Trofimovich wrote: Fix syscall name and parameters priinter. Before the change: ``` $ alpha-linux-user/qemu-alpha -strace -L /usr/alpha-unknown-linux-gnu/ /tmp/a ... 1274697

Re: [PULL 0/4] Block patches

2020-05-01 Thread Stefan Hajnoczi
On Fri, May 01, 2020 at 10:32:02AM +0100, Peter Maydell wrote: > On Fri, 1 May 2020 at 09:28, Stefan Hajnoczi wrote: > > > > The following changes since commit 27c94566379069fb8930bb1433dcffbf7df3203d: > > > > Merge remote-tracking branch > >

Re: [PATCH 1/1] Fix win32 keycode for VK_OEM_102

2020-05-01 Thread Daniel P . Berrangé
On Wed, Apr 29, 2020 at 08:42:50PM +0200, Volker Rümelin wrote: > The win32 keycode for VK_OEM_102 is 0xe2. The Microsoft docu- > mentation for virtual-key codes agrees with mingw32/winuser.h. Yes, I concur. I must have made a typo when entering this. > > Signed-off-by: Volker Rümelin > --- >

Re: [PATCH 1/4] softfloat: silence sNaN for conversions to/from floatx80

2020-05-01 Thread Alex Bennée
Joseph Myers writes: > Conversions between IEEE floating-point formats should convert > signaling NaNs to quiet NaNs. Most of those in QEMU's softfloat code > do so, but those for floatx80 fail to. Fix those conversions to > silence signaling NaNs as well. > > Signed-off-by: Joseph Myers

[PATCH 2/5] gitlab-ci/opensbi: Update GitLab CI to build generic platform

2020-05-01 Thread Bin Meng
From: Bin Meng This updates the GitLab CI opensbi job to build opensbi bios images for the generic platform. Signed-off-by: Bin Meng --- .gitlab-ci-opensbi.yml | 26 -- 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a/.gitlab-ci-opensbi.yml

[PATCH 1/5] roms/opensbi: Update to support building bios images for generic platform

2020-05-01 Thread Bin Meng
From: Bin Meng The RISC-V generic platform is a flattened device tree (FDT) based platform where all platform specific functionality is provided based on FDT passed by previous booting stage. The support was added in upstream opensbi recently. Bring the QEMU roms/opensbi submodule to the

Re: [PATCH v2] fuzz: select fuzz target using executable name

2020-05-01 Thread Darren Kenny
On Friday, 2020-05-01 at 09:56:12 -04, Alexander Bulekov wrote: > The fuzzers are built into a binary (e.g. qemu-fuzz-i386). To select the > device to fuzz/fuzz target, we usually use the --fuzz-target= argument. > This commit allows the fuzz-target to be specified using the name of the >

Re: [PATCH v1 4/4] .travis.yml: reduce the load on [ppc64] GCC check-tcg

2020-05-01 Thread Richard Henderson
On 5/1/20 4:15 AM, Alex Bennée wrote: > This seems to be timing out quite often and occasionally running out > of disk space. Relegate it to light duties. > > Signed-off-by: Alex Bennée > --- > .travis.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson

Re: [PATCH v1 2/9] gdbstub: Introduce gdb_get_float64() to get 64-bit float registers

2020-05-01 Thread Richard Henderson
On 4/30/20 12:01 PM, Alex Bennée wrote: > From: Philippe Mathieu-Daudé > > When converted to use GByteArray in commits 462474d760c and > a010bdbe719, the call to stfq_p() was removed. This call > serialize a float. > Since we now use a GByteArray, we can not use stfq_p() directly. > Introduce

Re: [PATCH v1 5/9] gdbstub: eliminate gdbserver_fd global

2020-05-01 Thread Richard Henderson
On 4/30/20 12:01 PM, Alex Bennée wrote: > We don't really need to track this fd beyond the initial creation of > the socket. We already know if the system has been initialised by > virtue of the gdbserver_state so lets remove it. This makes the later > re-factoring easier. > > Signed-off-by: Alex

Re: [PATCH v7 0/7] reference implementation of RSS and hash report

2020-05-01 Thread Michael S. Tsirkin
We are in freeze so nothing's applied right now. v8 which has all the bits will be a good step so we are ready for after freeze. On Fri, May 01, 2020 at 07:01:58AM +0300, Yuri Benditovich wrote: > Michael/Jason, > > As Linux headers was updated in qemu and now include RSC/RSS/Hash definitions, >

Re: [PATCH v1 6/9] gdbstub/linux-user: support debugging over a unix socket

2020-05-01 Thread Richard Henderson
On 4/30/20 12:01 PM, Alex Bennée wrote: > @@ -814,7 +814,7 @@ int main(int argc, char **argv) > exit(1); > } > } else if (!strcmp(r, "g")) { > -gdbstub_port = atoi(argv[optind++]); > +gdbstub = g_strdup(argv[optind++]); You've got one

Re: [PATCH v1 8/9] tests/tcg: add a multiarch linux-user gdb test

2020-05-01 Thread Richard Henderson
On 4/30/20 12:01 PM, Alex Bennée wrote: > When the gdbstub code was converted to the new API we missed a few > snafus in the various guests. Add a simple gdb test script which can > be used on all our linux-user guests to check for obvious failures. > > Signed-off-by: Alex Bennée > > --- > v2 >

Re: [PATCH v1 7/9] tests/guest-debug: use the unix socket for linux-user tests

2020-05-01 Thread Richard Henderson
On 4/30/20 12:01 PM, Alex Bennée wrote: > +if "system" in args.qemu: > +gdb_cmd += " -ex 'target remote localhost:1234'" > +else: > +gdb_cmd += " -ex 'target remote %s'" % (socket_name) Why should not system testing be moved to sockets? Surely that has the same problem in

Re: [PATCH v1 9/9] target/m68k: fix gdb for m68xxx

2020-05-01 Thread Laurent Vivier
Le 30/04/2020 à 21:01, Alex Bennée a écrit : > From: KONRAD Frederic > > Currently "cf-core.xml" is sent to GDB when using any m68k flavor. Thing is > it uses the "org.gnu.gdb.coldfire.core" feature name and gdb 8.3 then expects > a coldfire FPU instead of the default m68881 FPU. > > This is

Re: [PATCH v1 9/9] target/m68k: fix gdb for m68xxx

2020-05-01 Thread Richard Henderson
On 4/30/20 12:01 PM, Alex Bennée wrote: > From: KONRAD Frederic > > Currently "cf-core.xml" is sent to GDB when using any m68k flavor. Thing is > it uses the "org.gnu.gdb.coldfire.core" feature name and gdb 8.3 then expects > a coldfire FPU instead of the default m68881 FPU. > > This is not OK

[PATCH v1 0/7] various tcg and linux-user updates

2020-05-01 Thread Alex Bennée
Hi, Cleaning up my queues into more focused trees these are all tweaks to TCG related stuff. The guest_base changes where posted before but where a little radical for 5.0 but I think are worth getting in early as it enables the sanitizer builds for a range of linux-user targets we couldn't run

[PATCH v1 2/7] exec/cpu-all: Use bool for have_guest_base

2020-05-01 Thread Alex Bennée
From: Richard Henderson Signed-off-by: Richard Henderson Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- include/exec/cpu-all.h | 2 +- bsd-user/main.c| 4 ++-- linux-user/main.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH v1 5/7] disas: include an optional note for the start of disassembly

2020-05-01 Thread Alex Bennée
This will become useful shortly for providing more information about output assembly inline. While there fix up the indenting and code formatting in disas(). Signed-off-by: Alex Bennée --- include/disas/disas.h | 2 +- include/exec/log.h| 4 ++-- accel/tcg/translate-all.c | 4

[PATCH v1 3/7] accel/tcg: Relax va restrictions on 64-bit guests

2020-05-01 Thread Alex Bennée
From: Richard Henderson We cannot at present limit a 64-bit guest to a virtual address space smaller than the host. It will mostly work to ignore this limitation, except if the guest uses high bits of the address space for tags. But it will certainly work better, as presently we can wind up

Re: [PATCH v1 7/9] tests/guest-debug: use the unix socket for linux-user tests

2020-05-01 Thread Alex Bennée
Richard Henderson writes: > On 4/30/20 12:01 PM, Alex Bennée wrote: >> +if "system" in args.qemu: >> +gdb_cmd += " -ex 'target remote localhost:1234'" >> +else: >> +gdb_cmd += " -ex 'target remote %s'" % (socket_name) > > Why should not system testing be moved to

Re: [PATCH] aspeed: Add support for the sonorapass-bmc board

2020-05-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200501113704.2240698-1-patr...@stwcx.xyz/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200501113704.2240698-1-patr...@stwcx.xyz Subject: [PATCH] aspeed: Add support for the

Re: [PATCH v1 5/7] disas: include an optional note for the start of disassembly

2020-05-01 Thread Philippe Mathieu-Daudé
On 5/1/20 4:57 PM, Alex Bennée wrote: This will become useful shortly for providing more information about output assembly inline. While there fix up the indenting and code formatting in disas(). Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- include/disas/disas.h

Re: RFC: use VFIO over a UNIX domain socket to implement device offloading

2020-05-01 Thread Daniel P . Berrangé
On Fri, May 01, 2020 at 03:01:01PM +, Felipe Franciosi wrote: > Hi, > > > On Apr 30, 2020, at 4:20 PM, Thanos Makatos > > wrote: > > > More importantly, considering: > a) Marc-André's comments about data alignment etc., and > b) the possibility to run the server on another

Re: [PATCH 23/36] target/arm: Convert Neon 64-bit element 3-reg-same insns

2020-05-01 Thread Peter Maydell
On Thu, 30 Apr 2020 at 21:54, Richard Henderson wrote: > You can morph this into the gvec interface like so: > > #define DO_3SAME_64(INSN, FUNC) \ > static void gen_##INSN##_3s(unsigned vece, uint32_t rd_ofs, > uint32_t rn_ofs, uint32_t rm_ofs, >

Re: [PATCH 23/36] target/arm: Convert Neon 64-bit element 3-reg-same insns

2020-05-01 Thread Richard Henderson
On 5/1/20 8:36 AM, Peter Maydell wrote: > On Thu, 30 Apr 2020 at 21:54, Richard Henderson > wrote: >> You can morph this into the gvec interface like so: >> >> #define DO_3SAME_64(INSN, FUNC) \ >> static void gen_##INSN##_3s(unsigned vece, uint32_t rd_ofs, >>

[PATCH 0/5] riscv: Switch to use generic platform of opensbi bios images

2020-05-01 Thread Bin Meng
From: Bin Meng The RISC-V generic platform is a flattened device tree (FDT) based platform where all platform specific functionality is provided based on FDT passed by previous booting stage. The support was added in upstream opensbi recently. This series updates QEMU to switch to use generic

[PATCH 4/5] riscv/spike: Change the default bios to use generic platform image

2020-05-01 Thread Bin Meng
From: Bin Meng To keep sync with other RISC-V machines, change the default bios to use generic platform image. While we are here, add some comments to mention that keeping ELF files here was intentional. Signed-off-by: Bin Meng --- hw/riscv/spike.c | 9 +++-- 1 file changed, 7

Re: [PATCH 23/36] target/arm: Convert Neon 64-bit element 3-reg-same insns

2020-05-01 Thread Peter Maydell
On Thu, 30 Apr 2020 at 21:54, Richard Henderson wrote: > > On 4/30/20 11:09 AM, Peter Maydell wrote: > > + > > +rn = tcg_temp_new_i64(); > > +rm = tcg_temp_new_i64(); > > +rd = tcg_temp_new_i64(); > > + > > +for (pass = 0; pass < (a->q ? 2 : 1); pass++) { > > +

Re: About hardfloat in ppc

2020-05-01 Thread Richard Henderson
On 5/1/20 6:10 AM, Alex Bennée wrote: > > 罗勇刚(Yonggang Luo) writes: > >> On Fri, May 1, 2020 at 7:58 PM BALATON Zoltan wrote: >> >>> On Fri, 1 May 2020, 罗勇刚(Yonggang Luo) wrote: That's what I suggested, We preserve a float computing cache typedef struct FpRecord { uint8_t

Re: [PATCH v2] fuzz: select fuzz target using executable name

2020-05-01 Thread Alexander Bulekov
Please ignore. I think I misunderstood the issue with the pull-request. Additionally, this patch still has incorrect spacing and is missing review tags. On 200501 0956, Alexander Bulekov wrote: > The fuzzers are built into a binary (e.g. qemu-fuzz-i386). To select the > device to fuzz/fuzz

[PATCH v1 1/7] linux-user: completely re-write init_guest_space

2020-05-01 Thread Alex Bennée
First we ensure all guest space initialisation logic comes through probe_guest_base once we understand the nature of the binary we are loading. The convoluted init_guest_space routine is removed and replaced with a number of pgb_* helpers which are called depending on what requirements we have

[PATCH v1 7/7] translate-all: include guest address in out_asm output

2020-05-01 Thread Alex Bennée
We already have information about where each guest instructions representation starts stored in the tcg_ctx->gen_insn_data so we can rectify the PC for faults. We can re-use this information to annotate the out_asm output with guest instruction address which makes it a bit easier to work out where

[PATCH v1 6/7] disas: add optional note support to cap_disas

2020-05-01 Thread Alex Bennée
Include support for outputting a note at the top of a chunk of disassembly to capstone as well. Signed-off-by: Alex Bennée --- disas.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/disas.c b/disas.c index bb74650633..5e7eb65326 100644 --- a/disas.c

[PATCH 5/5] riscv: Suppress the error report for QEMU testing with riscv_find_firmware()

2020-05-01 Thread Bin Meng
From: Bin Meng We only ship plain binary bios images in the QEMU source. With Spike machine that uses ELF images as the default bios, running QEMU test will complain hence let's suppress the error report for QEMU testing. Signed-off-by: Bin Meng --- hw/riscv/boot.c | 14 +++--- 1

[PATCH 3/5] riscv: Use pre-built bios image of generic platform for virt & sifive_u

2020-05-01 Thread Bin Meng
From: Bin Meng Update virt and sifive_u machines to use the opensbi bios image built for the generic FDT platform. Remove the out-of-date no longer used bios images. Signed-off-by: Bin Meng --- hw/riscv/sifive_u.c | 4 ++-- hw/riscv/virt.c

  1   2   >