[PATCH v7 08/11] accel/Kconfig: Extract accel selectors into their own config

2020-06-05 Thread Philippe Mathieu-Daudé
Move the accel selectors from the global Kconfig.host to their own Kconfig file. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- Makefile | 1 + Kconfig.host | 7 --- accel/Kconfig | 6 ++ 3 files changed, 7 insertions(+), 7 deletions(-) create mode

[PATCH v7 07/11] Makefile: Write MINIKCONF variables as one entry per line

2020-06-05 Thread Philippe Mathieu-Daudé
Having one entry per line helps reviews/refactors. As we are going to modify the MINIKCONF variables, split them now to ease further review. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- Makefile | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff

[PATCH 5/7] softfloat: return low bits of quotient from floatx80_modrem

2020-06-05 Thread Joseph Myers
Both x87 and m68k need the low parts of the quotient for their remainder operations. Arrange for floatx80_modrem to track those bits and return them via a pointer. The architectures using float32_rem and float64_rem do not appear to need this information, so the *_rem interface is left unchanged

Re: [PATCH 14/16] arm/aspeed: Drop aspeed_board_init_flashes() parameter @errp

2020-06-05 Thread Cédric Le Goater
On 6/5/20 4:56 PM, Markus Armbruster wrote: > We always pass _abort. Drop the parameter, use _abort > directly. > > Cc: Cédric Le Goater > Cc: Peter Maydell > Cc: Andrew Jeffery > Cc: Joel Stanley > Cc: qemu-...@nongnu.org > Signed-off-by: Markus Armbruster Reviewed-by: Cédric Le Goater

Re: [PATCH 12/13] i386: hvf: Move mmio_buf into CPUX86State

2020-06-05 Thread Roman Bolshakov
On Thu, Jun 04, 2020 at 08:27:37PM +0200, Paolo Bonzini wrote: > On 28/05/20 21:37, Roman Bolshakov wrote: > > There's no similar field in CPUX86State, but it's needed for MMIO traps. > > > > It should be possible to get rid of the buffer altogether, but it's ok > to do it separately. > Hi

[PATCH v2 00/13] Add Thread Sanitizer support to QEMU

2020-06-05 Thread Robert Foley
v1: https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg08302.html Changes in v2: - Fixed make check under TSan.  With the below fixes, make check  under TSan completes successfully, albeit with TSan warnings.   - We found that several unit tests and the qtests hit an issue in TSan,

Re: [PATCH] fuzz: add oss-fuzz build.sh script

2020-06-05 Thread Philippe Mathieu-Daudé
On 6/5/20 7:40 PM, Alexander Bulekov wrote: > It is neater to keep this in the QEMU repo, since any change that > requires an update to the oss-fuzz build configuration, can make the > necessary changes in the same series. > > Suggested-by: Philippe Mathieu-Daude 'Philippe Mathieu-Daudé' ;) >

[PATCH v1] nvme: allow cmb and pmr emulation on same device

2020-06-05 Thread Andrzej Jakowski
This patch series does following: - Fixes problem where CMBS bit was not set in controller capabilities register, so support for CMB was not correctly advertised to guest. This is resend of patch that has been submitted and reviewed by Klaus [1] - Introduces BAR4 sharing between MSI-X

[PATCH v1 1/2] nvme: indicate CMB support through controller capabilities register

2020-06-05 Thread Andrzej Jakowski
This patch sets CMBS bit in controller capabilities register when user configures NVMe driver with CMB support, so capabilites are correctly reported to guest OS. Signed-off-by: Andrzej Jakowski Reviewed-by: Klaus Jensen --- hw/block/nvme.c | 2 ++ include/block/nvme.h | 6 +- 2 files

Re: [PATCH] configure: Disable -Wtautological-type-limit-compare

2020-06-05 Thread Peter Maydell
On Fri, 5 Jun 2020 at 18:47, Richard Henderson wrote: > > On 6/5/20 8:53 AM, Alex Bennée wrote: > >> --- a/configure > >> +++ b/configure > >> @@ -2009,6 +2009,8 @@ gcc_flags="-Wno-missing-include-dirs -Wempty-body > >> -Wnested-externs $gcc_flags" > >> gcc_flags="-Wendif-labels

[Bug 1827005] Re: hvf: ubuntu iso boot menu issue

2020-06-05 Thread Roman Bolshakov
** Tags added: hvf -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1827005 Title: hvf: ubuntu iso boot menu issue Status in QEMU: New Bug description: With hvf acceleration on macOS, ubuntu

[PATCH 4/7] softfloat: do not set denominator high bit for floatx80 remainder

2020-06-05 Thread Joseph Myers
The floatx80 remainder implementation unnecessarily sets the high bit of bSig explicitly. By that point in the function, arguments that are invalid, zero, infinity or NaN have already been handled and subnormals have been through normalizeFloatx80Subnormal, so the high bit will already be set.

[PATCH 6/7] target/i386: reimplement fprem1 using floatx80 operations

2020-06-05 Thread Joseph Myers
The x87 fprem1 emulation is currently based around conversion to double, which is inherently unsuitable for a good emulation of any floatx80 operation. Reimplement using the soft-float floatx80 remainder operations. Signed-off-by: Joseph Myers --- target/i386/fpu_helper.c | 96

Re: [PATCH v4 06/12] qcow2_format.py: use strings to specify c-type of struct fields

2020-06-05 Thread Eric Blake
On 6/4/20 12:41 PM, Vladimir Sementsov-Ogievskiy wrote: We are going to move field-parsing to super-class, this will be simpler with simple string specifiers instead of variables. For some reason python doesn't allow to define ctypes in class too, as well as fields: it's not available than in

[PATCH v2 06/13] tcg: call qemu_spin_destroy for tb->jmp_lock

2020-06-05 Thread Robert Foley
From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley [RF: Minor changes to fix some checkpatch errors] --- accel/tcg/translate-all.c | 10 +- include/tcg/tcg.h | 3 ++- tcg/tcg.c | 19 --- 3 files changed, 27

[PATCH v7 01/11] MAINTAINERS: Fix KVM path expansion glob

2020-06-05 Thread Philippe Mathieu-Daudé
The KVM files has been moved from target-ARCH to the target/ARCH/ folder in commit fcf5ef2a. Fix the pathname expansion. Fixes: fcf5ef2a ("Move target-* CPU file into a target/ folder") Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé ---

[PATCH v7 05/11] rules.mak: Add base-arch() rule

2020-06-05 Thread Philippe Mathieu-Daudé
Add a rule to return the base architecture for a QEMU target. The current list of TARGET_BASE_ARCH is: $ git grep TARGET_BASE_ARCH configure configure:7785:TARGET_BASE_ARCH="" configure:7795:TARGET_BASE_ARCH=i386 configure:7813:TARGET_BASE_ARCH=arm configure:7846:

[PATCH v7 02/11] MAINTAINERS: Add an 'overall' entry for accelerators

2020-06-05 Thread Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 948790b433..f725c12161 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -415,6 +415,17 @@ S: Supported F:

Re: [PATCH v2] fuzz: add oss-fuzz build.sh script

2020-06-05 Thread Alexander Bulekov
Hi Darren, On 200605 1858, Darren Kenny wrote: > Hi Alex, > > From looking at another OSS Fuzz project recently (a coincidence) I > wonder if we could make this script work so that it can be run outside > of the OSS-Fuzz environment? > > Specifically, for example, if $OUT is not set, then

Re: another tst-arm-mte bug: qemu-system segfaults

2020-06-05 Thread Richard Henderson
On 6/3/20 10:17 AM, Szabolcs Nagy wrote: > The 06/03/2020 09:21, Richard Henderson wrote: >> On 6/3/20 6:50 AM, Szabolcs Nagy wrote: >>> thanks my tests now get further but later i run into >>> the previous assert failure: >>> >>> target/arm/mte_helper.c:97:allocation_tag_mem: assertion failed:

Re: [PATCH] fuzz: add oss-fuzz build.sh script

2020-06-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200605174036.4527-1-alx...@bu.edu/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200605174036.4527-1-alx...@bu.edu Subject: [PATCH] fuzz: add oss-fuzz build.sh script Type: series ===

[PATCH] fuzz: add oss-fuzz build.sh script

2020-06-05 Thread Alexander Bulekov
It is neater to keep this in the QEMU repo, since any change that requires an update to the oss-fuzz build configuration, can make the necessary changes in the same series. Suggested-by: Philippe Mathieu-Daude Signed-off-by: Alexander Bulekov --- scripts/oss-fuzz/build.sh | 47

[PATCH v2 08/13] thread: add tsan annotations to QemuSpin

2020-06-05 Thread Robert Foley
From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley Reviewed-by: Alex Bennée --- include/qemu/thread.h | 39 --- 1 file changed, 36 insertions(+), 3 deletions(-) diff --git a/include/qemu/thread.h b/include/qemu/thread.h index

Re: [PULL v2 05/13] accel/tcg: Relax va restrictions on 64-bit guests

2020-06-05 Thread Richard Henderson
On 6/5/20 7:11 AM, Alex Bennée wrote: > @@ -467,7 +467,7 @@ abi_long target_mmap(abi_ulong start, abi_ulong len, int > prot, > * It can fail only on 64-bit host with 32-bit target. > * On any other target/host host mmap() handles this error correctly. > */ > -

Re: [PATCH v2 03/17] target/riscv: Move the hfence instructions to the rvh decode

2020-06-05 Thread Richard Henderson
On 6/4/20 6:20 PM, Alistair Francis wrote: > Also correct the name of the VVMA instruction. > > Signed-off-by: Alistair Francis > --- > target/riscv/insn32.decode| 8 ++- > .../riscv/insn_trans/trans_privileged.inc.c | 38 - >

[PATCH v7 03/11] MAINTAINERS: Add an entry for the HAX accelerator

2020-06-05 Thread Philippe Mathieu-Daudé
Nobody replied since the first time [*] that patch was posted, so mark HAX as orphan. [*] https://mid.mail-archive.com/20200316120049.11225-4-philmd@redhat.com Cc: haxm-t...@intel.com Cc: Tao Wu Cc: Colin Xu Cc: Wenchao Wang Cc: Vincent Palatin Cc: Sergio Andres Gomez Del Real

[PATCH v7 11/11] accel/tcg: Add stub for probe_access()

2020-06-05 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé The TCG helpers where added in b92e5a22ec3 in softmmu_template.h. probe_write() was added in there in 3b4afc9e75a to be moved out to accel/tcg/cputlb.c in 3b08f0a9254, and was later refactored as probe_access() in c25c283df0f. Since it is a TCG specific helper, add a

Re: [PATCH v4 01/12] qcow2.py: python style fixes

2020-06-05 Thread Eric Blake
On 6/4/20 12:41 PM, Vladimir Sementsov-Ogievskiy wrote: Fix flake8 complains. Leave the only chunk of lines over 79 characters: complaints initialization of cmds variable. Leave it for another day, when it should be refactored to utilize argparse instead of hand-written parsing.

Re: [RFC v2 00/18] Refactor configuration of guest memory protection

2020-06-05 Thread Thiago Jung Bauermann
Paolo Bonzini writes: > On 05/06/20 01:30, Thiago Jung Bauermann wrote: >> Paolo Bonzini writes: >>> On 04/06/20 23:54, Thiago Jung Bauermann wrote: QEMU could always create a PEF object, and if the command line defines one, it will correspond to it. And if the command line doesn't

Re: [PATCH v2 00/24] Fixes around device realization

2020-06-05 Thread Paolo Bonzini
Yes please, my next pull request is already at 120 patches... Paolo Il ven 5 giu 2020, 17:01 Markus Armbruster ha scritto: > Needs a rebase now. > > Paolo, would you like me to post the pull requests for my recent QOM > work myself? > >

[PATCH v2 09/13] tests/docker: Added docker build support for TSan.

2020-06-05 Thread Robert Foley
Added a new docker for ubuntu 20.04. This docker has support for Thread Sanitizer including one patch we need in one of the header files. https://github.com/llvm/llvm-project/commit/a72dc86cd This command will build with tsan enabled: make docker-test-tsan-ubuntu2004 Also added the TSAN

Re: [PATCH] configure: Disable -Wtautological-type-limit-compare

2020-06-05 Thread Richard Henderson
On 6/5/20 8:53 AM, Alex Bennée wrote: > > Richard Henderson writes: > >> Clang 10 enables this by default with -Wtype-limit. >> >> All of the instances flagged by this Werror so far have been >> cases in which we really do want the compiler to optimize away >> the test completely. Disabling

[PATCH v7 00/11] accel: Allow targets to use Kconfig

2020-06-05 Thread Philippe Mathieu-Daudé
Missing review: - 4/11 rules.mak: Add strequal() and startswith() rules - 5/11 rules.mak: Add base-arch() rule This series include generic patches I took of the KVM/ARM specific series which will follow. - List orphan accelerators in MAINTAINERS - Add accel/Kconfig - Allow targets to use their

[PATCH v7 04/11] rules.mak: Add strequal() and startswith() rules

2020-06-05 Thread Philippe Mathieu-Daudé
Add a rule to test if two strings are equal, and another to test if a string starts with a substring. Signed-off-by: Philippe Mathieu-Daudé --- rules.mak | 14 ++ 1 file changed, 14 insertions(+) diff --git a/rules.mak b/rules.mak index 694865b63e..7b58a6b8c5 100644 --- a/rules.mak

[PATCH v1 2/2] nvme: allow cmb and pmr to be enabled on same device

2020-06-05 Thread Andrzej Jakowski
So far it was not possible to have CMB and PMR emulated on the same device, because BAR2 was used exclusively either of PMR or CMB. This patch places CMB at BAR4 offset so it not conflicts with MSI-X vectors. Signed-off-by: Andrzej Jakowski --- hw/block/nvme.c | 127

Re: [PATCH 2/7] python/qemu: formalize as package

2020-06-05 Thread John Snow
On 6/5/20 10:40 AM, Vladimir Sementsov-Ogievskiy wrote: > > Hmm, documentation says: > >    Warning Using setup_requires is discouraged in favor of PEP-518 > > did you consider this thing? I guess the difference here is we start using a pyproject.toml and then we declare setuptools, wheel

Re: [PATCH v4 02/12] qcow2.py: move qcow2 format classes to separate module

2020-06-05 Thread Eric Blake
On 6/4/20 12:41 PM, Vladimir Sementsov-Ogievskiy wrote: We are going to enhance qcow2 format parsing by adding more structure classes. Let's split format parsing from utility code. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/qcow2.py| 161

Re: [PULL 00/19] Linux user for 5.1 patches

2020-06-05 Thread Peter Maydell
On Fri, 5 Jun 2020 at 20:20, Laurent Vivier wrote: > I was thinking this kind of problem would be detected by the travis-ci > builds, but in fact ppc64 and s390 builds don't build other architecture > linux-user targets. That's an unfortunate gap in the CI -- we should ideally cover the whole

Re: [PATCH v4 00/12] iotests: Dump QCOW2 dirty bitmaps metadata

2020-06-05 Thread Eric Blake
On 6/4/20 12:41 PM, Vladimir Sementsov-Ogievskiy wrote: Hi all! Here is my suggestion to substitute only first three patches :) of Andrey's [PATCH v3 0/6] iotests: Dump QCOW2 dirty bitmaps metadata so, I called it v4 for convenience. What is here: 1. First, update code style 2. Next, try to

[PATCH v2 07/13] translate-all: call qemu_spin_destroy for PageDesc

2020-06-05 Thread Robert Foley
From: "Emilio G. Cota" The radix tree is append-only, but we can fail to insert a PageDesc if the insertion races with another thread. Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- accel/tcg/translate-all.c | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH v2 13/13] tests: Disable select tests under TSan, which hit TSan issue.

2020-06-05 Thread Robert Foley
Disable a few tests under CONFIG_TSAN, which run into a known TSan issue that results in a hang. https://github.com/google/sanitizers/issues/1116 The disabled tests under TSan include all the qtests as well as the test-char, test-qga, and test-qdev-global-props. Signed-off-by: Robert Foley ---

[PATCH v2 05/13] qht: call qemu_spin_destroy for head buckets

2020-06-05 Thread Robert Foley
From: "Emilio G. Cota" Signed-off-by: Robert Foley Reviewed-by: Alex Bennée --- util/qht.c | 1 + 1 file changed, 1 insertion(+) diff --git a/util/qht.c b/util/qht.c index aa51be3c52..67e5d5b916 100644 --- a/util/qht.c +++ b/util/qht.c @@ -348,6 +348,7 @@ static inline void

[PATCH v2 11/13] util: Added tsan annotate for thread name.

2020-06-05 Thread Robert Foley
This allows us to see the name of the thread in tsan warning reports such as this: Thread T7 'CPU 1/TCG' (tid=24317, running) created by main thread at: Signed-off-by: Robert Foley Reviewed-by: Emilio G. Cota --- util/qemu-thread-posix.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH v2 01/17] target/riscv: Set access as data_load when validating stage-2 PTEs

2020-06-05 Thread Richard Henderson
On 6/4/20 6:20 PM, Alistair Francis wrote: > Signed-off-by: Alistair Francis > --- > target/riscv/cpu_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v2 02/17] target/riscv: Report errors validating 2nd-stage PTEs

2020-06-05 Thread Richard Henderson
On 6/4/20 6:20 PM, Alistair Francis wrote: > Signed-off-by: Alistair Francis > --- > target/riscv/cpu_helper.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

[PATCH v2] fuzz: add oss-fuzz build.sh script

2020-06-05 Thread Alexander Bulekov
It is neater to keep this in the QEMU repo, since any change that requires an update to the oss-fuzz build configuration, can make the necessary changes in the same series. Suggested-by: Philippe Mathieu-Daude Signed-off-by: Alexander Bulekov --- v2 updates the script header comment.

Re: [PULL 00/19] Linux user for 5.1 patches

2020-06-05 Thread Laurent Vivier
t;> >> stubs: Restrict ui/win32-kbd-hook to system-mode (2020-06-05 11:36:00 >> +0200) >> >> >> linux-user pull request 20200605 >> >> Implement F_OFD_ fcntl() command, /proc/cpuinfo for hppa &

Re: [PATCH v4 04/12] qcow2_format.py: use tuples instead of lists for fields

2020-06-05 Thread Eric Blake
On 6/4/20 12:41 PM, Vladimir Sementsov-Ogievskiy wrote: No need in lists: it's a constant variable. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/qcow2_format.py | 40 +++--- 1 file changed, 20 insertions(+), 20 deletions(-) #

Re: [PATCH 4/7] python/qemu: Add pipenv support

2020-06-05 Thread John Snow
On 6/5/20 12:21 PM, Vladimir Sementsov-Ogievskiy wrote: > 03.06.2020 03:15, John Snow wrote: >> pipenv is a tool used for managing virtual environments with precisely >> specified dependencies. It is separate from the dependencies listed in >> setup.py, which are (by 'best practices') not

[PATCH v2 02/13] cpu: convert queued work to a QSIMPLEQ

2020-06-05 Thread Robert Foley
From: "Emilio G. Cota" We convert queued work to a QSIMPLEQ, instead of open-coding it. While at it, make sure that all accesses to the list are performed while holding the list's lock. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé

[PATCH v2 01/13] configure: add --enable-tsan flag + fiber annotations for coroutine-ucontext

2020-06-05 Thread Robert Foley
From: Lingfeng Yang We tried running QEMU under tsan in 2016, but tsan's lack of support for longjmp-based fibers was a blocker: https://groups.google.com/forum/#!topic/thread-sanitizer/se0YuzfWazw Fortunately, thread sanitizer gained fiber support in early 2019:

[PATCH v2 12/13] docs: Added details on TSan to testing.rst

2020-06-05 Thread Robert Foley
Adds TSan details to testing.rst. This includes background and reference details on TSan, and details on how to build and test with TSan both with and without docker. Signed-off-by: Robert Foley Reviewed-by: Emilio G. Cota --- docs/devel/testing.rst | 107

[PATCH v2 04/13] cputlb: destroy CPUTLB with tlb_destroy

2020-06-05 Thread Robert Foley
From: "Emilio G. Cota" I was after adding qemu_spin_destroy calls, but while at it I noticed that we are leaking some memory. Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley Reviewed-by: Alex Bennée --- accel/tcg/cputlb.c | 15 +++ exec.c | 1 +

[PATCH v2 10/13] include/qemu: Added tsan.h for annotations.

2020-06-05 Thread Robert Foley
These annotations will allow us to give tsan additional hints. For example, we can inform tsan about reads/writes to ignore to silence certain classes of warnings. We can also annotate threads so that the proper thread naming shows up in tsan warning results. Signed-off-by: Robert Foley

[PATCH v2 03/13] thread: add qemu_spin_destroy

2020-06-05 Thread Robert Foley
From: "Emilio G. Cota" It will be used for TSAN annotations. Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley Reviewed-by: Alex Bennée --- include/qemu/thread.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/qemu/thread.h b/include/qemu/thread.h index

Re: [PATCH v2 04/17] target/riscv: Implement checks for hfence

2020-06-05 Thread Richard Henderson
On 6/4/20 6:20 PM, Alistair Francis wrote: > Call the helper_hyp_tlb_flush() function on hfence instructions which > will generate an illegal insruction execption if we don't have > permission to flush the Hypervisor level TLBs. > > Signed-off-by: Alistair Francis > --- > target/riscv/helper.h

[PATCH v7 09/11] accel/Kconfig: Add the TCG selector

2020-06-05 Thread Philippe Mathieu-Daudé
Expose the CONFIG_TCG selector to let minikconf.py uses it. When building with --disable-tcg build, this helps to deselect devices that are TCG-dependent. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- Makefile | 1 + accel/Kconfig | 3 +++ 2 files changed, 4

Re: [PATCH] fuzz: add oss-fuzz build.sh script

2020-06-05 Thread Alexander Bulekov
On 200605 1956, Philippe Mathieu-Daudé wrote: > On 6/5/20 7:40 PM, Alexander Bulekov wrote: > > It is neater to keep this in the QEMU repo, since any change that > > requires an update to the oss-fuzz build configuration, can make the > > necessary changes in the same series. > > > >

[PATCH 1/7] softfloat: merge floatx80_mod and floatx80_rem

2020-06-05 Thread Joseph Myers
The m68k-specific softfloat code includes a function floatx80_mod that is extremely similar to floatx80_rem, but computing the remainder based on truncating the quotient toward zero rather than rounding it to nearest integer. This is also useful for emulating the x87 fprem and fprem1

Re: [PATCH v2] fuzz: add oss-fuzz build.sh script

2020-06-05 Thread Darren Kenny
On Friday, 2020-06-05 at 14:24:59 -04, Alexander Bulekov wrote: > Hi Darren, > > On 200605 1858, Darren Kenny wrote: >> Hi Alex, >> >> From looking at another OSS Fuzz project recently (a coincidence) I >> wonder if we could make this script work so that it can be run outside >> of the OSS-Fuzz

[PATCH 0/7] softfloat, target/i386: fprem, fprem1 fixes

2020-06-05 Thread Joseph Myers
The x87 floating-point emulation of the fprem and fprem1 instructions works via conversion to and from double. This is inherently unsuitable for a good emulation of any floatx80 operation. This patch series adapts the softfloat floatx80_rem implementation to be suitable for these instructions

[PATCH 3/7] softfloat: do not return pseudo-denormal from floatx80 remainder

2020-06-05 Thread Joseph Myers
The floatx80 remainder implementation sometimes returns the numerator unchanged when the denominator is sufficiently larger than the numerator. But if the value to be returned unchanged is a pseudo-denormal, that is incorrect. Fix it to normalize the numerator in that case. Signed-off-by:

[PATCH 2/7] softfloat: fix floatx80 remainder pseudo-denormal check for zero

2020-06-05 Thread Joseph Myers
The floatx80 remainder implementation ignores the high bit of the significand when checking whether an operand (numerator) with zero exponent is zero. This means it mishandles a pseudo-denormal representation of 0x1p-16382L by treating it as zero. Fix this by checking the whole significand

Re: [PATCH] fuzz: add oss-fuzz build.sh script

2020-06-05 Thread Alexander Bulekov
On 200605 1340, Alexander Bulekov wrote: > It is neater to keep this in the QEMU repo, since any change that > requires an update to the oss-fuzz build configuration, can make the > necessary changes in the same series. > > Suggested-by: Philippe Mathieu-Daude > Signed-off-by: Alexander Bulekov

[PATCH v7 06/11] Makefile: Remove dangerous EOL trailing backslash

2020-06-05 Thread Philippe Mathieu-Daudé
One might get caught trying to understand unexpected Makefile behavior. Trailing backslash can help to split very long lines, but are rather dangerous when nothing follow. Preserve other developers debugging time by removing this one. Reviewed-by: Thomas Huth Reviewed-by: Alistair Francis

[PATCH v7 10/11] Makefile: Allow target-specific optional Kconfig

2020-06-05 Thread Philippe Mathieu-Daudé
Allow use of target-specific Kconfig file. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index f8a45e1379..d5009cd304 100644 --- a/Makefile +++ b/Makefile @@ -423,11

Re: [PATCH] configure: Disable -Wtautological-type-limit-compare

2020-06-05 Thread Eric Blake
On 6/5/20 1:09 PM, Peter Maydell wrote: If there's an ordering requirement here we should make it clearer, or somebody is going to do the obvious "tidying up" at some point in the future. Perhaps this whole set of lines should be rearranged, something like: # Enable these warnings if the

Re: [PULL v2 05/13] accel/tcg: Relax va restrictions on 64-bit guests

2020-06-05 Thread Richard Henderson
On 6/5/20 10:46 AM, Alex Bennée wrote: > > Richard Henderson writes: > >> On 6/5/20 7:11 AM, Alex Bennée wrote: >>> @@ -467,7 +467,7 @@ abi_long target_mmap(abi_ulong start, abi_ulong len, >>> int prot, >>> * It can fail only on 64-bit host with 32-bit target. >>> * On any

Re: [PATCH v2] fuzz: add oss-fuzz build.sh script

2020-06-05 Thread Philippe Mathieu-Daudé
On 6/5/20 7:58 PM, Darren Kenny wrote: > Hi Alex, > > From looking at another OSS Fuzz project recently (a coincidence) I > wonder if we could make this script work so that it can be run outside > of the OSS-Fuzz environment? Yes, we want to have this feature to reproduce/debug what oss-fuzz

[PATCH 7/7] target/i386: reimplement fprem using floatx80 operations

2020-06-05 Thread Joseph Myers
The x87 fprem emulation is currently based around conversion to double, which is inherently unsuitable for a good emulation of any floatx80 operation. Reimplement using the soft-float floatx80 remainder operations. Signed-off-by: Joseph Myers --- target/i386/fpu_helper.c | 58

Re: [PATCH v7 05/11] rules.mak: Add base-arch() rule

2020-06-05 Thread Richard Henderson
On 6/5/20 10:58 AM, Philippe Mathieu-Daudé wrote: > Add a rule to return the base architecture for a QEMU target. > > The current list of TARGET_BASE_ARCH is: > > $ git grep TARGET_BASE_ARCH configure > configure:7785:TARGET_BASE_ARCH="" > configure:7795:TARGET_BASE_ARCH=i386 >

Re: [PATCH RFC v2 0/5] block: add block-dirty-bitmap-populate job

2020-06-05 Thread Eric Blake
On 5/13/20 10:49 PM, John Snow wrote: Hi, This is a new (very small) block job that writes a pattern into a bitmap. The only pattern implemented is the top allocation information. This can be used to "recover" an incremental bitmap chain if an external snapshot was taken without creating a new

Re: [PATCH v7 06/11] Makefile: Remove dangerous EOL trailing backslash

2020-06-05 Thread Richard Henderson
On 6/5/20 10:58 AM, Philippe Mathieu-Daudé wrote: > One might get caught trying to understand unexpected Makefile > behavior. Trailing backslash can help to split very long lines, > but are rather dangerous when nothing follow. Preserve other > developers debugging time by removing this one. > >

[PATCH v5 2/3] hw/acpi/nvdimm: add a helper to augment SRAT generation

2020-06-05 Thread Vishal Verma
NVDIMMs can belong to their own proximity domains, as described by the NFIT. In such cases, the SRAT needs to have Memory Affinity structures in the SRAT for these NVDIMMs, otherwise Linux doesn't populate node data structures properly during NUMA initialization. See the following for an example

[PATCH v5 1/3] diffs-allowed: add the SRAT AML to diffs-allowed

2020-06-05 Thread Vishal Verma
In anticipation of a change to the SRAT generation in qemu, add the AML file to diffs-allowed. Signed-off-by: Vishal Verma --- tests/qtest/bios-tables-test-allowed-diff.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h

[PATCH v5 3/3] tests/acpi: update expected SRAT files

2020-06-05 Thread Vishal Verma
Update expected SRAT files for the change to account for NVDIMM NUMA nodes in the SRAT. AML diffs: tests/data/acpi/pc/SRAT.dimmpxm: --- /tmp/asl-3P2IL0.dsl 2020-05-28 15:11:02.326439263 -0600 +++ /tmp/asl-1N4IL0.dsl 2020-05-28 15:11:02.325439280 -0600 @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler

[PATCH v5 0/3] account for NVDIMM nodes during SRAT generation

2020-06-05 Thread Vishal Verma
Changes since v4 (no code changes): - Change the commit message in patch 2 to use memdev= instead of mem= which is deprecated (Igor) - Add Igor's Reviewed-by Changes since v3: - Add the SRAT augmentation for ARM's virt-acpi-build as well (Igor) - Update patches 1 and 3 for the test binaries to

Re: [PATCH v1 00/14] various fixes for next PR (testing, vhost, guest_base fixes)

2020-06-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200605154929.26910-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200605154929.26910-1-alex.ben...@linaro.org Subject: [PATCH v1 00/14] various fixes for next PR

Re: [PULL v2 05/13] accel/tcg: Relax va restrictions on 64-bit guests

2020-06-05 Thread Alex Bennée
Richard Henderson writes: > On 6/5/20 7:11 AM, Alex Bennée wrote: >> @@ -467,7 +467,7 @@ abi_long target_mmap(abi_ulong start, abi_ulong len, int >> prot, >> * It can fail only on 64-bit host with 32-bit target. >> * On any other target/host host mmap() handles this error

Re: [PATCH v2] fuzz: add oss-fuzz build.sh script

2020-06-05 Thread Darren Kenny
Hi Alex, >From looking at another OSS Fuzz project recently (a coincidence) I wonder if we could make this script work so that it can be run outside of the OSS-Fuzz environment? Specifically, for example, if $OUT is not set, then creating a subdir in the build directory, and setting it to be

[Bug 1815263] Re: hvf accelerator crashes on quest boot

2020-06-05 Thread Roman Bolshakov
** Tags added: hvf -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1815263 Title: hvf accelerator crashes on quest boot Status in QEMU: New Bug description: Host OS: macOS High Sierra

Re: [PULL 00/29] target-arm queue

2020-06-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200605165007.12095-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200605165007.12095-1-peter.mayd...@linaro.org Subject: [PULL 00/29] target-arm queue Type:

Re: [PATCH v6 0/7] dwc-hsotg (aka dwc2) USB host controller emulation

2020-06-05 Thread Peter Maydell
On Fri, 5 Jun 2020 at 23:14, Paul Zimmerman wrote: > > > > On Fri, Jun 5, 2020 at 7:28 AM Peter Maydell wrote: >> >> On Thu, 21 May 2020 at 00:54, Paul Zimmerman wrote: >> > >> > This verion fixes a few things pointed out by Peter, and one by >> > Felippe. >> > >> > This patch series adds

Re: [PULL 00/10] s390x update

2020-06-05 Thread Peter Maydell
in the Git repository at: > > https://github.com/cohuck/qemu tags/s390x-20200605 > > for you to fetch changes up to c44d26a2347177f9bcd558a7c429396b373bb68e: > > target/s390x: Restrict system-mode declarations (2020-06-05 17:13:11 +0200) > > --

Re: [PATCH v2] fuzz: add oss-fuzz build.sh script

2020-06-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200605175028.5626-1-alx...@bu.edu/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200605175028.5626-1-alx...@bu.edu Subject: [PATCH v2] fuzz: add oss-fuzz build.sh script Type: series ===

Re: [PATCH v2 1/1] virtio-ccw: auto-manage VIRTIO_F_IOMMU_PLATFORM if PV

2020-06-05 Thread Halil Pasic
On Wed, 20 May 2020 12:23:24 -0400 "Michael S. Tsirkin" wrote: > On Fri, May 15, 2020 at 12:11:55AM +0200, Halil Pasic wrote: > > The virtio specification tells that the device is to present > > VIRTIO_F_ACCESS_PLATFORM (a.k.a. VIRTIO_F_IOMMU_PLATFORM) when the > > device "can only access

Re: [PATCH v6 0/7] dwc-hsotg (aka dwc2) USB host controller emulation

2020-06-05 Thread Paul Zimmerman
On Fri, Jun 5, 2020 at 7:28 AM Peter Maydell wrote: > On Thu, 21 May 2020 at 00:54, Paul Zimmerman wrote: > > > > This verion fixes a few things pointed out by Peter, and one by > > Felippe. > > > > This patch series adds emulation for the dwc-hsotg USB controller, > > which is used on the

Re: [PATCH 0/7] python: create installable package

2020-06-05 Thread Vladimir Sementsov-Ogievskiy
For patches 05-07: Reviewing such patch is a strange thing: Pipfile changes are obvious enough, just select some version (I can't be sure about correct version choice, just believe in your commit messages). But what for Pipfile.lock? I can state that it's about package set selecting,

Re: [PATCH v7 04/11] rules.mak: Add strequal() and startswith() rules

2020-06-05 Thread Richard Henderson
On 6/5/20 10:58 AM, Philippe Mathieu-Daudé wrote: > Add a rule to test if two strings are equal, > and another to test if a string starts with a substring. > > Signed-off-by: Philippe Mathieu-Daudé > --- > rules.mak | 14 ++ > 1 file changed, 14 insertions(+) Reviewed-by: Richard

Re: [PATCH v4 2/3] hw/acpi/nvdimm: add a helper to augment SRAT generation

2020-06-05 Thread Verma, Vishal L
On Fri, 2020-06-05 at 10:23 +0200, Igor Mammedov wrote: > > > > The relevant command line options to exercise this are below. Nodes 0-1 > > > > contain CPUs and regular memory, and nodes 2-3 are the NVDIMM address > > > > space. > > > > > > > > -numa node,nodeid=0,mem=2048M, > > > > -numa

Re: [PATCH v2 00/13] Add Thread Sanitizer support to QEMU

2020-06-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200605173422.1490-1-robert.fo...@linaro.org/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash

Re: [PULL 00/19] Linux user for 5.1 patches

2020-06-05 Thread Richard Henderson
On 6/5/20 1:32 PM, Peter Maydell wrote: > On Fri, 5 Jun 2020 at 20:20, Laurent Vivier wrote: >> I was thinking this kind of problem would be detected by the travis-ci >> builds, but in fact ppc64 and s390 builds don't build other architecture >> linux-user targets. > > That's an unfortunate gap

Re: [PATCH 1/2] Introduce (x86) CPU model deprecation API

2020-06-05 Thread Robert Hoo
On Fri, 2020-06-05 at 08:47 -0500, Eric Blake wrote: > On 6/4/20 9:47 PM, Robert Hoo wrote: > > On Thu, 2020-06-04 at 06:59 -0500, Eric Blake wrote: > > > On 6/4/20 3:07 AM, Robert Hoo wrote: > > > > > > > > > +++ b/qapi/machine-target.json > > > > > > @@ -309,7 +309,8 @@ > > > > > >

Re: [PATCH 4/7] python/qemu: Add pipenv support

2020-06-05 Thread Vladimir Sementsov-Ogievskiy
05.06.2020 20:11, John Snow wrote: On 6/5/20 12:21 PM, Vladimir Sementsov-Ogievskiy wrote: 03.06.2020 03:15, John Snow wrote: pipenv is a tool used for managing virtual environments with precisely specified dependencies. It is separate from the dependencies listed in setup.py, which are (by

Re: [PATCH 3/7] python/qemu: add README.rst

2020-06-05 Thread John Snow
On 6/5/20 10:56 AM, Vladimir Sementsov-Ogievskiy wrote: > 03.06.2020 03:15, John Snow wrote: >> Add a short readme that explains the package hierarchy, which will be >> visible while browsing the source on e.g. gitlab/github. >> >> Signed-off-by: John Snow >> --- >>   python/qemu/README.rst |

Re: [PATCH 4/7] python/qemu: Add pipenv support

2020-06-05 Thread Vladimir Sementsov-Ogievskiy
03.06.2020 03:15, John Snow wrote: pipenv is a tool used for managing virtual environments with precisely specified dependencies. It is separate from the dependencies listed in setup.py, which are (by 'best practices') not supposed to be pinned. Note that pipenv is not required to install or

Re: [PATCH 1/1] util/oslib: Returns real thread identifier on FreeBSD and NetBSD

2020-06-05 Thread David CARLIER
>From 5f0b74a75906a9a043ce4874e7f09dedcad7e6e7 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Fri, 5 Jun 2020 17:18:25 +0100 Subject: [PATCH] util/oslib: Returns real thread identifier on FreeBSD, OpenBSD and NetBSD getpid is good enough in a mono thread context, however

Re: [PATCH v4 11/12] qcow2: QcowHeaderExtension print names for extension magics

2020-06-05 Thread Vladimir Sementsov-Ogievskiy
04.06.2020 20:41, Vladimir Sementsov-Ogievskiy wrote: Suggested-by: Andrey Shinkevich Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/031.out | 22 +++--- tests/qemu-iotests/036.out | 4 ++-- tests/qemu-iotests/061.out | 14

Re: [PATCH v2] exec: flush the whole TLB if a watchpoint crosses a page boundary

2020-06-05 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 6/3/20 2:46 PM, Philippe Mathieu-Daudé wrote: >> On 6/3/20 1:24 PM, Alex Bennée wrote: >>> There is no particular reason why you can't have a watchpoint in TCG >>> that covers a large chunk of the address space. We could be clever >>> about it but these

Re: [PATCH 02/13] i386: hvf: Drop useless declarations in sysemu

2020-06-05 Thread Roman Bolshakov
On Thu, Jun 04, 2020 at 11:53:53AM +0200, Claudio Fontana wrote: > On 5/28/20 9:37 PM, Roman Bolshakov wrote: > > They're either declared elsewhere or have no use. > > > > While at it, rename _hvf_cpu_synchronize_post_init() to > > do_hvf_cpu_synchronize_post_init(). > > > > Signed-off-by: Roman

  1   2   3   4   >