[PULL 09/20] qapi: Fix typo in request-ebpf documentation

Signed-off-by: Markus Armbruster Message-ID: <20240322140910.328840-7-arm...@redhat.com> --- qapi/ebpf.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/ebpf.json b/qapi/ebpf.json index f413d00154..61359e1c0f 100644 --- a/qapi/ebpf.json +++ b/qapi/ebpf.json @@ -51,7

Re: [PATCH 0/2] tap: Use g_spawn_sync() and g_spawn_check_wait_status()

On Tue, Dec 19, 2023 at 7:59 PM Akihiko Odaki wrote: > > g_spawn_sync() gives an informative message if it fails to execute > the script instead of reporting exiting status 1. > > g_spawn_check_wait_status() also gives an message easier to understand > than the raw value returned by waitpid(). >

Re: [PATCH] hw/net/net_tx_pkt: Fix virtio header without checksum offloading

On 2024/03/26 15:51, Jason Wang wrote: On Sun, Mar 24, 2024 at 4:32 PM Akihiko Odaki wrote: It is incorrect to have the VIRTIO_NET_HDR_F_NEEDS_CSUM set when checksum offloading is disabled so clear the bit. Set the VIRTIO_NET_HDR_F_DATA_VALID bit instead to tell the checksum is valid.

[PULL 16/20] qapi: document InputMultiTouchType

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Message-ID: <20240325095648.2835381-1-marcandre.lur...@redhat.com> Reviewed-by: Markus Armbruster [Update qapi/pragma.json] Signed-off-by: Markus Armbruster --- qapi/pragma.json | 2 -- qapi/ui.json | 12 2 files

[PULL 19/20] qapi/block-core: improve Qcow2OverlapCheckFlags documentation

From: Vladimir Sementsov-Ogievskiy Most of fields have no description at all. Let's fix that. Still, no reason to place here more detailed descriptions of what these structures are, as we have public Qcow2 format specification. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-ID:

[PULL 20/20] qapi: document parameters of query-cpu-model-* QAPI commands

From: David Hildenbrand Let's document the parameters of these commands, so we can remove them from the "documentation-exceptions" list. While at it, extend the "Returns:" documentation as well, fixing a wrong use of CpuModelBaselineInfo vs. CpuModelCompareInfo for query-cpu-model-comparison.

[PULL 10/20] qapi: Fix abbreviation punctuation in doc comments

Signed-off-by: Markus Armbruster Message-ID: <20240322140910.328840-8-arm...@redhat.com> --- qapi/migration.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qapi/migration.json b/qapi/migration.json index c865ab00c8..a4319f87bf 100644 --- a/qapi/migration.json +++

[PULL 00/20] QAPI patches patches for 2024-03-26

This pull request does not touch code, only QAPI schema documentation comments and error-suppressing QAPI schema pragma documentation-exceptions. The following changes since commit 6a4180af9686830d88c387baab6d79563ce42a15: Merge tag 'pull-request-2024-03-25' of https://gitlab.com/thuth/qemu

[PULL 01/20] qapi: Improve migration TLS documentation

MigrateSetParameters is about setting parameters, and MigrationParameters is about querying them. Their documentation of @tls-creds and @tls-hostname has residual damage from a failed attempt at de-duplicating them (see commit de63ab61241 "migrate: Share common MigrationParameters struct" and

Re: [PATCH v2] Revert "tap: setting error appropriately when calling net_init_tap_one()"

On Thu, Sep 21, 2023 at 5:48 PM Akihiko Odaki wrote: > > This reverts commit 46d4d36d0bf2b24b205f2f604f0905db80264eef. > > The reverted commit changed to emit warnings instead of errors when > vhost is requested but vhost initialization fails if vhostforce option > is not set. > > However,

[PATCH 2/3] target/hppa: Replace c with uv in do_cond

Prepare for proper indication of shladd unsigned overflow. The UV indicator will be zero/not-zero instead of a single bit. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/target/hppa/translate.c

[PULL 13/20] qapi: Refill doc comments to conform to current conventions

For legibility, wrap text paragraphs so every line is at most 70 characters long. To check the generated documentation does not change, I compared the generated HTML before and after this commit with "wdiff -3". Finds no differences. Comparing with diff is not useful, as the refilled paragraphs

[PULL 14/20] qapi: Correct documentation indentation and whitespace

Signed-off-by: Markus Armbruster Message-ID: <20240322140910.328840-12-arm...@redhat.com> [Add a previous patch's stray hunk] --- qapi/block-core.json | 20 ++-- qapi/crypto.json | 12 ++-- qapi/dump.json | 2 +- qapi/machine.json| 3 +--

[PULL 17/20] qapi: document leftover members in qapi/run-state.json

From: Paolo Bonzini Suggested-by: Markus Armbruster Signed-off-by: Paolo Bonzini Message-ID: <20240325104502.1358693-1-pbonz...@redhat.com> Reviewed-by: Markus Armbruster [Capitalize "ID", update qapi/pragma.json] Signed-off-by: Markus Armbruster --- qapi/pragma.json| 4 +---

[PULL 02/20] qapi: Resync MigrationParameter and MigrateSetParameters

Enum MigrationParameter mirrors the members of struct MigrateSetParameters. Differences to MigrateSetParameters's member documentation are pointless. Clean them up: * @compress-level, @compress-threads, @decompress-threads, and x-checkpoint-delay are more thoroughly documented for

[PULL 11/20] qapi: Start sentences with a capital letter, end them with a period

Signed-off-by: Markus Armbruster Message-ID: <20240322140910.328840-9-arm...@redhat.com> --- qapi/migration.json | 16 qapi/ui.json| 2 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/qapi/migration.json b/qapi/migration.json index

[PULL 06/20] qapi: Tidy up block-latency-histogram-set documentation some more

Commit a937b6aa739 (qapi: Reformat doc comments to conform to current conventions) reflowed some text that should have been left alone. Revert that. Signed-off-by: Markus Armbruster Message-ID: <20240322140910.328840-4-arm...@redhat.com> --- qapi/block.json | 10 +- 1 file changed, 5

[PULL 04/20] qapi: Drop stray Arguments: line from qmp_capabilities docs

Reported-by: John Snow Fixes: 119ebac1feb2 (qapi-schema: use generated marshaller for 'qmp_capabilities') Signed-off-by: Markus Armbruster Message-ID: <20240322140910.328840-2-arm...@redhat.com> Reviewed-by: John Snow --- qapi/control.json | 2 -- 1 file changed, 2 deletions(-) diff --git

[PULL 08/20] qapi: Fix argument markup in drive-mirror documentation

Signed-off-by: Markus Armbruster Message-ID: <20240322140910.328840-6-arm...@redhat.com> --- qapi/block-core.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 1874f880a8..64668b080d 100644 --- a/qapi/block-core.json +++

[PULL 18/20] qapi: document leftover members in qapi/stats.json

From: Paolo Bonzini Suggested-by: Markus Armbruster Signed-off-by: Paolo Bonzini Message-ID: <20240325104504.1358734-1-pbonz...@redhat.com> Reviewed-by: Markus Armbruster [Update qapi/pragma.json] Signed-off-by: Markus Armbruster --- qapi/pragma.json | 5 + qapi/stats.json | 14

[PULL 07/20] qapi: Tidy up indentation of add_client's example

Commit d23055b8db8 (qapi: Require descriptions and tagged sections to be indented) indented add_client's example too much. Revert that. Signed-off-by: Markus Armbruster Message-ID: <20240322140910.328840-5-arm...@redhat.com> [Move a stray hunk to the later patch it belongs to] ---

[PULL 05/20] qapi: Expand a few awkward abbreviations in documentation

Signed-off-by: Markus Armbruster Message-ID: <20240322140910.328840-3-arm...@redhat.com> --- qapi/replay.json | 4 ++-- qapi/virtio.json | 8 +--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/qapi/replay.json b/qapi/replay.json index 8626fb58f4..d3559f9c8f 100644 ---

Re: Let's close member documentation gaps

Markus Armbruster writes: > If you're cc'ed, I have a bit of doc work for you. Search for your > name to find it. > > The QAPI generator forces you to document your stuff. Except for > commands, events, enum and object types listed in pragma > documentation-exceptions, the generator silently

[PATCH for-9.0 0/3] target/hppa: Fix overflow computation for shladd

These ??? notes have been there since day one. This fixes l2diag test 59. r~ Richard Henderson (3): target/hppa: Squash d for pa1.x during decode target/hppa: Replace c with uv in do_cond target/hppa: Fix overflow computation for shladd target/hppa/insns.decode | 20 --

[PATCH 3/3] target/hppa: Fix overflow computation for shladd

Overflow indicator should include the effect of the shift step. We had previously left ??? comments about the issue. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 85 - 1 file changed, 66 insertions(+), 19 deletions(-) diff --git

[PATCH 1/3] target/hppa: Squash d for pa1.x during decode

The cond_need_ext predicate was created while we still had a 32-bit compilation mode. It now makes more sense to treat D as an absolute indicator of a 64-bit operation. Signed-off-by: Richard Henderson --- target/hppa/insns.decode | 20 +--- target/hppa/translate.c | 38

Re: [PATCH] hw/net/net_tx_pkt: Fix virtio header without checksum offloading

On Sun, Mar 24, 2024 at 4:32 PM Akihiko Odaki wrote: > > It is incorrect to have the VIRTIO_NET_HDR_F_NEEDS_CSUM set when > checksum offloading is disabled so clear the bit. Set the > VIRTIO_NET_HDR_F_DATA_VALID bit instead to tell the checksum is valid. > > TCP/UDP checksum is usually offloaded

Re: [External] Re: [PATCH v4 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

On Mon, Mar 25, 2024 at 8:08 PM Huang, Ying wrote: > > "Ho-Ren (Jack) Chuang" writes: > > > On Fri, Mar 22, 2024 at 1:41 AM Huang, Ying wrote: > >> > >> "Ho-Ren (Jack) Chuang" writes: > >> > >> > The current implementation treats emulated memory devices, such as > >> > CXL1.1 type3 memory, as

Re: [PATCH v2] tap-win32: Remove unnecessary stubs

On Mon, Feb 12, 2024 at 10:04 PM Akihiko Odaki wrote: > > Some of them are only necessary for POSIX systems. The others are > assigned to function pointers in NetClientInfo that can actually be > NULL. > > Signed-off-by: Akihiko Odaki > --- > Changes in v2: > - Rebased. > - Link to v1: >

[PULL 15/20] qga/qapi-schema: Refill doc comments to conform to current conventions

For legibility, wrap text paragraphs so every line is at most 70 characters long. To check the generated documentation does not change, I compared the generated HTML before and after this commit with "wdiff -3". Finds no differences. Comparing with diff is not useful, as the refilled paragraphs

[PULL 12/20] qapi: Don't repeat member type in its documentation text

Documentation generated for the arguments of MEMORY_FAILURE looks like "recipient": "MemoryFailureRecipient" recipient is defined as "MemoryFailureRecipient". "action": "MemoryFailureAction" action that has been taken. action is defined as "MemoryFailureAction".

[PULL 03/20] qapi: Fix bogus documentation of query-migrationthreads

The doc comment documents an argument that doesn't exist. Would fail compilation if it was marked up correctly. Delete. The Returns: section fails to refer to the data type, leaving the user to guess. Fix that. The command name violates QAPI naming rules: it should be query-migration-threads.

[RFC v3 4/5] target/arm: Enable feature ARM_FEATURE_EL2 if EL2 is supported

From: Haibo Xu KVM_CAP_ARM_EL2 must be supported by the cpu to enable ARM_FEATURE_EL2. In case the host does support NV, expose the feature. Signed-off-by: Haibo Xu Signed-off-by: Miguel Luis Signed-off-by: Eric Auger --- v2 -> v3: - check pmu->has_el2 on kvm_arch_init_vcpu() when setting

[RFC v3 1/5] [Placeholder] headers: Partial headers update for NV2 enablement

From: Haibo Xu For now let's only import the pieces needed to run NV on KVM. Later on this will be replaced by a standard and comprehensive linux header update using scripts/update-linux-headers.sh. For now the changes are taken from

[RFC v3 0/5] ARM Nested Virt Support

This series adds ARM Nested Virtualization support in KVM mode. This is a respin of previous contributions from Miguel [1] and Haibo [2]. This was tested with Marc's v11 [3] on Ampere HW with fedora L1 guest and L2 guests booted without EDK2. However it does not work yet with EDK2 but it looks

Re: [PATCH v2 1/3] target/hppa: Generate getshadowregs inline

On 3/26/24 19:10, Richard Henderson wrote: This operation is trivial and does not require a helper. Signed-off-by: Richard Henderson Reviewed-by: Helge Deller Helge --- target/hppa/helper.h | 1 - target/hppa/sys_helper.c | 4 ++-- target/hppa/translate.c | 17

Re: [PATCH v2 2/3] target/hppa: Move diag argument handling to decodetree

On 3/26/24 19:10, Richard Henderson wrote: Split trans_diag into per-operation functions. Signed-off-by: Richard Henderson Reviewed-by: Helge Deller Helge --- target/hppa/insns.decode | 8 +++- target/hppa/translate.c | 34 +- 2 files changed, 28

Re: [PATCH-for-9.1] hw/i386: Add a config to only build the microvm machine

On Tue, 26 Mar 2024 19:01:50 +0300 Michael Tokarev wrote: > 26.03.2024 18:58, Philippe Mathieu-Daudé: > > >> This is not enough.  This step is good already, but it lacks default > >> machine > >> type selection.  In debian we carry a tiny patch to make microvm the > >> default > >> machine

Re: [PATCH-for-9.0? v2 1/4] hw/arm/smmu: Avoid using inlined functions with external linkage again

Hi, On 3/26/24 18:10, Philippe Mathieu-Daudé wrote: > Similarly to commit 9de9fa5cf2 ("hw/arm/smmu-common: Avoid using > inlined functions with external linkage"): > > None of our code base require / use inlined functions with external > linkage. Some places use internal inlining in the hot

[PATCH v2 1/3] target/hppa: Generate getshadowregs inline

This operation is trivial and does not require a helper. Signed-off-by: Richard Henderson --- target/hppa/helper.h | 1 - target/hppa/sys_helper.c | 4 ++-- target/hppa/translate.c | 17 + 3 files changed, 15 insertions(+), 7 deletions(-) diff --git

[PATCH v2 3/3] target/hppa: Fix diag instructions to set/restore shadow registers

The 32-bit 7300LC CPU and the 64-bit PCX-W 8500 CPU use different diag instructions to save or restore the CPU registers to/from the shadow registers. Implement those per-CPU architecture diag instructions to fix those parts of the HP ODE testcases (L2DIAG and WDIAG, section 1) which test the

[PATCH v2 2/3] target/hppa: Move diag argument handling to decodetree

Split trans_diag into per-operation functions. Signed-off-by: Richard Henderson --- target/hppa/insns.decode | 8 +++- target/hppa/translate.c | 34 +- 2 files changed, 28 insertions(+), 14 deletions(-) diff --git a/target/hppa/insns.decode

[PATCH v2 0/3] target/hppa: Tidy and extend diag instructions

Don't do all the decode for diag in trans_diag; do it in decodetree instead. Add {get,put}shadowregs for ODE tests. r~ Richard Henderson (3): target/hppa: Generate getshadowregs inline target/hppa: Move diag argument handling to decodetree target/hppa: Fix diag instructions to set/restore

Re: [PATCH v4 9/9] plugins: remove op from qemu_plugin_inline_cb

On 3/26/24 02:34, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- include/qemu/plugin.h | 1 - plugins/plugin.h | 4 +++- plugins/core.c| 13 +++-- 3 files changed, 10 insertions(+), 8 deletions(-) Reviewed-by: Richard Henderson r~

Re: [RFC v3 4/5] target/arm: Enable feature ARM_FEATURE_EL2 if EL2 is supported

On 3/26/24 08:22, Eric Auger wrote: From: Haibo Xu KVM_CAP_ARM_EL2 must be supported by the cpu to enable ARM_FEATURE_EL2. In case the host does support NV, expose the feature. Signed-off-by: Haibo Xu Signed-off-by: Miguel Luis Signed-off-by: Eric Auger --- v2 -> v3: - check pmu->has_el2 on

Endless data flow on i2c bus

Hi, I am simulating an i2c slave device, listening on address 0x30. My intention is that in the hosted Linux OS, my driver will communicate with this (simulated) HW device. The problem I have is that ever since I start QEMU, and even before the hosted Linux OS was fully loaded, the device

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

On Tue, 26 Mar 2024 14:29:58 +0100 Philippe Mathieu-Daudé wrote: > Hi Igor, > > On 26/3/24 14:08, Thomas Huth wrote: > > > > s/iaspc/isapc/ in the subject > > > > On 26/03/2024 13.51, Igor Mammedov wrote: > >> ISAPC machine was introduced 25 years ago and it's a lot of time since > >> such

Re: target/hppa: be,n nullifying first insn at branch target?

Richard Henderson writes: > On 3/25/24 09:33, Sven Schnelle wrote: >> diff --git a/target/hppa/translate.c b/target/hppa/translate.c >> index 7546a5f5a2..56c68a7cbe 100644 >> --- a/target/hppa/translate.c >> +++ b/target/hppa/translate.c >> @@ -3847,7 +3849,7 @@ static bool trans_be(DisasContext

Re: [PATCH for-9.0 1/3] qtest/virtio-9p-test.c: consolidate create dir, file and symlink tests

On 3/26/24 14:05, Greg Kurz wrote: On Tue, 26 Mar 2024 10:26:04 -0300 Daniel Henrique Barboza wrote: The local 9p driver in virtio-9p-test.c its temporary dir right at the start of qos-test (via virtio_9p_create_local_test_dir()) and only deletes it after qos-test is finished (via

Re: [PATCH for-9.0 0/3] qtest/virtio-9p-test.c: fix slow tests

On 3/26/24 12:55, Greg Kurz wrote: Bom dia Daniel ! Bonne après-midi ! On Tue, 26 Mar 2024 10:26:03 -0300 Daniel Henrique Barboza wrote: Hi, Thomas reported in [1] a problem that happened with the RISC-V machine where some tests from virtio-9p-test.c were failing with '-m slow', i.e.

Re: [RFC 0/8] virtio,vhost: Add VIRTIO_F_IN_ORDER support

On 3/25/24 4:33 PM, Eugenio Perez Martin wrote: On Mon, Mar 25, 2024 at 5:52 PM Jonah Palmer wrote: On 3/22/24 7:18 AM, Eugenio Perez Martin wrote: On Thu, Mar 21, 2024 at 4:57 PM Jonah Palmer wrote: The goal of these patches is to add support to a variety of virtio and vhost devices

Re: [PATCH v2 1/2] hw/xen: detect when running inside stubdomain

On Tue, Mar 05, 2024 at 08:12:29PM +0100, Marek Marczykowski-Górecki wrote: > diff --git a/hw/xen/xen-legacy-backend.c b/hw/xen/xen-legacy-backend.c > index 124dd5f3d6..6bd4e6eb2f 100644 > --- a/hw/xen/xen-legacy-backend.c > +++ b/hw/xen/xen-legacy-backend.c > @@ -603,6 +603,20 @@ static void

Re: [PATCH-for-9.0? v2 4/4] meson: Enable -Wstatic-in-inline

On 26/03/2024 18.10, Philippe Mathieu-Daudé wrote: Compilers are clever enough to inline code when necessary. The only case we accept an inline function is static in header (we use C, not C++). Add the -Wstatic-in-inline CPPFLAG to prevent public and I think this is rather a compiler than a

Re: [PATCH v2 3/3] target/hppa: Fix diag instructions to set/restore shadow registers

On 3/26/24 19:10, Richard Henderson wrote: The 32-bit 7300LC CPU and the 64-bit PCX-W 8500 CPU use different I initially should have used the correct naming in my patch. So this sentence above should read: The 32-bit PA-7300LC (PCX-L2) CPU and the 64-bit PA8700 (PCX-W2) CPU use different

[PATCH-for-9.0? v2 4/4] meson: Enable -Wstatic-in-inline

Compilers are clever enough to inline code when necessary. The only case we accept an inline function is static in header (we use C, not C++). Add the -Wstatic-in-inline CPPFLAG to prevent public and inline function to be added in the code base. Signed-off-by: Philippe Mathieu-Daudé

[PATCH-for-9.0? v2 1/4] hw/arm/smmu: Avoid using inlined functions with external linkage again

Similarly to commit 9de9fa5cf2 ("hw/arm/smmu-common: Avoid using inlined functions with external linkage"): None of our code base require / use inlined functions with external linkage. Some places use internal inlining in the hot path. These two functions are certainly not in any hot path

[PATCH-for-9.0? v2 2/4] accel/hvf: Un-inline hvf_arch_supports_guest_debug()

See previous commit and commit 9de9fa5cf2 ("Avoid using inlined functions with external linkage") for rationale. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Reviewed-by: Richard Henderson Message-Id: <20240313184954.42513-3-phi...@linaro.org> --- target/arm/hvf/hvf.c | 2

[PATCH-for-9.0? v2 3/4] qtest/libqos: Reduce size_to_prdtl() declaration scope

Since size_to_prdtl() is only used within ahci.c, declare it statically. This removes the last use of "inlined function with external linkage". See previous commit and commit 9de9fa5cf2 for rationale. Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé ---

Re: [PATCH v2 2/2] xen: fix stubdom PCI addr

First things first, could you fix the coding style? Run something like `./scripts/checkpatch.pl @^..` or `./scripts/checkpatch.pl master..`. Patchew might have run that for you if the patch series had a cover letter. On Tue, Mar 05, 2024 at 08:12:30PM +0100, Marek Marczykowski-Górecki wrote: >

Re: [PULL 0/6] Block layer patches

On Tue, 26 Mar 2024 at 13:54, Kevin Wolf wrote: > > The following changes since commit 096ae430a7b5a704af4cd94dca7200d6cb069991: > > Merge tag 'pull-qapi-2024-03-26' of https://repo.or.cz/qemu/armbru into > staging (2024-03-26 09:50:21 +) > > are available in the Git repository at: > >

Re: [PULL 00/13] Misc HW patches for 2024-03-26

in the Git repository at: > > https://github.com/philmd/qemu.git tags/hw-misc-20240326 > > for you to fetch changes up to ccebb9ae352eea63cb1491cb829e4cd0f7576f1c: > > ui/cocoa: Use NSTrackingInVisibleRect (2024-03-26 14:32:54 +0100) > > A pair of "WARNI

Re: [PATCH] tests/qtest: Standardize qtest function caller strings.

Hi Maintainers, this is my first attempt trying to standardise the grammar around migration qtests. I am not sure at multiple places on whether a particular string is placed at the right place with the right grammar. Please comment on the patch, if anything you feel can be improvised in the

Re: [PATCH for-9.0 0/3] qtest/virtio-9p-test.c: fix slow tests

On 26/03/2024 14.26, Daniel Henrique Barboza wrote: Hi, Thomas reported in [1] a problem that happened with the RISC-V machine where some tests from virtio-9p-test.c were failing with '-m slow', i.e. enabling slow tests. In the end it wasn't a RISC-V specific problem. It just so happens that

Re: [PATCH-for-9.0? v2 3/4] qtest/libqos: Reduce size_to_prdtl() declaration scope

On Tue, 26 Mar 2024 at 17:10, Philippe Mathieu-Daudé wrote: > > Since size_to_prdtl() is only used within ahci.c, > declare it statically. This removes the last use > of "inlined function with external linkage". See > previous commit and commit 9de9fa5cf2 for rationale. > > Suggested-by: Peter

Re: [RFC 0/8] virtio,vhost: Add VIRTIO_F_IN_ORDER support

On Tue, Mar 26, 2024 at 5:49 PM Jonah Palmer wrote: > > > > On 3/25/24 4:33 PM, Eugenio Perez Martin wrote: > > On Mon, Mar 25, 2024 at 5:52 PM Jonah Palmer > > wrote: > >> > >> > >> > >> On 3/22/24 7:18 AM, Eugenio Perez Martin wrote: > >>> On Thu, Mar 21, 2024 at 4:57 PM Jonah Palmer > >>>

[PATCH for-9.0] target/hppa: Clear psw_n for BE on use_nullify_skip path

Along this path we have already skipped the insn to be nullified, so the subsequent insn should be executed. Cc: qemu-sta...@nongnu.org Reported-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH] tests/qtest: Standardize qtest function caller strings.

Het Gala writes: Some comments, mostly just thinking out loud... > For --> migrate > // > //O:/... > > For --> validate > ///O:/O:/ > /O:/O:/... Do we need an optional 'capability' element? I'm not sure how practical is to leave that as 'others', because that puts it at the end of the

Re: [PATCH-for-9.1] hw/i386: Add a config to only build the microvm machine

On Tue, 26 Mar 2024 at 16:03, Michael Tokarev wrote: > > 26.03.2024 18:58, Philippe Mathieu-Daudé: > > >> This is not enough. This step is good already, but it lacks default > >> machine > >> type selection. In debian we carry a tiny patch to make microvm the > >> default > >> machine type or

[PATCH-for-9.0? v2 0/4] overall: Avoid using inlined functions with external linkage again

Oops, I forgot patch 3 needed rework :/ Is it too late to enforce that flag for 9.0? Missing review: #3 Since v1: - Reduce size_to_prdtl() scope Mostly as a C style cleanup, use -Wstatic-in-inline to avoid using inlined function with external linkage. Philippe Mathieu-Daudé (4): hw/arm/smmu:

Re: [RFC v3 5/5] hw/arm/virt: Allow virt extensions with KVM

On 3/26/24 08:22, Eric Auger wrote: From: Haibo Xu Up to now virt support on guest has been only supported with TCG. Now it becomes feasible to use it with KVM acceleration. Also check only in-kernel GICv3 is used along with KVM EL2. Signed-off-by: Haibo Xu Signed-off-by: Miguel Luis

Re: [PATCH for-9.0] target/hppa: Clear psw_n for BE on use_nullify_skip path

On 26/3/24 19:35, Richard Henderson wrote: Along this path we have already skipped the insn to be nullified, so the subsequent insn should be executed. Cc: qemu-sta...@nongnu.org Reported-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 1 + 1 file changed,

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

On Tue, 26 Mar 2024 13:30:48 + Mark Cave-Ayland wrote: > On 26/03/2024 12:51, Igor Mammedov wrote: > > > ISAPC machine was introduced 25 years ago and it's a lot of time since > > such machine was around with real ISA only PC hardware practically defunct. > > Also it's slowly bit-rots (for

Re: [PATCH for-9.0 1/3] qtest/virtio-9p-test.c: consolidate create dir, file and symlink tests

On Tue, 26 Mar 2024 10:26:04 -0300 Daniel Henrique Barboza wrote: > The local 9p driver in virtio-9p-test.c its temporary dir right at the > start of qos-test (via virtio_9p_create_local_test_dir()) and only > deletes it after qos-test is finished (via > virtio_9p_remove_local_test_dir()). > >

Re: [PATCH-for-9.0? v2 3/4] qtest/libqos: Reduce size_to_prdtl() declaration scope

On 26/03/2024 18.10, Philippe Mathieu-Daudé wrote: Since size_to_prdtl() is only used within ahci.c, declare it statically. This removes the last use of "inlined function with external linkage". See previous commit and commit 9de9fa5cf2 for rationale. Suggested-by: Peter Maydell Signed-off-by:

Re: [PATCH v5 1/7] docs/migration: add qpl compression feature

On Wed, Mar 20, 2024 at 12:45:21AM +0800, Yuan Liu wrote: > add Intel Query Processing Library (QPL) compression method > introduction > > Signed-off-by: Yuan Liu > Reviewed-by: Nanhai Zou > --- > docs/devel/migration/features.rst| 1 + > docs/devel/migration/qpl-compression.rst |

[RFC v3 2/5] hw/arm: Allow setting KVM vGIC maintenance IRQ

From: Haibo Xu Allow virt arm machine to set the interrupt ID for the KVM GIC maintenance interrupt. This setting must be done before the KVM_DEV_ARM_VGIC_CTRL_INIT hence the choice to perform the setting in the GICv3 realize instead of proceeding the same way as kvm_arm_pmu_set_irq().

[RFC v3 3/5] target/arm/kvm: Add helper to detect EL2 when using KVM

From: Haibo Xu Introduce query support for KVM_CAP_ARM_EL2. Signed-off-by: Haibo Xu Signed-off-by: Miguel Luis Signed-off-by: Eric Auger Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- target/arm/kvm.c | 5 + target/arm/kvm_arm.h | 12 2 files

[RFC v3 5/5] hw/arm/virt: Allow virt extensions with KVM

From: Haibo Xu Up to now virt support on guest has been only supported with TCG. Now it becomes feasible to use it with KVM acceleration. Also check only in-kernel GICv3 is used along with KVM EL2. Signed-off-by: Haibo Xu Signed-off-by: Miguel Luis Signed-off-by: Eric Auger --- v2 -> v3: -

Re: [PATCH v4 6/9] tests/plugin/inline: add test for conditional callback

On 3/26/24 02:34, Pierrick Bouvier wrote: Count number of tb and insn executed using a conditional callback. We ensure the callback has been called expected number of time (per vcpu). Signed-off-by: Pierrick Bouvier --- tests/plugin/inline.c | 89 +--

Re: [RFC 0/8] virtio,vhost: Add VIRTIO_F_IN_ORDER support

On 3/26/24 2:34 PM, Eugenio Perez Martin wrote: On Tue, Mar 26, 2024 at 5:49 PM Jonah Palmer wrote: On 3/25/24 4:33 PM, Eugenio Perez Martin wrote: On Mon, Mar 25, 2024 at 5:52 PM Jonah Palmer wrote: On 3/22/24 7:18 AM, Eugenio Perez Martin wrote: On Thu, Mar 21, 2024 at 4:57 PM

Re: [PATCH for-9.0] target/hppa: Clear psw_n for BE on use_nullify_skip path

Richard Henderson writes: > Along this path we have already skipped the insn to be > nullified, so the subsequent insn should be executed. > > Cc: qemu-sta...@nongnu.org > Reported-by: Sven Schnelle > Signed-off-by: Richard Henderson > --- > target/hppa/translate.c | 1 + > 1 file changed, 1

[PATCH] tests/qtest: Standardize qtest function caller strings.

For --> migrate // //O:/... For --> validate ///O:/O:/ /O:/O:/... test-type:: migrate | validate migration-mode a. migrate --> :: precopy | postcopy | multifd b. validate -->:: (what to validate) methods :: preempt | recovery | reboot | suspend | simple

Re: [PATCH v2 1/2] hw/xen: detect when running inside stubdomain

On Tue, Mar 26, 2024 at 05:06:50PM +, Anthony PERARD wrote: > On Tue, Mar 05, 2024 at 08:12:29PM +0100, Marek Marczykowski-Górecki wrote: > > diff --git a/hw/xen/xen-legacy-backend.c b/hw/xen/xen-legacy-backend.c > > index 124dd5f3d6..6bd4e6eb2f 100644 > > --- a/hw/xen/xen-legacy-backend.c > >

[PATCH v3 0/2] Changes necessary to work inside Xen device model stubdomain

This is minimal set of changes necessary to run Xen device model inside a stubdomain and still support PCI passthrough. Marek Marczykowski-Górecki (2): hw/xen: detect when running inside stubdomain xen: fix stubdom PCI addr hw/i386/xen/xen-hvm.c| 22 +++-

Re: [PATCH-for-9.1 v2 1/3] gdbstub: Simplify #ifdef'ry in helpers.h

On 3/22/24 06:14, Philippe Mathieu-Daudé wrote: Slightly simplify by checking NEED_CPU_H definition in header. Signed-off-by: Philippe Mathieu-Daudé --- include/gdbstub/helpers.h | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH for-9.1 v5 2/3] target/i386: add guest-phys-bits cpu property

On 3/25/2024 10:14 PM, Paolo Bonzini wrote: From: Gerd Hoffmann Allows to set guest-phys-bits (cpuid leaf 8008, eax[23:16]) via -cpu $model,guest-phys-bits=$nr. Signed-off-by: Gerd Hoffmann Message-ID: <20240318155336.156197-3-kra...@redhat.com> Signed-off-by: Paolo Bonzini

Re: [PATCH] hw/net/net_tx_pkt: Fix virtio header without checksum offloading

On Wed, Mar 27, 2024 at 10:53 AM Akihiko Odaki wrote: > > On 2024/03/27 11:50, Jason Wang wrote: > > On Tue, Mar 26, 2024 at 3:04 PM Akihiko Odaki > > wrote: > >> > >> On 2024/03/26 15:51, Jason Wang wrote: > >>> On Sun, Mar 24, 2024 at 4:32 PM Akihiko Odaki > >>> wrote: > > It is

Re: [PULL 35/38] spapr: nested: Introduce H_GUEST_[GET|SET]_STATE hcalls.

On 3/26/24 21:32, Peter Maydell wrote: On Tue, 12 Mar 2024 at 17:11, Nicholas Piggin wrote: From: Harsh Prateek Bora Introduce the nested PAPR hcalls: - H_GUEST_GET_STATE which is used to get state of a nested guest or a guest VCPU. The value field for each element in the

[PATCH for-9.0] tcg/optimize: Fix sign_mask for logical right-shift

The 'sign' computation is attempting to locate the sign bit that has been repeated, so that we can test if that bit is known zero. That computation can be zero if there are no known sign repetitions. Cc: qemu-sta...@nongnu.org Fixes: 93a967fbb57 ("tcg/optimize: Propagate sign info for shifting")

Re: [PATCH] hw/net/net_tx_pkt: Fix virtio header without checksum offloading

On 2024/03/27 12:06, Jason Wang wrote: On Wed, Mar 27, 2024 at 11:05 AM Akihiko Odaki wrote: On 2024/03/27 11:59, Jason Wang wrote: On Wed, Mar 27, 2024 at 10:53 AM Akihiko Odaki wrote: On 2024/03/27 11:50, Jason Wang wrote: On Tue, Mar 26, 2024 at 3:04 PM Akihiko Odaki wrote: On

Re: [PATCH] hw/net/net_tx_pkt: Fix virtio header without checksum offloading

On 2024/03/27 12:24, Jason Wang wrote: On Wed, Mar 27, 2024 at 11:11 AM Akihiko Odaki wrote: On 2024/03/27 12:06, Jason Wang wrote: On Wed, Mar 27, 2024 at 11:05 AM Akihiko Odaki wrote: On 2024/03/27 11:59, Jason Wang wrote: On Wed, Mar 27, 2024 at 10:53 AM Akihiko Odaki wrote: On

Re: [PATCH-for-9.1 v2 3/3] exec: Rename NEED_CPU_H -> COMPILING_PER_TARGET

On 3/22/24 06:14, Philippe Mathieu-Daudé wrote: 'NEED_CPU_H' guard target-specific code; it is defined by meson altogether with the 'CONFIG_TARGET' definition. Rename NEED_CPU_H as COMPILING_PER_TARGET to clarify its meaning. Mechanical change running: $ sed -i

RE: [PATCH v3] contrib/plugins/execlog: Fix compiler warning

> -Original Message- > From: Philippe Mathieu-Daudé > Sent: Tuesday, March 26, 2024 8:04 PM > To: Peter Maydell > Cc: Pierrick Bouvier ; Yao, Xingtao/姚 幸涛 > ; qemu-devel@nongnu.org; alex.ben...@linaro.org; > erdn...@crans.org; ma.mando...@gmail.com > Subject: Re: [PATCH v3]

RE: [PATCH v5 1/7] docs/migration: add qpl compression feature

> -Original Message- > From: Peter Xu > Sent: Wednesday, March 27, 2024 1:58 AM > To: Liu, Yuan1 > Cc: faro...@suse.de; qemu-devel@nongnu.org; hao.xi...@bytedance.com; > bryan.zh...@bytedance.com; Zou, Nanhai > Subject: Re: [PATCH v5 1/7] docs/migration: add qpl compression feature >

Re: [PATCH] hw/net/net_tx_pkt: Fix virtio header without checksum offloading

On 2024/03/27 11:50, Jason Wang wrote: On Tue, Mar 26, 2024 at 3:04 PM Akihiko Odaki wrote: On 2024/03/26 15:51, Jason Wang wrote: On Sun, Mar 24, 2024 at 4:32 PM Akihiko Odaki wrote: It is incorrect to have the VIRTIO_NET_HDR_F_NEEDS_CSUM set when checksum offloading is disabled so clear

Re: [PATCH] hw/net/net_tx_pkt: Fix virtio header without checksum offloading

On Tue, Mar 26, 2024 at 3:04 PM Akihiko Odaki wrote: > > On 2024/03/26 15:51, Jason Wang wrote: > > On Sun, Mar 24, 2024 at 4:32 PM Akihiko Odaki > > wrote: > >> > >> It is incorrect to have the VIRTIO_NET_HDR_F_NEEDS_CSUM set when > >> checksum offloading is disabled so clear the bit. Set the

Re: [RFC 0/2] disable the configuration interrupt for the unsupported device

Hi Cindy: On Wed, Mar 27, 2024 at 9:29 AM Cindy Lu wrote: > > we need a crash in Non-standard image, here is the jira for this > https://issues.redhat.com/browse/RHEL-28522 > The root cause of the issue is that an IRQFD was used without initialization.. > > During the booting process of the

Re: [PATCH] hw/net/net_tx_pkt: Fix virtio header without checksum offloading

On 2024/03/27 11:59, Jason Wang wrote: On Wed, Mar 27, 2024 at 10:53 AM Akihiko Odaki wrote: On 2024/03/27 11:50, Jason Wang wrote: On Tue, Mar 26, 2024 at 3:04 PM Akihiko Odaki wrote: On 2024/03/26 15:51, Jason Wang wrote: On Sun, Mar 24, 2024 at 4:32 PM Akihiko Odaki wrote: It is

Re: [PATCH v5 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

"Ho-Ren (Jack) Chuang" writes: > The current implementation treats emulated memory devices, such as > CXL1.1 type3 memory, as normal DRAM when they are emulated as normal memory > (E820_TYPE_RAM). However, these emulated devices have different > characteristics than traditional DRAM, making it

[PATCH v2 1/2] virtio-net: Fix vhost virtqueue notifiers for RSS

virtio_net_guest_notifier_pending() and virtio_net_guest_notifier_mask() checked VIRTIO_NET_F_MQ to know there are multiple queues, but VIRTIO_NET_F_RSS also enables multiple queues. Refer to n->multiqueue, which is set to true either of VIRTIO_NET_F_MQ or VIRTIO_NET_F_RSS is enabled. Fixes:

  1   2   3   >