RE: [RFC PATCH v2 20/67] Hexagon instruction utility functions

2020-04-09 Thread Brian Cain
> -Original Message- > From: Qemu-devel bounces+bcain=codeaurora@nongnu.org> On Behalf Of Taylor Simpson > Sent: Friday, February 28, 2020 10:43 AM > To: qemu-devel@nongnu.org > Cc: riku.voi...@iki.fi; richard.hender...@linaro.org; laur...@vivier.eu; > Taylor Simpson ;

RE: Known issue? qemu is much slower when built with clang vs gcc

2020-08-24 Thread Brian Cain
: Brian Cain Subject: Known issue? qemu is much slower when built with clang vs gcc We're seeing significant slowdowns when we build qemu with clang instead of gcc. I'm hoping this is a known issue and there is a workaround or fix. Please advise. I have an example where qemu is 29X slower when

RE: [EXT] Re: [RFC PATCH v3 00/34] Hexagon patch series

2020-09-14 Thread Brian Cain
> -Original Message- > From: Qemu-devel > On Behalf Of Rob Landley ... > > On 8/30/20 3:47 PM, Taylor Simpson wrote: > > Richard, > > > > Thank you so much for the feedback. I really appreciate it. > > > > I'll get to work addressing the issues. Since some of the items will take > >

hexagon sysemu - library loading path feature

2020-12-16 Thread Brian Cain
My team is working on sysemu support for Hexagon. We've made some good progress so far and we'll work on upstreaming after Taylor’s hexagon linux-user patch series lands. The only use case we have focused on with sysemu is booting/running elf programs. Both "-device loader,file=..." or

RE: [PATCH v7 00/35] Hexagon patch series

2021-01-25 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Monday, January 25, 2021 5:09 PM > To: Philippe Mathieu-Daudé ; qemu-devel@nongnu.org > Cc: richard.hender...@linaro.org; alex.ben...@linaro.org; > laur...@vivier.eu; a...@rev.ng; Brian Cain > Subject: RE: [PATCH v7

RE: [PATCH v1 08/25] gitlab: add build-user-hexagon test

2021-05-11 Thread Brian Cain
> -Original Message- > From: Alex Bennée ... > Which leads to the compiler complaining: > > hexagon-unknown-linux-musl-clang -Wno-incompatible-pointer-types - > Wno-undefined-internal -fno-unroll-loops -Wall -Werror -O0 -g -fno-strict- > aliasing -mv67 -O2 -static /home >

RE: [PATCH v1 08/25] gitlab: add build-user-hexagon test

2021-05-11 Thread Brian Cain
> -Original Message- > From: Brian Cain ... > > I suspect the easiest thing to do is to drop the patches again so I > > don't hold up the rest of testing/next. I can include the initial > > docker image patch but I won't enable it in configure.sh/gitlab. > >

RE: [PATCH 01/20] Hexagon HVX (target/hexagon) README

2021-07-12 Thread Brian Cain
> -Original Message- > From: Rob Landley > Sent: Monday, July 12, 2021 3:16 AM ... > Except the LLVM_ENABLE_LLD part breaks with a standard debian/devuan x86- > 64 host > toolchain because it ONLY works with host llvm, and apparently only a pretty > current one at that: > >

RE: sysemu SMP scheduling

2021-04-28 Thread Brian Cain
> -Original Message- > From: Brian Cain > Sent: Wednesday, April 28, 2021 10:06 PM > To: qemu-devel@nongnu.org > Cc: Richard Henderson ; Taylor Simpson > ; Michael Lambert ; > Manning, Sid > Subject: sysemu SMP scheduling > > For some hexagon use cases,

sysemu SMP scheduling

2021-04-28 Thread Brian Cain
For some hexagon use cases, we would prefer to have finer grained scheduling among multiple guest cores/threads. We haven't been able to determine exactly what kind of scheduling algorithm is operating in the baseline case. If the current hw thread is ready-to-run and is spinning over a tight

testing/next - hexagon toolchain update

2021-04-03 Thread Brian Cain
rom 68547357c895934796e9b4687338bb9e39ac86c5 Mon Sep 17 00:00:00 2001 From: Brian Cain mailto:bc...@quicinc.com Date: Thu, 1 Apr 2021 10:32:24 -0500 Subject: [PATCH] Update llvm-project commit clang was updated with new inline asm registers for hexagon, this is necessary for QEMU test cases currently under rev

gitlab outage?

2021-03-12 Thread Brian Cain
https://gitlab.com/qemu-project/ asks for sign in and if I do sign in, I get a 404. Is this expected? https://status.gitlab.com/ describes "shared runner degradation" but that doesn't sound like this problem. -Brian

RE: [PATCH 1/4] docker: Add Hexagon image

2021-03-01 Thread Brian Cain
Reviewed-by: Brian Cain > -Original Message- > From: Philippe Mathieu-Daudé On > Behalf Of Philippe Mathieu-Daudé > Sent: Sunday, February 28, 2021 4:23 PM > To: qemu-devel@nongnu.org > Cc: Fam Zheng ; Taylor Simpson > ; Philippe Mathieu-Daudé ; > Alex Bennée

RE: [PATCH v8 35/35] Add Dockerfile for hexagon

2021-02-27 Thread Brian Cain
> -Original Message- > From: Philippe Mathieu-Daudé On > Behalf Of Philippe Mathieu-Daudé > Sent: Saturday, February 27, 2021 8:10 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: richard.hender...@linaro.org; alex.ben...@linaro.org; > laur...@vivier.eu; a...@rev

RE: hexagon sysemu - library loading path feature

2021-02-18 Thread Brian Cain
> -Original Message- > From: Alex Bennée > Sent: Tuesday, February 16, 2021 5:18 AM > To: Philippe Mathieu-Daudé > Cc: Brian Cain ; qemu-devel@nongnu.org; Michael > Lambert ; Sid Manning ; > Laurent Vivier > Subject: [EXT] Re: hexagon sysemu - library loading pat

RE: [qemu-hexagon] Error mapping file: Invalid argument

2021-09-13 Thread Brian Cain
> -Original Message- > From: Philippe Mathieu-Daudé On > Behalf Of Philippe Mathieu-Daudé > Sent: Monday, September 13, 2021 3:19 PM > To: Waksmanski, Lukasz ; qemu- > de...@nongnu.org > Cc: Taylor Simpson ; Brian Cain > > Subject: Re: [qemu-hexagon] Error map

hexagon container update

2021-10-01 Thread Brian Cain
Alex, We need to update the docker container used for hexagon for new test cases proposed in Taylor's recent patch series under review. Thankfully, CodeLinaro has provided a binary of the hexagon cross toolchain so now I think we can simplify the hexagon docker file to something like the

RE: hexagon container update

2021-10-01 Thread Brian Cain
> -Original Message- > From: Brian Cain ... > > -Original Message- > > From: Richard Henderson > ... > > On 10/1/21 12:59 PM, Brian Cain wrote: > > > Alex, > > > > > > We need to update the docker container used for hexago

RE: hexagon container update

2021-10-01 Thread Brian Cain
> -Original Message- > From: Richard Henderson ... > On 10/1/21 12:59 PM, Brian Cain wrote: > > Alex, > > > > We need to update the docker container used for hexagon for new test cases > proposed in Taylor's recent patch series under review. Thankfully, Code

RE: [PATCH v2 for 6.2?] gicv3: fix ICH_MISR's LRENP computation

2021-12-07 Thread Brian Cain
> -Original Message- > From: Peter Maydell ... > On Tue, 7 Dec 2021 at 15:18, Brian Cain wrote: > > Peter Maydell wrote: > > > I won't try to put this into 6.2 unless you have a common guest > > > that runs into this bug. > > > I know th

RE: [PATCH v2 for 6.2?] gicv3: fix ICH_MISR's LRENP computation

2021-12-07 Thread Brian Cain
> -Original Message- > From: Qemu-devel > On Behalf Of Peter Maydell ... > On Tue, 7 Dec 2021 at 09:44, Damien Hedde > wrote: > > > > According to the "Arm Generic Interrupt Controller Architecture > > Specification GIC architecture version 3 and 4" (version G: page 345 > > for aarch64

RE: [PATCH 01/20] Hexagon HVX (target/hexagon) README

2021-07-19 Thread Brian Cain
> -Original Message- > From: Rob Landley ... > On 7/12/21 8:42 AM, Brian Cain wrote: ... > > and there's also a binary hexagon-linux cross toolchain that > > we shared for use by kernel developers. The hexagon linux > > toolchain is built on Ubuntu 16.04. &g

[ Job Ad ] Qualcomm hiring developers to work on QEMU

2022-02-24 Thread Brian Cain
/* moderators - this is a job ad, please discard if it's not permitted by the community */ Qualcomm has openings for developers to help work on QEMU for the Hexagon DSP. If you like QEMU and are interested in challenging work, please apply!

RE: hexagon container update

2022-01-14 Thread Brian Cain
> -Original Message- > From: Brian Cain > Sent: Friday, October 1, 2021 7:23 PM > To: Richard Henderson ; Alex Bennée > ; qemu-devel@nongnu.org > Cc: Taylor Simpson > Subject: RE: hexagon container update > > > -Original Message- > > From:

RE: hexagon container update

2022-01-18 Thread Brian Cain
> -Original Message- > From: Brian Cain > Sent: Tuesday, January 18, 2022 9:25 AM > To: Alex Bennée > Cc: Richard Henderson ; qemu- > de...@nongnu.org; Taylor Simpson > Subject: RE: hexagon container update > > > -Original Message- > > Fr

RE: hexagon container update

2022-01-18 Thread Brian Cain
> -Original Message- > From: Alex Bennée .. > Brian Cain writes: > ... > > We had some issues with the previous attempt to update the container. > > The linux-user "signals" test failed. Richard pointed out that the > > archive of the C library

RE: [PATCH 0/1] Enable -Wshadow=local

2023-10-26 Thread Brian Cain
> -Original Message- > From: Stefan Hajnoczi > Sent: Thursday, October 26, 2023 7:52 PM > To: Markus Armbruster > Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; > marcandre.lur...@redhat.com; berra...@redhat.com; th...@redhat.com; > phi...@linaro.org; Brian C

RE: [PATCH v2 07/16] target/hexagon: Declare QOM definitions in 'cpu-qom.h'

2023-10-26 Thread Brian Cain
- > ri...@nongnu.org; Palmer Dabbelt ; Yoshinori Sato > ; Bastian Koppelmann paderborn.de>; Bin Meng ; Daniel Henrique > Barboza ; Mark Cave-Ayland ayl...@ilande.co.uk>; Weiwei Li ; Daniel Henrique > Barboza ; Nicholas Piggin > ; qemu-...@nongnu.org; Liu Zhiwei > ; Marek Vasut

[PULL 2/2] target/hexagon: fix some occurrences of -Wshadow=local

2023-10-18 Thread Brian Cain
ino Signed-off-by: Brian Cain Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20231008220945.983643-3-bc...@quicinc.com> --- target/hexagon/imported/alu.idef | 6 +++--- target/hexagon/mmvec/macros.h| 2 +- target/hexagon/op_helper.c | 9 +++-- target/hexagon/translate.c

[PULL 0/2] hex queue - GETPC() fixes, shadowing fixes

2023-10-18 Thread Brian Cain
Brian Cain (1): target/hexagon: fix some occurrences of -Wshadow=local Matheus Tavares Bernardino (1): target/hexagon: move GETPC() calls to top level helpers target/hexagon/imported/alu.idef | 6 +-- target/hexagon/macros.h | 19 + target/hexagon

[PULL 1/2] target/hexagon: move GETPC() calls to top level helpers

2023-10-18 Thread Brian Cain
: <2c74c3696946edba7cc5b2942cf296a5af532052.1689070412.git.quic_mathb...@quicinc.com>-ne Reviewed-by: Brian Cain Signed-off-by: Brian Cain Message-Id: <20231008220945.983643-2-bc...@quicinc.com> --- target/hexagon/macros.h| 19 +- target/hexagon/op_h

[PULL 1/2] target/hexagon: move GETPC() calls to top level helpers

2023-10-03 Thread Brian Cain
: <2c74c3696946edba7cc5b2942cf296a5af532052.1689070412.git.quic_mathb...@quicinc.com>-ne Reviewed-by: Brian Cain Signed-off-by: Brian Cain --- target/hexagon/macros.h| 19 +- target/hexagon/op_helper.c | 75 +++--- target/hexagon/op_helper.h | 9 - 3

[PULL 2/2] target/hexagon: fix some occurrences of -Wshadow=local

2023-10-03 Thread Brian Cain
ino Signed-off-by: Brian Cain --- target/hexagon/imported/alu.idef | 6 +++--- target/hexagon/mmvec/macros.h| 2 +- target/hexagon/op_helper.c | 9 +++-- target/hexagon/translate.c | 10 +- 4 files changed, 12 insertions(+), 15 deletions(-) diff --git a/target/hexa

[PULL 0/2] hex queue

2023-10-03 Thread Brian Cain
Brian Cain (1): target/hexagon: fix some occurrences of -Wshadow=local Matheus Tavares Bernardino (1): target/hexagon: move GETPC() calls to top level helpers target/hexagon/imported/alu.idef | 6 +-- target/hexagon/macros.h | 19 + target/hexagon/mmvec/macros.h| 2

[PATCH 1/2] target/hexagon: move GETPC() calls to top level helpers

2023-10-04 Thread Brian Cain
: <2c74c3696946edba7cc5b2942cf296a5af532052.1689070412.git.quic_mathb...@quicinc.com>-ne Reviewed-by: Brian Cain --- target/hexagon/macros.h| 19 +- target/hexagon/op_helper.c | 75 +++--- target/hexagon/op_helper.h | 9 - 3 files changed, 38 insertions(

[PATCH 0/2] Fix usage of GETPC(), variable shadowing

2023-10-04 Thread Brian Cain
Matheus' patch has previously been reviewed, but I based my -Wshadow patch on his. So I'm submitting the series for review. Brian Cain (1): target/hexagon: fix some occurrences of -Wshadow=local Matheus Tavares Bernardino (1): target/hexagon: move GETPC() calls to top level helpers target

[PATCH 2/2] target/hexagon: fix some occurrences of -Wshadow=local

2023-10-04 Thread Brian Cain
ino Signed-off-by: Brian Cain --- target/hexagon/imported/alu.idef | 6 +++--- target/hexagon/mmvec/macros.h| 2 +- target/hexagon/op_helper.c | 9 +++-- target/hexagon/translate.c | 10 +- 4 files changed, 12 insertions(+), 15 deletions(-) diff --git a/target/hexa

RE: [PULL 0/2] hex queue

2023-10-04 Thread Brian Cain
> -Original Message- > From: Markus Armbruster > Sent: Wednesday, October 4, 2023 2:38 AM > To: Brian Cain > Cc: qemu-devel@nongnu.org; richard.hender...@linaro.org; > phi...@linaro.org; peter.mayd...@linaro.org; Matheus Bernardino (QUIC) > ; stefa...@re

[PATCH v3 2/3] target/hexagon: fix some occurrences of -Wshadow=local

2023-10-08 Thread Brian Cain
ino Signed-off-by: Brian Cain --- target/hexagon/imported/alu.idef | 6 +++--- target/hexagon/mmvec/macros.h| 2 +- target/hexagon/op_helper.c | 9 +++-- target/hexagon/translate.c | 10 +- 4 files changed, 12 insertions(+), 15 deletions(-) diff --git a/target/hexa

[PATCH v3 3/3] target/hexagon: avoid shadowing globals

2023-10-08 Thread Brian Cain
The typedef `vaddr` is shadowed by `vaddr` identifiers, so we rename the identifiers to avoid shadowing the type name. The global `tcg_env` is shadowed by local `tcg_env` arguments, so we rename the function arguments to avoid shadowing the global. Signed-off-by: Brian Cain --- target/hexagon

[PATCH v3 0/3] hexagon: GETPC() fixes, shadowing fixes

2023-10-08 Thread Brian Cain
Changes since v2: - rebased, suggested by Markus - s/cpu_env/tcg_env/ - For local shadows: s/tcg_env/tcg_env_/ Brian Cain (2): target/hexagon: fix some occurrences of -Wshadow=local target/hexagon: avoid shadowing globals Matheus Tavares Bernardino (1): target/hexagon

[PATCH v3 1/3] target/hexagon: move GETPC() calls to top level helpers

2023-10-08 Thread Brian Cain
: <2c74c3696946edba7cc5b2942cf296a5af532052.1689070412.git.quic_mathb...@quicinc.com>-ne Reviewed-by: Brian Cain Signed-off-by: Brian Cain --- target/hexagon/macros.h| 19 +- target/hexagon/op_helper.c | 75 +++--- target/hexagon/op_helper.h | 9 - 3

[PATCH v2 1/3] target/hexagon: move GETPC() calls to top level helpers

2023-10-05 Thread Brian Cain
: <2c74c3696946edba7cc5b2942cf296a5af532052.1689070412.git.quic_mathb...@quicinc.com>-ne Reviewed-by: Brian Cain Signed-off-by: Brian Cain --- target/hexagon/macros.h| 19 +- target/hexagon/op_helper.c | 75 +++--- target/hexagon/op_helper.h | 9 - 3

[PATCH v2 2/3] target/hexagon: fix some occurrences of -Wshadow=local

2023-10-05 Thread Brian Cain
ino Signed-off-by: Brian Cain --- target/hexagon/imported/alu.idef | 6 +++--- target/hexagon/mmvec/macros.h| 6 +++--- target/hexagon/op_helper.c | 9 +++-- target/hexagon/translate.c | 9 - 4 files changed, 13 insertions(+), 17 deletions(-) diff --git a/target/hexa

[PATCH v2 3/3] target/hexagon: avoid shadowing globals

2023-10-05 Thread Brian Cain
The typedef `vaddr` is shadowed by `vaddr` identifiers, so we rename the identifiers to avoid shadowing the type name. The global `cpu_env` is shadowed by local `cpu_env` arguments, so we rename the function arguments to avoid shadowing the global. Signed-off-by: Brian Cain --- target/hexagon

[PATCH v2 0/3] hexagon: GETPC() and shadowing fixes

2023-10-05 Thread Brian Cain
In v2: reworked with suggestions from Philippe and added a new patch to cover -Wshadow=global. Brian Cain (2): target/hexagon: fix some occurrences of -Wshadow=local target/hexagon: avoid shadowing globals Matheus Tavares Bernardino (1): target/hexagon: move GETPC() calls to top level

RE: [PATCH v2 3/3] target/hexagon: avoid shadowing globals

2023-10-17 Thread Brian Cain
> -Original Message- > From: Philippe Mathieu-Daudé > Sent: Tuesday, October 10, 2023 12:23 AM > To: Brian Cain ; richard.hender...@linaro.org; > a...@rev.ng > Cc: arm...@redhat.com; peter.mayd...@linaro.org; Matheus Bernardino > (QUIC) ; stefa...@redhat.com; a...@r

RE: [PATCH v2 3/3] target/hexagon: avoid shadowing globals

2023-10-09 Thread Brian Cain
> -Original Message- > From: Philippe Mathieu-Daudé > Sent: Monday, October 9, 2023 1:43 AM > To: Brian Cain ; qemu-devel@nongnu.org > Cc: arm...@redhat.com; richard.hender...@linaro.org; > peter.mayd...@linaro.org; Matheus Bernardino (QUIC) > ; stefa...@re

RE: [PATCH v2 3/3] target/hexagon: avoid shadowing globals

2023-10-08 Thread Brian Cain
> -Original Message- > From: ltaylorsimp...@gmail.com > Sent: Friday, October 6, 2023 11:01 AM > To: Brian Cain ; qemu-devel@nongnu.org > Cc: arm...@redhat.com; richard.hender...@linaro.org; phi...@linaro.org; > peter.mayd...@linaro.org; Matheus Bernardino (QUIC) >

RE: [PATCH 11/24] hexagon: spelling fixes

2023-08-23 Thread Brian Cain
quot;Replicates scalar across bytes in vector", VdV.ub[i] = RtV) > > > diff --git a/tests/tcg/hexagon/fpstuff.c b/tests/tcg/hexagon/fpstuff.c > index 344b9f7772..6aadaccabd 100644 > --- a/tests/tcg/hexagon/fpstuff.c > +++ b/tests/tcg/hexagon/fpstuff.c > @@ -53,5 +53,5 @@ static void check_compare_exception(void) > uint32_t usr; > > -/* Check that FP compares are quiet (don't raise any execptions) */ > +/* Check that FP compares are quiet (don't raise any exceptions) */ > asm (CLEAR_FPSTATUS > "p0 = sfcmp.eq(%2, %3)\n\t" > diff --git a/tests/tcg/hexagon/test_clobber.S > b/tests/tcg/hexagon/test_clobber.S > index a7aeb2b60c..10046c30d2 100644 > --- a/tests/tcg/hexagon/test_clobber.S > +++ b/tests/tcg/hexagon/test_clobber.S > @@ -1,4 +1,4 @@ > /* > - * Purpose: demonstrate the succesful operation of the register save > mechanism, > + * Purpose: demonstrate the successful operation of the register save > mechanism, > * in which the caller saves the registers that will be clobbered, and > restores > * them after the call. > -- > 2.39.2 > Reviewed-by: Brian Cain

RE: [PATCH] tests: Remove unused "wcount" from linux-test.c

2022-05-20 Thread Brian Cain
> -Original Message- > From: Peter Maydell > Sent: Friday, May 20, 2022 8:21 AM > To: Brian Cain > Cc: Daniel P. Berrangé ; qemu-devel@nongnu.org; > Alex Bennée > Subject: Re: [PATCH] tests: Remove unused "wcount" from linux-test.c > > WARNIN

[PATCH] tests: Remove unused "wcount" from linux-test.c

2022-05-20 Thread Brian Cain
clang reports this variable as 'set but not used'. Signed-off-by: Brian Cain --- tests/tcg/multiarch/linux/linux-test.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/tcg/multiarch/linux/linux-test.c b/tests/tcg/multiarch/linux/linux-test.c index 019d8175ca

RE: hexagon docker test failure

2022-07-26 Thread Brian Cain
> -Original Message- > From: Qemu-devel > On Behalf Of Richard Henderson > Sent: Tuesday, July 26, 2022 12:42 PM > To: Taylor Simpson > Cc: qemu-devel > Subject: Re: hexagon docker test failure > > WARNING: This email originated from outside of Qualcomm. Please be wary of > any links

[PATCH] Hexagon (target/hexagon) implement mutability mask for GPRs

2022-09-01 Thread Brian Cain
Some registers are defined to have immutable bits, this commit will implement that behavior. Signed-off-by: Brian Cain --- target/hexagon/gen_masked.c | 44 target/hexagon/gen_masked.h | 26 target/hexagon/genptr.c | 33 - target/hexagon

RE: [PATCH] Hexagon (target/hexagon) implement mutability mask for GPRs

2022-09-07 Thread Brian Cain
. > > Some registers are defined to have immutable bits, this commit > > will implement that behavior. > > > > Signed-off-by: Brian Cain > > --- > > target/hexagon/gen_masked.c | 44 > > target/hexagon/gen_masked.h

RE: [PATCH] Hexagon (target/hexagon) implement mutability mask for GPRs

2022-09-03 Thread Brian Cain
> -Original Message- > From: Richard Henderson ... > It might be clearer, and easier to initialize, if you invert the sense of the > mask: Ok -- thanks for the suggestions! I'll give 'em all a try. -Brian

RE: [RFC PATCH v2] gdbstub: only send stop-reply packets when allowed to

2022-09-15 Thread Brian Cain
> -Original Message- > From: Qemu-devel > On Behalf Of Matheus Tavares Bernardino ... > On Wed, 24 Aug 2022 at 14:51, Matheus Tavares Bernardino > wrote: > > > > Instead, let's change gdb_set_stop_cpu() to send stop messages only as a > > response to a previous GDB command, also making

RE: [PATCH] linux-test.c: Remove unused but set variable

2023-01-05 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Thursday, January 5, 2023 10:24 AM > To: qemu-devel@nongnu.org; alex.ben...@linaro.org > Cc: Taylor Simpson ; richard.hender...@linaro.org; > phi...@linaro.org; a...@rev.ng; a...@rev.ng; Brian Cain > ; Mat

RE: [PATCH] linux-test.c: Remove unused but set variable

2023-01-05 Thread Brian Cain
> -Original Message- > From: Brian Cain > Sent: Thursday, January 5, 2023 11:10 AM > To: Taylor Simpson ; qemu-devel@nongnu.org; > alex.ben...@linaro.org > Cc: Taylor Simpson ; richard.hender...@linaro.org; > phi...@linaro.org; a...@rev.ng; a...@rev.ng; Mat

RE: [PATCH v2 11/21] Hexagon (target/hexagon) Short-circuit packet register writes

2023-04-27 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Thursday, April 27, 2023 6:00 PM > To: qemu-devel@nongnu.org > Cc: Taylor Simpson ; richard.hender...@linaro.org; > phi...@linaro.org; a...@rev.ng; a...@rev.ng; Brian Cain > ; Matheus Bernardino (QUIC) > &g

RE: [PATCH] Use hexagon toolchain version 16.0.0

2023-03-29 Thread Brian Cain
CHAIN_RELEASE}-cross- > hexagon-unknown-linux-musl" > ENV TOOLCHAIN_URL https://codelinaro.jfrog.io/artifactory/codelinaro- > toolchain-for- > hexagon/v${TOOLCHAIN_RELEASE}/${TOOLCHAIN_BASENAME}.tar.xz > > -- > 2.25.1 > Reviewed-by: Brian Cain

RE: [PATCH] target/hexagon/idef-parser: Remove self-assignment

2023-07-13 Thread Brian Cain
> -Original Message- > From: Anton Johansson > Sent: Thursday, July 13, 2023 7:09 AM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; peter.mayd...@linaro.org > Subject: [PATCH] target/hexagon/idef-parser: Remove self-assignment > > WARNING: This email

RE: [PATCH] Hexagon: move GETPC() calls to top level helpers

2023-07-03 Thread Brian Cain
> -Original Message- > From: Matheus Tavares Bernardino > Sent: Monday, July 3, 2023 4:50 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Marco Liebel (QUIC) > ; ltaylorsimp...@gmail.com > Subject: [PATCH] Hexagon: move GETPC() calls to top level helpers >

RE: How do you represent a host gcc and a cross gcc in lcitool?

2023-05-31 Thread Brian Cain
> -Original Message- > From: Alex Bennée > Sent: Wednesday, May 31, 2023 6:24 AM > To: Daniel P.Berrangé > Cc: qemu-devel ; Michael Tokarev > ; Erik Skultety ; Brian Cain > ; Palmer Dabbelt ; Alistair Francis > ; Bin Meng > Subject: How do you represent

RE: [PATCH v2] Hexagon (target/hexagon) Fix assignment to tmp registers

2023-05-22 Thread Brian Cain
> -Original Message- > From: Marco Liebel (QUIC) > Sent: Monday, May 22, 2023 12:47 PM > To: qemu-devel@nongnu.org > Cc: Taylor Simpson ; Brian Cain ; > Marco Liebel (QUIC) > Subject: [PATCH v2] Hexagon (target/hexagon) Fix assignment to tmp registers &g

RE: Help finding Coverity defects for generated Hexagon code

2023-05-23 Thread Brian Cain
> -Original Message- > From: qemu-devel-bounces+bcain=quicinc@nongnu.org bounces+bcain=quicinc@nongnu.org> On Behalf Of Richard Henderson > Sent: Tuesday, May 23, 2023 10:32 AM > To: a...@rev.ng; Paolo Bonzini ; Peter Maydell > > Cc: qemu-devel@nongnu.org > Subject: Re: Help

RE: [PATCH] Remove test_vshuff from hvx_misc tests

2023-05-09 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Tuesday, May 9, 2023 2:28 PM > To: Marco Liebel (QUIC) ; qemu- > de...@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > > Subject: RE: [PATCH] Remove test_vshuff from hvx_misc tests > >

RE: [PATCH] Remove test_vshuff from hvx_misc tests

2023-05-09 Thread Brian Cain
> -Original Message- > From: Marco Liebel (QUIC) > Sent: Tuesday, May 9, 2023 1:43 PM > To: qemu-devel@nongnu.org > Cc: Taylor Simpson ; Brian Cain ; > Matheus Bernardino (QUIC) ; Marco Liebel > (QUIC) > Subject: [PATCH] Remove test_vshuff from hvx_misc tests

RE: [PATCH v3 5/6] Hexagon (gdbstub): add HVX support

2023-05-12 Thread Brian Cain
> -Original Message- > From: Matheus Tavares Bernardino > Sent: Thursday, May 4, 2023 10:38 AM > To: qemu-devel@nongnu.org > Cc: alex.ben...@linaro.org; Brian Cain ; > f4...@amsat.org; peter.mayd...@linaro.org; Taylor Simpson > ; phi...@linaro.org; richard.hender...@

hexagon: modeling a shared lock state

2024-01-24 Thread Brian Cain
Philippe, For hexagon sysemu, while internally reviewing patches to be upstreamed we noticed that our design for a lock instruction is not quite suitable. The k0lock instruction will halt if some other hexagon hardware CPU has already claimed the kernel lock, only to continue executing once

RE: [PATCH v3 1/3] Hexagon (target/hexagon) Pass P0 explicitly to helpers that need it

2024-02-16 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Tuesday, February 13, 2024 10:27 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH v3 2/3] Hexagon (target/hexagon) Pass SP explicitly to helpers that need it

2024-02-16 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Tuesday, February 13, 2024 10:27 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH v3 2/3] Hexagon (target/hexagon) Pass SP explicitly to helpers that need it

2024-02-16 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Tuesday, February 13, 2024 10:27 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

testing without the translation cache

2024-01-08 Thread Brian Cain
Alex, A very long time ago QEMU supported disabling the translation cache via "-translation no-cache". That option was deliberately removed. We are looking into a hexagon-specific failure when there's a TB lookup miss from a cpu_loop_exit_restore().I'd like to test our fix for this

RE: [PATCH v2 9/9] Hexagon (target/hexagon) Remove dead functions from hex_common.py

2024-01-11 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Sunday, December 10, 2023 4:07 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH v2 8/9] Hexagon (target/hexagon) Remove unused WRITES_PRED_REG attribute

2024-01-11 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Sunday, December 10, 2023 4:07 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH v2 2/9] Hexagon (target/hexagon) Make generators object oriented - gen_tcg_funcs

2024-01-11 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Sunday, December 10, 2023 4:07 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH v2 7/9] Hexagon (target/hexagon) Make generators object oriented - gen_analyze_funcs

2024-01-11 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Sunday, December 10, 2023 4:07 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH v2 3/9] Hexagon (target/hexagon) Make generators object oriented - gen_helper_protos

2024-01-11 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Sunday, December 10, 2023 4:07 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH v2 4/9] Hexagon (target/hexagon) Make generators object oriented - gen_helper_funcs

2024-01-11 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Sunday, December 10, 2023 4:07 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH v2 6/9] Hexagon (target/hexagon) Make generators object oriented - gen_op_regs

2024-01-11 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Sunday, December 10, 2023 4:07 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH v2 5/9] Hexagon (target/hexagon) Make generators object oriented - gen_idef_parser_funcs

2024-01-11 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Sunday, December 10, 2023 4:07 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH v2 3/3] Hexagon (target/hexagon) Remove old dectree.py

2024-01-14 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Monday, January 8, 2024 4:49 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org; a...@rev.ng;

RE: [PATCH v2 1/3] Hexagon (target/hexagon) Use QEMU decodetree (32-bit instructions)

2024-01-14 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Monday, January 8, 2024 4:49 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org; a...@rev.ng;

RE: [PATCH v2 2/3] Hexagon (target/hexagon) Use QEMU decodetree (16-bit instructions)

2024-01-14 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Monday, January 8, 2024 4:49 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org; a...@rev.ng;

[PATCH] tests/docker: Hexagon toolchain update

2024-01-14 Thread Brian Cain
This update includes support for privileged instructions. Signed-off-by: Brian Cain --- tests/docker/dockerfiles/debian-hexagon-cross.docker | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/docker/dockerfiles/debian-hexagon-cross.docker b/tests/docker/dockerfiles

[PATCH] Reduce scope of def_regnum, remove dead assignment

2024-01-14 Thread Brian Cain
This is intended to address a coverity finding: CID 1527408. Signed-off-by: Brian Cain --- target/hexagon/mmvec/decode_ext_mmvec.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/hexagon/mmvec/decode_ext_mmvec.c b/target/hexagon/mmvec/decode_ext_mmvec.c index

RE: [PATCH v2 0/9] Hexagon (target/hexagon) Make generators object oriented

2024-01-15 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Sunday, December 10, 2023 4:07 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH v2 0/3] Hexagon (target/hexagon) Use QEMU decodetree

2024-01-15 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Monday, January 15, 2024 4:15 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH 2/9] Hexagon (target/hexagon) Make generators object oriented - gen_tcg_funcs

2023-12-04 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Monday, December 4, 2023 7:53 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH 1/9] Hexagon (target/hexagon) Clean up handling of modifier registers

2023-12-04 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Monday, December 4, 2023 7:53 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH 6/9] Hexagon (target/hexagon) Make generators object oriented - gen_op_regs

2023-12-04 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Monday, December 4, 2023 7:53 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH 3/9] Hexagon (target/hexagon) Make generators object oriented - gen_helper_protos

2023-12-04 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Monday, December 4, 2023 7:53 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PULL v2 25/30] Hexagon HVX (target/hexagon) instruction decoding

2023-11-26 Thread Brian Cain
> -Original Message- > From: Brian Cain > Sent: Tuesday, November 21, 2023 9:52 AM > To: Peter Maydell > Cc: qemu-devel@nongnu.org; richard.hender...@linaro.org; f4...@amsat.org > Subject: RE: [PULL v2 25/30] Hexagon HVX (target/hexagon) instruction > decoding >

RE: [PATCH] Hexagon (target/hexagon) Fix shadow variable when idef-parser is off

2023-11-30 Thread Brian Cain
> -Original Message- > From: Philippe Mathieu-Daudé > Sent: Thursday, November 30, 2023 2:17 PM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; >

RE: [PATCH] Hexagon (target/hexagon) Fix shadow variable when idef-parser is off

2023-11-30 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Thursday, November 30, 2023 12:40 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: hexagon: modeling a shared lock state

2024-01-25 Thread Brian Cain
> -Original Message- > From: Richard Henderson > Sent: Wednesday, January 24, 2024 6:22 PM > To: Brian Cain ; Philippe Mathieu-Daudé > > Cc: qemu-devel@nongnu.org; Sid Manning ; Marco > Liebel ; Matheus Bernardino > > Subject: Re: hexagon: modeling a sha

[PULL 04/15] Hexagon (target/hexagon) Make generators object oriented - gen_tcg_funcs

2024-01-21 Thread Brian Cain
that use regtype/regid (e.g., is_read) This patch creates the class hierarchy in hex_common and converts gen_tcg_funcs.py. The other scripts will be converted in subsequent patches in this series. Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20231210220712.49149

[PULL 15/15] target/hexagon: reduce scope of def_regnum, remove dead assignment

2024-01-21 Thread Brian Cain
This is intended to address a coverity finding: CID 1527408. Signed-off-by: Brian Cain Reviewed-by: Matheus Tavares Bernardino Message-Id: <20240114234453.4114587-1-bc...@quicinc.com> --- target/hexagon/mmvec/decode_ext_mmvec.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

[PULL 01/15] tests/docker: Hexagon toolchain update

2024-01-21 Thread Brian Cain
This update includes support for privileged instructions. Signed-off-by: Brian Cain Reviewed-by: Matheus Tavares Bernardino Tested-by: Matheus Tavares Bernardino Message-Id: <20240114232354.4109231-1-bc...@quicinc.com> --- tests/docker/dockerfiles/debian-hexagon-cross.docker | 4 ++--

  1   2   >