25.05.2013 00:07, Ed Maste wrote:
When probing for ncurses, try pkg-config first rather than after
explicit -lncurses and -lcurses. This fixes static linking in the case
that ncurses has additional dependencies, such as -ltinfo (as on FreeBSD).
This is not a FreeBSD-specific thing, this is
24.05.2013 22:47, Brad Smith wrote:
+++ b/include/qemu-common.h
#elif defined CONFIG_BSD
+# include termios.h
Kinda late nit picking about it now.
It's not. And it's not nitpicking really, we're
carrying a ton of unnecessary #includes which slows
down compilation significantly.
The whole
We test pkg-config for curses and curl even if those are explicitly
disabled. Move these tests inside `if $feature != no' sections.
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
configure | 21 +
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/configure
24.05.2013 14:19, Stefan Weil wrote:
Fix these warnings from cppcheck:
Thanks, applied to the trivial patches tree.
/mjt
24.05.2013 06:47, liguang wrote:
when enable DEBUG_DEBUGCON, there are some message
printing bugs, so fix them.
this patch-set based on previous 3 patches,
http://comments.gmane.org/gmane.comp.emulators.qemu/212550
http://comments.gmane.org/gmane.comp.emulators.qemu/212551
22.05.2013 17:21, Ed Maste wrote:
The configure script had some code to manipulate config-host.ld~ (i.e.,
a common backup filename), comparing it with the newly-generated file.
I believe the sense of the comparison was backwards.
Since it seemed to serve little purpose anyway, remove it to
25.05.2013 14:35, Andreas Färber wrote:
Am 25.05.2013 11:28, schrieb Michael Tokarev:
[]
debugcon: use fprintf(stderr...) instead of printf
The subjects and commit messages are a bit inaccurate, and
as Andreas says, these may have been merged together, but
the inaccuracy is small
25.05.2013 15:38, Andreas Färber wrote:
Am 25.05.2013 06:25, schrieb Michael Tokarev:
[]
Here, it is interesting to note that pkg-config does not actually do
the right thing in this case. Because practically, it should have
one extra flag, something like --static-libs (or --libs --static
27.05.2013 14:33, Lei Li wrote:
This small series improves the document migration.txt
and remove a duplicated setting of bandwidth_limit.
FWIW, please don't CC me directly, I'm subscribed to
qemu-trivial@ obviously (being the one behind trivial-
patches currently).
Thanks,
/mjt
27.05.2013 16:59, Kevin O'Connor wrote:
A new stable release of SeaBIOS (version 1.7.2.2) has been tagged.
This release contains bug fixes.
The release is available via git:
git clone git://git.seabios.org/seabios -b 1.7.2-stable
Just.. curious -- why there are no tarballs for the
20.05.2013 13:20, Lei Li wrote:
Signed-off-by: Lei Li li...@linux.vnet.ibm.com
---
linux-user/syscall.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Thanks, applied to the trivial patch queue.
/mjt
22.05.2013 09:33, Hu Tao wrote:
Since it's not defined and used anywhere.
Thanks, applied to the trivial-patches queue.
If the need arises to bring it back, it can be done
together with the implementation and some users :)
/mjt
25.05.2013 00:07, Ed Maste wrote:
When probing for ncurses, try pkg-config first rather than after
explicit -lncurses and -lcurses. This fixes static linking in the case
that ncurses has additional dependencies, such as -ltinfo (as on FreeBSD).
Thanks, applied to the trivial patches queue, on
27.05.2013 14:33, Lei Li wrote:
This small series improves the document migration.txt
and remove a duplicated setting of bandwidth_limit.
Thanks, both applied to the trivial patch queue.
/mjt
27.05.2013 05:40, li guang wrote:
[]
NACK. If you want to apply 1-3, okay. But please unqueue 4/4, it makes
no sense as-is (just look at the stderr output to see what I mean) and
it pretends that I suggested that!
Actually I did just that, rebuild with DEBUG_DEBUGCON and looked
at the
There are quite a few leftover declarations in slirp/misc.h.
Remove them.
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
slirp/misc.h | 14 --
1 file changed, 14 deletions(-)
I'm not entirely sure we should do this, since this kind of
changes just moves us more and more away
Um, something's wrong with the Date. Care to resend with that fixed?
Thanks,
/mjt
18.01.2009 02:13, Xudong Hao wrote:
mmap is used in qemu_vmalloc function instead of qemu_memalign(commit
7dda5dc8), so it should change qemu_vfree to munmap to fix a unmatched
issue.
[...]
29.05.2013 17:30, Alexey Kardashevskiy wrote:
The symlink to asm platform linux headers is made in the build tree by
the configure script but gcc is not told to look for them there.
The patch fixes this.
Thanks, applied to the trivial patches queue.
/mjt
29.05.2013 17:58, Ed Maste wrote:
Based on the datasheet at
http://www.micron.com/~/media/Documents/Products/Data%20Sheet/NOR%20Flash/Serial%20NOR/N25Q/n25q_32mb_1_8v_65nm.pdf
Thanks, applied to the trivial patches queue.
/mjt
31.05.2013 13:39, Thomas Schwinge wrote:
Signed-off-by: Thomas Schwinge tho...@codesourcery.com
---
fpu/softfloat-specialize.h | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git fpu/softfloat-specialize.h fpu/softfloat-specialize.h
index 518f694..83add1a
31.05.2013 16:00, Paolo Bonzini wrote:
Two instances, both spotted by Coverity. In one, two blocks were
swapped. In the other, the check is not needed anymore.
Thanks, applied to the trivial patches queue.
/mjt
-config ncurses first
m25p80: Add Micron n25q032a
Hu Tao (1):
rtc: remove rtc_set_date
Lei Li (3):
linux-user: Fix typo in comment
docs: Fix typo and update file in migration
migration: Remove duplicate bandwidth_limit set
Michael Tokarev (2):
don't run pkg-config
[Replying to a very old email which I missed initially]
Todd, do you still have the issue you describe?
I mean, not that we changed lots in that area (I guess we
changed nothing there), but i'm not sure I understand what
is going on there, and why the behavour changed the way you
describe. I
when
neither is set, and we generate bogus acpi table in this
case.
Instead, check if sum of the two is exactly 1.
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
hw/acpi/core.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/acpi/core.c b/hw/acpi/core.c
index 42eeace
03.06.2013 16:34, Eric Blake wrote:
On 06/03/2013 03:20 AM, Michael Tokarev wrote:
Initially the code ensured that we have exactly one of data= or file= option
for -acpitable. But after some transformations, the condition becomes
if (has_data == has_file) { error }
to mean, probably
Public bug reported:
When some guest is run with -vga vmware -display gtk, qemu segfaults
after certain guest gui operations.
./x86_64-softmmu/qemu-system-x86_64 -cdrom
ubuntu-10.04.4-desktop-i386.iso -vga vmware -enable-kvm
(-enable-kvm just to speed things up, it does not depend on kvm).
03.06.2013 22:19, Laszlo Ersek wrote:
On 06/03/13 14:42, Michael Tokarev wrote:
[]
This function has another error -- if the file specified
(either for data= or file=) can't be read, it happily
continues instead of erroring out. _That_ is the bug
I tried to hunt but catched something else
03.06.2013 14:54, Peter Wu wrote:
The GTK display type has been introduced in 1.5, replacing SDL as default.
Some
options only work with SDL and not GTK. This patch tries to address them.
The `-display` option is updated with the new `gtk` option.
The `-alt-grab` and `-ctrl-alt` options
04.06.2013 18:23, Anthony Liguori wrote:
Andreas Färber afaer...@suse.de writes:
[]
Do we have an active maintainer for 1.1 or 1.3? Unfortunately qemu.git
MAINTAINERS has not been updated with stable branches and maintainers
for some time. If not, I'd be willing to step up for security fixes
23.05.2013 02:38, Brad Smith wrote:
Fix the build of the Gtk+ UI on *BSD systems.
Can you please describe what exactly was broken on *BSD
systems, -- which file(s) needs this additional
termios.h include?
I want to fix this properly, because now it isn't
nitpicking, as you say, anymore -- after
Hello.
One of old issues with compatibility between different
*Nix systems was the way how pty pairs were allocated.
And qemu have a twist in #includes, depending on which
platform it is run, and quite some compat cruft in
qemu-char.c about this issue.
Here it is, from qemu-char.c:
#ifdef
05.06.2013 15:23, Andreas Färber wrote:
Am 05.06.2013 12:28, schrieb Michael Tokarev:
[qemu_openpty() wrapper]
I haven't tried yet, but this sounds like something for osdep.c, no need
for a special qemu-openpty.c.
This is a bit more tricky. At least on glibc, openpty() is in -lutil
isn't a place for such specific headers really.
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
include/qemu-common.h | 15 +-
qemu-char.c | 77 ++--
ui/gtk.c | 12 ++---
util/Makefile.objs|2 +-
util/qemu-openpty.c | 134
This removes syslog.h since we don't use
syslogging, and removes second, solaris-specific,
include of net/if.h (which is included in
a common part of the file)
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
qemu-char.c |2 --
1 file changed, 2 deletions(-)
diff --git a/qemu-char.c b
isn't a place for such specific headers really.
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
Changes since v1:
- added a forgotten #include termios.h for *BSD,
which was recently added into qemu-common.h by
Brad Smith, and which I intended to use in
qemu-openpty.c too, but somehow
05.06.2013 00:23, Alon Levy wrote:
Used by the followin patch.
+int qemu_pipe_non_block(int pipefd[2]);
A nitpick. I'd name it qemu_pipe_nonblock(), like O_NONBLOCK
is named, but that may be just me.
Thanks,
/mjt
05.06.2013 16:16, Hervé Poussineau wrote:
'pd' variable has been removed in 06ef3525e1f271b6a842781a05eace5cf63b95c2.
It's been removed indeed, but the value has been replaced by using
a MemoryRegionSection instead. I understand current code is wrong
when DEBUG_TLB is #defined, but I think it
05.06.2013 19:02, Ed Maste wrote:
- linker_script=-Wl,-T../config-host.ld
-Wl,-T,\$(SRC_PATH)/ldscripts/\$(ARCH).ld
+ linker_script=-Wl,-T../${config_host_ld}
-Wl,-T,\$(SRC_PATH)/ldscripts/\$(ARCH).ld
Do we really care? To me it looks like it is better
to just remove the variable (which
Hello.
On debian we, for a long time, used the following hack
in a build script of qemu:
# Hack alert. qemu-1.3 still needs this.
# On recent kFreebsd, old USB host API has been removed,
# but qemu did not learn to use new USB API.
# Just do not build USB host support.
sed -i
for downstreams who apply patches for
real.
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
.gitignore |1 -
1 file changed, 1 deletion(-)
diff --git a/.gitignore b/.gitignore
index 64e9466..0fe114d 100644
--- a/.gitignore
+++ b/.gitignore
@@ -82,7 +82,6 @@ fsdev/virtfs-proxy-helper.pod
06.06.2013 16:53, Ed Maste wrote:
It was only used in one place (and already expanded in one other).
Thanks, applied to the trivial patches queue.
I think we should just as well get rid of ${config_host_mak},
as it makes no sense too... ;) And while at it, maybe use
common constructs like
{
06.06.2013 17:18, Ed Maste wrote:
It hasn't built since FreeBSD 8.x, and is disabled by a patch in the
FreeBSD ports tree. FreeBSD is migrating to QEMU's libusb support.
Thanks, applied to the trivial patches queue.
/mjt
07.06.2013 06:39, Peter Crosthwaite wrote:
Use qemu_set_irq rather than if-elsing qemu_irq_(lower|raise). No
functional change, just reduces verbosity.
Thanks, applied to the trivial patches queue.
/mjt
06.06.2013 07:59, Alexey Kardashevskiy wrote:
From: Scott Wood scottw...@freescale.com
The common KVM code insists on calling kvm_arch_init_irq_routing()
as soon as it sees kernel header support for it (regardless of whether
QEMU supports it). Provide a dummy function to satisfy this.
05.06.2013 17:42, Hervé Poussineau wrote:
If that's not the case, QEMU will may during execution.
This has recently been fixed for:
- acpi (2d3b989529727ccace243b953a181fbae04a30d1)
- kvmapic (0c1cd0ae2a4faabeb948b9a07ea1696e853de174)
- xhci (6d3bc22e31bcee74dc1e05a5370cabb33b7c3fda)
And
03.06.2013 09:12, peter.crosthwa...@xilinx.com wrote:
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Some cosmetic fixes to char/serial fixing some checkpatch errors.
These are all cosmetic fixes indeed. I weren't sure we're
applying stylistic changes by its own. But apparently
people
10.06.2013 19:17, Michael Tokarev пишет:
03.06.2013 09:12, peter.crosthwa...@xilinx.com wrote:
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Some cosmetic fixes to char/serial fixing some checkpatch errors.
These are all cosmetic fixes indeed. I weren't sure we're
applying
10.06.2013 17:19, Richard W.M. Jones wrote:
From: Richard W.M. Jones rjo...@redhat.com
(Found by Kamil Dudka)
Signed-off-by: Richard W.M. Jones rjo...@redhat.com
---
block/curl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/curl.c b/block/curl.c
index b634ccf..bf31efe
09.06.2013 16:22, Stefan Weil wrote:
GCC_ATTR was only used in audio_int.h, so it is now unused and
the definition can be removed from compiler.h.
Thanks, applied to the trivial patches queue.
/mjt
09.06.2013 14:30, Peter Wu wrote:
Aiming for GTK as replacement for SDL, features like -full-screen and
-no-frame
should also be implemented.
I'm not sure both options really should be implemented. I think -no-frame makes
little sense actually. But -full-screen is very useful, and hiding
07.06.2013 07:51, Peter Crosthwaite wrote:
[]
Id like to give it a few days to see what they say before we merge
this. Ideally we have agreement between the two source trees, so we
can continue the copy-paste based update strategy.
Do we have any agreement yet? :)
Thanks,
/mjt
. Mohan Kumar mo...@in.ibm.com
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
configure |2 ++
1 file changed, 2 insertions(+)
diff --git a/configure b/configure
index a3f0b7a..0ff0380 100755
--- a/configure
+++ b/configure
@@ -3423,6 +3423,8 @@ if test $softmmu = yes ; then
tools=qemu
11.06.2013 00:47, Michael Tokarev wrote:
Or else
./configure --disable-system --enable-virtfs
(which makes no sense by its own but does not error out)
will fail to build, because it will define CONFIG_VIRTFS,
and the makefile will try to build virtfs-proxy-helper
manpage
11.06.2013 04:41, Peter Crosthwaite wrote:
On Sat, Jun 8, 2013 at 8:36 AM, Michael Tokarev m...@tls.msk.ru wrote:
Thanks, applied to the trivial patches queue.
I need to respin the later patches in this series but as you have
taken this ill drop it from the respin. No conflict issues.
heh
11.06.2013 13:22, M. Mohan Kumar wrote:
Michael Tokarev m...@tls.msk.ru writes:
11.06.2013 00:47, Michael Tokarev wrote:
Or else
./configure --disable-system --enable-virtfs
(which makes no sense by its own but does not error out)
will fail to build, because it will define CONFIG_VIRTFS
10.06.2013 14:23, Peter Crosthwaite wrote:
Ping!
Any objections to this one going in? perhaps even via trivial queue?
Actually applied all 3 (including 2/3 which weren't submitted to -trivial --
I had some fun verifying it :) to the trivial-patches queue.
Thanks!
/mjt
10.06.2013 22:04, Peter Wu wrote:
Aiming for GTK as replacement for SDL, a feature like -full-screen should also
be implemented.
Bringing the window into full-screen mode is done by activating the
Fullscreen
menu item. This is done after showing the windows to make the cursor and menu
11.06.2013 09:15, liguang wrote:
because memory_region_update_pending is bool
Signed-off-by: liguang lig.f...@cn.fujitsu.com
---
memory.c | 18 +-
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/memory.c b/memory.c
index 5cb8f4a..d99eecd 100644
---
11.06.2013 09:15, liguang wrote:
Signed-off-by: liguang lig.f...@cn.fujitsu.com
---
qemu-char.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index d04b429..8092eb8 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2767,10
1/5 and 2/5 (vnc_listen_read),
I think.
Does something like the below look ok? (not even compile-tested)
(and I'd really rename `skipauth' to `doauth' everywhere, to mean
exactly the opposite so that we don't have double negatives, but
it is too late already)
From: Michael Tokarev m...@tls.msk.ru
11.06.2013 15:13, Andreas Färber wrote:
When splitting openSUSE's qemu and qemu-linux-user packages we noticed
that for linux-user-only builds unrelated man pages got installed.
It's surely possible to delete them before packaging, but not installing
them in the first place seems more logical.
Thanks, applied all 4(*) to trivial-patches queue.
(*)
target-sparc: Replace free by g_free
hw/scsi: Don't increment a boolean value
device tree: Fix cppcheck warning
hw/xen: Use g_free instead of free and fix potential memory leaks
(I think it wont hurt if the xen one will come from both
11.06.2013 12:55, Peter Wu wrote:
Certain options (-no-frame, -alt-grab, -ctrl-grab) only make sense with SDL.
When compiling without SDL, these options (and -no-quit) print an error
message
and exit qemu.
In case QEMU is compiled with SDL support, the three aforementioned options
still
11.06.2013 01:45, Peter Maydell wrote:
On 10 June 2013 21:47, Michael Tokarev m...@tls.msk.ru wrote:
Or else
./configure --disable-system --enable-virtfs
(which makes no sense by its own but does not error out)
will fail to build, because it will define CONFIG_VIRTFS,
and the makefile
[Removing malc's email since it bounces]
09.06.2013 16:22, Stefan Weil wrote:
GCC_ATTR was only used in audio_int.h, so it is now unused and
the definition can be removed from compiler.h.
Signed-off-by: Stefan Weil s...@weilnetz.de
---
audio/audio_int.h |8 +++-
05.06.2013 19:25, Michael Tokarev wrote:
In two places qemu uses openpty() which is very system-dependent,
and in both places the pty is switched to raw mode as well.
Make a wrapper function which does both steps, and move all the
system-dependent complexity into a separate file, together
11.06.2013 21:23, M. Mohan Kumar wrote:
Peter Maydell peter.mayd...@linaro.org writes:
How about this approach?
Well, this is definitely wrong :)
-if test $softmmu = yes ; then
- if test $virtfs != no ; then
+
+if test $virtfs != no ; then
+ if test $softmmu = yes ; then
if test
11.06.2013 23:21, Peter Maydell пишет:
On 11 June 2013 19:19, Michael Tokarev m...@tls.msk.ru wrote:
FWIW, I still don't understand what Peter Maydell dislikes
in a simplest case I posted initially, where we merely ignore
(disable) virtfs in case !softmmu.
It just seems to me that rather
12.06.2013 11:22, Stefan Hajnoczi wrote:
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index a19a6d6..5658f73 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -735,6 +735,7 @@ static int pci_ivshmem_init(PCIDevice *dev)
if (s-shmobj == NULL) {
12.06.2013 11:26, Alexey Kardashevskiy wrote:
We need new headers for live migration and in-kernel interrupt controller
support.
However just copying new headers breaks at least PPC so dummy
kvm_arch_init_irq_routing()
is required as well.
Changes since v1:
* added dummy functions for
05.06.2013 00:23, Alon Levy wrote:
[PATCH 1/5] oslib-posix: add qemu_pipe_non_block
[PATCH 2/5] use qemu_pipe_non_block
[PATCH 3/5] libcacard/vscclient: fix leakage of socket on error paths
[PATCH 4/5] libcacard/vreader.c: fix possible NULL dereference
[PATCH 5/5] libcacard/vscclient.c: fix
06.06.2013 01:22, Peter Maydell wrote:
Personally I think a lot of the random rubbish in
our .gitignore is bogus and should be removed.
Basically anything that's an editor dropping or
.patch or TAGS file or similar is a local workflow
thing and should be dealt with by setting up a global
05.06.2013 00:23, Alon Levy wrote:
--- a/libcacard/vscclient.c
+++ b/libcacard/vscclient.c
@@ -759,5 +763,6 @@ main(
g_io_channel_unref(channel_socket);
g_byte_array_unref(socket_to_send);
+closesocket(sock);
return 0;
}
This one isn't really needed, -- there's no
.
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
main-loop.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/main-loop.c b/main-loop.c
index cf36645..a44fff6 100644
--- a/main-loop.c
+++ b/main-loop.c
@@ -24,7 +24,8 @@
#include qemu-common.h
#include qemu/timer.h
24.09.2013 11:43, arm...@redhat.com wrote:
From: Markus Armbruster arm...@redhat.com
Commit 4f193e3 added the test, but screwed up in-tree builds
(SRCDIR=.): the tests's output overwrites the expected output, and is
thus compared to itself.
[]
.PHONY: $(patsubst %, check-%,
Thanks,
applied to the trivial patches queue.
/mjt
27.09.2013 11:28, Paolo Bonzini wrote:
Michael, want to pick this up for -trivial?
Reviewed-by: Paolo Bonzini pbonz...@redhat.com
Il 27/09/2013 03:25, Amos Kong ha scritto:
Touched some error after enabling DEBUG_SUBPAGE.
Thanks, applied to the trivial patches queue.
/mjt
28.09.2013 13:55, Stefan Weil wrote:
blockdev.c:1929:13: warning: Value stored to 'ret' is never read
ret = 0;
^ ~
Applied to the trivial patches queue.
Signed-off-by: Stefan Weil s...@weilnetz.de
---
blockdev.c |1 -
1 file changed, 1 deletion(-)
diff
29.09.2013 19:55, Stefan Weil wrote:
From buildbot default_i386_rhel61:
CCi386-softmmu/target-i386/arch_memory_mapping.o
target-i386/arch_memory_mapping.c: In function 'walk_pde':
target-i386/arch_memory_mapping.c:110: warning:
integer constant is too large for 'long' type
Thanks,
29.09.2013 19:51, Stefan Weil wrote:
From buildbot default_i386_rhel61:
CCalpha-softmmu/hw/alpha/typhoon.o
hw/alpha/typhoon.c: In function 'typhoon_translate_iommu':
hw/alpha/typhoon.c:703: warning: integer constant is too large for 'long' type
hw/alpha/typhoon.c:703: warning: integer
29.09.2013 23:12, Paolo Bonzini wrote:
sh4 is ~orphan so nobody should complain if qemu-trivial picks this up
as well.
Paolo
Il 14/09/2013 06:04, Guenter Roeck ha scritto:
On 09/08/2013 12:39 AM, Guenter Roeck wrote:
With Linux kernel version 3.3 or later, qemu fails with the following
29.09.2013 19:41, Stefan Weil wrote:
The QEMU buildbot default_i386_debian_6_0 shows this warning:
CCmigration.o
migration.c: In function 'qmp_query_migrate_capabilities':
migration.c:149: warning:
'caps' may be used uninitialized in this function
Gah, how disgusting. The code is
22.09.2013 00:26, Ján Veselý wrote:
Device communication errors need to be reported to driver.
Add a debug message while at it.
Signed-off-by: Jan Vesely jano.ves...@gmail.com
---
hw/usb/hcd-ohci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c
30.09.2013 10:32, Gerd Hoffmann wrote:
Hi,
While the actual interesting change (adding break) looks
correct, and the whole thing is trivial indeed, this area
has a maintainer, -- Cc'ing Gerd for this. If he's okay
I'll pick it up.
Patch is fine.
No, I didn't ask whenever the patch is
01.10.2013 01:04, Stefan Weil wrote:
Latest gcc-4.8 supports a new option -fsanitize=address which activates
an AddressSanitizer. This AddressSanitizer stops the QEMU system emulation
very early because two character arrays of size 8 are potentially written
with 9 bytes.
Commit
01.10.2013 15:47, arm...@redhat.com пишет:
From: Markus Armbruster arm...@redhat.com
Messed up in commit 8281abd.
Thanks, applied to the trivial patches queue.
/mjt
01.10.2013 15:28, Daniel P. Berrange пишет:
From: Daniel P. Berrange berra...@redhat.com
If there is no operation driver for the xattr type the
functions return '-1' and set errno to '-EOPNOTSUPP'.
When the calling code sets 'ret = -errno' this turns
into a large positive number.
In Linux
24.09.2013 11:43, arm...@redhat.com wrote:
From: Markus Armbruster arm...@redhat.com
Commit 4f193e3 added the test, but screwed up in-tree builds
(SRCDIR=.): the tests's output overwrites the expected output, and is
thus compared to itself.
Thanks, applied to the trivial patches queue.
The
How about this:
diff --git a/migration.c b/migration.c
index b4f8462..6066ab4 100644
--- a/migration.c
+++ b/migration.c
@@ -146,22 +146,16 @@ uint64_t migrate_max_downtime(void)
MigrationCapabilityStatusList *qmp_query_migrate_capabilities(Error **errp)
{
MigrationCapabilityStatusList
That's a seabios update. It is interesting that qemu may crash due to
different bios - this smells fishy, and it looks like there's some big
security issue waiting to be discovered... ;)
Lucas, I think you want to change --disable-strip into --enable-debug in
your configure line, to be able to
: convert block drivers linked with libs to modules
All the series:
Reviewed-by: Michael Tokarev m...@tls.msk.ru
Thank you for the good work!
/mjt
03.10.2013 00:40, Stefan Weil wrote:
While dirent-d_type is 8 bit for most systems, it is 32 bit for MinGW.
Reducing it to 8 bit results in a compiler warning because the macro
is_dir_maybe compares that 8 bit value with 32 bit constants.
Using 'unsigned' instead of 'unsigned char' matches the
Okay. This takes just too long and too many people
are affected. I'll just set the variable in question
(caps) to NULL at entry for now, -- it is not a critical
path and the current code is correct anyway. This is
becoming ridiculous, when there are so many different
opinions about such a
05.10.2013 13:15, Michael Tokarev пишет:
Okay. This takes just too long and too many people
are affected. I'll just set the variable in question
(caps) to NULL at entry for now, -- it is not a critical
path and the current code is correct anyway. This is
becoming ridiculous, when there are so
From: Markus Armbruster arm...@redhat.com
Forgotten in commit 6046c62 and 3464700.
Cc: qemu-sta...@nongnu.org
Reviewed-by: Andreas Färber afaer...@suse.de
Reviewed-by: Laszlo Ersek ler...@redhat.com
Signed-off-by: Markus Armbruster arm...@redhat.com
Signed-off-by: Michael Tokarev m...@tls.msk.ru
Armbruster (3):
tests: Update .gitignore for test-int128 and test-bitops
tests: Fix schema parser test for in-tree build
vl: Clean up unnecessary boot_order complications
Michael Tokarev (1):
migration: Fix compiler warning ('caps' may be used uninitialized)
Stefan Weil (5
-by: Stefan Weil s...@weilnetz.de
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
target-i386/arch_memory_mapping.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-i386/arch_memory_mapping.c
b/target-i386/arch_memory_mapping.c
index 2566a04..462f984 100644
--- a/target
peter.mayd...@linaro.org
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
hw/char/sh_serial.c |2 --
1 file changed, 2 deletions(-)
diff --git a/hw/char/sh_serial.c b/hw/char/sh_serial.c
index 6223a55..9328dd1 100644
--- a/hw/char/sh_serial.c
+++ b/hw/char/sh_serial.c
@@ -248,11 +248,9
afaer...@suse.de
Reviewed-by: Laszlo Ersek ler...@redhat.com
Signed-off-by: Markus Armbruster arm...@redhat.com
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
tests/.gitignore |1 +
tests/Makefile |8
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/tests
workaround is to pass 'version=9p2000.u' when
mounting the 9p fs in the guest, to disable all use of
xattrs.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
Reviewed-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
hw/9pfs/virtio-9p-xattr.c
1 - 100 of 6817 matches
Mail list logo
