Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

> On 23 Sep 2016, at 09:15, Markus Armbruster wrote: > > Eric Blake writes: > >> On 09/22/2016 06:51 AM, Markus Armbruster wrote: I think the file probably should not have been listed as public domain in the first place, as its initial

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

Eric Blake writes: > On 09/22/2016 06:51 AM, Markus Armbruster wrote: >>> >>> I think the file probably should not have been listed as public domain >>> in the first place, as its initial contents were copied from qemu-common.h >>> which is not public domain. >> >> Ewww!

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

On 09/22/2016 06:51 AM, Markus Armbruster wrote: >> >> I think the file probably should not have been listed as public domain >> in the first place, as its initial contents were copied from qemu-common.h >> which is not public domain. > > Ewww! Needs fixing. Indeed. Commit 5c02632 shows the

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

"Daniel P. Berrange" writes: > On Wed, Sep 21, 2016 at 01:18:58PM -0500, Eric Blake wrote: >> On 09/21/2016 10:28 AM, Markus Armbruster wrote: >> >> >> The compiler.h file has no license header, just a comment >> >> saying "public domain", which is obviously not the case >>

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

On Wed, Sep 21, 2016 at 01:18:58PM -0500, Eric Blake wrote: > On 09/21/2016 10:28 AM, Markus Armbruster wrote: > > >> The compiler.h file has no license header, just a comment > >> saying "public domain", which is obviously not the case > >> if you add this macro. > >> > >> Given that you'll need

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

On 09/21/2016 10:28 AM, Markus Armbruster wrote: >> The compiler.h file has no license header, just a comment >> saying "public domain", which is obviously not the case >> if you add this macro. >> >> Given that you'll need to explicitly mention the license terms >> for ignore_value. eg with a

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

"Daniel P. Berrange" writes: > On Wed, Sep 21, 2016 at 02:26:48PM +, Felipe Franciosi wrote: >> >> > On 21 Sep 2016, at 14:55, Eric Blake wrote: >> > >> > On 09/21/2016 07:31 AM, Markus Armbruster wrote: >> >>> >> >>> If we want to ignore return

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

On 09/21/2016 09:26 AM, Felipe Franciosi wrote: > > What's the best way to bring gnulib's ignore-value.h into Qemu? I'd think we > could just add to include/qemu/compiler.h something like: > > --8<-- > #if QEMU_GNUC_PREREQ(3, 4) > /* From gnulib's

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

On 09/21/2016 09:35 AM, Daniel P. Berrange wrote: >> But I'm not sure if that suffices to meet GPL's requirements. > > The compiler.h file has no license header, just a comment > saying "public domain", which is obviously not the case > if you add this macro. Oh, I missed that; I was assuming

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

> On 21 Sep 2016, at 15:35, Daniel P. Berrange wrote: > > On Wed, Sep 21, 2016 at 02:26:48PM +, Felipe Franciosi wrote: >> >>> On 21 Sep 2016, at 14:55, Eric Blake wrote: >>> >>> On 09/21/2016 07:31 AM, Markus Armbruster wrote: > > If we

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

On Wed, Sep 21, 2016 at 02:26:48PM +, Felipe Franciosi wrote: > > > On 21 Sep 2016, at 14:55, Eric Blake wrote: > > > > On 09/21/2016 07:31 AM, Markus Armbruster wrote: > >>> > >>> If we want to ignore return value reliably, lets just pull in the > >>> ignore_value macro

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

> On 21 Sep 2016, at 14:55, Eric Blake wrote: > > On 09/21/2016 07:31 AM, Markus Armbruster wrote: >>> >>> If we want to ignore return value reliably, lets just pull in the >>> ignore_value macro from gnulib which is known to work across GCC >>> versions >>> >>> >>> /*

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

On 09/21/2016 07:31 AM, Markus Armbruster wrote: >> >> If we want to ignore return value reliably, lets just pull in the >> ignore_value macro from gnulib which is known to work across GCC >> versions >> >> >> /* Normally casting an expression to void discards its value, but GCC >>versions 3.4

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

"Daniel P. Berrange" writes: > On Wed, Sep 21, 2016 at 10:00:23AM +, Felipe Franciosi wrote: >> >> > On 21 Sep 2016, at 07:24, Markus Armbruster wrote: >> > >> > "Pavel Dovgalyuk" writes: >> > >> >>> From: Felipe Franciosi

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

Actually, I just noticed Pavel is in the middle of submitting a "replay additions" series (currently at v4). Pavel: is this something you can address as part of that series? Thanks, Felipe > On 21 Sep 2016, at 11:12, Felipe Franciosi wrote: > > >> On 21 Sep 2016, at

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

> On 21 Sep 2016, at 11:07, Daniel P. Berrange wrote: > > On Wed, Sep 21, 2016 at 10:00:23AM +, Felipe Franciosi wrote: >> >>> On 21 Sep 2016, at 07:24, Markus Armbruster wrote: >>> >>> "Pavel Dovgalyuk" writes: >>> >

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

On Wed, Sep 21, 2016 at 10:00:23AM +, Felipe Franciosi wrote: > > > On 21 Sep 2016, at 07:24, Markus Armbruster wrote: > > > > "Pavel Dovgalyuk" writes: > > > >>> From: Felipe Franciosi [mailto:fel...@nutanix.com] > >>> If compiling with

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

> From: Felipe Franciosi [mailto:fel...@nutanix.com] > > On 21 Sep 2016, at 07:24, Markus Armbruster wrote: > > > > "Pavel Dovgalyuk" writes: > > > >>> From: Felipe Franciosi [mailto:fel...@nutanix.com] > >>> If compiling with -Werror=unused-result,

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

> On 21 Sep 2016, at 07:24, Markus Armbruster wrote: > > "Pavel Dovgalyuk" writes: > >>> From: Felipe Franciosi [mailto:fel...@nutanix.com] >>> If compiling with -Werror=unused-result, replay-internal.c won't build >>> due to a call to fwrite() where the

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1474391326-871-1-git-send-email-fel...@nutanix.com Subject: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result === TEST SCRIPT BEGIN === #!/bin/bash BASE

[Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

If compiling with -Werror=unused-result, replay-internal.c won't build due to a call to fwrite() where the returned value is ignored. A simple cast to (void) is not sufficient on recent GCCs, so this fixes it. Signed-off-by: Felipe Franciosi --- replay/replay-internal.c | 2

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

"Pavel Dovgalyuk" writes: >> From: Felipe Franciosi [mailto:fel...@nutanix.com] >> If compiling with -Werror=unused-result, replay-internal.c won't build >> due to a call to fwrite() where the returned value is ignored. A simple >> cast to (void) is not sufficient on recent

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

> From: Felipe Franciosi [mailto:fel...@nutanix.com] > If compiling with -Werror=unused-result, replay-internal.c won't build > due to a call to fwrite() where the returned value is ignored. A simple > cast to (void) is not sufficient on recent GCCs, so this fixes it. > > Signed-off-by: Felipe