Re: [Qemu-devel] [PATCH] net: tap: use qemu_set_nonblock

2019-03-11 Thread Jason Wang
On 2019/3/10 下午7:26, Li Qiang wrote: Hi Jason, What's the status of this patch? I don't see it in upstream. Thanks, Li Qiang Sorry, it would be in next pull request for sure. Thanks

Re: [Qemu-devel] [PATCH] net: tap: use qemu_set_nonblock

2019-03-10 Thread Li Qiang
Hi Jason, What's the status of this patch? I don't see it in upstream. Thanks, Li Qiang Jason Wang 于2018年11月22日周四 上午10:22写道： > > On 2018/11/22 上午1:39, Michael S. Tsirkin wrote: > > On Wed, Nov 21, 2018 at 11:30:41AM -0600, Eric Blake wrote: > >> On 11/21/18 6:23 AM, Michael S. Tsirkin wrote:

Re: [Qemu-devel] [PATCH] net: tap: use qemu_set_nonblock

2018-11-21 Thread Jason Wang
On 2018/11/22 上午1:39, Michael S. Tsirkin wrote: On Wed, Nov 21, 2018 at 11:30:41AM -0600, Eric Blake wrote: On 11/21/18 6:23 AM, Michael S. Tsirkin wrote: I agree it is good to preserve fcntl flags though, so this patch looks desirable. Reviewed-by: Daniel P. Berrangé Sure Acked-by:

Re: [Qemu-devel] [PATCH] net: tap: use qemu_set_nonblock

2018-11-21 Thread Michael S. Tsirkin
On Wed, Nov 21, 2018 at 11:30:41AM -0600, Eric Blake wrote: > On 11/21/18 6:23 AM, Michael S. Tsirkin wrote: > > > > > > > I agree it is good to preserve fcntl flags though, so this patch > > > looks desirable. > > > > > > Reviewed-by: Daniel P. Berrangé > > > > Sure > > > > Acked-by:

Re: [Qemu-devel] [PATCH] net: tap: use qemu_set_nonblock

2018-11-21 Thread Eric Blake
On 11/21/18 6:23 AM, Michael S. Tsirkin wrote: I agree it is good to preserve fcntl flags though, so this patch looks desirable. Reviewed-by: Daniel P. Berrangé Sure Acked-by: Michael S. Tsirkin but really not for this release I guess as we are in freeze. We're in freeze, so the

Re: [Qemu-devel] [PATCH] net: tap: use qemu_set_nonblock

2018-11-21 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Wed, Nov 21, 2018 at 11:57:18AM +, Daniel P. Berrangé wrote: >> On Wed, Nov 21, 2018 at 03:28:29PM +0400, Marc-André Lureau wrote: >> > Hi >> > >> > On Wed, Nov 21, 2018 at 3:22 PM Li Qiang wrote: >> > > >> > > The fcntl will change the flags directly, use

Re: [Qemu-devel] [PATCH] net: tap: use qemu_set_nonblock

2018-11-21 Thread Michael S. Tsirkin
On Wed, Nov 21, 2018 at 11:57:18AM +, Daniel P. Berrangé wrote: > On Wed, Nov 21, 2018 at 03:28:29PM +0400, Marc-André Lureau wrote: > > Hi > > > > On Wed, Nov 21, 2018 at 3:22 PM Li Qiang wrote: > > > > > > The fcntl will change the flags directly, use qemu_set_nonblock() > > > instead. > >

Re: [Qemu-devel] [PATCH] net: tap: use qemu_set_nonblock

2018-11-21 Thread Daniel P . Berrangé
On Wed, Nov 21, 2018 at 03:28:29PM +0400, Marc-André Lureau wrote: > Hi > > On Wed, Nov 21, 2018 at 3:22 PM Li Qiang wrote: > > > > The fcntl will change the flags directly, use qemu_set_nonblock() > > instead. > > qemu_set_nonblock() will preserve the existing flags. And on windows, > it will

Re: [Qemu-devel] [PATCH] net: tap: use qemu_set_nonblock

2018-11-21 Thread Li Qiang
Marc-André Lureau 于2018年11月21日周三 下午7:28写道： > Hi > > On Wed, Nov 21, 2018 at 3:22 PM Li Qiang wrote: > > > > The fcntl will change the flags directly, use qemu_set_nonblock() > > instead. > > qemu_set_nonblock() will preserve the existing flags. And on windows, > it will register the FD to the

Re: [Qemu-devel] [PATCH] net: tap: use qemu_set_nonblock

2018-11-21 Thread Marc-André Lureau
Hi On Wed, Nov 21, 2018 at 3:22 PM Li Qiang wrote: > > The fcntl will change the flags directly, use qemu_set_nonblock() > instead. qemu_set_nonblock() will preserve the existing flags. And on windows, it will register the FD to the event loop. that's a reasonable thing to do, is this fixing an