Re: [Qgis-developer] QgsField::length semantic

2016-10-11 Thread Sandro Santilli
On Tue, Oct 11, 2016 at 12:40:21PM +0200, Even Rouault wrote: > Le mardi 11 octobre 2016 12:17:44, Sandro Santilli a écrit : > > Then I think the OGR provider should just avoid setting OFTReal fields > > length/precision values, upon reading (but also upon writing, as long > > as the QgsField

Re: [Qgis-developer] QgsField::length semantic

2016-10-11 Thread Even Rouault
Le mardi 11 octobre 2016 12:17:44, Sandro Santilli a écrit : > On Tue, Oct 11, 2016 at 11:53:27AM +0200, Even Rouault wrote: > > Le mardi 11 octobre 2016 11:42:12, Jürgen E. Fischer a écrit : > > > On Tue, 11. Oct 2016 at 10:45:18 +0200, Sandro Santilli wrote: > > > > Chasing a regression bug upon

Re: [Qgis-developer] QgsField::length semantic

2016-10-11 Thread Sandro Santilli
On Tue, Oct 11, 2016 at 12:11:06PM +0200, Even Rouault wrote: > > According to this: > > http://devzone.advantagedatabase.com/dz/webhelp/advantage9.0/server1/dbf_fi > > eld_types_and_specifications.htm > > > > A DBF field with extended data type "double" does not affect the > > precision of the

Re: [Qgis-developer] QgsField::length semantic

2016-10-11 Thread Even Rouault
> According to this: > http://devzone.advantagedatabase.com/dz/webhelp/advantage9.0/server1/dbf_fi > eld_types_and_specifications.htm > > A DBF field with extended data type "double" does not affect the > precision of the stored data, and the length information is simply > ignored. I had never

Re: [Qgis-developer] QgsField::length semantic

2016-10-11 Thread Sandro Santilli
On Tue, Oct 11, 2016 at 11:42:12AM +0200, Jürgen E. Fischer wrote: > On Tue, 11. Oct 2016 at 10:45:18 +0200, Sandro Santilli wrote: > > Chasing a regression bug upon importing shapefile to postgresql [1] > > I've stumbled upon an unclear semantic of the "length" member of > > QgsField class [2]. >

Re: [Qgis-developer] QgsField::length semantic

2016-10-11 Thread Even Rouault
Le mardi 11 octobre 2016 11:42:12, Jürgen E. Fischer a écrit : > On Tue, 11. Oct 2016 at 10:45:18 +0200, Sandro Santilli wrote: > > Chasing a regression bug upon importing shapefile to postgresql [1] > > I've stumbled upon an unclear semantic of the "length" member of > > QgsField class [2]. > >

Re: [Qgis-developer] QgsField::length semantic

2016-10-11 Thread Jürgen E . Fischer
On Tue, 11. Oct 2016 at 10:45:18 +0200, Sandro Santilli wrote: > Chasing a regression bug upon importing shapefile to postgresql [1] > I've stumbled upon an unclear semantic of the "length" member of > QgsField class [2]. Hm, I though that was following database semantics - at least that's what I

Re: [Qgis-developer] QgsField::length semantic

2016-10-11 Thread Sandro Santilli
Adding Arnaud to the loop, being the author of the PR which added constrained numeric fields in PostgreSQL provider [1] [1] https://github.com/qgis/qgis/commit/92f71b696ca93c792ae5602ed82863fcef0e5006 Arnaud: what was the reason for constraining that field ? The semantic of QgsField's length and

Re: [Qgis-developer] QgsField::length semantic

2016-10-11 Thread Paolo Cavallini
Il 11 ottobre 2016 10:45:18 CEST, Sandro Santilli ha scritto: >Chasing a regression bug upon importing shapefile to postgresql [1] >I've stumbled upon an unclear semantic of the "length" member of >QgsField class [2]. > >The Ogr provider, upon loading shapefiles, uses the DBF field

[Qgis-developer] QgsField::length semantic

2016-10-11 Thread Sandro Santilli
Chasing a regression bug upon importing shapefile to postgresql [1] I've stumbled upon an unclear semantic of the "length" member of QgsField class [2]. The Ogr provider, upon loading shapefiles, uses the DBF field width _minus_one_, for reasons that are unknown to me. Upon writing a layer to