[quagga-dev 16285] CI Testresult: FAILED (Re: [quagga-dev, 16282, v2, 10/10] bgpd: avoid looping when unselecting a list of mpath entries)

Continous Integration Result: FAILED See below for issues. This is an EXPERIMENTAL automated CI system. For questions and feedback, feel free to email Martin Winter . Patches applied : Patchwork 2125: http://patchwork.quagga.net/patch/2125

[quagga-dev 16260] Re: [PATCHv3 1/4] bgpd: eliminate RD related duplicate code in bgp_encap.c decode_rd_... apis are declared global in bgp_mplsvpn.c

On Mon, Oct 10, 2016 at 8:36 PM, Lou Berger wrote: Hello Lou, > --- > bgpd/bgp_encap.c | 45 - > bgpd/bgp_mplsvpn.c | 8 > bgpd/bgp_mplsvpn.h | 5 + > 3 files changed, 9 insertions(+), 49 deletions(-) > It is

[quagga-dev 16264] Re: [PATCH 2/2] lib: move and complete RD library to rd.[ch] files

On Wed, 12 Oct 2016, Philippe Guibert wrote: +u_int16_t +decode_rd_type (u_char *pnt) +{ + u_int16_t v; + + v = ((u_int16_t) *pnt++ << 8); + v |= (u_int16_t) *pnt; + + return v; +} + +/* type == RD_TYPE_AS */ +void +decode_rd_as (u_char *pnt, struct rd_as *rd_as) +{ + rd_as->as =

[quagga-dev 16263] [PATCH 2/2] lib: move and complete RD library to rd.[ch] files

Move rd structure handling routines into a common file. This API is used by BGP daemons when handling SAFI MPLS and SAFI ENCAP address sub families. This could also to be used as library for other daemons. Signed-off-by: Philippe Guibert --- bgpd/bgp_encap.c | 2

[quagga-dev 16262] [PATCH 1/2] bgpd: eliminate RD related duplicate code in bgp_encap.c decode_rd_... apis are declared global in bgp_mplsvpn.c

From: Lou Berger --- bgpd/bgp_encap.c | 45 - bgpd/bgp_mplsvpn.c | 8 bgpd/bgp_mplsvpn.h | 5 + 3 files changed, 9 insertions(+), 49 deletions(-) diff --git a/bgpd/bgp_encap.c b/bgpd/bgp_encap.c index

[quagga-dev 16261] [PATCH 0/2] Route Distinguisher utilities move to lib

This patch is moving the initial RD functions into one dedicated library file. It follows a patch from Lou, where a beginning of factorisation has begun. This patch proposes to go further by pushing route distinguisher to a separate library. Behind that commit, it lies the idea that several

[quagga-dev 16265] CI Testresult: PASSED (Re: [quagga-dev, 16263, 2/2] lib: move and complete RD library to rd.[ch] files)

Continous Integration Result: SUCCESSFUL Congratulations, this patch passed basic tests Tested-by: NetDEF CI System This is an EXPERIMENTAL automated CI system. For questions and feedback, feel free to email Martin Winter . Patches applied :

[quagga-dev 16280] [PATCH v2 08/10] bgpd: apply multipath algorithm to VRF

This commit checks for the maximum path per VRF before running the multipath algorithm. This makes it possible to limit the number of paths for a specific VRF, and not for an other one. Signed-off-by: Philippe Guibert --- bgpd/bgp_mpath.c | 34

[quagga-dev 16279] [PATCH v2 05/10] bgpd: VRF RIB log updates enhancement

On adding/removing/updating NLRI entries into VRF RIB tables, a BGP event is fired. Note that only selected entries, and entries that are part of multipath entries, and where one of the multipath entry is selected. Signed-off-by: Philippe Guibert --- bgpd/bgp_route.c

[quagga-dev 16276] [PATCH v2 01/10] tests: fix BGP VRF interactions

From: David Lamparter Signed-off-by: David Lamparter Signed-off-by: Philippe Guibert --- tests/Makefile.am | 2 +- tests/bgp_mpath_test.c | 15 +++ 2 files changed, 16 insertions(+), 1

[quagga-dev 16281] [PATCH v2 09/10] bgpd: sanity check against accessing invalid table pointer.

This sanity check has been discovered when running bgp mpath_tests that are available in tests folder. Signed-off-by: Philippe Guibert --- bgpd/bgp_mpath.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bgpd/bgp_mpath.c b/bgpd/bgp_mpath.c index

[quagga-dev 16274] [PATCH v1 09/10] *: enhance memtype and memgroup generation across lib and daemons

This commit introduces a bash script called from Makefile from each lib/daemon. Upon call, this script takes as input a txt file describing the various memory group and type that need to be defined, initialised and declared. The output of this script is 2 .c and .h files used for compilation

[quagga-dev 16273] [PATCH v1 05/10] *: split & distribute memtypes

From: David Lamparter This is a rather large mechanical commit that splits up the memory types defined in lib/memtypes.c and distributes them into *_memory.[ch] files in the individual daemons. The zebra change is slightly annoying because there is no nice place to

[quagga-dev 16272] [PATCH v1 07/10] *: declare and init mgroup and mtype for all lib/daemons

This commit centralises the memory group and memory types declarations into one single place for each daemon/library. In this case, files affected are /_memory.[ch]. In order to be used, the memory groups and memory types have to be manually initialised. This is why the daemons are initialising

[quagga-dev 16271] [PATCH v1 06/10] *: stop (re|ab)using lib/ MTYPEs

From: David Lamparter bgpd, ospf6d, isisd and some tests were reusing MTYPEs defined in the library for its own use. This is bad practice and will break with the later commit making the library's MTYPEs static. Signed-off-by: David Lamparter

[quagga-dev 16269] [PATCH v1 02/10] lib: add new extensible memory-type handling

From: David Lamparter This rewrites Quagga's memory per-type allocation counting, without using a fixed global list of types. Instead, source files can declare memory types which get handled through constructor functions called by the dynamic linker during

[quagga-dev 16273] [PATCH v1 10/10] lib: clean/restore memory debugging functions

This adapts the dump-at-exit handler and removes the old leftover code. (Note the text in log_memtype_stderr was actually incorrect as the only caller in bgpd cleans up configuration before calling it, i.e. any remaining allocations are missing-cleanup bugs.) Signed-off-by: David Lamparter

[quagga-dev 16266] [PATCH v1 00/10] VRF Import Processing + VRF Multipath

This series of patch is the following of VRF and VRF RIB tables introduction in BGP. It enhances the import processing algorithm: it reuses the export route target extended community, as well as the local import route target configured per VRF, to append/remove NLRI entries from VPNv4 into VRF RIB

[quagga-dev 16268] [PATCH v1 03/10] lib: remove constructor reference

because some compilers do not use this feature, it is provided an API that forces the user to call its mem group and memtypes init. Signed-off-by: Philippe Guibert --- lib/memory.h | 24 ++-- 1 file changed, 2 insertions(+), 22 deletions(-) diff

[quagga-dev 16272] [PATCH v1 08/10] *: static mgroup and mtypes are locally declared and initialised

On some specific cases, the user may wish not to export its memory type and group. The user can then declare and initialises this memory type, provided that he ensures also the initialisation. The goal of that commit is initialising in quagga the static mtypes. Signed-off-by: Philippe Guibert

[quagga-dev 16277] [PATCH v2 03/10] bgpd: detect if bgp_info is multipath entry

Enhance a function that permits knowing if two entries belong to the same multipath group. Signed-off-by: Philippe Guibert --- bgpd/bgp_mpath.c | 15 +++ bgpd/bgp_mpath.h | 1 + 2 files changed, 16 insertions(+) diff --git a/bgpd/bgp_mpath.c

[quagga-dev 16276] [PATCH v2 02/10] bgpd: BGP VRF processing handling

NLRI entries received from MP-BGP peer exchange are exported in VRF RIB tables. This commit introduces the BGP VRF processing handler that can be used for further processing into VRF RIB tables: best selection algorithm, multipath. Signed-off-by: Philippe Guibert ---

[quagga-dev 16278] [PATCH v2 04/10] bgpd: VRF import processing

From: Christian Franke This enhancement permits to export received or locally set route entries for MPLS VPN, to the appropriate VRF. By introducing the RFC4360 and BGP extended communities, some export route target are received on BGP update, or some import route

[quagga-dev 16286] Open Bugs on Master (new compared to last release)

Here is my list from the tests of actual new bugs in quagga master: ——— Test ANVL-BGPPLUS-21.1: ProtocolBGP IPv6 Reference RFC RFC 4271, Sect. 4.5, p 20, NOTIFICATION message format) Issue: No BGP notification sent by Quagga on Protocol violation In my tests, I configure a IPv6 BGP peer on

[quagga-dev 16284] CI Testresult: FAILED (Re: [quagga-dev, 16273, v1, 10/10] lib: clean/restore memory debugging functions)

Continous Integration Result: FAILED See below for issues. This is an EXPERIMENTAL automated CI system. For questions and feedback, feel free to email Martin Winter . Patches applied : Patchwork 2120: http://patchwork.quagga.net/patch/2120