Hi !
I have a little problem here. r3169, "Enable warnings on first load
only. File which are loaded but raise an exception are not added to
loaded set" http://dev.rubyonrails.org/changeset/3169 causes stack
level too deep errors while loading my models, using the console.
$ svn up -r3169 vendor
Hi !
2005/11/24, Trevor Squires <[EMAIL PROTECTED]>:
> this issue went away for me after svn upping to the latest rev (3188
> for me).
Yes, I concur. Sorry for the noise. I also just found my real problem:
class TransactionMember < ActiveRecord::Base
belongs_to :transaction, :class_name => '
2005/11/24, Michael Koziarski <[EMAIL PROTECTED]>:
> SystemStackError isn't the user experience we're after though...
>
> Was there anything in your logs warning you that you'd overridden transaction?
Nope, and I have had the same kind of error with other base class
methods: quote, transaction.
2005/11/24, Jeremy Kemper <[EMAIL PROTECTED]>:
> Bummer. The whole point of this warnings stuff is so that you get a
> message in your logs telling you that you're overriding an existing
> method. If you're on FastCGI, the message will appear in your
> web server's error log, not in development.l
Hi !
I just spent an hour refactoring the patch in #3005 so it was
applicable again. Is there a way to make patches go in faster ? Can a
committer apply the patch so it doesn't get out of date anymore ?
Another plus is I wouldn't have to do patch management on my end too
:) DRY they say !
Than
Hello all,
I'd like to get a review of ticket #3005: http://dev.rubyonrails.org/ticket/3005
This patch prevents the following kind of errors:
class QuoteLine < AR:Base
belongs_to :quote
end
QuoteLine.find_by_product_id(312)
SELECT * FROM quote_lines WHERE product_id = <#Quote:0x39420>
#quote
Hi !
Another patch that I feel needs more attention:
http://dev.rubyonrails.org/ticket/3024
This patch ensures aggregations are reloaded when the parent record
is. This bit me during unit testing. I was going bonkers thinking
there was something wrong with my code.
Anyway, this patch applies t
Hello Michael,
2005/12/5, Michael Koziarski <[EMAIL PROTECTED]>:
> On 12/6/05, Francois Beausoleil <[EMAIL PROTECTED]> wrote:
> > Hello all,
> >
> > I'd like to get a review of ticket #3005:
> > http://dev.rubyonrails.org/ticket/3005
>
> I
Hi all !
http://dev.rubyonrails.org/ticket/3042
Just a heads up that this is a three line patch, easily applied.
This is important when testing PayPal integration with the PayPal
library. Paypal::Notification requires access to the raw POST data.
It's either that, or a patch is sent to the Pay
Hi !
2005/12/5, Michael Koziarski <[EMAIL PROTECTED]>:
> On 12/6/05, Francois Beausoleil <[EMAIL PROTECTED]> wrote:
> > Hello all,
> >
> > I'd like to get a review of ticket #3005:
> > http://dev.rubyonrails.org/ticket/3005
>
> I like the ge
2005/12/7, Duane Johnson <[EMAIL PROTECTED]>:
> > ./script/../config/../vendor/rails/railties/lib/commands/runner.rb:27:
> > Columns 'name', 'transaction', 'quote' have already been taken in
> > models of class Game. You will have to rename your columns to not
> > conflict with pre-existing method
2005/12/7, Michael Koziarski <[EMAIL PROTECTED]>:
> Why are you taking the class methods as well? Column names won't
> conflict with class methods.
Because you won't be able to start a transaction on a model instance otherwise:
Game.find(1).transaction do
# Do stuff on game
end
I verified whi
Hi !
2005/12/7, Duane Johnson <[EMAIL PROTECTED]>:
> On Dec 7, 2005, at 2:23 PM, Francois Beausoleil wrote:
> > So, we do in fact have to gobble up the class methods. Maybe this is
> > an instance of Ruby being too helpful ?
>
> class RubyBeingTooHelpful; end
> inst
Hi !
I have an instance where I'd like to use the automatic value quoting
that sanitize conditions provides. Here's the SQL:
SELECT COUNT(*) FROM tournaments
INNER JOIN entries ON entries.tournament_id = tournaments.id
INNER JOIN plays ON plays.entry_id = entries.id
WHERE #{self.class.sanit
2005/12/8, Michael Koziarski <[EMAIL PROTECTED]>:
> On 12/9/05, Francois Beausoleil <[EMAIL PROTECTED]> wrote:
> > Is there a particular reason why this is protected ?
>
> Usually methods are marked as protected when we don't want to make
> them part of the pub
Hi all !
http://dev.rubyonrails.org/ticket/2917
In the interest of symmetry, it would be a good idea to have
#collection_singular_ids present, just like we have
#collection_singular_ids= for HABTM relationships.
This has an impact on the HABTM Helper Plugin where users need to add
a method to th
2005/12/7, Francois Beausoleil <[EMAIL PROTECTED]>:
> In the end, we're trying to keep the principle of least surprise
> active. What's less suprising:
>
> instance.transaction = Transaction.new
> # NoMethodError
>
> - OR -
>
> instance.transaction do
&g
Hey !
2005/12/9, Francois Beausoleil <[EMAIL PROTECTED]>:
> 2005/12/7, Francois Beausoleil <[EMAIL PROTECTED]>:
> > In the end, we're trying to keep the principle of least surprise
> > active. What's less suprising:
>
> So, what do we do ? We could a
2005/12/14, Wilson Bilkovich <[EMAIL PROTECTED]>:
> What if the patch were the 'full bonanza', combining both of the
> earlier ones, with a special exception for the 'type' column, since
> that one would be a hassle, and is going away soon via a Ruby update
> anyway?
>
> Even better, these checks c
Hi !
I don't know if you've seen the thread on the main Rails ML, but I
found a problem in Rails handling of session stores.
I configured the ActiveRecord session store, but had no sessions
table. Rails did not automatically create the table, nor did it
report the missing table in the log, and f
Hi !
In http://thread.gmane.org/gmane.comp.lang.ruby.rails/39798 Damon Hill
has a problem with afterUpdateElement. Now, I need the same
functionnality, and I'm missing it too.
The problem is with
ActionView::Helpers::JavaScriptMacrosHelper::auto_complete_field.
#auto_complete_field knows about
Hi !
2006/1/27, Norman Timmler <[EMAIL PROTECTED]>:
> validates_presence_of :email_address, :message => 'Give me an address!'
> validates_format_of :email_address, :with => /[EMAIL PROTECTED],}/,
> :message => 'Something's wrong with your address!'
In this specific case, could
2006/2/3, Jeremy Hopple <[EMAIL PROTECTED]>:
> Anyone else seen this?
Confirmed. Win XP SP2, Ruby 1.8.2, Edge Rails (r3524).
WEBrick does that. Haven't tried SCGI yet. If you look at
http://article.gmane.org/gmane.comp.lang.ruby.rails/45409
You'll see the stack trace I got. Forget the rest o
Hi !
2006/2/12, Tobias Luetke <[EMAIL PROTECTED]>:
> huh? that would break url_for, link_to, textilize, markdown and every
> single other helper which outputs html tags. I use the h helper in
> like 3 different places in shopify, thats definitely the exception.
Am I reading this right ? 3 places
2006/2/12, Tobias Luetke <[EMAIL PROTECTED]>:
> By escaping the html your customers input you potentially disable a
> lot of cool features.
>
> For example we use html to make links in todo list items in basecamp
> all the time. Couldn't do that if it was escaped.
Isn't Textile quite suited to thi
Hello everyone,
Slight problem on Edge Rails:
$ ruby script\console
Loading development environment.
./script/../config/../config/../vendor/rails/activerecord/lib/../../activesupport/lib/active_support/dependencies.rb:129:in
`const_missing':NameError: uninitialized constant LoadingModule
r3525 i
Hi !
2006/2/16, Francois Beausoleil <[EMAIL PROTECTED]>:
./script/../config/../config/../vendor/rails/activerecord/lib/../../activesupport/lib/active_support/dependencies.rb:129:in
> `const_missing':NameError: uninitialized constant LoadingModule
Of course, now that I tested
Hi !
I was taking another look at http://dev.rubyonrails.org/ticket/3005
I reread the discussion we had here in late December:
http://thread.gmane.org/gmane.comp.lang.ruby.rails.core/41
The patch still applies cleanly. After removing the exceptions we had
talked about, now I have another proble
http://dev.rubyonrails.org/ticket/3270
I added a bunch of tests. Need someone to review and apply.
Bye !
--
François Beausoleil
http://blog.teksol.info/
___
Rails-core mailing list
Rails-core@lists.rubyonrails.org
http://lists.rubyonrails.org/mailman/l
Hi all !
r3679 | bitsweat | 2006-02-26 19:27:48 -0500 | 1 line
Define attribute query methods to avoid method_missing calls. Closes #3677.
Unfortunate
As long as we're on the subject of integrating patches, what about this:
http://dev.rubyonrails.org/ticket/3042
TestRequest#raw_post is missing from trunk. That's what this patch
adds, and it even has a simple test.
Bye !
--
François Beausoleil
http://blog.teksol.info/
__
Hi !
Just wondering here, because if I define reader methods, then these
aren't used in the forms.
For example, I have this:
class Customer
def tax_rate
(read_attribute(:tax_rate) * 100.0).to_i
end
def tax_rate=(rate)
write_attribute(:tax_rate, rate / 100.0)
end
end
<%= text_fie
2006/3/5, Michael Koziarski <[EMAIL PROTECTED]>:
> On 3/6/06, Francois Beausoleil <[EMAIL PROTECTED]> wrote:
> > class Customer
> > def tax_rate
> > (read_attribute(:tax_rate) * 100.0).to_i
> > end
> >
> > def tax_rate=(rate)
> &g
2006/3/5, Michael Koziarski <[EMAIL PROTECTED]>:
> See
> http://dev.rubyonrails.org/browser/trunk/activerecord/lib/active_record/base.rb#L1561
>
> if you implement your own _before_type_cast methods you should be
> fine. Why not just define a separate accessor though, i.e. one
> used during ca
Hi !
I have these models:
class Invoice < AR::Base
has_many :lines, :class_name => 'InvoiceLine'
end
class InvoiceLine < AR::Base
belongs_to :invoice
end
This fails at the console:
$ ruby script\console
Loading development environment.
>> invoice = Invoice.new
=> #
>> line = invoice.lines.
2006/3/8, Duane Johnson <[EMAIL PROTECTED]>:
> I've also come up to this oddity and I'd like to know the answer to
> the questions pose--is the author of the original code present, or an
> otherwise knowledgeable person who could answer?
Ok, I found the solution:
http://blog.teksol.info/articles/
2006/3/8, Francois Beausoleil <[EMAIL PROTECTED]>:
> class Child < AR::Base
> validates_presence_of :parent_id
> end
http://dev.rubyonrails.org/ticket/4147
--
François Beausoleil
http://blog.teksol.info/
___
Rails-core maili
Hello Michael,
2006/3/12, Michael Koziarski <[EMAIL PROTECTED]>:
> I've had some reports of edge rails not working for windows when svn
> isn't available in your path. Specifically, running rake migrate.
> Does anyone have a windows installation around to test on?
Hmm, don't see that on r3856.
http://dev.rubyonrails.org/changeset/3804
This test case fails in r3804 and later:
class CategoriesControllerTest < Test::Unit::TestCase
fixtures :categories_screenshots
def test_update
...
end
end
11) Error:
test_update_accepts_screenshot(CategoriesControllerTest):
FixtureClassNotFo
2006/3/13, Rick Olson <[EMAIL PROTECTED]>:
> What are you trying to do? If this is a habtm, there is no join
Load the fixtures on setup.
> model, so you shouldn't be calling categories_screenshots(:foo). If
> it is a join model that's named differently, then you need to set the
> proper fixture
Hi !
rollback_db_transaction() states:
"" Rolls back the transaction (and turns on auto-committing). Must be
done if the transaction block raises an exception or returns false. ""
The implementation does not support that statement:
http://dev.rubyonrails.org/browser/trunk/activerecord/lib/active_
http://dev.rubyonrails.org/changeset/3981
?!?
The changes are a rename of RailsInfoController to
Rails::InfoController. That seems to be completely unrelated to this
error:
$ ruby script\server
=> Booting WEBrick...
./script/../config/../vendor/rails/activesupport/lib/active_support/inflector.r
Hello James,
2006/3/21, James Adam <[EMAIL PROTECTED]>:
> I have seen this error recently - have you updated to the latest
> version of Engines trunk? It stems from a recursive failure during the
> redefinition of require_or_load, because the Rails::VERSION module
> wasn't already loaded. It shoul
Hi !
Having a problem here. I'm fighting ActiveRecord really.
ActiveRecord depends on Transaction::Simple, and helpfully bundles
simple.rb. Great, except it doesn't work with PDF::Writer and
PDF::SimpleTable. PDF::SimpleTable requires transaction/group, which
is NOT bundled.
Two solutions:
1.
Hi !
I have two apps really: the frontend and the backend. Apache has an
Alias directive which directs traffic normally destined to
public/images to another folder.
The problem is that r4098 attemps to do a File.stat on a non-existent
file. This is the breakage I'm talking about.
Next, I'd lik
Hi !
Quick question: what should ActionView::Base do when render(:partial
=> '', :collection => nil) is called ?
1. Don't render anything
2. Render once (current behavior, breaks some views)
3. Raise something
I'm inclined to think #1 is the best. What do you people think ?
Bye !
--
François
Hi !
2006/4/3, Chris Hall <[EMAIL PROTECTED]>:
> anyways, my problem is on the last two steps. i've created the diff, but
> that doesn't indicate that the new directory was created and the file moved.
> how would I go about indicating that in a patch? should i create a small
> script to automat
Hi !
dev.rubyonrails.org and dev.rubyonrails.org are both down.
BTW, which is the "real" domain, the canonical one.
Thanks !
--
François Beausoleil
http://blog.teksol.info/
___
Rails-core mailing list
Rails-core@lists.rubyonrails.org
http://lists.rubyo
http://dev.rubyonrails.org/ticket/4732
I'd like to push to get this included in core. I have often
complained that Rails should not bundle Transaction::Simple:
http://thread.gmane.org/gmane.comp.lang.ruby.rails/32629
http://thread.gmane.org/gmane.comp.lang.ruby.rails.core/916
This patch at leas
Hello everyone !
I'm just wondering what your expectations would be if you saw that code:
def edit
@contact = Contact.find(params[:id])
@contact.phone.attributes = params[:phone]
return if @contact.update_attributes(params[:contact])
# handle validation errors
end
What do you expect the
Hello Benjamin,
2006/4/21, Benjamin Curtis <[EMAIL PROTECTED]>:
> Thoughts?
Little bug. On http://www.agilewebdevelopment.com/plugins/show/16,
click Jonathan's name. You end up on Emanuel's page...
Nice stuff, and I like the design too. I'm missing the part of the
brain which understands how t
Hi !
File:
actionpack/lib/action_controller/templates/rescues/routing_error.rhtml:4
Has tabs instead of spaces for indenting. That causes an Application
Error on Win32.
Simply replace the tabs with spaces and everything works again. Do we
need a patch for something like this ? We should proba
Hello David !
2006/4/29, David Felstead <[EMAIL PROTECTED]>:
I've created a couple of useful helpers that automatically generate
the tags for the submit button/link, the busy indicator and the
related javascript, and was wondering if it's worth sumitting an
enhancement patch for? It's very simp
Hi all !
I am adding observers to some model objects. One of these uses
RailsCron. RailsCron adds a class method to ActiveRecord::Base.
Unfortunately, during the initialization phase, plugins aren't yet
loaded, so I can't setup my observers in config/environment.rb, as
suggested by the commen
http://dev.rubyonrails.org/ticket/5167
Small patch that adds a new generator for observers. I never remember
what to inherit from when I want a new observer. That solves the
problem nicely and simply.
Didn't put a lot of options in this. A further patch could optionally
generate the proper af
Hello all !
Since r4397, I have 27 errors in my functional tests. Let me recap a bit:
r4393: All tests green
r4394: 2 errors, one corrected [content_edit_url(:id => @content)
transformed to content_edit_url(:id => @content.id)]
r4395: Same error
r4397: 27 errors in all
The first error I hit up
Hello Pete,
2006/6/2, Pete Forde <[EMAIL PROTECTED]>:
I've recently submitted two patches (#5122 and #5266) to the Rails trac.
These patches are actually for Prototype. There appears to be very little
discussion about Prototype on this list, but I wanted to share what I've
been doing in the hope
http://dev.rubyonrails.org/ticket/3677
Lots and lots of links. I received a couple last week, but they
seemed to have been resolved before I visited the issue.
Bye,
François
___
Rails-core mailing list
Rails-core@lists.rubyonrails.org
http://lists.rub
http://dev.rubyonrails.org/ticket/5390
The AR Rakefile did not pickup the test files ending with the current
adapter's name. This patch corrects the problem.
Bye !
--
François Beausoleil
http://blog.teksol.info/
___
Rails-core mailing list
Rails-core@
Hi !
I get a failure for
RawPostDataTest#test_put_with_empty_content_type_ignores_body at
r4498:
2) Error:
test_put_with_empty_content_type_ignores_body(RawPostDataTest):
NoMethodError: undefined method `downcase' for nil:NilClass
./test/controller/../../lib/action_controller/cgi_ext/raw_po
Hi all,
I seem to have a problem. I attached a test case which I can't make
pass. The route was extracted verbatim from an existing application.
If I rollback in time to r4393, the tests pass.
The route is:
map.game_instructions 'game/:game/instructions', :controller => 'games',
:action =>
Ah ha !
2006/6/28, Jamis Buck <[EMAIL PROTECTED]>:
I suspect the problem is that the :game regex has \A and \Z in it.
Because the new routes put that verbatim into the larger route regex,
the match will fail. (Ditto for the /^.*$/ regex, with the ^ and $
anchors.) I *think* (Nicholas, correct me
Hello Jean-François,
2006/6/28, Jean-François <[EMAIL PROTECTED]>:
By the way, isn't \A \z better than \A \Z ?
Actually, you might be right, except in this case it doesn't matter.
From "Programming Ruby" 2nd edition, p. 70, section Anchors:
"""The sequence \A matches the beginning of a string
Hello Nicholas !
2006/6/28, Nicholas Seckar <[EMAIL PROTECTED]>:
Perhaps we should add an informative error message for this case. Feel free
to weight in if you think so. (Or better yet, send a diff + unit test.)
I will, I only need a pointer on where I should start searching. With
that, I'll
Hi !
2006/6/28, Nicholas Seckar <[EMAIL PROTECTED]>:
Awesome.
There are two places Regexp's appear. They are attached to segments in the
path as segment.regexp (See DynamicSegment.) and they also appear on the
route's requirements hash (route.requirements.)
However they both pass thru RouteBui
Hello Luke,
2006/8/16, Luke Redpath <[EMAIL PROTECTED]>:
Expected /Users/luke/Sandbox/projects/rails_plugin_repository/
config/../vendor/plugins/unobtrusive_javascript/lib/
unobtrusive_javascript.rb to define UnobtrusiveJavascript
I get the same kind of error in the test environment:
Expected
Hello Keith,
2006/8/17, Keith Morrison <[EMAIL PROTECTED]>:
Comments, questions, suggestions?
My tests are defined like this now:
# test/functional/admin_controller_test.rb
class UnauthenticatedAccessToAdminSectionTest < Test::Unit::TestCase
def setup
@controller = AdminController.new
Hi all,
http://dev.rubyonrails.org/ticket/3833
I updated the patch for r4807. If someone could apply this, I'd be grateful.
Thanks !
François
___
Rails-core mailing list
Rails-core@lists.rubyonrails.org
http://lists.rubyonrails.org/mailman/listinfo/r
68 matches
Mail list logo
