Re: [Replicant] [PATCH] Hide information leaking phone number lookup settings

2019-10-10 Thread Joonas Kylmälä
Hi, Denis 'GNUtoo' Carikli: >> The phone number lookup service leaks private information so hide the >> option to enable it. > It may be a good idea to give a bit more context by explaining that it > needs to be hidden because the "Disable phone number lookup settings > during upgrade" only disabl

Re: [Replicant] [PATCH] Hide information leaking phone number lookup settings

2019-10-10 Thread Joonas Kylmälä
Hi, Joonas Kylmälä: >> Note that I didn't have time to look into the broader context of that >> patch yet, so I don't know if lookupSettingsHeader should be completely >> removed or not. > > I will remove it completely in v2. Thanks for the review! oh actually

Re: [Replicant] [PATCH v2] Add native Android support for external WiFi dongles

2019-10-12 Thread Joonas Kylmälä
Hi, I'm a bit worried about removing the code about multicast packet filtering. Would this have some sort of effect on the firewall configuration? You also dropped the signed-off-by line and the description why bluetooth and the packet filter needs to be removed, please add those back for v3. Jo

Re: [Replicant] [PATCH v3] Add native Android support for external WiFi dongles

2019-10-12 Thread Joonas Kylmälä
Hi, removing the multicast packet filtering is not ideal but I checked the RepWifi code and it doesn't seem to be setting any packet filters either so that seems to be a separate problem to be solved. Otherwise the patch seems okay and I have tested it works: Acked-by: Joonas Kylmälä Tha

[Replicant] [PATCH v2] Hide information leaking phone number lookup settings

2019-10-12 Thread Joonas Kylmälä
The phone number lookup service leaks private information so hide the option to enable it. The lookup service is by default disabled so this guarantees no information gets leaked if the user would accidentally enable the service. Signed-off-by: Joonas Kylmälä --- src/com/android/dialer/settings

Re: [Replicant] [PATCH v2] Hide information leaking phone number lookup settings

2019-10-13 Thread Joonas Kylmälä
is mail topic. > > Thanks, > > - Fil Lupin. > > ‐‐‐ Original Message ‐‐‐ > On Saturday, October 12, 2019 7:15 PM, Joonas Kylmälä > wrote: > >> The phone number lookup service leaks private information so hide the >> option to enable it. The lookup se

Re: [Replicant] [PATCH 0/7] Per process libagl/llvmpipe

2019-10-13 Thread Joonas Kylmälä
default opengles renderer. > > Andrés Domínguez > > El jue., 10 oct. 2019 a las 20:07, Joonas Kylmälä () > escribió: > >> Hi, >> >> so we didn't get anyone to review these patches except the last one: >> <https://redmine.replicant.us/issues/1844#no

Re: [Replicant] [PATCH] Include F-droid's Offline Calendar as a prebuild

2019-10-13 Thread Joonas Kylmälä
Hi, please send two patches: 1 to remove f-droid and 1 to include offline calendar. Also add signed-off-by line. Also would be nice to have a description why Offline Calendar app and not some other calendar app. And descriptoin for why F-droid is removed. Joonas Andrés Domínguez: > --- > confi

Re: [Replicant] [PATCH] Add libagl override for surfaceflinger

2019-10-13 Thread Joonas Kylmälä
Hi, please explain in the patch what is libagl override for surfaceflinger and add your signed-off-by line. Joonas Andrés Domínguez: > --- > config/common.mk | 4 > prebuilt/common/etc/libGLES_android/system/bin/surfaceflinger | 0 > 2 files cha

Re: [Replicant] [PATCH 0/7] Per process libagl/llvmpipe

2019-10-14 Thread Joonas Kylmälä
Hi, pushed all except the last patch. Joonas Kylmälä: > Hi, > > thanks for the reply! > > I'm planning to push these patches tomorrow so if you have any > objections please do that now. > > Joonas > > Andrés Domínguez: >> Hi. >> >>

Re: [Replicant] [PATCH v3] Add native Android support for external WiFi dongles

2019-10-14 Thread Joonas Kylmälä
Hi, I have pushed it now here: <https://git.replicant.us/replicant/frameworks_opt_net_wifi/log/?h=replicant-6.0>. It still needs to be added to the manifest which I will submit a patch in a moment. Joonas Joonas Kylmälä: > Hi, > > removing the multicast packet filtering is

[Replicant] [PATCH] Use Replicant's fork of frameworks/opt/net/wifi

2019-10-14 Thread Joonas Kylmälä
Signed-off-by: Joonas Kylmälä --- default.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/default.xml b/default.xml index ca727c1..ed52512 100644 --- a/default.xml +++ b/default.xml @@ -167,7 +167,7 @@ - + -- 2.11.0

Re: [Replicant] [PATCH] Use Replicant's fork of frameworks/opt/net/wifi

2019-10-14 Thread Joonas Kylmälä
Hi, this is for the manifest repo: https://git.replicant.us/replicant/manifest/ Joonas Joonas Kylmälä: > Signed-off-by: Joonas Kylmälä > --- > default.xml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/default.xml b/default.xml > index ca

[Replicant] Security fix causing crash that blocks Replicant 6.0 0004 release

2019-10-14 Thread Joonas Kylmälä
Hi, we investigated today a system server crash: . It was bisected to commit . If anybody has suggestions how to fix this please let us know! This is causin

Re: [Replicant] Security fix causing crash that blocks Replicant 6.0 0004 release

2019-10-14 Thread Joonas Kylmälä
gt; > On Mon, Oct 14, 2019 at 9:38 PM Joonas Kylmälä wrote: >> >> Hi, >> >> we investigated today a system server crash: >> <http://paste.debian.net/plain/1106710>. It was bisected to commit >> <https://git.replicant.us/replicant/frameworks_av/commit/

Re: [Replicant] pinephone chief wants to ship phones to a replicant manager denis please read this post

2019-10-17 Thread Joonas Kylmälä
Andrés Domínguez: > I also mentioned the non-free firmware for WIFI, but I tell him that the > display firmware would make a port of Replicant to it impossible. depends how simple the hardware is. We could write free firmware if there is no signature checking. Joonas _

Re: [Replicant] Security fix causing crash that blocks Replicant 6.0 0004 release

2019-10-19 Thread Joonas Kylmälä
ount. I don't have a > google account though and don't particularly want one. It might be worth > asking them to provide a different login option so that we can > collaborate with them closer. > > Cordially, > Kurtis > > Joonas Kylmälä: >> Hi, >> >> yea

Re: [Replicant] [PATCH] Use Replicant's fork of frameworks/opt/net/wifi

2019-10-19 Thread Joonas Kylmälä
This is pushed now. Belgin Știrbu: > >Signed-off-by: Joonas Kylmälä <https://lists.osuosl.org/mailman/listinfo/replicant>> > > Acked-by: Belgin Stirbu > >   Belgin > ___ > Replicant mailing list > Replicant@o

[Replicant] [PATCH] Revert "Backport: OMXNodeInstance: use a lock around OMX::freeNode"

2019-10-19 Thread Joonas Kylmälä
mx.so Signed-off-by: Joonas Kylmälä --- media/libstagefright/omx/OMXNodeInstance.cpp | 4 1 file changed, 4 deletions(-) diff --git a/media/libstagefright/omx/OMXNodeInstance.cpp b/media/libstagefright/omx/OMXNodeInstance.cpp index 6f1ba9b6b..04d0b258a 100644 --- a/media/libstagefrigh

Re: [Replicant] [PATCH] espresso: Add support for USB Ethernet adapters and CDC Ethernet

2019-10-20 Thread Joonas Kylmälä
Hi, I have pushed this now since it was tested with success in https://redmine.replicant.us/issues/1889 and more than one week has passed and nobody reviewed this patch. Denis 'GNUtoo' Carikli: > Signed-off-by: Denis 'GNUtoo' Carikli > --- > arch/arm/configs/espresso_defconfig | 14

[Replicant] [PATCH v3] Remove phone number lookup settings in the graphical interface

2019-10-27 Thread Joonas Kylmälä
ff-by: Joonas Kylmälä --- src/com/android/dialer/settings/DialerSettingsActivity.java | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/com/android/dialer/settings/DialerSettingsActivity.java b/src/com/android/dialer/settings/DialerSettingsActivity.java index 52d91104..8db2e809 100644 ---

[Replicant] [PATCH] Replicant 6.0 0004 images release

2019-10-27 Thread Joonas Kylmälä
Signed-off-by: Joonas Kylmälä --- CHANGELOG.mkdn | 10 ++ config/common.mk | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.mkdn b/CHANGELOG.mkdn index bb654f14..9c9eb960 100644 --- a/CHANGELOG.mkdn +++ b/CHANGELOG.mkdn @@ -1,6 +1,16 @@ Replicant

Re: [Replicant] [PATCH] Replicant 6.0 0004 images release

2019-10-27 Thread Joonas Kylmälä
This should be applied to vendor/replicant. Joonas Kylmälä: > Signed-off-by: Joonas Kylmälä > --- > CHANGELOG.mkdn | 10 ++ > config/common.mk | 2 +- > 2 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/CHANGELOG.mkdn b/CHANGELOG.mkdn >

Re: [Replicant] [PATCH][kernel/samsung/smdk4412] i9305: enable rt2500usb

2019-12-11 Thread Joonas Kylmälä
Hi, please remove the extra colon ":" in "gnu...@cyberdimension.org:: Added more context in the commit message" and then feel free to add Acked-by: Joonas Kylmälä and push the patch! Denis 'GNUtoo' Carikli: > From: Joonas Kylmälä > > Some compat

Re: [Replicant] [PATCH] Replicant 6.0 0004 images release

2020-01-03 Thread Joonas Kylmälä
Hi, if you can wait until Monday I can send a v2. I would like to reproduce this issue myself also. Denis 'GNUtoo' Carikli: > On Sun, 27 Oct 2019 17:26:57 +0200 > Joonas Kylmälä wrote: > >> Signed-off-by: Joonas Kylmälä >> --- >> CHANGELOG.mkdn | 10

[Replicant] [PATCH v2] Replicant 6.0 0004 images release

2020-01-06 Thread Joonas Kylmälä
Changes since v1: - Bump Replicant version in the sign-build script (GNUtoo) Signed-off-by: Joonas Kylmälä --- CHANGELOG.mkdn | 10 ++ config/common.mk | 2 +- sign-build | 2 +- 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.mkdn b/CHANGELOG.mkdn

Re: [Replicant] Replicant 6.0 0004 RC1

2020-01-14 Thread Joonas Kylmälä
Hi, modem is not supported for the i9305 so no phone calls, sms or data. Josh Branning: > On 12/01/20 05:11, Kurtis Hanna wrote: >> Heyo, >> >> Here's the link to the Replicant 6.0 0004 rc1 images: >> https://ftp.osuosl.org/pub/replicant/images/replicant-6.0/replicant-6.0-0004-rc1/images/i9305/ >

Re: [Replicant] Replicant 6.0 0004 RC1 - LineageOS 16 or LineageOS 17 ?

2020-01-14 Thread Joonas Kylmälä
Hi, Jozef Macko: > just quick question which version of LineageOS 16 or LineageOS 17 are used > for Replicant 6.0 0004 RC1? Neither, 6.0 is based on LineageOS/CyanogenMod 13. > One day 10.10.2019 i received answer from Joonas Kylmälä that you are > working on that, LineageOS 16 bas

Re: [Replicant] [PATCH] ipc-test: improve error reporting

2020-01-17 Thread Joonas Kylmälä
Acked-by: Joonas Kylmälä Denis 'GNUtoo' Carikli: > Signed-off-by: Denis 'GNUtoo' Carikli > --- > tools/ipc-test.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/tools/ipc-test.c b/tools/ipc-test.c > index

Re: [Replicant] Replicant 6.0 0004 RC1 on espressowifi

2020-02-13 Thread Joonas Kylmälä
Hi, yeah, the images for RC1 has been signed with GNUtoo's key and for the 0003 release with Wolfgang's key, so since there is signature checking using rc1 zip on 0003 recovery won't work and vice versa. Graham Cobb: > On 13/02/2020 10:11, Graham Cobb wrote: >> Do I need to reload the original re

Re: [Replicant] [device_samsung_espresso3g][PATCH] device.mk: fix "libaudio-ril-intierface" typo

2020-02-14 Thread Joonas Kylmälä
Acked-by: Joonas Kylmälä Denis 'GNUtoo' Carikli: > This was introduced by the following commit: > affda81 Add scripts to disable the modem > > Reported-by: Joonas Kylmälä > Signed-off-by: Denis 'GNUtoo' Carikli > --- > device.mk | 2 +- >

Re: [Replicant] Device donation: Nexus 5X

2020-02-19 Thread Joonas Kylmälä
Hi, the Nexus 5X seems to not be a good target for Replicant because of its Qualcomm MSM SoC with integrated modem (https://redmine.replicant.us/projects/replicant/wiki/TargetsEvaluation#Known-to-be-bad-targets). So probably no Replicant developer is interested in that particular device. Sascha B

Re: [Replicant] is replicant 6 insecure? does google update android 6?

2020-03-09 Thread Joonas Kylmälä
Hi, there are no security updates / bug fixes for AOSP 6, meaning also no updates for Replicant 6. I think I have seen occasional security fix backported by LineageOS devs for CM13 but that probably doesn't help much. ___ Replicant mailing list Replicant

Re: [Replicant] [manifest][PATCH] Move libsamsung-ril and libsamsung-ipc in vendor/replicant

2020-04-04 Thread Joonas Kylmälä
Hi, Just FYI: I will be pushing similar patch for replicant-9 manifest. Denis 'GNUtoo' Carikli: > This unify the naming of libsamsung-ril which is sometimes > called samsung-ril and sometimes libsamsung-ril. > > Using the samsung-ril naming is confusing because it would > imply that it's not a l

Re: [Replicant] Introducing ccache to Replicant 6

2020-04-15 Thread Joonas Kylmälä
Hi, Denis 'GNUtoo' Carikli: > Is there an advantage in building ccache when most GNU/Linux > distributions already have it? > > Is it for making the build more reproducible? > Is it to make it more easy and have less dependencies? In my opinion we should just use the distro ccache and that is

Re: [Replicant] Replicant Digest, Vol 351, Issue 1

2020-04-20 Thread Joonas Kylmälä
Hi, I still don't see a reason to include it in the Replicant build process. Why newer version is better? Without any good reason to fork the upstream code we should not do this because it leaves us to maintain it. Although almost nobody is probably working anymore on the replicant 6 upstream sour

Re: [Replicant] apAndroid basic apps still are google?

2020-05-14 Thread Joonas Kylmälä
Hey, yes, but there are commits to remove the telemetrics, this is at least what we did recently with the Dialer App since there was one thing we had missed (https://redmine.replicant.us/issues/1827). I have not been developing replicant 6 in its early days so I'm not exactly sure how rigourous me

Re: [Replicant] libsamsung-ipc: Switch to Linux code style (/!\ Huge patch set)

2020-06-25 Thread Joonas Kylmälä
Hi GNUtoo, you can add my Reviewed-by to the the patches 1-7 of the patch set: Reviewed-by: Joonas Kylmälä The remaining patches I will hopefully review soon also. I just thought to write this email so other people won't be doing duplicated work by reviewing these first 7 patches. J

Re: [Replicant] libsamsung-ipc: Switch to Linux code style (/!\ Huge patch set)

2020-06-27 Thread Joonas Kylmälä
Hi, the patches 8-53 are now reviewed also: Reviewed-by: Joonas Kylmälä Joonas Joonas Kylmälä: > Hi GNUtoo, > > you can add my Reviewed-by to the the patches 1-7 of the patch set: > > Reviewed-by: Joonas Kylmälä > > The remaining patches I will hopefully review soon

Re: [Replicant] [libsamsung-ril] Fix compilation failure due to libsamsung-ipc typo fixes

2020-07-06 Thread Joonas Kylmälä
Hi, I checked quickly through all the patches (1-5) and they look sensible: Acked-by: Joonas Kylmälä Denis 'GNUtoo' Carikli: > > Hi, > > As there were some typo fixes in libsamsung-ipc, we need to adjust > libsamsung-ril as well. This should make libsamsung-ril com

Re: [Replicant] [libsamsung-ipc][PATCH] autogen.sh: don't run ./configure

2020-07-07 Thread Joonas Kylmälä
Acked-by: Joonas Kylmälä Denis 'GNUtoo' Carikli: > In project using autotools, autogen.sh scrips are common and > are typically used to generate the ./configure script. > > While running ./configure in that script might speed up the > setup for compiling libsamsung-ipc

Re: [Replicant] [libsamsung-ipc] [PATCH 1/4] Android.mk: remove deprecated LOCAL_COPY_HEADERS

2020-07-16 Thread Joonas Kylmälä
Hi, Acked-by: Joonas Kylmälä ___ Replicant mailing list Replicant@osuosl.org https://lists.osuosl.org/mailman/listinfo/replicant

Re: [Replicant] [libsamsung-ipc] [PATCH] tools: reorder includes

2020-07-17 Thread Joonas Kylmälä
Hi, Reviewed-by: Joonas Kylmälä ___ Replicant mailing list Replicant@osuosl.org https://lists.osuosl.org/mailman/listinfo/replicant

Re: [Replicant] [libsamsung-ril] [PATCH] Android.mk: remove hardcoded reference to external/libsamsung-ipc

2020-07-17 Thread Joonas Kylmälä
\ > - external/libsamsung-ipc/include \ > hardware/libhardware_legacy/include \ > system/core/include If I remember correctly there is some way to include the other modules headers too in non-hardcoded way, by referencing the module name. Anyway this patch

Re: [Replicant] [libsamsung-ril] [PATCH 1/8] ss: remove unused state variable

2020-08-21 Thread Joonas Kylmälä
Hi, Denis 'GNUtoo' Carikli: > Signed-off-by: Denis 'GNUtoo' Carikli > --- > ss.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/ss.c b/ss.c > index 49f3152..59e134f 100644 > --- a/ss.c > +++ b/ss.c > @@ -214,7 +214,9 @@ complete: > return rc; > } > > -int

Re: [Replicant] [libsamsung-ril] [PATCH 5/8] data: remove unused setup_data_call_response variable

2020-08-21 Thread Joonas Kylmälä
Reviewed-by: Joonas Kylmälä Denis 'GNUtoo' Carikli: > Signed-off-by: Denis 'GNUtoo' Carikli > --- > data.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/data.c b/data.c > index 5335a97..11d0b47 100644 > --- a/data.c > +++ b/data.c

Re: [Replicant] [vendor_replicant] [PATCH v3 2/4] Set Replicant version to replicant-6.0-dev

2020-10-02 Thread Joonas Kylmälä
Hi, Denis 'GNUtoo' Carikli: > This change is based on work by Joonas Kylmälä. hmm, I don't remember on working on anything like this, and seems very trivial change. Why is this patch needed by the way (the commit message doesn&#

Re: [Replicant] [libsamsung-ipc] [PATCH 1/3] tools: nv_data-imei: fix unused-label

2020-11-29 Thread Joonas Kylmälä
Reviewed-by: Joonas Kylmälä Denis 'GNUtoo' Carikli: > Without that fix, when building libsamsung-ipc under GNU/Linux > with the "-Werror -W -Wall -Wunused -Wunused-function" CFLAGS, > GCC and the autotools build system, we have: > nv_data-imei.c: In

Re: [Replicant] [libsamsung-ipc] [PATCH 2/3] rfs: fix sign comparison

2020-11-29 Thread Joonas Kylmälä
Any idea why are we not just checking st.st_size == MD5_DIGEST_LENGTH ? If we don't check that the data that exists on the file is not the same length then we end up just comparing the first MD5_DIGEST_LENGTH / 16 bytes. Joonas Denis 'GNUtoo' Carikli: > Without that fix, when building libsamsung-

Re: [Replicant] [libsamsung-ipc] [PATCH 3/3] Add guix.scm

2020-11-29 Thread Joonas Kylmälä
I have one concern: if we introduce these packaging files and then the distro wants to modify them because we did it suboptimally now they first have to maintain a patch to remove our packaging and then introduce their packaging meaning extra work for the distro maintainer. This might also interfer

Re: [Replicant] [libsamsung-ipc] Add various build tests

2020-11-29 Thread Joonas Kylmälä
It would be good to bring back the nightly builds we had for the 6.0 0004 rc releases but now also the same system for replicant 4.2 and replicant-11-dev. This would solve the issue you are having but we just need a sysadmin and a server for that. Joonas Denis 'GNUtoo' Carikli: > Hi, > > I need

[Replicant] Call for a community manager

2020-12-01 Thread Joonas Kylmälä
The Replicant project is looking for a community manager. The role of the community manager is to fill the gap between Replicant developers and users, making sure that users' concerns are properly addressed while at the same time freeing the developers from the burden of running the community. The

Re: [Replicant] [libsamsung-ipc] Add various build tests

2020-12-01 Thread Joonas Kylmälä
Denis 'GNUtoo' Carikli: > On Sun, 29 Nov 2020 15:27:12 +0200 > Joonas Kylmälä wrote: > >> It would be good to bring back the nightly builds we had for the 6.0 >> 0004 rc releases but now also the same system for replicant 4.2 and >> replicant-11-dev. This wou

Re: [Replicant] [libsamsung-ipc] [PATCH 3/3] Add guix.scm

2020-12-01 Thread Joonas Kylmälä
Hi, Denis 'GNUtoo' Carikli: > On Sun, 29 Nov 2020 15:12:55 +0200 > Joonas Kylmälä wrote: > >> I have one concern: if we introduce these packaging files and then the >> distro wants to modify them because we did it suboptimally [...] > While technically this

Re: [Replicant] [libsamsung-ipc] [PATCH 3/3] Add guix.scm

2020-12-01 Thread Joonas Kylmälä
Hi, Denis 'GNUtoo' Carikli: > --- /dev/null > +++ b/guix.scm > @@ -0,0 +1,194 @@ > +;;; Copyright © 2020 Denis Carikli > +;;; > +;;; This file is not part of GNU Guix (yet). > +;;; > +;;; Part of this file might be moved to Guix when a new release of > +;;; libsamsung-ipc is made. This will proba

Re: [Replicant] [libsamsung-ipc] [PATCH 2/3] rfs: fix sign comparison

2020-12-01 Thread Joonas Kylmälä
. Joonas Denis 'GNUtoo' Carikli: > On Sun, 29 Nov 2020 15:00:38 +0200 > Joonas Kylmälä wrote: > >> Any idea why are we not just checking st.st_size == MD5_DIGEST_LENGTH >> ? If we don't check that the data that exists on the file is not the >> same leng

[Replicant] [PATCH] samsung-ipc: rfs: fix incorrect sign comparison for md5 file length

2020-12-01 Thread Joonas Kylmälä
] if (st.st_size < 2 * sizeof(char) * MD5_DIGEST_LENGTH) { ^ This simplifies the comparison by making sure we have exactly 32 bytes (2*MD5_DIGEST_LENGTH, i.e. md5 digest in ascii) in the file we read the MD5 digest from. Signed-off-by: Joonas Kylmälä --- samsung-ipc/rfs.c

Re: [Replicant] [PATCH] samsung-ipc: rfs: fix incorrect sign comparison for md5 file length

2020-12-01 Thread Joonas Kylmälä
Hi, I couldn't do any real device testing because I don't have any storage space to build replicant 6 and would have had to delete replicant 11 work to do this so if this patch looks good to you it would be awesome if you could give it a spin on a real device. Joonas Joonas Kylmä

[Replicant] [PATCH v2] samsung-ipc: rfs: fix incorrect sign comparison for md5 file length

2020-12-02 Thread Joonas Kylmälä
(st.st_size < 2 * sizeof(char) * MD5_DIGEST_LENGTH) { ^ This simplifies the comparison by making sure we have exactly 32 bytes (2*MD5_DIGEST_LENGTH, i.e. md5 digest in ascii) in the file we read the MD5 digest from. Signed-off-by: Joonas Kylmälä --- samsung-ipc/rfs.c

Re: [Replicant] [PATCH] samsung-ipc: rfs: fix incorrect sign comparison for md5 file length

2020-12-02 Thread Joonas Kylmälä
Denis 'GNUtoo' Carikli: > Besides the very long line in the commit ("rfs.c:115:17: error: > comparison of integer expressions of different signedness: ‘__off_t’ > {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare]") that > needs to be spitted, everything looks good. Ok, I just send v2

Re: [Replicant] (no subject)

2020-12-11 Thread Joonas Kylmälä
Hi, thanks for the interest. What sort of relevant experience do you have? Have you for example written any blog posts before, used Git version control system (other projects besides us use it, e.g. postmarketos, and it will be useful if the community manager is able to check the things others are

[Replicant] Update on the community manager position

2020-12-17 Thread Joonas Kylmälä
Hi, as a Replicant Steering Committee member, I just wanted to give you all a quick update on the status of community manager position. The deadline for applications has now ended and we don't consider any new applications. We have started the evaluation of the applications received, but have not

Re: [Replicant] [www.replicant.us] [PATCH] Remove broken git RSS panel

2020-12-18 Thread Joonas Kylmälä
Hi, maur...@prtrc.net: > I can't remember the content of the GitLab RSS Panel, but cgit does > provide Atom commit feeds, i.e. > https://git.replicant.us/contrib/GNUtoo/www.replicant.us/atom/?h=master > > These doesn"t work with the WP Panel or doesn"t contain the desired > content? I somehow re

[Replicant] Update on community manager applications

2021-01-10 Thread Joonas Kylmälä
Hi, the steering committee has now gone through all the community manager applications. I have listed below all the applications we received on the mailing list (before the deadline). The applicants with "(second round)" after their name will proceed to next round of the selection process. We will

Re: [Replicant] [vendor_replicant-scripts] [PATCH 1/6] replicant_prepare_patch.py: fix interpreter path

2023-08-02 Thread Joonas Kylmälä via Replicant
Reviewed-by: Joonas Kylmälä Denis 'GNUtoo' Carikli via Replicant: Some distributions like Trisquel 10 don't necessarily have an interpreter at /usr/bin/python. In addition it makes sure that the right interpreter is used, as packages like python-is-python2 can ship /usr/

Re: [Replicant] [vendor_replicant-scripts] [PATCH 2/6] replicant_prepare_patch.py: Makefile: create DESTDIR

2023-08-02 Thread Joonas Kylmälä via Replicant
Hi, Denis 'GNUtoo' Carikli via Replicant: .PHONY: install install: + $(INSTALL) -d $(DESTDIR) On my machine running this command seems to modify the DESTDIR permissions. To avoid changing the user's directory permissions it seems like we could do instead of the line here:

Re: [Replicant] [vendor_replicant-scripts] Build system and documentation fixes

2023-08-02 Thread Joonas Kylmälä via Replicant
Hi Denis, all the patches except the first one in this series seem to have gotten accidentally "replicant_prepare_patch.py:" prefix in the title line. Joonas Denis 'GNUtoo' Carikli via Replicant: Hi, In addition to the patches that will follow in a response to this mail, here's an URL to t

Re: [Replicant] [vendor_replicant-scripts] [PATCH 6/6] replicant_prepare_patch.py: Makefile: Ship COPYING, README, config file

2023-08-02 Thread Joonas Kylmälä via Replicant
Hi, Denis 'GNUtoo' Carikli via Replicant: Signed-off-by: Denis 'GNUtoo' Carikli --- patches/Makefile | 8 1 file changed, 8 insertions(+) diff --git a/patches/Makefile b/patches/Makefile index d45bc63..f3b32f9 100644 --- a/patches/Makefile +++ b/patches/Makefile @@ -5,3 +5,11 @@ IN

Re: [Replicant] [vendor_replicant-scripts] replicant_prepare_patch.py: V2 for "Build system and documentation fixes"

2023-08-07 Thread Joonas Kylmälä via Replicant
Hi Denis, seems like somehow the prefix "replicant_prepare_patch.py:" is still in the v2 patches (though, in the first one it should be). I wonder how it gets added, does git send-email or similar command do it somehow? Joonas Denis 'GNUtoo' Carikli: Hi, As promised here's the v2 of this

Re: [Replicant] [vendor_replicant-scripts] [PATCH v2 2/6] replicant_prepare_patch.py: Makefile: create DESTDIR

2023-08-07 Thread Joonas Kylmälä via Replicant
Hi, Denis 'GNUtoo' Carikli: Some distributions like Guix work best when DESTDIR is created by the software build system (here the Makefile). [Joonas Kylmälä]: Fixed bug that didn't preserve DESTDIR permissions. Signed-off-by: Denis 'GNUtoo' Carikli --- patche

Re: [Replicant] [vendor_replicant-scripts] replicant_prepare_patch.py: V2 for "Build system and documentation fixes"

2023-08-09 Thread Joonas Kylmälä via Replicant
Hi, Denis 'GNUtoo' Carikli: seems like somehow the prefix "replicant_prepare_patch.py:" is still in the v2 patches (though, in the first one it should be). I wonder how it gets added, does git send-email or similar command do it somehow? I added it manually. Basically vendor_replicant-scripts h

Re: [Replicant] [vendor_replicant-scripts] [PATCH v2 4/6] replicant_prepare_patch.py: README: fix example repository URL

2023-08-09 Thread Joonas Kylmälä via Replicant
Reviewed-by: Joonas Kylmälä Denis 'GNUtoo' Carikli: The user repositories were moved to contrib long time ago. Signed-off-by: Denis 'GNUtoo' Carikli --- patches/README | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/patches/README b/patches/

<    1   2