Re: Post-review version 0.8: The patch to ... didn't apply cleanly

2008-12-19 Thread Muhammad Haggag
When that happened to me, I went to the temp directory and examined the files myself. In my case, it turned out that my source control system mishandled files that didn't have trailing newlines incorrectly, and produced diffs that gnu patch didn't understand. Using gnu diff solved my problem (It

Submitted status is not intuitive

2008-12-19 Thread morisgi
First I would like to congratulate the authors of ReviewBoard: this is already a very good tool and there is even more to come. However, in my discovery of the tool, I was wondering what Submitted stands for. Correct me if I am wrong, you press the Set Submitted button to finish a review with an

Re: Submitted status is not intuitive

2008-12-19 Thread morisgi
On Dec 19, 3:56 pm, Russell Bryant russell.bry...@gmail.com wrote: I believe that most people use the review with a tag of Ship it as the approval.  The set submitted functionality is intended to be used by the committer of the change after it has been approved and committed, to mark the

Off-line Usage.

2008-12-19 Thread Blake Winton
Hi, I think I'm probably going to start using Review Board in the coming months, and I've got a question. One of my developers isn't able to connect to the Internet full time. (She's on the wrong side of a PPP link.) Is there any sort of offline/batch tool she could use to interact with

Issue 779 in reviewboard: When site_root is not /, deleting an issue will result in wrong start page

2008-12-19 Thread codesite-noreply
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 779 by tmetsch: When site_root is not /, deleting an issue will result in wrong start page http://code.google.com/p/reviewboard/issues/detail?id=779 *NOTE: Do not post confidential information in this bug report.* What's

Issue 285 in reviewboard: Usernames with period don't work in

2008-12-19 Thread codesite-noreply
Comment #2 on issue 285 by murk...@telecolumbus.net: Usernames with period don't work in http://code.google.com/p/reviewboard/issues/detail?id=285 As Administrator you can't edit preferences for a user with dot in name. There's a validation on user-name-field that said only letters, numbers