Re: ReviewBoard + GIT Integration

2009-09-15 Thread Matthew Woehlke
On 2009-09-15 18:07, Kunjal wrote: > We already have RB integrated with Perforce and it is working cool. > Now, we have some developers working in GIT and we want to review that > code as well. > What are the steps developer should perform to get the diff and post > the review? Save yourself a wh

ReviewBoard + GIT Integration

2009-09-15 Thread Kunjal
Hello, We already have RB integrated with Perforce and it is working cool. Now, we have some developers working in GIT and we want to review that code as well. Where should I start? What are the steps developer should perform to get the diff and post the review? Any info. in this regard will be h

Re: post-review and git: create reviews for already committed code

2009-09-15 Thread Flavio Castelli
On Tuesday 15 September 2009 12:44:26 Christian Hammond wrote: > You'll need the nightly of RBTools (instructions below), or generate a diff > manually with `git diff --full-index`. Done, thanks a lot! http://reviews.review-board.org/r/1049/ Cheers Flavio --~--~-~--~~~--

Re: post-review and git: create reviews for already committed code

2009-09-15 Thread Christian Hammond
You'll need the nightly of RBTools (instructions below), or generate a diff manually with `git diff --full-index`. To get the nightly: easy_install -f http://downloads.review-board.org/nightlies -U RBTools Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-bo

Re: post-review and git: create reviews for already committed code

2009-09-15 Thread Flavio Castelli
On Tuesday 15 September 2009 12:11:00 Christian Hammond wrote: > Please submit code changes up on http://reviews.review-board.org/. I have selected RBTools as repository but I get this error message when I try to upload the diff: The file 'rbtools/postreview.py' (r2e2518f) could not be found in

Re: post-review and git: create reviews for already committed code

2009-09-15 Thread Christian Hammond
Please submit code changes up on http://reviews.review-board.org/. Thanks, Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, Sep 15, 2009 at 3:05 AM, Flavio Castelli wrote: > > On Wednesday 09 Septembe

Re: post-review and git: create reviews for already committed code

2009-09-15 Thread Flavio Castelli
On Wednesday 09 September 2009 20:25:45 Dan Savilonis wrote: > The currently released version of post-review is limited to very basic > git functionality. You can't specify an arbitrary revision range. You > can try my updated version here and see how it works: > > http://github.com/djs/rbtools/tr

Re: non-ASCII in comments

2009-09-15 Thread Dmitry Konyshev
Hi, David and Christian, Thank you for the prompt responses and the tip! I'm running MySQL 5.0.84. This command did the trick: ALTER TABLE reviews_comment MODIFY text longtext CHARACTER SET utf8; I guess, now I need to find other longtext columns in the database and convert they too? I reall

Re: non-ASCII in comments

2009-09-15 Thread Christian Hammond
Hi Dmitry, Review Board is designed to work entirely with UTF-8, but it's up to the database to use the correct encoding. It's possible that yours isn't set for UTF-8. When did you create your database, and what version of MySQL are you using? You should be able to see the character set of the c

Re: non-ASCII in comments

2009-09-15 Thread David Trowbridge
It sounds like maybe the tables aren't UTF-8. I don't recall off the top of my head how to change the charset of your tables, but I recall the mysql documentation on the topic being relatively helpful. -David On Mon, Sep 14, 2009 at 11:58 PM, Dmitry Konyshev wrote: > > Hi guys, > > First of a

non-ASCII in comments

2009-09-15 Thread Dmitry Konyshev
Hi guys, First of all, many thanks to the developers of this wonderful piece of software! Please help me with the following issue: When I use non-ASCII characters in comments (specifically, cyrillic characters), they are turned into question marks once comments are published. I looked at the my