Download diff

2009-11-04 Thread H M
Is there a way to download a diff through the formal JSON api? I realize the diff could be downloaded through a GET call to http://reviewboard/r/id/diff/raw But given that all of the REST API URLs begin with /api/json/, I'm wondering if there is something I'm missing. H.M.

Comment type/severity

2009-10-16 Thread H M
Hi All, I would like to urge you to view this enhancement suggestion and participate in the discussion. http://code.google.com/p/reviewboard/issues/detail?id=1277 I feel having a comment type/severity would greatly enhance the usability of RB at mature software development copmanies while it

Re: Using Review Board

2009-05-11 Thread H M
Chris wrote: Also unless code has been given the OK i dont want it to get into trunk, is this possible? i.e. can we stop people committing to trunk, or is that more something we need to deal with at a people level not an automation level I don't think this is done out of the box. At least not

Re: Review Metrics

2008-12-12 Thread H M
I began thinking more about this and would like to return to the topic. I think that a tool should help MOST people do their work right while being flexible at the same time. I think the ideas below are flexible enough that they don't stop others from using reviewboard as they were already,

Huge patch files

2008-10-29 Thread H M
We have a review request that was recently submitted that touches around 200 source files (2-3 lines per file). Just a change in the copyright notice. Reviewboard's View Diff page hangs. I'm assuming that it is having a problem opening up 200 files to generate the HTML for the diff viewer. I

Re: Review Metrics

2008-10-24 Thread H M
, Inc. On Wed, Oct 22, 2008 at 3:53 PM, H M [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote: Sure, I think keeping track of time like you described won't be enough. At least in our case, our review policy requires the reviewer to actually download the code and see

Review Metrics

2008-10-22 Thread H M
We would like to see if we can gather some metrics from Reviewboard, including: * *Inspection Rate:* The number of KLOC inspected per hour. * *Defect Identification Rate:* The number of defects found in one hour of inspection time. * *Defect Density:* The amount of defects

Re: Marking review as Submitted using API

2008-10-22 Thread H M
Attached is a snippet of Perl I came up with to set the ReviewRequest as Submitted using SQL. I know this is probably not a desired way to do it, but it worked for us. If there is any use for this, I can tidy it up a bit and submit it to the project. Hovanes Augie Fackler wrote: On Oct 20,

Re: Review Metrics

2008-10-22 Thread H M
Sure, I think keeping track of time like you described won't be enough. At least in our case, our review policy requires the reviewer to actually download the code and see if there are any warnings, does it run as expected, etc... All this will be outside of ReviewBoard. Perhaps another

Re: Marking review as Submitted using API

2008-10-22 Thread H M
Great! Thanks. Christian Hammond wrote: There's an API command up for review that will be in today which allows you to easily mark a review request as submitted. See http://reviews.review-board.org/r/604/ Christian -- Christian Hammond - [EMAIL PROTECTED] mailto:[EMAIL PROTECTED]