Christian,
Where should I look into for this? is it postreview.py?
thanks,
Deniz
On Sep 25, 3:17 pm, Christian Hammond chip...@chipx86.com wrote:
You being Deniz, not Chris, unless Chris wants to take this on too. :)
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board
Yep. You'll want to look at the CVSClient class, specifically the diff code.
It's not too big and is hopefully mostly obvious (in terms of how the
commands are constructed and all).
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. -
Is there any way to create review request for code files that are not
added into CVS repository yet?
I would like to be able to send review requests for classes that I am
writing first time and not yet added into CVS.
thanks,
Deniz
--~--~-~--~~~---~--~~
You
You just need to cvs add these files and then generate a diff. This model
(pre-commit reviews) are actually the model we had in mind when writing
Review Board.
We highly recommend using post-review for diff generation and uploading. It
will make life much easier. You can get this by:
Thank you, Christian.
I tried cvs add but then I got the following result:
cvs diff: file_name is a new entry, no comparison available
I am trying review board for facilitating our code review practice. We
have a primitive mechanism around cvs and bugzilla for post-commit
reviews but we do not
Yeah, sounds like a bug in the CVS support. If you can figure out what's
causing it and contribute a fix, that would help. I won't be able to look at
it for a little while.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. -
You being Deniz, not Chris, unless Chris wants to take this on too. :)
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com
On Fri, Sep 25, 2009 at 3:17 PM, Christian Hammond chip...@chipx86.comwrote:
Yeah,
