Re: Review Board 1.0 RC3 released
On Sun, Jun 14, 2009 at 03:43, Christian Hammondchip...@chipx86.com wrote: I've just put out a release of 1.0 RC3, which should actually be the final RC as long as nothing else blows up. I plan to release 1.0 next weekend. Upgrade (rc1-rc3) works fine. If people would test this release this week and make sure nothing is newly broken in your installs, it would REALLY help us out! After 2 days, no problem here. Details on the release can be found at http://www.review-board.org/news/2009/06/13/review-board-10-rc3-released/ I see: Added support for parent diffs for Mercurial. Patch by Colin Caughie. Why haven't you change initial screen (create a Hg review request)? It's not possible to create a review request with parent path. -- Sebastien Douche sdou...@gmail.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Create new review remote API
On Fri, Jun 12, 2009 at 19:11, Christophernadiasver...@gmail.com wrote:
I am doing a check of reviewboard, and so far it is really nice.
I was wondering if there is a SOAP or AJAX or REST API for creating
new review requests.
Here the function we use :
def new_request(self, repo_path, changenum=None, submit_as=None):
Creates a review request on a Review Board server, updating an
existing one if the changeset number already exists.
try:
debug(Attempting to create review request for %s % repo_path)
data = { 'repository_path': repo_path }
if changenum:
data['changenum'] = changenum
if submit_as:
debug(Submitting the review request as %s % submit_as)
data['submit_as'] = submit_as
rsp = self.api_post('api/json/reviewrequests/new/', data)
except APIError, e:
rsp, = e.args
If someone had guidance on how to do the reviewboard side of this, I
would appreciate it.
We develop an CLI app with Hg and Reviewboard. Alpha stage but useful
to understand interaction with RB.
--
Sebastien Douche sdou...@gmail.com
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: Review Board 1.0 RC3 released
On Mon, Jun 15, 2009 at 8:07 AM, Sebastien Douche sdou...@gmail.com wrote: On Sun, Jun 14, 2009 at 03:43, Christian Hammondchip...@chipx86.com wrote: I've just put out a release of 1.0 RC3, which should actually be the final RC as long as nothing else blows up. I plan to release 1.0 next weekend. Upgrade (rc1-rc3) works fine. If people would test this release this week and make sure nothing is newly broken in your installs, it would REALLY help us out! After 2 days, no problem here. Good to hear! Details on the release can be found at http://www.review-board.org/news/2009/06/13/review-board-10-rc3-released/ I see: Added support for parent diffs for Mercurial. Patch by Colin Caughie. Why haven't you change initial screen (create a Hg review request)? It's not possible to create a review request with parent path. Pretty much because it wasn't in the patch that added this support. If you want to whip up a patch to do this (modify get_fields in scmtools/hg.py) then I'll get it in for 1.0. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Best way to tie revisions to a review / Subversion
Hi Eric, post-review can actually post committed changes up for review (see http://www.review-board.org/docs/manual/dev/users/tools/post-review/#posting-committed-code). You can run this per revision. You'll end up with a different review request for each one, though, since it wouldn't make sense ot have one review that touches the same file multiple times. If you only wanted the latest revision on a ticket, you could of course do that too by just specifying the most recent revision. Or you could specify a range of revisions. Whichever you need for the situation. Review Board is largely designed for a pre-commit model, but companies do use it with a post-commit. Hopefully some other people will share their strategies here. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Mon, Jun 15, 2009 at 8:58 AM, Eric P eric.maill...@gmail.com wrote: Hi, We're looking at a few code review tools for work, and I'm excited by what I see in Review Board. I'm trying to wrap my head around the best way to associate a review with the correct file changes. We use Subversion and we usually do regular commits while working on a ticket (we use Trac) in order to not lose any local changes (e.g., drive failure, etc.). So I think (?) that rules us out of using the post-review model which relies on creating the review from all the uncommitted local changes for a ticket. The pre-review model (i.e., posting a diff of all the relevant code changes) seems like it might work, but the process of gathering up all the revisions for a ticket seems error prone. A ticket could have anywhere from 1 to 50 (or more) commits for it. Although each commit in our system is loosely tied to a ticket via the inclusion of a ticket number in the revision comment, how could we systematically pull in all of these revisions into one nice diff? I'm very curious to hear how other users have successfully integrated their code development/review with Review Board. I'm sure I'm missing the boat on some of this here. Thanks for reading, Eric P. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
posting paths with post-review
I'm trying to post a path (opposed to a changelist) as laid out in the docs: http://www.review-board.org/docs/manual/dev/users/tools/post-review/#posting-paths If I run the following command: post-review //path/to/dir/... I get the following error message: You must enter a valid change number. It may just be a case where I'm misunderstanding the docs. Should this be possible? Kind regards, Scott --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Syntax highlighting
Hi -- I apologize if this has been answered elsewhere. I see strange artifacts when displaying diffs of PHP code. Essentially all my $ @ ! and ' get a red box around them. I use .inc extensions on my files. Is there a setting (more specific than on/off on the admin page) where I could indicate what extension uses what language? (I am pretty sure that ReviewBoard treats my files as something else, maybe Pascal?). Thanks! --Marcin --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Syntax highlighting
Hi Marcin, There's no setting for this yet, but I know someone was working on one. It's too late to get it into 1.0, but it's possible we can encourage him to get it ready for 1.1 :) This is really an issue in Pygments, the third-party library we use for syntax highlighting. They hard-code the extensions for certain file types. While we can override in the future, it really would be ideal if they had a way of customizing this better. Right now it requires modifying some files in the Pygments tree directly and running a script (I don't remember the details on how that works off-hand). Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Mon, Jun 15, 2009 at 2:51 PM, MStruzak mar...@pbanker.com wrote: Hi -- I apologize if this has been answered elsewhere. I see strange artifacts when displaying diffs of PHP code. Essentially all my $ @ ! and ' get a red box around them. I use .inc extensions on my files. Is there a setting (more specific than on/off on the admin page) where I could indicate what extension uses what language? (I am pretty sure that ReviewBoard treats my files as something else, maybe Pascal?). Thanks! --Marcin --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Issue 1166 in reviewboard: view diff failed for files contain Mac newline char (i.e. CR \r) -- use SVN client
Comment #3 on issue 1166 by f...@datasynapse.com: view diff failed for files contain Mac newline char (i.e. CR \r) -- use SVN client http://code.google.com/p/reviewboard/issues/detail?id=1166 I couldn't figure out how to apply nightly ReviewBoard and RBTools plugins. Is there any FAQ? Thanks for the fix. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1165 in reviewboard: diffviewer does not show all comments (RC2)
Comment #3 on issue 1165 by ochernyavskyy: diffviewer does not show all comments (RC2) http://code.google.com/p/reviewboard/issues/detail?id=1165 (No comment was entered for this change.) Attachments: screenshot_1.jpg 368 KB screenshot_2.jpg 329 KB screenshot_3.jpg 338 KB -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1165 in reviewboard: diffviewer does not show all comments (RC2)
Comment #4 on issue 1165 by ochernyavskyy: diffviewer does not show all comments (RC2) http://code.google.com/p/reviewboard/issues/detail?id=1165 To make a repo case use the following data: repository Path: :pserver:anonym...@openmotif.cvs.sourceforge.net:/cvsroot/openmotif Username: anonymous Tool: CVS -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
