Re: Review Board 1.5 RC 2 is released
Great work getting 1.5 RC 2 out. I upgraded the FedoraHosted deployment today, but I've stumbled across three new bugs. (I strongly suspect that two of them were present in RC1 as well, but I didn't notice them then) 1829 - Viewing the server log from the admin interface fails 1828 - 500 Error trying to review an image-only review request 1827 - Sending notification emails fails Additionally, we noticed something that seems peculiar. When ReviewBoard (or maybe it's Django) makes postgresql requests, it starts a new connection for each request and terminates it at the end. I'm not certain if this is ReviewBoard or Django (or python-psycopg2) doing this, but the added overhead of those connection setups is nothing to sneeze at. On Sep 20, 2:57 am, Christian Hammond chip...@chipx86.com wrote: Hi everyone, Review Board 1.5 RC 2 is out the door. Details on the release, as well as further prodding about the release party, are up at: http://www.reviewboard.org/news/2010/09/19/review-board-15-rc-2-relea... On an unrelated note, some of you have asked how you can help with our expenses without going through PayPal. One person has suggested a service called Flattr, which specializes in micropayments. I'm looking into this as an alternative, but if you've used it, I'd love to hear from you. Thanks! Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Review Board 1.5 RC 2 is released
Hi Stephen, I suspect that 1829 is due to an installation or packaging problem with Djblets. I can't reproduce this on our install, which was installed using easy_install. The log.html template is there, and has been for a while. 1828 is a definite bug, which I'll fix for the release. 1827 again looks to be an installation/configuration problem. E-mails are working fine on our install. I don't believe it's a Django 1.1 vs 1.2 incompatibility, as our nightly test suite checks for e-mail signaling on both versions. However, I'll look into this further for the release. Do you know if it worked in RC1? I don't think anything with the signaling has changed in a long time. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Sep 24, 2010 at 8:16 AM, Stephen Gallagher karrde...@gmail.comwrote: Great work getting 1.5 RC 2 out. I upgraded the FedoraHosted deployment today, but I've stumbled across three new bugs. (I strongly suspect that two of them were present in RC1 as well, but I didn't notice them then) 1829 - Viewing the server log from the admin interface fails 1828 - 500 Error trying to review an image-only review request 1827 - Sending notification emails fails Additionally, we noticed something that seems peculiar. When ReviewBoard (or maybe it's Django) makes postgresql requests, it starts a new connection for each request and terminates it at the end. I'm not certain if this is ReviewBoard or Django (or python-psycopg2) doing this, but the added overhead of those connection setups is nothing to sneeze at. On Sep 20, 2:57 am, Christian Hammond chip...@chipx86.com wrote: Hi everyone, Review Board 1.5 RC 2 is out the door. Details on the release, as well as further prodding about the release party, are up at: http://www.reviewboard.org/news/2010/09/19/review-board-15-rc-2-relea... On an unrelated note, some of you have asked how you can help with our expenses without going through PayPal. One person has suggested a service called Flattr, which specializes in micropayments. I'm looking into this as an alternative, but if you've used it, I'd love to hear from you. Thanks! Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Issue 1828 in reviewboard: 500 Error trying to review an image-only review request
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 1828 by Karrde712: 500 Error trying to review an image-only
review request
http://code.google.com/p/reviewboard/issues/detail?id=1828
*NOTE: Do not post confidential information in this bug report.*
What version are you running?
ReviewBoard 1.5 RC2
Django 1.1.1
What's the URL of the page containing the problem?
https://fedorahosted.org/reviewboard/r/79/reviews/draft/inline-form/
What steps will reproduce the problem?
1. Create a new review request on the None repository
2. Publish the review (I did so without adding any files to review)
3. Click on Review
What is the expected output? What do you see instead?
A review text entry box should appear, along with a shipit checkbox.
Instead, A server error occurred. Show Details Dismiss is displayed.
With debugging turned on, the traceback below is provided.
What operating system are you using? What browser?
Fedora 13, Mozilla Firefox 3.6.10
Please provide any additional information below.
Environment:
Request Method: GET
Request URL:
https://fedorahosted.org/reviewboard/r/79/reviews/draft/inline-form/
Django Version: 1.1.1
Python Version: 2.4.3
Installed Applications:
['django.contrib.admin',
'django.contrib.auth',
'django.contrib.contenttypes',
'django.contrib.markup',
'django.contrib.sites',
'django.contrib.sessions',
'djblets.datagrid',
'djblets.feedview',
'djblets.siteconfig',
'djblets.util',
'djblets.webapi',
'reviewboard.accounts',
'reviewboard.admin',
'reviewboard.changedescs',
'reviewboard.diffviewer',
'reviewboard.iphone',
'reviewboard.reports',
'reviewboard.reviews',
'reviewboard.scmtools',
'reviewboard.webapi',
'fedora.django.auth',
'django_evolution']
Installed Middleware:
('django.middleware.gzip.GZipMiddleware',
'django.middleware.common.CommonMiddleware',
'django.middleware.doc.XViewMiddleware',
'django.middleware.http.ConditionalGetMiddleware',
'django.middleware.locale.LocaleMiddleware',
'django.contrib.sessions.middleware.SessionMiddleware',
'fedora.django.auth.middleware.FasMiddleware',
'django.contrib.auth.middleware.AuthenticationMiddleware',
'djblets.siteconfig.middleware.SettingsMiddleware',
'reviewboard.admin.middleware.LoadSettingsMiddleware',
'djblets.log.middleware.LoggingMiddleware',
'reviewboard.admin.middleware.CheckUpdatesRequiredMiddleware')
Traceback:
File /usr/lib/python2.4/site-packages/django/core/handlers/base.py in
get_response
92. response = callback(request, *callback_args,
**callback_kwargs)
File /usr/lib/python2.4/site-packages/djblets/auth/util.py in _checklogin
46. return view_func(request, *args, **kwargs)
File /usr/lib/python2.4/site-packages/django/views/decorators/cache.py in
_cache_controlled
30. response = viewfunc(request, *args, **kw)
File /usr/lib/python2.4/site-packages/reviewboard/reviews/views.py in
review_draft_inline_form
270. return render_to_response(template_name, RequestContext(request,
{
Exception Type: AttributeError at
/reviewboard/r/79/reviews/draft/inline-form/
Exception Value: 'NoneType' object has no attribute 'get_scmtool'
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1829 in reviewboard: Viewing the server log from the admin interface fails
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 1829 by Karrde712: Viewing the server log from the admin
interface fails
http://code.google.com/p/reviewboard/issues/detail?id=1829
*NOTE: Do not post confidential information in this bug report.*
What version are you running?
ReviewBoard 1.5 RC2
Django 1.1.1
What's the URL of the page containing the problem?
https://fedorahosted.org/reviewboard/admin/log/server/
What steps will reproduce the problem?
1. Enable logging in the admin interface
2. Click on server log in the admin dashboard
What is the expected output? What do you see instead?
I expect to see the server log. I get a 500 instead.
The traceback below is found in the log on-disk
What operating system are you using? What browser?
Red Hat Enterprise Linux 5 (server)
Fedora 13 (client)
Mozilla Firefox 3.6.10
Please provide any additional information below.
Traceback (most recent call last):
File /usr/lib/python2.4/site-packages/django/core/handlers/base.py,
line 92, in get_response
response = callback(request, *callback_args, **callback_kwargs)
File /usr/lib/python2.4/site-packages/django/contrib/admin/views/decorators.py,
line 33, in _checklogin
return view_func(request, *args, **kwargs)
File /usr/lib/python2.4/site-packages/djblets/log/views.py, line 271,
in server_log
response = render_to_response(template_name, RequestContext(request, {
File /usr/lib/python2.4/site-packages/django/shortcuts/__init__.py,
line 20, in render_to_response
return HttpResponse(loader.render_to_string(*args, **kwargs),
**httpresponse_kwargs)
File /usr/lib/python2.4/site-packages/django/template/loader.py, line
103, in render_to_string
t = get_template(template_name)
File /usr/lib/python2.4/site-packages/django/template/loader.py, line
81, in get_template
source, origin = find_template_source(template_name)
File /usr/lib/python2.4/site-packages/django/template/loader.py, line
74, in find_template_source
raise TemplateDoesNotExist, name
TemplateDoesNotExist: log/log.html
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1202 in reviewboard: Post-review socket.gaierror: (-2, 'Name or service not known')
Comment #3 on issue 1202 by dhumeniuk: Post-review socket.gaierror: (-2, 'Name or service not known') http://code.google.com/p/reviewboard/issues/detail?id=1202 If you add whatever socket.gethostname() returns to /etc/hosts that should fix/work around the issue. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request
Comment #18 on issue 831 by sameeralam69: Can't leave comments before you publish your own newly created review request http://code.google.com/p/reviewboard/issues/detail?id=831 it is good effort to demonstrate the way that help to understand -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
