Getting 404 (NOT FOUND) while saving review comment

2013-03-21 Thread kvr 
Hi,

We are using Review Board 1.7.1 

I am getting "404 not found" error while giving the diff comment and before 
publishing it.But the comment is getting saved.

Below is the API call it is making.

http://127.0.0.1:8000/api/review-requests/13/reviews/draft/?api_format=json

I guessed this is not the valid API URL,so tried below URL but it throws 
Page not found.

http://127.0.0.1:8000/api/review-requests/13/reviews/41/draft/


Any clues to resolve this?

Regards,
kvr

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Use new python API to get latest changes

2013-03-21 Thread A.M. 
On Thu, 21 Mar 2013 00:12:30 +, "A.M." 
wrote:
> Hello,
> 
> Is it possible to use the rb API in 1.7.5 to get the changes to
reviewboard
> in the past X minutes (any review request changes)? I am creating a
review
> board poller which will then update a ticket system with links to
> reviewboard. 
> 
> I had previously made a reviewboard plugin for this task, but our ticket
> system is sluggish at times, so users are annoyed that the "Publish" step
> is blocking/slow. To address this, I would like to poll and update the
> ticket out-of-band.

I figured this out myself.

rbclient.get_root().get_review_requests(last_updated_from=X)

Cheers,
M

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Use new python API to get latest changes

2013-03-21 Thread Matthew Woehlke 

On 2013-03-20 20:12, A.M. wrote:

Is it possible to use the rb API in 1.7.5 to get the changes to reviewboard
in the past X minutes (any review request changes)? I am creating a review
board poller which will then update a ticket system with links to
reviewboard.

I had previously made a reviewboard plugin for this task, but our ticket
system is sluggish at times, so users are annoyed that the "Publish" step
is blocking/slow. To address this, I would like to poll and update the
ticket out-of-band.


Have you considered moving your ticket updates to a separate thread?

So, I see you already found a solution, but because it is a good use 
case, I'll mention it anyway...


I have a feature request to add an asynchronous event monitoring system 
a la gerrit. The idea is you have a plugin that takes internal 
(synchronous) RB events and publishes them over some asynchronous 
channel (I used dbus since it is generally available on modern Linux 
systems, but you could use something else). You can then log into the 
system and run a listener program that will dump events to stdout (for 
dbus, a small Python script can do the job). If you run this in a 
separate process and connect a pipe to its output, buffering should take 
care of whatever lag your own process introduces, providing that the 
event queue doesn't fill the buffer. (You could trivially filter by 
relevant events to make that less likely.)


The advantage of this versus polling is (potentially) less latency, and 
less load on the server and network because it is event driven (the 
server and network only need to do work when an event actually happens; 
you aren't making them work every poll-interval just to tell you that 
nothing has changed).


--
Matthew

--
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups "reviewboard" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Integration of Review Board with Perforce

2013-03-21 Thread SHWETA AHER 
Hello everyone,

 In my project am trying to submit review request directly from 
Perforce(version control system) to Review Board. So please can someone 
suggest how to extract the fields from Perforce to Review Board. 

Thanks
Shweta. 

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Integration of Review Board with Perforce

2013-03-21 Thread David Trowbridge 
I'm not entirely sure what you're asking. What do you mean by "extract the
fields from Perforce to Review Board"?


-David


On Thu, Mar 21, 2013 at 10:38 AM, SHWETA AHER wrote:

> Hello everyone,
>
>  In my project am trying to submit review request directly from
> Perforce(version control system) to Review Board. So please can someone
> suggest how to extract the fields from Perforce to Review Board.
>
> Thanks
> Shweta.
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Getting 404 (NOT FOUND) while saving review comment

2013-03-21 Thread David Trowbridge 
Yes, that's currently expected. We don't intend to allow commenting on
diffs before the review request is public, but we have a long-standing bug
where it's allowed. Hopefully we'll fix that sometime soon, but for now,
you have to publish first.


-David


On Thu, Mar 21, 2013 at 6:49 AM, kvr  wrote:

> Hi,
>
> We are using Review Board 1.7.1
>
> I am getting "404 not found" error while giving the diff comment and
> before publishing it.But the comment is getting saved.
>
> Below is the API call it is making.
>
> http://127.0.0.1:8000/api/review-requests/13/reviews/draft/?api_format=json
>
> I guessed this is not the valid API URL,so tried below URL but it throws
> Page not found.
>
> http://127.0.0.1:8000/api/review-requests/13/reviews/41/draft/
>
>
> Any clues to resolve this?
>
> Regards,
> kvr
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Perforce aliases are breaking reviewboard on the server

2013-03-21 Thread Lee Laborczfalvi 
We've got a somewhat odd perforce setup that has a single server that can 
be addressed a number of ways:

server.eng.domain.net
server.domain.net
server.comany.com

I've patched the post-review tool so that it ignores the aliases, but 
anytime I post a review to the server I get a server error indicating the 
server can't be found (no repository found).

Is there anyway that the server code can also be patched to ignore aliases?

Running 1.7.6

Lee

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Perforce aliases are breaking reviewboard on the server

2013-03-21 Thread David Trowbridge 
The best way to handle this is to set REPOSITORY in the .reviewboardrc in
order to force it to always find the right one.


-David


On Thu, Mar 21, 2013 at 4:35 PM, Lee Laborczfalvi wrote:

> We've got a somewhat odd perforce setup that has a single server that can
> be addressed a number of ways:
>
> server.eng.domain.net
> server.domain.net
> server.comany.com
>
> I've patched the post-review tool so that it ignores the aliases, but
> anytime I post a review to the server I get a server error indicating the
> server can't be found (no repository found).
>
> Is there anyway that the server code can also be patched to ignore aliases?
>
> Running 1.7.6
>
> Lee
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Perforce aliases are breaking reviewboard on the server

2013-03-21 Thread Lee Laborczfalvi 
Yeah I have that - it's in my .reviewboardrc file...if I dump the server 
log it ends with this:

2013-03-21 18:14:31,878 - ERROR - Error uploading new diff: A repository 
was not found at the specified path.
Traceback (most recent call last):
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.6-py2.7.egg/reviewboard/webapi/resources.py",
 
line 2022, in create
request.FILES.get('parent_diff_path'))
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.6-py2.7.egg/reviewboard/reviews/forms.py",
 
line 305, in create
history)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.6-py2.7.egg/reviewboard/diffviewer/forms.py",
 
line 85, in create
diff_file, basedir, check_existance=(not parent_diff_file)))
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.6-py2.7.egg/reviewboard/diffviewer/forms.py",
 
line 162, in _process_files
f.moved)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.6-py2.7.egg/reviewboard/scmtools/perforce.py",
 
line 326, in parse_diff_revision
if len(self.client.get_files_at_revision(revision_str)) == 0:
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.6-py2.7.egg/reviewboard/scmtools/perforce.py",
 
line 235, in get_files_at_revision
lambda: self._get_files_at_revision(revision_str))
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.6-py2.7.egg/reviewboard/scmtools/perforce.py",
 
line 178, in _run_worker
self._convert_p4exception_to_scmexception(e)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.6-py2.7.egg/reviewboard/scmtools/perforce.py",
 
line 160, in _convert_p4exception_to_scmexception

I can happily ping the server from the same reviewboard server though or 
run p4 on the command line on the server and talk to the perforce server...

Lee

On Friday, March 22, 2013 12:40:22 AM UTC+1, David Trowbridge wrote:
>
> The best way to handle this is to set REPOSITORY in the .reviewboardrc in 
> order to force it to always find the right one.
>
>
> -David
>
>
> On Thu, Mar 21, 2013 at 4:35 PM, Lee Laborczfalvi 
> 
> > wrote:
>
>> We've got a somewhat odd perforce setup that has a single server that can 
>> be addressed a number of ways:
>>
>> server.eng.domain.net
>> server.domain.net
>> server.comany.com
>>
>> I've patched the post-review tool so that it ignores the aliases, but 
>> anytime I post a review to the server I get a server error indicating the 
>> server can't be found (no repository found).
>>
>> Is there anyway that the server code can also be patched to ignore 
>> aliases?
>>
>> Running 1.7.6
>>
>> Lee
>>
>> -- 
>> Want to help the Review Board project? Donate today at 
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~--~~~~--~~--~--~---
>> To unsubscribe from this group, send email to 
>> reviewboard...@googlegroups.com 
>> For more options, visit this group at 
>> http://groups.google.com/group/reviewboard?hl=en
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/groups/opt_out.
>>  
>>  
>>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.