anonymous users shouldn't be able to leave comments
Hi, A colleague of mine just ran into that: I had anonymous viewing of reviews and diffs enabled. If you now view a diff as anonymous, you can leave comments. Attempts to publish or edit the review will fail, because it asks you to login and will not remember your changes (obviously, since they are not in the database). Wouldn't it be better to turn off the ability to create comments when you are not logged in? My colleague spent half an hour creating comments, which he lost because he didn't realize he was not logged in. Thanks, Martin --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Review Board 1.0 alpha 1 released
Awesome, thanks for all your hard work! -- Arthur Kalmenson On Mon, Jan 19, 2009 at 5:50 AM, Christian Hammond chip...@chipx86.com wrote: Hey everyone. We've released Review Board 1.0 alpha 1 tonight. This is basically a snapshot of tonight's nightly build, which we've considered to be stable enough for an alpha release. See http://www.review-board.org/news/2009/01/19/review-board-10-alpha-1-released/. If you're using nightlies, you're going to be automatically switched over to official releases from nightlies the next time you upgrade. The Getting Started guide (http://www.review-board.org/docs/GettingStarted) has some instructions on switching back to nightlies if you prefer to use those. While we do recommend using a stable release, those of you who have been contributing in the past and feel comfortable staying on the nightlies should do so. It'll help us to stabilize for 1.0. We're going to be entering a feature freeze before too long, so if you have any feature contributions up for review that still need changes made, they probably won't make it for 1.0 unless there's an update soon. We'll get these remaining features into the release following 1.0. If it's something critical, we might take it on a case-by-case basis. And, of course, we'll definitely continue to take bug fixes. On an important note, those running a site directly out of SVN (as opposed to running python setup.py install out of SVN) are going to find your installs broken soon. We've been holding off for a long time on fixing the directory structure in the source tree, and we really need to do this before 1.0. If you're still doing this, please try to switch over to an installed setup using our rb-site tool. We'll be glad to work with you on any migration problems if they arise. Thanks to everyone who's helped out with Review Board so far. We hit both our 100th and 101st contributor tonight (counting those who have code in the tree). We really couldn't have done this without the help of the people on here reporting bugs, contributing to the code and documentation, and providing support on this mailing list. So again, thank you all. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: anonymous users shouldn't be able to leave comments
I'm surprised I missed that during testing. Would you mind filing a bug on this? We'll be sure to fix it soon. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Wed, Jan 21, 2009 at 12:32 PM, Martin mkoeb...@gmail.com wrote: Hi, A colleague of mine just ran into that: I had anonymous viewing of reviews and diffs enabled. If you now view a diff as anonymous, you can leave comments. Attempts to publish or edit the review will fail, because it asks you to login and will not remember your changes (obviously, since they are not in the database). Wouldn't it be better to turn off the ability to create comments when you are not logged in? My colleague spent half an hour creating comments, which he lost because he didn't realize he was not logged in. Thanks, Martin --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Reviewboard alpa
I'm not sure, but I might be having the same site media problem. I'm familiar with django, but not the way djiblets does the database settings stuff. Basically, the MEDIA_URL isn't being set at all. I've tried setting it through the admin interface, but what I'd think would be the correct value of /media/ (no quotes) throws up an Enter a valid URL. error when I try and save it. All of the media is attempting to be pulled from urls like http://media/djblets/js/jquery-1.2.6.min.js or http://media/rb/css/admin.css I tried setting a MEDIA_URL in my settings_local, but it looks like it's over-ridden in settings.py anyway (and possible through whatever the djiblets stuff does that I don't fully understand). The more confusing part is that I can't get any value to stick in the media url field with the description- Media URL: The URL to the media files. Leave blank to use the default media path on this server. I've tried: /, /media/, http://test.reviews/media/, /media and leaving it blank and I always get the Enter a valid URL message (which is placed above the Server field in reality, so maybe I'm just misunderstanding, but I can't get any valid values for that either). Also, the default value for Media URL when I load http://test.reviews/admin/settings/general/ is //media/' despite the fact that I can't even resubmit the form to keep it as //media/ I'm using the easy_install with 1.0alpha2.dev_20090121 And yes, my media works fine if I just access it via something like http://test.reviews/media/djiblets Any suggestions? thanks -wes On Jan 20, 5:05 am, roshan pius roshanpiustho...@gmail.com wrote: The Permissions have been set: drwxrwxrwx 3 www-data www-data 4096 Jan 19 20:05 . drwxrwxrwx 5 www-data www-data 4096 Jan 19 20:05 .. lrwxrwxrwx 1 www-data www-data 99 Jan 19 20:05 errordocs - /usr/local/lib/python2.6/site-packages/ReviewBoard-1.0alpha1-py2.6.egg/reviewboard/htdocs/errordocs drwxrwxrwx 3 www-data www-data 4096 Jan 19 20:05media On Tue, Jan 20, 2009 at 3:24 PM, Christian Hammond chip...@chipx86.com wrote: Okay, so you're getting a Forbidden error with this directory, but the HTML file for that is missing so it's sending a 404 instead. What you're seeing is a config error on your server where Apache's user is unable to access yourmediadirectory. The user just doesn't have the permissions required. Check to make sure your site's htdocs/mediadirectory (and everything else in htdocs/) has permissions set so that the Apache user can access it. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Tue, Jan 20, 2009 at 1:46 AM, roshan pius roshanpiustho...@gmail.com wrote: I added the line to vhosts.conf file Options FollowSymLinks When i tried accessing thehttp://135.254.219.50/media/- I got this error on the browser Page not found (404) Request Method: GET Request URL: http://135.254.219.50/error/HTTP_FORBIDDEN.html.var Regards, Roshan Pius On Tue, Jan 20, 2009 at 3:06 PM, Christian Hammond chip...@chipx86.com wrote: That file seems to have some issues. Perhaps the browser tried to normalize the file paths, but they end up looking like: SCRIPT type=text/javascript src=./Dashboard Review Board administration_files/jquery-1.2.6.min.js/SCRIPT There's also a bunch of custom HTML in there, and existing HTML that's modified. Definitely looks like the browser is doing it. Can you look at the source for that file in your browser, find any link or script line, and paste it? Also, what happens if you go tohttp://yoursite/media/? Do you get a 404, or a directory with admin and rb and djblets ? Another thing that could potentially cause this is Apache being configured to block symlinks by default. Try to edit your Apache config and, in the Location /media section, add: Options FollowSymLinks This may fix it. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Tue, Jan 20, 2009 at 1:17 AM, roshan pius roshanpiustho...@gmail.com wrote: Hi , The post-review worked once i removed the old cookies file. You may want to also try going tohttp://yoursite/admin/, logging in, clicking on Settings, and then checking what the MediaURL is set to. It should be /media/. If not, you can set this and then click Save. It should all work even if the page styles aren't there. I already tried this and no luck. MymediaURL is already /media/. I've attached the admin html page. i accessed using the url : http://xxx.xxx.xxx.xxx/admin Thanks, Roshan Pius On Tue, Jan 20, 2009 at 2:26 PM, Christian Hammond chip...@chipx86.com wrote: Can you run post-review with -d and attach the debug log? Is it just asking for a password over and over? If so, try deleting ~/.post-review-cookies.txt. I'm imagining the problem is the site root ormediaroot. Can you
Re: Reviewboard alpa
Django's URLField requires a fully-qualified domain (like foo.com), so if you're using something like http://reviews/, it'll complain. I want to change this at some point, since internal domains should be fine. Are you using such a domain in that field? I imagine the media field is actually fine, and once you enter a URL that the URLField is happy with, it should fix the double / in the media path. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Wed, Jan 21, 2009 at 9:45 PM, Wes Winham winha...@gmail.com wrote: I'm not sure, but I might be having the same site media problem. I'm familiar with django, but not the way djiblets does the database settings stuff. Basically, the MEDIA_URL isn't being set at all. I've tried setting it through the admin interface, but what I'd think would be the correct value of /media/ (no quotes) throws up an Enter a valid URL. error when I try and save it. All of the media is attempting to be pulled from urls like http://media/djblets/js/jquery-1.2.6.min.js or http://media/rb/css/admin.css I tried setting a MEDIA_URL in my settings_local, but it looks like it's over-ridden in settings.py anyway (and possible through whatever the djiblets stuff does that I don't fully understand). The more confusing part is that I can't get any value to stick in the media url field with the description- Media URL: The URL to the media files. Leave blank to use the default media path on this server. I've tried: /, /media/, http://test.reviews/media/, /media and leaving it blank and I always get the Enter a valid URL message (which is placed above the Server field in reality, so maybe I'm just misunderstanding, but I can't get any valid values for that either). Also, the default value for Media URL when I load http://test.reviews/admin/settings/general/ is //media/' despite the fact that I can't even resubmit the form to keep it as //media/ I'm using the easy_install with 1.0alpha2.dev_20090121 And yes, my media works fine if I just access it via something like http://test.reviews/media/djiblets Any suggestions? thanks -wes On Jan 20, 5:05 am, roshan pius roshanpiustho...@gmail.com wrote: The Permissions have been set: drwxrwxrwx 3 www-data www-data 4096 Jan 19 20:05 . drwxrwxrwx 5 www-data www-data 4096 Jan 19 20:05 .. lrwxrwxrwx 1 www-data www-data 99 Jan 19 20:05 errordocs - /usr/local/lib/python2.6/site-packages/ReviewBoard-1.0alpha1-py2.6.egg/reviewboard/htdocs/errordocs drwxrwxrwx 3 www-data www-data 4096 Jan 19 20:05media On Tue, Jan 20, 2009 at 3:24 PM, Christian Hammond chip...@chipx86.com wrote: Okay, so you're getting a Forbidden error with this directory, but the HTML file for that is missing so it's sending a 404 instead. What you're seeing is a config error on your server where Apache's user is unable to access yourmediadirectory. The user just doesn't have the permissions required. Check to make sure your site's htdocs/mediadirectory (and everything else in htdocs/) has permissions set so that the Apache user can access it. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Tue, Jan 20, 2009 at 1:46 AM, roshan pius roshanpiustho...@gmail.com wrote: I added the line to vhosts.conf file Options FollowSymLinks When i tried accessing thehttp://135.254.219.50/media/- I got this error on the browser Page not found (404) Request Method: GET Request URL:http://135.254.219.50/error/HTTP_FORBIDDEN.html.var Regards, Roshan Pius On Tue, Jan 20, 2009 at 3:06 PM, Christian Hammond chip...@chipx86.com wrote: That file seems to have some issues. Perhaps the browser tried to normalize the file paths, but they end up looking like: SCRIPT type=text/javascript src=./Dashboard Review Board administration_files/jquery-1.2.6.min.js/SCRIPT There's also a bunch of custom HTML in there, and existing HTML that's modified. Definitely looks like the browser is doing it. Can you look at the source for that file in your browser, find any link or script line, and paste it? Also, what happens if you go tohttp://yoursite/media/? Do you get a 404, or a directory with admin and rb and djblets ? Another thing that could potentially cause this is Apache being configured to block symlinks by default. Try to edit your Apache config and, in the Location /media section, add: Options FollowSymLinks This may fix it. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Tue, Jan 20, 2009 at 1:17 AM, roshan pius roshanpiustho...@gmail.com wrote: Hi , The post-review worked once i removed the old cookies file. You may want to also try going tohttp://yoursite/admin/, logging in, clicking on Settings, and then checking what the MediaURL is
Re: Reviewboard alpa
Well that was easy :) Thanks for the quick help. Switching it to a fully qualified domain name and using /etc/hosts to catch it made everything work like a charm after the re-install. So it sounds like the error message I thought might be coming from the Server actually was and I wasn't even stressing over the right field. doh Thanks again -wes On Jan 22, 12:52 am, Christian Hammond chip...@chipx86.com wrote: Django's URLField requires a fully-qualified domain (like foo.com), so if you're using something likehttp://reviews/, it'll complain. I want to change this at some point, since internal domains should be fine. Are you using such a domain in that field? I imagine the media field is actually fine, and once you enter a URL that the URLField is happy with, it should fix the double / in the media path. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Wed, Jan 21, 2009 at 9:45 PM, Wes Winham winha...@gmail.com wrote: I'm not sure, but I might be having the same site media problem. I'm familiar with django, but not the way djiblets does the database settings stuff. Basically, the MEDIA_URL isn't being set at all. I've tried setting it through the admin interface, but what I'd think would be the correct value of /media/ (no quotes) throws up an Enter a valid URL. error when I try and save it. All of the media is attempting to be pulled from urls likehttp://media/djblets/js/jquery-1.2.6.min.jsor http://media/rb/css/admin.css I tried setting a MEDIA_URL in my settings_local, but it looks like it's over-ridden in settings.py anyway (and possible through whatever the djiblets stuff does that I don't fully understand). The more confusing part is that I can't get any value to stick in the media url field with the description- Media URL: The URL to the media files. Leave blank to use the default media path on this server. I've tried: /, /media/,http://test.reviews/media/, /media and leaving it blank and I always get the Enter a valid URL message (which is placed above the Server field in reality, so maybe I'm just misunderstanding, but I can't get any valid values for that either). Also, the default value for Media URL when I load http://test.reviews/admin/settings/general/is //media/' despite the fact that I can't even resubmit the form to keep it as //media/ I'm using the easy_install with 1.0alpha2.dev_20090121 And yes, my media works fine if I just access it via something like http://test.reviews/media/djiblets Any suggestions? thanks -wes On Jan 20, 5:05 am, roshan pius roshanpiustho...@gmail.com wrote: The Permissions have been set: drwxrwxrwx 3 www-data www-data 4096 Jan 19 20:05 . drwxrwxrwx 5 www-data www-data 4096 Jan 19 20:05 .. lrwxrwxrwx 1 www-data www-data 99 Jan 19 20:05 errordocs - /usr/local/lib/python2.6/site-packages/ReviewBoard-1.0alpha1-py2.6.egg/reviewboard/htdocs/errordocs drwxrwxrwx 3 www-data www-data 4096 Jan 19 20:05media On Tue, Jan 20, 2009 at 3:24 PM, Christian Hammond chip...@chipx86.com wrote: Okay, so you're getting a Forbidden error with this directory, but the HTML file for that is missing so it's sending a 404 instead. What you're seeing is a config error on your server where Apache's user is unable to access yourmediadirectory. The user just doesn't have the permissions required. Check to make sure your site's htdocs/mediadirectory (and everything else in htdocs/) has permissions set so that the Apache user can access it. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Tue, Jan 20, 2009 at 1:46 AM, roshan pius roshanpiustho...@gmail.com wrote: I added the line to vhosts.conf file Options FollowSymLinks When i tried accessing thehttp://135.254.219.50/media/-I got this error on the browser Page not found (404) Request Method: GET Request URL: http://135.254.219.50/error/HTTP_FORBIDDEN.html.var Regards, Roshan Pius On Tue, Jan 20, 2009 at 3:06 PM, Christian Hammond chip...@chipx86.com wrote: That file seems to have some issues. Perhaps the browser tried to normalize the file paths, but they end up looking like: SCRIPT type=text/javascript src=./Dashboard Review Board administration_files/jquery-1.2.6.min.js/SCRIPT There's also a bunch of custom HTML in there, and existing HTML that's modified. Definitely looks like the browser is doing it. Can you look at the source for that file in your browser, find any link or script line, and paste it? Also, what happens if you go tohttp://yoursite/media/?Do you get a 404, or a directory with admin and rb and djblets ? Another thing that could potentially cause this is Apache being configured to block symlinks by default. Try to edit your Apache config and, in the
Issue 826 in reviewboard: Publishing screenshot comment reviews fails and duplicates comments
Comment #1 on issue 826 by timw.at.work: Publishing screenshot comment reviews fails and duplicates comments http://code.google.com/p/reviewboard/issues/detail?id=826 I have not had this problem since correcting an issue in my database (probably related to a local test I was running). I haven't reproduced this issue within the last day. I'll post again if I have not seen it for another two days. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
