Fwd: Google Summer of Code

2009-03-19 Thread Christopher Orr

Begin forwarded message:
> From: Alejandro Cadavid 
> Date: 20 March 2009 02:34:24 GMT
> To: Christopher Orr 
> Subject: Re: Google Summer of Code
> X-Spam-Status: No, score=0.6 required=3.9 tests=BAYES_00,X_IP  
> autolearn=no version=3.2.5
>
> I never heard about this project before, it was just checking the list
> of mentoring organizations that i found it.. it's a pretty good tool
> to keep code organized and develope good ideas around it.
> Congratulations for being accepted on Google Summer of Code!.
>
> I was just wondering, i'm not Eclipse user, I use Emacs to write my
> code. I know that Emacs it's not used so widely used as IDEs like
> Eclipse or NetBeans in the software industry (I think it's due to the
> lazyness of developers to work a little bit on learning how to use
> Emacs).. But anyway I would like to ask.. do people show any interest
> on an emacs mode for Review board? Would it be a cool propouse for an
> application to the project? Or the "Eclipse Plugin" would be more
> imperative?
>
> Thanks for any comments about it!
>
> On 19 mar, 18:22, Christopher Orr  wrote:
>> Hi all,
>>
>> I just saw that Review Board got accepted for Google Summer of Code
>> this year.  Great news!
>>
>> The ideas page is looking 
>> good:http://code.google.com/p/reviewboard/wiki/Summer_of_Code_Ideas
>>
>> Just in case any potential students are reading, Eclipse integration
>> would be an excellent choice! ;)
>>
>> Chris


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Blank skin at startup

2009-03-19 Thread laurent.dufrec...@gmail.com

Oups sorry christian I didn't seen youy previous mail.
But now seems solved
Thx anyway for your support!
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Blank skin at startup

2009-03-19 Thread laurent.dufrec...@gmail.com

Fianlly get it works...
I set back /media/ and it works :)

On 20 mar, 00:34, "laurent.dufrec...@gmail.com"
 wrote:
> sorry... I've missed something else...
> Now I can log to the webpage server but the "skin" is blank ("raw")
> I suspect a problem with media?
>
> so here are some info:
> laur...@dev:/var/www/reviews/htdocs$ ls -l
> total 8
> lrwxrwxrwx 1 root root   93 2009-03-19 23:16 errordocs
> drwxr-xr-x 3 root root 4096 2009-03-19 23:16 media
>
> (i've run sudo chown -R www-data:www-data db htdocs/media/uploaded)
>
> Goind into admin mode media url is:
> /reviews/htdocs/media/
> (was /media/ before but it changes nothing... :( )
>
> and:
>         # Serve static media without running it through mod_python
>         # (overrides the above)
>         
>                 SetHandler None
>         
>         
>                 SetHandler None
>         
>
>         
>                 AllowOverride All
>         
>
>         # Alias static media requests to filesystem
>         Alias /media /var/www/reviews/htdocs/media
>         Alias /errordocs /var/www/reviews/htdocs/errordocs
> 
>
> Any idea?
>
> Laurent
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Blank skin at startup

2009-03-19 Thread Christian Hammond
Can you privately e-mail me your Apache config file and your
conf/settings_local.py file (in your site tree)?

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Thu, Mar 19, 2009 at 4:34 PM, laurent.dufrec...@gmail.com <
laurent.dufrec...@gmail.com> wrote:

>
> sorry... I've missed something else...
> Now I can log to the webpage server but the "skin" is blank ("raw")
> I suspect a problem with media?
>
> so here are some info:
> laur...@dev:/var/www/reviews/htdocs$ ls -l
> total 8
> lrwxrwxrwx 1 root root   93 2009-03-19 23:16 errordocs
> drwxr-xr-x 3 root root 4096 2009-03-19 23:16 media
>
> (i've run sudo chown -R www-data:www-data db htdocs/media/uploaded)
>
> Goind into admin mode media url is:
> /reviews/htdocs/media/
> (was /media/ before but it changes nothing... :( )
>
> and:
># Serve static media without running it through mod_python
># (overrides the above)
>
>SetHandler None
>
>
>SetHandler None
>
>
>
>AllowOverride All
>
>
># Alias static media requests to filesystem
>Alias /media /var/www/reviews/htdocs/media
>Alias /errordocs /var/www/reviews/htdocs/errordocs
> 
>
> Any idea?
>
> Laurent
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Blank skin at startup

2009-03-19 Thread laurent.dufrec...@gmail.com

sorry... I've missed something else...
Now I can log to the webpage server but the "skin" is blank ("raw")
I suspect a problem with media?

so here are some info:
laur...@dev:/var/www/reviews/htdocs$ ls -l
total 8
lrwxrwxrwx 1 root root   93 2009-03-19 23:16 errordocs
drwxr-xr-x 3 root root 4096 2009-03-19 23:16 media

(i've run sudo chown -R www-data:www-data db htdocs/media/uploaded)

Goind into admin mode media url is:
/reviews/htdocs/media/
(was /media/ before but it changes nothing... :( )

and:
# Serve static media without running it through mod_python
# (overrides the above)

SetHandler None


SetHandler None



AllowOverride All


# Alias static media requests to filesystem
Alias /media /var/www/reviews/htdocs/media
Alias /errordocs /var/www/reviews/htdocs/errordocs


Any idea?

Laurent
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Google Summer of Code

2009-03-19 Thread Christopher Orr

Hi all,

I just saw that Review Board got accepted for Google Summer of Code  
this year.  Great news!

The ideas page is looking good:
http://code.google.com/p/reviewboard/wiki/Summer_of_Code_Ideas

Just in case any potential students are reading, Eclipse integration  
would be an excellent choice! ;)

Chris

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Need some help with apache2 configuration...

2009-03-19 Thread Laurent Dufrechou
Yep, I've seen the previous thread about debian :)
Thx, it seems to work now :)

2009/3/20 Christian Hammond 

> Default Ubuntu installs of Apache have a /etc/apache2/sites-enabled/default
> or 000-default file that shares /var/www itself as the website for all URLs.
> Try removing this file and restarting Apache.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board - http://www.review-board.org
> VMware, Inc. - http://www.vmware.com
>
>
>
> On Thu, Mar 19, 2009 at 4:04 PM, laurent.dufrec...@gmail.com <
> laurent.dufrec...@gmail.com> wrote:
>
>>
>> Hello,
>> I'm trying to install reviewboard
>> i've followed the insatll book but apache don't want to show up review
>> board.
>> :(
>>
>> I've asked to insatll reviewboard @localhost/reviews
>> but when i go there i see the directory listing and not reviewboard
>> python web interface.
>> So i suspect something is missing.
>> At below of the page there is written:
>> Apache/2.2.8 (Ubuntu) mod_python/3.3.1 Python/2.5.2 Server at
>> localhost Port 80
>>
>> I've copied /var/www/reviews/conf/apache-modpython.conf to /etc/
>> apache2/sites-available
>> and done a2ensite apache-modpython.conf
>> I needed to modify it:
>>  <-- removed :
>> 80 becasue get an apache warning
>>ServerName 127.0.0.1
>>DocumentRoot /var/www/reviews/htdocs
>>
>> Done sudo /etc/apache2 restart
>>
>> But well nothing happens when i go to http://localhost/reviews/
>>
>> Does any of us can give me a little idea to try?
>>
>> thx!
>>
>> Laurent
>>
>>
>
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Need some help with apache2 configuration...

2009-03-19 Thread Christian Hammond
Default Ubuntu installs of Apache have a /etc/apache2/sites-enabled/default
or 000-default file that shares /var/www itself as the website for all URLs.
Try removing this file and restarting Apache.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Thu, Mar 19, 2009 at 4:04 PM, laurent.dufrec...@gmail.com <
laurent.dufrec...@gmail.com> wrote:

>
> Hello,
> I'm trying to install reviewboard
> i've followed the insatll book but apache don't want to show up review
> board.
> :(
>
> I've asked to insatll reviewboard @localhost/reviews
> but when i go there i see the directory listing and not reviewboard
> python web interface.
> So i suspect something is missing.
> At below of the page there is written:
> Apache/2.2.8 (Ubuntu) mod_python/3.3.1 Python/2.5.2 Server at
> localhost Port 80
>
> I've copied /var/www/reviews/conf/apache-modpython.conf to /etc/
> apache2/sites-available
> and done a2ensite apache-modpython.conf
> I needed to modify it:
>  <-- removed :
> 80 becasue get an apache warning
>ServerName 127.0.0.1
>DocumentRoot /var/www/reviews/htdocs
>
> Done sudo /etc/apache2 restart
>
> But well nothing happens when i go to http://localhost/reviews/
>
> Does any of us can give me a little idea to try?
>
> thx!
>
> Laurent
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Need some help with apache2 configuration...

2009-03-19 Thread laurent.dufrec...@gmail.com

Hello,
I'm trying to install reviewboard
i've followed the insatll book but apache don't want to show up review
board.
:(

I've asked to insatll reviewboard @localhost/reviews
but when i go there i see the directory listing and not reviewboard
python web interface.
So i suspect something is missing.
At below of the page there is written:
Apache/2.2.8 (Ubuntu) mod_python/3.3.1 Python/2.5.2 Server at
localhost Port 80

I've copied /var/www/reviews/conf/apache-modpython.conf to /etc/
apache2/sites-available
and done a2ensite apache-modpython.conf
I needed to modify it:
 <-- removed :
80 becasue get an apache warning
ServerName 127.0.0.1
DocumentRoot /var/www/reviews/htdocs

Done sudo /etc/apache2 restart

But well nothing happens when i go to http://localhost/reviews/

Does any of us can give me a little idea to try?

thx!

Laurent
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Slow Performance On Large Diffs -- much better, but still a big issue for us.

2009-03-19 Thread ciaomary

Thanks again. I'm really not that familiar with Apache 2 w/ regards to
performance issues. At this time, I just have a more or less out-of-
the-box Apache2 setup on CentOS 5. Any recommendations here would be
hugely appreciated. Further answers inline below...

On Mar 19, 12:09 pm, Christian Hammond  wrote:
> We should figure out first why your backend server is being hit so hard. We
> have over a thousand people at VMware submitting good sized diffs and aren't
> hitting any of these issues. So a few more questions. Apologies if you've
> answered these before in other threads.
>
> 1) What MPM is your Apache using?
>

I'm using the default for httpd 2.2.3 CentOS. I believe this is
'prefork'.

> 2) And is this fastcgi or mod_python?
>

mod_python (mod_python-3.2.8-3.1)

> 3) Are you absolutely sure Review Board is using your memcached server? Go
> in the admin dashboard and click Server Cache, then copy and paste the info
> and paste it here.


Server Cache
Cache backend: django.core.cache.backends.memcached
Statistics
127.0.0.1:11211 Memory usage:   45.7 MB
Keys in cache:  1767 of 1777
Cache hits: 3996 of 7464: 53%
Cache misses:   3468 of 7464: 46%
Cache evictions:0
Cache traffic:  46.1 MB in, 103.8 MB out
Uptime: 53009


>
> We might be able to do something smarter with deleted diffs, but that would
> require a good bit of work, and we'd have to think carefully about it.
>
> We talked about splitting up the reviews page, but decided it wouldn't make
> much sense due to how it's ordered. We came up with a method for collapsing,
> but  I'm probably holding off until after 1.0 to finish this, because it
> needs a lot more thought and testing.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.review-board.org
> VMware, Inc. -http://www.vmware.com
>
>
>
> On Thu, Mar 19, 2009 at 11:39 AM, ciaomary  wrote:
>
> > Thanks for your response. Please see comments inline below...
>
> > On Mar 18, 11:35 am, Christian Hammond  wrote:
> > > Not immediately, no.
>
> > > I can't even determine right now whether we can do anything about this.
> > > You're seeing crazy CPU loads that we're definitely not seeing, and most
> > of
> > > this has to do with the browser itself. We're loading the files
> > > asynchronously, but it appears that for whatever reason your browser is
> > > blocking until it's all loaded (if I'm understanding right).
>
> > Just for clarity, the page can sometimes load partially, but since the
> > CPU is at 99% it's of little value. I don't get the CPU back until the
> > page is fully loaded.
>
> > We now understand that our backend server is also getting maxed out to
> > the point of failure. One request of this page demands 800 M of
> > virtual memory from Apache! Once the request is fully loaded, 400 M of
> > that memory is freed again - but since we have 200 reviewboard users
> > this isn't very scalable.
>
> > > I'm wondering
> > > if there's something with the configuration in your browsers where you
> > work
> > > that is causing some of this.
>
> > I really don't think this is a browser configuration issue because
> > users across many different OS and browsers are seeing this. I see it
> > on default FireFox 3.0.7 and IE 7.0. Users have reported that Safari
> > works the best, but I have not confirmed. FireFox 2 and IE 6 users
> > have reported the same problem.
>
> > > You say this is happening on several different browsers? In the case of
> > > Firefox, what extensions are loaded?
>
> > Just the default FireFox 3.0.7 install.
>
> > > We definitely would like to fix this. But we just don't know enough about
> > > what the problem is right now to determine if it's in our control.
>
> > Apache must load up a huge amount of data in VM for these large diffs
> > (I believe this is especially true when diffs contain deleted files).
> > This isn't scalable across many users. Can the amount of data/
> > filediffs/etc needed to load the page be scaled back further? Changing
> > the 'Paginate by' value from 20 to 3 has helped, but not enough and it
> > hasn't helped the review page obviously.
>
> > Instead of showing all lines for deleted files can this be loaded
> > later only on request?
> > Can the 'View Reviews' page be broken up or paginated as well?
> > I think these two suggestions would help us.
>
> > > Christian
>
> > > --
> > > Christian Hammond - chip...@chipx86.com
> > > Review Board -http://www.review-board.org
> > > VMware, Inc. -http://www.vmware.com
>
> > > On Wed, Mar 18, 2009 at 9:54 AM, ciaomary  wrote:
>
> > > > Can anything be done to fix the pegged CPU issue I've reported in my
> > > > prior email?
>
> > > > On Mar 17, 9:38 am, ciaomary  wrote:
> > > > > The downloadable diff for the review is 1.6MB.
>
> > > > > The review has 138 different files (7 pages).
>
> > > > > Page 1 loads in ~1 minute in FireFox. The twenty files are on average
> > > > > 38 K. (max=118K, min=2K). Here all files have edit changes (no
> > deleted
> 

Reviweing a patch and a directory/working copy

2009-03-19 Thread Prabhu Ramachandran

Hi,

First thanks for the excellent software! I have only started using 
reviewboard but am very impressed thus far.  I have one naive question.

Is it possible to do reviews of patches submitted against a particular 
directory containing the code.  This comes up because I can only host a 
reviewboard server behind a firewall and want to review patches 
submitted to software projects that I have a working copy of but not the 
repository itself.  This peculiarity arises since I am behind an 
authenticated proxy and I cannot setup reviewboard to access the web 
directly. Local repositories are not problems but the remote one is.

Essentially, is there a way to setup a "repository" as just a directory 
(or a working copy) and review diffs submitted against that?  Is this 
doable?  I am running 1.0alpha4 on an Ubuntu 8.04 i386 machine.

Thanks!

cheers,
-- 
Prabhu Ramachandran http://www.aero.iitb.ac.in/~prabhu

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Slow Performance On Large Diffs -- much better, but still a big issue for us.

2009-03-19 Thread Christian Hammond
We should figure out first why your backend server is being hit so hard. We
have over a thousand people at VMware submitting good sized diffs and aren't
hitting any of these issues. So a few more questions. Apologies if you've
answered these before in other threads.

1) What MPM is your Apache using?

2) And is this fastcgi or mod_python?

3) Are you absolutely sure Review Board is using your memcached server? Go
in the admin dashboard and click Server Cache, then copy and paste the info
and paste it here.

We might be able to do something smarter with deleted diffs, but that would
require a good bit of work, and we'd have to think carefully about it.

We talked about splitting up the reviews page, but decided it wouldn't make
much sense due to how it's ordered. We came up with a method for collapsing,
but  I'm probably holding off until after 1.0 to finish this, because it
needs a lot more thought and testing.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Thu, Mar 19, 2009 at 11:39 AM, ciaomary  wrote:

>
> Thanks for your response. Please see comments inline below...
>
> On Mar 18, 11:35 am, Christian Hammond  wrote:
> > Not immediately, no.
> >
> > I can't even determine right now whether we can do anything about this.
> > You're seeing crazy CPU loads that we're definitely not seeing, and most
> of
> > this has to do with the browser itself. We're loading the files
> > asynchronously, but it appears that for whatever reason your browser is
> > blocking until it's all loaded (if I'm understanding right).
>
> Just for clarity, the page can sometimes load partially, but since the
> CPU is at 99% it's of little value. I don't get the CPU back until the
> page is fully loaded.
>
> We now understand that our backend server is also getting maxed out to
> the point of failure. One request of this page demands 800 M of
> virtual memory from Apache! Once the request is fully loaded, 400 M of
> that memory is freed again - but since we have 200 reviewboard users
> this isn't very scalable.
>
> > I'm wondering
> > if there's something with the configuration in your browsers where you
> work
> > that is causing some of this.
> >
>
> I really don't think this is a browser configuration issue because
> users across many different OS and browsers are seeing this. I see it
> on default FireFox 3.0.7 and IE 7.0. Users have reported that Safari
> works the best, but I have not confirmed. FireFox 2 and IE 6 users
> have reported the same problem.
>
> > You say this is happening on several different browsers? In the case of
> > Firefox, what extensions are loaded?
> >
>
> Just the default FireFox 3.0.7 install.
>
> > We definitely would like to fix this. But we just don't know enough about
> > what the problem is right now to determine if it's in our control.
> >
>
> Apache must load up a huge amount of data in VM for these large diffs
> (I believe this is especially true when diffs contain deleted files).
> This isn't scalable across many users. Can the amount of data/
> filediffs/etc needed to load the page be scaled back further? Changing
> the 'Paginate by' value from 20 to 3 has helped, but not enough and it
> hasn't helped the review page obviously.
>
> Instead of showing all lines for deleted files can this be loaded
> later only on request?
> Can the 'View Reviews' page be broken up or paginated as well?
> I think these two suggestions would help us.
>
>
> > Christian
> >
> > --
> > Christian Hammond - chip...@chipx86.com
> > Review Board -http://www.review-board.org
> > VMware, Inc. -http://www.vmware.com
> >
> >
> >
> > On Wed, Mar 18, 2009 at 9:54 AM, ciaomary  wrote:
> >
> > > Can anything be done to fix the pegged CPU issue I've reported in my
> > > prior email?
> >
> > > On Mar 17, 9:38 am, ciaomary  wrote:
> > > > The downloadable diff for the review is 1.6MB.
> >
> > > > The review has 138 different files (7 pages).
> >
> > > > Page 1 loads in ~1 minute in FireFox. The twenty files are on average
> > > > 38 K. (max=118K, min=2K). Here all files have edit changes (no
> deleted
> > > > files.)
> >
> > > > Page 3 loads in ~3 minutes in FireFox. The twenty files are on
> average
> > > > 25K . No major deviations from the average. Here 12 of the files have
> > > > been deleted rather than just edited.
> >
> > > > There are hundreds of review comments on this review across many
> users
> > > > and files.
> >
> > > > During page load, the CPU is pegged and the browser is unresponsive
> > > > for a good 2-3 minutes. This is the cause every time, very
> > > > reproducable. If you are patient the page finally loads and the
> system
> > > > CPU returns to normal.
> >
> > > > FireBug shows an HTTPS GET request for each of the twenty files
> during
> > > > the slow down/cpu pegging. Each HTTPS GETS are taking longer on page
> > > > 3, with some taking up to 2.5 seconds (others < 50ms). Since the is
> > > > cpu is pegged the br

Re: Slow Performance On Large Diffs -- much better, but still a big issue for us.

2009-03-19 Thread ciaomary

Thanks for your response. Please see comments inline below...

On Mar 18, 11:35 am, Christian Hammond  wrote:
> Not immediately, no.
>
> I can't even determine right now whether we can do anything about this.
> You're seeing crazy CPU loads that we're definitely not seeing, and most of
> this has to do with the browser itself. We're loading the files
> asynchronously, but it appears that for whatever reason your browser is
> blocking until it's all loaded (if I'm understanding right).

Just for clarity, the page can sometimes load partially, but since the
CPU is at 99% it's of little value. I don't get the CPU back until the
page is fully loaded.

We now understand that our backend server is also getting maxed out to
the point of failure. One request of this page demands 800 M of
virtual memory from Apache! Once the request is fully loaded, 400 M of
that memory is freed again - but since we have 200 reviewboard users
this isn't very scalable.

> I'm wondering
> if there's something with the configuration in your browsers where you work
> that is causing some of this.
>

I really don't think this is a browser configuration issue because
users across many different OS and browsers are seeing this. I see it
on default FireFox 3.0.7 and IE 7.0. Users have reported that Safari
works the best, but I have not confirmed. FireFox 2 and IE 6 users
have reported the same problem.

> You say this is happening on several different browsers? In the case of
> Firefox, what extensions are loaded?
>

Just the default FireFox 3.0.7 install.

> We definitely would like to fix this. But we just don't know enough about
> what the problem is right now to determine if it's in our control.
>

Apache must load up a huge amount of data in VM for these large diffs
(I believe this is especially true when diffs contain deleted files).
This isn't scalable across many users. Can the amount of data/
filediffs/etc needed to load the page be scaled back further? Changing
the 'Paginate by' value from 20 to 3 has helped, but not enough and it
hasn't helped the review page obviously.

Instead of showing all lines for deleted files can this be loaded
later only on request?
Can the 'View Reviews' page be broken up or paginated as well?
I think these two suggestions would help us.


> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.review-board.org
> VMware, Inc. -http://www.vmware.com
>
>
>
> On Wed, Mar 18, 2009 at 9:54 AM, ciaomary  wrote:
>
> > Can anything be done to fix the pegged CPU issue I've reported in my
> > prior email?
>
> > On Mar 17, 9:38 am, ciaomary  wrote:
> > > The downloadable diff for the review is 1.6MB.
>
> > > The review has 138 different files (7 pages).
>
> > > Page 1 loads in ~1 minute in FireFox. The twenty files are on average
> > > 38 K. (max=118K, min=2K). Here all files have edit changes (no deleted
> > > files.)
>
> > > Page 3 loads in ~3 minutes in FireFox. The twenty files are on average
> > > 25K . No major deviations from the average. Here 12 of the files have
> > > been deleted rather than just edited.
>
> > > There are hundreds of review comments on this review across many users
> > > and files.
>
> > > During page load, the CPU is pegged and the browser is unresponsive
> > > for a good 2-3 minutes. This is the cause every time, very
> > > reproducable. If you are patient the page finally loads and the system
> > > CPU returns to normal.
>
> > > FireBug shows an HTTPS GET request for each of the twenty files during
> > > the slow down/cpu pegging. Each HTTPS GETS are taking longer on page
> > > 3, with some taking up to 2.5 seconds (others < 50ms). Since the is
> > > cpu is pegged the browser processing seems to be the cause of the
> > > delay however.
>
> > > On Mar 16, 6:31 pm, Christian Hammond  wrote:
>
> > > > So it's really going to depend on the sizes of the individual files
> > > > themselves. If a file is by itself large enough to cause a couple meg
> > diff
> > > > to be generated, there's nothing we can do really do, since that boils
> > down
> > > > to too large a file to show in the browser.
>
> > > > In your page 3 example, how big are the files and the diffs in
> > particular?
>
> > > > The page itself loads quick enough, right? It's just the diff
> > fragments?
> > > > Which ones are you finding takes a long time and how big are those
> > changes?
>
> > > > Christian
>
> > > > --
> > > > Christian Hammond - chip...@chipx86.com
> > > > Review Board -http://www.review-board.org
> > > > VMware, Inc. -http://www.vmware.com
>
> > > > On Mon, Mar 16, 2009 at 5:32 PM, mary  wrote:
>
> > > > > On really large diffs, performance is very slow and can crash the
> > > > > browser.
>
> > > > > We've picked up the recent 3/13/09 nightly which has helped
> > enormously
> > > > > (A BIG THANKS!) but that said, we're still finding pages that take 3+
> > > > > minutes to load.
>
> > > > > For example we have one review in particular that has File
> > Changes
> > > >

Re: Unable to get any images and .css files are not loaded

2009-03-19 Thread Christian Hammond
Sounds like your Apache/lighttpd configuration isn't correct. Can you paste
it and tell us where the site directory is on your filesystem?

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Thu, Mar 19, 2009 at 4:46 AM, Dev  wrote:

>
> Hi,
>
> I am unable to see any images and .css files are not loaded.In log
> file it shows '404 Not found' .But media directory available inside
> reviewboard directory.
>
> Pl help me in this regard.
>
> Awaiting for reply.
>
> -Dev
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



A reviewboard plugin for Kibot

2009-03-19 Thread Brad Taylor
Hey,

When I started playing with reviewboard for my team, I had an idea
kicking around in my head about writing a plugin for our IRC channel's
kibot instance which announced new review requests.  I put the
finishing touches on it today, and I'm releasing it under the MIT/X11
license.  Check it out.  If you end up using it, let me know.  We're
currently running it in irc.gimp.net, #mono-a11y.

Best,

-Brad

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

#!/usr/bin/env python

# Permission is hereby granted, free of charge, to any person obtaining 
# a copy of this software and associated documentation files (the 
# "Software"), to deal in the Software without restriction, including 
# without limitation the rights to use, copy, modify, merge, publish, 
# distribute, sublicense, and/or sell copies of the Software, and to 
# permit persons to whom the Software is furnished to do so, subject to 
# the following conditions: 
#  
# The above copyright notice and this permission notice shall be 
# included in all copies or substantial portions of the Software. 
#  
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, 
# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF 
# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND 
# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE 
# LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION 
# OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION 
# WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. 
# 
# Copyright (c) 2009 Novell, Inc. (http://www.novell.com) 
#
# Authors: 
# Brad Taylor 

#
# reviewboard.py is a kibot plugin which interfaces with Review Board
# (http://www.review-board.org).  It offers a basic query interface and an
# optional notification of new review requests.
#
# This plugin has only been tested with kibot 0.0.12, so if you're using a
# different version, YMMV.
# 
# Installation:
#   - Modify the user-editable configuration section.
#   - Copy reviewboard.py into your kibot modules directory.  Usually this
# will be /usr/share/kibot/modules or /usr/local/share/kibot/modules
#   - Use kibot-control to get into the administrative interface for kibot
# and:
# load reviewboard
#   - To configure new review request notification, in kibot-control, do:
# set reviewboard.notify_channel #my-channel
#

# -- Begin user-editable configuration section --

# The URL to your review board installation. This will be used to do the JSON
# API calls and to search the commit log messages for review request links.
REVIEWBOARD_URL = None

# The timezone of your review board installation.
REVIEWBOARD_TIMEZONE = 'US/Pacific'

# The user to log in as.
USERNAME = ''
PASSWORD = ''

# How often to poll for new review requests in seconds.  If set to 0, the
# plugin will not watch for new review requests.
REVIEW_REQUEST_POLL_INTERVAL = 60

# -- End user-editable configuration section --

import cookielib
import mimetools
import re
import simplejson
import subprocess
import sys
import urllib2
from urlparse import urljoin

class APIError(Exception):
pass

# This is shamelessly ripped off from post-review
class ReviewBoardServer:
"""
An instance of a Review Board server.
"""
def __init__(self, url):
self.url = url
if self.url[-1] != '/':
self.url += '/'
cj = cookielib.CookieJar()
opener = urllib2.build_opener(urllib2.HTTPCookieProcessor(cj))
urllib2.install_opener(opener)

def login(self, username, password):
"""
Logs in to a Review Board server, prompting the user for login
information if needed.
"""
try:
self.api_post('api/json/accounts/login/', {
'username': username,
'password': password,
})
except APIError, e:
rsp, = e.args

die("Unable to log in: %s (%s)" % (rsp["err"]["msg"],
   rsp["err"]["code"]))

def set_submitted(self, review_request_id):
"""
Marks a review request as submitted.
"""
self.api_post('api/json/reviewrequests/%s/close/submitted/' %
  review_request_id)

def process_json(self, data):
"""
Loads in a JSON file and returns the data if successful. On failure,
APIError is raised.
"""
rsp = simplejson.loads(data)

if rsp['stat'] == 'fail':
raise APIError, rsp

return rsp

def

Unable to get any images and .css files are not loaded

2009-03-19 Thread Dev

Hi,

I am unable to see any images and .css files are not loaded.In log
file it shows '404 Not found' .But media directory available inside
reviewboard directory.

Pl help me in this regard.

Awaiting for reply.

-Dev
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---