Re: How to make detailed permission control on ReviewBoard
This support is planned for a future release (probably the 2.0 timeframe) but doesn't exist in any way today. If you really need separation on that level, you may have to set up multiple Review Board servers. If they already have access to the sourcecode on other repositories/groups anyway, and it's just about enforcing a policy about them commenting/reviewing someone else's code, then the best solution today is to just make it clear that they're not allowed to do that. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Dec 15, 2009 at 7:10 PM, JohnHenry qhlonl...@163.com wrote: Hi, all. There is a new request for us. In ReviewBoard, each person has an All review requests on his WebUI so that he can make commentment to all ReviewRequests. But some times we don't want some user to make comment on the project he didnot attend. Or we even did not want him to see the review requests in the ReviewGroup which he is not in. Anyway, We need more detailed and powerful permission control on ReviewGroups. How to realize those functions then? Best Regards! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: About Error occured when print view diff on User WebUI of ReviewBoard
I don't really know what you mean, but I know that many companies using
Review Board have clients on Linux, Windows and Mac who post to a Review
Board server on Linux without any problems. I'd have to see some diffs and
original source files where this fails to have an idea as to what's going
wrong.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Tue, Dec 15, 2009 at 7:55 PM, JohnHenry qhlonl...@163.com wrote:
I have viewed the diff file of both Windows and Linux, It seems that
not only they have difference between there NewLine character, There
are some file format difference but I am not sure, Can any one give a
description of there difference?
Best Regards!
On Dec 15, 4:09 pm, JohnHenry qhlonl...@163.com wrote:
OK, The first problem is that I have Created new ReviewRequest in
WindowsOS through Web UI while the RB Server is on Linux. When I use
post-review in linux to create new ReviewRequest , That will be fine.
But I had not test the windowsOS post-review generated new
ReviewRequest now.
But the second problem, How to make Review to the review request
generated with newly source code( that is the source code has never
been commited to CVS ) is waiting for suggestion.
Best Regards!
On 12月15日, 下午3时36分, JohnHenry qhlonl...@163.com wrote:
Hi,
I have tried to post a review request and publish it using one
User, But in the Reviewers' UI, when He cilck the view diff link on
the top-right, There will be some error infomation:
**
The patch to 'mySouceTest.c' didn't apply cleanly. The temporary files
have been left in '/tmp/reviewboard.zX0n4M' for debugging purposes.
`patch` returned: patching file /tmp/reviewboard.zX0n4M/tmphNZpB0
patch: malformed patch at line 25: - exit(1);
Traceback (most recent call last):
File /data1/John1/bin/develop_tools/python/python2.5/lib/python2.5/
site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/
views.py, line 153, in view_diff
interdiffset, highlighting, True)
File /data1/John1/bin/develop_tools/python/python2.5/lib/python2.5/
site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/
diffutils.py, line 623, in get_diff_files
large_data=True)
File /data1/qiaohl/bin/develop_tools/python/python2.5/lib/python2.5/
site-packages/Djblets-0.5.6-py2.5.egg/djblets/util/misc.py, line 162,
in cache_memoize
data = lookup_callable()
File /data1/John1/bin/develop_tools/python/python2.5/lib/python2.5/
site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/
diffutils.py, line 622, in lambda
enable_syntax_highlighting),
File /data1/John1/bin/develop_tools/python/python2.5/lib/python2.5/
site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/
diffutils.py, line 345, in get_chunks
new = get_patched_file(old, filediff)
File /data1/John1l/bin/develop_tools/python/python2.5/lib/python2.5/
site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/
diffutils.py, line 261, in get_patched_file
return patch(filediff.diff, buffer, filediff.dest_file)
File /data1/John1/bin/develop_tools/python/python2.5/lib/python2.5/
site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/
diffutils.py, line 129, in patch
(filename, tempdir, patch_output))
Exception: The patch to 'myUCMobile.c' didn't apply cleanly. The
temporary files have been left in '/tmp/reviewboard.zX0n4M' for
debugging purposes.
`patch` returned: patching file /tmp/reviewboard.zX0n4M/tmphNZpB0
patch: malformed patch at line 25: - exit(1);
***
Need suggestion.
And, If I want to make a new reivewrequest with a new file that has
never been commited to CVS repository before ,The info would be as
follows:
------
Review request draft saved
Uploading diff, size: 50
HTTP POSTing tohttp://
192.168.3.20:8080/api/json/reviewrequests/9/diff/new/:{}http://192.168.3.20:8080/api/json/reviewrequests/9/diff/new/:%7B%7D
{fields: {path: [The diff file is empty]}, stat: fail,
err: {msg: One or more fields had errors, code: 105}}
Error uploading diff: One or more fields had errors (105) {'fields':
{'path': ['The diff file is empty']}, 'stat': 'fail', 'err': {'msg': 'One or
more fields had errors', 'code': 105}}
Your review request still exists, but the diff is not attached
----
In that case , Can the reviewer see the source code in the new file of
ReviewRequestor's any way?
Best Regards!- Hide quoted text -
- Show quoted text -
--
Want to
Re: About User setting UI
This is a Django bug, though I think there's a bug filed in our own bug tracker for it. We'll probably address this in a future release. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Dec 15, 2009 at 8:32 PM, JohnHenry qhlonl...@163.com wrote: Hi, I found that it is rather hard to use of User setting on Administrator UI, some permissions string are partly hidden by the UI box. And I really don't konw what those permissions mean. For example, I had set a user permission as reviews| review requests|Can change status; But when I logged on with this user, I can't find the Close | Submited button on his top-left toolbar. Is there some detailed info about all those permissions? BestRegards! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Can't add repository on development installation
Hi Ryan,
The Djblets versioning issue is due to our setup.py configuration appending
.dev to the end by default, despite it not being a development release. We
haven't bumped the version since the last release. I'll do that probably
tomorrow (about to head to bed) but what you could do in the future when
hitting such a problem is run:
./setup.py install release
There's nothing special about our django-evolution egg. I don't know why you
hit that issue, but it just sounds like there was some sort of installation
quirk. Any chance you upgraded your distro since installing that? Perhaps it
installed into an older Python.
What we should do is just have prepare-dev.py go ahead and install all
dependencies, or make sure they're installed. It would eliminate the need
for additions to the docs.
I have a fix for the '_' issue that I'll commit tomorrow along with some
other fixes. With the holidays and all, things have been a little busy
around here so I'm a bit behind on some of these issues in the alpha
releases, but will hopefully have time soon to implement the other fixes.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Mon, Dec 14, 2009 at 12:19 AM, Ryan Oblak rrob...@gmail.com wrote:
Yes, this is for the 1.1 development series. It's the HEAD from
github.
I tried running ./reviewboard/manage.py registerscmtools, but was
met with this error:
Unable to load SCMTool svn = reviewboard.scmtools.svn:SVNTool:
(Djblets 0.5.6.dev (/home/rroblak/workspace/djblets), Requirement.parse
('Djblets=0.5.6'))Unable to load SCMTool git =
reviewboard.scmtools.git:GitTool: (Djblets 0.5.6.dev (/home/rroblak/
workspace/djblets), Requirement.parse('Djblets=0.5.6'))Unable to load
SCMTool bzr = reviewboard.scmtools.bzr:BZRTool: (Djblets 0.5.6.dev (/
home/rroblak/workspace/djblets), Requirement.parse('Djblets=0.5.6'))
Unable to load SCMTool cvs = reviewboard.scmtools.cvs:CVSTool:
(Djblets 0.5.6.dev (/home/rroblak/workspace/djblets), Requirement.parse
('Djblets=0.5.6'))Unable to load SCMTool perforce =
reviewboard.scmtools.perforce:PerforceTool: (Djblets 0.5.6.dev (/home/
rroblak/workspace/djblets), Requirement.parse('Djblets=0.5.6'))Unable
to load SCMTool clearcase =
reviewboard.scmtools.clearcase:ClearCaseTool: (Djblets 0.5.6.dev (/
home/rroblak/workspace/djblets), Requirement.parse('Djblets=0.5.6'))
Unable to load SCMTool hg = reviewboard.scmtools.hg:HgTool: (Djblets
0.5.6.dev (/home/rroblak/workspace/djblets), Requirement.parse
('Djblets=0.5.6'))
I tracked this down to the version specified in djblets/Djblets.egg-
info/PKG-INFO. I changed the version in this file from 0.5.6.dev to
0.5.6 and this error went away. Seems like either the version should
be changed so it doesn't kill the Requirement parser, or the
Requirement parser should be changed so that it doesn't die on non-
numeric versions.
After changing the version to 0.5.6 in djblets/Djblets.egg-info/PKG-
INFO, I tried to run registerscmtools again, but was met with this
error:
Unable to load SCMTool svn = reviewboard.scmtools.svn:SVNTool: django-
evolutionUnable to load SCMTool git =
reviewboard.scmtools.git:GitTool: django-evolutionUnable to load
SCMTool bzr = reviewboard.scmtools.bzr:BZRTool: django-evolutionUnable
to load SCMTool cvs = reviewboard.scmtools.cvs:CVSTool: django-
evolutionUnable to load SCMTool perforce =
reviewboard.scmtools.perforce:PerforceTool: django-evolutionUnable to
load SCMTool clearcase = reviewboard.scmtools.clearcase:ClearCaseTool:
django-evolutionUnable to load SCMTool hg =
reviewboard.scmtools.hg:HgTool: django-evolution
To fix this I uninstalled my previous django-evolution installation
(installed via SVN checkout as described here:
http://code.google.com/p/django-evolution/)
and reinstalled using your egg (easy_install -f http://
downloads.review-board.org/mirror/ django_evolution). I'm not sure
why my SVN installation didn't work. When I uninstalled the SVN
installation completely I was given a terse 'django-evolution not
found' error, so it seems as though the django-evolution package was
installed in some capacity, though somehow incorrectly. At any rate,
you may want to make a note of the django-evolution dependency in the
developer documentation (I realize it's already in the admin
documentation-- perhaps refactoring a separate 'dependencies' page
would be helpful?). Also, publicizing how to install your
django_evolution egg may be of help to some.
After getting django-evolution installed properly I was able to run
registerscmtools without a hitch. However, I am still getting a
global name '_' is not defined validation error on the Add
repository page. It appears that this error is being caught
upstream, as it is presented as a form validation error. Accordingly,
there is no associated stack trace (unless there is some method of
grabbing stack traces on form
Re: reviewboard api is missing
Hello Yes I am able to login to the UI with this username/password. I was able to create a group and a repository in the UI. What worries me is the error message: post-review --server=http://localhost/rb Unable to access http://localhost/rb/api/json/accounts/login/. The host path may be invalid HTTP Error 403: Forbidden Any other ideas? Victor On Tue, Dec 15, 2009 at 6:44 PM, Christian Hammond chip...@chipx86.comwrote: Hi, The api/json isn't an actual directory in the installation. All paths within Review Board are handled internally to Review Board. It's possible that the username/password you used is wrong. Can you log in with that user using the web UI? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Dec 15, 2009 at 6:17 AM, victor z vzac...@gmail.com wrote: Hello, I am trying to setup reviewboard on a windows/mysql/apache/perforce machine. I have the web UI working, but I am having problems with post-review. It seems like the reviewboard api is missing from my installation... Post-review -d gives: Z:\post-review -d p4 info repository info: Path: mdc-sc-perf01.ubisoft.org:2386, Base path: None, Supp orts changesets: True p4 counters Unable to find a Review Board server for this source code tree. If I try to set a server and I then get: Z:\post-review --server=http://localhost/rb == Review Board Login Required Enter username and password for Review Board at http://localhost/rb/ Username: vzachev Password: Unable to access http://localhost/rb/api/json/accounts/login/. The host path may be invalid HTTP Error 403: Forbidden I do not see any api/json in my apache install Thank you -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Installation problem
This did the trick: yum install python-imaging On Dec 15, 4:44 pm, Dregel dre...@gmail.com wrote: Looks like the installation of PIL did fail. I'll start there then. Cheers! Python 2.4.3 (#1, Sep 3 2009, 15:37:37) ... import PIL Traceback (most recent call last): File stdin, line 1, in ? Easy_install, yeah right... On Dec 15, 1:17 am, Christian Hammond chip...@chipx86.com wrote: From a python prompt, type: import PIL If that fails, then PIL is not installed on the system. If it does work, then we need to investigate why your Python isn't seeing it. I assume you've done a web server restart since installing Review Board? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Dec 14, 2009 at 4:03 PM, nshenry03 nshenr...@gmail.com wrote: I am getting the same issue: r...@scubuntuvm1:~# python --version Python 2.5.2 r...@scubuntuvm1:~# lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 8.04.3 LTS Release: 8.04 Codename: hardy r...@scubuntuvm1:~# uname -r 2.6.24-23-generic On Dec 14, 2:26 pm, Christian Hammond chip...@chipx86.com wrote: Hi, The manual updates page is old and generally isn't seen anymore. We'll need to update the text to reference rb-site instead of manage.py. The error definitely seems to be that PIL isn't installed correctly. Yes, easy_install should get it, but perhaps something went wrong. What version of Python is being used on the system? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Dec 14, 2009 at 12:07 PM, Dregel dre...@gmail.com wrote: Hi, After following the installation guide, I got RB kind of working on centos but when I go to default page I get the message: Manual server updates required The suggestion is to run manage.py. After some investigation I found someone that recommended a rb-site upgrade instead and that command reveals a problem: []# rb-site -d upgrade /var/www/reviewboard Rebuilding directory structure Updating database. This may take a while. Error: One or more models did not validate: reviews.screenshot: image: To use ImageFields, you need to install the Python Imaging Library. Get it at http://www.pythonware.com/products/pil/ . What gives? I thought PIL was correctly installed when running easy_install but it's not working. Any suggestions? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com reviewboard%2bunsubscr...@googlegroups.comreviewboard%252bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Cant connect to SVN repository using RB 1.1 alpa 2
Hi, I hit the same error today. Did you ever solve this? On Nov 27, 6:25 am, pk pankaj.khar...@gmail.com wrote: Hi Christian, Is this hosted on a Windows or Linux install? - Its hosted on a Ubuntu m/c. What happens if you check out that repo on the same box? Therepositoryis on a remote m/c which is accessed over VPN, I dont wont to have a local copy of therepository! Did it ever prompt you for confirmation on the host key? Yes, it did I accepted the confirmation but after that it lead to Error : Arepositorywasnotfoundat thespecifiedpath. I'm able to connect to the samerepositoryto the samepath thr' the command prompt/terminal Also, the reviewboard logs i have configured for Allow code profiling option but there are no logs for the failure, I do see logs for the successful authentication I'm stuck now, we have a couple project repositories which we wanted to use the tool with most of them use SVN i.e. svn+ssh access !! Appreciate your help in advance !! - Pankaj -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re:Re: About Error occured when print view diff on User WebUI of ReviewBoard
Hi, Christian,
Now that is the different diff file contents of the same file change:
On Windows:
WWW
Index: abc.c
===
RCS file: /export/home/cvsroot/test/abc.c,v
retrieving revision 1.1
diff -u -r1.1 abc.c
--- abc.c2009/12/17 02:37:241.1
+++ abc.c2009/12/17 02:43:08
@@ -2,6 +2,7 @@
#include stdlib.h
int main()
{
+printf(Begin, Begin!);
print(Hello World!);
if(a==5)
{
@@ -11,4 +12,5 @@
{
printf(Hi,sir!);
}
+printf(Hello, Sir!);
}
And on Linux:
L
Index: abc.c
===
RCS file: /export/home/cvsroot/test/abc.c,v
retrieving revision 1.1
diff -u -r1.1 abc.c
--- abc.c2009/12/17 02:37:241.1
+++ abc.c2009/12/17 02:50:30
@@ -2,6 +2,7 @@
#include stdlib.h
int main()
{
+printf(Begin, Begin!);
print(Hello World!);
if(a==5)
{
@@ -11,4 +12,5 @@
{
printf(Hi,sir!);
}
-}
\ No newline at end of file
+printf(Hello, Sir!);
+}
LL
There is no much difference. But the linux diff file ends with a warning: \
No newline at end of file and the end Brace} has been viewed as a change: +
and -; This kind of format diff file works well, The Reviewer can open the
view diff correctly. But the windows diff file format, which gave no warning
and view the last brace as unchanged, with this format, The Reviewers clicking
view diff will report error as in the first message of this topic I have
pointed. And infect I have never add any new-line to the end of the source code
file: neither the original file, nore the chenged files in both Operating
System.
And If I had manualy add a blank new line in the changed file in Windows
local source code file, I will get the same diff file content as that of linux
said above, And that may slove this problem. But I don't know why. and How to
fundamentally solve the problem?
Best Regards!
在2009-12-16，Christian Hammond chip...@chipx86.com 写道：
I don't really know what you mean, but I know that many companies using Review
Board have clients on Linux, Windows and Mac who post to a Review Board server
on Linux without any problems. I'd have to see some diffs and original source
files where this fails to have an idea as to what's going wrong.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Tue, Dec 15, 2009 at 7:55 PM, JohnHenry qhlonl...@163.com wrote:
I have viewed the diff file of both Windows and Linux, It seems that
not only they have difference between there NewLine character, There
are some file format difference but I am not sure, Can any one give a
description of there difference?
Best Regards!
On Dec 15, 4:09 pm, JohnHenry qhlonl...@163.com wrote:
OK, The first problem is that I have Created new ReviewRequest in
WindowsOS through Web UI while the RB Server is on Linux. When I use
post-review in linux to create new ReviewRequest , That will be fine.
But I had not test the windowsOS post-review generated new
ReviewRequest now.
But the second problem, How to make Review to the review request
generated with newly source code( that is the source code has never
been commited to CVS ) is waiting for suggestion.
Best Regards!
On 12月15日, 下午3时36分, JohnHenry qhlonl...@163.com wrote:
Hi,
I have tried to post a review request and publish it using one
User, But in the Reviewers' UI, when He cilck the view diff link on
the top-right, There will be some error infomation:
**
The patch to 'mySouceTest.c' didn't apply cleanly. The temporary files
have been left in '/tmp/reviewboard.zX0n4M' for debugging purposes.
`patch` returned: patching file /tmp/reviewboard.zX0n4M/tmphNZpB0
patch: malformed patch at line 25: - exit(1);
Traceback (most recent call last):
File /data1/John1/bin/develop_tools/python/python2.5/lib/python2.5/
site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/
views.py, line 153, in view_diff
interdiffset, highlighting, True)
File /data1/John1/bin/develop_tools/python/python2.5/lib/python2.5/
site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/
diffutils.py, line 623, in get_diff_files
large_data=True)
File /data1/qiaohl/bin/develop_tools/python/python2.5/lib/python2.5/
site-packages/Djblets-0.5.6-py2.5.egg/djblets/util/misc.py, line 162,
in cache_memoize
data = lookup_callable()
File /data1/John1/bin/develop_tools/python/python2.5/lib/python2.5/
site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/
diffutils.py, line 622, in lambda
Re: Re: About Error occured when print view diff on User WebUI of ReviewBoard
What version of diff is on the Windows install? It must specifically use GNU
diff, and not some other diff tool.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Dec 16, 2009 at 7:27 PM, qhlonline qhlonl...@163.com wrote:
Hi, Christian,
Now that is the different diff file contents of the same file change:
On Windows:
WWW
Index: abc.c
===
RCS file: /export/home/cvsroot/test/abc.c,v
retrieving revision 1.1
diff -u -r1.1 abc.c
--- abc.c2009/12/17 02:37:241.1
+++ abc.c2009/12/17 02:43:08
@@ -2,6 +2,7 @@
#include stdlib.h
int main()
{
+printf(Begin, Begin!);
print(Hello World!);
if(a==5)
{
@@ -11,4 +12,5 @@
{
printf(Hi,sir!);
}
+printf(Hello, Sir!);
}
And on Linux:
L
Index: abc.c
===
RCS file: /export/home/cvsroot/test/abc.c,v
retrieving revision 1.1
diff -u -r1.1 abc.c
--- abc.c2009/12/17 02:37:241.1
+++ abc.c2009/12/17 02:50:30
@@ -2,6 +2,7 @@
#include stdlib.h
int main()
{
+printf(Begin, Begin!);
print(Hello World!);
if(a==5)
{
@@ -11,4 +12,5 @@
{
printf(Hi,sir!);
}
-}
\ No newline at end of file
+printf(Hello, Sir!);
+}
LL
There is no much difference. But the linux diff file ends with a warning:
\ No newline at end of file and the end Brace} has been viewed as a
change: + and -; This kind of format diff file works well, The Reviewer can
open the view diff correctly. But the windows diff file format, which gave
no warning and view the last brace as unchanged, with this format, The
Reviewers clicking view diff will report error as in the first message of
this topic I have pointed. And infect I have never add any new-line to the
end of the source code file: neither the original file, nore the chenged
files in both Operating System.
And If I had manualy add a blank new line in the changed file in Windows
local source code file, I will get the same diff file content as that of
linux said above, And that may slove this problem. But I don't know why. and
How to fundamentally solve the problem?
Best Regards!
在2009-12-16，Christian Hammond chip...@chipx86.com 写道：
I don't really know what you mean, but I know that many companies using
Review Board have clients on Linux, Windows and Mac who post to a Review
Board server on Linux without any problems. I'd have to see some diffs and
original source files where this fails to have an idea as to what's going
wrong.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Tue, Dec 15, 2009 at 7:55 PM, JohnHenry qhlonl...@163.com wrote:
I have viewed the diff file of both Windows and Linux, It seems that
not only they have difference between there NewLine character, There
are some file format difference but I am not sure, Can any one give a
description of there difference?
Best Regards!
On Dec 15, 4:09 pm, JohnHenry qhlonl...@163.com wrote:
OK, The first problem is that I have Created new ReviewRequest in
WindowsOS through Web UI while the RB Server is on Linux. When I use
post-review in linux to create new ReviewRequest , That will be fine.
But I had not test the windowsOS post-review generated new
ReviewRequest now.
But the second problem, How to make Review to the review request
generated with newly source code( that is the source code has never
been commited to CVS ) is waiting for suggestion.
Best Regards!
On 12月15日, 下午3时36分, JohnHenry qhlonl...@163.com wrote:
Hi,
I have tried to post a review request and publish it using one
User, But in the Reviewers' UI, when He cilck the view diff link on
the top-right, There will be some error infomation:
**
The patch to 'mySouceTest.c' didn't apply cleanly. The temporary files
have been left in '/tmp/reviewboard.zX0n4M' for debugging purposes.
`patch` returned: patching file /tmp/reviewboard.zX0n4M/tmphNZpB0
patch: malformed patch at line 25: - exit(1);
Traceback (most recent call last):
File /data1/John1/bin/develop_tools/python/python2.5/lib/python2.5/
site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/
views.py, line 153, in view_diff
interdiffset, highlighting, True)
File /data1/John1/bin/develop_tools/python/python2.5/lib/python2.5/
site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/
diffutils.py, line 623, in get_diff_files
Re:Re: Re: About Error occured when print view diff on User WebUI of ReviewBoard
I am using the TortoiseCVS as CVS client, I am not sure what kind of diff it
support, But my diff command is using as cvs diff -uN Can you please
recommand me some GNU-diff-supported CVS client run on Windows OS? Thanks.
Best Regards!
在2009-12-17，Christian Hammond chip...@chipx86.com 写道：
What version of diff is on the Windows install? It must specifically use GNU
diff, and not some other diff tool.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Dec 16, 2009 at 7:27 PM, qhlonline qhlonl...@163.com wrote:
Hi, Christian,
Now that is the different diff file contents of the same file change:
On Windows:
WWW
Index: abc.c
===
RCS file: /export/home/cvsroot/test/abc.c,v
retrieving revision 1.1
diff -u -r1.1 abc.c
--- abc.c2009/12/17 02:37:241.1
+++ abc.c2009/12/17 02:43:08
@@ -2,6 +2,7 @@
#include stdlib.h
int main()
{
+printf(Begin, Begin!);
print(Hello World!);
if(a==5)
{
@@ -11,4 +12,5 @@
{
printf(Hi,sir!);
}
+printf(Hello, Sir!);
}
And on Linux:
L
Index: abc.c
===
RCS file: /export/home/cvsroot/test/abc.c,v
retrieving revision 1.1
diff -u -r1.1 abc.c
--- abc.c2009/12/17 02:37:241.1
+++ abc.c2009/12/17 02:50:30
@@ -2,6 +2,7 @@
#include stdlib.h
int main()
{
+printf(Begin, Begin!);
print(Hello World!);
if(a==5)
{
@@ -11,4 +12,5 @@
{
printf(Hi,sir!);
}
-}
\ No newline at end of file
+printf(Hello, Sir!);
+}
LL
There is no much difference. But the linux diff file ends with a warning: \
No newline at end of file and the end Brace} has been viewed as a change: +
and -; This kind of format diff file works well, The Reviewer can open the
view diff correctly. But the windows diff file format, which gave no warning
and view the last brace as unchanged, with this format, The Reviewers clicking
view diff will report error as in the first message of this topic I have
pointed. And infect I have never add any new-line to the end of the source code
file: neither the original file, nore the chenged files in both Operating
System.
And If I had manualy add a blank new line in the changed file in Windows
local source code file, I will get the same diff file content as that of linux
said above, And that may slove this problem. But I don't know why. and How to
fundamentally solve the problem?
Best Regards!
在2009-12-16，Christian Hammond chip...@chipx86.com 写道：
I don't really know what you mean, but I know that many companies using Review
Board have clients on Linux, Windows and Mac who post to a Review Board server
on Linux without any problems. I'd have to see some diffs and original source
files where this fails to have an idea as to what's going wrong.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Tue, Dec 15, 2009 at 7:55 PM, JohnHenry qhlonl...@163.com wrote:
I have viewed the diff file of both Windows and Linux, It seems that
not only they have difference between there NewLine character, There
are some file format difference but I am not sure, Can any one give a
description of there difference?
Best Regards!
On Dec 15, 4:09 pm, JohnHenry qhlonl...@163.com wrote:
OK, The first problem is that I have Created new ReviewRequest in
WindowsOS through Web UI while the RB Server is on Linux. When I use
post-review in linux to create new ReviewRequest , That will be fine.
But I had not test the windowsOS post-review generated new
ReviewRequest now.
But the second problem, How to make Review to the review request
generated with newly source code( that is the source code has never
been commited to CVS ) is waiting for suggestion.
Best Regards!
On 12月15日, 下午3时36分, JohnHenry qhlonl...@163.com wrote:
Hi,
I have tried to post a review request and publish it using one
User, But in the Reviewers' UI, when He cilck the view diff link on
the top-right, There will be some error infomation:
**
The patch to 'mySouceTest.c' didn't apply cleanly. The temporary files
have been left in '/tmp/reviewboard.zX0n4M' for debugging purposes.
`patch` returned: patching file /tmp/reviewboard.zX0n4M/tmphNZpB0
patch: malformed patch at line 25: - exit(1);
Traceback (most recent call last):
File /data1/John1/bin/develop_tools/python/python2.5/lib/python2.5/
site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/
views.py, line 153, in view_diff
interdiffset,
About Post-Review User change problem
Hi， I used post-review to create review request. in the form as: post-review --username=A --password=Apassword --target-person=C myfile; But when I want to post reviewrequest as another user, like B, I type: post-review --username=B --password=Bpassword --target-person=C myfile; This time , When I logged in the WebUI to publish my reviewrequest. I found that actually post-review didn't create reviewrequest as user B ,But create as user A again! I think it is because my first using user A account has created a cookie for it, and the second using of post-review is not authenticate B user at all. It will be nothing for practical usage because each RB client may be using a permanent account, But as a tester, He may need to log in the same machine with different account. So I think it is a problem then. Best Regards! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Re: Re: About Error occured when print view diff on User WebUI of ReviewBoard
That's on the client, not the server, right?
What version of patch is on the server?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Dec 16, 2009 at 7:43 PM, qhlonline qhlonl...@163.com wrote:
I am using the TortoiseCVS as CVS client, I am not sure what kind of diff
it support, But my diff command is using as cvs diff -uN Can you
please recommand me some GNU-diff-supported CVS client run on Windows OS?
Thanks.
Best Regards!
在2009-12-17，Christian Hammond chip...@chipx86.com 写道：
What version of diff is on the Windows install? It must specifically use
GNU diff, and not some other diff tool.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Dec 16, 2009 at 7:27 PM, qhlonline qhlonl...@163.com wrote:
Hi, Christian,
Now that is the different diff file contents of the same file change:
On Windows:
WWW
Index: abc.c
===
RCS file: /export/home/cvsroot/test/abc.c,v
retrieving revision 1.1
diff -u -r1.1 abc.c
--- abc.c2009/12/17 02:37:241.1
+++ abc.c2009/12/17 02:43:08
@@ -2,6 +2,7 @@
#include stdlib.h
int main()
{
+printf(Begin, Begin!);
print(Hello World!);
if(a==5)
{
@@ -11,4 +12,5 @@
{
printf(Hi,sir!);
}
+printf(Hello, Sir!);
}
And on Linux:
L
Index: abc.c
===
RCS file: /export/home/cvsroot/test/abc.c,v
retrieving revision 1.1
diff -u -r1.1 abc.c
--- abc.c2009/12/17 02:37:241.1
+++ abc.c2009/12/17 02:50:30
@@ -2,6 +2,7 @@
#include stdlib.h
int main()
{
+printf(Begin, Begin!);
print(Hello World!);
if(a==5)
{
@@ -11,4 +12,5 @@
{
printf(Hi,sir!);
}
-}
\ No newline at end of file
+printf(Hello, Sir!);
+}
LL
There is no much difference. But the linux diff file ends with a warning:
\ No newline at end of file and the end Brace} has been viewed as a
change: + and -; This kind of format diff file works well, The Reviewer can
open the view diff correctly. But the windows diff file format, which gave
no warning and view the last brace as unchanged, with this format, The
Reviewers clicking view diff will report error as in the first message of
this topic I have pointed. And infect I have never add any new-line to the
end of the source code file: neither the original file, nore the chenged
files in both Operating System.
And If I had manualy add a blank new line in the changed file in
Windows local source code file, I will get the same diff file content as
that of linux said above, And that may slove this problem. But I don't know
why. and How to fundamentally solve the problem?
Best Regards!
在2009-12-16，Christian Hammond chip...@chipx86.com 写道：
I don't really know what you mean, but I know that many companies using
Review Board have clients on Linux, Windows and Mac who post to a Review
Board server on Linux without any problems. I'd have to see some diffs and
original source files where this fails to have an idea as to what's going
wrong.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Tue, Dec 15, 2009 at 7:55 PM, JohnHenry qhlonl...@163.com wrote:
I have viewed the diff file of both Windows and Linux, It seems that
not only they have difference between there NewLine character, There
are some file format difference but I am not sure, Can any one give a
description of there difference?
Best Regards!
On Dec 15, 4:09 pm, JohnHenry qhlonl...@163.com wrote:
OK, The first problem is that I have Created new ReviewRequest in
WindowsOS through Web UI while the RB Server is on Linux. When I use
post-review in linux to create new ReviewRequest , That will be fine.
But I had not test the windowsOS post-review generated new
ReviewRequest now.
But the second problem, How to make Review to the review request
generated with newly source code( that is the source code has never
been commited to CVS ) is waiting for suggestion.
Best Regards!
On 12月15日, 下午3时36分, JohnHenry qhlonl...@163.com wrote:
Hi,
I have tried to post a review request and publish it using one
User, But in the Reviewers' UI, when He cilck the view diff link on
the top-right, There will be some error infomation:
**
The patch to 'mySouceTest.c' didn't apply cleanly. The temporary
files
have been left in
Re: About Post-Review User change problem
Known bug. See http://code.google.com/p/reviewboard/issues/detail?id=762 Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com 2009/12/16 qhlonline qhlonl...@163.com Hi， I used post-review to create review request. in the form as: post-review --username=A --password=Apassword --target-person=C myfile; But when I want to post reviewrequest as another user, like B, I type: post-review --username=B --password=Bpassword --target-person=C myfile; This time , When I logged in the WebUI to publish my reviewrequest. I found that actually post-review didn't create reviewrequest as user B ,But create as user A again! I think it is because my first using user A account has created a cookie for it, and the second using of post-review is not authenticate B user at all. It will be nothing for practical usage because each RB client may be using a permanent account, But as a tester, He may need to log in the same machine with different account. So I think it is a problem then. Best Regards! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
