Re: Access is denied using post-review with ClearCase under Cygwin
Maybe someone want to know. Actually I not pretty sure which change
made that all start working. I just describe my configuration.
I use Vobs which location is somewhere in company's network on
clearcase servers. I use Python 2.5.4 and made my changes in C:
\Python25\Lib\site-packages\RBTools-0.2beta2-py2.5\postreview.py. One
tip. Default RBTools Python egg is compressed to zip file. But there
is switch in easy_install which may change that behaviour:
easy_install --always-unzip -U RBTools
So my post-review is straight python text file in standard folder.
Next I patch postreview.py using patch from this issue:
http://code.google.com/p/reviewboard/issues/detail?id=1423
After that I change my ClearCaseClient class. My ClearCaseClient class
now looks like:
ccroot_path = "Z:\SCM_tools"
viewinfo = ""
viewtype = "dynamic"
I'am not sure is this should be Z:\ or Z:/ but post-review generate
diff properly. Unfortunately I'am now in home and my VPN doesn't work
again :/ So I can't check anything else for 100%. I just try remember.
The first thing is that ccroot_path must be the same as Path field in
Repository form. This is something what I discover in my battles with
ClearCase on ReviewBoard. I ran post-review from cygwin like this:
post-review -d --server http://localhost/ file1 file2 file3
So Yes I must pass filenames as parameters. xargs is also good option
to automate this :) But I can't remember that I made this on checkin
files or checkedout files... But this is something what should be easy
to check. Option -n in post-review help me very much because I find
that confguration (checkin/checkout files) where all start working.
That is all what i remember.
On Jan 26, 2:12 pm, Jan Koprowski wrote:
> After use dynamic view and made changes in ClearCaseClient class in
> postreview I stop getting this problem.
>
> On Jan 25, 5:14 pm, Jan Koprowski wrote:
>
>
>
> > Hi!
>
> > On the beginning I want to say that ReviewBoard is great tool. The
> > best I have ever seen. Excellent job!
> > I'am trying to use ReviewBoard in ClearCase under Windows. I was
> > install whole stuff (ReviewBoard and RBTools) using easy_install under
> > Windows cmd. I made new snapshot etc... Then I installed cygwin (I
> > don't know is the order is correct) and run there:
>
> > $ post-review index.wsgi --server localhost
> > Traceback (most recent call last):
> > File "C:\Python25\Scripts\post-review-script.py", line 8, in
> >
> > load_entry_point('RBTools==0.2beta2', 'console_scripts', 'post-
> > review')()
> > File "C:\Python25\lib\site-packages\rbtools-0.2beta2-py2.5.egg
> > \rbtools\postreview.py", line 2520, in main
> > diff, parent_diff = tool.diff(args)
> > File "C:\Python25\lib\site-packages\rbtools-0.2beta2-py2.5.egg
> > \rbtools\postreview.py", line 951, in diff
> > return self.do_diff(self.get_extended_namespace(files))
> > File "C:\Python25\lib\site-packages\rbtools-0.2beta2-py2.5.egg
> > \rbtools\postreview.py", line 912, in get_extended_namespace
> > os.unlink(tf)
> > WindowsError: [Error 5] Access is denied: 'c:\\temp\
> > \62b637b6048cb59c9bf5e3ab0e37aa83'
>
> > I know only that c:\temp\62b637b6048cb59c9bf5e3ab0e37aa83 is read-only
> > and this is a problem but I don't know what fix environ to save this
> > normally. Any sugestions? After delete this file I get:
>
> > $ post-review index.wsgi --server localhost
> > Failed to execute command: ['cleartool', 'get', '-to', 'c:\\temp\
> > \81c147b7ee258f26c9cc2854623b769c', 'C:\\Snapshots\\jkoprows_view\
> > \SCM_tools\\scripts\\ReleaseRobot\\index.wsgi@@\\main\\3\n']
> > cleartool: Error: "C:\Snapshots\jkoprows_view\SCM_tools\scripts
> > \ReleaseRobot\index.wsgi@@\main\3" does not exist, or is not a
> > ClearCase version, or is a checked out version which was removed.
>
> > C:\\Snapshots\\jkoprows_view\\SCM_tools\\scripts\\ReleaseRobot\
> > \index.wsgi file is checkedin on 100% so I don't know why this is
> > wrong.
>
> > --
> > Greetings from Poland
> > Jan Koprowski
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Unified diff view
No, and it would take a lot of work to get the UI to render and operate in that way. If someone wanted to work on this as a sort of optional feature, then maybe we'd include it, but I don't suspect it will be easy. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Jan 27, 2010 at 10:46 PM, Brad wrote: > Is there a way to show diffs with an inline "unified diff" format > (something like "diff -u" spits out)? I'd like to do reviews on my > laptop and the side-by-side diffs don't always fit very well. Seems > like mapping line based review comments to either view shouldn't be > too difficult. > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Unified diff view
Is there a way to show diffs with an inline "unified diff" format (something like "diff -u" spits out)? I'd like to do reviews on my laptop and the side-by-side diffs don't always fit very well. Seems like mapping line based review comments to either view shouldn't be too difficult. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: ReviewBoard Error while posting review for GIT
I've tried to reproduce this in my version of post-review and I can't. Are you running a fully upstream version of RBTools now, or is it at all custom? Also, what version of Python are you running? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Jan 27, 2010 at 2:12 PM, Kunjal wrote: > Any pointers? > > On Jan 26, 9:55 am, Kunjal wrote: > > Here is my config looks like: > > > > [core] > > repositoryformatversion = 0 > > filemode = true > > bare = false > > logallrefupdates = true > > [remote "origin"] > > url = git:// > mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git > > fetch = +refs/heads/*:refs/remotes/origin/* > > [branch "donut"] > > remote = origin > > merge = refs/heads/donut > > [reviewboard] > > url =http://mob-rb-test.sj.broadcom.com > > > > I also try alternative config as: > > > > [core] > > repositoryformatversion = 0 > > filemode = true > > bare = false > > logallrefupdates = true > > [remote "origin"] > > url = git:// > mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git > > fetch = +refs/heads/*:refs/remotes/origin/* > > [branch "donut"] > > remote = origin > > merge = refs/heads/donut > > > > But same result. > > > > On Jan 25, 5:27 pm, Christian Hammond wrote: > > > > > > > > > Hmm, that doesn't look good. What does the Git config look like? > > > > > Christian > > > > > -- > > > Christian Hammond - chip...@chipx86.com > > > Review Board -http://www.reviewboard.org > > > VMware, Inc. -http://www.vmware.com > > > > > On Mon, Jan 25, 2010 at 11:07 AM, Kunjal > wrote: > > > > Hello, > > > > > > When I post-review for GIT, I am getting below error. > > > > > > somehow the host path is listing ReviewBoard URL two times as you can > > > > see below. > > > > How to fix this? > > > > > > Unable to access > > > > > http://mob-rb-test.sj.broadcom.com/mob-rb-test.sj.broadcom.com/api/js... > > > > . > > > > The host path may be invalid > > > > HTTP Error 404: Not Found > > > > > > -- > > > > Want to help the Review Board project? Donate today at > > > >http://www.reviewboard.org/donate/ > > > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > > > -~--~~~~--~~--~--~--- > > > > To unsubscribe from this group, send email to > > > > reviewboard+unsubscr...@googlegroups.com > > > > > For more options, visit this group at > > > >http://groups.google.com/group/reviewboard?hl=en-Hide quoted text - > > > > > - Show quoted text -- Hide quoted text - > > > > - Show quoted text - > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: ReviewBoard Error while posting review for GIT
On Tuesday 26 January 2010 18:55:20 Kunjal wrote: > Here is my config looks like: > > [core] > repositoryformatversion = 0 > filemode = true > bare = false > logallrefupdates = true > [remote "origin"] > url = > git://mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git fetch = > +refs/heads/*:refs/remotes/origin/* > [branch "donut"] > remote = origin > merge = refs/heads/donut > [reviewboard] > url = http://mob-rb-test.sj.broadcom.com What happens when you manually specify the RB server URL on the post-review command line? Regards, Thilo -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: ReviewBoard Error while posting review for GIT
Any pointers? On Jan 26, 9:55 am, Kunjal wrote: > Here is my config looks like: > > [core] > repositoryformatversion = 0 > filemode = true > bare = false > logallrefupdates = true > [remote "origin"] > url = > git://mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git > fetch = +refs/heads/*:refs/remotes/origin/* > [branch "donut"] > remote = origin > merge = refs/heads/donut > [reviewboard] > url =http://mob-rb-test.sj.broadcom.com > > I also try alternative config as: > > [core] > repositoryformatversion = 0 > filemode = true > bare = false > logallrefupdates = true > [remote "origin"] > url = > git://mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git > fetch = +refs/heads/*:refs/remotes/origin/* > [branch "donut"] > remote = origin > merge = refs/heads/donut > > But same result. > > On Jan 25, 5:27 pm, Christian Hammond wrote: > > > > > Hmm, that doesn't look good. What does the Git config look like? > > > Christian > > > -- > > Christian Hammond - chip...@chipx86.com > > Review Board -http://www.reviewboard.org > > VMware, Inc. -http://www.vmware.com > > > On Mon, Jan 25, 2010 at 11:07 AM, Kunjal wrote: > > > Hello, > > > > When I post-review for GIT, I am getting below error. > > > > somehow the host path is listing ReviewBoard URL two times as you can > > > see below. > > > How to fix this? > > > > Unable to access > > >http://mob-rb-test.sj.broadcom.com/mob-rb-test.sj.broadcom.com/api/js... > > > . > > > The host path may be invalid > > > HTTP Error 404: Not Found > > > > -- > > > Want to help the Review Board project? Donate today at > > >http://www.reviewboard.org/donate/ > > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > > -~--~~~~--~~--~--~--- > > > To unsubscribe from this group, send email to > > > reviewboard+unsubscr...@googlegroups.com > > > For more options, visit this group at > > >http://groups.google.com/group/reviewboard?hl=en-Hide quoted text - > > > - Show quoted text -- Hide quoted text - > > - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Upgrading pygments
Hi Mark, It should be possible to simply upgrade Pygments. If it fails, it's easy to revert back to a stable version. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Jan 27, 2010 at 5:52 AM, Bickford, Mark < mark_bickf...@wrightexpress.com> wrote: > Hi, > > We are currently running RB 1.0.5.1. Is it possible to just upgrade > Pygments within it, to their 1.2.2 release, or will that break RB? They’ve > added some new language highlighting within it that we’d like to have > access to. > > Thanks, > Mark > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Upgrading pygments
If the pygments interface hasn't changed (and I doubt it has), it should be fine. -David On Wed, Jan 27, 2010 at 5:52 AM, Bickford, Mark wrote: > Hi, > > We are currently running RB 1.0.5.1. Is it possible to just upgrade > Pygments within it, to their 1.2.2 release, or will that break RB? They’ve > added some new language highlighting within it that we’d like to have access > to. > > Thanks, > Mark > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Upgrading pygments
Hi, We are currently running RB 1.0.5.1. Is it possible to just upgrade Pygments within it, to their 1.2.2 release, or will that break RB? They've added some new language highlighting within it that we'd like to have access to. Thanks, Mark -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: RB Security Concern
Thanks. I have configured RB with HTTPS now. On Jan 26, 11:28 am, Christian Hammond wrote: > You can put the entire site on HTTPS if you want. Review Board doesn't limit > you to HTTP or HTTPS. Set the correct URL in your admin settings, and if > necessary set up Apache to redirect automatically to the HTTPS URL. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > On Tue, Jan 26, 2010 at 9:56 AM, Kunjal wrote: > > Hello, > > > We have enabled RB with Active Directory. > > > I can see that ReviewBoard uses http to login, and not https. I am no > > expert in these matters, but according to my old knowledge this means > > that the username and password is being sent in clear text on Broadcom > > intranet. > > > This seems a bit unsafe to me, especially considering that we now use > > windows passwords. > > > Is this how RB works? Is there a work around? > > > Kunjal > > > -- > > Want to help the Review Board project? Donate today at > >http://www.reviewboard.org/donate/ > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > -~--~~~~--~~--~--~--- > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group at > >http://groups.google.com/group/reviewboard?hl=en- Hide quoted text - > > - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
