Designer Workflow: Review's For Graphic Assets
I've seen ReviewBoard's support for images and started thinking about how hard it would be to expand upon this. Designers have a similar need as developers except their sources are images and not text files. As far as I can tell, this would have the following impact, + images alone create a diff + image revisions must be managed + comments on an image create a new revision For background, have a skim over Adobe's solution to this (supports video also) http://tinyurl.com/AdobeCSReview Any thoughts or ideas on the topic? For those on the list familiar with the code base, what are the hard parts to implement this? Thanks! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Unable to upload screenshots
I somehow missed your reply until now. I'm currently at Review Board 1.0.8, with Djblets at 0.6.2. I tried it again and found that I am now able to upload GIF files -- though the first one I tried uploading failed. PNG and JPG still fail with the same The file you uploaded was either not an image or a corrupted image. message. Great feature, BTW! It is going to be really helpful to allow people to comment on images. Any additional things I can look at to try to figure out why it is still not completely working? Thanks, David On Fri, Feb 26, 2010 at 10:05 PM, Christian Hammond chip...@chipx86.comwrote: What version of Djblets is on there? I believe this may now be fixed as of 0.5.6. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Jan 26, 2010 at 12:55 PM, David Resnick abune...@gmail.comwrote: No, I'm still stuck with this. -David On Tue, Jan 26, 2010 at 6:33 PM, Thilo-Alexander Ginkel th...@ginkel.com wrote: On Thu, Jan 7, 2010 at 08:34, David Resnick abune...@gmail.com wrote: Well, loading the image in PIL from the command line works. I am facing the same issue. Command line image loading works, but uploading through the RB UI fails: $ python Python 2.6 (r26:66714, Feb 21 2009, 02:16:04) [GCC 4.3.2 [gcc-4_3-branch revision 141291]] on linux2 Type help, copyright, credits or license for more information. from PIL import Image Image.open(screenshot.png) PIL.PngImagePlugin.PngImageFile instance at 0x7f1ee8babdd0 Have you been able to figure out what was wrong in your case? Unfortunately, I cannot add any further details as Review Board only intermittently writes to its log file (the last time on Jan 16th - nothing has been changed since then). Regards, Thilo -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: remote Mercurial repo support?
On Sat, Jun 26, 2010 at 09:17:48PM -0700, Christian Hammond wrote: Not bitter at all! ;) Sadly, this is what happens when $DAYJOB and real life get in the way for a little while. I'll be doing a new RBTools release with those fixes very soon. Objectively Awesome! I can relate wrt ye olde $DAYJOB. I speak for my coworkers when I say that the many hours you've sunk into ReviewBoard and RBTools are very much appreciated. Cheers and thanks again, -- ~Dan Christian On Saturday, June 26, 2010, Dan Buch daniel.b...@gmail.com wrote: On Fri, Jun 25, 2010 at 09:41:02AM -0700, Gordon Morehouse wrote: On Jun 24, 9:12 pm, Dan Buch daniel.b...@gmail.com wrote: IIRC there's some naive logic in the remote Mercurial repo client inside Reviewboard that screws up the number/presence of some '/' chars. I think a recently accepted patch fixed the logic, but you can get it working with older versions of ReviewBoard by doing something like this: for the Path value: http://example.com/hgweb/AwesomeTown for the Mirror path value: http://example.com/hgweb/AwesomeTown/ And yes, it really is the trailing slash. No, this is not 1994. ...Unbelievable. Banging my head for days over a single slash (and no documentation of the issue anywhere). Thank goodness there's a patch in. I've submitted a documentation bug about this: http://code.google.com/p/reviewboard/issues/detail?id=1699 My prior solution had been to mount the repo itself from our repo server via sshfs, but after putting the HTTPS URL back in minus the trailing slash it still worked. Thanks for that, because an automounted sshfs was not exactly the greatest 'solution.' If you haven't already tried, I can warn you that the current public release of RBTools doesn't *actually* support plain ol' Mercurial usage, although it *does* have good support for hgsubversion. Another recently-accepted patch fixes this (for the most part,) and a dist which includes it is available here: http://github.com/meatballhat/rbtools/downloads Thanks! I will investigate that. Any idea if it will be accepted upstream? It has! It *only* took 3 months! ;-) http://reviews.reviewboard.org/r/1464/ I'm not bitter. I swear. When it will actually ship with canonical RBTools? not sure... chipx86 or trowbrds willing to weigh in? :) -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- ~Dan -- -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en pgp2JCf1X6JRU.pgp Description: PGP signature
Re: Connection close when uploading diff file
Hi Christian,
Path: svn+ssh://x.x.x.x/var/svn/repos/
Mirror path has nothing for it.
Jianwei
On Jun 27, 6:43 am, Christian Hammond chip...@chipx86.com wrote:
While that may be unrelated, it's certainly a problem by itself. Did you at
any point attempt to edit the SiteConfiguration table in the database
browser in the admin UI?
Can you show me what you're using for Path and Mirror Path for your
repository?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Thu, Jun 24, 2010 at 4:30 PM, jianwei majesty...@hotmail.com wrote:
Hi Christian,
Thank you for your reply.
I am using subversion for my repos.
My log looks like this, some settings are not pasted to here.
Also, the upload_temp_dir is NONE, is it this causes the problem? But
I can upload img file.
2010-06-24 14:50:26,611 - DEBUG - DiffParser.parse: Beginning parse of
diff, size = 3670
2010-06-24 14:50:26,612 - DEBUG - DiffParser.parse: Finished parsing
diff.
2010-06-24 14:50:30,448 - WARNING - JSONField decode error. Expected
dictionary, got string for input '{
u'cache_backend': u'file:///tmp/reviewboard_cache',
u'site_upload_temp_dir': None,
u'diffviewer_context_num_lines': 5,
u'diffviewer_paginate_orphans': 10,
u'site_upload_max_memory_size': 2621440,
u'cache_expiration_time': 2592000,
u'diffviewer_include_space_patterns': [],
u'diffviewer_paginate_by': 20,
u'diffviewer_syntax_highlighting': True,
u'site_media_url': u'/media/',
Looking forward to everyone's response. Thank you
Jianwei
On Jun 24, 5:09 pm, Christian Hammond chip...@chipx86.com wrote:
Hi,
This may be due to some issue between Review Board and your repository.
What
type of repository are you using?
Can you turn on logging in the administration UI (Admin - Settings -
Logging), reproduce the problem, and then see if there's anything in the
log
files?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Wed, Jun 23, 2010 at 9:29 PM, jianwei majesty...@hotmail.com wrote:
Hi all,
The problem is I got connection closed unexpectedly when I try to
upload a diff file.
After searching for the solutions to this problems for a few days
and I still can not solve this problem except knowing there are some
problems of the server site. Can somebody please help me to fix this
problem? eg: what can I do on the server side?
At the moment, I can use eReviewboard plugin to create a new
request from eclipse and I am able to upload image. Version of
reviewboard is 1.0.8.
Regards
Jianwei
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
reviewboard%2bunsubscr...@googlegroups.comreviewboard%252bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Connection close when uploading diff file
That'd be it. Review Board 1.0.x doesn't support ssh-backed repositories.
You'll need the 1.5 betas for that.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Sun, Jun 27, 2010 at 4:06 PM, jianwei majesty...@hotmail.com wrote:
Hi Christian,
Path: svn+ssh://x.x.x.x/var/svn/repos/
Mirror path has nothing for it.
Jianwei
On Jun 27, 6:43 am, Christian Hammond chip...@chipx86.com wrote:
While that may be unrelated, it's certainly a problem by itself. Did you
at
any point attempt to edit the SiteConfiguration table in the database
browser in the admin UI?
Can you show me what you're using for Path and Mirror Path for your
repository?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Thu, Jun 24, 2010 at 4:30 PM, jianwei majesty...@hotmail.com wrote:
Hi Christian,
Thank you for your reply.
I am using subversion for my repos.
My log looks like this, some settings are not pasted to here.
Also, the upload_temp_dir is NONE, is it this causes the problem? But
I can upload img file.
2010-06-24 14:50:26,611 - DEBUG - DiffParser.parse: Beginning parse of
diff, size = 3670
2010-06-24 14:50:26,612 - DEBUG - DiffParser.parse: Finished parsing
diff.
2010-06-24 14:50:30,448 - WARNING - JSONField decode error. Expected
dictionary, got string for input '{
u'cache_backend': u'file:///tmp/reviewboard_cache',
u'site_upload_temp_dir': None,
u'diffviewer_context_num_lines': 5,
u'diffviewer_paginate_orphans': 10,
u'site_upload_max_memory_size': 2621440,
u'cache_expiration_time': 2592000,
u'diffviewer_include_space_patterns': [],
u'diffviewer_paginate_by': 20,
u'diffviewer_syntax_highlighting': True,
u'site_media_url': u'/media/',
Looking forward to everyone's response. Thank you
Jianwei
On Jun 24, 5:09 pm, Christian Hammond chip...@chipx86.com wrote:
Hi,
This may be due to some issue between Review Board and your
repository.
What
type of repository are you using?
Can you turn on logging in the administration UI (Admin - Settings
-
Logging), reproduce the problem, and then see if there's anything in
the
log
files?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Wed, Jun 23, 2010 at 9:29 PM, jianwei majesty...@hotmail.com
wrote:
Hi all,
The problem is I got connection closed unexpectedly when I try
to
upload a diff file.
After searching for the solutions to this problems for a few
days
and I still can not solve this problem except knowing there are
some
problems of the server site. Can somebody please help me to fix
this
problem? eg: what can I do on the server side?
At the moment, I can use eReviewboard plugin to create a new
request from eclipse and I am able to upload image. Version of
reviewboard is 1.0.8.
Regards
Jianwei
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
reviewboard%2bunsubscr...@googlegroups.comreviewboard%252bunsubscr...@googlegroups.com
reviewboard%2bunsubscr...@googlegroups.comreviewboard%252bunsubscr...@googlegroups.com
reviewboard%252bunsubscr...@googlegroups.comreviewboard%25252bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
reviewboard%2bunsubscr...@googlegroups.comreviewboard%252bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Re: Issue 1683 in reviewboard: PendingDeprecationWarning while rbsite install
Updates: Status: Fixed Owner: chipx86 Comment #3 on issue 1683 by chipx86: PendingDeprecationWarning while rbsite install http://code.google.com/p/reviewboard/issues/detail?id=1683 Changed rb-site to silence this warning. Fixed on master (revision 3028465). -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1571 in reviewboard: Diff-Upload UI: Base Path field too narrow
Updates: Labels: -Milestone-Release1.5 Milestone-Release1.5.x Comment #4 on issue 1571 by chipx86: Diff-Upload UI: Base Path field too narrow http://code.google.com/p/reviewboard/issues/detail?id=1571 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 676 in reviewboard: Document how to raise the mysql packet size
Updates: Labels: -Milestone-Release1.5 Milestone-Release1.5.x Comment #10 on issue 676 by chipx86: Document how to raise the mysql packet size http://code.google.com/p/reviewboard/issues/detail?id=676 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 394 in reviewboard: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it
Comment #16 on issue 394 by chipx86: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it http://code.google.com/p/reviewboard/issues/detail?id=394 Actually, that won't be good enough. We really do need the full file path. cvs really should be showing the full path information. The fact that it's not is bad, and we need to investigate how long this has been happening and figure out if there's a fix for it. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 394 in reviewboard: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it
Updates: Owner: chipx86 Labels: -Component-SCMTools Component-DiffViewer Component-DiffParser Comment #17 on issue 394 by chipx86: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it http://code.google.com/p/reviewboard/issues/detail?id=394 Been poking at this. Since the problem is that the RCS File line doesn't contain any information on which module the file is in, we may have to post-process the diff in post-review. Another option is to finally give Review Board a concept of deleted files, but that's potentially a larger change. This appears to be a conscious choice on behalf of cvs: /* This is fullname, not file, possibly despite the POSIX.2 * specification, because that's the way all the Larry Wall * implementations of patch (are there other implementations?) want * things and the POSIX.2 spec appears to leave room for this. */ -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1587 in reviewboard: Some lines don't word-wrap correctly on IE/Chrome
Updates: Status: ThirdParty Comment #10 on issue 1587 by chipx86: Some lines don't word-wrap correctly on IE/Chrome http://code.google.com/p/reviewboard/issues/detail?id=1587 Closing as third-party, since there's nothing sane we can do about this. It depends on the browser and on the characters used on the lines. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1066 in reviewboard: Show file status in diff (added, modified, deleted, renamed)
Comment #7 on issue 1066 by chipx86: Show file status in diff (added, modified, deleted, renamed) http://code.google.com/p/reviewboard/issues/detail?id=1066 The deleted part of this is up for review at http://reviews.reviewboard.org/r/1685/. This part should end up in 1.5. The rest will wait until 1.6 or later. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 394 in reviewboard: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it
Updates: Status: PendingReview Comment #18 on issue 394 by chipx86: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it http://code.google.com/p/reviewboard/issues/detail?id=394 That wasn't too bad.. I have a patch up for review at http://reviews.reviewboard.org/r/1685/ -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1536 in reviewboard: Enabling Active Directory causes complete lockout (even local superuser cannot log back in)
Comment #4 on issue 1536 by sierragolfoneniner: Enabling Active Directory causes complete lockout (even local superuser cannot log back in) http://code.google.com/p/reviewboard/issues/detail?id=1536 I even tried several times to make up admin users with random strings as their names (e.g. djfskhkfshfsd) so unless AD has some sort of wildcard capability or I was really (un)lucky there's no way the users could have existed. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1536 in reviewboard: Enabling Active Directory causes complete lockout (even local superuser cannot log back in)
Comment #5 on issue 1536 by chipx86: Enabling Active Directory causes complete lockout (even local superuser cannot log back in) http://code.google.com/p/reviewboard/issues/detail?id=1536 Can you try something on your end? You'd need to either modify your installed copy (when nobody's using it, if possible) or have a test dev environment to play with. Edit reviewboard/accounts/backends.py. Find the 'authenticate' function in 'ActiveDirectoryBackend'. Look for the line that says 'user_data = self.search_ad(..)'. Right after that, add: if not user_data: return None Then restart your web server and try again. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
