The width of Files being diff'd is too wide in the IE browser sometime.

2010-07-23 Thread Lan Cheng
Hi guys, Do you come into this kind of issues when using Reviewboard? When I view diffs in the IE browser, the vertical bar between old version and new version is not in the middle of my screen and I have to move the horizontal scroll bar of the browser to see the whole lines in the new versions.

Re: The width of Files being diff'd is too wide in the IE browser sometime.

2010-07-23 Thread Lan Cheng
Thanks David. But generally there must be some space or punctuations, like . , or -, or . in a line of code. And how do you deal with this issue? You know moving scroll bar back and forth is not convenient for reviewing code. On Jul 23, 3:33 pm, David Trowbridge trowb...@gmail.com wrote:

Re: The width of Files being diff'd is too wide in the IE browser sometime.

2010-07-23 Thread Lan Cheng
Thanks David. You're right. I checked reviewboard diff behaviour in the Firefox and the Firefox breaks lines according to spaces and comma. But how do you deal with the situation when a line of code is long and no spaces and commas in it? We have some long attribut names in our code and usually

Re: The width of Files being diff'd is too wide in the IE browser sometime.

2010-07-23 Thread Christian Hammond
We don't do anything about this. Realistically, in order to fix it, we'd have to do text processing on each outputted line and insert extra tags to tell the browser it can break there. This would greatly increase the size of the page and reduce the diff generation and load times. So we don't do

Re: The width of Files being diff'd is too wide in the IE browser sometime.

2010-07-23 Thread loc
Not necessarily a good answer, but this is why our coding standard is limiting the line width to XX characters. Modern computers can easily display more than 80 characters, but when you want to view side by side diffs, it's good to have some limit. And this is not specific to ReviewBoard.

Re: Issue 1444 in reviewboard: DLL load failed on trying to create SVN repository

2010-07-23 Thread reviewboard
Comment #6 on issue 1444 by ruslan.tarasov: DLL load failed on trying to create SVN repository http://code.google.com/p/reviewboard/issues/detail?id=1444 I have found the reason of the problem. Looks like libapr-1.dll library coming with some Apache server versions conflicts with the one

Re: Issue 1444 in reviewboard: DLL load failed on trying to create SVN repository

2010-07-23 Thread reviewboard
Comment #7 on issue 1444 by ruslan.tarasov: DLL load failed on trying to create SVN repository http://code.google.com/p/reviewboard/issues/detail?id=1444 You can still use Review Board in standalone mode if you do not want to find compatible versions of Apache server and pysvn. Use the