Accessing different repo types from post-review

2010-09-21 Thread Jay
I have post-review installed on windows and have successfully been
creating RB requests against perforce.  We also have SVN projects, but
when I try to use post-review against them it wants to talk to
perforce instead.  For instance if I enter:

post-review --server=http://somehost/reviewboard --repository-
url=https://some-svn-repo-url  --revision-range=0:999 --debug

I see:

 hg root
 p4 info
 repository info: Path: sdgperforce:1666, Base path: None, Supports 
 changesets: True

So how do I get post-review to speak svn instead of perforce for a
given request?  The reviewboard instance is aware of the svn
repositories and others that only post against svn don't seem to have
a problem.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Accessing different repo types from post-review

2010-09-21 Thread Chris Clark

Jay wrote:

I have post-review installed on windows and have successfully been
creating RB requests against perforce.  We also have SVN projects, but
when I try to use post-review against them it wants to talk to
perforce instead.  For instance if I enter:

post-review --server=http://somehost/reviewboard --repository-
url=https://some-svn-repo-url  --revision-range=0:999 --debug

I see:

  

hg root
p4 info
repository info: Path: sdgperforce:1666, Base path: None, Supports changesets: 
True



So how do I get post-review to speak svn instead of perforce for a
given request?  The reviewboard instance is aware of the svn
repositories and others that only post against svn don't seem to have
a problem.
  


It looks like p4 is claiming there is a perforce repo in the svn 
location. A quick hack/test would be to modify postreview to check svn 
first. I.e. hack the SCMCLIENTS def.


Chris

--
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Accessing different repo types from post-review

2010-09-21 Thread Jay
On Sep 21, 12:11 pm, Chris Clark chris.cl...@ingres.com wrote:

 It looks like p4 is claiming there is a perforce repo in the svn
 location. A quick hack/test would be to modify postreview to check svn
 first. I.e. hack the SCMCLIENTS def.

And where would the SCMCLIENTS.def be located?  Is this on the client?
I can't seem to find any config files for post-review apart from
a .post-review-cookie file in Local Settings/Application Data...

...Jay

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Accessing different repo types from post-review

2010-09-21 Thread Jan Koprowski
in file postreview.py somewhere in
/usr/lib/python2.x/site-packges/rbtools/ (this could be zipped so You
probably must use some smart editor which allow change files in zipped
archives)

On Tue, Sep 21, 2010 at 10:43 PM, Jay jayki...@gmail.com wrote:
 On Sep 21, 12:11 pm, Chris Clark chris.cl...@ingres.com wrote:

 It looks like p4 is claiming there is a perforce repo in the svn
 location. A quick hack/test would be to modify postreview to check svn
 first. I.e. hack the SCMCLIENTS def.

 And where would the SCMCLIENTS.def be located?  Is this on the client?
 I can't seem to find any config files for post-review apart from
 a .post-review-cookie file in Local Settings/Application Data...

 ...Jay

 --
 Want to help the Review Board project? Donate today at 
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to 
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at 
 http://groups.google.com/group/reviewboard?hl=en



-- 
 Jan Koprowski

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Accessing different repo types from post-review

2010-09-21 Thread Jay
  On Sep 21, 12:11 pm, Chris Clark chris.cl...@ingres.com wrote:

  It looks like p4 is claiming there is a perforce repo in the svn
  location. A quick hack/test would be to modify postreview to check svn
  first. I.e. hack the SCMCLIENTS def.

Let's assume this suggestion actually works since it looks like the
script first tries hg, then p4, probably then svn.  It seems there
needs to be a way to explicitly indicate which scm provider to use,
rather than do it implicitly since it's conceivable they could all
work for a given directory.   Take for instance the following
structure:

c:/dev   - this is the root for the perforce clientspec
c:/dev/myproject/vers1 - this is a perforce version of the project
called out in the clientspec
c:/dev/myproject/vers2 - this is the root for an svn repository for
the project

I could see how perforce might be picked up for myproject/vers2 even
though it isn't specified in the perforce clientspec.  If there was a
way to explicitly declare the repo type, then this wouldn't be an
issue.

...Jay

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Issue 1821 in reviewboard: Error during uploading updated diff

2010-09-21 Thread reviewboard

Updates:
Status: NeedInfo

Comment #1 on issue 1821 by chipx86: Error during uploading updated diff
http://code.google.com/p/reviewboard/issues/detail?id=1821

Likely due to a compatibility issue in Djblets. Try upgrading Djblets:

  $ sudo easy_install -U Djblets

Then restart Apache. If that doesn't work, we'll look into a quick fix.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1821 in reviewboard: Error during uploading updated diff

2010-09-21 Thread reviewboard


Comment #2 on issue 1821 by balabol: Error during uploading updated diff
http://code.google.com/p/reviewboard/issues/detail?id=1821

As I see, I use actual version of Djblets.

Output:

easy_install -U Djblets
Searching for Djblets
Reading http://pypi.python.org/simple/Djblets/
Reading http://www.review-board.org/wiki/Djblets
Reading http://downloads.review-board.org/releases/Djblets/0.5/
Reading http://downloads.review-board.org/releases/
Reading http://downloads.review-board.org/releases/Djblets/0.6/
Best match: Djblets 0.6.4
Processing Djblets-0.6.4-py2.4.egg
Djblets 0.6.4 is already the active version in easy-install.pth

Using /usr/lib/python2.4/site-packages/Djblets-0.6.4-py2.4.egg
Reading http://downloads.review-board.org/mirror/
Processing dependencies for Djblets
Finished processing dependencies for Djblets


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1821 in reviewboard: Error during uploading updated diff

2010-09-21 Thread reviewboard


Comment #3 on issue 1821 by sskrasnov: Error during uploading updated diff
http://code.google.com/p/reviewboard/issues/detail?id=1821

As I see, I use actual version of Djblets.

Output:

easy_install -U Djblets
Searching for Djblets
Reading http://pypi.python.org/simple/Djblets/
Reading http://www.review-board.org/wiki/Djblets
Reading http://downloads.review-board.org/releases/Djblets/0.5/
Reading http://downloads.review-board.org/releases/
Reading http://downloads.review-board.org/releases/Djblets/0.6/
Best match: Djblets 0.6.4
Processing Djblets-0.6.4-py2.4.egg
Djblets 0.6.4 is already the active version in easy-install.pth

Using /usr/lib/python2.4/site-packages/Djblets-0.6.4-py2.4.egg
Reading http://downloads.review-board.org/mirror/
Processing dependencies for Djblets
Finished processing dependencies for Djblets

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 1822 in reviewboard: When ReviewBoard cooperates with BTS(Trac, Redmine), what can you do?

2010-09-21 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 1822 by asa...@bsc.fujitsu.com: When ReviewBoard cooperates with  
BTS(Trac, Redmine), what can you do?

http://code.google.com/p/reviewboard/issues/detail?id=1822

What version are you running?
 ver 1.0.9

What operating system are you using? What browser?
 Server : CentOS 5.3 32 bit
 SVN: Subversion
 BTS: Nothing
 Client : WindowsXP SP3 Firefox3.6.9

Please provide any additional information below.

What does the ReviewBoard have in connection with BTS(Trac, Redmine)?

It is this that I know.
・When input bug management ID at the time of review comment making, link  
to a ticket of BTS(Trac, Redmine).


Is the cooperation of ReviewBoard and BTS(Trac, Redmine) only a link?


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1822 in reviewboard: When ReviewBoard cooperates with BTS(Trac, Redmine), what can you do?

2010-09-21 Thread reviewboard

Updates:
Status: NotABug

Comment #1 on issue 1822 by chipx86: When ReviewBoard cooperates with  
BTS(Trac, Redmine), what can you do?

http://code.google.com/p/reviewboard/issues/detail?id=1822

For now, yes, we only support creating the links. In the future, there may  
be better support for actually updating bug trackers.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1660 in reviewboard: djblets.utils.misc.cache_memoize wrong work for large data in some cases

2010-09-21 Thread reviewboard


Comment #1 on issue 1660 by email.do.nuno: djblets.utils.misc.cache_memoize  
wrong work for large data in some cases

http://code.google.com/p/reviewboard/issues/detail?id=1660

I also have this problem with v1.0.9.

After the problem occurs apache keeps using 100% CPU until I restart it

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 1823 in reviewboard: reports an XML file as binary when it is text.

2010-09-21 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 1823 by cppgent0: reports an XML file as binary when it is text.
http://code.google.com/p/reviewboard/issues/detail?id=1823

*NOTE: Do not post confidential information in this bug report.*

What version are you running? 1.0.7


What's the URL of the page containing the problem?  
http://cm1/reviews/r/26/diff/#index_header



What steps will reproduce the problem?
Not sure exactly, but:
1. create an XML file (see attached)
2. use hg postreview to create the diff
3. view in RB (see screenshot.png)
3.

What is the expected output? What do you see instead?
I expected a diff for a text file. RB indicates it is binary.

What operating system are you using? What browser?
Ubuntu 10.04, Google chrome


Please provide any additional information below.


Attachments:
EN-AM.xml  1.0 KB
Screenshot.png  10.5 KB

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1822 in reviewboard: When ReviewBoard cooperates with BTS(Trac, Redmine), what can you do?

2010-09-21 Thread reviewboard


Comment #3 on issue 1822 by asa...@bsc.fujitsu.com: When ReviewBoard  
cooperates with BTS(Trac, Redmine), what can you do?

http://code.google.com/p/reviewboard/issues/detail?id=1822

Please teach it one more.

I understand that one review request and the ticket of the one of bug  
trackers can link.


Then can you link one review request and plural tickets of bug trackers?


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1822 in reviewboard: When ReviewBoard cooperates with BTS(Trac, Redmine), what can you do?

2010-09-21 Thread reviewboard


Comment #4 on issue 1822 by trowbrds: When ReviewBoard cooperates with  
BTS(Trac, Redmine), what can you do?

http://code.google.com/p/reviewboard/issues/detail?id=1822

You can link as many tickets as you like, separated by commas.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1822 in reviewboard: When ReviewBoard cooperates with BTS(Trac, Redmine), what can you do?

2010-09-21 Thread reviewboard


Comment #5 on issue 1822 by asa...@bsc.fujitsu.com: When ReviewBoard  
cooperates with BTS(Trac, Redmine), what can you do?

http://code.google.com/p/reviewboard/issues/detail?id=1822

Thank you very much for your quick reply.



--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 1824 in reviewboard: unable to easy_install 1.5rc2

2010-09-21 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 1824 by latchkey: unable to easy_install 1.5rc2
http://code.google.com/p/reviewboard/issues/detail?id=1824

Excited for rc2!

I already have rc1 installed.

I'm looking at:  
http://www.reviewboard.org/docs/manual/dev/admin/installation/upgrading/


I thus execute:

[root@ ~]# easy_install -U ReviewBoard
Searching for ReviewBoard
Reading http://pypi.python.org/simple/ReviewBoard/
Reading http://www.reviewboard.org/
Reading http://downloads.reviewboard.org/releases/ReviewBoard/1.0/
Reading http://www.review-board.org/
Reading http://downloads.review-board.org/releases/
Reading http://downloads.review-board.org/releases/ReviewBoard/1.0/
Best match: ReviewBoard 1.5rc1
Processing ReviewBoard-1.5rc1-py2.4.egg
ReviewBoard 1.5rc1 is already the active version in easy-install.pth
Installing rb-site script to /usr/bin

Using /usr/lib/python2.4/site-packages/ReviewBoard-1.5rc1-py2.4.egg
Reading http://downloads.reviewboard.org/mirror/
Reading http://downloads.reviewboard.org/releases/ReviewBoard/1.5/
Processing dependencies for ReviewBoard
Finished processing dependencies for ReviewBoard


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1821 in reviewboard: Error during uploading updated diff

2010-09-21 Thread reviewboard


Comment #4 on issue 1821 by sskrasnov: Error during uploading updated diff
http://code.google.com/p/reviewboard/issues/detail?id=1821

If my previous comment was misunderstand, I explain more detailed.
I try to update Djblets with easy_install tool, and get message, that I  
have actual version of Djblets.

Also, after that I restart Apache and try to upload diff.
It doesn't work, I get same error.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1821 in reviewboard: Error during uploading updated diff

2010-09-21 Thread reviewboard


Comment #5 on issue 1821 by chipx86: Error during uploading updated diff
http://code.google.com/p/reviewboard/issues/detail?id=1821

Okay, this looks like a regression caused by the newer Djblets. Try to  
uninstall your old Djblets (you'll need to remove  
/usr/lib/python2.4/site-packages/Djblets-0.6.4-py2.4.egg) and then try  
installing 0.6.3:


   $ sudo easy_install -U Djblets=0.6.3

I'll look at putting out a patch to 1.0.9 that fixes compatibility.

Let me know if the above works.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.