View Diff shows file content incorrectly
Reviewboard 1.0.9 is configured on a Centos 5.5 machine with postgresql as the database. We had done an upgrade from 1.0.7 to 1.0.9, rbsites were upgraded to 1.0.9 and everything was working fine, off late we have started facing issues- code is committed in one project, its corresponding RB site review request view diff shows the diff of some file checked in some other project; however download diff downloads the proper diff. Our setup has multiples RB sites each pointing to its respective subversion repository; users can only access the rbsite for the project in which they are working. After the upgrade no change was made on server side; hence kind of lost on what went wrong. In a particular project, this was restricted to a single user, deleting user's RB site login did the trick in that instance. Kindly help in resolving this issue!! regards, -nj -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Permission to create and comment on reviews?
On Fri, Nov 26 I wrote: Is it possible to configure reviewboard so that: Accounts can be created by anyone Those accounts cannot create reviews or post comments until they have been manually added to the appropriate Permission Group? I'm setting up a system to be used by the Second Life Viewer open source project, and would prefer not to have to create accounts for people by hand, but would like to have some control over who can add content. On 2010-11-26 15:06, Christian Hammond wrote: The default registration method is to allow anyone to register a new account. However, it's not moderated, as you know. That's something that could be accomplished by unsetting the 'active' flag on the User entry in the database, which an auth backend could certainly do. So, short term, if you wanted you could probably just create a new Django auth backend and tell Review Board to use it. I'm working on documentation on how to create these and use them, and have some plans for making it easier to work with them in 1.6. What you also probably want is some notification on newly registered users. The auth backend could potentially do this too. So, if you want to get going fast, that's probably what you should do. However, one option we could add is to have a new option in Authentication Settings for Require approval for new accounts or something to that effect. When checked, new accounts would be set inactive by default, and an e-mail would go out to the admins of the site (or some other preconfigured address). The admin would then just need to go into the admin UI and set them active. Does that sound about what you'd want? You mentioned the permission groups, but those aren't really used anywhere but the admin UI (with the exception of a couple special permissions for allowing users to post on behalf of other users, mainly for post-commit hooks). I've since gotten a bit further with this, and have some feedback on authentication/permission issues for future versions... * I had wanted to allow anonymous read-only access to the system, since I'd like to run the project in as open a way as possible, but the fact that the RESTful APIs are all open when anonymous access is allowed made me decide not to do that - try: curl http://reviews.reviewboard.org/api/users/ (it dumps the user database, including email addresses) Which apparently leaves me with allowing anyone to create an account and then shutting them out manually if they post inappropriately (I have not been able to get Christians suggestion to start with the Active flag false to deploy... see earlier mail). I expect this to cause problems... Ideally, I'd like to be able to configure things so that * Anonymous users can browse reviews * Anyone can create an account * I can create permissions groups: o Contributors - can post and comment on reviews (see below) o Committers - can also change status and edit reviews (this one I have now) * Even if I could allow anonymous access, I'd only want it to be allowed for actual people; at a previous project, I ran an open instance of Fisheye/Crucible, and the search engine spiders really ran up our bandwidth and cpu usage by crawling links. In my new reviewboard installation, I've added a robots.txt file to discourage them (worked well last time). I'm not sure why one would need anything more than an all-or-nothing choice here, but it would be good to automate this one way or the other. * Since we're using the Standard Registration system, and I don't want credentials to be visible on the wire, I configured the entire site (except /robots.txt) to require SSL. This was pretty easy to do, including a redirect for any http URL to its https equivalent. It would be nice if rb-site had an option to require this (if there's interest, I may be able to work on this as a contribution at some point). A note on why I need permission control for Contributors... our project, like many others, has a Contribution Agreement that developers must agree to in order for us to accept code. It provides some mutual patent protections, and assigns a shared copyright, which can be very useful if the project ever needs to modify its license terms (we recently switched from GPL to LGPL for most things). The terms of use for our reviewboard site (codereview.secondlife.com) include an agreement that anything posted there counts as a Contribution under that agreement, so I'd like to be able to verify that a given account has an agreement on file before allowing them write access (if someone ignores the terms of use statement and posts something but has not signed the agreement, I am in a grey area I'd rather not be in). -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at
ImproperlyConfigured: Error importing middleware reviewboard.admin.middleware: DLL load failed: The specified module could not be found.
Trying to install Reviewboard 1.5.1 on Windows XP SP3 with Apache 2.2
and mod_wsgi. Below is my apache error log. In my browser I get stuck
on Review Board is taking a nap. Any idea what's going on? How do I
tell which DLL failed?
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1] mod_wsgi
(pid=14184): Exception occurred processing WSGI script 'C:/reviewboard/
htdocs/reviewboard.wsgi'.
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1] Traceback (most
recent call last):
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1] File C:\
\Python27\\lib\\site-packages\\django-1.2.3-py2.7.egg\\django\\core\
\handlers\\wsgi.py, line 230, in __call__
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1]
self.load_middleware()
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1] File C:\
\Python27\\lib\\site-packages\\django-1.2.3-py2.7.egg\\django\\core\
\handlers\\base.py, line 42, in load_middleware
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1] raise
exceptions.ImproperlyConfigured('Error importing middleware %s: %s'
% (mw_module, e))
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1]
ImproperlyConfigured: Error importing middleware
reviewboard.admin.middleware: DLL load failed: The specified module
could not be found.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
callback_ssl_client_cert_prompt required; when using client cert authentication for svn
HI, I am using 1.5.1 version and still facing the same issue. Just wondering if the problem is still in reviewboard or i'm doing something wrong. error.log says: callback_ssl_client_cert_prompt required Thanks in advance. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Issue 1903 in reviewboard: [Discarded] label could be red to diferentiate from Submitted ones
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1903 by adrianboimvaser: [Discarded] label could be red to diferentiate from Submitted ones http://code.google.com/p/reviewboard/issues/detail?id=1903 What version are you running? 1.5.1 What's the URL of the page containing the problem? /dashboard/?view=mine What is the expected output? What do you see instead? A red [Discarded] label. A green [Discarded] label. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1904 in reviewboard: Adding Bonus/Deduction mark doesn't update total marks.
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1904 by byronweberbecker: Adding Bonus/Deduction mark doesn't update total marks. http://code.google.com/p/reviewboard/issues/detail?id=1904 *NOTE: Do not post confidential information in this bug report.* What version are you running? v0.9.2 What's the URL of the page containing the problem? https://markus002.student.cs.uwaterloo.ca/cs135/main/results/edit/1566 What steps will reproduce the problem? 1. Go to the summary tab. Add a bonus/deduction. 2. 3. What is the expected output? What do you see instead? The final mark should be recalculated. It isn't. Refreshing the page doesn't seem to make a difference. Going back to the submissions list and clicking on this student's submission seems to do it. What operating system are you using? What browser? OS X I've observed this in both safari and firefox. Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1904 in reviewboard: Adding Bonus/Deduction mark doesn't update total marks.
Updates: Status: Invalid Comment #1 on issue 1904 by trowbrds: Adding Bonus/Deduction mark doesn't update total marks. http://code.google.com/p/reviewboard/issues/detail?id=1904 This bug tracker is about Review Board, not MarkUs. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1903 in reviewboard: [Discarded] label could be red to diferentiate from Submitted ones
Updates: Labels: -Type-Defect Type-Enhancement Component-Dashboard Comment #1 on issue 1903 by trowbrds: [Discarded] label could be red to diferentiate from Submitted ones http://code.google.com/p/reviewboard/issues/detail?id=1903 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1897 in reviewboard: The Posted Time should be the time of publish
Updates: Labels: Component-Reviews Comment #1 on issue 1897 by trowbrds: The Posted Time should be the time of publish http://code.google.com/p/reviewboard/issues/detail?id=1897 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1896 in reviewboard: Omitting the git repo path throws 500 error
Updates: Labels: Component-Admin Comment #1 on issue 1896 by trowbrds: Omitting the git repo path throws 500 error http://code.google.com/p/reviewboard/issues/detail?id=1896 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1905 in reviewboard: Extra whitespace is not highlighted
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 1905 by mikhail@gmail.com: Extra whitespace is not highlighted
http://code.google.com/p/reviewboard/issues/detail?id=1905
What version are you running?
ReviewBoard-1.5-py2.6 and up
What's the URL of the page containing the problem?
e.g. http://reviews.reviewboard.org/r/1914/diff/3/#index_header
What steps will reproduce the problem?
1. create review request, upload patch contained some extra whitespace
2. click View diffs
What is the expected output? What do you see instead?
ACT: only some of extra whitespaces are highlighted
whitespace in RBBugTracker/setup.py:15 is highlighted
whitespace in
RBBugTracker/RBBugTracker/templates/googlecode/save_username.html:7 is not
highlighted
EXP: all whitespaces are highlighted
What operating system are you using? What browser?
Chromium 6.0, Firefox 3.6.12, IE 8
Please provide any additional information below.
The bug occurs because toggleExtraWhitespace called in $(document).ready
(diffviewer.js:1335)
toggleExtraWhitespace function toggles ewhl class on all whitespace
elements. Since diffs content is loaded asynchronously, most of the
whitespace elements are not loaded when document.ready occured.
In my install i fixed it following way:
diff --git a/reviewboard/htdocs/media/rb/js/diffviewer.js
b/reviewboard/htdocs/media/rb/js/diffviewer.js
index d283d89..116b016 100644
--- a/reviewboard/htdocs/media/rb/js/diffviewer.js
+++ b/reviewboard/htdocs/media/rb/js/diffviewer.js
@@ -1325,7 +1325,7 @@ function toggleExtraWhitespace(init)
}
/* Toggle highlighting */
-$(table.sidebyside .ew).toggleClass(ewhl);
+$(#diffs).toggleClass(ewhl);
/* Toggle the display of the button itself */
$(.review-request ul.controls li.ew).toggle();
diff --git a/reviewboard/templates/diffviewer/view_diff.html
b/reviewboard/templates/diffviewer/view_diff.html
index de1f8c2..62dafc8 100644
--- a/reviewboard/templates/diffviewer/view_diff.html
+++ b/reviewboard/templates/diffviewer/view_diff.html
@@ -23,7 +23,7 @@
link rel=stylesheet type=text/css
href={{MEDIA_URL}}rb/css/syntax.css?{{MEDIA_SERIAL}} /
{% if siteconfig.settings.diffviewer_show_trailing_whitespace|
default_if_none:1 %}
style type=text/css
- .ewhl { background: #ee3434; }
+ #diffs.ewhl table.sidebyside .ew { background: #ee3434; }
/style
{% endif %}
{% endblock %}
Toggle ewhl class only on parent element.
ew elements are highlighted depending on this not their own class.
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
