Send reminder mails to reviewers who have not responded after fixed time.
Hi, I would like to know if it is possible to Send Reminder Mails to reviewers who haven't responded to a review posted within a specified amount of time ? This will be helpful in case some reviewer has forgotten to review for some reason and overlooked the Dashboard. If it is not already available, where can I start (source files etc) to develop this feature on my own ? Thanks, Anshul -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Send reminder mails to reviewers who have not responded after fixed time.
There's nothing yet to do this automatically. What most people do is to just add a review to their own change with some kind of ping message. I personally prefer this solution because different changes often have different priorities, and people already get quite a bit of email from review board. If you want to try to implement something, a good place to start would be in reviewboard/notifications/email.py -David On Wed, Jan 12, 2011 at 12:52 AM, Anshul anshul14ran...@gmail.com wrote: Hi, I would like to know if it is possible to Send Reminder Mails to reviewers who haven't responded to a review posted within a specified amount of time ? This will be helpful in case some reviewer has forgotten to review for some reason and overlooked the Dashboard. If it is not already available, where can I start (source files etc) to develop this feature on my own ? Thanks, Anshul -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
after code review, i can not submit code to svn repository
Hi, i encountered one issue, please help. i installed review board, also configured, i can submit review request, after reviewers review the request, when i click close- submitted, but the code can not submitted to the svn repository, please help me, thanks, will be appreciated. regards liting -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: after code review, i can not submit code to svn repository
Review Board does not automatically submit code for you. What's expected is that you'll commit your code as you have always done, and close - submitted is just a way of marking the review request as being done because the code is committed (as opposed to closing because the change was abandoned). - David On Jan 12, 2011, at 1:14 AM, liting cao airsu...@gmail.com wrote: Hi, i encountered one issue, please help. i installed review board, also configured, i can submit review request, after reviewers review the request, when i click close- submitted, but the code can not submitted to the svn repository, please help me, thanks, will be appreciated. regards liting -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Question about postreview.py get_repository_info
Here is a more accurate description:
In ReviewBoardServer.get_repository_info, it calls
ReviewBoardServer.api_get to fetch the repository info from sever,
from my debug, it show the return json is something like (if the
repository is svn)
{
stat: ok,
repository: {
path: http://192.168.1.131/svn/Android;,
tool: Subversion,
id: 2,
links: {
info: {
href: http://192.168.1.131:81/api/repositories/2/
info/,
method: GET
},
self: {
href: http://192.168.1.131:81/api/repositories/
2/,
method:
GET
}
},
name: local-android
}
}
from the data structure of the json, we can see that use url =
rsp['links']['info']['href'] of course will get a array key
exception.
should use url = rsp['repository']['links']['info']['href'].
Is this a bug?
On Jan 11, 9:24 pm, Dan birb...@gmail.com wrote:
Hi
Here I have a problem with postreview.py when publish a review
request, could anyone please have a look?
My enviroment is Reviewboard 1.5.1 and SVN. I downloaded postreview.py
fromhttps://github.com/reviewboard/rbtools/blob/184334a7a5ddc24172ae2aa03...,
and configed the constants necessary.
When I run postreivew, it throws a array index exception at line 677:
url = rsp['links']['info']['href'], The whole piece of code is
def get_repository_info(self, rid):
Returns detailed information about a specific repository.
if self.deprecated_api:
url = 'api/json/repositories/%s/info/' % rid
else:
rsp = self.api_get(
'%s%s/' % (self.root_resource['links']['repositories']
['href'],
rid))
url = rsp['links']['info']['href']
rsp = self.api_get(url)
return rsp['info']
I added debug info for rep, it did not contain the links index
indeed, but it contained a repository index.
Then I manually went to check the xml from reviewboard server, and
found the structure of the xml is like this
rsp
repository
links
info
href
so I changed line 677 to url = rsp[repository]['links']['info']
['href'], finally it worked.
Though it worked, I still did not know the reason and whether my
change is right or wrong. I think it is unlike to be a bug of
reviewboard, but I am too lazy to read all the code :-) so, could
anyone kindly tell me that what the real problem is and what should I
do?
Any help will be highly appreciated!
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Question about postreview.py get_repository_info
A more correct and readable json than last post, the indent for name
in the last post is wrong.
{
stat: ok,
repository: {
path: http://192.168.1.131/svn/Android;,
tool: Subversion,
id: 2,
links: {
info: {
href: http://192.168.1.131:81/api/repositories/2/
info/,
method: GET},
self: {
href: http://192.168.1.131:81/api/repositories/
2/,
method: GET}},
name: local-android}
}
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: after code review, i can not submit code to svn repository
Hi, David thanks, appreciated. Best Regards liting 2011/1/12 David Trowbridge trowb...@gmail.com Review Board does not automatically submit code for you. What's expected is that you'll commit your code as you have always done, and close - submitted is just a way of marking the review request as being done because the code is committed (as opposed to closing because the change was abandoned). - David On Jan 12, 2011, at 1:14 AM, liting cao airsu...@gmail.com wrote: Hi, i encountered one issue, please help. i installed review board, also configured, i can submit review request, after reviewers review the request, when i click close- submitted, but the code can not submitted to the svn repository, please help me, thanks, will be appreciated. regards liting -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- 曹丽婷 -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Clustered RB Instances ?
Hi ALL, I have been using RB since 1.0 and then I have successfully upgraded it 1.5.2. We have global teams which would like to use RB Server for their code reviews. The source code repositories are located in their respective geographies. Is it possible to have clustered instances of RB Servers in which 1. Administration, configuration ... etc are done at the master / central server. 2. The local RB instances would pull information for any commits commited to the local SCM, diff them generate review requests, etc. and then push them to the master RB server Thanks Regards Prashant -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Question about postreview.py get_repository_info
Hi Dan,
You're correct, this is a bug, and your fix looks fine. We'll have to
get that fix in. Want to post a review request?
Christian
On Wednesday, January 12, 2011, Dan birb...@gmail.com wrote:
Here is a more accurate description:
In ReviewBoardServer.get_repository_info, it calls
ReviewBoardServer.api_get to fetch the repository info from sever,
from my debug, it show the return json is something like (if the
repository is svn)
{
stat: ok,
repository: {
path: http://192.168.1.131/svn/Android;,
tool: Subversion,
id: 2,
links: {
info: {
href: http://192.168.1.131:81/api/repositories/2/
info/,
method: GET
},
self: {
href: http://192.168.1.131:81/api/repositories/
2/,
method:
GET
}
},
name: local-android
}
}
from the data structure of the json, we can see that use url =
rsp['links']['info']['href'] of course will get a array key
exception.
should use url = rsp['repository']['links']['info']['href'].
Is this a bug?
On Jan 11, 9:24 pm, Dan birb...@gmail.com wrote:
Hi
Here I have a problem with postreview.py when publish a review
request, could anyone please have a look?
My enviroment is Reviewboard 1.5.1 and SVN. I downloaded postreview.py
fromhttps://github.com/reviewboard/rbtools/blob/184334a7a5ddc24172ae2aa03...,
and configed the constants necessary.
When I run postreivew, it throws a array index exception at line 677:
url = rsp['links']['info']['href'], The whole piece of code is
def get_repository_info(self, rid):
Returns detailed information about a specific repository.
if self.deprecated_api:
url = 'api/json/repositories/%s/info/' % rid
else:
rsp = self.api_get(
'%s%s/' % (self.root_resource['links']['repositories']
['href'],
rid))
url = rsp['links']['info']['href']
rsp = self.api_get(url)
return rsp['info']
I added debug info for rep, it did not contain the links index
indeed, but it contained a repository index.
Then I manually went to check the xml from reviewboard server, and
found the structure of the xml is like this
rsp
repository
links
info
href
so I changed line 677 to url = rsp[repository]['links']['info']
['href'], finally it worked.
Though it worked, I still did not know the reason and whether my
change is right or wrong. I think it is unlike to be a bug of
reviewboard, but I am too lazy to read all the code :-) so, could
anyone kindly tell me that what the real problem is and what should I
do?
Any help will be highly appreciated!
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Issue 1939 in reviewboard: .sj Files are being displayed as binary files (despite being text format files) in review board
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1939 by rahulrstogi: .sj Files are being displayed as binary files (despite being text format files) in review board http://code.google.com/p/reviewboard/issues/detail?id=1939 *NOTE: Do not post confidential information in this bug report.* What version are you running - 1.0.9 What's the URL of the page containing the problem - N/A What steps will reproduce the problem? 1. Submit any diff file which contains .sj files in the code 2. Go to View Diff 3. Review board shows that .sj files are binary files and code doesn't get displayed for these files What is the expected output - N/A What do you see instead - N/A What operating system are you using - All OS What browser - All Browsers Thanks Regards Rahul -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1940 in reviewboard: Spaces in URL path are not encoded as %20 in email notifications
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1940 by quinntay...@mac.com: Spaces in URL path are not encoded as %20 in email notifications http://code.google.com/p/reviewboard/issues/detail?id=1940 What version are you running? 1.5.1 What's the URL of the page containing the problem? n/a, it's in an email What steps will reproduce the problem? 1. Enable email notifications for review requests. 2. Submit a review request for a path containing one or more spaces. What is the expected output? What do you see instead? The web page for the review displays correct links under Files Changed (the href has unescaped URLs, but the browser automatically handles spaces), but the notification email does not. My email client auto-senses URLs and only picks up the part up to the first space. If the URL were encoded such that spaces are replaced by %20, the links would work just fine. This problem occurs both in the plain text and HTML parts of the email. What operating system are you using? What browser? Mac OS X 10.6.6, Safari 5, Mail.app -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1941 in reviewboard: Code comments should have quick done button.
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 1941 by philip.zeyliger: Code comments should have quick done button. http://code.google.com/p/reviewboard/issues/detail?id=1941 *NOTE: If you have a patch, please submit it to http://reviews.reviewboard.org/ What version are you running? 1.5 What's the URL of the page this enhancement relates to, if any? /r/[0-9]*/diff/ Describe the enhancement and the motivation for it. For a great deal of code comments, I merely want to acknowledge that I saw them and that I changed the code per the recommendation. My reviewer might say indentation is wrong or does this need to be public or can you add some javadoc here, and I want to indicate to them that I did what they recommended and that there's nothing more to say. I think this is such a common use case that there can be a single button to write the comment for me. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1940 in reviewboard: Spaces in URL path are not encoded as %20 in email notifications
Comment #2 on issue 1940 by quinntay...@mac.com: Spaces in URL path are not encoded as %20 in email notifications http://code.google.com/p/reviewboard/issues/detail?id=1940 Sorry, the URLs I'm talking about are repository paths for the files changed in a given diff. (I have RB connected to our Subversion repository.) When there are spaces in the path (either for a directory or filename) the email dutifully prints the URL as-is. The trouble starts when I try to click on a link to jump to such a file. For example, if I submit a review request for a diff affecting this URL: http://svn.example.com/trunk/A Spaceful Directory Name/foo.java the email that is sent will include this URL in a bulleted list, but without accounting for spaces, the URL is recognized as: http://svn.example.com/trunk/A Obviously, this is not a URL that RB is creating per se, but is IS something that can be defended against. One simple approach to fix this is detailed here: http://stackoverflow.com/questions/120951/how-can-i-normalize-a-url-in-python#845595 import urllib url = urllib.quote(url, safe=%/:=?~#+!$,;'@()*[]) This percent escapes spaces and other characters, but avoid escaping the colon in the scheme, etc. The result is: http://svn.example.com/trunk/A%20Spaceful%20Directory%20Name/foo.java Hopefully this provides enough context to clarify the problem I'm seeing. Thanks! -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1032 in reviewboard: Diff currently unavailable when viewing diffs of diffs
Comment #11 on issue 1032 by yiminmm: Diff currently unavailable when viewing diffs of diffs http://code.google.com/p/reviewboard/issues/detail?id=1032 Unfortunately this happened on me for now. http://ramble.corp.good.com/reviewboard/r/12744/diff/ Please let me know how to clear server cache for me. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1942 in reviewboard: [ReviewBoard] Unexisted js scripts links in admin page
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1942 by Jan.Koprowski: [ReviewBoard] Unexisted js scripts links in admin page http://code.google.com/p/reviewboard/issues/detail?id=1942 What version are you running? ReviewBoard 1.5 What's the URL of the page containing the problem? /admin/db/auth/user/ What steps will reproduce the problem? 1. Visit followin URL 2. View the Source of webpage 3. See at part: script type=text/javascript src=/media/admin/js/core.js/script script type=text/javascript src=/media/admin/js/admin/RelatedObjectLookups.js/script script type=text/javascript src=/media/admin/js/jquery.min.js/script script type=text/javascript src=/media/admin/js/jquery.init.js/script script type=text/javascript src=/media/admin/js/actions.min.js/script There is a bunch of scripts which doesn't exist in file system. Apache error log shows: [Thu Jan 11 08:02:55 2011] [error] [client 192.168.0.1] File does not exist: /reviewboards/project/htdocs/media/admin/js/jquery.min.js, referer: https://project.reviewboard.com/admin/db/auth/user/ [Thu Jan 11 08:02:55 2011] [error] [client 192.168.0.1] File does not exist: /reviewboards/project/htdocs/media/admin/js/jquery.init.js, referer: https://project.reviewboard.com/admin/db/auth/user/ [Thu Jan 11 08:02:55 2011] [error] [client 192.168.0.1] File does not exist: /reviewboards/project/htdocs/media/admin/js/actions.min.js, referer: https://project.reviewboard.com/admin/db/auth/user/ [Thu Jan 11 08:02:55 2011] [error] [client 192.168.0.1] File does not exist: /reviewboards/project/htdocs/media/admin/js/jquery.min.js, referer: https://project.reviewboard.com/admin/db/auth/user/ [Thu Jan 11 08:02:55 2011] [error] [client 192.168.0.1] File does not exist: /reviewboards/project/htdocs/media/admin/js/jquery.init.js, referer: https://project.reviewboard.com/admin/db/auth/user/ [Thu Jan 11 08:02:55 2011] [error] [client 192.168.0.1] File does not exist: /reviewboards/project/htdocs/media/admin/js/actions.min.js, referer: https://project.reviewboard.com/admin/db/auth/user/ What is the expected output? What do you see instead? Clean Apache error-log. What operating system are you using? What browser? Firefox/Google Chrome/Internet Explorer 8 Linux Apache 2 mod_wsgi -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
