Re: How to make compatibility mode enable RB for IE9

2011-10-14 Thread Christian Hammond
What values? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Oct 13, 2011 at 12:06 AM, jack jack wrote: > I am seeing this issue where the values are not getting populated if the > compatibility mode

Re: Internationalization and support for unicode

2011-10-14 Thread Christian Hammond
Hi Sam, This sounds like another instance of the database not being utf-8. We operate almost entirely in utf-8, and the database needs to be able to store that. The reviews_review table is the cause for this error, but you'll likely hit it again and again with more tables unless the entire databas

Re: problem upgrading 1.5.6 to 1.6.1

2011-10-14 Thread Christian Hammond
Hmm hard to say. Sounds like a very round-about way of doing things. I believe there were some transformations we made during evolution time to the data in 1.6. Have you hit any problems yet? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, I

Re: "Issue" checkbox in while entering comments

2011-10-14 Thread Christian Hammond
Hi Gyanesh, The new issue tracking feature is intended as a way to speed up the review process. Typically, when a reviewer found something that needed to be changed, they would make a comment and say what the problem was. The developer would then generally reply with "Fixed" or "Done" or something

Re: post-review unable to log into ReviewBoard server

2011-10-14 Thread Christian Hammond
Hi Phil, It looks like your path to the Review Board server is configured wrong. It looks like you've installed RB in a subdirectory install, but your repository is pointing to the root of the server and not the subdirectory. If you're using the reviewboard:url SVN property, try setting it to htt

Re: reviewboard 1.6.1 with wsgi

2011-10-14 Thread יונתן קינן
I got it to work in my personal laptop, I should note that you also need to change the settings file. /var/www/reviewboard/conf/settings_local.py You need to change SITE_ROOT from '/' to '/review/'(depends on the chosen sub directory) I also added reverse proxying so it could work with Bugzilla. I

Re: Web API: interpreting line positions of diff comments

2011-10-14 Thread Christian Hammond
Hi Robert, Sorry I didn't get to this sooner, but you're correct. It's a virtual line number that is based on the generated diff using our specific algorithm. We use virtual line numbers rather than real numbers because real numbers wouldn't necessarily make sense depending on how you generate the

post-review unable to log into ReviewBoard server

2011-10-14 Thread Phil Lodine
I've installed the RB 1.6.1 on my Windows 7 machine, with Apache 2.2 and mod_python, for use with our company's Subversion repository. (Many thanks to David Ball for his excellent braindump on installing RB on Windows!) The RB Admin site works fine (able to set up users, review groups etc.). Howev

Internationalization and support for unicode

2011-10-14 Thread Sam
Installing RB for the first time today. I ran into problems when trying to comment on code lines using Chines; it would show up as question marks after I published it. I made a quick fix by changing the text column of a reviews_comment table to be utf8_general_ci collation in the database. I notice

Re: "Issue" checkbox while entering comments

2011-10-14 Thread Gyanesh Singh
Hi, I am using RB 1.6, RBTools: 3.4 on RHEL I think the I didn't check the documentation in detail, before writing this email. I checked the documentation at http://www.reviewboard.org/docs/manual/dev/users/reviews/issue-tracking/ It says, "By default, Open an issue is checked for new comments."

Re: Web API: interpreting line positions of diff comments

2011-10-14 Thread Robert Munteanu
I've tried to understand how this mapping is perfomed and came up with the following description/example. Can anyone confirm that I got it right? Thanks. ReviewBoard diff comments are mapped to the virtual diff table which is shown in the web interface, not to a location in the old or new fil

"Issue" checkbox in while entering comments

2011-10-14 Thread Gyanesh Singh
Hi, I need some more info on when does a reviewer tick this "Issue" check box? How is different from any other comment where this is not ticked? Is there any special meaning to it? The only difference I see when this is selected is that comment is shown little differently. PS: Curious on this as