Review Board 1.6.2 released

2011-11-10 Thread Christian Hammond
Hey everyone,

Review Board 1.6.2 is out. Lots of various bug fixes in this, and hopefully
some fixes for deployment that'll keep new users from hitting problems.

See http://www.reviewboard.org/news/2011/11/10/review-board-162-released/

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: SVN+SSH Problem

2011-11-10 Thread Christian Hammond
Did you not see my reply?

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Wed, Nov 9, 2011 at 9:38 PM, MonicaS castaneda.mon...@gmail.com wrote:

 I have been trying to setup ReviewBoard with SVN SSH for a while, I
 tried everything found on the internet and I still have problems.

 I'm suppose to have a presentation this Friday but I just cannot make
 it run. I cannot add repositories.

 First at all, I copy the SSH public key on setting to the subversion
 server (specific user home page/.ssh/authorized_keys).

 When I use my subversion path: svn+ssh://username@repo-path/dir1/dir2
 I got the error: Unable to authenticate against this repository using
 one of the supported authentication types
 The log file is

   23:57:53 DEBUG SVNTool: Attempting ssh connection with host:
 svn_host, username: username
   23:57:53 DEBUG starting thread (client mode): 0xa5b8c4cL
   23:57:53 INFO Connected (version 2.0, client Sun_SSH_1.1)
   23:57:53 DEBUG kex algos:['diffie-hellman-group-exchange-sha1',
 'diffie-hellman-group1-sha1'] server key:['ssh-rsa', 'ssh-dss'] client
 encrypt:['aes128-cbc', 'blowfish-cbc', '3des-cbc'] server encrypt:
 ['aes128-cbc', 'blowfish-cbc', '3des-cbc'] client mac:['hmac-sha1',
 'hmac-md5'] server mac:['hmac-sha1', 'hmac-md5'] client compress:
 ['none', 'zlib'] server compress:['none', 'zlib'] client lang:['en-
 CA', 'en-US', 'es', 'es-MX', 'fr', 'fr-CA', 'i-default'] server lang:
 ['en-CA', 'en-US', 'es', 'es-MX', 'fr', 'fr-CA', 'i-default'] kex
 follows?False
   23:57:53 DEBUG Ciphers agreed: local=aes128-cbc, remote=aes128-cbc
   23:57:53 DEBUG using kex diffie-hellman-group1-sha1; server key
 type ssh-rsa; cipher: local aes128-cbc, remote aes128-cbc; mac: local
 hmac-sha1, remote hmac-sha1; compression: local none, remote none
   23:57:53 DEBUG Switch to new keys ...
   23:57:53 DEBUG Trying discovered key
 8d0aaca62fecf442ca7807b92061cd04 in /software/tools/reviewBoard/sites/
 reviews.example.com/data/.ssh/id_rsa
   23:57:53 DEBUG userauth is OK
   23:57:53 INFO Authentication (publickey) failed.
   23:57:53 DEBUG userauth is OK
   23:57:53 INFO Authentication (password) failed.
   23:57:53 DEBUG EOF in transport thread


 When I fill the subversion path:  svn+ssh://username@repo-path/dir1/
 dir2
 And I also fill Username and Password
 I got the error : ReviewBoard is taking a nap  or A repository
 was not found at the specified path
 The Log file is:

   00:34:33 DEBUG SVNTool: Attempting ssh connection with host:
 svn_host, username: username
00:34:33 DEBUG starting thread (client mode): 0x9b61c8cL
   00:34:33 INFO Connected (version 2.0, client Sun_SSH_1.1)
   00:34:33 DEBUG kex algos:['diffie-hellman-group-exchange-sha1',
 'diffie-hellman-group1-sha1'] server key:['ssh-rsa', 'ssh-dss'] client
 encrypt:['aes128-cbc', 'blowfish-cbc', '3des-cbc'] server encrypt:
 ['aes128-cbc', 'blowfish-cbc', '3des-cbc'] client mac:['hmac-sha1',
 'hmac-md5'] server mac:['hmac-sha1', 'hmac-md5'] client compress:
 ['none', 'zlib'] server compress:['none', 'zlib'] client lang:['en-
 CA', 'en-US', 'es', 'es-MX', 'fr', 'fr-CA', 'i-default'] server lang:
 ['en-CA', 'en-US', 'es', 'es-MX', 'fr', 'fr-CA', 'i-default'] kex
 follows?False
   00:34:33 DEBUG Ciphers agreed: local=aes128-cbc, remote=aes128-cbc
   00:34:33 DEBUG using kex diffie-hellman-group1-sha1; server key
 type ssh-rsa; cipher: local aes128-cbc, remote aes128-cbc; mac: local
 hmac-sha1, remote hmac-sha1; compression: local none, remote none
   00:34:33 DEBUG Switch to new keys ...
  00:34:33 DEBUG Trying discovered key
 8d0aaca62fecf442ca7807b92061cd04 in /software/tools/reviewBoard/sites/
 reviews.example.com/data/.ssh/id_rsa
  00:34:33 DEBUG userauth is OK
   00:34:34 INFO Authentication (publickey) failed.
   00:34:34 DEBUG userauth is OK
   00:34:34 INFO Authentication (password) successful!
   00:34:34 DEBUG EOF in transport thread
   00:34:35 ERROR SVN: Failed to get repository information for svn
 +ssh://username@repo-path/dir1/dir2: Connection closed unexpectedly


 Could somebody help me?
 I'm so desperate that I'm willing to pay for some support.
 Thank you.

 .


 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en


-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Migrated to a new server, now LDAP doesn't work

2011-11-10 Thread Christian Hammond
Can you tell me what change you made? I'd like to get a fix into a release.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Wed, Nov 9, 2011 at 11:45 PM, Nilesh Jaiswal nileshj...@gmail.comwrote:

 Its seems, you need to make the changes in the backends.py to add the
 filter for the LDAP user, I was also facing this issue then i add the
 filter and it started working for me


 On Tue, Nov 8, 2011 at 4:58 AM, Christian Hammond chip...@chipx86.comwrote:

 Hi,

 Are you just having trouble with API logins using post-review, or the
 website as well?

 There are some issues we haven't yet tracked down specifically with LDAP
 logins with the API. I honestly don't know what's going on there, and
 nobody who has such a setup has been able to debug enough to figure out the
 root cause.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com



 On Mon, Nov 7, 2011 at 2:41 PM, Mail Team email@gmail.com wrote:

 And the server is ReviewBoard 1.6.1 with Django 1.3.1, Djblets 0.6.13,
 django_evolution 0.6.5.

 Ian


 On Sun, Nov 6, 2011 at 1:13 AM, Mail Team email@gmail.com wrote:

 And the client was using Python 2.7 all along.  It was using RBTools
 0.3.3, I tried updating them to 0.3.4 but that didn't make a difference.

 Ian


 On Sun, Nov 6, 2011 at 1:12 AM, Mail Team email@gmail.com wrote:

 A bit more info:
 My old server used Python 2.6, my new server uses 2.7.

 $ post-review --debug -o dummyfile
  RBTools 0.3.4
  Home = /path/to/my/home
  svn info
  diff --version
  repository info: Path: svn+ssh://my.repository/url, Base path:
 /trunk, Supports changesets: False
  svn propget reviewboard:url /path/to/my/working/copy/trunk
  HTTP GETting api/
  HTTP GETting http://my.reviewboard.server/codereviews/api/info/
 == HTTP Authentication Required
 Enter authorization information for Web API at mailteam.apple.com
 Username: iana
 Password:
  Got API Error 103 (HTTP code 401): You are not logged in
  Error data: {u'stat': u'fail', u'err': {u'msg': u'You are not
 logged in', u'code': 103}}
 Unable to log in with the supplied username and password.

 When I use post-review as above, I do get some logs but they're not
 all that helpful to me.
 DEBUG Attempting authentication on API for user iana
 DEBUG API Login failed. No valid user found.

 On Sun, Nov 6, 2011 at 1:43 AM, Mail Team email@gmail.com wrote:

 I moved my Review Board installation to a new server via rb-site
 manage dumpdata/loaddata which seemed to go fine, but now LDAP logins 
 don't
 work.  If I go into the admin interface and click on Logs, there's 
 nothing.
  Any idea how I could debug this? Any silly gotchas that I might be 
 missing?

 Ian



  --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en


  --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en


  --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en


-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Review Board, Git and patch-series

2011-11-10 Thread Long VU
+1 vote for patch-series feature.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: SVN+SSH Problem

2011-11-10 Thread MonicaS
Christian,

WOW, that was the problem. I didn't have the id_rsa.pub key only
id_rsa. I generated them and them I
copy to my authorized_key on the subversion server after I tried using
the username, the connection worked fine
Thank you  very much.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: post-review

2011-11-10 Thread Stephen Gallagher
On Thu, 2011-11-10 at 13:29 -0800, Christian Hammond wrote:
 
 
 Good question.
 
 mod_wsgi is, it seems, the future of Python web service integration.
 It's become the de facto standard at this point. mod_python is dead,
 and fastcgi is not the most reliable thing out there (at least, we've
 hit many issues with it). So I think it wouldn't be terrible to depend
 on it, and it's certainly what we plan to support going forward. That
 said, people should always still be able to choose alternatives if it
 suits their needs. We'll just have different levels of support.


Well, adding an RPM dependency on mod_wsgi won't *prevent* them from
using something else, though it will mean that they are stuck with it on
their system even if they're using FastCGI. I guess I'm looking for an
answer to is it worth caring about?

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Issue 489 in reviewboard: [ ] DON'T SHIP IT button

2011-11-10 Thread reviewboard


Comment #31 on issue 489 by bela.lub...@gmail.com: [ ] DON'T SHIP IT button
http://code.google.com/p/reviewboard/issues/detail?id=489

[Hold] is good.   Per-reviewer flag, can be cleared by anyone (leaving a  
paper trail).  Any further semantic process needs to be handled by humans  
once the review has gotten into this sort of exception state.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 2380 in reviewboard: Setting e-mail won't blank out user name

2011-11-10 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2380 by jimcurti...@gmail.com: Setting e-mail won't blank out  
user name

http://code.google.com/p/reviewboard/issues/detail?id=2380

* NOTE: Do not post confidential information in this bug report. *
*   If you need immediate support, please contact*
*   reviewbo...@googlegroups.com *

What version are you running?

1.6

What's the URL of the page containing the problem?

http://hhcvm04.cup.hp.com/admin/settings/email/?saved=1

What steps will reproduce the problem?
1. Login as admin and go to the e-mail settings tab
2. Accidentally specify a user name and password and click save
3. Go back to this setting page and backspace over the user name and  
password to leave them blank and click save


What is the expected output? What do you see instead?

I would expect the message at the top saying the settings have been saved  
and the entry boxes for user name and password to remain blank.  I do get  
the message at the top saying the setting have been saved, but the entry  
boxes do not remain blank, they are instead filled with the username and  
password that I backspaced over.  This indicates that the blank values are  
not what was saved.



What operating system are you using? What browser?
 Centos 6.  Chrome

Please provide any additional information below.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2380 in reviewboard: Setting e-mail won't blank out user name

2011-11-10 Thread reviewboard


Comment #1 on issue 2380 by trowb...@gmail.com: Setting e-mail won't blank  
out user name

http://code.google.com/p/reviewboard/issues/detail?id=2380

It sounds a lot like your browser is auto-filling username and password  
fields.


We should probably turn off autofill for these fields.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2380 in reviewboard: Setting e-mail won't blank out user name

2011-11-10 Thread reviewboard


Comment #2 on issue 2380 by jimcurti...@gmail.com: Setting e-mail won't  
blank out user name

http://code.google.com/p/reviewboard/issues/detail?id=2380

You are correct.  I tried IE which doesn't autofill and it shows blank  
values.  Thanks.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.