How to use post-review with --file-list option.

Hi, We were using old post-review utility which was supporting following review option. parser.add_option("--file-list", dest="file_list", default=None, help="use file list instead of all files in changelist") parser.add_option("--ignore-diff-size",

Re: post-review throw diff error

If you are asking about the version path util then here it is. patch -version patch 2.5.4 Copyright 1984-1988 Larry Wall Copyright 1989-1999 Free Software Foundation, Inc. Please correct me if i am wrong. On Mon, May 14, 2012 at 10:43 AM, Nilesh Jaiswal wrote: > How to get the version of GNU pa

Re: post-review throw diff error

How to get the version of GNU patch. Are you asking about the version of post-review util.? On Mon, May 14, 2012 at 4:08 AM, Christian Hammond wrote: > Hi Nilesh, > > We run everything through GNU patch. That generally will handle the "\ No > newline at end of file". > > What version of GNU patch

Re: Final procedure for perforce integration?

Hi Neel, The procedure to get it into Review Board? We'd need a patch developed that worked with p4 ticketing but without breaking user/pass access, and it'd need to be uploaded to http://reviews.reviewboard.org/. We can then review it, and once we're satisfied, put it into a release. Christian

Re: Problem creating a review after upgrading to 1.6.6 on CentOS 5.8 (patch file too large?)

Hi, Sorry, been on vacation this week. I'm not sure if memcached provides an easy way to see what's in the cache. We don't have one. Sounds like memcached was the bottleneck, though, with only 128MB of RAM allocated. I'd definitely recommend more. Have you made changes since our last exchange, a

Re: Publishing a review request by a user other than the submitter

What's the use case you're going for? You may want to look at the "can_edit_reviewrequest" and "can_change_status" permissions. I think what you were trying were Django's generated permissions that were only for the database UI. Christian -- Christian Hammond - chip...@chipx86.com Review Board

Re: Problem with uploading consecutive diffs with updates

Hi Robert, Sorry for the late reply. I've been on vacation. I'm not sure I'm fully understanding the problem you're hitting. Let me see if I have this right. You have a changelist with some code in it. You sync, new changes are pulled in. You post the new changeset to Review Board, and the diff i

Re: Error while uploading Diff: Unable to parse diff revision header ' (revision 6886)'

Hi, What version of Review Board are you running? It looks like there are two tabs before the revision field, which we don't expect. We expect only one. I've never seen this before. What version of SVN? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.

Re: post-review throw diff error

Hi Nilesh, We run everything through GNU patch. That generally will handle the "\ No newline at end of file". What version of GNU patch is running on that server? What happens if you try to apply that same patch on a developer machine? Christian -- Christian Hammond - chip...@chipx86.com Revie

Re: /r in diff files

Hi, Newline normalization is very hard to get right at the best of times, and impossible at other times. When there's something like \r\n\n, it shows that there's a problem on the client side. Generally, it's due to your editor not handling it right, or your source control tools attempting its own