Re: post-review throw diff error
Yes this patch version 2.5.4 is running in my server.
I don't know how to patch that file locally with the same patch, Could you
help me with the step.
Kind Regards,
Nilesh
On Wed, May 16, 2012 at 11:05 AM, Christian Hammond chip...@chipx86.comwrote:
Hi Nilesh,
That version seems right, but I don't know why you're hitting that
problem. Was that the version of patch running on the server?
What happens if you try patching that file locally with the same patch?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Tue, May 15, 2012 at 9:52 PM, Nilesh Jaiswal nileshj...@gmail.comwrote:
Hi Chris,
Could you please provide me a solution to resolve the issue.
Regards,
Nilesh
On Mon, May 14, 2012 at 3:40 PM, Nilesh Jaiswal nileshj...@gmail.comwrote:
is this patch version mentioned in the email you are talking about.? Or
something else.
What do i need to do?
On Mon, May 14, 2012 at 10:48 AM, Nilesh Jaiswal
nileshj...@gmail.comwrote:
If you are asking about the version path util then here it is.
patch -version
patch 2.5.4
Copyright 1984-1988 Larry Wall
Copyright 1989-1999 Free Software Foundation, Inc.
Please correct me if i am wrong.
On Mon, May 14, 2012 at 10:43 AM, Nilesh Jaiswal
nileshj...@gmail.comwrote:
How to get the version of GNU patch. Are you asking about the version
of post-review util.?
On Mon, May 14, 2012 at 4:08 AM, Christian Hammond
chip...@chipx86.com wrote:
Hi Nilesh,
We run everything through GNU patch. That generally will handle the
\ No newline at end of file.
What version of GNU patch is running on that server? What happens if
you try to apply that same patch on a developer machine?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Thu, May 10, 2012 at 12:06 AM, Nilesh Jaiswal
nileshj...@gmail.com wrote:
Dear All,
I have posted the queries on this but i haven't got any answer hence
i am raising this queries again.
After posting review request and then clicking on viewdiff link on
RB server i get following error message for the files.
The patch to
'//sdm/DEV/V14_2_App/XSDGFDH/portals/sidadfds/resources/ApplicationManager.js'
didn't apply cleanly. The temporary files have been left in
'/tmp/reviewboard.pgHnuQ' for debugging purposes. `patch` returned:
patching file /tmp/reviewboard.pgHnuQ/tmpVIuwIQ Hunk #2 FAILED at 931. 1
out of 2 hunks FAILED -- saving rejects to file
/tmp/reviewboard.pgHnuQ/tmpVIuwIQ-new.rej
After looking into the /tmp/reviewboard.pgHnuQ/tmpVIuwIQ-new.rejor
diff file in /tmp of RB server its says
Pasting diff snippet which contains the following string (*\ No
newline at end of file*) in
ActionStatusEventHandlerThread.java.diff which has caused the diff
error.
why can we not handle such cases in viewdiff.py script. Do we have any
patch for the same. I would appreciate if you could provide me solution
that will solve 100's of such failure issues.
private void log(Exception e) {
@@ -86,4 +93,4 @@ public class ActionStatusEventHandlerThr
return ActionStatusEventHandlerThread;
}
-}
+}
*\ No newline at end of file*
Regards,
Nilesh J
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate
Diff fie size limited to 1 MB
Hi, With the release of Review Board (1.6.6), the diff file size is limited to 1MB only. Since my setup has a limit of 15MB with earlier version and with the latest update I am facing problems How can it be increased to say atleast to 10MB. thanks Ashish -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Diff fie size limited to 1 MB
Hi Ashish, What's the size you're hitting with your diffs, and what's in them? Diffs that are megabytes in size are generally impossible to review. I'll look at making the limit flexible, but I want to better understand the problems people are hitting. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, May 16, 2012 at 5:14 AM, Ashish Sharma ashiish.sha...@gmail.comwrote: Hi, With the release of Review Board (1.6.6), the diff file size is limited to 1MB only. Since my setup has a limit of 15MB with earlier version and with the latest update I am facing problems How can it be increased to say atleast to 10MB. thanks Ashish -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review throw diff error
Get the file from the repository (we use p4 print //depot/path/to/file#rev
for this), get the diff (just for that file), and then do:
patch -p0 diff-filename
You may need to tell it the location of the file, since it may not find it.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Tue, May 15, 2012 at 11:28 PM, Nilesh Jaiswal nileshj...@gmail.comwrote:
Yes this patch version 2.5.4 is running in my server.
I don't know how to patch that file locally with the same patch, Could you
help me with the step.
Kind Regards,
Nilesh
On Wed, May 16, 2012 at 11:05 AM, Christian Hammond
chip...@chipx86.comwrote:
Hi Nilesh,
That version seems right, but I don't know why you're hitting that
problem. Was that the version of patch running on the server?
What happens if you try patching that file locally with the same patch?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Tue, May 15, 2012 at 9:52 PM, Nilesh Jaiswal nileshj...@gmail.comwrote:
Hi Chris,
Could you please provide me a solution to resolve the issue.
Regards,
Nilesh
On Mon, May 14, 2012 at 3:40 PM, Nilesh Jaiswal nileshj...@gmail.comwrote:
is this patch version mentioned in the email you are talking about.? Or
something else.
What do i need to do?
On Mon, May 14, 2012 at 10:48 AM, Nilesh Jaiswal
nileshj...@gmail.comwrote:
If you are asking about the version path util then here it is.
patch -version
patch 2.5.4
Copyright 1984-1988 Larry Wall
Copyright 1989-1999 Free Software Foundation, Inc.
Please correct me if i am wrong.
On Mon, May 14, 2012 at 10:43 AM, Nilesh Jaiswal nileshj...@gmail.com
wrote:
How to get the version of GNU patch. Are you asking about the version
of post-review util.?
On Mon, May 14, 2012 at 4:08 AM, Christian Hammond
chip...@chipx86.com wrote:
Hi Nilesh,
We run everything through GNU patch. That generally will handle the
\ No newline at end of file.
What version of GNU patch is running on that server? What happens if
you try to apply that same patch on a developer machine?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Thu, May 10, 2012 at 12:06 AM, Nilesh Jaiswal
nileshj...@gmail.com wrote:
Dear All,
I have posted the queries on this but i haven't got any answer
hence i am raising this queries again.
After posting review request and then clicking on viewdiff link on
RB server i get following error message for the files.
The patch to
'//sdm/DEV/V14_2_App/XSDGFDH/portals/sidadfds/resources/ApplicationManager.js'
didn't apply cleanly. The temporary files have been left in
'/tmp/reviewboard.pgHnuQ' for debugging purposes. `patch` returned:
patching file /tmp/reviewboard.pgHnuQ/tmpVIuwIQ Hunk #2 FAILED at 931.
1
out of 2 hunks FAILED -- saving rejects to file
/tmp/reviewboard.pgHnuQ/tmpVIuwIQ-new.rej
After looking into the /tmp/reviewboard.pgHnuQ/tmpVIuwIQ-new.rejor
diff file in /tmp of RB server its says
Pasting diff snippet which contains the following string (*\ No
newline at end of file*) in
ActionStatusEventHandlerThread.java.diff which has caused the diff
error.
why can we not handle such cases in viewdiff.py script. Do we have any
patch for the same. I would appreciate if you could provide me solution
that will solve 100's of such failure issues.
private void log(Exception e) {
@@ -86,4 +93,4 @@ public class ActionStatusEventHandlerThr
return ActionStatusEventHandlerThread;
}
-}
+}
*\ No newline at end of file*
Regards,
Nilesh J
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
Re: Review Request not published
Hi Christian, I attached the headers and data for a publish and for a discard. I used the Live http headers and httpfox add-on for iceweasel to capture them. Hope that helps. Cheers - Geert -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=enhttp://nzchswreviews.au.ivc/api/review-requests/4310/reviews/draft/?api_format=json GET /api/review-requests/4310/reviews/draft/?api_format=json HTTP/1.1 Host: nzchswreviews.au.ivc User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/2008 Iceweasel/3.5.16 (like Firefox/3.5.16) Accept: application/json, text/javascript, */* Accept-Language: en,en-us;q=0.5 Accept-Encoding: true Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7 Keep-Alive: 300 Connection: keep-alive X-Requested-With: XMLHttpRequest Referer: http://nzchswreviews.au.ivc/r/4310/ Cookie: rbsessionid=f63f634a35eb85f86e939f2d791ca43a; csrftoken=397c8540a69626cc3c3b077e4e921446; collapsediffs=True If-Modified-Since: Wed, 16 May 2012 19:51:13 GMT HTTP/1.1 301 MOVED PERMANENTLY Date: Wed, 16 May 2012 19:52:16 GMT Server: Apache/2.2.20 (Ubuntu) Content-Language: en-us Expires: Wed, 16 May 2012 19:52:16 GMT Vary: Accept,Cookie,Accept-Language Cache-Control: max-age=0 Content-Length: 14 Last-Modified: Wed, 16 May 2012 19:52:16 GMT Location: http://nzchswreviews.au.ivc/api/review-requests/4310/reviews/6631/?api_format=json Keep-Alive: timeout=5, max=100 Connection: Keep-Alive Content-Type: application/vnd.reviewboard.org.review-draft+json -- http://nzchswreviews.au.ivc/api/review-requests/4310/reviews/6631/?api_format=json GET /api/review-requests/4310/reviews/6631/?api_format=json HTTP/1.1 Host: nzchswreviews.au.ivc User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/2008 Iceweasel/3.5.16 (like Firefox/3.5.16) Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8 Accept-Language: en,en-us;q=0.5 Accept-Encoding: true Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7 Keep-Alive: 300 Connection: keep-alive Referer: http://nzchswreviews.au.ivc/r/4310/ Cookie: rbsessionid=f63f634a35eb85f86e939f2d791ca43a; csrftoken=397c8540a69626cc3c3b077e4e921446; collapsediffs=True If-Modified-Since: Wed, 16 May 2012 02:21:52 GMT HTTP/1.1 304 NOT MODIFIED Date: Wed, 16 May 2012 19:52:16 GMT Server: Apache/2.2.20 (Ubuntu) Connection: Keep-Alive Keep-Alive: timeout=5, max=99 Expires: Wed, 16 May 2012 19:52:16 GMT Cache-Control: max-age=0 Vary: Accept,Cookie,Accept-Language,Accept-Encoding -- http://nzchswreviews.au.ivc/api/review-requests/4310/reviews/draft/?api_format=json GET /api/review-requests/4310/reviews/draft/?api_format=json HTTP/1.1 Host: nzchswreviews.au.ivc User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/2008 Iceweasel/3.5.16 (like Firefox/3.5.16) Accept: application/json, text/javascript, */* Accept-Language: en,en-us;q=0.5 Accept-Encoding: true Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7 Keep-Alive: 300 Connection: keep-alive X-Requested-With: XMLHttpRequest Referer: http://nzchswreviews.au.ivc/r/4310/ Cookie: rbsessionid=f63f634a35eb85f86e939f2d791ca43a; csrftoken=397c8540a69626cc3c3b077e4e921446; collapsediffs=True If-Modified-Since: Wed, 16 May 2012 19:52:16 GMT HTTP/1.1 301 MOVED PERMANENTLY Date: Wed, 16 May 2012 19:52:46 GMT Server: Apache/2.2.20 (Ubuntu) Content-Language: en-us Expires: Wed, 16 May 2012 19:52:46 GMT Vary: Accept,Cookie,Accept-Language Cache-Control: max-age=0 Content-Length: 14 Last-Modified: Wed, 16 May 2012 19:52:46 GMT Location: http://nzchswreviews.au.ivc/api/review-requests/4310/reviews/6631/?api_format=json Keep-Alive: timeout=5, max=100 Connection: Keep-Alive Content-Type: application/vnd.reviewboard.org.review-draft+json -- http://nzchswreviews.au.ivc/api/review-requests/4310/reviews/6631/?api_format=json GET /api/review-requests/4310/reviews/6631/?api_format=json HTTP/1.1 Host: nzchswreviews.au.ivc User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/2008 Iceweasel/3.5.16 (like Firefox/3.5.16) Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8 Accept-Language: en,en-us;q=0.5 Accept-Encoding: true Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7 Keep-Alive: 300 Connection: keep-alive Referer: http://nzchswreviews.au.ivc/r/4310/ Cookie: rbsessionid=f63f634a35eb85f86e939f2d791ca43a; csrftoken=397c8540a69626cc3c3b077e4e921446; collapsediffs=True If-Modified-Since: Wed, 16 May 2012 02:21:52 GMT HTTP/1.1 304 NOT MODIFIED Date: Wed, 16 May 2012 19:52:46 GMT
Re: Review Request not published
Hi Geert, Hmmm so the publish.data and discard.data is what the addon is showing what's coming back from the server? Because if so, there's something very wrong here. That's XML data, and we're requesting JSON. I wonder if you could install Firebug and reproduce just to make sure that's not some bug with those addons not preserving the ?api_format=json. If those are indeed what you're getting back, we'll need to figure out how this is possibly happening. Are you in any way behind a proxy? Is Review Board in the exception list? I wouldn't expect a proxy to strip these arguments, but just something to check. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, May 16, 2012 at 1:02 PM, Geert Linders glind...@dynamiccontrols.com wrote: Hi Christian, I attached the headers and data for a publish and for a discard. I used the Live http headers and httpfox add-on for iceweasel to capture them. Hope that helps. Cheers - Geert -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Review Request not published
Hi Christian, I upgraded my Iceweasel to install Firebug. Now after the upgrade the problem has gone away, so I can't produce the logs you want anymore. Sorry about that. Is there anything else I can do for you to help? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Review Request not published
Hi Geert, I wondered about that. I imagine there was some bug with Iceweasel causing that. Based on the Firefox version it claimed to be based off of, it's below our minimum supported browser requirements anyway. So if it works now, awesome :) Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, May 16, 2012 at 4:36 PM, Geert Linders glind...@dynamiccontrols.com wrote: Hi Christian, I upgraded my Iceweasel to install Firebug. Now after the upgrade the problem has gone away, so I can't produce the logs you want anymore. Sorry about that. Is there anything else I can do for you to help? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Problem creating a review after upgrading to 1.6.6 on CentOS 5.8 (patch file too large?)
I know I previously looked to see if I could get memcached to report what it has cached, but I didn't find anything. Eric On May 14, 2012, at 12:53 AM, Christian Hammond chip...@chipx86.com wrote: Hi, Sorry, been on vacation this week. I'm not sure if memcached provides an easy way to see what's in the cache. We don't have one. Sounds like memcached was the bottleneck, though, with only 128MB of RAM allocated. I'd definitely recommend more. Have you made changes since our last exchange, and if so, is it any better? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, May 7, 2012 at 2:53 PM, Alfred von Campe alf...@von-campe.com wrote: On May 7, 2012, at 16:56, Christian Hammond wrote: Memory and how much of it that memcached can use is crucial. We cache a *lot*, since fetching files from the repository, patching them, and generating diffs is all very expensive. So the more that memcached can hold at once, the faster things will feel all around. After that, you'll get some gains from database optimization and from increased CPU performance (for the diff generation). That's good to know. How big is your userbase, and what are your current specs? I know of servers with thousands of users that stand up under constant use. Usually it's just a configuration issue, or lack of memory for caching, that causes the most problems. A few dozen users and about 15 repos. It's on an older IBM xServer 335 with a 3.06GHz Intel Xeon CPU and 2GB or memory with 128MB configured for memcached. I've only recently enabled memcached, so I'm not 100% certain it is configured properly. Is there a way to query it to see what it has cached? Alfred -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
