Re: HOW to avoiding publishing a review request if no user present in people/group
I am talking about UI only. I am still able to publish without assigning people/groups. I used post-review -c changelist This gave me UI link also opened web UI with people/group field empty, when i pressed publish it proceeded with informing user. How to avoid it, is there any Admin setting which i need to configure to avoid such operation. On Sat, Jun 16, 2012 at 2:16 AM, David Trowbridge trowb...@gmail.comwrote: If there are no assigned people or groups, it already will prevent publishing (at least through the web UI; I'm not sure about post-review -p). -David On Fri, Jun 15, 2012 at 6:39 AM, Nilesh Jaiswal nileshj...@gmail.com wrote: Hi All, Can you provide me rule which will avoid publishing review request if the people/group list is empty. Regards, Nilesh -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post review for a specific mercurial changeset
On Friday 15 June 2012 10:50:07 pm TP wrote: Hi, We're using hg postreview extension with RB. How do we submit a review for a specific changeset if we've multiple outgoing changesets? For example, if we have local changesets 1, 2, 3 and I want to submit a review for 2. Running hg postreview 2 would include all three changesets. Thanks! Only 2 will be sent for review. 1 will also be sent but only as a parent diff. Regards. Gilles. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: HOW to avoiding publishing a review request if no user present in people/group
Review Board doesn't allow publishing if there's no user or group, and never has. This sounds like a local modification, if it's allowing it. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sat, Jun 16, 2012 at 1:11 AM, Nilesh Jaiswal nileshj...@gmail.comwrote: I am talking about UI only. I am still able to publish without assigning people/groups. I used post-review -c changelist This gave me UI link also opened web UI with people/group field empty, when i pressed publish it proceeded with informing user. How to avoid it, is there any Admin setting which i need to configure to avoid such operation. On Sat, Jun 16, 2012 at 2:16 AM, David Trowbridge trowb...@gmail.comwrote: If there are no assigned people or groups, it already will prevent publishing (at least through the web UI; I'm not sure about post-review -p). -David On Fri, Jun 15, 2012 at 6:39 AM, Nilesh Jaiswal nileshj...@gmail.com wrote: Hi All, Can you provide me rule which will avoid publishing review request if the people/group list is empty. Regards, Nilesh -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
A repository was not found at the specified path CVS Reviewboard 1.6.9 MOD-WSGI
Hi, I could successfully install Reviewboard on Ubuntu . I am new to linux,python wsgi etc. even then by following the user guide I could unstall Reviewbord. But while adding the cvs repository getting the 'A repository was not found at the specified path.' The url is given as :pserver:username:password@serveraddress:port/cvsroot THe mod I selected while installing reviewboard is WSGI. I have been trying for the past 1 week with various option but no luck. Could any one help me with step by step procedure . Thanks in advance. Augba -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Can't seem to connect to pserver CVS repository
I too facing the same issue. Please let me know if you have the steps working. On Friday, April 13, 2012 8:45:12 PM UTC+5:30, sagar wrote: Using ReviewBoard version 1.6.5 I've tried the following: *:pserver:user:pass@repo-url:/path/to/repo* ** *:pserver:user@repo-url:/path/to/repo* ** *:pserver:repo-url:/path/to/repo* all with and without the username/password fields filled in. I always get the error: A repository was not found at the specified path. I'm at a loss. Any ideas on what this could be? I can use the command line on the machine to go to the same repository and checkout stuff, using the same URIs, and username and password. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Upgraded OS , then ReviewBoard failed upgrade
Didn't touch the apache config. It's a http - https redirect (no idea why the browser isn't simply following it, do ajax requests eat the 301 errors? I can't remember). This is a brand new draft. On Saturday, June 16, 2012 9:31:26 PM UTC-4, Christian Hammond wrote: Hi Dan, It looks like it's redirecting to the URL it's already at? Is that right? Do any URLs but that cause a redirect? Was this an existing draft in the database, or a brand new one? And also, did you have to reconfigure the settings/Apache configuration at all, or is that all the same from before? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sat, Jun 16, 2012 at 4:53 PM, Dan Dumont ddum...@gmail.com wrote: Hi Christian, I got things mostly up and running again by reconstructing the sql tables in a new 1.5.5 install and then upgrading that. Having some difficulty at the site though. Many different api problems it looks like. I can't publish drafts, getting a 301: OPTIONS /api/review-requests/5335/draft/ HTTP/1.1 Host: reviews.apache.org Connection: keep-alive Access-Control-Request-Method: PUT Origin: https://reviews.apache.org User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/536.11 (KHTML, like Gecko) Chrome/20.0.1132.34 Safari/536.11 Access-Control-Request-Headers: origin, x-requested-with, content-type, accept Accept: */* Accept-Encoding: gzip,deflate,sdch Accept-Language: en-US,en;q=0.8 Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.3 - HTTP/1.1 301 Moved Permanently Date: Sat, 16 Jun 2012 23:51:28 GMT Server: Apache/2.2.20 (Ubuntu) Location: https://reviews.apache.org/api/review-requests/5335/draft/ Vary: Accept-Encoding Content-Encoding: gzip Content-Length: 263 Keep-Alive: timeout=5, max=100 Connection: Keep-Alive Content-Type: text/html; charset=iso-8859-1 Can you help me troubleshoot this? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Upgraded OS , then ReviewBoard failed upgrade
Ahh ok. So a bit more info: http://stackoverflow.com/questions/228225/prevent-redirection-of-xmlhttprequest If the origin of the URL conveyed by the Location header is same origin with the XMLHttpRequest origin and the redirect does not violate infinite loop precautions, transparently follow the redirect while observing the same-origin request event rules. I'm assuming origin here works the same as normal SOP browser stuff, so http - https will break. How are you crafting the api url for the post (not all the api calls fail, some of them are flaky occasionally though). Do you use a protocol relative url? //reviews.apache.org/path/to/api or do you build it off of some variable in the config? On Saturday, June 16, 2012 9:37:11 PM UTC-4, Dan Dumont wrote: Didn't touch the apache config. It's a http - https redirect (no idea why the browser isn't simply following it, do ajax requests eat the 301 errors? I can't remember). This is a brand new draft. On Saturday, June 16, 2012 9:31:26 PM UTC-4, Christian Hammond wrote: Hi Dan, It looks like it's redirecting to the URL it's already at? Is that right? Do any URLs but that cause a redirect? Was this an existing draft in the database, or a brand new one? And also, did you have to reconfigure the settings/Apache configuration at all, or is that all the same from before? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sat, Jun 16, 2012 at 4:53 PM, Dan Dumont ddum...@gmail.com wrote: Hi Christian, I got things mostly up and running again by reconstructing the sql tables in a new 1.5.5 install and then upgrading that. Having some difficulty at the site though. Many different api problems it looks like. I can't publish drafts, getting a 301: OPTIONS /api/review-requests/5335/draft/ HTTP/1.1 Host: reviews.apache.org Connection: keep-alive Access-Control-Request-Method: PUT Origin: https://reviews.apache.org User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/536.11 (KHTML, like Gecko) Chrome/20.0.1132.34 Safari/536.11 Access-Control-Request-Headers: origin, x-requested-with, content-type, accept Accept: */* Accept-Encoding: gzip,deflate,sdch Accept-Language: en-US,en;q=0.8 Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.3 - HTTP/1.1 301 Moved Permanently Date: Sat, 16 Jun 2012 23:51:28 GMT Server: Apache/2.2.20 (Ubuntu) Location: https://reviews.apache.org/api/review-requests/5335/draft/ Vary: Accept-Encoding Content-Encoding: gzip Content-Length: 263 Keep-Alive: timeout=5, max=100 Connection: Keep-Alive Content-Type: text/html; charset=iso-8859-1 Can you help me troubleshoot this? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Upgraded OS , then ReviewBoard failed upgrade
Request URL:
https://reviews.apache.org/api/review-requests/5345/?api_format=json
responds:
1. review_request: {status:pending, last_updated:2012-06-17 02:58:20,
description:,…}
1. branch:
2. bugs_closed: []
3. changenum: null
4. description:
5. id: 5345
6. last_updated: 2012-06-17 02:58:20
7. links:
{diffs:{href:http://reviews.apache.org/api/review-requests/5345/diffs/,
method:GET},…}
1. changes:
{href:http://reviews.apache.org/api/review-requests/5345/changes/,
method:GET}
1. href:
http://reviews.apache.org/api/review-requests/5345/changes/;
2. method: GET
2. delete: {href:http://reviews.apache.org/api/review-requests/5345/,
method:DELETE}
1. href: http://reviews.apache.org/api/review-requests/5345/;
2. method: DELETE
3. diffs:
{href:http://reviews.apache.org/api/review-requests/5345/diffs/,
method:GET}
1. href:
http://reviews.apache.org/api/review-requests/5345/diffs/;
2. method: GET
4. draft:
{href:http://reviews.apache.org/api/review-requests/5345/draft/,
method:GET}
1. href:
http://reviews.apache.org/api/review-requests/5345/draft/;
2. method: GET
5. file_attachments:
{href:http://reviews.apache.org/api/review-requests/5345/file-attachments/,
method:GET}
1. href:
http://reviews.apache.org/api/review-requests/5345/file-attachments/;
2. method: GET
6. last_update:
{href:http://reviews.apache.org/api/review-requests/5345/last-update/,
method:GET}
1. href:
http://reviews.apache.org/api/review-requests/5345/last-update/;
2. method: GET
7. repository: {href:http://reviews.apache.org/api/repositories/11/,
method:GET, title:shindig}
1. href: http://reviews.apache.org/api/repositories/11/;
2. method: GET
3. title: shindig
8. reviews:
{href:http://reviews.apache.org/api/review-requests/5345/reviews/,
method:GET}
1. href:
http://reviews.apache.org/api/review-requests/5345/reviews/;
2. method: GET
9. screenshots:
{href:http://reviews.apache.org/api/review-requests/5345/screenshots/,
method:GET}
1. href:
http://reviews.apache.org/api/review-requests/5345/screenshots/;
2. method: GET
10. self: {href:http://reviews.apache.org/api/review-requests/5345/,
method:GET}
1. href: http://reviews.apache.org/api/review-requests/5345/;
2. method: GET
11. submitter: {href:http://reviews.apache.org/api/users/ddumont/,
method:GET, title:ddumont}
1. href: http://reviews.apache.org/api/users/ddumont/;
2. method: GET
3. title: ddumont
12. update: {href:http://reviews.apache.org/api/review-requests/5345/,
method:PUT}
1. href: http://reviews.apache.org/api/review-requests/5345/;
2. method: PUT
8. public: false
9. status: pending
10. summary:
11. target_groups: []
12. target_people: []
13. testing_done:
14. time_added: 2012-06-17 02:58:19
2. stat: ok
Is there a setting I'm missing that controls the protocol?
On Saturday, June 16, 2012 9:50:36 PM UTC-4, Dan Dumont wrote:
Ahh ok. So a bit more info:
http://stackoverflow.com/questions/228225/prevent-redirection-of-xmlhttprequest
If the origin of the URL conveyed by the Location header is same
origin with the XMLHttpRequest origin and the redirect does not
violate infinite loop precautions, transparently follow the
redirect while observing the same-origin request event rules.
I'm assuming origin here works the same as normal SOP browser stuff, so
http - https will break.
How are you crafting the api url for the post (not all the api calls fail,
some of them are flaky occasionally though). Do you use a protocol
relative url? //reviews.apache.org/path/to/api
or do you build it off of some variable in the config?
On Saturday, June 16, 2012 9:37:11 PM UTC-4, Dan Dumont wrote:
Didn't touch the apache config.
It's a http - https redirect (no idea why the browser isn't simply
following it, do ajax requests eat the 301 errors? I can't remember).
This is a brand new draft.
On Saturday, June 16, 2012 9:31:26 PM UTC-4, Christian Hammond wrote:
Hi Dan,
It looks like it's redirecting to the URL it's already at? Is that right?
Do any URLs but that cause a redirect?
Was this an existing draft in the database, or a brand new one?
And also, did you have to reconfigure the settings/Apache configuration
at all, or is that all the same from before?
Christian
--
Christian Hammond - chip...@chipx86.com
Review
Re: Upgraded OS , then ReviewBoard failed upgrade
I found
https://groups.google.com/forum/?fromgroups#!topic/reviewboard/yIOamU1uvIY
But I tried setting
os.environ['HTTPS'] = on
In the reviewboard.wsgi file, but no dice. I'm pretty sure we have a
reverse proxy of some sort in front of us terminating SSL at the the border.
Would be nice if you guys could just return protocol relative urls
//reviewboard.apache.org/etc...
Any advice on where to stick that config setting to force https urls?
On Saturday, June 16, 2012 11:16:27 PM UTC-4, Dan Dumont wrote:
Request URL:
https://reviews.apache.org/api/review-requests/5345/?api_format=json
responds:
1. review_request: {status:pending, last_updated:2012-06-17 02:58:20,
description:,…}
1. branch:
2. bugs_closed: []
3. changenum: null
4. description:
5. id: 5345
6. last_updated: 2012-06-17 02:58:20
7. links: {diffs:{href:
http://reviews.apache.org/api/review-requests/5345/diffs/,
method:GET},…}
1. changes: {href:
http://reviews.apache.org/api/review-requests/5345/changes/,
method:GET}
1. href:
http://reviews.apache.org/api/review-requests/5345/changes/;
2. method: GET
2. delete: {href:
http://reviews.apache.org/api/review-requests/5345/,
method:DELETE}
1. href: http://reviews.apache.org/api/review-requests/5345/;
2. method: DELETE
3. diffs: {href:
http://reviews.apache.org/api/review-requests/5345/diffs/,
method:GET}
1. href:
http://reviews.apache.org/api/review-requests/5345/diffs/;
2. method: GET
4. draft: {href:
http://reviews.apache.org/api/review-requests/5345/draft/,
method:GET}
1. href:
http://reviews.apache.org/api/review-requests/5345/draft/;
2. method: GET
5. file_attachments: {href:
http://reviews.apache.org/api/review-requests/5345/file-attachments/,
method:GET}
1. href:
http://reviews.apache.org/api/review-requests/5345/file-attachments/
2. method: GET
6. last_update: {href:
http://reviews.apache.org/api/review-requests/5345/last-update/,
method:GET}
1. href:
http://reviews.apache.org/api/review-requests/5345/last-update/
2. method: GET
7. repository: {href:
http://reviews.apache.org/api/repositories/11/, method:GET,
title:shindig}
1. href: http://reviews.apache.org/api/repositories/11/;
2. method: GET
3. title: shindig
8. reviews: {href:
http://reviews.apache.org/api/review-requests/5345/reviews/,
method:GET}
1. href:
http://reviews.apache.org/api/review-requests/5345/reviews/;
2. method: GET
9. screenshots: {href:
http://reviews.apache.org/api/review-requests/5345/screenshots/,
method:GET}
1. href:
http://reviews.apache.org/api/review-requests/5345/screenshots/
2. method: GET
10. self: {href:
http://reviews.apache.org/api/review-requests/5345/, method:GET}
1. href: http://reviews.apache.org/api/review-requests/5345/;
2. method: GET
11. submitter: {href:http://reviews.apache.org/api/users/ddumont/,
method:GET, title:ddumont}
1. href: http://reviews.apache.org/api/users/ddumont/;
2. method: GET
3. title: ddumont
12. update: {href:
http://reviews.apache.org/api/review-requests/5345/, method:PUT}
1. href: http://reviews.apache.org/api/review-requests/5345/;
2. method: PUT
8. public: false
9. status: pending
10. summary:
11. target_groups: []
12. target_people: []
13. testing_done:
14. time_added: 2012-06-17 02:58:19
2. stat: ok
Is there a setting I'm missing that controls the protocol?
On Saturday, June 16, 2012 9:50:36 PM UTC-4, Dan Dumont wrote:
Ahh ok. So a bit more info:
http://stackoverflow.com/questions/228225/prevent-redirection-of-xmlhttprequest
If the origin of the URL conveyed by the Location header is same
origin with the XMLHttpRequest origin and the redirect does not
violate infinite loop precautions, transparently follow the
redirect while observing the same-origin request event rules.
I'm assuming origin here works the same as normal SOP browser stuff, so
http - https will break.
How are you crafting the api url for the post (not all the api calls
fail, some of them are flaky occasionally though). Do you use a protocol
relative url? //reviews.apache.org/path/to/api
or do you build it off of some
Issue 2639 in reviewboard: Appending 'undefined' to options.path
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 2639 by ddumont: Appending 'undefined' to options.path
http://code.google.com/p/reviewboard/issues/detail?id=2639
* NOTE: Do not post confidential information in this bug report. *
* If you need immediate support, please contact*
* reviewbo...@googlegroups.com *
What version are you running?
1.6.9
What's the URL of the page containing the problem?
https://reviewboard.apache.org
What steps will reproduce the problem?
_apiCall: function(options) {
var self = this;
options.prefix = this.prefix;
options.path = /review-requests/ + this.id + options.path;
if (!options.success) {
options.success = function() {
window.location = self.path;
};
}
rbApiCall(options);
}
I think you mean for the line to be:
options.path = /review-requests/ + this.id + (options.path || '');
I see 'undefined' being appended to the path member of the options object.
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2639 in reviewboard: Appending 'undefined' to options.path
Comment #1 on issue 2639 by ddumont: Appending 'undefined' to options.path http://code.google.com/p/reviewboard/issues/detail?id=2639 I see there's a similar function where that was already applied. Sorry for no files or line numbers, I'm doing this in the debugger. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2639 in reviewboard: Appending 'undefined' to options.path
Comment #2 on issue 2639 by ddumont: Appending 'undefined' to options.path http://code.google.com/p/reviewboard/issues/detail?id=2639 datastore.js:655 (in my browser, anyway) datastore.js:840 has this technique already employed. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
