Database upgrade issues

2012-12-28 Thread Christian Hammond
Hi guys,

I wanted to condense the three active threads on database upgrade issues.
The things you all have in common is that you're upgrading from older
versions using an older Django Evolution that all had a bug causing blank
hinted schema evolutions, which could cause problems when upgrading.

So for each of you still having the hinted evolution problem, can you do
the following:

1) Do a full SQL backup of your database
2) Run:

  $ rb-site manage /path/to/site shell
   from django_evolution.models import Version
   print Version.objects.all()

Paste that for me.

Now, here's where your backup comes in. Do this:

  $ rb-site manage /path/to/site shell
   from django_evolution.models import Version
   Version.objects.exclude(evolutions__pk__gt=0).delete()

Then re-do the rb-site upgrade, reload the web server, and see if that
works better. Test the site, make sure you don't have any database errors,
and report back.

I'm hoping this fixes the problem for you. If so, I can integrate this into
the upgrade process for future upgrades. (Not that you should ever hit this
again, since it's fixed in django-evolution.)

Christian


-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en




RB 1.6.12 upgrade to 1.7.1 is failed. Web (WSGI) problem.

2012-12-28 Thread Viktor Jozsa
Hi Christian,

I upgreaded my RB to 1.7.1. I don't found error in process, but my web page 
is not good.I attached the apache2.log and web page picture..

[Fri Dec 28 10:53:13 2012] [error] 
/usr/local/lib/python2.6/dist-packages/Django-1.4.3-py2.6.egg/django/template/defaulttags.py:1235:
 
DeprecationWarning: The syntax for the url template tag is changing. Load 
the `url` tag from the `future` tag library to start using the new behavior.
[Fri Dec 28 10:53:13 2012] [error]   category=DeprecationWarning)
[Fri Dec 28 11:53:14 2012] [error] 
/usr/local/lib/python2.6/dist-packages/Django-1.4.3-py2.6.egg/django/views/generic/simple.py:8:
 
DeprecationWarning: Function-based generic views have been deprecated; use 
class-based views instead.
[Fri Dec 28 11:53:14 2012] [error]   DeprecationWarning
[Fri Dec 28 10:53:19 2012] [error] 
/usr/local/lib/python2.6/dist-packages/Django-1.4.3-py2.6.egg/django/views/generic/list_detail.py:10:
 
DeprecationWarning: Function-based generic views have been deprecated; use 
class-based views instead.
[Fri Dec 28 10:53:19 2012] [error]   DeprecationWarning
[Fri Dec 28 10:53:19 2012] [error] 
/usr/local/lib/python2.6/dist-packages/Django-1.4.3-py2.6.egg/django/views/generic/list_detail.py:10:
 
DeprecationWarning: Function-based generic views have been deprecated; use 
class-based views instead.
[Fri Dec 28 10:53:19 2012] [error]   DeprecationWarning
[Fri Dec 28 10:53:19 2012] [error] 
/usr/local/lib/python2.6/dist-packages/Django-1.4.3-py2.6.egg/django/views/generic/list_detail.py:10:
 
DeprecationWarning: Function-based generic views have been deprecated; use 
class-based views instead.
[Fri Dec 28 10:53:19 2012] [error]   DeprecationWarning
[Fri Dec 28 10:53:19 2012] [error] 
/usr/local/lib/python2.6/dist-packages/Django-1.4.3-py2.6.egg/django/views/generic/list_detail.py:10:
 
DeprecationWarning: Function-based generic views have been deprecated; use 
class-based views instead.
[Fri Dec 28 10:53:19 2012] [error]   DeprecationWarning
[Fri Dec 28 10:53:19 2012] [error] 
/usr/local/lib/python2.6/dist-packages/Django-1.4.3-py2.6.egg/django/views/generic/list_detail.py:10:
 
DeprecationWarning: Function-based generic views have been deprecated; use 
class-based views instead.
[Fri Dec 28 10:53:19 2012] [error]   DeprecationWarning
[Fri Dec 28 10:53:19 2012] [error] 
/usr/local/lib/python2.6/dist-packages/Django-1.4.3-py2.6.egg/django/views/generic/list_detail.py:10:
 
DeprecationWarning: Function-based generic views have been deprecated; use 
class-based views instead.
[Fri Dec 28 10:53:19 2012] [error]   DeprecationWarning
[Fri Dec 28 11:53:20 2012] [error] 
/usr/local/lib/python2.6/dist-packages/Django-1.4.3-py2.6.egg/django/conf/__init__.py:75:
 
DeprecationWarning: The ADMIN_MEDIA_PREFIX setting has been removed; use 
STATIC_URL instead.
[Fri Dec 28 11:53:20 2012] [error]   use STATIC_URL instead., 
DeprecationWarning)
[Fri Dec 28 11:53:20 2012] [error] 
/usr/local/lib/python2.6/dist-packages/Django-1.4.3-py2.6.egg/django/conf/__init__.py:75:
 
DeprecationWarning: The ADMIN_MEDIA_PREFIX setting has been removed; use 
STATIC_URL instead.
[Fri Dec 28 11:53:20 2012] [error]   use STATIC_URL instead., 
DeprecationWarning)
[Fri Dec 28 11:53:20 2012] [error] 
/usr/local/lib/python2.6/dist-packages/Django-1.4.3-py2.6.egg/django/conf/__init__.py:75:
 
DeprecationWarning: The ADMIN_MEDIA_PREFIX setting has been removed; use 
STATIC_URL instead.
[Fri Dec 28 11:53:20 2012] [error]   use STATIC_URL instead., 
DeprecationWarning)
[Fri Dec 28 11:53:20 2012] [error] 
/usr/local/lib/python2.6/dist-packages/Django-1.4.3-py2.6.egg/django/conf/__init__.py:75:
 
DeprecationWarning: The ADMIN_MEDIA_PREFIX setting has been removed; use 
STATIC_URL instead.
[Fri Dec 28 11:53:20 2012] [error]   use STATIC_URL instead., 
DeprecationWarning)
[Fri Dec 28 11:53:20 2012] [error] 
/usr/local/lib/python2.6/dist-packages/Django-1.4.3-py2.6.egg/django/conf/__init__.py:75:
 
DeprecationWarning: The ADMIN_MEDIA_PREFIX setting has been removed; use 
STATIC_URL instead.
[Fri Dec 28 11:53:20 2012] [error]   use STATIC_URL instead., 
DeprecationWarning)
[Fri Dec 28 11:53:20 2012] [error] 
/usr/local/lib/python2.6/dist-packages/Django-1.4.3-py2.6.egg/django/template/defaulttags.py:1235:
 
DeprecationWarning: The syntax for the url template tag is changing. Load 
the `url` tag from the `future` tag library to start using the new behavior.
[Fri Dec 28 11:53:20 2012] [error]   category=DeprecationWarning)
[Fri Dec 28 11:53:20 2012] [error] 
/usr/local/lib/python2.6/dist-packages/Django-1.4.3-py2.6.egg/django/template/defaulttags.py:1235:
 
DeprecationWarning: The syntax for the url template tag is changing. Load 
the `url` tag from the `future` tag library to start using the new behavior.
[Fri Dec 28 11:53:20 2012] [error]   category=DeprecationWarning)
[Fri Dec 28 11:53:20 2012] [error] 
/usr/local/lib/python2.6/dist-packages/Django-1.4.3-py2.6.egg/django/template/defaulttags.py:1235:
 
DeprecationWarning: The 

Re: RB 1.6.12 upgrade to 1.7.1 is failed. Web (WSGI) problem.

2012-12-28 Thread Christian Hammond
Hi Viktor,

Those are all harmless errors. Just future deprecations Django is letting us 
know about.

It looks like the necessary static directory location changes that Review Board 
described during rb-site upgrade and on the Manual Updates page weren't made 
properly. Can you show me your Apache configuration file for the Review Board 
site?

Christian


On Dec 28, 2012, at 3:10 AM, Viktor Jozsa jozsa.vikt...@gmail.com wrote:

 Hi Christian,
 
 I upgreaded my RB to 1.7.1. I don't found error in process, but my web page 
 is not good.I attached the apache2.log and web page picture..
 
 [Fri Dec 28 10:53:13 2012] [error] 
 /usr/local/lib/python2.6/dist-packages/Django-1.4.3-py2.6.egg/django/template/defaulttags.py:1235:
  DeprecationWarning: The syntax for the url template tag is changing. Load 
 the `url` tag from the `future` tag library to start using the new behavior.
 [Fri Dec 28 10:53:13 2012] [error]   category=DeprecationWarning)
 [Fri Dec 28 11:53:14 2012] [error] 
 /usr/local/lib/python2.6/dist-packages/Django-1.4.3-py2.6.egg/django/views/generic/simple.py:8:
  DeprecationWarning: Function-based generic views have been deprecated; use 
 class-based views instead.
 [Fri Dec 28 11:53:14 2012] [error]   DeprecationWarning
 [Fri Dec 28 10:53:19 2012] [error] 
 /usr/local/lib/python2.6/dist-packages/Django-1.4.3-py2.6.egg/django/views/generic/list_detail.py:10:
  DeprecationWarning: Function-based generic views have been deprecated; use 
 class-based views instead.
 [Fri Dec 28 10:53:19 2012] [error]   DeprecationWarning
 [Fri Dec 28 10:53:19 2012] [error] 
 /usr/local/lib/python2.6/dist-packages/Django-1.4.3-py2.6.egg/django/views/generic/list_detail.py:10:
  DeprecationWarning: Function-based generic views have been deprecated; use 
 class-based views instead.
 [Fri Dec 28 10:53:19 2012] [error]   DeprecationWarning
 [Fri Dec 28 10:53:19 2012] [error] 
 /usr/local/lib/python2.6/dist-packages/Django-1.4.3-py2.6.egg/django/views/generic/list_detail.py:10:
  DeprecationWarning: Function-based generic views have been deprecated; use 
 class-based views instead.
 [Fri Dec 28 10:53:19 2012] [error]   DeprecationWarning
 [Fri Dec 28 10:53:19 2012] [error] 
 /usr/local/lib/python2.6/dist-packages/Django-1.4.3-py2.6.egg/django/views/generic/list_detail.py:10:
  DeprecationWarning: Function-based generic views have been deprecated; use 
 class-based views instead.
 [Fri Dec 28 10:53:19 2012] [error]   DeprecationWarning
 [Fri Dec 28 10:53:19 2012] [error] 
 /usr/local/lib/python2.6/dist-packages/Django-1.4.3-py2.6.egg/django/views/generic/list_detail.py:10:
  DeprecationWarning: Function-based generic views have been deprecated; use 
 class-based views instead.
 [Fri Dec 28 10:53:19 2012] [error]   DeprecationWarning
 [Fri Dec 28 10:53:19 2012] [error] 
 /usr/local/lib/python2.6/dist-packages/Django-1.4.3-py2.6.egg/django/views/generic/list_detail.py:10:
  DeprecationWarning: Function-based generic views have been deprecated; use 
 class-based views instead.
 [Fri Dec 28 10:53:19 2012] [error]   DeprecationWarning
 [Fri Dec 28 11:53:20 2012] [error] 
 /usr/local/lib/python2.6/dist-packages/Django-1.4.3-py2.6.egg/django/conf/__init__.py:75:
  DeprecationWarning: The ADMIN_MEDIA_PREFIX setting has been removed; use 
 STATIC_URL instead.
 [Fri Dec 28 11:53:20 2012] [error]   use STATIC_URL instead., 
 DeprecationWarning)
 [Fri Dec 28 11:53:20 2012] [error] 
 /usr/local/lib/python2.6/dist-packages/Django-1.4.3-py2.6.egg/django/conf/__init__.py:75:
  DeprecationWarning: The ADMIN_MEDIA_PREFIX setting has been removed; use 
 STATIC_URL instead.
 [Fri Dec 28 11:53:20 2012] [error]   use STATIC_URL instead., 
 DeprecationWarning)
 [Fri Dec 28 11:53:20 2012] [error] 
 /usr/local/lib/python2.6/dist-packages/Django-1.4.3-py2.6.egg/django/conf/__init__.py:75:
  DeprecationWarning: The ADMIN_MEDIA_PREFIX setting has been removed; use 
 STATIC_URL instead.
 [Fri Dec 28 11:53:20 2012] [error]   use STATIC_URL instead., 
 DeprecationWarning)
 [Fri Dec 28 11:53:20 2012] [error] 
 /usr/local/lib/python2.6/dist-packages/Django-1.4.3-py2.6.egg/django/conf/__init__.py:75:
  DeprecationWarning: The ADMIN_MEDIA_PREFIX setting has been removed; use 
 STATIC_URL instead.
 [Fri Dec 28 11:53:20 2012] [error]   use STATIC_URL instead., 
 DeprecationWarning)
 [Fri Dec 28 11:53:20 2012] [error] 
 /usr/local/lib/python2.6/dist-packages/Django-1.4.3-py2.6.egg/django/conf/__init__.py:75:
  DeprecationWarning: The ADMIN_MEDIA_PREFIX setting has been removed; use 
 STATIC_URL instead.
 [Fri Dec 28 11:53:20 2012] [error]   use STATIC_URL instead., 
 DeprecationWarning)
 [Fri Dec 28 11:53:20 2012] [error] 
 /usr/local/lib/python2.6/dist-packages/Django-1.4.3-py2.6.egg/django/template/defaulttags.py:1235:
  DeprecationWarning: The syntax for the url template tag is changing. Load 
 the `url` tag from the `future` tag library to start using the new behavior.
 [Fri Dec 28 11:53:20 2012] [error]   category=DeprecationWarning)
 [Fri Dec 28 11:53:20 

Re: Database upgrade issues

2012-12-28 Thread jacob.j.rosales
Hi Christian,

Here is what the output for the version

Python 2.7.1+ (r271:86832, Apr 11 2011, 18:13:53)
[GCC 4.5.2] on linux2
Type help, copyright, credits or license for more information.
(InteractiveConsole)
 from django_evolution.models import Version
 print Version.objects.all()
[Version: Hinted version, updated on 2012-12-27 19:00:56+00:00, Version: 
Hinted version, updated on 2012-10-25 05:40:26+00:00, Version: Stored 
version, updated on 2012-10-25 05:40:26+00:00, Version: Stored version, 
updated on 2011-08-08 17:07:01+00:00]


I was able to successfully execute the commands in step 2 and now have a 
working 1.7.1 RB!
A quick test does not show any issues as of yet, however I will keep an eye 
out for any.
Thank you for your time and assistance on resolving this issue! 

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en




Re: Database upgrade issues

2012-12-28 Thread jacob.j.rosales
Upon further testing, it seems something has changed with this release and 
LDAP authentication.
I was able to log into RB with a local user, however all LDAP users can not 
log in. Do you know what has changed with the LDAP backend authentication?
The RB log shows the following message

2012-12-28 06:30:38,031 - WARNING - LDAP error: The specified object does 
not exist in the Directory or provided invalid credentials: 
(emailAddress=user-email)

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en




Some noob questions...

2012-12-28 Thread Klaim J. Lamotte
Hi,

I am considering using this tool but I have some questions to clarify 
ReviewBoard usage.

Before the questions, just a quick note: the website states
Stable: 
1.7.1http://www.reviewboard.org/docs/releasenotes/dev/reviewboard/1.7.1/

In-development: 1.7 RC 
1http://www.reviewboard.org/docs/releasenotes/dev/reviewboard/1.7-rc-1/

Which is not very logical and don't really feel professional either... :)

0. The context I would use this is:
- I'm working alone for now
- I have some friends who can help by reviewing the code
- until now I just gave them access to the source code but it's not 
perfect to do reviews
   In this context, is there some specific feature you think would appeal 
to me in ReviewBoard? 
1. Can I use Mercurial and Git with 1.7.1? It is not clear from the 
documentation, I just see some discussions implying I can, but I didn't 
find explicit statements.
2. I'm using Rhodecode to manage my repositories. It have basic review 
support apparently. How does ReviewBoard compare?
3. How does ReviewBoard compare to Phabricator's review system and 
Atlassian's one? So far I have a hard time seeing any real difference other 
than the cost.
The problem is that I didn't use any such tool so far so I don't know 
what kind of feature are good or not.

Thanks for your time

Joel Lamotte


-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en




Re: Some noob questions...

2012-12-28 Thread Matthew Woehlke

On 2012-12-28 10:20, Klaim J. Lamotte wrote:

0. The context I would use this is:
 - I'm working alone for now
 - I have some friends who can help by reviewing the code
 - until now I just gave them access to the source code but it's not
perfect to do reviews
In this context, is there some specific feature you think would appeal
to me in ReviewBoard?


I think that would depend mainly on the degree of informality of your 
review process. If we're talking 'running commentary while looking over 
your shoulder', you probably don't need RB yet. If you want to keep a 
record of reviews, or even just have a structured mechanism for doing 
reviews, then RB will provide this.



1. Can I use Mercurial and Git with 1.7.1? It is not clear from the
documentation, I just see some discussions implying I can, but I didn't
find explicit statements.


I'm using RB with git. I haven't used it with hg, but AFAIK you can.


3. How does ReviewBoard compare to Phabricator's review system and
Atlassian's one? So far I have a hard time seeing any real difference other
than the cost.


Well, personally I'd have a hard time justifying spending money for a 
review tool unless I'm getting paid to write the software being 
reviewed. RB is free in both senses. (If you're willing to run your 
server on Fedora 18, RB 1.7.1 is even packaged by the distro.)


Since you mentioned hg, it's probably not an option anyway, but I'd stay 
away from gerrit; it's interface is absolute rubbish compared to RB.


--
Matthew

--
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en




Re: reviewboard upgrade

2012-12-28 Thread Christian Hammond
Hi,

Well, it looks like you have a matching version of Python, and you're able
to load the middleware that mod_python was complaining about. So in theory,
it should work, and that error isn't saying exactly which forms model
it's trying to load. Most likely, it's django.forms, which should also be
working if you're at this point. Sounds like a broken setup.

Repeat the same test above, but instead of that import, do:

from reviewboard.admin.middleware import InitReviewBoardMiddleware

Since you blew away your old database, you probably should also be creating
a new site directory. Did you want to do that, or try using your old
database and using the fix I outlined in my previous e-mail?

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Fri, Dec 28, 2012 at 12:07 PM, utku utkuyil...@gmail.com wrote:

 hello Christian, var/log/apache/error.log has not change after executing
 that command still the same error is there, output from the console is

  rb-site manage /var/www/reviewboard shell
 Python 2.6.6 (r266:84292, Oct  1 2012, 22:48:04)
 [GCC 4.5.2] on linux2
 Type help, copyright, credits or license for more information.
 (InteractiveConsole)
  import reviewboard.admin.middleware
  exit()

 i dont know my current version, but did succesfully easy_install -U
 ReviewBoard and rb-site upgrade /var/www/reviewboard which is i believe
 1.7.1 now
 atached is my mysql dump from empty database since i just deleted/created
 yesterday. Please let me know what information you need. Since i am kind of
 new, please include the exact folders and commands thanks...

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en




-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en




Re: Some noob questions...

2012-12-28 Thread Christian Hammond
On Fri, Dec 28, 2012 at 7:20 AM, Klaim J. Lamotte mjkl...@gmail.com wrote:

 Hi,


Hi!



 I am considering using this tool but I have some questions to clarify
 ReviewBoard usage.

 Before the questions, just a quick note: the website states
 Stable: 
 1.7.1http://www.reviewboard.org/docs/releasenotes/dev/reviewboard/1.7.1/

 In-development: 1.7 RC 
 1http://www.reviewboard.org/docs/releasenotes/dev/reviewboard/1.7-rc-1/

 Which is not very logical and don't really feel professional either... :)


Just a bug in how it computes it that got introduced. The site's being
rewritten but I'll backport this fix.




 0. The context I would use this is:
 - I'm working alone for now
 - I have some friends who can help by reviewing the code
 - until now I just gave them access to the source code but it's not
 perfect to do reviews
In this context, is there some specific feature you think would appeal
 to me in ReviewBoard?


I find with changes I'm writing, getting another pair of eyes really helps
to catch mistakes I've made. By putting code up for someone to review, even
if they're not writing code for the product, they may see something I
missed, or find a better way to do something I did. Or they might learn
something themselves, get a feel for my coding style, etc., which is useful
if they ever start writing code for it.



 1. Can I use Mercurial and Git with 1.7.1? It is not clear from the
 documentation, I just see some discussions implying I can, but I didn't
 find explicit statements.


Both are supported. And many more.



 2. I'm using Rhodecode to manage my repositories. It have basic review
 support apparently. How does ReviewBoard compare?


I don't know Rhodecode. I played around with it for a few minutes to see
how it compares. It looks pretty basic and standard so far. Here's what we
seem to have that it doesn't:

1) Side-by-side diffs. Some people like the top-down look, but a
side-by-side means we can do inline comments that span lines, better
indication of what changed within a line, and more.

2) Syntax highlighting. We syntax-highlight the source code, which makes it
easier to read.

3) In-line diffing. If a line of code changed (marked as a replace),
we'll show exactly what changed so you don't have to read the entire line.
It looks like Rhodecode is trying to do this, but it doesn't seem to work
very consistently.

4) Function/class context. We show you where you are in a diff. That is,
what function or class precedes the code you're looking at.

5) Diff expansion. We start off by showing you just the changed regions,
with some unchanged lines surrounding it. You can expand the collapsed
areas all at once, by 20 lines at a time, or expand up to the nearest
function or class.

6)  Move detection. We can show you when a block of code moves within a
file without being changed. Useful with large changes when you're moving
functions around.

7) Issue toggling. When someone leaves a comment, they can mark it as an
opened issue, which basically is a TODO item for you to fix. Makes ti
easier to separate general discussion from things you need to fix.

8) Image commenting. If you upload an image (screenshot or something),
people can make comments right on that. We're working to expand this to
other types of files as wel.

9) All comments across all files made by a user during a review are grouped
together into a single box. All discussions about those comments go there.
Every review gets its own box. It's easier to stay organized this way,
rather than just comments inline in code in places.

10) Posting a review request to Review Board is one command on the command
line, It can be done without pushing code to a central repository, allowing
for pre-commit reviews. More scripts are coming, and we have a full API
(REST API, and soon a Python API) for writing custom integration.

11) Extension support. While new, we've made Review Board extensible so
that other people, companies, and even us can provide loadable extensions
to enhance the feature set of Review Board without having to modify Review
Board itself.

There are other things we do, but I'll stop there.



 3. How does ReviewBoard compare to Phabricator's review system and
 Atlassian's one? So far I have a hard time seeing any real difference other
 than the cost.
 The problem is that I didn't use any such tool so far so I don't know
 what kind of feature are good or not.


I'm told Phabricator makes it really easy to include pictures of cats and
Jean-Luc Picard facepalm images. So if that's important, you can go with
them. I haven't heard anything else about how their system is to use.

I haven't used Atlassian's product. All I have there is second-hand
knowledge. I hear managers really like it because of all the tracking it
can do based on the required fields for users. I've heard from developers
that Review Board was easier for them to integrate into their workflow. I
think it's just up to what your needs are. 

Re: reviewboard upgrade

2012-12-28 Thread utku
what i want is just the get the reviewboard up first then i will try to 
merge the 1.6.4 database.
i already have a site /var/www/reviewboard and i just deleted and created 
the databse with mysql with the same name, so that site should be okay?
or should i run

rb-site install /var/www/reviewboard
which was already there?


i executed,
rb-site manage /var/www/reviewboard shell
Python 2.6.6 (r266:84292, Oct  1 2012, 22:48:04)
[GCC 4.5.2] on linux2
Type help, copyright, credits or license for more information.
(InteractiveConsole)


 from reviewboard.admin.middleware import InitReviewBoardMiddleware


 exit()

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en




python errors on upgrade to 1.7.1?

2012-12-28 Thread Randy Faux
Hello,

After upgrading from, I think 1.6.5, to 1.7.1 we are seeing some issues 
with our rb. I added the /static alias to the apache2 virtualhost, which 
got us mostly going. We're seeing errors of the type:

  ERROR:root:Exception thrown for user xx  at 
http://reviewboard.our.site/r/5/
  
  'NoneType' object is not callable
  Traceback (most recent call last):
File 
/usr/local/lib/python2.7/dist-packages/Django-1.4.3-py2.7.egg/django/core/handlers/base.py,
 
line 111, in get_response
  response = callback(request, *callback_args, **callback_kwargs)
File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.1-py2.7.egg/reviewboard/accounts/decorators.py,
 
line 20, in _check
  return login_required(view_func)(*args, **kwargs)
File 
/usr/local/lib/python2.7/dist-packages/Djblets-0.7.8-py2.7.egg/djblets/auth/util.py,
 
line 47, in _checklogin
  return view_func(request, *args, **kwargs)
File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.1-py2.7.egg/reviewboard/reviews/views.py,
 
line 728, in review_detail
  'screenshots': screenshots,
File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.1-py2.7.egg/reviewboard/reviews/views.py,
 
line 124, in _make_review_request_context
  upload_diff_form = UploadDiffForm(review_request)
File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.1-py2.7.egg/reviewboard/reviews/forms.py,
 
line 276, in __init__
  data, *args, **kwargs)
File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.1-py2.7.egg/reviewboard/diffviewer/forms.py,
 
line 51, in __init__
  if self.repository.get_scmtool().get_diffs_use_absolute_paths():
File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.1-py2.7.egg/reviewboard/scmtools/models.py,
 
line 134, in get_scmtool
  return cls(self)
File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.1-py2.7.egg/reviewboard/scmtools/hg.py,
 
line 31, in __init__
  self.client = HgClient(repository.path, repository.local_site)
File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.1-py2.7.egg/reviewboard/scmtools/hg.py,
 
line 215, in __init__
  if parse_version(version) = parse_version(1.2):
File /usr/lib/python2.7/dist-packages/pkg_resources.py, line 1956, in 
parse_version
  for part in _parse_version_parts(s.lower()):
  TypeError: 'NoneType' object is not callable
  ERROR:django.request:Internal Server Error: /r/5/
  Traceback (most recent call last):
File 
/usr/local/lib/python2.7/dist-packages/Django-1.4.3-py2.7.egg/django/core/handlers/base.py,
 
line 111, in get_response
  response = callback(request, *callback_args, **callback_kwargs)
File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.1-py2.7.egg/reviewboard/accounts/decorators.py,
 
line 20, in _check
  return login_required(view_func)(*args, **kwargs)
File 
/usr/local/lib/python2.7/dist-packages/Djblets-0.7.8-py2.7.egg/djblets/auth/util.py,
 
line 47, in _checklogin
  return view_func(request, *args, **kwargs)
File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.1-py2.7.egg/reviewboard/reviews/views.py,
 
line 728, in review_detail
  'screenshots': screenshots,
File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.1-py2.7.egg/reviewboard/reviews/views.py,
 
line 124, in _make_review_request_context
  upload_diff_form = UploadDiffForm(review_request)
File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.1-py2.7.egg/reviewboard/reviews/forms.py,
 
line 276, in __init__
  data, *args, **kwargs)
File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.1-py2.7.egg/reviewboard/diffviewer/forms.py,
 
line 51, in __init__
  if self.repository.get_scmtool().get_diffs_use_absolute_paths():
File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.1-py2.7.egg/reviewboard/scmtools/models.py,
 
line 134, in get_scmtool
  return cls(self)
File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.1-py2.7.egg/reviewboard/scmtools/hg.py,
 
line 31, in __init__
  self.client = HgClient(repository.path, repository.local_site)
File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.1-py2.7.egg/reviewboard/scmtools/hg.py,
 
line 215, in __init__
  if parse_version(version) = parse_version(1.2):
File /usr/lib/python2.7/dist-packages/pkg_resources.py, line 1956, in 
parse_version
  for part in _parse_version_parts(s.lower()):
  TypeError: 'NoneType' object is not callable

We are running on Ubuntu 12.04.1 x86_64 with python 2.7 installed. Here is 
our simple virtualhost:
VirtualHost *:80
ServerName reviewboard.our.site
DocumentRoot /var/www/rbsite/htdocs

# Error handlers
ErrorDocument 500 /errordocs/500.html

WSGIPassAuthorization On
WSGIScriptAlias / /var/www/rbsite/htdocs/reviewboard.wsgi/

Directory /var/www/rbsite/htdocs
AllowOverride All
Options -Indexes FollowSymLinks
Allow from all

Re: reviewboard upgrade

2012-12-28 Thread Christian Hammond
So, one of the reasons for creating a new site is to rule out some stale data 
somewhere. Plus, your old Apache configuration doesn't include the new updates 
that need to be made for 1.7 (adding /static/ paths, just like /media/), and 
since it's a new database, it won't tell you to make those changes (it thinks 
it's a fresh install and not an upgrade).

Since the import is working there, then there's some Python path or loader 
issue when it's running within Apache. One thing to try is mod_wsgi instead 
(mod_python is deprecated by Apache and by Django), just to rule out a 
mod_python issue. Perhaps your version is not built to work with Python 2.6?

Christian


On Dec 28, 2012, at 2:12 PM, utku utkuyil...@gmail.com wrote:

 what i want is just the get the reviewboard up first then i will try to merge 
 the 1.6.4 database.
 i already have a site /var/www/reviewboard and i just deleted and created the 
 databse with mysql with the same name, so that site should be okay?
 or should i run
 rb-site install /var/www/reviewboard
 which was already there?
 
 i executed,
 rb-site manage /var/www/reviewboard shell
 Python 2.6.6 (r266:84292, Oct  1 2012, 22:48:04)
 [GCC 4.5.2] on linux2
 Type help, copyright, credits or license for more information.
 (InteractiveConsole)
 
 
  from reviewboard.admin.middleware import InitReviewBoardMiddleware
 
 
  exit()
 
 
 -- 
 Want to help the Review Board project? Donate today at 
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to 
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at 
 http://groups.google.com/group/reviewboard?hl=en
  
  

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en




Re: python errors on upgrade to 1.7.1?

2012-12-28 Thread Christian Hammond
What version of Mercurial is on that system?

The problem is that we're getting the version of Mercurial and trying to test 
its version, but it's coming back None.

Christian


On Dec 28, 2012, at 4:19 PM, Randy Faux randy.f...@gmail.com wrote:

 Hello,
 
 After upgrading from, I think 1.6.5, to 1.7.1 we are seeing some issues with 
 our rb. I added the /static alias to the apache2 virtualhost, which got us 
 mostly going. We're seeing errors of the type:
 
   ERROR:root:Exception thrown for user xx  at 
 http://reviewboard.our.site/r/5/
   
   'NoneType' object is not callable
   Traceback (most recent call last):
 File 
 /usr/local/lib/python2.7/dist-packages/Django-1.4.3-py2.7.egg/django/core/handlers/base.py,
  line 111, in get_response
   response = callback(request, *callback_args, **callback_kwargs)
 File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.1-py2.7.egg/reviewboard/accounts/decorators.py,
  line 20, in _check
   return login_required(view_func)(*args, **kwargs)
 File 
 /usr/local/lib/python2.7/dist-packages/Djblets-0.7.8-py2.7.egg/djblets/auth/util.py,
  line 47, in _checklogin
   return view_func(request, *args, **kwargs)
 File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.1-py2.7.egg/reviewboard/reviews/views.py,
  line 728, in review_detail
   'screenshots': screenshots,
 File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.1-py2.7.egg/reviewboard/reviews/views.py,
  line 124, in _make_review_request_context
   upload_diff_form = UploadDiffForm(review_request)
 File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.1-py2.7.egg/reviewboard/reviews/forms.py,
  line 276, in __init__
   data, *args, **kwargs)
 File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.1-py2.7.egg/reviewboard/diffviewer/forms.py,
  line 51, in __init__
   if self.repository.get_scmtool().get_diffs_use_absolute_paths():
 File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.1-py2.7.egg/reviewboard/scmtools/models.py,
  line 134, in get_scmtool
   return cls(self)
 File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.1-py2.7.egg/reviewboard/scmtools/hg.py,
  line 31, in __init__
   self.client = HgClient(repository.path, repository.local_site)
 File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.1-py2.7.egg/reviewboard/scmtools/hg.py,
  line 215, in __init__
   if parse_version(version) = parse_version(1.2):
 File /usr/lib/python2.7/dist-packages/pkg_resources.py, line 1956, in 
 parse_version
   for part in _parse_version_parts(s.lower()):
   TypeError: 'NoneType' object is not callable
   ERROR:django.request:Internal Server Error: /r/5/
   Traceback (most recent call last):
 File 
 /usr/local/lib/python2.7/dist-packages/Django-1.4.3-py2.7.egg/django/core/handlers/base.py,
  line 111, in get_response
   response = callback(request, *callback_args, **callback_kwargs)
 File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.1-py2.7.egg/reviewboard/accounts/decorators.py,
  line 20, in _check
   return login_required(view_func)(*args, **kwargs)
 File 
 /usr/local/lib/python2.7/dist-packages/Djblets-0.7.8-py2.7.egg/djblets/auth/util.py,
  line 47, in _checklogin
   return view_func(request, *args, **kwargs)
 File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.1-py2.7.egg/reviewboard/reviews/views.py,
  line 728, in review_detail
   'screenshots': screenshots,
 File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.1-py2.7.egg/reviewboard/reviews/views.py,
  line 124, in _make_review_request_context
   upload_diff_form = UploadDiffForm(review_request)
 File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.1-py2.7.egg/reviewboard/reviews/forms.py,
  line 276, in __init__
   data, *args, **kwargs)
 File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.1-py2.7.egg/reviewboard/diffviewer/forms.py,
  line 51, in __init__
   if self.repository.get_scmtool().get_diffs_use_absolute_paths():
 File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.1-py2.7.egg/reviewboard/scmtools/models.py,
  line 134, in get_scmtool
   return cls(self)
 File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.1-py2.7.egg/reviewboard/scmtools/hg.py,
  line 31, in __init__
   self.client = HgClient(repository.path, repository.local_site)
 File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.1-py2.7.egg/reviewboard/scmtools/hg.py,
  line 215, in __init__
   if parse_version(version) = parse_version(1.2):
 File /usr/lib/python2.7/dist-packages/pkg_resources.py, line 1956, in 
 parse_version
   for part in _parse_version_parts(s.lower()):
   TypeError: 'NoneType' object is not callable
 
 We are running on Ubuntu 12.04.1 x86_64 with python 2.7 installed. Here is 
 our simple virtualhost:
 VirtualHost *:80
 ServerName