Re: Review Board 1.7.4 released
Hi, I just wanted to let you know that in BitNami we have already released installers, vms and cloud images for ReviewBoard 1.7.4. You can get them in http://bitnami.org/stack/reviewboard Best regards, Victoria. On Fri, Feb 1, 2013 at 6:41 AM, Christian Hammond chip...@chipx86.com wrote: Ah, okay. Well you definitely don't want to run a production site that way, but for a dev environment, sure. What you may be hitting is stale generated media files. Check to see if you have a reviewboard/htdocs/static/ directory. If so, delete it and restart, see if it improves. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Jan 31, 2013, at 9:38 PM, Tao Zhou moon...@gmail.com wrote: Hi, Christian: Yes, you are quite right. As I didn't use virtualenv and didn't know how to upgrade an existing site, I just start reviewboard with 'manage.py runserver' with latest code and thought it was same with deployed one, I will later cleanup my environment and have a test and see if the issue was fixed or not next Monday. Thanks! Tao On Thursday, January 31, 2013 6:41:20 PM UTC+8, Christian Hammond wrote: Hi Tao, This doesn't look like you're running a standard install, but rather a development install. Am I correct? Christian -- Christian Hammond - chi...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Jan 31, 2013, at 2:34 AM, Tao Zhou moo...@gmail.com wrote: Hi, Christian: Seems the view diff issue for clearcase repo on Windows has not been fixed completely in this release, I have tried and now all diffs could be displayed normally, but the spinning.gif keeping loading and loading, and below is the error message on Chrome console Resource interpreted as Image but transferred with MIME type image/x-png: http://localhost:8080/reviews/static/rb/images/edit.png;. jquery-1.8.2.min.js:2 Uncaught TypeError: undefined is not a function reviews.js:1840 (anonymous function)reviews.js:1840 kjquery-1.8.2.min.js:2 l.fireWithjquery-1.8.2.min.js:2 p.extend.readyjquery-1.8.2.min.js:2 Djquery-1.8.2.min.js:2 isshow:false and if click on diff area to ad comment, it fails, with new error message as below: Uncaught TypeError: Cannot call method 'create' of undefined diffviewer.js:279 $.extend.showCommentDlgdiffviewer.js:279 endSelectiondiffviewer.js:553 (anonymous function)diffviewer.js:419 p.event.dispatchjquery-1.8.2.min.js:2 g.handle.h On Thursday, January 31, 2013 2:08:28 PM UTC+8, Christian Hammond wrote: Hi everyone, Review Board 1.7.4 is out. It fixes a couple problems with 1.7.3 that users of IE and developers generating patches on Windows have hit. It's a pretty small release, but if you have 1.7.3 installed, you should upgrade. http://www.reviewboard.org/news/2013/01/30/review-board-1-7-4-released/ Christian -- Christian Hammond - chi...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from
Re: Review Board 1.7.4 released
Great! Thanks Victoria :) We'll work out something at some point to link to your builds for Windows users in the docs and site. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Feb 1, 2013, at 12:22 AM, victoria ka...@bitrock.com wrote: Hi, I just wanted to let you know that in BitNami we have already released installers, vms and cloud images for ReviewBoard 1.7.4. You can get them in http://bitnami.org/stack/reviewboard Best regards, Victoria. On Fri, Feb 1, 2013 at 6:41 AM, Christian Hammond chip...@chipx86.com wrote: Ah, okay. Well you definitely don't want to run a production site that way, but for a dev environment, sure. What you may be hitting is stale generated media files. Check to see if you have a reviewboard/htdocs/static/ directory. If so, delete it and restart, see if it improves. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Jan 31, 2013, at 9:38 PM, Tao Zhou moon...@gmail.com wrote: Hi, Christian: Yes, you are quite right. As I didn't use virtualenv and didn't know how to upgrade an existing site, I just start reviewboard with 'manage.py runserver' with latest code and thought it was same with deployed one, I will later cleanup my environment and have a test and see if the issue was fixed or not next Monday. Thanks! Tao On Thursday, January 31, 2013 6:41:20 PM UTC+8, Christian Hammond wrote: Hi Tao, This doesn't look like you're running a standard install, but rather a development install. Am I correct? Christian -- Christian Hammond - chi...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Jan 31, 2013, at 2:34 AM, Tao Zhou moo...@gmail.com wrote: Hi, Christian: Seems the view diff issue for clearcase repo on Windows has not been fixed completely in this release, I have tried and now all diffs could be displayed normally, but the spinning.gif keeping loading and loading, and below is the error message on Chrome console Resource interpreted as Image but transferred with MIME type image/x-png: http://localhost:8080/reviews/static/rb/images/edit.png;. jquery-1.8.2.min.js:2 Uncaught TypeError: undefined is not a function reviews.js:1840 (anonymous function)reviews.js:1840 kjquery-1.8.2.min.js:2 l.fireWithjquery-1.8.2.min.js:2 p.extend.readyjquery-1.8.2.min.js:2 Djquery-1.8.2.min.js:2 isshow:false and if click on diff area to ad comment, it fails, with new error message as below: Uncaught TypeError: Cannot call method 'create' of undefined diffviewer.js:279 $.extend.showCommentDlgdiffviewer.js:279 endSelectiondiffviewer.js:553 (anonymous function)diffviewer.js:419 p.event.dispatchjquery-1.8.2.min.js:2 g.handle.h On Thursday, January 31, 2013 2:08:28 PM UTC+8, Christian Hammond wrote: Hi everyone, Review Board 1.7.4 is out. It fixes a couple problems with 1.7.3 that users of IE and developers generating patches on Windows have hit. It's a pretty small release, but if you have 1.7.3 installed, you should upgrade. http://www.reviewboard.org/news/2013/01/30/review-board-1-7-4-released/ Christian -- Christian Hammond - chi...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/
Re: Review Board 1.7.4 released
On Fri, Feb 1, 2013 at 9:24 AM, Christian Hammond chip...@chipx86.com wrote: Great! Thanks Victoria :) We'll work out something at some point to link to your builds for Windows users in the docs and site. Hey! Thanks but we are still working on Windows :) I plan to send you a beta build today or on Monday so you can take a look at it. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Feb 1, 2013, at 12:22 AM, victoria ka...@bitrock.com wrote: Hi, I just wanted to let you know that in BitNami we have already released installers, vms and cloud images for ReviewBoard 1.7.4. You can get them in http://bitnami.org/stack/reviewboard Best regards, Victoria. On Fri, Feb 1, 2013 at 6:41 AM, Christian Hammond chip...@chipx86.com wrote: Ah, okay. Well you definitely don't want to run a production site that way, but for a dev environment, sure. What you may be hitting is stale generated media files. Check to see if you have a reviewboard/htdocs/static/ directory. If so, delete it and restart, see if it improves. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Jan 31, 2013, at 9:38 PM, Tao Zhou moon...@gmail.com wrote: Hi, Christian: Yes, you are quite right. As I didn't use virtualenv and didn't know how to upgrade an existing site, I just start reviewboard with 'manage.py runserver' with latest code and thought it was same with deployed one, I will later cleanup my environment and have a test and see if the issue was fixed or not next Monday. Thanks! Tao On Thursday, January 31, 2013 6:41:20 PM UTC+8, Christian Hammond wrote: Hi Tao, This doesn't look like you're running a standard install, but rather a development install. Am I correct? Christian -- Christian Hammond - chi...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Jan 31, 2013, at 2:34 AM, Tao Zhou moo...@gmail.com wrote: Hi, Christian: Seems the view diff issue for clearcase repo on Windows has not been fixed completely in this release, I have tried and now all diffs could be displayed normally, but the spinning.gif keeping loading and loading, and below is the error message on Chrome console Resource interpreted as Image but transferred with MIME type image/x-png: http://localhost:8080/reviews/static/rb/images/edit.png;. jquery-1.8.2.min.js:2 Uncaught TypeError: undefined is not a function reviews.js:1840 (anonymous function)reviews.js:1840 kjquery-1.8.2.min.js:2 l.fireWithjquery-1.8.2.min.js:2 p.extend.readyjquery-1.8.2.min.js:2 Djquery-1.8.2.min.js:2 isshow:false and if click on diff area to ad comment, it fails, with new error message as below: Uncaught TypeError: Cannot call method 'create' of undefined diffviewer.js:279 $.extend.showCommentDlgdiffviewer.js:279 endSelectiondiffviewer.js:553 (anonymous function)diffviewer.js:419 p.event.dispatchjquery-1.8.2.min.js:2 g.handle.h On Thursday, January 31, 2013 2:08:28 PM UTC+8, Christian Hammond wrote: Hi everyone, Review Board 1.7.4 is out. It fixes a couple problems with 1.7.3 that users of IE and developers generating patches on Windows have hit. It's a pretty small release, but if you have 1.7.3 installed, you should upgrade. http://www.reviewboard.org/news/2013/01/30/review-board-1-7-4-released/ Christian -- Christian Hammond - chi...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Review Board 1.7.4 released
On Feb 1, 2013, at 12:34 AM, victoria ka...@bitrock.com wrote: On Fri, Feb 1, 2013 at 9:24 AM, Christian Hammond chip...@chipx86.com wrote: Great! Thanks Victoria :) We'll work out something at some point to link to your builds for Windows users in the docs and site. Hey! Thanks but we are still working on Windows :) I plan to send you a beta build today or on Monday so you can take a look at it. Well, in general then :) Thanks! I won't be able to get to it this weekend, but do let me know when it's ready. I would definitely like to test it out. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: GitHub private repo with RB
Google fucked up all attached images. Sorry. All was attached properly. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: RB server upgrade from 1.6.1 to 1.7.4
Thanks Christian for the response. Good to hear that upgrade is possible from 1.6.1 to 1.7.4 RB version, apart from the database backup do we need to take care of any thing else which will disturb our production setup and in case of any issue we should be able to go back to our original state, if you point us action item it would be really great. Few queries though 1. How does upgrade takes place, does it replace files by files ( I mean python scripts etc ) apart from db. 2. The Release note of 1.7.2 its been mentioned about below However, this requires that p4python is specially compiled with OpenSSL support, and that the system has development headers for OpenSSL 1.0.1. P4PythonInstaller doesn’t do this, so users who need this feature will currently have to compile p4python manually, providing the path to the SSL directory using --ssl Do we have any tech note for the above steps which end user needs to perform. Cheers, Chuck On Thu, Jan 31, 2013 at 2:50 PM, Christian Hammond chip...@chipx86.comwrote: Hi Chuck, I always recommend backing up your database first, but you should be able to upgrade from 1.6.1 to 1.7.4 without any real problems. There is a bug that some people hit a while back in older versions that introduced some stale upgrade data in the database. I meant to get a final fix out in 1.7.4, but it slipped. If your 'rb-site upgrade' complains about fields that already exist or something, e-mail and I'll give you the solution. Otherwise, you shouldn't have any problems. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Jan 31, 2013 at 2:47 PM, chuck j cjerry2...@gmail.com wrote: Dear All, There has been lots of improvement done on RB server from version 1.6.1 till date, hence i would like to know if the upgrade from 1.6.1 to latest version is supported? If not then how should I bring my RB server 1.6.1 to latest state without loosing the existing data from my existing database. We need to upgrade because 1.7.2 has SSL feature implement and we have planned to upgrade perforce server to 2012.2. Please help. Appreciated your response and help Cheers, Chuck. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: GitHub private repo with RB
Hi Igor, I don't know what you'd need the WebHook for. Sounds like you're set up to use Review Board with GitHub. We don't work with pull requests, if that's what you're asking. We don't have support on our side, and even if we want to add them, there's a challenge in figuring out how username association would work between the two, and challenges with workflows in general. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Feb 1, 2013 at 4:47 AM, Igor Kryltsov krylt...@gmail.com wrote: 1. Repo is set in RB 2. SSH key is set in RB and visible in GitHub Question is what needs to be done in GitHub repo. Is is a matter of adding a web hook pointing to my RB URL? Thank you Igor -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: a couple of issues post 1.7.1 upgrade
I am also seeing this issue. Did you ever find a solution for this? - Loke On Monday, January 7, 2013 5:46:49 PM UTC+1, Dave Preston wrote: Ok I’ll give that a shot and report back. Thanks again Christian. Dave *From:* revie...@googlegroups.com javascript: [mailto: revie...@googlegroups.com javascript:] *On Behalf Of *Christian Hammond *Sent:* Friday, January 04, 2013 2:48 PM *To:* revie...@googlegroups.com javascript: *Subject:* Re: a couple of issues post 1.7.1 upgrade So that function is doing basically a 'svn cat', but it's also doing a 'svn propget svn:keywords' on the path with the given revision. Perhaps something broke there? Maybe try adding some logging inside scmtools/svn.py inside get_file_data, before the cat, before the propget, and after the propget. See what turns up. Christian -- Christian Hammond - chi...@chipx86.com javascript: Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Jan 4, 2013 at 2:24 PM, Christian Hammond chi...@chipx86.comjavascript: wrote: Hi Dave, Sorry to say that I'm fresh out of ideas at this point. If you have any VM software handy, you could try setting up a test 1.6.3 install and make sure it works, take a snapshot of the VM, then try 1.6.14. If that fails, revert back to 1.6.3, and try something in the middle, see how that works... binary search the releases. That can help narrow down where this may have fallen apart. There's nothing else I can really do on my side right now. I'll keep thinking through this, but without access to the server, I'm kind of stuck. Christian -- Christian Hammond - chi...@chipx86.com javascript: Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Jan 4, 2013 at 1:43 PM, Dave Preston d.pr...@complianceease.comjavascript: wrote: We have never used those fields at all. I did populate them though and have the same results. I was able to use svn cat successfully as www-data with the key. *From:* revie...@googlegroups.com javascript: [mailto: revie...@googlegroups.com javascript:] *On Behalf Of *Christian Hammond *Sent:* Friday, January 04, 2013 1:32 PM *To:* revie...@googlegroups.com javascript: *Subject:* Re: a couple of issues post 1.7.1 upgrade Did you ever have anything filled out in the Password field for the repository? Do you still have the username field set? If these were ever filled out, be sure they're filled out now (re-type the password) and save the repository again. I want to rule out a configuration issue on that end. At this point, I don't think it's an issue with either rbssh or Review Board, but rather some configuration issue somewhere. (Though I won't rule it out completely.) The logs indicate to me that we've handed things over to svnserve at this point, meaning we're no longer a factor. In that case, it'd be something between libsvn and svnserve. I haven't hit this problem in my testing so far. Christian -- Christian Hammond - chi...@chipx86.com javascript: Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Jan 4, 2013 at 7:53 AM, Dave Preston d.pr...@complianceease.comjavascript: wrote: I did upgrade the svn server after I started to have these problems. But everything else is the same. Dave *From:* revie...@googlegroups.com javascript: [mailto: revie...@googlegroups.com javascript:] *On Behalf Of *Christian Hammond *Sent:* Thursday, January 03, 2013 10:16 PM *To:* revie...@googlegroups.com javascript: *Subject:* Re: a couple of issues post 1.7.1 upgrade If it's process_stdin, it sounds like it's svnserve asking for the password, meaning the SSH authentication was successful. I assume it's doing this in the original log you showed as well, and the lack of stdin was causing the connection to be closed unexpectedly. I don't know why it'd be different from when you were using 1.6.9 (nor do I know what would have changed to break this in this way). Sounds like something changed, though. Were any other things upgraded along with Review Board? The SVN server, or pysvn/libsvn? Christian -- Christian Hammond - chi...@chipx86.com javascript: Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Jan 3, 2013 at 7:59 PM, Dave Preston d.pr...@complianceease.comjavascript: wrote: All those process_stdin is where it prompts for the password. I don't get why it seems to connect with the key ok and then fall back to password, if that's what is actually happening. -Original Message- From: revie...@googlegroups.com javascript: [mailto:revie...@googlegroups.com javascript:] On Behalf Of Christian Hammond Sent: Thursday, January 03, 2013 5:45 PM To: revie...@googlegroups.com javascript: Subject: Re: a
Re: a couple of issues post 1.7.1 upgrade
That's concerning. I've spent a lot of time trying to test some of the Subversion cases that were reported, but I haven't hit the problems that were reported, and that code really hasn't changed in any significant ways since 1.6.14... Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Feb 1, 2013 at 1:58 PM, Dave Preston d.pres...@complianceease.comwrote: No, I haven’t had the time to set up another subversion server to test it against. Ultimately I went the route of setting up another user in active directory and pointed the reviewboard to it via https rather than svn+ssh. It still seems that I was unable to add new repositories via ssh or https once I got to 1.7 so we’re still on the 1.6 series. ** ** Dave ** ** *From:* reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com] *On Behalf Of *Loke Dupont *Sent:* Friday, February 01, 2013 4:13 AM *To:* reviewboard@googlegroups.com *Subject:* Re: a couple of issues post 1.7.1 upgrade ** ** I am also seeing this issue. Did you ever find a solution for this? ** ** - Loke On Monday, January 7, 2013 5:46:49 PM UTC+1, Dave Preston wrote: Ok I’ll give that a shot and report back. Thanks again Christian. Dave *From:* revie...@googlegroups.com [mailto:revie...@googlegroups.com] *On Behalf Of *Christian Hammond *Sent:* Friday, January 04, 2013 2:48 PM *To:* revie...@googlegroups.com *Subject:* Re: a couple of issues post 1.7.1 upgrade So that function is doing basically a 'svn cat', but it's also doing a 'svn propget svn:keywords' on the path with the given revision. Perhaps something broke there? Maybe try adding some logging inside scmtools/svn.py inside get_file_data, before the cat, before the propget, and after the propget. See what turns up. Christian -- Christian Hammond - chi...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Jan 4, 2013 at 2:24 PM, Christian Hammond chi...@chipx86.com wrote: Hi Dave, Sorry to say that I'm fresh out of ideas at this point. If you have any VM software handy, you could try setting up a test 1.6.3 install and make sure it works, take a snapshot of the VM, then try 1.6.14. If that fails, revert back to 1.6.3, and try something in the middle, see how that works... binary search the releases. That can help narrow down where this may have fallen apart. There's nothing else I can really do on my side right now. I'll keep thinking through this, but without access to the server, I'm kind of stuck. Christian -- Christian Hammond - chi...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Jan 4, 2013 at 1:43 PM, Dave Preston d.pr...@complianceease.com wrote: We have never used those fields at all. I did populate them though and have the same results. I was able to use svn cat successfully as www-data with the key. *From:* revie...@googlegroups.com [mailto:revie...@googlegroups.com] *On Behalf Of *Christian Hammond *Sent:* Friday, January 04, 2013 1:32 PM *To:* revie...@googlegroups.com *Subject:* Re: a couple of issues post 1.7.1 upgrade Did you ever have anything filled out in the Password field for the repository? Do you still have the username field set? If these were ever filled out, be sure they're filled out now (re-type the password) and save the repository again. I want to rule out a configuration issue on that end. At this point, I don't think it's an issue with either rbssh or Review Board, but rather some configuration issue somewhere. (Though I won't rule it out completely.) The logs indicate to me that we've handed things over to svnserve at this point, meaning we're no longer a factor. In that case, it'd be something between libsvn and svnserve. I haven't hit this problem in my testing so far. Christian -- Christian Hammond - chi...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Jan 4, 2013 at 7:53 AM, Dave Preston d.pr...@complianceease.com wrote: I did upgrade the svn server after I started to have these problems. But everything else is the same. Dave *From:* revie...@googlegroups.com [mailto:revie...@googlegroups.com] *On Behalf Of *Christian Hammond *Sent:* Thursday, January 03, 2013 10:16 PM *To:* revie...@googlegroups.com *Subject:* Re: a couple of issues post 1.7.1 upgrade If it's process_stdin, it sounds like it's svnserve asking for the password, meaning the SSH authentication was successful. I assume
Re: GitHub private repo with RB
Hi Christian, We already use RB with SVN for a few years. It is in post commit mode. So there is SVN hook which tells RB about commit, RB pulls it and creates reviews. On pictures attached, I think, I configured RB to be able to pull but what will tell RB about GitHub commit if not a web hook set in GitHub? My questions is what needs to nbe done to set it up. We don't work with pull requests, if that's what you're asking Is scenario I describe is what you call 'pull requests'? In this case what scenario IS supported by RB for GitHub? Thank you Igor -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Issue 2885 in reviewboard: Hide whitespace changes toggle not working in diff viewer
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2885 by btho...@gmail.com: Hide whitespace changes toggle not working in diff viewer http://code.google.com/p/reviewboard/issues/detail?id=2885 * NOTE: For customer support, please post to * * reviewbo...@googlegroups.com * ** * Do not post confidential information in this bug report. * * If you need immediate support, please contact* * reviewbo...@googlegroups.com * What version are you running? 1.7.1 What's the URL of the page containing the problem? Found on internal instance of ReviewBoard. What steps will reproduce the problem? 1. View a diff that contains lines with only whitespace changes 2. Try to toggle 'Hide whitespace changes' 3. What is the expected output? What do you see instead? References to the whitespace changes should dim and whitespace changes should no longer be highlighted. Instead nothing happens and the button doesn't toggle. Chrome's console shows: Uncaught Error: Syntax error, unrecognized expression: ol.index a[href=#5.2] What operating system are you using? What browser? Windows 7/Mac OS X 10.8 Chrome/Firefox/Opera Please provide any additional information below. I've attached a patch that fixes the problem for me. Attachments: whitespace_toggle.patch 594 bytes -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2885 in reviewboard: Hide whitespace changes toggle not working in diff viewer
Comment #1 on issue 2885 by trowb...@gmail.com: Hide whitespace changes toggle not working in diff viewer http://code.google.com/p/reviewboard/issues/detail?id=2885 Can you put this up on http://reviews.reviewboard.org/ ? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2884 in reviewboard: links with ampersand () are truncated
Comment #1 on issue 2884 by rajas...@gmail.com: links with ampersand () are truncated http://code.google.com/p/reviewboard/issues/detail?id=2884 I tested on 1.7.2 and 1.7.4 and dont seem to have this problem. Attaching screenshot. Is this how you modified the description? Attachments: 2884.png 138 KB -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
