Re: post-review: Ignore whitespace?
Hi Robert, We purposefully do not provide this feature for diff uploads. From the Review Board diff viewer, you can hide lines that are whitespace-only changes (okay, this is broken in the past couple releases, but the next one will fix it). We prefer to do customization of display like that on the Review Board side, and in fact, it's very important that Review Board does not have a mangled view of how the diff looks, since we apply the patch and do some processing and caching on the result. Christian Robert Dailey wrote: Is there a way to tell post-review to ignore whitespace in diffs that it uploads? I use this tool through P4V (perforce visual client). Sometimes a file is full of tabs to spaces conversions and it mixes in with real, useful code changes. I'd like to see a way to upload a diff without whitespace OR a user-option in ReviewBoard to hide diffs on lines with only whitespace changes. Anyone? Thanks. -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: post-review: Ignore whitespace?
Thanks for the quick response Christian. Is this option under the My Account page? I don't currently see an option for this. I'm on version 1.6.3. Can you comment if this is one of the versions the option you speak of is not working in? Does the server configuration have to enable this option as well? Thanks again. On Fri, Jul 12, 2013 at 5:27 PM, Christian Hammond chip...@chipx86.com wrote: Hi Robert, We purposefully do not provide this feature for diff uploads. From the Review Board diff viewer, you can hide lines that are whitespace-only changes (okay, this is broken in the past couple releases, but the next one will fix it). We prefer to do customization of display like that on the Review Board side, and in fact, it's very important that Review Board does not have a mangled view of how the diff looks, since we apply the patch and do some processing and caching on the result. Christian Robert Dailey wrote: Is there a way to tell post-review to ignore whitespace in diffs that it uploads? I use this tool through P4V (perforce visual client). Sometimes a file is full of tabs to spaces conversions and it mixes in with real, useful code changes. I'd like to see a way to upload a diff without whitespace OR a user-option in ReviewBoard to hide diffs on lines with only whitespace changes. Anyone? Thanks. -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: post-review: Ignore whitespace?
This is just a toggle when viewing the diff. Look at the options at the bottom of the review request box, just above the first diff. It should be on 1.6.3, but that's such an old release that I don't remember. Christian Robert Dailey wrote: Thanks for the quick response Christian. Is this option under the My Account page? I don't currently see an option for this. I'm on version 1.6.3. Can you comment if this is one of the versions the option you speak of is not working in? Does the server configuration have to enable this option as well? Thanks again. On Fri, Jul 12, 2013 at 5:27 PM, Christian Hammondchip...@chipx86.com wrote: Hi Robert, We purposefully do not provide this feature for diff uploads. From the Review Board diff viewer, you can hide lines that are whitespace-only changes (okay, this is broken in the past couple releases, but the next one will fix it). We prefer to do customization of display like that on the Review Board side, and in fact, it's very important that Review Board does not have a mangled view of how the diff looks, since we apply the patch and do some processing and caching on the result. Christian Robert Dailey wrote: Is there a way to tell post-review to ignore whitespace in diffs that it uploads? I use this tool through P4V (perforce visual client). Sometimes a file is full of tabs to spaces conversions and it mixes in with real, useful code changes. I'd like to see a way to upload a diff without whitespace OR a user-option in ReviewBoard to hide diffs on lines with only whitespace changes. Anyone? Thanks. -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Issue 3034 in reviewboard: RBTools Mercurial client ignore hgrc configuration file
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3034 by a...@zigarn.com: RBTools Mercurial client ignore hgrc configuration file http://code.google.com/p/reviewboard/issues/detail?id=3034 With RBTools 0.5.1 Mercurial client, hgrc configuration file is by-passed by setting 'HGRCPATH': os.devnull in 'hg_env'. In my case, it breaks the connection to the repository : my repo is on a self-signed HTTP server and I set hostfingerprints to avoid SSL problem, but with RBTools, I have SSL problem back. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2544 in reviewboard: HTTP 500 when performing search
Comment #7 on issue 2544 by subodhko...@gmail.com: HTTP 500 when performing search http://code.google.com/p/reviewboard/issues/detail?id=2544 Same issue with 1.7.11 and 12.04 with pylucene, but the above fix in admin/views.py worked. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3016 in reviewboard: Search sometimes results in internal server error
Comment #1 on issue 3016 by subodhko...@gmail.com: Search sometimes results in internal server error http://code.google.com/p/reviewboard/issues/detail?id=3016 Refer https://code.google.com/p/reviewboard/issues/detail?id=2544 and you shall get your fix. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3016 in reviewboard: Search sometimes results in internal server error
Updates: Status: Duplicate Mergedinto: 2544 Comment #2 on issue 3016 by trowb...@gmail.com: Search sometimes results in internal server error http://code.google.com/p/reviewboard/issues/detail?id=3016 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
