Re: scroll issue on some file

2014-06-02 Thread Adrien Rochereau
I indeed have a couple long html strings in that file, I will wrap and see 
if it happens again  (long being a couple 300ish lines and one 500ish line)
I'll update you if it happens on files with shorter lines, in the mean time 
I will assume that this is the source of the problem (and should be fixed 
in my file in fact)

Thanks

On Thursday, May 29, 2014 6:22:18 PM UTC-4, Christian Hammond wrote:

 Hi Adrien,

 Somewhere in that file, I imagine you have a very long line that the 
 browser is unable to wrap.

 We rely on the browser to handle wrapping, since we have very little 
 control of that. Some browsers work differently than other browsers in this 
 regard. If you have a line that the browser considers one long unwrappable 
 string, then it's going to cause this sort of problem.

 Can you check to see if that's the case?

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com javascript:
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com


 On Thu, May 29, 2014 at 12:46 PM, Adrien Rochereau aroch...@broadsoft.com 
 javascript: wrote:

 this one is a weird bug, on 2.0.1 it does not detect properly when to 
 wrap the lines and it makes it impossible to review a file, see screenshot.
 please note that this is one file out of more than 50, so definitely not 
 a common bug but still annoying:


 https://lh5.googleusercontent.com/-ThIEqGdw0fM/U4eNQN3lVXI/AFo/JE0lZonGryo/s1600/scrolling+bug.png

 as you can see the right side is being cut, let me know if you need more 
 information. scrolling down to other files, the other files were correct.

  
 See why you should attend BroadSoft Connections 2014 
 http://broadsoftconnections.com/

 This email is intended solely for the person or entity to which it is 
 addressed and may contain confidential and/or privileged information. If 
 you are not the intended recipient and have received this email in error, 
 please notify BroadSoft, Inc. immediately by replying to this message, and 
 destroy all copies of this message, along with any attachment, prior to 
 reading, distributing or copying it.
  
 -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.



-- 

See why you should attend BroadSoft Connections 
2014http://broadsoftconnections.com/

This email is intended solely for the person or entity to which it is 
addressed and may contain confidential and/or privileged information. If 
you are not the intended recipient and have received this email in error, 
please notify BroadSoft, Inc. immediately by replying to this message, and 
destroy all copies of this message, along with any attachment, prior to 
reading, distributing or copying it.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Fedora rawhide: RB Dashboard missing Edit Columns button and column styling

2014-06-02 Thread Paul Fee
Hi Stephen,

Comparing the HTML using Firefox/Firebug, I see both good and bad pages
have the correct HTML to display the Edit columns heading.  However the
bad page has missing CSS styling.

On Fedora rawhide, with an up to date locate database, I can see an empty
CSS file that looks suspicious.

$ ls -l `locate datagrid | grep css`
-rw-r--r--. 1 root root 6251 May 27 15:03
/usr/lib/python2.7/site-packages/djblets/htdocs/static/djblets/css/datagrid.css
-rw-r--r--. 1 root root 6316 May 27 15:03
/usr/lib/python2.7/site-packages/djblets/htdocs/static/djblets/css/datagrid.da6c340af879.css
-rw-r--r--. 1 root root 6316 May 27 02:01
/usr/lib/python2.7/site-packages/djblets/htdocs/static/djblets/css/datagrid.min.6521a0d8b348.css
-rw-r--r--. 1 root root0 May 27 15:03
/usr/lib/python2.7/site-packages/djblets/htdocs/static/djblets/css/datagrid.min.css
-rw-r--r--. 1 root root0 May 27 15:03
/usr/lib/python2.7/site-packages/djblets/htdocs/static/djblets/css/datagrid.min.d41d8cd98f00.css
-rw-r--r--. 1 root root 6251 May 27 02:01
/usr/lib/python2.7/site-packages/djblets/static/djblets/css/datagrid.css

I expect those two empty files are (part of) the problem.

According to rpm -qf they're both owned by
python-djblets-0.8.1-1.fc21.noarch.

Thanks,
Paul


On 2 June 2014 14:14, Stephen Gallagher step...@gallagherhome.com wrote:

 On 05/30/2014 01:58 PM, Stephen Gallagher wrote:
  On 05/30/2014 12:57 PM, Paul Fee wrote:
  Hi all,
 
  On my Fedora rawhide system with RB2.0 the dashboard doesn't look right.
 
  * The column headers are missing their styling.
  * The Edit Columns button is missing.
 
  I see this with a freshly created site as illustrated below:
 
 
 
 
  There's no issue with RB1.7.25 on Centos6 nor RB2.0.1 hosted at
  http://demo.reviewboard.org/
 
 
 
  I'm suspecting the issue is unique to the Rawhide packages.  Has anyone
  else seen this or able to reproduce?
 
 
  I saw that on an instance I created the other day as well. I'll look
  into it next week.
 

 Ok, I'm pretty stumped here. There's nothing obviously wrong with the
 build [1] [2], but I'm getting output that is apparently *slightly*
 malformed, such that neither Chrome or Firefox will render it properly.
 I do not have a strong background in HTML/JS, so I can't spot the issue.
 I'm attaching the saved page, hopefully someone can take a look and tell
 me where I screwed up.


 [1]

 https://kojipkgs.fedoraproject.org//packages/python-djblets/0.8.1/1.fc21/data/logs/noarch/build.log
 [2]

 https://kojipkgs.fedoraproject.org//packages/ReviewBoard/2.0.1/1.fc21/data/logs/noarch/build.log

 --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to a topic in the
 Google Groups reviewboard group.
 To unsubscribe from this topic, visit
 https://groups.google.com/d/topic/reviewboard/31p7hxUkUX4/unsubscribe.
 To unsubscribe from this group and all its topics, send an email to
 reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Fedora rawhide: RB Dashboard missing Edit Columns button and column styling

2014-06-02 Thread Stephen Gallagher
On 06/02/2014 11:46 AM, Paul Fee wrote:
 Hi Stephen,
 
 Comparing the HTML using Firefox/Firebug, I see both good and bad pages
 have the correct HTML to display the Edit columns heading.  However
 the bad page has missing CSS styling.
 
 On Fedora rawhide, with an up to date locate database, I can see an
 empty CSS file that looks suspicious.
 
 $ ls -l `locate datagrid | grep css`
 -rw-r--r--. 1 root root 6251 May 27 15:03
 /usr/lib/python2.7/site-packages/djblets/htdocs/static/djblets/css/datagrid.css
 -rw-r--r--. 1 root root 6316 May 27 15:03
 /usr/lib/python2.7/site-packages/djblets/htdocs/static/djblets/css/datagrid.da6c340af879.css
 -rw-r--r--. 1 root root 6316 May 27 02:01
 /usr/lib/python2.7/site-packages/djblets/htdocs/static/djblets/css/datagrid.min.6521a0d8b348.css
 -rw-r--r--. 1 root root0 May 27 15:03
 /usr/lib/python2.7/site-packages/djblets/htdocs/static/djblets/css/datagrid.min.css
 -rw-r--r--. 1 root root0 May 27 15:03
 /usr/lib/python2.7/site-packages/djblets/htdocs/static/djblets/css/datagrid.min.d41d8cd98f00.css
 -rw-r--r--. 1 root root 6251 May 27 02:01
 /usr/lib/python2.7/site-packages/djblets/static/djblets/css/datagrid.css
 
 I expect those two empty files are (part of) the problem.
 
 According to rpm -qf they're both owned by
 python-djblets-0.8.1-1.fc21.noarch.
 


Thanks, Paul. I hadn't spotted that. I suspect you're right. Looks like
the minification of datagrid.css may have broken somehow.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Unable to view SVN diff after migration from 1.7.x to 2.0.1

2014-06-02 Thread Roudaille77
Hello,

I have just updated my ReviewBoard site but I can't visualize the 
Subversion diff anymore...
I can see :

There was an error displaying this diff.

Traceback (most recent call last):
  File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/views.py,
 line 236, in get
renderer = self.create_renderer(context, *args, **kwargs)
  File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/reviews/views.py,
 line 1102, in create_renderer
*args, **kwargs)
  File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/views.py,
 line 326, in create_renderer
self.diff_file = self._get_requested_diff_file()
  File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/views.py,
 line 367, in _get_requested_diff_file
request=self.request)
  File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/diffutils.py,
 line 373, in populate_diff_chunks
chunks = generator.get_chunks()
  File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py,
 line 148, in get_chunks
large_data=True)
  File 
/usr/local/lib/python2.7/dist-packages/Djblets-0.8.1-py2.7.egg/djblets/cache/backend.py,
 line 109, in cache_memoize
data = lookup_callable()
  File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py,
 line 147, in lambda
lambda: list(self._get_chunks_uncached()),
  File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py,
 line 154, in _get_chunks_uncached
old = get_original_file(self.filediff, self.request, encoding_list)
  File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/diffutils.py,
 line 172, in get_original_file
encoding, data = convert_to_unicode(data, encoding_list)
  File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/diffutils.py,
 line 50, in convert_to_unicode
return e, six.text_type(s, e)
LookupError: unknown encoding: 

Any idea ?

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Review Board 2.x and hg postreview

2014-06-02 Thread Bruce Cran
I'm investigating upgrading our installation to Review Board 2.x and one
issue I've come across is that with the existing code, hg postreview
doesn't work correctly. I've submitted a ticket to
https://bitbucket.org/ccaughie/hgreviewboard, but I was wondering - are
people still planning to use the hg postreview extension, or are you all
switching to the rbt client?

--
Bruce

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board 2.x and hg postreview

2014-06-02 Thread Christian Hammond
We made a number of improvements to the Mercurial support in RBTools 0.6. I
don't have personal experience with hg subversion myself, so I don't know
whether it's still at all necessary for any workflows. Certainly, we'd
rather time be spent updating RBTools for any missing functionality.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com


On Mon, Jun 2, 2014 at 11:21 AM, Bruce Cran bruce.c...@gmail.com wrote:

 I'm investigating upgrading our installation to Review Board 2.x and one
 issue I've come across is that with the existing code, hg postreview
 doesn't work correctly. I've submitted a ticket to
 https://bitbucket.org/ccaughie/hgreviewboard, but I was wondering - are
 people still planning to use the hg postreview extension, or are you all
 switching to the rbt client?

 --
 Bruce

 --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board 2.x and hg postreview

2014-06-02 Thread Sara Rayburn
Hi Bruce,

Most of the developers at my company are still using postreview with RB 
2.0. We've always seen the error you reported in the bug, both with and 
without postreview. It seems to be a reviewboard issue. As a workaround, 
you might be able to make your parent diff include more changesets. The 
trick is that all of the changed files in your diff must be referenced in 
the parent diff as well. Hope that helps.

Sara

On Monday, June 2, 2014 1:22:09 PM UTC-5, Bruce Cran wrote:

 I'm investigating upgrading our installation to Review Board 2.x and one 
 issue I've come across is that with the existing code, hg postreview 
 doesn't work correctly. I've submitted a ticket to 
 https://bitbucket.org/ccaughie/hgreviewboard 
 https://www.google.com/url?q=https%3A%2F%2Fbitbucket.org%2Fccaughie%2Fhgreviewboardsa=Dsntz=1usg=AFQjCNE34g4wW_nHHVDDE-wLzYYOHMTp6w,
  
 but I was wondering - are people still planning to use the hg postreview 
 extension, or are you all switching to the rbt client?

 --  
 Bruce 


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Multiple Warnings and strange behaviour on RB2.0

2014-06-02 Thread Adrien Rochereau
getting the same logs using tortoisesvn as well

On Tuesday, May 27, 2014 11:10:31 PM UTC-4, MoonWalker wrote:

 No, we are using tortoisesvn to generate an unified diffs. We are using 
 SVN only

 On Wednesday, May 28, 2014 12:21:18 PM UTC+10, Christian Hammond wrote:

 Hi,

 Those are completely harmless and unrelated.

 Are you using any extensions? ReviewBot perhaps?

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com


 On Tue, May 27, 2014 at 7:19 PM, MoonWalker daniel.c...@gmail.com 
 wrote:

 I renable Debug mode, because we are experiencing some strange behavior 
 on some reviews, when we try to update some reviews. Seems like when the 
 developers submit publish the nothing happens and the new review does not 
 get published. 

 I have the following warring and this may or may not explain such 
 behavior or any other potential issue.

  23:00:49WARNING 

  - Cache data for key 
 codereview.local:/:diffviewer/diff_file_fragment.html-3-1-3809-collapsed-highlighting-en-1401231630
  (length 1706544) may be too big for the cache.

  01:45:59WARNING 

  - 
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/models/fields/__init__.py:848:
  RuntimeWarning: DateTimeField User.last_login received a naive datetime 
 (2014-05-21 00:00:00) while time zone support is active.
   RuntimeWarning)

  1:46:00WARNING 

  - 
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/http/response.py:327:
  DeprecationWarning: Using mimetype keyword argument is deprecated, use 
 content_type instead
   super(HttpResponse, self).__init__(*args, **kwargs)


 Is there any way to increase the level of verbosity, so far the only 
 change that I made is enable DEBUG = True on settings_local.py

  -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.



-- 

See why you should attend BroadSoft Connections 
2014http://broadsoftconnections.com/

This email is intended solely for the person or entity to which it is 
addressed and may contain confidential and/or privileged information. If 
you are not the intended recipient and have received this email in error, 
please notify BroadSoft, Inc. immediately by replying to this message, and 
destroy all copies of this message, along with any attachment, prior to 
reading, distributing or copying it.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Multiple Warnings and strange behaviour on RB2.0

2014-06-02 Thread Christian Hammond
Nothing in those logs are related, so I don't actually have anything to go
on. Those are just harmless warnings that everybody will see.

While TortoiseSVN should be compatible, it's not actively tested. Still, it
should *never* cause an issue with publishing.

Adrien, are you also unable to publish? What does the browser's JavaScript
console and HTTP response in the Network tab for the publish request show?

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com


On Mon, Jun 2, 2014 at 11:58 AM, Adrien Rochereau arocher...@broadsoft.com
wrote:

 getting the same logs using tortoisesvn as well


 On Tuesday, May 27, 2014 11:10:31 PM UTC-4, MoonWalker wrote:

 No, we are using tortoisesvn to generate an unified diffs. We are using
 SVN only

 On Wednesday, May 28, 2014 12:21:18 PM UTC+10, Christian Hammond wrote:

 Hi,

 Those are completely harmless and unrelated.

 Are you using any extensions? ReviewBot perhaps?

 Christian

 --
 Christian Hammond - chi...@chipx86.com
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com


 On Tue, May 27, 2014 at 7:19 PM, MoonWalker daniel.c...@gmail.com
 wrote:

 I renable Debug mode, because we are experiencing some strange behavior
 on some reviews, when we try to update some reviews. Seems like when the
 developers submit publish the nothing happens and the new review does not
 get published.

 I have the following warring and this may or may not explain such
 behavior or any other potential issue.

  23:00:49WARNING

  - Cache data for key 
 codereview.local:/:diffviewer/diff_file_fragment.html-3-1-3809-collapsed-highlighting-en-1401231630
  (length 1706544) may be too big for the cache.

  01:45:59WARNING

  - 
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/models/fields/__init__.py:848:
  RuntimeWarning: DateTimeField User.last_login received a naive datetime 
 (2014-05-21 00:00:00) while time zone support is active.
   RuntimeWarning)

  1:46:00WARNING

  - 
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/http/response.py:327:
  DeprecationWarning: Using mimetype keyword argument is deprecated, use 
 content_type instead
   super(HttpResponse, self).__init__(*args, **kwargs)


 Is there any way to increase the level of verbosity, so far the only
 change that I made is enable DEBUG = True on settings_local.py

  --
 Get the Review Board Power Pack at http://www.reviewboard.org/
 powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.



 See why you should attend BroadSoft Connections 2014
 http://broadsoftconnections.com/

 This email is intended solely for the person or entity to which it is
 addressed and may contain confidential and/or privileged information. If
 you are not the intended recipient and have received this email in error,
 please notify BroadSoft, Inc. immediately by replying to this message, and
 destroy all copies of this message, along with any attachment, prior to
 reading, distributing or copying it.

 --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Unable to view SVN diff after migration from 1.7.x to 2.0.1

2014-06-02 Thread David Trowbridge
Can you tell us what's in the Encoding field (under Advanced Settings)
in the repository admin?

-David


On Mon, Jun 2, 2014 at 7:53 AM, Roudaille77 rudy.he...@gmail.com wrote:

 Hello,

 I have just updated my ReviewBoard site but I can't visualize the
 Subversion diff anymore...
 I can see :

 There was an error displaying this diff.

 Traceback (most recent call last):
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/views.py,
  line 236, in get
 renderer = self.create_renderer(context, *args, **kwargs)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/reviews/views.py,
  line 1102, in create_renderer
 *args, **kwargs)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/views.py,
  line 326, in create_renderer
 self.diff_file = self._get_requested_diff_file()
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/views.py,
  line 367, in _get_requested_diff_file
 request=self.request)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/diffutils.py,
  line 373, in populate_diff_chunks
 chunks = generator.get_chunks()
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py,
  line 148, in get_chunks
 large_data=True)
   File 
 /usr/local/lib/python2.7/dist-packages/Djblets-0.8.1-py2.7.egg/djblets/cache/backend.py,
  line 109, in cache_memoize
 data = lookup_callable()
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py,
  line 147, in lambda
 lambda: list(self._get_chunks_uncached()),
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py,
  line 154, in _get_chunks_uncached
 old = get_original_file(self.filediff, self.request, encoding_list)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/diffutils.py,
  line 172, in get_original_file
 encoding, data = convert_to_unicode(data, encoding_list)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/diffutils.py,
  line 50, in convert_to_unicode
 return e, six.text_type(s, e)
 LookupError: unknown encoding:

 Any idea ?

  --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Multiple Warnings and strange behaviour on RB2.0

2014-06-02 Thread Adrien Rochereau
publishing actually works fine, so not related as you said.
These are actual warnings not errors anyway


On Mon, Jun 2, 2014 at 3:31 PM, Christian Hammond christ...@beanbaginc.com
wrote:

 Nothing in those logs are related, so I don't actually have anything to go
 on. Those are just harmless warnings that everybody will see.

 While TortoiseSVN should be compatible, it's not actively tested. Still,
 it should *never* cause an issue with publishing.

 Adrien, are you also unable to publish? What does the browser's JavaScript
 console and HTTP response in the Network tab for the publish request show?

 Christian

 --
 Christian Hammond - christ...@beanbaginc.com
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com


 On Mon, Jun 2, 2014 at 11:58 AM, Adrien Rochereau 
 arocher...@broadsoft.com wrote:

 getting the same logs using tortoisesvn as well


 On Tuesday, May 27, 2014 11:10:31 PM UTC-4, MoonWalker wrote:

 No, we are using tortoisesvn to generate an unified diffs. We are using
 SVN only

 On Wednesday, May 28, 2014 12:21:18 PM UTC+10, Christian Hammond wrote:

 Hi,

 Those are completely harmless and unrelated.

 Are you using any extensions? ReviewBot perhaps?

 Christian

 --
 Christian Hammond - chi...@chipx86.com
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com


 On Tue, May 27, 2014 at 7:19 PM, MoonWalker daniel.c...@gmail.com
 wrote:

 I renable Debug mode, because we are experiencing some strange
 behavior on some reviews, when we try to update some reviews. Seems like
 when the developers submit publish the nothing happens and the new review
 does not get published.

 I have the following warring and this may or may not explain such
 behavior or any other potential issue.

  23:00:49WARNING

  - Cache data for key 
 codereview.local:/:diffviewer/diff_file_fragment.html-3-1-3809-collapsed-highlighting-en-1401231630
  (length 1706544) may be too big for the cache.

  01:45:59WARNING

  - 
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/models/fields/__init__.py:848:
  RuntimeWarning: DateTimeField User.last_login received a naive datetime 
 (2014-05-21 00:00:00) while time zone support is active.
   RuntimeWarning)

  1:46:00WARNING

  - 
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/http/response.py:327:
  DeprecationWarning: Using mimetype keyword argument is deprecated, use 
 content_type instead
   super(HttpResponse, self).__init__(*args, **kwargs)


 Is there any way to increase the level of verbosity, so far the only
 change that I made is enable DEBUG = True on settings_local.py

  --
 Get the Review Board Power Pack at http://www.reviewboard.org/
 powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.



 See why you should attend BroadSoft Connections 2014
 http://broadsoftconnections.com/

 This email is intended solely for the person or entity to which it is
 addressed and may contain confidential and/or privileged information. If
 you are not the intended recipient and have received this email in error,
 please notify BroadSoft, Inc. immediately by replying to this message, and
 destroy all copies of this message, along with any attachment, prior to
 reading, distributing or copying it.

 --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


  --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to a topic in the
 Google Groups reviewboard group.
 To unsubscribe from this topic, visit
 https://groups.google.com/d/topic/reviewboard/M_xRSmgWRQo/unsubscribe.
 To unsubscribe from this group and all its topics, send an email to
 reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 

See why you should attend BroadSoft Connections 
2014http://broadsoftconnections.com/

This email is intended solely for the person or entity to which it is 
addressed and may contain 

Re: Fedora rawhide: RB Dashboard missing Edit Columns button and column styling

2014-06-02 Thread Stephen Gallagher
On 06/02/2014 11:58 AM, Stephen Gallagher wrote:
 On 06/02/2014 11:46 AM, Paul Fee wrote:
 Hi Stephen,

 Comparing the HTML using Firefox/Firebug, I see both good and bad pages
 have the correct HTML to display the Edit columns heading.  However
 the bad page has missing CSS styling.

 On Fedora rawhide, with an up to date locate database, I can see an
 empty CSS file that looks suspicious.

 $ ls -l `locate datagrid | grep css`
 -rw-r--r--. 1 root root 6251 May 27 15:03
 /usr/lib/python2.7/site-packages/djblets/htdocs/static/djblets/css/datagrid.css
 -rw-r--r--. 1 root root 6316 May 27 15:03
 /usr/lib/python2.7/site-packages/djblets/htdocs/static/djblets/css/datagrid.da6c340af879.css
 -rw-r--r--. 1 root root 6316 May 27 02:01
 /usr/lib/python2.7/site-packages/djblets/htdocs/static/djblets/css/datagrid.min.6521a0d8b348.css
 -rw-r--r--. 1 root root0 May 27 15:03
 /usr/lib/python2.7/site-packages/djblets/htdocs/static/djblets/css/datagrid.min.css
 -rw-r--r--. 1 root root0 May 27 15:03
 /usr/lib/python2.7/site-packages/djblets/htdocs/static/djblets/css/datagrid.min.d41d8cd98f00.css
 -rw-r--r--. 1 root root 6251 May 27 02:01
 /usr/lib/python2.7/site-packages/djblets/static/djblets/css/datagrid.css

 I expect those two empty files are (part of) the problem.

 According to rpm -qf they're both owned by
 python-djblets-0.8.1-1.fc21.noarch.

 
 
 Thanks, Paul. I hadn't spotted that. I suspect you're right. Looks like
 the minification of datagrid.css may have broken somehow.
 


With help from Christian, we sorted this out today and got a release of
Djblets 0.8.2 out (with just the one fix for this issue).

I've done a Rawhide build of Djblets (and a rebuild of Review Board to
update the dependency), so it should be available in your local mirror
within 48 hours.

If you want it sooner than that, you can get the raw RPMs from
http://koji.fedoraproject.org/koji/taskinfo?taskID=6919241

I've also kicked off this update in my COPR repository for Fedora 20, so
that will be available shortly there as well.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Problem upgrading from 1.6.9 to 2.0.1

2014-06-02 Thread Thomas Allen
I'm attempting a Reviewboard 1.6.9-2.0 migration.  This is on Ubuntu 12.04 
and I'm using postgresql as the database.

I've updated review-board with this command:

 sudo easy_install -U ReviewBoard

Based on the release notes, I went ahead and removed PIL and installed 
pillow, but then rb-site did not even run. I re-installed PIL with sudo 
easy_install pil and then I get this error when I run sudo rb-site 
upgrade /var/www/review-board:

Traceback (most recent call last):
   File /usr/local/bin/rb-site, line 9, in module
 load_entry_point('ReviewBoard==2.0.1', 'console_scripts', 'rb-site')()
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/cmdline/rbsite.py,
  
 line 1733, in main
 command.run()
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/cmdline/rbsite.py,
  
 line 1536, in run
 diff_dedup_needed = site.get_diff_dedup_needed()
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/cmdline/rbsite.py,
  
 line 442, in get_diff_dedup_needed
 return FileDiff.objects.unmigrated().count()  0
   File 
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/models/query.py,
  
 line 294, in count
 return self.query.get_count(using=self.db)
   File 
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/models/sql/query.py,
  
 line 390, in get_count
 number = obj.get_aggregation(using=using)[None]
   File 
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/models/sql/query.py,
  
 line 356, in get_aggregation
 result = query.get_compiler(using).execute_sql(SINGLE)
   File 
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/models/sql/compiler.py,
  
 line 786, in execute_sql
 cursor.execute(sql, params)
   File 
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/backends/util.py,
  
 line 69, in execute
 return super(CursorDebugWrapper, self).execute(sql, params)
   File 
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/backends/util.py,
  
 line 53, in execute
 return self.cursor.execute(sql, params)
   File 
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/utils.py,
  
 line 99, in __exit__
 six.reraise(dj_exc_type, dj_exc_value, traceback)
   File 
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/backends/util.py,
  
 line 53, in execute
 return self.cursor.execute(sql, params)
 django.db.utils.ProgrammingError: column diffviewer_filediff.diff_hash_id 
 does not exist
 LINE 1: ...CT COUNT(*) FROM diffviewer_filediff WHERE NOT (diffviewe...


Based on some comments in similar threads, I went into the rbsite.py file 
and made the site.get_diff_dedup_needed function return True to get past 
this error, but then I end up with another error:

Rebuilding directory structure
 Updating database. This may take a while.
 The log output below, including warnings and errors,
 can be ignored unless upgrade fails.
 -- begin log output --
 Creating tables ...
 There are unapplied evolutions for auth.
 There are unapplied evolutions for contenttypes.
 There are unapplied evolutions for accounts.
 There are unapplied evolutions for attachments.
 There are unapplied evolutions for changedescs.
 There are unapplied evolutions for diffviewer.
 There are unapplied evolutions for hostingsvcs.
 There are unapplied evolutions for reviews.
 There are unapplied evolutions for scmtools.
 There are unapplied evolutions for site.
 Project signature has changed - an evolution is required
 Installing custom SQL ...
 Installing indexes ...
 Installed 0 object(s) from 0 fixture(s)
 ERROR:root:Unexpected error: 'NoneType' object is not iterable
 Traceback (most recent call last):
   File 
 /usr/local/lib/python2.7/dist-packages/django_evolution-0.7.1-py2.7.egg/django_evolution/management/commands/evolve.py,
  
 line 65, in handle
 self.evolve(*app_labels, **options)
   File 
 /usr/local/lib/python2.7/dist-packages/django_evolution-0.7.1-py2.7.egg/django_evolution/management/commands/evolve.py,
  
 line 125, in evolve
 sql.extend(self.evolve_app(app))
   File 
 /usr/local/lib/python2.7/dist-packages/django_evolution-0.7.1-py2.7.egg/django_evolution/management/commands/evolve.py,
  
 line 165, in evolve_app
 app_mutator_sql = app_mutator.to_sql()
   File 
 /usr/local/lib/python2.7/dist-packages/django_evolution-0.7.1-py2.7.egg/django_evolution/mutators.py,
  
 line 303, in to_sql
 sql.extend(mutator.to_sql())
   File 
 /usr/local/lib/python2.7/dist-packages/django_evolution-0.7.1-py2.7.egg/django_evolution/mutators.py,
  
 line 186, in to_sql
 return self.evolver.generate_table_ops_sql(self, self._ops)
   File 
 /usr/local/lib/python2.7/dist-packages/django_evolution-0.7.1-py2.7.egg/django_evolution/db/common.py,
  
 line 42, in generate_table_ops_sql
 

Re: Problem upgrading from 1.6.9 to 2.0.1

2014-06-02 Thread Christian Hammond
Looks like there was a similar bug in the Postgres backend. I'm working on
a fix now, and will reply when there's a new Django Evolution version for
you to try.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com


On Mon, Jun 2, 2014 at 2:23 PM, Thomas Allen tho...@agilelaw.com wrote:

 I'm attempting a Reviewboard 1.6.9-2.0 migration.  This is on Ubuntu
 12.04 and I'm using postgresql as the database.

 I've updated review-board with this command:

  sudo easy_install -U ReviewBoard

 Based on the release notes, I went ahead and removed PIL and installed
 pillow, but then rb-site did not even run. I re-installed PIL with sudo
 easy_install pil and then I get this error when I run sudo rb-site
 upgrade /var/www/review-board:

 Traceback (most recent call last):
   File /usr/local/bin/rb-site, line 9, in module
 load_entry_point('ReviewBoard==2.0.1', 'console_scripts', 'rb-site')()
   File
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/cmdline/rbsite.py,
 line 1733, in main
 command.run()
   File
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/cmdline/rbsite.py,
 line 1536, in run
 diff_dedup_needed = site.get_diff_dedup_needed()
   File
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/cmdline/rbsite.py,
 line 442, in get_diff_dedup_needed
 return FileDiff.objects.unmigrated().count()  0
   File
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/models/query.py,
 line 294, in count
 return self.query.get_count(using=self.db)
   File
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/models/sql/query.py,
 line 390, in get_count
 number = obj.get_aggregation(using=using)[None]
   File
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/models/sql/query.py,
 line 356, in get_aggregation
 result = query.get_compiler(using).execute_sql(SINGLE)
   File
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/models/sql/compiler.py,
 line 786, in execute_sql
 cursor.execute(sql, params)
   File
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/backends/util.py,
 line 69, in execute
 return super(CursorDebugWrapper, self).execute(sql, params)
   File
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/backends/util.py,
 line 53, in execute
 return self.cursor.execute(sql, params)
   File
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/utils.py,
 line 99, in __exit__
 six.reraise(dj_exc_type, dj_exc_value, traceback)
   File
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/backends/util.py,
 line 53, in execute
 return self.cursor.execute(sql, params)
 django.db.utils.ProgrammingError: column diffviewer_filediff.diff_hash_id
 does not exist
 LINE 1: ...CT COUNT(*) FROM diffviewer_filediff WHERE NOT (diffviewe...


 Based on some comments in similar threads, I went into the rbsite.py file
 and made the site.get_diff_dedup_needed function return True to get past
 this error, but then I end up with another error:

 Rebuilding directory structure
 Updating database. This may take a while.
 The log output below, including warnings and errors,
 can be ignored unless upgrade fails.
 -- begin log output --
 Creating tables ...
 There are unapplied evolutions for auth.
 There are unapplied evolutions for contenttypes.
 There are unapplied evolutions for accounts.
 There are unapplied evolutions for attachments.
 There are unapplied evolutions for changedescs.
 There are unapplied evolutions for diffviewer.
 There are unapplied evolutions for hostingsvcs.
 There are unapplied evolutions for reviews.
 There are unapplied evolutions for scmtools.
 There are unapplied evolutions for site.
 Project signature has changed - an evolution is required
 Installing custom SQL ...
 Installing indexes ...
 Installed 0 object(s) from 0 fixture(s)
 ERROR:root:Unexpected error: 'NoneType' object is not iterable
 Traceback (most recent call last):
   File
 /usr/local/lib/python2.7/dist-packages/django_evolution-0.7.1-py2.7.egg/django_evolution/management/commands/evolve.py,
 line 65, in handle
 self.evolve(*app_labels, **options)
   File
 /usr/local/lib/python2.7/dist-packages/django_evolution-0.7.1-py2.7.egg/django_evolution/management/commands/evolve.py,
 line 125, in evolve
 sql.extend(self.evolve_app(app))
   File
 /usr/local/lib/python2.7/dist-packages/django_evolution-0.7.1-py2.7.egg/django_evolution/management/commands/evolve.py,
 line 165, in evolve_app
 app_mutator_sql = app_mutator.to_sql()
   File
 /usr/local/lib/python2.7/dist-packages/django_evolution-0.7.1-py2.7.egg/django_evolution/mutators.py,
 line 303, in to_sql
 sql.extend(mutator.to_sql())
   File
 

Re: Problem upgrading from 1.6.9 to 2.0.1

2014-06-02 Thread Christian Hammond
Go ahead and update django_evolution:

$ sudo easy_install -U django_evolution

The 0.7.2 release should hopefully fix these issues.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com


On Mon, Jun 2, 2014 at 3:08 PM, Christian Hammond chip...@chipx86.com
wrote:

 Looks like there was a similar bug in the Postgres backend. I'm working on
 a fix now, and will reply when there's a new Django Evolution version for
 you to try.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com


 On Mon, Jun 2, 2014 at 2:23 PM, Thomas Allen tho...@agilelaw.com wrote:

 I'm attempting a Reviewboard 1.6.9-2.0 migration.  This is on Ubuntu
 12.04 and I'm using postgresql as the database.

 I've updated review-board with this command:

  sudo easy_install -U ReviewBoard

 Based on the release notes, I went ahead and removed PIL and installed
 pillow, but then rb-site did not even run. I re-installed PIL with sudo
 easy_install pil and then I get this error when I run sudo rb-site
 upgrade /var/www/review-board:

 Traceback (most recent call last):
   File /usr/local/bin/rb-site, line 9, in module
 load_entry_point('ReviewBoard==2.0.1', 'console_scripts',
 'rb-site')()
   File
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/cmdline/rbsite.py,
 line 1733, in main
 command.run()
   File
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/cmdline/rbsite.py,
 line 1536, in run
 diff_dedup_needed = site.get_diff_dedup_needed()
   File
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/cmdline/rbsite.py,
 line 442, in get_diff_dedup_needed
 return FileDiff.objects.unmigrated().count()  0
   File
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/models/query.py,
 line 294, in count
 return self.query.get_count(using=self.db)
   File
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/models/sql/query.py,
 line 390, in get_count
 number = obj.get_aggregation(using=using)[None]
   File
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/models/sql/query.py,
 line 356, in get_aggregation
 result = query.get_compiler(using).execute_sql(SINGLE)
   File
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/models/sql/compiler.py,
 line 786, in execute_sql
 cursor.execute(sql, params)
   File
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/backends/util.py,
 line 69, in execute
 return super(CursorDebugWrapper, self).execute(sql, params)
   File
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/backends/util.py,
 line 53, in execute
 return self.cursor.execute(sql, params)
   File
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/utils.py,
 line 99, in __exit__
 six.reraise(dj_exc_type, dj_exc_value, traceback)
   File
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/backends/util.py,
 line 53, in execute
 return self.cursor.execute(sql, params)
 django.db.utils.ProgrammingError: column
 diffviewer_filediff.diff_hash_id does not exist
 LINE 1: ...CT COUNT(*) FROM diffviewer_filediff WHERE NOT
 (diffviewe...


 Based on some comments in similar threads, I went into the rbsite.py file
 and made the site.get_diff_dedup_needed function return True to get past
 this error, but then I end up with another error:

 Rebuilding directory structure
 Updating database. This may take a while.
 The log output below, including warnings and errors,
 can be ignored unless upgrade fails.
 -- begin log output --
 Creating tables ...
 There are unapplied evolutions for auth.
 There are unapplied evolutions for contenttypes.
 There are unapplied evolutions for accounts.
 There are unapplied evolutions for attachments.
 There are unapplied evolutions for changedescs.
 There are unapplied evolutions for diffviewer.
 There are unapplied evolutions for hostingsvcs.
 There are unapplied evolutions for reviews.
 There are unapplied evolutions for scmtools.
 There are unapplied evolutions for site.
 Project signature has changed - an evolution is required
 Installing custom SQL ...
 Installing indexes ...
 Installed 0 object(s) from 0 fixture(s)
 ERROR:root:Unexpected error: 'NoneType' object is not iterable
 Traceback (most recent call last):
   File
 /usr/local/lib/python2.7/dist-packages/django_evolution-0.7.1-py2.7.egg/django_evolution/management/commands/evolve.py,
 line 65, in handle
 self.evolve(*app_labels, **options)
   File
 /usr/local/lib/python2.7/dist-packages/django_evolution-0.7.1-py2.7.egg/django_evolution/management/commands/evolve.py,
 line 125, in evolve
 sql.extend(self.evolve_app(app))
   File
 

Issue 3394 in reviewboard: Problem with upgrade from 1.7.22 to 2.0.1. Django evolution fails

2014-06-02 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3394 by rafal.wo...@gmail.com: Problem with upgrade from 1.7.22  
to 2.0.1. Django evolution fails

http://code.google.com/p/reviewboard/issues/detail?id=3394

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
rejected.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this bug report!


What version are you running?
1.7.22

What's the URL of the page containing the problem?
N/A

What steps will reproduce the problem?
1. Install RB 2.0.1
2. Run rb-site upgrade /path/to/my/board
3. Run once again rb-site upgrade /path/to/my/board

What is the expected output? What do you see instead?

After the first run of the upgrade command, rb-site upgrade /path/ I get:
Rebuilding directory structure
Updating database. This may take a while.

The log output below, including warnings and errors,
can be ignored unless upgrade fails.

-- begin log output --
Creating tables ...
Upgrading Review Board from 1.7.22 to 2.0.1
There are unapplied evolutions for auth.
There are unapplied evolutions for contenttypes.
There are unapplied evolutions for accounts.
There are unapplied evolutions for attachments.
There are unapplied evolutions for changedescs.
There are unapplied evolutions for diffviewer.
There are unapplied evolutions for hostingsvcs.
There are unapplied evolutions for reviews.
There are unapplied evolutions for scmtools.
Adding baseline version for new models
Project signature has changed - an evolution is required
Installing custom SQL ...
Installing indexes ...
Installed 0 object(s) from 0 fixture(s)
Evolution successful.
--- end log output ---

Resetting in-database caches.

Upgrade complete!


If the command is run the second time, it ends with error message:

Rebuilding directory structure
Updating database. This may take a while.

The log output below, including warnings and errors,
can be ignored unless upgrade fails.

-- begin log output --
Creating tables ...
Project signature has changed - an evolution is required
Installing custom SQL ...
Installing indexes ...
Installed 0 object(s) from 0 fixture(s)
The stored evolutions do not completely resolve all model changes.

Run `./manage.py evolve --hint` to see a suggestion for the changes  
required.


The following are the changes that could not be resolved:
The application markup has been deleted
In model changedescs.ChangeDescription:
Field 'rich_text' has been added
In model attachments.FileAttachment:
Field 'added_in_filediff' has been added
Field 'repository' has been added
Field 'repo_revision' has been added
Field 'repo_path' has been added
In model auth.Permission:
Meta property 'unique_together' has changed
In model reviews.Comment:
Field 'rich_text' has been added
Field 'extra_data' has been added
In model reviews.Group:
Field 'extra_data' has been added
In field 'mailing_list':
Property 'max_length' has changed
Meta property 'unique_together' has changed
In model reviews.FileAttachmentComment:
Field 'diff_against_file_attachment' has been added
Field 'rich_text' has been added
In model reviews.Review:
Field 'rich_text' has been added
Field 'extra_data' has been added
In model reviews.ReviewRequestDraft:
Field 'commit_id' has been added
Field 'extra_data' has been added
Field 'rich_text' has been added
In model reviews.ReviewRequest:
Field 'issue_dropped_count' has been added
Field 'extra_data' has been added
Field 'commit_id' has been added
Field 'issue_resolved_count' has been added
Field 'issue_open_count' has been added
Field 'rich_text' has been added
Meta property 'unique_together' has changed
In model reviews.ScreenshotComment:
Field 'rich_text' has been added
Field 'extra_data' has been added
In model contenttypes.ContentType:
Meta property 'unique_together' has changed
In model accounts.Profile:
Field 'show_closed' has been added
Field 'show_submitted' has been deleted
In model accounts.ReviewRequestVisit:
Meta property 'unique_together' has changed
In model accounts.LocalSiteProfile:
Meta property 'unique_together' has changed
In model scmtools.Repository:
Meta property 'unique_together' has changed
In model diffviewer.DiffSet:
Field 'extra_data' has been added
In model diffviewer.FileDiffData:
Field 'extra_data' has been added
In model diffviewer.DiffSetHistory:
Field 'extra_data' has been added
In model diffviewer.FileDiff:
Field 'extra_data' has been added
CommandError: Your models contain changes that Django Evolution cannot  
resolve automatically.



What operating system are you using? What browser?
Ubuntu 

Re: Issue 3394 in reviewboard: Problem with upgrade from 1.7.22 to 2.0.1. Django evolution fails

2014-06-02 Thread reviewboard

Updates:
Status: NeedInfo

Comment #1 on issue 3394 by chip...@gmail.com: Problem with upgrade from  
1.7.22 to 2.0.1. Django evolution fails

http://code.google.com/p/reviewboard/issues/detail?id=3394

This is almost always due to upgrading, then downgrading, then upgrading  
again. Or, a previously failed upgrade attempt due to some other error  
(often a MyISAM vs. InnoDB table difference).


Can you show me the output of:

rb-site manage /path/to/site list-evolutions

Also, was this the very first upgrade attempt?

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3394 in reviewboard: Problem with upgrade from 1.7.22 to 2.0.1. Django evolution fails

2014-06-02 Thread reviewboard


Comment #2 on issue 3394 by rafal.wo...@gmail.com: Problem with upgrade  
from 1.7.22 to 2.0.1. Django evolution fails

http://code.google.com/p/reviewboard/issues/detail?id=3394

It is the very first attempt to upgrade this 1.7.22 version to 2.0.1. I am  
trying to test new 2.0.1 in testing environment separated from my 1.7.22  
production instance. I can migrate the database from production with  
mysqldump or restore the whole environment from backup but the error stops  
me every time and I do not know what could be wrong. This production  
instance was upgraded many times but never downgraded.



Applied evolutions for 'auth':
auth_delete_message
auth_unique_together_baseline

Applied evolutions for 'contenttypes':
contenttypes_unique_together_baseline

Applied evolutions for 'sessions':
session_expire_date_db_index

Applied evolutions for 'accounts':
is_private
timezone
open_an_issue
extra_data
timezone_length_30
localsiteprofile_permissions
unique_together_baseline
profile_show_closed

Applied evolutions for 'attachments':
file_attachment_orig_filename
file_attachment_file_max_length_512
file_attachment_repo_info
file_attachment_repo_path_no_index
file_attachment_repo_revision_max_length_64

Applied evolutions for 'changedescs':
fields_changed_longtext
rich_text

Applied evolutions for 'diffviewer':
add_parent_diffs
filediff_filenames_1024_chars
diffset_basedir
filediff_status
add_diff_hash
diffsethistory_diff_updated
diffset_base_commit_id
filediffdata_line_counts
filediffdata_extra_data
all_extra_data

Applied evolutions for 'hostingsvcs':
account_hosting_url
account_hosting_url_max_length_255
account_unique_together_baseline

Applied evolutions for 'reviews':
change_descriptions
last_review_timestamp
shipit_count
default_reviewer_repositories
null_repository
localsite
group_incoming_request_count
group_invite_only
group_visible
default_reviewer_local_site
add_issues_to_comments
file_attachments
file_attachment_comment_extra_data
review_request_last_review_activity_timestamp
review_request_depends_on
commit_id
file_attachment_comment_diff_id
rich_text
base_comment_extra_data
unique_together_baseline
extra_data
review_request_issue_counts
group_mailing_list_charfield
review_request_draft_commit_id

Applied evolutions for 'scmtools':
bugzilla_url_charfield
repository_raw_file_url
repository_visible
repository_path_length_255
localsite
repository_access_control
group_site
repository_hosting_accounts
repository_extra_data_null
unique_together_baseline

Applied evolutions for 'site':
localsite_public



--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3394 in reviewboard: Problem with upgrade from 1.7.22 to 2.0.1. Django evolution fails

2014-06-02 Thread reviewboard


Comment #3 on issue 3394 by rafal.wo...@gmail.com: Problem with upgrade  
from 1.7.22 to 2.0.1. Django evolution fails

http://code.google.com/p/reviewboard/issues/detail?id=3394

After few more tries I managed to finish rb-site upgrade without any  
errors :) Unfortunately I cannot tell what I did wrong and what solved the  
problem, sorry.


At the moment I have another problem with formatting in review request  
window (please see attached image). Text areas seem to be badly formatted  
and too wide. It occurs only for migrated review requests. Newly created  
review requests look well, as it should.


I confirmed the formatting problem in chromium-browser, firefox and IE8.

Could it be upgrading/evolution related issue?

Attachments:
review_problem.png  21.9 KB

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3395 in reviewboard: Password reset unsuccessful

2014-06-02 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3395 by ipe...@gmail.com: Password reset unsuccessful
http://code.google.com/p/reviewboard/issues/detail?id=3395

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
rejected.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this bug report!


What version are you running?
2.0.1

What's the URL of the page containing the problem?
https://reviews.reviewboard.org/account/reset/MzAxMDE-3s4-b1fd01d35d993ad1b3aa/

What steps will reproduce the problem?
1. Request a password reset
2. Click on the email link
3. Password reset unsuccessful.

What is the expected output? What do you see instead?
I expect a password reset form. Instead a message is displayed:
The password reset link was invalid, either because it expired or has  
already been used. Please request a new one here.


What operating system are you using? What browser?
Linux Mint 16, Chrome  33.0.1750.149

Please provide any additional information below.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3396 in reviewboard: No logging in RB 1.7.25 - instead getting apache error

2014-06-02 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3396 by alexkb...@gmail.com: No logging in RB 1.7.25 - instead  
getting apache error

http://code.google.com/p/reviewboard/issues/detail?id=3396

What version are you running?
Review Board 1.7.25 on Centos 6.5 with Apache 2.2.15; Python 2.6. As best I  
can tell, I'm using Django 1.4.11 and Djblets 0.7.29.


What's the URL of the page containing the problem?
Running on local network (no public url)

What steps will reproduce the problem?
1. From web ui, create new review request assigned to self, with summary,  
description, and all other fields left blank

2. Publish request
3a. Navigate to admin panel  Server Log
3b. From ssh tunnel to server: list the contents of the error log directory  
(as specified from the web ui config pane under Admin  Logging)


What is the expected output? What do you see instead?
Expected to see something logged in the web ui; expected to see a log file  
in the log file directory. Log file from ui and log file directory are both  
empty. Instead, the apache error log contains:

[Mon Jun 02 17:32:53 2014] [error] Traceback (most recent call last):
[Mon Jun 02 17:32:53 2014] [error]
File /usr/lib64/python2.6/logging/__init__.py, line 776, in emit

[Mon Jun 02 17:32:53 2014] [error] msg = self.format(record)
[Mon Jun 02 17:32:53 2014] [error]
File /usr/lib64/python2.6/logging/__init__.py, line 654, in format

[Mon Jun 02 17:32:53 2014] [error] return fmt.format(record)
[Mon Jun 02 17:32:53 2014] [error]
File /usr/lib64/python2.6/logging/__init__.py, line 439, in format

[Mon Jun 02 17:32:53 2014] [error] s = self._fmt % record.__dict__
[Mon Jun 02 17:32:53 2014] [error] KeyError: 'request_info'

See below for additional details.

What operating system are you using? What browser?
See version section. Not browser related.

Please provide any additional information below.
Bug report requested by Christian Hammond after an email exchange, included  
below:


From: Christian Hammond chip...@chipx86.com
Subject: Re: 1.5 to 1.7 DB Migration
Date: May 30, 2014 at 3:45:40 PM MDT
To: alexkb...@gmail.com
Cc: reviewbo...@googlegroups.com reviewbo...@googlegroups.com

It's more likely to be a bug than a configuration issue. This code is old,  
though. I'm surprised people are starting to report issues here.


I need more of the traceback. Can you show me the entire trace, along with  
the exact repro case?


In fact, would you mind filing a bug with this information, so we can track  
it?


Christian

--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com


On Fri, May 30, 2014 at 2:20 PM, alexkb...@gmail.com wrote:
I'm having a very similar problem to schmi...@gmail.com. I'm running Review  
Board 1.7.25 on Centos 6.5 with Apache 2.2.15; Python 2.6. As best I can  
tell, I'm using Django 1.4.11 and Djblets 0.7.29. (I found this by looking  
at __init__.py from the /usr/lib/python2.6/site-packages/djblets  
and ...django.) This is a new install of RB, not a migration from a  
previous version.


I have not been able to get the RB logging to do anything. I changed the  
settings from the admin panel as documented - nothing. (empty log files,  
nothing on the web ui Server Log.) I checked the ownership of the logging  
directory - apache user has write permissions. I know from some other  
debugging that the Apache server is running as the 'apache' user. To be  
really sure it wasn't a permission issue, I set the logging directory to  
/tmp - still nothing there and nothing from the web ui.


Next step was the apache error logs, which led me to this discussion. I am  
getting errors from /usr/lib64/python2.6/logging/__init__.py


I noticed that they at a different line number from schmi...@gmail.com's  
post, and that I'm using python 2.6 instead of 2.7.


Here is the apache error log snippet:
[Fri May 30 00:01:24 2014] [error] Traceback (most recent call last):
[Fri May 30 00:01:24 2014] [error]
File /usr/lib64/python2.6/logging/__init__.py, line 776, in emit

[Fri May 30 00:01:24 2014] [error] msg = self.format(record)
[Fri May 30 00:01:24 2014] [error]
File /usr/lib64/python2.6/logging/__init__.py, line 654, in format

[Fri May 30 00:01:24 2014] [error] return fmt.format(record)
[Fri May 30 00:01:24 2014] [error]
File /usr/lib64/python2.6/logging/__init__.py, line 439, in format

[Fri May 30 00:01:24 2014] [error] s = self._fmt % record.__dict__
[Fri May 30 00:01:24 2014] [error] KeyError: 'request_info'

A note on versions/install:
following the review board install instructions:  
http://www.reviewboard.org/docs/manual/dev/admin/installation/linux/

Python: it says 2.5 or newer is acceptable , so I'm fine on that front.
CentOS: it supports it, but requires the EPEL package repository, which I  
have


However, I was not the one who installed RB, so I can't confirm that the  
install procedure was 

Re: Issue 3394 in reviewboard: Problem with upgrade from 1.7.22 to 2.0.1. Django evolution fails

2014-06-02 Thread reviewboard

Updates:
Status: SetupIssue

Comment #4 on issue 3394 by chip...@gmail.com: Problem with upgrade from  
1.7.22 to 2.0.1. Django evolution fails

http://code.google.com/p/reviewboard/issues/detail?id=3394

Can you please file a separate bug for the text areas? We keep bug reports  
to one incident per report.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3396 in reviewboard: No logging in RB 1.7.25 - instead getting apache error

2014-06-02 Thread reviewboard

Updates:
Status: NeedInfo

Comment #1 on issue 3396 by chip...@gmail.com: No logging in RB 1.7.25 -  
instead getting apache error

http://code.google.com/p/reviewboard/issues/detail?id=3396

Can you tell me what your web server configuration is like?

In particular, are you using mod_wsgi, or something else?

Are you using the worker MPM or the prefork MPM?

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3396 in reviewboard: No logging in RB 1.7.25 - instead getting apache error

2014-06-02 Thread reviewboard


Comment #2 on issue 3396 by alexkb...@gmail.com: No logging in RB 1.7.25 -  
instead getting apache error

http://code.google.com/p/reviewboard/issues/detail?id=3396

We're using prefork MPM and mod_wsgi

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.