Re: Unable to view SVN diff after migration from 1.7.x to 2.0.1
I've had a similar issue intermittently. Adding windows-1252 to the list of encodings mentioned by David fixed the issue On 3/06/2014 5:42 AM, Roudaille77 rudy.he...@gmail.com wrote: Hello, I have just updated my ReviewBoard site but I can't visualize the Subversion diff anymore... I can see : There was an error displaying this diff. Traceback (most recent call last): File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/views.py, line 236, in get renderer = self.create_renderer(context, *args, **kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/reviews/views.py, line 1102, in create_renderer *args, **kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/views.py, line 326, in create_renderer self.diff_file = self._get_requested_diff_file() File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/views.py, line 367, in _get_requested_diff_file request=self.request) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/diffutils.py, line 373, in populate_diff_chunks chunks = generator.get_chunks() File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py, line 148, in get_chunks large_data=True) File /usr/local/lib/python2.7/dist-packages/Djblets-0.8.1-py2.7.egg/djblets/cache/backend.py, line 109, in cache_memoize data = lookup_callable() File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py, line 147, in lambda lambda: list(self._get_chunks_uncached()), File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py, line 154, in _get_chunks_uncached old = get_original_file(self.filediff, self.request, encoding_list) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/diffutils.py, line 172, in get_original_file encoding, data = convert_to_unicode(data, encoding_list) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/diffutils.py, line 50, in convert_to_unicode return e, six.text_type(s, e) LookupError: unknown encoding: Any idea ? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Unable to view SVN diff after migration from 1.7.x to 2.0.1
This field is blank ! Le lundi 2 juin 2014 21:36:32 UTC+2, David Trowbridge a écrit : Can you tell us what's in the Encoding field (under Advanced Settings) in the repository admin? -David On Mon, Jun 2, 2014 at 7:53 AM, Roudaille77 rudy@gmail.com javascript: wrote: Hello, I have just updated my ReviewBoard site but I can't visualize the Subversion diff anymore... I can see : There was an error displaying this diff. Traceback (most recent call last): File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/views.py, line 236, in get renderer = self.create_renderer(context, *args, **kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/reviews/views.py, line 1102, in create_renderer *args, **kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/views.py, line 326, in create_renderer self.diff_file = self._get_requested_diff_file() File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/views.py, line 367, in _get_requested_diff_file request=self.request) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/diffutils.py, line 373, in populate_diff_chunks chunks = generator.get_chunks() File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py, line 148, in get_chunks large_data=True) File /usr/local/lib/python2.7/dist-packages/Djblets-0.8.1-py2.7.egg/djblets/cache/backend.py, line 109, in cache_memoize data = lookup_callable() File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py, line 147, in lambda lambda: list(self._get_chunks_uncached()), File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py, line 154, in _get_chunks_uncached old = get_original_file(self.filediff, self.request, encoding_list) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/diffutils.py, line 172, in get_original_file encoding, data = convert_to_unicode(data, encoding_list) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/diffutils.py, line 50, in convert_to_unicode return e, six.text_type(s, e) LookupError: unknown encoding: Any idea ? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Unable to view SVN diff after migration from 1.7.x to 2.0.1
Can you check to make sure that there's not a space in there? -David On Tue, Jun 3, 2014 at 12:28 AM, Roudaille77 rudy.he...@gmail.com wrote: This field is blank ! Le lundi 2 juin 2014 21:36:32 UTC+2, David Trowbridge a écrit : Can you tell us what's in the Encoding field (under Advanced Settings) in the repository admin? -David On Mon, Jun 2, 2014 at 7:53 AM, Roudaille77 rudy@gmail.com wrote: Hello, I have just updated my ReviewBoard site but I can't visualize the Subversion diff anymore... I can see : There was an error displaying this diff. Traceback (most recent call last): File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/views.py, line 236, in get renderer = self.create_renderer(context, *args, **kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/reviews/views.py, line 1102, in create_renderer *args, **kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/views.py, line 326, in create_renderer self.diff_file = self._get_requested_diff_file() File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/views.py, line 367, in _get_requested_diff_file request=self.request) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/diffutils.py, line 373, in populate_diff_chunks chunks = generator.get_chunks() File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py, line 148, in get_chunks large_data=True) File /usr/local/lib/python2.7/dist-packages/Djblets-0.8.1-py2.7.egg/djblets/cache/backend.py, line 109, in cache_memoize data = lookup_callable() File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py, line 147, in lambda lambda: list(self._get_chunks_uncached()), File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py, line 154, in _get_chunks_uncached old = get_original_file(self.filediff, self.request, encoding_list) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/diffutils.py, line 172, in get_original_file encoding, data = convert_to_unicode(data, encoding_list) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/diffutils.py, line 50, in convert_to_unicode return e, six.text_type(s, e) LookupError: unknown encoding: Any idea ? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Unable to view SVN diff after migration from 1.7.x to 2.0.1
No space. I tried to put windows-1252 as Christian mentioned, it solves the
problem !
Note that the diff files are generated by eclipse on Windows machines. My
SVN server is on a linux one.
I still have a similar problem : when I try to create a request from a
commited change, i get an 500 error and receive the following error :
Traceback (most recent call last):
File
/usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/core/handlers/base.py,
line 112, in get_response
response = wrapped_callback(request, *callback_args, **callback_kwargs)
File
/usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/views/decorators/cache.py,
line 52, in _wrapped_view_func
response = view_func(request, *args, **kwargs)
File
/usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/views/decorators/vary.py,
line 19, in inner_func
response = func(*args, **kwargs)
File
/usr/local/lib/python2.7/dist-packages/Djblets-0.8.1-py2.7.egg/djblets/webapi/resources.py,
line 451, in __call__
result = view(request, api_format=api_format, *args, **kwargs)
File
/usr/local/lib/python2.7/dist-packages/Djblets-0.8.1-py2.7.egg/djblets/webapi/resources.py,
line 672, in post
return self.create(*args, **kwargs)
File
/usr/local/lib/python2.7/dist-packages/Djblets-0.8.1-py2.7.egg/djblets/webapi/decorators.py,
line 115, in _call
return view_func(*args, **kwargs)
File
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/webapi/decorators.py,
line 110, in _check
return view_func(*args, **kwargs)
File
/usr/local/lib/python2.7/dist-packages/Djblets-0.8.1-py2.7.egg/djblets/webapi/decorators.py,
line 115, in _call
return view_func(*args, **kwargs)
File
/usr/local/lib/python2.7/dist-packages/Djblets-0.8.1-py2.7.egg/djblets/webapi/decorators.py,
line 136, in _checklogin
return view_func(*args, **kwargs)
File
/usr/local/lib/python2.7/dist-packages/Djblets-0.8.1-py2.7.egg/djblets/webapi/decorators.py,
line 115, in _call
return view_func(*args, **kwargs)
File
/usr/local/lib/python2.7/dist-packages/Djblets-0.8.1-py2.7.egg/djblets/webapi/decorators.py,
line 115, in _call
return view_func(*args, **kwargs)
File
/usr/local/lib/python2.7/dist-packages/Djblets-0.8.1-py2.7.egg/djblets/webapi/decorators.py,
line 285, in _validate
return view_func(*args, **new_kwargs)
File
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/webapi/resources/review_request.py,
line 564, in create
create_from_commit_id=create_from_commit_id)
File
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/reviews/managers.py,
line 135, in create
review_request.update_from_commit_id(commit_id)
File
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/reviews/models/base_review_request_details.py,
line 186, in update_from_commit_id
self.update_from_committed_change(commit_id)
File
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/reviews/models/base_review_request_details.py,
line 233, in update_from_committed_change
commit = self.repository.get_change(commit_id)
File
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/scmtools/models.py,
line 299, in get_change
return self.get_scmtool().get_change(revision)
File
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/scmtools/svn/__init__.py,
line 133, in get_change
return self.client.get_change(revision, cache_key)
File
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/scmtools/svn/pysvn.py,
line 213, in get_change
diff_options=['-u']).decode('utf-8')
File /usr/lib/python2.7/encodings/utf_8.py, line 16, in decode
return codecs.utf_8_decode(input, errors, True)
UnicodeDecodeError: 'utf8' codec can't decode byte 0xea in position 5092:
invalid continuation byte
Le mardi 3 juin 2014 09:31:23 UTC+2, David Trowbridge a écrit :
Can you check to make sure that there's not a space in there?
-David
On Tue, Jun 3, 2014 at 12:28 AM, Roudaille77 rudy@gmail.com
javascript: wrote:
This field is blank !
Le lundi 2 juin 2014 21:36:32 UTC+2, David Trowbridge a écrit :
Can you tell us what's in the Encoding field (under Advanced
Settings) in the repository admin?
-David
On Mon, Jun 2, 2014 at 7:53 AM, Roudaille77 rudy@gmail.com wrote:
Hello,
I have just updated my ReviewBoard site but I can't visualize the
Subversion diff anymore...
I can see :
There was an error displaying this diff.
Traceback (most recent call last):
File
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/views.py,
line 236, in get
renderer = self.create_renderer(context, *args, **kwargs)
File
Bulk Upload of Users
Hello, I have around 30 users who want to have an account created. Currently I see that I can do that via UI. Wanted to know if there is any bulk user creation option from CSV file or something on those lines. Best regards, Joe. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Fedora rawhide: RB Dashboard missing Edit Columns button and column styling
Thanks Stephen and Christian, I've downloaded the rawhide updates from Koji and confirmed they've fixed this issue. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Review Board 2.0.1 is released
On 29 May 2014 19:24, Stephen Gallagher step...@gallagherhome.com wrote: On 05/29/2014 07:19 AM, Cian Mc Govern wrote: On 28 May 2014 21:07, Stephen Gallagher step...@gallagherhome.com mailto:step...@gallagherhome.com wrote: On 05/26/2014 09:31 PM, Christian Hammond wrote: Hi everyone, Review Board 2.0.1 is out. It fixes a number of bugs that have been reported to us since last week's 2.0 release. A big thanks to everyone who's upgraded to 2.0 already and provided useful feedback to us! The full details of the release are up at: http://www.reviewboard.org/news/2014/05/26/review-board-2-0-1-released/ Review Board 2.0.1 is now available in the Fedora Rawhide repository as well as http://copr.fedoraproject.org/coprs/sgallagh/ReviewBoard2/ for Fedora 20. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com mailto:reviewboard%2bunsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. Any chance of a package for EL6? I'm currently working on packaging it for EPEL 7, after which I may look into an EL 6 COPR. The EPEL packages will stay on the 1.7.x branch for the immediate future (until enough people can verify with the COPR that an upgrade isn't going to break them). I try to be REALLY conservative with upgrades on EL branches. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. Thanks Stephen. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Review Board 2.x and hg postreview
I and my team are still using hg postreview daily, including after upgrading to RB 2.0.1, and I'm still maintaining it as and when I have time (although I admit I've fallen behind on some of the requests in the issues list). I haven't worked much with RBTools; I'm sure it works fine but what we like about postreview is that it follows the same syntax and logic as other Mercurial commands, which means you don't have to learn a new tool. It also integrates with TortoiseHg, which is handy for those who prefer a GUI. As I mentioned in the bug report, and as Sara noted, the problem you're experiencing does not seem to be specific to hg postreview and does not seem to have changed since the upgrade to 2.x. It is something I'd like to get to the bottom of though so if you have any further information, e.g. what's going on in the particular diffs and parent diffs that cause this issue, I'd be glad to take a look at it. Colin On 06/02/2014 11:21 AM, Bruce Cran wrote: I'm investigating upgrading our installation to Review Board 2.x and one issue I've come across is that with the existing code, hg postreview doesn't work correctly. I've submitted a ticket to https://bitbucket.org/ccaughie/hgreviewboard, but I was wondering - are people still planning to use the hg postreview extension, or are you all switching to the rbt client? -- Bruce -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com mailto:reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
GitHub/ReviewBoard workflow
Hello, I'd like to know what the workflows are like for people who use ReviewBoard with GitHub/git. The team is used to GH pull requests and I worry that if we let them push directly to the repository, the code that shows up in the repo vs the review might be different. I understand there's currently no button that I just click to make the changes show up in the repo. Would this be easy to implement? I've googled for extending RB, but the result from the official site 404s on me. Any help would be appreciated. Thanks! -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: ReviewBoard 2.0.1 and Subversion - API Error 207
Hi Dan,
Are you using PySVN on the server, or Subvertpy?
Internally, we're running the equivalent of:
$ svn cat base_repo_pathpath_from_diff@7134
It should be possible to run that and get the output.
99 times out of 100, when this happens, it's due to the resulting path
being invalid. You can sanity-check the path by editing
reviewboard/scmtools/svn/pysvn.py (if using PySVN, subvert.py otherwise),
finding the 'get_file' function, and adding this as the first statement:
logging.info('repopath = %s, path = %s, revision = %s' %
(self.repopath, path, revision))
Restart Apache, try again, and see if that looks like what you expect.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com
On Tue, Jun 3, 2014 at 3:33 AM, Dan Jackson danjackso...@googlemail.com
wrote:
I'm trying to setup ReviewBoard 2.0.1 for the first time. Mostly it seems
okay - I can get into the administration screen and add users/repos/etc -
but I'm failing at the last hurdle. I can't get it to integrate properly
with our Subversion server.
In the Change Repository screen, I've picked Custom Repository,
Subversion, and my path is set to the root of the repository. (
http://dev1:9980/company_name;) I have a valid username and password
entered (because the SVN server doesn't allow anonymous access.)
RBT setup-repo sees the ReviewBoard repository, and asks if I want to use
it (I do). It then generates the following .reviewboardrc:
REVIEWBOARD_URL = http://review.board.com;
REPOSITORY = CompanyName
RBT can generate a valid diff (content removed but...)
Index:
/PRODUCT/Code/Trunk/Server/PRODUCTServer/MacServer/NativeMacUsbInterface.cs
===
---
/PRODUCT/Code/Trunk/Server/PRODUCTServer/MacServer/NativeMacUsbInterface.cs
(revision
7134)
+++
/PRODUCT/Code/Trunk/Server/PRODUCTServer/MacServer/NativeMacUsbInterface.cs
(working
copy)
@@ -40,7 +40,7 @@
However, when I run rbt post --debug I get:
RBTools 0.6
Python 2.7.5 (default, Mar 9 2014, 22:15:05)
[GCC 4.2.1 Compatible Apple LLVM 5.0 (clang-500.0.68)]
Running on Darwin-13.2.0-x86_64-i386-64bit
Home = /Users/dan
Current directory = /Volumes/Data/Work/PRODUCT/Trunk
Checking for a Subversion repository...
Running: svn info --non-interactive
Running: diff --version
repository info: Path: http://dev1:9880/company_name, Base path:
/PRODUCT/Code/Trunk, Supports changesets: False
Making HTTP GET request to http://review.board.com/api/
Running: svn info --non-interactive
Running: diff --version
repository info: Path: http://dev1:9880/company_name, Base path:
/PRODUCT/Code/Trunk, Supports changesets: False
Running: svn status --ignore-externals
Running: svn diff --diff-cmd=diff --notice-ancestry -r BASE
Running: svn info
Server/PRODUCTServer/MacServer/NativeMacUsbInterface.cs
Running: svn info Server/PRODUCTServer/MacServer
Running: svn info Server/PRODUCTServer
Running: svn info Server
Running: svn info
Server/PRODUCTServer/MacServer/NativeMacUsbInterface.cs
Running: svn info
Server/PRODUCTServer/MacServer/NativeMacUsbInterface.cs
Running: svn info
Server/PRODUCTServer/MacServer/NativeMacUsbInterface.cs
Making HTTP GET request to
http://review.board.com/api/review-requests/
Making HTTP POST request to
http://review.board.com/api/review-requests/
Making HTTP GET request to
http://review.board.com/api/review-requests/23/diffs/
Making HTTP POST request to
http://review.board.com/api/review-requests/23/diffs/
Got API Error 207 (HTTP code 400): The file was not found in the
repository.
Error data: {u'stat': u'fail', u'file':
u'/PRODUCT/Code/Trunk/Server/PRODUCTServer/MacServer/NativeMacUsbInterface.cs',
u'err': {u'msg': u'The file was not found in the repository.', u'code':
207}, u'revision': u'7134'}
Traceback (most recent call last):
File /usr/local/bin/rbt, line 8, in module
load_entry_point('RBTools==0.6', 'console_scripts', 'rbt')()
File
/Library/Python/2.7/site-packages/RBTools-0.6-py2.7.egg/rbtools/commands/main.py,
line 134, in main
command.run_from_argv([RB_MAIN, command_name] + args)
File
/Library/Python/2.7/site-packages/RBTools-0.6-py2.7.egg/rbtools/commands/__init__.py,
line 422, in run_from_argv
exit_code = self.main(*args) or 0
File
/Library/Python/2.7/site-packages/RBTools-0.6-py2.7.egg/rbtools/commands/post.py,
line 769, in main
submit_as=self.options.submit_as)
File
/Library/Python/2.7/site-packages/RBTools-0.6-py2.7.egg/rbtools/commands/post.py,
line 545, in post_request
raise CommandError('\n'.join(error_msg))
rbtools.commands.CommandError: Error uploading diff
The file was not found in the repository. (HTTP 400, API Error 207)
Your review request still exists, but the diff is not attached.
The file
Re: GitHub/ReviewBoard workflow
Hi Daryl, Which result 404s? I'd like to get that fixed. You'll probably have a lot of answers to your question. I'll tell you what I do, and what I've seen many others do. Instead of the model of pushing to a branch and submitting a pull request, users instead commit locally and post to Review Board, using: $ rbt post When they're ready to update the review request, they don't need to push extra commits to that remote branch, or force-push the branch to keep it in a clean state. Instead, they just commit locally (as they would anyway), and run: $ rbt post -u One of the big differences in workflow is who's in charge of pushing to the repository. In Review Board's model, the developer is still in charge of pushing their commits. (You can have someone apply the review request's patch locally and push it under the other developer's name using 'rbt patch -c', but that's generally done more on open source projects and such). Since that does assume that developers have the ability to push their changes, you may have the issue where what's reviewed is not what goes in. We do not prevent this ourselves. Sometimes, this is totally okay. For instance, I'll sometimes post a review that opens some issues *and* chooses Ship It!, signaling to the other developer that once they fix those (trivial) issues, they can just push without updating the review request again. If you want more control, one option (with a standard Git repository) is to have a pre-commit hook that asks Review Board first if the change can go in. You could do something like compare hashes of the file contents, potentially. We don't bake any of this in, though. GitHub, unfortunately, does not support pre-commit hooks, so you'd be a bit out of luck there. In my personal opinion, this all comes down to culture and company policy. If people are caught pushing changes they shouldn't push, there's a bigger problem than just the tool's abilities. Review Board, historically, has tried not to bake in any strict policy support, since every company is a little bit different there. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Tue, Jun 3, 2014 at 7:17 AM, Daryl Yu jany...@gmail.com wrote: Hello, I'd like to know what the workflows are like for people who use ReviewBoard with GitHub/git. The team is used to GH pull requests and I worry that if we let them push directly to the repository, the code that shows up in the repo vs the review might be different. I understand there's currently no button that I just click to make the changes show up in the repo. Would this be easy to implement? I've googled for extending RB, but the result from the official site 404s on me. Any help would be appreciated. Thanks! -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: CRITICAL: tuple index out of range error with RBTools 0.6 and Mercurial
The issue here is that rbt can't figure out which branch is your upstream (that is, which one is also available on the repository configured in review board). You can use --tracking-branch to specify this manually. We'll get a fix for the terrible error message in for 0.6.1 -David On Sun, May 25, 2014 at 6:31 PM, OPL X oplx.0...@gmail.com wrote: Hello, Here's the output from 'hg showconfig' --- bundle.mainreporoot=/home/oplx/rb_repo/hg0 merge-tools.kdiff3.args=--auto --L1 base --L2 local --L3 other $base $local $other -o $output merge-tools.kdiff3.regkey=Software\KDiff3 merge-tools.kdiff3.regkeyalt=Software\Wow6432Node\KDiff3 merge-tools.kdiff3.regappend=\kdiff3.exe merge-tools.kdiff3.fixeol=True merge-tools.kdiff3.gui=True merge-tools.kdiff3.diffargs=--L1 '$plabel1' --L2 '$clabel' $parent $child merge-tools.gvimdiff.args=--nofork -d -g -O $local $other $base merge-tools.gvimdiff.regkey=Software\Vim\GVim merge-tools.gvimdiff.regkeyalt=Software\Wow6432Node\Vim\GVim merge-tools.gvimdiff.regname=path merge-tools.gvimdiff.priority=-9 merge-tools.vimdiff.args=$local $other $base -c 'redraw | echomsg hg merge conflict, type \:cq\ to abort vimdiff' merge-tools.vimdiff.check=changed merge-tools.vimdiff.priority=-10 merge-tools.merge.check=conflicts merge-tools.merge.priority=-100 merge-tools.gpyfm.gui=True merge-tools.meld.gui=True merge-tools.meld.args=--label='local' $local --label='merged' $base --label='other' $other -o $output merge-tools.meld.check=changed merge-tools.meld.diffargs=-a --label='$plabel1' $parent --label='$clabel' $child merge-tools.tkdiff.args=$local $other -a $base -o $output merge-tools.tkdiff.gui=True merge-tools.tkdiff.priority=-8 merge-tools.tkdiff.diffargs=-L '$plabel1' $parent -L '$clabel' $child merge-tools.xxdiff.args=--show-merged-pane --exit-with-merge-status --title1 local --title2 base --title3 other --merged-filename $output --merge $local $base $other merge-tools.xxdiff.gui=True merge-tools.xxdiff.priority=-8 merge-tools.xxdiff.diffargs=--title1 '$plabel1' $parent --title2 '$clabel' $child merge-tools.diffmerge.regkey=Software\SourceGear\SourceGear DiffMerge\ merge-tools.diffmerge.regkeyalt=Software\Wow6432Node\SourceGear\SourceGear DiffMerge\ merge-tools.diffmerge.regname=Location merge-tools.diffmerge.priority=-7 merge-tools.diffmerge.args=-nosplash -merge -title1=local -title2=merged -title3=other $local $base $other -result=$output merge-tools.diffmerge.check=changed merge-tools.diffmerge.gui=True merge-tools.diffmerge.diffargs=--nosplash --title1='$plabel1' --title2='$clabel' $parent $child merge-tools.p4merge.args=$base $local $other $output merge-tools.p4merge.regkey=Software\Perforce\Environment merge-tools.p4merge.regkeyalt=Software\Wow6432Node\Perforce\Environment merge-tools.p4merge.regname=P4INSTROOT merge-tools.p4merge.regappend=\p4merge.exe merge-tools.p4merge.gui=True merge-tools.p4merge.priority=-8 merge-tools.p4merge.diffargs=$parent $child merge-tools.tortoisemerge.args=/base:$base /mine:$local /theirs:$other /merged:$output merge-tools.tortoisemerge.regkey=Software\TortoiseSVN merge-tools.tortoisemerge.regkeyalt=Software\Wow6432Node\TortoiseSVN merge-tools.tortoisemerge.check=changed merge-tools.tortoisemerge.gui=True merge-tools.tortoisemerge.priority=-8 merge-tools.tortoisemerge.diffargs=/base:$parent /mine:$child /basename:'$plabel1' /minename:'$clabel' merge-tools.ecmerge.args=$base $local $other --mode=merge3 --title0=base --title1=local --title2=other --to=$output merge-tools.ecmerge.regkey=Software\Elli\xc3\xa9 Computing\Merge merge-tools.ecmerge.regkeyalt=Software\Wow6432Node\Elli\xc3\xa9 Computing\Merge merge-tools.ecmerge.gui=True merge-tools.ecmerge.diffargs=$parent $child --mode=diff2 --title1='$plabel1' --title2='$clabel' merge-tools.filemerge.executable=/Developer/Applications/Utilities/FileMerge.app/Contents/MacOS/FileMerge merge-tools.filemerge.args=-left $other -right $local -ancestor $base -merge $output merge-tools.filemerge.gui=True merge-tools.beyondcompare3.args=$local $other $base $output /ro /lefttitle=local /centertitle=base /righttitle=other /automerge /reviewconflicts /solo merge-tools.beyondcompare3.regkey=Software\Scooter Software\Beyond Compare 3 merge-tools.beyondcompare3.regname=ExePath merge-tools.beyondcompare3.gui=True merge-tools.beyondcompare3.priority=-2 merge-tools.beyondcompare3.diffargs=/lro /lefttitle='$plabel1' /righttitle='$clabel' /solo /expandall $parent $child merge-tools.bcompare.args=$local $other $base -mergeoutput=$output -ro -lefttitle=parent1 -centertitle=base -righttitle=parent2 -outputtitle=merged -automerge -reviewconflicts -solo merge-tools.bcompare.premerge=False merge-tools.bcompare.gui=True merge-tools.bcompare.priority=-1 merge-tools.bcompare.diffargs=-lro -lefttitle='$plabel1' -righttitle='$clabel' -solo -expandall $parent $child merge-tools.winmerge.args=/e /x /wl /ub /dl other /dr local
Power Pack Reports for Review Board beta sign-up
Hey everyone, We’ll soon be releasing a new beta of Power Pack http://www.reviewboard.org/powerpack/ containing one of our most frequently-requested features: Reporting. Many people on this list have shown interest over the years in gathering useful statistics on how effectively their teams have been making use of code review. We’ve been taking this feedback and using it to plan out the new Reporting feature. We’d like anyone who’s interested to read about our upcoming beta and sign up to receive a copy when it’s ready for testing: http://www.reviewboard.org/news/2014/06/03/powerpack-reports-beta/ The initial beta will contain some built-in reports. We’re looking to bring additional functionality and APIs for creating custom reports, based on the feedback we receive throughout the betas. If you know anyone in your organization who would be especially interested, we'd love to talk to them! Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3384 in reviewboard: Content-Disposition is inline instead of attachment in response to Download Diff
Updates: Status: Fixed Comment #3 on issue 3384 by trowb...@gmail.com: Content-Disposition is inline instead of attachment in response to Download Diff http://code.google.com/p/reviewboard/issues/detail?id=3384 Fixed in release-2.0.x (855d395). Thanks! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3397 in reviewboard: Wrong review request window formatting after upgrading from 1.7.22 to 2.0.1
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3397 by rafal.wo...@gmail.com: Wrong review request window formatting after upgrading from 1.7.22 to 2.0.1 http://code.google.com/p/reviewboard/issues/detail?id=3397 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or your bug report will be rejected. *** *** For customer support, please post to reviewbo...@googlegroups.com *** *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** Do not post confidential information in this bug report! What version are you running? 2.0.1 What's the URL of the page containing the problem? /r/../ What steps will reproduce the problem? 1. Upgrade from 1.7.22 to 2.0.1 with rb-site upgrade command 2. Access any migrated review request on Review Board 3. What is the expected output? What do you see instead? Review request windows formatting is changed with 2.0.0 version. I guess formatting of text boxes inside review request window should be also changed but it is not. Text boxes are too wide (please see attached image). This issue occurs only for migrated requests. Newly created review requests are formatted as it should and look well. What operating system are you using? What browser? Ubuntu 12.04 as RB server. Client browsers: IE 8, Fire Fox, Chromium Browser. Please provide any additional information below. Attachments: review_problem.png 21.9 KB -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3397 in reviewboard: Wrong review request window formatting after upgrading from 1.7.22 to 2.0.1
Updates: Status: NeedInfo Comment #1 on issue 3397 by chip...@gmail.com: Wrong review request window formatting after upgrading from 1.7.22 to 2.0.1 http://code.google.com/p/reviewboard/issues/detail?id=3397 I assume there were some long lines in the content? Having at least a sense of the word boundaries and wrapping of the existing text would help a lot here. Not knowing the text contents makes it difficult to know what went wrong and why. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
